Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-12-11 13:41:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

irqchip: spear_shirq: Simplify chained handler

Browse Source 
I don't know if there are less efficient ways to code that. Get rid of
the loop mess and use efficient code.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Link: https://lkml.kernel.org/r/20140619212713.662897061@linutronix.de
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Jason Cooper <jason@lakedaemon.net>
This commit is contained in:
Thomas Gleixner 2014-06-19 21:34:42 +00:00 committed by Jason Cooper
parent 97dcc21bd3
commit 25dc49e332
1 changed files with 8 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
drivers/irqchip/spear-shirq.c
View File

@ -224,23 +224,20 @@ static void shirq_handler(unsigned irq, struct irq_desc *desc)
struct spear_shirq *shirq = irq_get_handler_data(irq); struct spear_shirq *shirq = irq_get_handler_data(irq);
struct irq_data *idata = irq_desc_get_irq_data(desc); struct irq_data *idata = irq_desc_get_irq_data(desc);
struct irq_chip *chip = irq_data_get_irq_chip(idata); struct irq_chip *chip = irq_data_get_irq_chip(idata);
u32 i, j, val, mask; u32 pend;
chip->irq_ack(idata); chip->irq_ack(idata);
mask = shirq->mask; pend = readl(shirq->base + shirq->regs.status_reg) & shirq->mask;
while ((val = readl(shirq->base + shirq->regs.status_reg) & pend >>= shirq->offset;
mask)) {
val >>= shirq->offset; while (pend) {
for (i = 0, j = 1; i < shirq->nr_irqs; i++, j <<= 1) { int irq = __ffs(pend);
if (!(j & val)) pend &= ~(0x1 << irq);
continue; generic_handle_irq(shirq->virq_base + irq);
generic_handle_irq(shirq->virq_base + i);
}
} }
chip->irq_unmask(idata); chip->irq_unmask(idata);
} }