Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-12-13 22:53:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

fbdev: Remove FBINFO_FLAG_DEFAULT from kzalloc()'ed structs

Browse Source 
The flag FBINFO_FLAG_DEFAULT is 0 and has no effect, as struct
fbinfo.flags has been allocated to zero by kzalloc(). So do not
set it.

Flags should signal differences from the default values. After cleaning
up all occurrences of FBINFO_DEFAULT, the token will be removed.

v4:
	* clarify commit message (Geert, Dan)
v2:
	* fix commit message (Miguel)

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Acked-by: Sam Ravnborg <sam@ravnborg.org>
Cc: Helge Deller <deller@gmx.de>
Link: https://patchwork.freedesktop.org/patch/msgid/20230715185343.7193-14-tzimmermann@suse.de
This commit is contained in:
Thomas Zimmermann 2023-07-15 20:51:55 +02:00
parent cdeb052cdb
commit 252b7b147c
2 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
drivers/video/fbdev/amba-clcd.c
View File

@ -461,7 +461,6 @@ static int clcdfb_register(struct clcd_fb *fb)
} }
fb->fb.fbops = &clcdfb_ops; fb->fb.fbops = &clcdfb_ops;
fb->fb.flags = FBINFO_FLAG_DEFAULT;
fb->fb.pseudo_palette = fb->cmap; fb->fb.pseudo_palette = fb->cmap;
strncpy(fb->fb.fix.id, clcd_name, sizeof(fb->fb.fix.id)); strncpy(fb->fb.fix.id, clcd_name, sizeof(fb->fb.fix.id));

5
drivers/video/fbdev/matrox/matroxfb_crtc2.c
View File

@ -603,9 +603,8 @@ static int matroxfb_dh_regit(const struct matrox_fb_info *minfo,
void* oldcrtc2; void* oldcrtc2;
m2info->fbcon.fbops = &matroxfb_dh_ops; m2info->fbcon.fbops = &matroxfb_dh_ops;
m2info->fbcon.flags = FBINFO_FLAG_DEFAULT; m2info->fbcon.flags = FBINFO_HWACCEL_XPAN |
m2info->fbcon.flags |= FBINFO_HWACCEL_XPAN | FBINFO_HWACCEL_YPAN;
FBINFO_HWACCEL_YPAN;
m2info->fbcon.pseudo_palette = m2info->cmap; m2info->fbcon.pseudo_palette = m2info->cmap;
fb_alloc_cmap(&m2info->fbcon.cmap, 256, 1); fb_alloc_cmap(&m2info->fbcon.cmap, 256, 1);