Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-12-27 13:22:23 +00:00
Code Issues Packages Projects Releases Wiki Activity

clk: sunxi: fix some calculations

Browse Source 
Some divisor calculations were misrounded, causing higher than requested
rates on some clocks. Fix them up using DIV_ROUND_UP, and replace one
homebrew instance of it as well with the right macro.

Reported-by: Boris BREZILLON <b.brezillon.dev@gmail.com>
Signed-off-by: Emilio López <emilio@elopez.com.ar>
Signed-off-by: Mike Turquette <mturquette@linaro.org>
This commit is contained in:
Emilio López 2014-03-19 15:19:32 -03:00 committed by Mike Turquette
parent 5a8ddf2682
commit 2226013972
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/clk/sunxi/clk-sunxi.c
View File

@ -299,7 +299,7 @@ static void sun4i_get_apb1_factors(u32 *freq, u32 parent_rate,
if (parent_rate < *freq) if (parent_rate < *freq)
*freq = parent_rate; *freq = parent_rate;
parent_rate = (parent_rate + (*freq - 1)) / *freq; parent_rate = DIV_ROUND_UP(parent_rate, *freq);
/* Invalid rate! */ /* Invalid rate! */
if (parent_rate > 32) if (parent_rate > 32)
@ -344,7 +344,7 @@ static void sun4i_get_mod0_factors(u32 *freq, u32 parent_rate,
if (*freq > parent_rate) if (*freq > parent_rate)
*freq = parent_rate; *freq = parent_rate;
div = parent_rate / *freq; div = DIV_ROUND_UP(parent_rate, *freq);
if (div < 16) if (div < 16)
calcp = 0; calcp = 0;
@ -385,7 +385,7 @@ static void sun7i_a20_get_out_factors(u32 *freq, u32 parent_rate,
if (*freq > parent_rate) if (*freq > parent_rate)
*freq = parent_rate; *freq = parent_rate;
div = parent_rate / *freq; div = DIV_ROUND_UP(parent_rate, *freq);
if (div < 32) if (div < 32)
calcp = 0; calcp = 0;