Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-12-26 04:42:12 +00:00
Code Issues Packages Projects Releases Wiki Activity

[media] omap3isp: preview: Skip brightness and contrast in configuration ioctl

Browse Source 
Brightness and contrast are handled through V4L2 controls. Their
configuration bit in the preview engine update attributes table is set
to -1 to reflect that. However, the VIDIOC_OMAP3ISP_PRV_CFG ioctl
handler doesn't handle -1 correctly as a configuration bit value, and
erroneously considers that the parameter has been selected for update by
the ioctl caller. Fix this.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Acked-by: Sakari Ailus <sakari.ailus@iki.fi>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
This commit is contained in:
Laurent Pinchart 2012-03-26 08:54:26 -03:00 committed by Mauro Carvalho Chehab
parent ca7f4a3821
commit 213cf90b9a
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/media/video/omap3isp/isppreview.c
View File

@ -903,7 +903,7 @@ static int preview_config(struct isp_prev_device *prev,
attr = &update_attrs[i];
bit = 0;
if (!(cfg->update & attr->cfg_bit))
if (attr->cfg_bit == -1 || !(cfg->update & attr->cfg_bit))
continue;
bit = cfg->flag & attr->cfg_bit;