net/ipv6: compute anycast address hash only if dev is null

avoid to compute the hash value if dev is not null, since
hash value is not used

Signed-off-by: Li RongQing <lirongqing@baidu.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Li RongQing 2018-11-08 14:58:07 +08:00 committed by David S. Miller
parent 0db55093b5
commit 1c51dc9ad6

View File

@ -433,7 +433,6 @@ static bool ipv6_chk_acast_dev(struct net_device *dev, const struct in6_addr *ad
bool ipv6_chk_acast_addr(struct net *net, struct net_device *dev, bool ipv6_chk_acast_addr(struct net *net, struct net_device *dev,
const struct in6_addr *addr) const struct in6_addr *addr)
{ {
unsigned int hash = inet6_acaddr_hash(net, addr);
struct net_device *nh_dev; struct net_device *nh_dev;
struct ifacaddr6 *aca; struct ifacaddr6 *aca;
bool found = false; bool found = false;
@ -441,7 +440,9 @@ bool ipv6_chk_acast_addr(struct net *net, struct net_device *dev,
rcu_read_lock(); rcu_read_lock();
if (dev) if (dev)
found = ipv6_chk_acast_dev(dev, addr); found = ipv6_chk_acast_dev(dev, addr);
else else {
unsigned int hash = inet6_acaddr_hash(net, addr);
hlist_for_each_entry_rcu(aca, &inet6_acaddr_lst[hash], hlist_for_each_entry_rcu(aca, &inet6_acaddr_lst[hash],
aca_addr_lst) { aca_addr_lst) {
nh_dev = fib6_info_nh_dev(aca->aca_rt); nh_dev = fib6_info_nh_dev(aca->aca_rt);
@ -452,6 +453,7 @@ bool ipv6_chk_acast_addr(struct net *net, struct net_device *dev,
break; break;
} }
} }
}
rcu_read_unlock(); rcu_read_unlock();
return found; return found;
} }