mirror of
https://github.com/torvalds/linux.git
synced 2024-11-23 12:42:02 +00:00
sysfs: fix up space coding style issues
This fixes up all of the space-related coding style issues for the sysfs code. Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
parent
ab9bf4be4d
commit
1b18dc2beb
@ -391,7 +391,7 @@ out_unlock:
|
||||
return rc;
|
||||
}
|
||||
|
||||
static int open(struct inode * inode, struct file * file)
|
||||
static int open(struct inode *inode, struct file *file)
|
||||
{
|
||||
struct sysfs_dirent *attr_sd = file->f_path.dentry->d_fsdata;
|
||||
struct bin_attribute *attr = attr_sd->s_bin_attr.bin_attr;
|
||||
@ -435,7 +435,7 @@ static int open(struct inode * inode, struct file * file)
|
||||
return error;
|
||||
}
|
||||
|
||||
static int release(struct inode * inode, struct file * file)
|
||||
static int release(struct inode *inode, struct file *file)
|
||||
{
|
||||
struct bin_buffer *bb = file->private_data;
|
||||
|
||||
|
@ -46,7 +46,7 @@ static unsigned int sysfs_name_hash(const void *ns, const char *name)
|
||||
unsigned int len = strlen(name);
|
||||
while (len--)
|
||||
hash = partial_name_hash(*name++, hash);
|
||||
hash = ( end_name_hash(hash) ^ hash_ptr( (void *)ns, 31 ) );
|
||||
hash = (end_name_hash(hash) ^ hash_ptr((void *)ns, 31));
|
||||
hash &= 0x7fffffffU;
|
||||
/* Reserve hash numbers 0, 1 and INT_MAX for magic directory entries */
|
||||
if (hash < 1)
|
||||
@ -258,7 +258,7 @@ static void sysfs_free_ino(unsigned int ino)
|
||||
spin_unlock(&sysfs_ino_lock);
|
||||
}
|
||||
|
||||
void release_sysfs_dirent(struct sysfs_dirent * sd)
|
||||
void release_sysfs_dirent(struct sysfs_dirent *sd)
|
||||
{
|
||||
struct sysfs_dirent *parent_sd;
|
||||
|
||||
@ -451,7 +451,7 @@ int __sysfs_add_one(struct sysfs_addrm_cxt *acxt, struct sysfs_dirent *sd)
|
||||
|
||||
if (!!sysfs_ns_type(acxt->parent_sd) != !!sd->s_ns) {
|
||||
WARN(1, KERN_WARNING "sysfs: ns %s in '%s' for '%s'\n",
|
||||
sysfs_ns_type(acxt->parent_sd)? "required": "invalid",
|
||||
sysfs_ns_type(acxt->parent_sd) ? "required" : "invalid",
|
||||
acxt->parent_sd->s_name, sd->s_name);
|
||||
return -EINVAL;
|
||||
}
|
||||
@ -619,7 +619,7 @@ struct sysfs_dirent *sysfs_find_dirent(struct sysfs_dirent *parent_sd,
|
||||
|
||||
if (!!sysfs_ns_type(parent_sd) != !!ns) {
|
||||
WARN(1, KERN_WARNING "sysfs: ns %s in '%s' for '%s'\n",
|
||||
sysfs_ns_type(parent_sd)? "required": "invalid",
|
||||
sysfs_ns_type(parent_sd) ? "required" : "invalid",
|
||||
parent_sd->s_name, name);
|
||||
return NULL;
|
||||
}
|
||||
@ -674,7 +674,7 @@ static int create_dir(struct kobject *kobj, struct sysfs_dirent *parent_sd,
|
||||
enum kobj_ns_type type, const void *ns, const char *name,
|
||||
struct sysfs_dirent **p_sd)
|
||||
{
|
||||
umode_t mode = S_IFDIR| S_IRWXU | S_IRUGO | S_IXUGO;
|
||||
umode_t mode = S_IFDIR | S_IRWXU | S_IRUGO | S_IXUGO;
|
||||
struct sysfs_addrm_cxt acxt;
|
||||
struct sysfs_dirent *sd;
|
||||
int rc;
|
||||
@ -737,7 +737,7 @@ static enum kobj_ns_type sysfs_read_ns_type(struct kobject *kobj)
|
||||
* sysfs_create_dir - create a directory for an object.
|
||||
* @kobj: object we're creating directory for.
|
||||
*/
|
||||
int sysfs_create_dir(struct kobject * kobj)
|
||||
int sysfs_create_dir(struct kobject *kobj)
|
||||
{
|
||||
enum kobj_ns_type type;
|
||||
struct sysfs_dirent *parent_sd, *sd;
|
||||
@ -764,8 +764,8 @@ int sysfs_create_dir(struct kobject * kobj)
|
||||
return error;
|
||||
}
|
||||
|
||||
static struct dentry * sysfs_lookup(struct inode *dir, struct dentry *dentry,
|
||||
unsigned int flags)
|
||||
static struct dentry *sysfs_lookup(struct inode *dir, struct dentry *dentry,
|
||||
unsigned int flags)
|
||||
{
|
||||
struct dentry *ret = NULL;
|
||||
struct dentry *parent = dentry->d_parent;
|
||||
@ -857,7 +857,7 @@ static void __sysfs_remove_dir(struct sysfs_dirent *dir_sd)
|
||||
* what used to be sysfs_rmdir() below, instead of calling separately.
|
||||
*/
|
||||
|
||||
void sysfs_remove_dir(struct kobject * kobj)
|
||||
void sysfs_remove_dir(struct kobject *kobj)
|
||||
{
|
||||
struct sysfs_dirent *sd = kobj->sd;
|
||||
|
||||
@ -1001,7 +1001,7 @@ static struct sysfs_dirent *sysfs_dir_next_pos(const void *ns,
|
||||
static int sysfs_readdir(struct file *file, struct dir_context *ctx)
|
||||
{
|
||||
struct dentry *dentry = file->f_path.dentry;
|
||||
struct sysfs_dirent * parent_sd = dentry->d_fsdata;
|
||||
struct sysfs_dirent *parent_sd = dentry->d_fsdata;
|
||||
struct sysfs_dirent *pos = file->private_data;
|
||||
enum kobj_ns_type type;
|
||||
const void *ns;
|
||||
|
@ -45,8 +45,8 @@ struct sysfs_open_dirent {
|
||||
struct sysfs_buffer {
|
||||
size_t count;
|
||||
loff_t pos;
|
||||
char * page;
|
||||
const struct sysfs_ops * ops;
|
||||
char *page;
|
||||
const struct sysfs_ops *ops;
|
||||
struct mutex mutex;
|
||||
int needs_read_fill;
|
||||
int event;
|
||||
@ -64,11 +64,11 @@ struct sysfs_buffer {
|
||||
* This is called only once, on the file's first read unless an error
|
||||
* is returned.
|
||||
*/
|
||||
static int fill_read_buffer(struct dentry * dentry, struct sysfs_buffer * buffer)
|
||||
static int fill_read_buffer(struct dentry *dentry, struct sysfs_buffer *buffer)
|
||||
{
|
||||
struct sysfs_dirent *attr_sd = dentry->d_fsdata;
|
||||
struct kobject *kobj = attr_sd->s_parent->s_dir.kobj;
|
||||
const struct sysfs_ops * ops = buffer->ops;
|
||||
const struct sysfs_ops *ops = buffer->ops;
|
||||
int ret = 0;
|
||||
ssize_t count;
|
||||
|
||||
@ -127,12 +127,12 @@ static int fill_read_buffer(struct dentry * dentry, struct sysfs_buffer * buffer
|
||||
static ssize_t
|
||||
sysfs_read_file(struct file *file, char __user *buf, size_t count, loff_t *ppos)
|
||||
{
|
||||
struct sysfs_buffer * buffer = file->private_data;
|
||||
struct sysfs_buffer *buffer = file->private_data;
|
||||
ssize_t retval = 0;
|
||||
|
||||
mutex_lock(&buffer->mutex);
|
||||
if (buffer->needs_read_fill || *ppos == 0) {
|
||||
retval = fill_read_buffer(file->f_path.dentry,buffer);
|
||||
retval = fill_read_buffer(file->f_path.dentry, buffer);
|
||||
if (retval)
|
||||
goto out;
|
||||
}
|
||||
@ -154,8 +154,8 @@ out:
|
||||
* Allocate @buffer->page if it hasn't been already, then
|
||||
* copy the user-supplied buffer into it.
|
||||
*/
|
||||
static int fill_write_buffer(struct sysfs_buffer * buffer,
|
||||
const char __user * buf, size_t count)
|
||||
static int fill_write_buffer(struct sysfs_buffer *buffer,
|
||||
const char __user *buf, size_t count)
|
||||
{
|
||||
int error;
|
||||
|
||||
@ -166,7 +166,7 @@ static int fill_write_buffer(struct sysfs_buffer * buffer,
|
||||
|
||||
if (count >= PAGE_SIZE)
|
||||
count = PAGE_SIZE - 1;
|
||||
error = copy_from_user(buffer->page,buf,count);
|
||||
error = copy_from_user(buffer->page, buf, count);
|
||||
buffer->needs_read_fill = 1;
|
||||
/* if buf is assumed to contain a string, terminate it by \0,
|
||||
so e.g. sscanf() can scan the string easily */
|
||||
@ -186,11 +186,11 @@ static int fill_write_buffer(struct sysfs_buffer * buffer,
|
||||
* passing the buffer that we acquired in fill_write_buffer().
|
||||
*/
|
||||
static int
|
||||
flush_write_buffer(struct dentry * dentry, struct sysfs_buffer * buffer, size_t count)
|
||||
flush_write_buffer(struct dentry *dentry, struct sysfs_buffer *buffer, size_t count)
|
||||
{
|
||||
struct sysfs_dirent *attr_sd = dentry->d_fsdata;
|
||||
struct kobject *kobj = attr_sd->s_parent->s_dir.kobj;
|
||||
const struct sysfs_ops * ops = buffer->ops;
|
||||
const struct sysfs_ops *ops = buffer->ops;
|
||||
int rc;
|
||||
|
||||
/* need attr_sd for attr and ops, its parent for kobj */
|
||||
@ -225,7 +225,7 @@ flush_write_buffer(struct dentry * dentry, struct sysfs_buffer * buffer, size_t
|
||||
static ssize_t
|
||||
sysfs_write_file(struct file *file, const char __user *buf, size_t count, loff_t *ppos)
|
||||
{
|
||||
struct sysfs_buffer * buffer = file->private_data;
|
||||
struct sysfs_buffer *buffer = file->private_data;
|
||||
ssize_t len;
|
||||
|
||||
mutex_lock(&buffer->mutex);
|
||||
@ -418,7 +418,7 @@ static int sysfs_release(struct inode *inode, struct file *filp)
|
||||
*/
|
||||
static unsigned int sysfs_poll(struct file *filp, poll_table *wait)
|
||||
{
|
||||
struct sysfs_buffer * buffer = filp->private_data;
|
||||
struct sysfs_buffer *buffer = filp->private_data;
|
||||
struct sysfs_dirent *attr_sd = filp->f_path.dentry->d_fsdata;
|
||||
struct sysfs_open_dirent *od = attr_sd->s_attr.open;
|
||||
|
||||
@ -567,7 +567,7 @@ int sysfs_add_file(struct sysfs_dirent *dir_sd, const struct attribute *attr,
|
||||
* @kobj: object we're creating for.
|
||||
* @attr: attribute descriptor.
|
||||
*/
|
||||
int sysfs_create_file(struct kobject * kobj, const struct attribute * attr)
|
||||
int sysfs_create_file(struct kobject *kobj, const struct attribute *attr)
|
||||
{
|
||||
BUG_ON(!kobj || !kobj->sd || !attr);
|
||||
|
||||
@ -660,7 +660,7 @@ EXPORT_SYMBOL_GPL(sysfs_chmod_file);
|
||||
*
|
||||
* Hash the attribute name and kill the victim.
|
||||
*/
|
||||
void sysfs_remove_file(struct kobject * kobj, const struct attribute * attr)
|
||||
void sysfs_remove_file(struct kobject *kobj, const struct attribute *attr)
|
||||
{
|
||||
const void *ns;
|
||||
|
||||
@ -671,7 +671,7 @@ void sysfs_remove_file(struct kobject * kobj, const struct attribute * attr)
|
||||
}
|
||||
EXPORT_SYMBOL_GPL(sysfs_remove_file);
|
||||
|
||||
void sysfs_remove_files(struct kobject * kobj, const struct attribute **ptr)
|
||||
void sysfs_remove_files(struct kobject *kobj, const struct attribute **ptr)
|
||||
{
|
||||
int i;
|
||||
for (i = 0; ptr[i]; i++)
|
||||
|
@ -36,7 +36,7 @@ static struct backing_dev_info sysfs_backing_dev_info = {
|
||||
.capabilities = BDI_CAP_NO_ACCT_AND_WRITEBACK,
|
||||
};
|
||||
|
||||
static const struct inode_operations sysfs_inode_operations ={
|
||||
static const struct inode_operations sysfs_inode_operations = {
|
||||
.permission = sysfs_permission,
|
||||
.setattr = sysfs_setattr,
|
||||
.getattr = sysfs_getattr,
|
||||
@ -67,7 +67,7 @@ static struct sysfs_inode_attrs *sysfs_init_inode_attrs(struct sysfs_dirent *sd)
|
||||
return attrs;
|
||||
}
|
||||
|
||||
int sysfs_sd_setattr(struct sysfs_dirent *sd, struct iattr * iattr)
|
||||
int sysfs_sd_setattr(struct sysfs_dirent *sd, struct iattr *iattr)
|
||||
{
|
||||
struct sysfs_inode_attrs *sd_attrs;
|
||||
struct iattr *iattrs;
|
||||
@ -186,13 +186,13 @@ out:
|
||||
return error;
|
||||
}
|
||||
|
||||
static inline void set_default_inode_attr(struct inode * inode, umode_t mode)
|
||||
static inline void set_default_inode_attr(struct inode *inode, umode_t mode)
|
||||
{
|
||||
inode->i_mode = mode;
|
||||
inode->i_atime = inode->i_mtime = inode->i_ctime = CURRENT_TIME;
|
||||
}
|
||||
|
||||
static inline void set_inode_attr(struct inode * inode, struct iattr * iattr)
|
||||
static inline void set_inode_attr(struct inode *inode, struct iattr *iattr)
|
||||
{
|
||||
inode->i_uid = iattr->ia_uid;
|
||||
inode->i_gid = iattr->ia_gid;
|
||||
@ -285,7 +285,7 @@ static void sysfs_init_inode(struct sysfs_dirent *sd, struct inode *inode)
|
||||
* RETURNS:
|
||||
* Pointer to allocated inode on success, NULL on failure.
|
||||
*/
|
||||
struct inode * sysfs_get_inode(struct super_block *sb, struct sysfs_dirent *sd)
|
||||
struct inode *sysfs_get_inode(struct super_block *sb, struct sysfs_dirent *sd)
|
||||
{
|
||||
struct inode *inode;
|
||||
|
||||
|
@ -64,7 +64,7 @@ static int sysfs_fill_super(struct super_block *sb, void *data, int silent)
|
||||
/* instantiate and link root dentry */
|
||||
root = d_make_root(inode);
|
||||
if (!root) {
|
||||
pr_debug("%s: could not get root dentry!\n",__func__);
|
||||
pr_debug("%s: could not get root dentry!\n", __func__);
|
||||
return -ENOMEM;
|
||||
}
|
||||
root->d_fsdata = &sysfs_root;
|
||||
|
@ -167,7 +167,7 @@ void sysfs_delete_link(struct kobject *kobj, struct kobject *targ,
|
||||
* @kobj: object we're acting for.
|
||||
* @name: name of the symlink to remove.
|
||||
*/
|
||||
void sysfs_remove_link(struct kobject * kobj, const char * name)
|
||||
void sysfs_remove_link(struct kobject *kobj, const char *name)
|
||||
{
|
||||
struct sysfs_dirent *parent_sd = NULL;
|
||||
|
||||
@ -278,7 +278,7 @@ static int sysfs_get_target_path(struct sysfs_dirent *parent_sd,
|
||||
return 0;
|
||||
}
|
||||
|
||||
static int sysfs_getlink(struct dentry *dentry, char * path)
|
||||
static int sysfs_getlink(struct dentry *dentry, char *path)
|
||||
{
|
||||
struct sysfs_dirent *sd = dentry->d_fsdata;
|
||||
struct sysfs_dirent *parent_sd = sd->s_parent;
|
||||
|
Loading…
Reference in New Issue
Block a user