mirror of
https://github.com/torvalds/linux.git
synced 2024-11-27 14:41:39 +00:00
ptp: ocp: Avoid operator precedence warning in ptp_ocp_summary_show()
Clang warns twice:
drivers/ptp/ptp_ocp.c:2065:16: error: operator '?:' has lower precedence
than '&'; '&' will be evaluated first
[-Werror,-Wbitwise-conditional-parentheses]
on & map ? " ON" : "OFF", src);
~~~~~~~~ ^
drivers/ptp/ptp_ocp.c:2065:16: note: place parentheses around the '&'
expression to silence this warning
on & map ? " ON" : "OFF", src);
^
( )
drivers/ptp/ptp_ocp.c:2065:16: note: place parentheses around the '?:'
expression to evaluate it first
on & map ? " ON" : "OFF", src);
^
on and map are both booleans so this should be a logical AND, which
clears up the operator precedence issue.
Fixes: a62a56d04e
("ptp: ocp: Enable 4th timestamper / PPS generator")
Link: https://github.com/ClangBuiltLinux/linux/issues/1457
Suggested-by: Jonathan Lemon <jonathan.lemon@gmail.com>
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Acked-by: Jonathan Lemon <jonathan.lemon@gmail.com>
Link: https://lore.kernel.org/r/20210917045204.1385801-1-nathan@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
This commit is contained in:
parent
5ef8a02915
commit
1a575cde59
@ -2062,11 +2062,11 @@ ptp_ocp_summary_show(struct seq_file *s, void *data)
|
||||
on = ioread32(&ts_reg->enable);
|
||||
map = !!(bp->pps_req_map & OCP_REQ_TIMESTAMP);
|
||||
seq_printf(s, "%7s: %s, src: %s\n", "TS3",
|
||||
on & map ? " ON" : "OFF", src);
|
||||
on && map ? " ON" : "OFF", src);
|
||||
|
||||
map = !!(bp->pps_req_map & OCP_REQ_PPS);
|
||||
seq_printf(s, "%7s: %s, src: %s\n", "PPS",
|
||||
on & map ? " ON" : "OFF", src);
|
||||
on && map ? " ON" : "OFF", src);
|
||||
}
|
||||
|
||||
if (bp->irig_out) {
|
||||
|
Loading…
Reference in New Issue
Block a user