Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-11-27 14:41:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

[DLM] Fix memory leak in dlm_add_member() when dlm_node_weight() returns less than zero

Browse Source 
There's a memory leak in fs/dlm/member.c::dlm_add_member().

If "dlm_node_weight(ls->ls_name, nodeid)" returns < 0, then
we'll return without freeing the memory allocated to the (at
that point yet unused) 'memb'.
This patch frees the allocated memory in that case and thus
avoids the leak.

Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com>
Signed-off-by: David Teigland <teigland@redhat.com>
Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>
This commit is contained in:
Jesper Juhl 2007-07-19 00:27:43 +02:00 committed by Steven Whitehouse
parent 01c8cab258
commit 1a2bf2eefb
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
fs/dlm/member.c
View File

@ -56,8 +56,10 @@ static int dlm_add_member(struct dlm_ls *ls, int nodeid)
return -ENOMEM; return -ENOMEM;
w = dlm_node_weight(ls->ls_name, nodeid); w = dlm_node_weight(ls->ls_name, nodeid);
if (w < 0) if (w < 0) {
kfree(memb);
return w; return w;
}
memb->nodeid = nodeid; memb->nodeid = nodeid;
memb->weight = w; memb->weight = w;