Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-11-22 12:11:40 +00:00
Code Issues Packages Projects Releases Wiki Activity

livepatch: Small shadow variable documentation fixes

Browse Source 
The description of the basic operations was a bit inconsistent
and based on older version of the patchset.

Also the size of the spinlock structure should be allocated
instead of the pointer.

Signed-off-by: Petr Mladek <pmladek@suse.com>
Acked-by: Joe Lawrence <joe.lawrence@redhat.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
This commit is contained in:
Petr Mladek 2017-09-25 17:41:59 +02:00 committed by Jiri Kosina
parent 5d9da759f7
commit 19205da6a0
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Documentation/livepatch/shadow-vars.txt
View File

@ -6,7 +6,7 @@ Shadow variables are a simple way for livepatch modules to associate
additional "shadow" data with existing data structures. Shadow data is additional "shadow" data with existing data structures. Shadow data is
allocated separately from parent data structures, which are left allocated separately from parent data structures, which are left
unmodified. The shadow variable API described in this document is used unmodified. The shadow variable API described in this document is used
to allocate/attach and detach/release shadow variables to their parents. to allocate/add and remove/free shadow variables to/from their parents.
The implementation introduces a global, in-kernel hashtable that The implementation introduces a global, in-kernel hashtable that
associates pointers to parent objects and a numeric identifier of the associates pointers to parent objects and a numeric identifier of the
@ -107,7 +107,7 @@ struct sta_info *sta_info_alloc(struct ieee80211_sub_if_data *sdata,
sta = kzalloc(sizeof(*sta) + hw->sta_data_size, gfp); sta = kzalloc(sizeof(*sta) + hw->sta_data_size, gfp);
/* Attach a corresponding shadow variable, then initialize it */ /* Attach a corresponding shadow variable, then initialize it */
ps_lock = klp_shadow_alloc(sta, PS_LOCK, NULL, sizeof(ps_lock), gfp); ps_lock = klp_shadow_alloc(sta, PS_LOCK, NULL, sizeof(*ps_lock), gfp);
if (!ps_lock) if (!ps_lock)
goto shadow_fail; goto shadow_fail;
spin_lock_init(ps_lock); spin_lock_init(ps_lock);