mirror of
https://github.com/torvalds/linux.git
synced 2024-12-01 00:21:32 +00:00
radeonfb: use display information in info not in var for panning
We must not use any information in the passed var besides xoffset, yoffset and vmode as otherwise applications might abuse it. Also use the aligned fix.line_length and not the (possible) unaligned xres_virtual. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
This commit is contained in:
parent
b3e9c12949
commit
0e03f856d2
@ -845,16 +845,16 @@ static int radeonfb_pan_display (struct fb_var_screeninfo *var,
|
||||
{
|
||||
struct radeonfb_info *rinfo = info->par;
|
||||
|
||||
if ((var->xoffset + var->xres > var->xres_virtual)
|
||||
|| (var->yoffset + var->yres > var->yres_virtual))
|
||||
return -EINVAL;
|
||||
if ((var->xoffset + info->var.xres > info->var.xres_virtual)
|
||||
|| (var->yoffset + info->var.yres > info->var.yres_virtual))
|
||||
return -EINVAL;
|
||||
|
||||
if (rinfo->asleep)
|
||||
return 0;
|
||||
|
||||
radeon_fifo_wait(2);
|
||||
OUTREG(CRTC_OFFSET, ((var->yoffset * var->xres_virtual + var->xoffset)
|
||||
* var->bits_per_pixel / 8) & ~7);
|
||||
OUTREG(CRTC_OFFSET, (var->yoffset * info->fix.line_length +
|
||||
var->xoffset * info->var.bits_per_pixel / 8) & ~7);
|
||||
return 0;
|
||||
}
|
||||
|
||||
|
Loading…
Reference in New Issue
Block a user