Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-12-11 13:41:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

net: bonding: Add support for IPV6 ns/na to balance-alb/balance-tlb mode

Browse Source 
Since ipv6 neighbor solicitation and advertisement messages
isn't handled gracefully in bond6 driver, we can see packet
drop due to inconsistency between mac address in the option
message and source MAC .

Another examples is ipv6 neighbor solicitation and advertisement
messages from VM via tap attached to host bridge, the src mac
might be changed through balance-alb mode, but it is not synced
with Link-layer address in the option message.

The patch implements bond6's tx handle for ipv6 neighbor
solicitation and advertisement messages.

Suggested-by: Hu Yadi <huyd12@chinatelecom.cn>
Acked-by: Jay Vosburgh <jay.vosburgh@canonical.com>
Signed-off-by: Sun Shouxin <sunshouxin@chinatelecom.cn>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Sun Shouxin 2022-01-28 09:44:42 -05:00 committed by David S. Miller
parent 4f0e30407e
commit 0da8aa00bf
1 changed files with 28 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
drivers/net/bonding/bond_alb.c
View File

@ -1269,6 +1269,27 @@ unwind:
return res; return res;
} }
/* determine if the packet is NA or NS */
static bool alb_determine_nd(struct sk_buff *skb, struct bonding *bond)
{
struct ipv6hdr *ip6hdr;
struct icmp6hdr *hdr;
if (!pskb_network_may_pull(skb, sizeof(*ip6hdr)))
return true;
ip6hdr = ipv6_hdr(skb);
if (ip6hdr->nexthdr != IPPROTO_ICMPV6)
return false;
if (!pskb_network_may_pull(skb, sizeof(*ip6hdr) + sizeof(*hdr)))
return true;
hdr = icmp6_hdr(skb);
return hdr->icmp6_type == NDISC_NEIGHBOUR_ADVERTISEMENT ||
hdr->icmp6_type == NDISC_NEIGHBOUR_SOLICITATION;
}
/************************ exported alb functions ************************/ /************************ exported alb functions ************************/
int bond_alb_initialize(struct bonding *bond, int rlb_enabled) int bond_alb_initialize(struct bonding *bond, int rlb_enabled)
@ -1348,8 +1369,11 @@ struct slave *bond_xmit_tlb_slave_get(struct bonding *bond,
/* Do not TX balance any multicast or broadcast */ /* Do not TX balance any multicast or broadcast */
if (!is_multicast_ether_addr(eth_data->h_dest)) { if (!is_multicast_ether_addr(eth_data->h_dest)) {
switch (skb->protocol) { switch (skb->protocol) {
case htons(ETH_P_IP):
case htons(ETH_P_IPV6): case htons(ETH_P_IPV6):
if (alb_determine_nd(skb, bond))
break;
fallthrough;
case htons(ETH_P_IP):
hash_index = bond_xmit_hash(bond, skb); hash_index = bond_xmit_hash(bond, skb);
if (bond->params.tlb_dynamic_lb) { if (bond->params.tlb_dynamic_lb) {
tx_slave = tlb_choose_channel(bond, tx_slave = tlb_choose_channel(bond,
@ -1432,10 +1456,12 @@ struct slave *bond_xmit_alb_slave_get(struct bonding *bond,
break; break;
} }
if (!pskb_network_may_pull(skb, sizeof(*ip6hdr))) { if (alb_determine_nd(skb, bond)) {
do_tx_balance = false; do_tx_balance = false;
break; break;
} }
/* The IPv6 header is pulled by alb_determine_nd */
/* Additionally, DAD probes should not be tx-balanced as that /* Additionally, DAD probes should not be tx-balanced as that
* will lead to false positives for duplicate addresses and * will lead to false positives for duplicate addresses and
* prevent address configuration from working. * prevent address configuration from working.