Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-12-03 01:21:28 +00:00
Code Issues Packages Projects Releases Wiki Activity

iio: magnetometer: mag3110: Simplify with dev_err_probe()

Browse Source 
Common pattern of handling deferred probe can be simplified with
dev_err_probe().  Less code and also it prints the error value.

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Link: https://lore.kernel.org/r/20200829064726.26268-17-krzk@kernel.org
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
This commit is contained in:
Krzysztof Kozlowski 2020-08-29 08:47:25 +02:00 committed by Jonathan Cameron
parent 5d2180ce14
commit 0d81951dad
1 changed files with 6 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
drivers/iio/magnetometer/mag3110.c
View File

@ -476,22 +476,14 @@ static int mag3110_probe(struct i2c_client *client,
data = iio_priv(indio_dev); data = iio_priv(indio_dev);
data->vdd_reg = devm_regulator_get(&client->dev, "vdd"); data->vdd_reg = devm_regulator_get(&client->dev, "vdd");
if (IS_ERR(data->vdd_reg)) { if (IS_ERR(data->vdd_reg))
if (PTR_ERR(data->vdd_reg) == -EPROBE_DEFER) return dev_err_probe(&client->dev, PTR_ERR(data->vdd_reg),
return -EPROBE_DEFER; "failed to get VDD regulator!\n");
dev_err(&client->dev, "failed to get VDD regulator!\n");
return PTR_ERR(data->vdd_reg);
}
data->vddio_reg = devm_regulator_get(&client->dev, "vddio"); data->vddio_reg = devm_regulator_get(&client->dev, "vddio");
if (IS_ERR(data->vddio_reg)) { if (IS_ERR(data->vddio_reg))
if (PTR_ERR(data->vddio_reg) == -EPROBE_DEFER) return dev_err_probe(&client->dev, PTR_ERR(data->vddio_reg),
return -EPROBE_DEFER; "failed to get VDDIO regulator!\n");
dev_err(&client->dev, "failed to get VDDIO regulator!\n");
return PTR_ERR(data->vddio_reg);
}
ret = regulator_enable(data->vdd_reg); ret = regulator_enable(data->vdd_reg);
if (ret) { if (ret) {