Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-11-21 19:41:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

ASoC: codecs: lpass-rx-macro: Keep static regmap_config as const

Browse Source 
The driver has static 'struct regmap_config', which is then customized
depending on device version.  This works fine, because there should not
be two devices in a system simultaneously and even less likely that such
two devices would have different versions, thus different regmap config.
However code is cleaner and more obvious when static data in the driver
is also const - it serves as a template.

Mark the 'struct regmap_config' as const and duplicate it in the probe()
with kmemdup to allow customizing per detected device variant.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Link: https://patch.msgid.link/20240701-b4-qcom-audio-lpass-codec-cleanups-v3-3-6d98d4dd1ef5@linaro.org
Signed-off-by: Mark Brown <broonie@kernel.org>
This commit is contained in:
Krzysztof Kozlowski 2024-07-01 09:39:35 +02:00 committed by Mark Brown
parent ee5e13b2c9
commit 0c02cacf62
No known key found for this signature in database
GPG Key ID: 24D68B725D5487D0
1 changed files with 10 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
sound/soc/codecs/lpass-rx-macro.c
View File

@ -1663,7 +1663,7 @@ static bool rx_is_readable_register(struct device *dev, unsigned int reg)
return rx_is_rw_register(dev, reg);
}
static struct regmap_config rx_regmap_config = {
static const struct regmap_config rx_regmap_config = {
.name = "rx_macro",
.reg_bits = 16,
.val_bits = 32, /* 8 but with 32 bit read/write */
@ -3847,10 +3847,16 @@ static int rx_macro_probe(struct platform_device *pdev)
return -EINVAL;
}
rx_regmap_config.reg_defaults = reg_defaults;
rx_regmap_config.num_reg_defaults = def_count;
struct regmap_config *reg_config __free(kfree) = kmemdup(&rx_regmap_config,
sizeof(*reg_config),
GFP_KERNEL);
if (!reg_config)
return -ENOMEM;
rx->regmap = devm_regmap_init_mmio(dev, base, &rx_regmap_config);
reg_config->reg_defaults = reg_defaults;
reg_config->num_reg_defaults = def_count;
rx->regmap = devm_regmap_init_mmio(dev, base, reg_config);
if (IS_ERR(rx->regmap))
return PTR_ERR(rx->regmap);