Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-12-18 09:02:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

scsi: qedf: Drop unnecessary NULL checks after container_of()

Browse Source 
The result of container_of() operations is never NULL unless the embedded
element is the first element of the structure, which is not the case here.
The NULL checks are therefore unnecessary and misleading. Remove them.

The changes in this patch were made automatically using the following
Coccinelle script.

@@
type t;
identifier v;
statement s;
@@

<+...
(
  t v = container_of(...);
|
  v = container_of(...);
)
  ...
  when != v
- if (\( !v \| v == NULL \) ) s
...+>

Link: https://lore.kernel.org/r/20210510041211.2051325-1-linux@roeck-us.net
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
This commit is contained in:
Guenter Roeck 2021-05-09 21:12:11 -07:00 committed by Martin K. Petersen
parent 998da772fd
commit 09c6538397
2 changed files with 0 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/scsi/qedf/qedf_io.c
View File

@ -23,11 +23,6 @@ static void qedf_cmd_timeout(struct work_struct *work)
struct qedf_ctx *qedf; struct qedf_ctx *qedf;
struct qedf_rport *fcport; struct qedf_rport *fcport;
if (io_req == NULL) {
QEDF_INFO(NULL, QEDF_LOG_IO, "io_req is NULL.\n");
return;
}
fcport = io_req->fcport; fcport = io_req->fcport;
if (io_req->fcport == NULL) { if (io_req->fcport == NULL) {
QEDF_INFO(NULL, QEDF_LOG_IO, "fcport is NULL.\n"); QEDF_INFO(NULL, QEDF_LOG_IO, "fcport is NULL.\n");

4
drivers/scsi/qedf/qedf_main.c
View File

@ -3971,10 +3971,6 @@ void qedf_stag_change_work(struct work_struct *work)
struct qedf_ctx *qedf = struct qedf_ctx *qedf =
container_of(work, struct qedf_ctx, stag_work.work); container_of(work, struct qedf_ctx, stag_work.work);
if (!qedf) {
QEDF_ERR(NULL, "qedf is NULL");
return;
}
QEDF_ERR(&qedf->dbg_ctx, "Performing software context reset.\n"); QEDF_ERR(&qedf->dbg_ctx, "Performing software context reset.\n");
qedf_ctx_soft_reset(qedf->lport); qedf_ctx_soft_reset(qedf->lport);
} }