Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-10-30 00:32:38 +00:00
Code Issues Packages Projects Releases Wiki Activity

bnxt: fix a condition

Browse Source 
This code generates as static checker warning because htons(ETH_P_IPV6)
is always true.  From the context it looks like the && was intended to
be !=.

Fixes: 94758f8de0 ('bnxt_en: Add GRO logic for BCM5731X chips.')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Michael Chan <michael.chan@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Dan Carpenter 2016-07-07 11:23:09 +03:00 committed by David S. Miller
parent 606274c5ab
commit 09a7636a5b
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/net/ethernet/broadcom/bnxt/bnxt.c
View File

@ -997,7 +997,7 @@ static struct sk_buff *bnxt_gro_func_5731x(struct bnxt_tpa_info *tpa_info,
* correct protocol ID, it must be a loopback packet where * correct protocol ID, it must be a loopback packet where
* the offsets are off by 4. * the offsets are off by 4.
*/ */
if (proto != htons(ETH_P_IP) && proto && htons(ETH_P_IPV6)) if (proto != htons(ETH_P_IP) && proto != htons(ETH_P_IPV6))
loopback = true; loopback = true;
} }
if (loopback) { if (loopback) {