Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-11-26 06:02:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

NFS: Fix a potential NULL dereference in nfs_get_client()

Browse Source 
None of the callers are expecting NULL returns from nfs_get_client() so
this code will lead to an Oops.  It's better to return an error
pointer.  I expect that this is dead code so hopefully no one is
affected.

Fixes: 31434f496a ("nfs: check hostname in nfs_get_client")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
This commit is contained in:
Dan Carpenter 2021-06-03 15:37:53 +03:00 committed by Trond Myklebust
parent 476bdb04c5
commit 09226e8303
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
fs/nfs/client.c
View File

@ -406,7 +406,7 @@ struct nfs_client *nfs_get_client(const struct nfs_client_initdata *cl_init)
if (cl_init->hostname == NULL) { if (cl_init->hostname == NULL) {
WARN_ON(1); WARN_ON(1);
return NULL; return ERR_PTR(-EINVAL);
} }
/* see if the client already exists */ /* see if the client already exists */