Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-11-28 07:01:32 +00:00
Code Issues Packages Projects Releases Wiki Activity

dmi: Avoid unaligned memory access in save_mem_devices()

Browse Source 
Firmware is not required to maintain alignment of SMBIOS
entries, so we should take care accessing fields within these
structures. Use "get_unaligned()" to avoid problems.

[ Found on ia64 (which grumbles about unaligned access) ]

Signed-off-by: Tony Luck <tony.luck@intel.com>
Cc: Chen Gong <gong.chen@linux.intel.com>
Link: http://lkml.kernel.org/r/27d82dbff5be1025bf18ab88498632d36c2fcf3c.1383331440.git.tony.luck@intel.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
This commit is contained in:
Luck, Tony 2013-11-01 13:59:52 -07:00 committed by Ingo Molnar
parent d61ec845e2
commit 0841c04d65
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/firmware/dmi_scan.c
View File

@ -8,6 +8,7 @@
#include <linux/bootmem.h> #include <linux/bootmem.h>
#include <linux/random.h> #include <linux/random.h>
#include <asm/dmi.h> #include <asm/dmi.h>
#include <asm/unaligned.h>
/* /*
* DMI stands for "Desktop Management Interface". It is part * DMI stands for "Desktop Management Interface". It is part
@ -347,7 +348,7 @@ static void __init save_mem_devices(const struct dmi_header *dm, void *v)
pr_warn(FW_BUG "Too many DIMM entries in SMBIOS table\n"); pr_warn(FW_BUG "Too many DIMM entries in SMBIOS table\n");
return; return;
} }
dmi_memdev[nr].handle = dm->handle; dmi_memdev[nr].handle = get_unaligned(&dm->handle);
dmi_memdev[nr].device = dmi_string(dm, d[0x10]); dmi_memdev[nr].device = dmi_string(dm, d[0x10]);
dmi_memdev[nr].bank = dmi_string(dm, d[0x11]); dmi_memdev[nr].bank = dmi_string(dm, d[0x11]);
nr++; nr++;