Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-11-28 07:01:32 +00:00
Code Issues Packages Projects Releases Wiki Activity

[SCSI] 3w-xxxx: remove unnecessary local_irq_save/restore for scsi sg copy API

Browse Source 
Since the commit 50bed2e286 (sg: disable
interrupts inside sg_copy_buffer), no need to disable interrupts
before calling scsi_sg_copy_from_buffer. So we can simplify
tw_transfer_internal, which disables interrupts just for
scsi_sg_copy_from_buffer.

Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>\
Acked-by: Adam Radford <linuxraid@amcc.com>
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
This commit is contained in:
FUJITA Tomonori 2008-10-09 11:25:42 +09:00 committed by James Bottomley
parent aa198bf1da
commit 0723d4a806
1 changed files with 1 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
drivers/scsi/3w-xxxx.c
View File

@ -1466,12 +1466,7 @@ static int tw_scsiop_inquiry(TW_Device_Extension *tw_dev, int request_id)
static void tw_transfer_internal(TW_Device_Extension *tw_dev, int request_id, static void tw_transfer_internal(TW_Device_Extension *tw_dev, int request_id,
void *data, unsigned int len) void *data, unsigned int len)
{ {
struct scsi_cmnd *cmd = tw_dev->srb[request_id]; scsi_sg_copy_from_buffer(tw_dev->srb[request_id], data, len);
unsigned long flags;
local_irq_save(flags);
scsi_sg_copy_from_buffer(cmd, data, len);
local_irq_restore(flags);
} }
/* This function is called by the isr to complete an inquiry command */ /* This function is called by the isr to complete an inquiry command */