drm/mipi-dsi: Add mipi_dsi_dcs_set_tear_scanline_multi

mipi_dsi_dcs_set_tear_scanline_multi can heavily benefit from being
converted to a multi style function as it is often called in the context of
similar functions.

Reviewed-by: Douglas Anderson <dianders@chromium.org>
Signed-off-by: Tejas Vipin <tejasvipin76@gmail.com>
Signed-off-by: Douglas Anderson <dianders@chromium.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20240818060816.848784-2-tejasvipin76@gmail.com
This commit is contained in:
Tejas Vipin 2024-08-18 11:38:15 +05:30 committed by Douglas Anderson
parent 1453323eac
commit 051c86afc3
2 changed files with 33 additions and 0 deletions

View File

@ -1339,6 +1339,9 @@ EXPORT_SYMBOL(mipi_dsi_dcs_set_pixel_format);
* @dsi: DSI peripheral device * @dsi: DSI peripheral device
* @scanline: scanline to use as trigger * @scanline: scanline to use as trigger
* *
* This function is deprecated. Use mipi_dsi_dcs_set_tear_scanline_multi()
* instead.
*
* Return: 0 on success or a negative error code on failure * Return: 0 on success or a negative error code on failure
*/ */
int mipi_dsi_dcs_set_tear_scanline(struct mipi_dsi_device *dsi, u16 scanline) int mipi_dsi_dcs_set_tear_scanline(struct mipi_dsi_device *dsi, u16 scanline)
@ -1833,6 +1836,34 @@ void mipi_dsi_dcs_set_page_address_multi(struct mipi_dsi_multi_context *ctx,
} }
EXPORT_SYMBOL(mipi_dsi_dcs_set_page_address_multi); EXPORT_SYMBOL(mipi_dsi_dcs_set_page_address_multi);
/**
* mipi_dsi_dcs_set_tear_scanline_multi() - set the scanline to use as trigger for
* the Tearing Effect output signal of the display module
* @ctx: Context for multiple DSI transactions
* @scanline: scanline to use as trigger
*
* Like mipi_dsi_dcs_set_tear_scanline() but deals with errors in a way that
* makes it convenient to make several calls in a row.
*/
void mipi_dsi_dcs_set_tear_scanline_multi(struct mipi_dsi_multi_context *ctx,
u16 scanline)
{
struct mipi_dsi_device *dsi = ctx->dsi;
struct device *dev = &dsi->dev;
int ret;
if (ctx->accum_err)
return;
ret = mipi_dsi_dcs_set_tear_scanline(dsi, scanline);
if (ret < 0) {
ctx->accum_err = ret;
dev_err(dev, "Failed to set tear scanline: %d\n",
ctx->accum_err);
}
}
EXPORT_SYMBOL(mipi_dsi_dcs_set_tear_scanline_multi);
static int mipi_dsi_drv_probe(struct device *dev) static int mipi_dsi_drv_probe(struct device *dev)
{ {
struct mipi_dsi_driver *drv = to_mipi_dsi_driver(dev->driver); struct mipi_dsi_driver *drv = to_mipi_dsi_driver(dev->driver);

View File

@ -375,6 +375,8 @@ void mipi_dsi_dcs_set_column_address_multi(struct mipi_dsi_multi_context *ctx,
u16 start, u16 end); u16 start, u16 end);
void mipi_dsi_dcs_set_page_address_multi(struct mipi_dsi_multi_context *ctx, void mipi_dsi_dcs_set_page_address_multi(struct mipi_dsi_multi_context *ctx,
u16 start, u16 end); u16 start, u16 end);
void mipi_dsi_dcs_set_tear_scanline_multi(struct mipi_dsi_multi_context *ctx,
u16 scanline);
/** /**
* mipi_dsi_generic_write_seq - transmit data using a generic write packet * mipi_dsi_generic_write_seq - transmit data using a generic write packet