Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-11-23 12:42:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

xfs: fix some memory leaks in log recovery

Browse Source 
Fix a few places where we xlog_alloc_buffer a buffer, hit an error, and
then bail out without freeing the buffer.

Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
This commit is contained in:
Darrick J. Wong 2019-11-14 12:51:34 -08:00
parent f368b29ba9
commit 050552cbe0
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
fs/xfs/xfs_log_recover.c
View File

@ -1342,10 +1342,11 @@ xlog_find_tail(
error = xlog_rseek_logrec_hdr(log, *head_blk, *head_blk, 1, buffer, error = xlog_rseek_logrec_hdr(log, *head_blk, *head_blk, 1, buffer,
&rhead_blk, &rhead, &wrapped); &rhead_blk, &rhead, &wrapped);
if (error < 0) if (error < 0)
return error; goto done;
if (!error) { if (!error) {
xfs_warn(log->l_mp, "%s: couldn't find sync record", __func__); xfs_warn(log->l_mp, "%s: couldn't find sync record", __func__);
return -EFSCORRUPTED; error = -EFSCORRUPTED;
goto done;
} }
*tail_blk = BLOCK_LSN(be64_to_cpu(rhead->h_tail_lsn)); *tail_blk = BLOCK_LSN(be64_to_cpu(rhead->h_tail_lsn));
@ -5300,7 +5301,8 @@ xlog_do_recovery_pass(
} else { } else {
XFS_ERROR_REPORT(__func__, XFS_ERRLEVEL_LOW, XFS_ERROR_REPORT(__func__, XFS_ERRLEVEL_LOW,
log->l_mp); log->l_mp);
return -EFSCORRUPTED; error = -EFSCORRUPTED;
goto bread_err1;
} }
} }