Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-12-04 18:13:04 +00:00
Code Issues Packages Projects Releases Wiki Activity

s390/qeth: don't call INIT_LIST_HEAD() on iob's list entry

Browse Source 
INIT_LIST_HEAD() only needs to be called on actual list heads.
While at it clarify the naming of the field.

Suggested-by: Vasily Gorbik <gor@linux.ibm.com>
Signed-off-by: Julian Wiedmann <jwi@linux.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Julian Wiedmann 2020-12-07 14:12:28 +01:00 committed by David S. Miller
parent af3f4a85d9
commit 04ea30c857
2 changed files with 5 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/s390/net/qeth_core.h
View File

@ -624,7 +624,7 @@ struct qeth_reply {
}; };
struct qeth_cmd_buffer { struct qeth_cmd_buffer {
struct list_head list; struct list_head list_entry;
struct completion done; struct completion done;
spinlock_t lock; spinlock_t lock;
unsigned int length; unsigned int length;

9
drivers/s390/net/qeth_core_main.c
View File

@ -615,7 +615,7 @@ static void qeth_enqueue_cmd(struct qeth_card *card,
struct qeth_cmd_buffer *iob) struct qeth_cmd_buffer *iob)
{ {
spin_lock_irq(&card->lock); spin_lock_irq(&card->lock);
list_add_tail(&iob->list, &card->cmd_waiter_list); list_add_tail(&iob->list_entry, &card->cmd_waiter_list);
spin_unlock_irq(&card->lock); spin_unlock_irq(&card->lock);
} }
@ -623,7 +623,7 @@ static void qeth_dequeue_cmd(struct qeth_card *card,
struct qeth_cmd_buffer *iob) struct qeth_cmd_buffer *iob)
{ {
spin_lock_irq(&card->lock); spin_lock_irq(&card->lock);
list_del(&iob->list); list_del(&iob->list_entry);
spin_unlock_irq(&card->lock); spin_unlock_irq(&card->lock);
} }
@ -977,7 +977,7 @@ static void qeth_clear_ipacmd_list(struct qeth_card *card)
QETH_CARD_TEXT(card, 4, "clipalst"); QETH_CARD_TEXT(card, 4, "clipalst");
spin_lock_irqsave(&card->lock, flags); spin_lock_irqsave(&card->lock, flags);
list_for_each_entry(iob, &card->cmd_waiter_list, list) list_for_each_entry(iob, &card->cmd_waiter_list, list_entry)
qeth_notify_cmd(iob, -ECANCELED); qeth_notify_cmd(iob, -ECANCELED);
spin_unlock_irqrestore(&card->lock, flags); spin_unlock_irqrestore(&card->lock, flags);
} }
@ -1047,7 +1047,6 @@ struct qeth_cmd_buffer *qeth_alloc_cmd(struct qeth_channel *channel,
init_completion(&iob->done); init_completion(&iob->done);
spin_lock_init(&iob->lock); spin_lock_init(&iob->lock);
INIT_LIST_HEAD(&iob->list);
refcount_set(&iob->ref_count, 1); refcount_set(&iob->ref_count, 1);
iob->channel = channel; iob->channel = channel;
iob->timeout = timeout; iob->timeout = timeout;
@ -1094,7 +1093,7 @@ static void qeth_issue_next_read_cb(struct qeth_card *card,
/* match against pending cmd requests */ /* match against pending cmd requests */
spin_lock_irqsave(&card->lock, flags); spin_lock_irqsave(&card->lock, flags);
list_for_each_entry(tmp, &card->cmd_waiter_list, list) { list_for_each_entry(tmp, &card->cmd_waiter_list, list_entry) {
if (tmp->match && tmp->match(tmp, iob)) { if (tmp->match && tmp->match(tmp, iob)) {
request = tmp; request = tmp;
/* take the object outside the lock */ /* take the object outside the lock */