mirror of
https://github.com/torvalds/linux.git
synced 2024-11-23 12:42:02 +00:00
xfs: fix misspelled S_IS...()
mode_t is not a bitmap... Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
This commit is contained in:
parent
abbede1b3a
commit
03209378b4
@ -265,7 +265,7 @@ xfs_open_by_handle(
|
||||
return PTR_ERR(filp);
|
||||
}
|
||||
|
||||
if (inode->i_mode & S_IFREG) {
|
||||
if (S_ISREG(inode->i_mode)) {
|
||||
filp->f_flags |= O_NOATIME;
|
||||
filp->f_mode |= FMODE_NOCMTIME;
|
||||
}
|
||||
|
@ -345,8 +345,8 @@ _xfs_filestream_update_ag(
|
||||
* directory and pip is NULL.
|
||||
*/
|
||||
ASSERT(ip && ((S_ISREG(ip->i_d.di_mode) && pip &&
|
||||
(pip->i_d.di_mode & S_IFDIR)) ||
|
||||
((ip->i_d.di_mode & S_IFDIR) && !pip)));
|
||||
S_ISDIR(pip->i_d.di_mode)) ||
|
||||
(S_ISDIR(ip->i_d.di_mode) && !pip)));
|
||||
|
||||
mp = ip->i_mount;
|
||||
cache = mp->m_filestream;
|
||||
@ -537,7 +537,7 @@ xfs_filestream_lookup_ag(
|
||||
xfs_agnumber_t ag;
|
||||
int ref;
|
||||
|
||||
if (!(ip->i_d.di_mode & (S_IFREG | S_IFDIR))) {
|
||||
if (!S_ISREG(ip->i_d.di_mode) && !S_ISDIR(ip->i_d.di_mode)) {
|
||||
ASSERT(0);
|
||||
return NULLAGNUMBER;
|
||||
}
|
||||
@ -579,9 +579,9 @@ xfs_filestream_associate(
|
||||
xfs_agnumber_t ag, rotorstep, startag;
|
||||
int err = 0;
|
||||
|
||||
ASSERT(pip->i_d.di_mode & S_IFDIR);
|
||||
ASSERT(ip->i_d.di_mode & S_IFREG);
|
||||
if (!(pip->i_d.di_mode & S_IFDIR) || !(ip->i_d.di_mode & S_IFREG))
|
||||
ASSERT(S_ISDIR(pip->i_d.di_mode));
|
||||
ASSERT(S_ISREG(ip->i_d.di_mode));
|
||||
if (!S_ISDIR(pip->i_d.di_mode) || !S_ISREG(ip->i_d.di_mode))
|
||||
return -EINVAL;
|
||||
|
||||
mp = pip->i_mount;
|
||||
|
Loading…
Reference in New Issue
Block a user