Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-12-13 06:32:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

net_sched: fix errno in tcindex_set_parms()

Browse Source 
When kmemdup() fails, we should return -ENOMEM.

Cc: John Fastabend <john.fastabend@gmail.com>
Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
Acked-by: John Fastabend <john.r.fastabend@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
WANG Cong 2014-09-25 12:06:04 -07:00 committed by David S. Miller
parent c01035f174
commit 02c5e84413
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
net/sched/cls_tcindex.c
View File

@ -237,15 +237,14 @@ tcindex_set_parms(struct net *net, struct tcf_proto *tp, unsigned long base,
if (err < 0) if (err < 0)
return err; return err;
err = -ENOMEM;
/* tcindex_data attributes must look atomic to classifier/lookup so /* tcindex_data attributes must look atomic to classifier/lookup so
* allocate new tcindex data and RCU assign it onto root. Keeping * allocate new tcindex data and RCU assign it onto root. Keeping
* perfect hash and hash pointers from old data. * perfect hash and hash pointers from old data.
*/ */
cp = kzalloc(sizeof(*cp), GFP_KERNEL); cp = kzalloc(sizeof(*cp), GFP_KERNEL);
if (!cp) { if (!cp)
err = -ENOMEM;
goto errout; goto errout;
}
cp->mask = p->mask; cp->mask = p->mask;
cp->shift = p->shift; cp->shift = p->shift;