Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-11-22 12:11:40 +00:00
Code Issues Packages Projects Releases Wiki Activity

iio: imu: adis_trigger: Allow level interrupts for FIFO readings

Browse Source 
Currently, adis library allows configuration only for edge interrupts,
needed for data ready sampling.
This patch removes the restriction for level interrupts for devices
which have FIFO support.
Furthermore, in case of devices which have FIFO support,
devm_request_threaded_irq is used for interrupt allocation, to avoid
flooding the processor with the FIFO watermark level interrupt, which
is active until enough data has been read from the FIFO.

Reviewed-by: Nuno Sa <nuno.sa@analog.com>
Signed-off-by: Ramona Gradinariu <ramona.bolboaca13@gmail.com>
Link: https://lore.kernel.org/r/20240527142618.275897-7-ramona.bolboaca13@gmail.com
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
This commit is contained in:
Ramona Gradinariu 2024-05-27 17:26:15 +03:00 committed by Jonathan Cameron
parent f5657c7751
commit 01724ce2d9
2 changed files with 27 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

37
drivers/iio/imu/adis_trigger.c
View File

@ -34,17 +34,24 @@ static int adis_validate_irq_flag(struct adis *adis)
if (adis->data->unmasked_drdy) if (adis->data->unmasked_drdy)
adis->irq_flag |= IRQF_NO_AUTOEN; adis->irq_flag |= IRQF_NO_AUTOEN;
/* /*
* Typically this devices have data ready either on the rising edge or * Typically adis devices without FIFO have data ready either on the
* on the falling edge of the data ready pin. This checks enforces that * rising edge or on the falling edge of the data ready pin.
* one of those is set in the drivers... It defaults to * IMU devices with FIFO support have the watermark pin level driven
* IRQF_TRIGGER_RISING for backward compatibility with devices that * either high or low when the FIFO is filled with the desired number
* don't support changing the pin polarity. * of samples.
* It defaults to IRQF_TRIGGER_RISING for backward compatibility with
* devices that don't support changing the pin polarity.
*/ */
if (direction == IRQF_TRIGGER_NONE) { if (direction == IRQF_TRIGGER_NONE) {
adis->irq_flag |= IRQF_TRIGGER_RISING; adis->irq_flag |= IRQF_TRIGGER_RISING;
return 0; return 0;
} else if (direction != IRQF_TRIGGER_RISING && } else if (direction != IRQF_TRIGGER_RISING &&
direction != IRQF_TRIGGER_FALLING) { direction != IRQF_TRIGGER_FALLING && !adis->data->has_fifo) {
dev_err(&adis->spi->dev, "Invalid IRQ mask: %08lx\n",
adis->irq_flag);
return -EINVAL;
} else if (direction != IRQF_TRIGGER_HIGH &&
direction != IRQF_TRIGGER_LOW && adis->data->has_fifo) {
dev_err(&adis->spi->dev, "Invalid IRQ mask: %08lx\n", dev_err(&adis->spi->dev, "Invalid IRQ mask: %08lx\n",
adis->irq_flag); adis->irq_flag);
return -EINVAL; return -EINVAL;
@ -77,11 +84,19 @@ int devm_adis_probe_trigger(struct adis *adis, struct iio_dev *indio_dev)
if (ret) if (ret)
return ret; return ret;
ret = devm_request_irq(&adis->spi->dev, adis->spi->irq, if (adis->data->has_fifo)
&iio_trigger_generic_data_rdy_poll, ret = devm_request_threaded_irq(&adis->spi->dev, adis->spi->irq,
adis->irq_flag, NULL,
indio_dev->name, &iio_trigger_generic_data_rdy_poll,
adis->trig); adis->irq_flag | IRQF_ONESHOT,
indio_dev->name,
adis->trig);
else
ret = devm_request_irq(&adis->spi->dev, adis->spi->irq,
&iio_trigger_generic_data_rdy_poll,
adis->irq_flag,
indio_dev->name,
adis->trig);
if (ret) if (ret)
return ret; return ret;

1
include/linux/iio/imu/adis.h
View File

@ -85,6 +85,7 @@ struct adis_data {
bool unmasked_drdy; bool unmasked_drdy;
bool has_paging; bool has_paging;
bool has_fifo;
unsigned int burst_reg_cmd; unsigned int burst_reg_cmd;
unsigned int burst_len; unsigned int burst_len;