Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-11-01 01:31:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

pwm: renesas-tpu: fix return value check in tpu_probe()

Browse Source 
In case of error, the function devm_ioremap_resource() returns ERR_PTR()
and never returns NULL. The NULL test in the return value check should
be replaced with IS_ERR().

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Reviewed-by: Axel Lin <axel.lin@ingics.com>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
This commit is contained in:
Wei Yongjun 2013-06-25 10:09:57 +08:00 committed by Thierry Reding
parent 99b82abb0a
commit 00cf99ee00
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/pwm/pwm-renesas-tpu.c
View File

@ -410,10 +410,8 @@ static int tpu_probe(struct platform_device *pdev)
} }
tpu->base = devm_ioremap_resource(&pdev->dev, res); tpu->base = devm_ioremap_resource(&pdev->dev, res);
if (tpu->base == NULL) { if (IS_ERR(tpu->base))
dev_err(&pdev->dev, "failed to remap I/O memory\n"); return PTR_ERR(tpu->base);
return -ENXIO;
}
tpu->clk = devm_clk_get(&pdev->dev, NULL); tpu->clk = devm_clk_get(&pdev->dev, NULL);
if (IS_ERR(tpu->clk)) { if (IS_ERR(tpu->clk)) {