2022-05-26 02:36:47 +00:00
|
|
|
// SPDX-License-Identifier: GPL-2.0
|
|
|
|
#include <linux/kernel.h>
|
|
|
|
#include <linux/errno.h>
|
|
|
|
#include <linux/fs.h>
|
|
|
|
#include <linux/file.h>
|
|
|
|
#include <linux/mm.h>
|
|
|
|
#include <linux/slab.h>
|
|
|
|
#include <linux/namei.h>
|
io_uring: add sync cancelation API through io_uring_register()
The io_uring cancelation API is async, like any other API that we expose
there. For the case of finding a request to cancel, or not finding one,
it is fully sync in that when submission returns, the CQE for both the
cancelation request and the targeted request have been posted to the
CQ ring.
However, if the targeted work is being executed by io-wq, the API can
only start the act of canceling it. This makes it difficult to use in
some circumstances, as the caller then has to wait for the CQEs to come
in and match on the same cancelation data there.
Provide a IORING_REGISTER_SYNC_CANCEL command for io_uring_register()
that does sync cancelations, always. For the io-wq case, it'll wait
for the cancelation to come in before returning. The only expected
returns from this API is:
0 Request found and canceled fine.
> 0 Requests found and canceled. Only happens if asked to
cancel multiple requests, and if the work wasn't in
progress.
-ENOENT Request not found.
-ETIME A timeout on the operation was requested, but the timeout
expired before we could cancel.
and we won't get -EALREADY via this API.
If the timeout value passed in is -1 (tv_sec and tv_nsec), then that
means that no timeout is requested. Otherwise, the timespec passed in
is the amount of time the sync cancel will wait for a successful
cancelation.
Link: https://github.com/axboe/liburing/discussions/608
Signed-off-by: Jens Axboe <axboe@kernel.dk>
2022-06-18 16:00:50 +00:00
|
|
|
#include <linux/nospec.h>
|
2022-05-26 02:36:47 +00:00
|
|
|
#include <linux/io_uring.h>
|
|
|
|
|
|
|
|
#include <uapi/linux/io_uring.h>
|
|
|
|
|
|
|
|
#include "io_uring.h"
|
|
|
|
#include "tctx.h"
|
|
|
|
#include "poll.h"
|
|
|
|
#include "timeout.h"
|
|
|
|
#include "cancel.h"
|
|
|
|
|
|
|
|
struct io_cancel {
|
|
|
|
struct file *file;
|
|
|
|
u64 addr;
|
|
|
|
u32 flags;
|
|
|
|
s32 fd;
|
|
|
|
};
|
|
|
|
|
|
|
|
#define CANCEL_FLAGS (IORING_ASYNC_CANCEL_ALL | IORING_ASYNC_CANCEL_FD | \
|
2022-06-18 15:47:04 +00:00
|
|
|
IORING_ASYNC_CANCEL_ANY | IORING_ASYNC_CANCEL_FD_FIXED)
|
2022-05-26 02:36:47 +00:00
|
|
|
|
|
|
|
static bool io_cancel_cb(struct io_wq_work *work, void *data)
|
|
|
|
{
|
|
|
|
struct io_kiocb *req = container_of(work, struct io_kiocb, work);
|
|
|
|
struct io_cancel_data *cd = data;
|
|
|
|
|
|
|
|
if (req->ctx != cd->ctx)
|
|
|
|
return false;
|
|
|
|
if (cd->flags & IORING_ASYNC_CANCEL_ANY) {
|
|
|
|
;
|
|
|
|
} else if (cd->flags & IORING_ASYNC_CANCEL_FD) {
|
|
|
|
if (req->file != cd->file)
|
|
|
|
return false;
|
|
|
|
} else {
|
|
|
|
if (req->cqe.user_data != cd->data)
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
if (cd->flags & (IORING_ASYNC_CANCEL_ALL|IORING_ASYNC_CANCEL_ANY)) {
|
|
|
|
if (cd->seq == req->work.cancel_seq)
|
|
|
|
return false;
|
|
|
|
req->work.cancel_seq = cd->seq;
|
|
|
|
}
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int io_async_cancel_one(struct io_uring_task *tctx,
|
|
|
|
struct io_cancel_data *cd)
|
|
|
|
{
|
|
|
|
enum io_wq_cancel cancel_ret;
|
|
|
|
int ret = 0;
|
|
|
|
bool all;
|
|
|
|
|
|
|
|
if (!tctx || !tctx->io_wq)
|
|
|
|
return -ENOENT;
|
|
|
|
|
|
|
|
all = cd->flags & (IORING_ASYNC_CANCEL_ALL|IORING_ASYNC_CANCEL_ANY);
|
|
|
|
cancel_ret = io_wq_cancel_cb(tctx->io_wq, io_cancel_cb, cd, all);
|
|
|
|
switch (cancel_ret) {
|
|
|
|
case IO_WQ_CANCEL_OK:
|
|
|
|
ret = 0;
|
|
|
|
break;
|
|
|
|
case IO_WQ_CANCEL_RUNNING:
|
|
|
|
ret = -EALREADY;
|
|
|
|
break;
|
|
|
|
case IO_WQ_CANCEL_NOTFOUND:
|
|
|
|
ret = -ENOENT;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
2022-06-18 15:23:54 +00:00
|
|
|
int io_try_cancel(struct io_uring_task *tctx, struct io_cancel_data *cd,
|
2022-06-16 09:22:11 +00:00
|
|
|
unsigned issue_flags)
|
2022-05-26 02:36:47 +00:00
|
|
|
{
|
2022-06-18 15:23:54 +00:00
|
|
|
struct io_ring_ctx *ctx = cd->ctx;
|
2022-05-26 02:36:47 +00:00
|
|
|
int ret;
|
|
|
|
|
2022-06-18 15:23:54 +00:00
|
|
|
WARN_ON_ONCE(!io_wq_current_is_worker() && tctx != current->io_uring);
|
2022-05-26 02:36:47 +00:00
|
|
|
|
2022-06-18 15:23:54 +00:00
|
|
|
ret = io_async_cancel_one(tctx, cd);
|
2022-05-26 02:36:47 +00:00
|
|
|
/*
|
|
|
|
* Fall-through even for -EALREADY, as we may have poll armed
|
|
|
|
* that need unarming.
|
|
|
|
*/
|
|
|
|
if (!ret)
|
|
|
|
return 0;
|
|
|
|
|
2022-06-16 09:22:11 +00:00
|
|
|
ret = io_poll_cancel(ctx, cd, issue_flags);
|
2022-05-26 02:36:47 +00:00
|
|
|
if (ret != -ENOENT)
|
2022-06-16 09:22:04 +00:00
|
|
|
return ret;
|
|
|
|
|
2022-06-16 09:22:02 +00:00
|
|
|
spin_lock(&ctx->completion_lock);
|
2022-05-26 02:36:47 +00:00
|
|
|
if (!(cd->flags & IORING_ASYNC_CANCEL_FD))
|
|
|
|
ret = io_timeout_cancel(ctx, cd);
|
|
|
|
spin_unlock(&ctx->completion_lock);
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
int io_async_cancel_prep(struct io_kiocb *req, const struct io_uring_sqe *sqe)
|
|
|
|
{
|
2022-08-11 07:11:15 +00:00
|
|
|
struct io_cancel *cancel = io_kiocb_to_cmd(req, struct io_cancel);
|
2022-05-26 02:36:47 +00:00
|
|
|
|
|
|
|
if (unlikely(req->flags & REQ_F_BUFFER_SELECT))
|
|
|
|
return -EINVAL;
|
|
|
|
if (sqe->off || sqe->len || sqe->splice_fd_in)
|
|
|
|
return -EINVAL;
|
|
|
|
|
|
|
|
cancel->addr = READ_ONCE(sqe->addr);
|
|
|
|
cancel->flags = READ_ONCE(sqe->cancel_flags);
|
|
|
|
if (cancel->flags & ~CANCEL_FLAGS)
|
|
|
|
return -EINVAL;
|
|
|
|
if (cancel->flags & IORING_ASYNC_CANCEL_FD) {
|
|
|
|
if (cancel->flags & IORING_ASYNC_CANCEL_ANY)
|
|
|
|
return -EINVAL;
|
|
|
|
cancel->fd = READ_ONCE(sqe->fd);
|
|
|
|
}
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2022-06-18 15:23:54 +00:00
|
|
|
static int __io_async_cancel(struct io_cancel_data *cd,
|
|
|
|
struct io_uring_task *tctx,
|
2022-05-26 02:36:47 +00:00
|
|
|
unsigned int issue_flags)
|
|
|
|
{
|
|
|
|
bool all = cd->flags & (IORING_ASYNC_CANCEL_ALL|IORING_ASYNC_CANCEL_ANY);
|
|
|
|
struct io_ring_ctx *ctx = cd->ctx;
|
|
|
|
struct io_tctx_node *node;
|
|
|
|
int ret, nr = 0;
|
|
|
|
|
|
|
|
do {
|
2022-06-18 15:23:54 +00:00
|
|
|
ret = io_try_cancel(tctx, cd, issue_flags);
|
2022-05-26 02:36:47 +00:00
|
|
|
if (ret == -ENOENT)
|
|
|
|
break;
|
|
|
|
if (!all)
|
|
|
|
return ret;
|
|
|
|
nr++;
|
|
|
|
} while (1);
|
|
|
|
|
|
|
|
/* slow path, try all io-wq's */
|
|
|
|
io_ring_submit_lock(ctx, issue_flags);
|
|
|
|
ret = -ENOENT;
|
|
|
|
list_for_each_entry(node, &ctx->tctx_list, ctx_node) {
|
|
|
|
struct io_uring_task *tctx = node->task->io_uring;
|
|
|
|
|
|
|
|
ret = io_async_cancel_one(tctx, cd);
|
|
|
|
if (ret != -ENOENT) {
|
|
|
|
if (!all)
|
|
|
|
break;
|
|
|
|
nr++;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
io_ring_submit_unlock(ctx, issue_flags);
|
|
|
|
return all ? nr : ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
int io_async_cancel(struct io_kiocb *req, unsigned int issue_flags)
|
|
|
|
{
|
2022-08-11 07:11:15 +00:00
|
|
|
struct io_cancel *cancel = io_kiocb_to_cmd(req, struct io_cancel);
|
2022-05-26 02:36:47 +00:00
|
|
|
struct io_cancel_data cd = {
|
|
|
|
.ctx = req->ctx,
|
|
|
|
.data = cancel->addr,
|
|
|
|
.flags = cancel->flags,
|
|
|
|
.seq = atomic_inc_return(&req->ctx->cancel_seq),
|
|
|
|
};
|
2022-06-18 15:23:54 +00:00
|
|
|
struct io_uring_task *tctx = req->task->io_uring;
|
2022-05-26 02:36:47 +00:00
|
|
|
int ret;
|
|
|
|
|
|
|
|
if (cd.flags & IORING_ASYNC_CANCEL_FD) {
|
2022-06-18 15:47:04 +00:00
|
|
|
if (req->flags & REQ_F_FIXED_FILE ||
|
|
|
|
cd.flags & IORING_ASYNC_CANCEL_FD_FIXED) {
|
|
|
|
req->flags |= REQ_F_FIXED_FILE;
|
2022-05-26 02:36:47 +00:00
|
|
|
req->file = io_file_get_fixed(req, cancel->fd,
|
|
|
|
issue_flags);
|
2022-06-18 15:47:04 +00:00
|
|
|
} else {
|
2022-05-26 02:36:47 +00:00
|
|
|
req->file = io_file_get_normal(req, cancel->fd);
|
2022-06-18 15:47:04 +00:00
|
|
|
}
|
2022-05-26 02:36:47 +00:00
|
|
|
if (!req->file) {
|
|
|
|
ret = -EBADF;
|
|
|
|
goto done;
|
|
|
|
}
|
|
|
|
cd.file = req->file;
|
|
|
|
}
|
|
|
|
|
2022-06-18 15:23:54 +00:00
|
|
|
ret = __io_async_cancel(&cd, tctx, issue_flags);
|
2022-05-26 02:36:47 +00:00
|
|
|
done:
|
|
|
|
if (ret < 0)
|
|
|
|
req_set_fail(req);
|
|
|
|
io_req_set_res(req, ret, 0);
|
|
|
|
return IOU_OK;
|
|
|
|
}
|
2022-06-16 09:22:02 +00:00
|
|
|
|
2022-06-16 09:22:10 +00:00
|
|
|
void init_hash_table(struct io_hash_table *table, unsigned size)
|
2022-06-16 09:22:02 +00:00
|
|
|
{
|
|
|
|
unsigned int i;
|
|
|
|
|
|
|
|
for (i = 0; i < size; i++) {
|
2022-06-16 09:22:10 +00:00
|
|
|
spin_lock_init(&table->hbs[i].lock);
|
|
|
|
INIT_HLIST_HEAD(&table->hbs[i].list);
|
2022-06-16 09:22:02 +00:00
|
|
|
}
|
|
|
|
}
|
io_uring: add sync cancelation API through io_uring_register()
The io_uring cancelation API is async, like any other API that we expose
there. For the case of finding a request to cancel, or not finding one,
it is fully sync in that when submission returns, the CQE for both the
cancelation request and the targeted request have been posted to the
CQ ring.
However, if the targeted work is being executed by io-wq, the API can
only start the act of canceling it. This makes it difficult to use in
some circumstances, as the caller then has to wait for the CQEs to come
in and match on the same cancelation data there.
Provide a IORING_REGISTER_SYNC_CANCEL command for io_uring_register()
that does sync cancelations, always. For the io-wq case, it'll wait
for the cancelation to come in before returning. The only expected
returns from this API is:
0 Request found and canceled fine.
> 0 Requests found and canceled. Only happens if asked to
cancel multiple requests, and if the work wasn't in
progress.
-ENOENT Request not found.
-ETIME A timeout on the operation was requested, but the timeout
expired before we could cancel.
and we won't get -EALREADY via this API.
If the timeout value passed in is -1 (tv_sec and tv_nsec), then that
means that no timeout is requested. Otherwise, the timespec passed in
is the amount of time the sync cancel will wait for a successful
cancelation.
Link: https://github.com/axboe/liburing/discussions/608
Signed-off-by: Jens Axboe <axboe@kernel.dk>
2022-06-18 16:00:50 +00:00
|
|
|
|
|
|
|
static int __io_sync_cancel(struct io_uring_task *tctx,
|
|
|
|
struct io_cancel_data *cd, int fd)
|
|
|
|
{
|
|
|
|
struct io_ring_ctx *ctx = cd->ctx;
|
|
|
|
|
|
|
|
/* fixed must be grabbed every time since we drop the uring_lock */
|
|
|
|
if ((cd->flags & IORING_ASYNC_CANCEL_FD) &&
|
|
|
|
(cd->flags & IORING_ASYNC_CANCEL_FD_FIXED)) {
|
2022-08-23 13:26:08 +00:00
|
|
|
if (unlikely(fd >= ctx->nr_user_files))
|
io_uring: add sync cancelation API through io_uring_register()
The io_uring cancelation API is async, like any other API that we expose
there. For the case of finding a request to cancel, or not finding one,
it is fully sync in that when submission returns, the CQE for both the
cancelation request and the targeted request have been posted to the
CQ ring.
However, if the targeted work is being executed by io-wq, the API can
only start the act of canceling it. This makes it difficult to use in
some circumstances, as the caller then has to wait for the CQEs to come
in and match on the same cancelation data there.
Provide a IORING_REGISTER_SYNC_CANCEL command for io_uring_register()
that does sync cancelations, always. For the io-wq case, it'll wait
for the cancelation to come in before returning. The only expected
returns from this API is:
0 Request found and canceled fine.
> 0 Requests found and canceled. Only happens if asked to
cancel multiple requests, and if the work wasn't in
progress.
-ENOENT Request not found.
-ETIME A timeout on the operation was requested, but the timeout
expired before we could cancel.
and we won't get -EALREADY via this API.
If the timeout value passed in is -1 (tv_sec and tv_nsec), then that
means that no timeout is requested. Otherwise, the timespec passed in
is the amount of time the sync cancel will wait for a successful
cancelation.
Link: https://github.com/axboe/liburing/discussions/608
Signed-off-by: Jens Axboe <axboe@kernel.dk>
2022-06-18 16:00:50 +00:00
|
|
|
return -EBADF;
|
|
|
|
fd = array_index_nospec(fd, ctx->nr_user_files);
|
2023-06-20 11:32:33 +00:00
|
|
|
cd->file = io_file_from_index(&ctx->file_table, fd);
|
io_uring: add sync cancelation API through io_uring_register()
The io_uring cancelation API is async, like any other API that we expose
there. For the case of finding a request to cancel, or not finding one,
it is fully sync in that when submission returns, the CQE for both the
cancelation request and the targeted request have been posted to the
CQ ring.
However, if the targeted work is being executed by io-wq, the API can
only start the act of canceling it. This makes it difficult to use in
some circumstances, as the caller then has to wait for the CQEs to come
in and match on the same cancelation data there.
Provide a IORING_REGISTER_SYNC_CANCEL command for io_uring_register()
that does sync cancelations, always. For the io-wq case, it'll wait
for the cancelation to come in before returning. The only expected
returns from this API is:
0 Request found and canceled fine.
> 0 Requests found and canceled. Only happens if asked to
cancel multiple requests, and if the work wasn't in
progress.
-ENOENT Request not found.
-ETIME A timeout on the operation was requested, but the timeout
expired before we could cancel.
and we won't get -EALREADY via this API.
If the timeout value passed in is -1 (tv_sec and tv_nsec), then that
means that no timeout is requested. Otherwise, the timespec passed in
is the amount of time the sync cancel will wait for a successful
cancelation.
Link: https://github.com/axboe/liburing/discussions/608
Signed-off-by: Jens Axboe <axboe@kernel.dk>
2022-06-18 16:00:50 +00:00
|
|
|
if (!cd->file)
|
|
|
|
return -EBADF;
|
|
|
|
}
|
|
|
|
|
|
|
|
return __io_async_cancel(cd, tctx, 0);
|
|
|
|
}
|
|
|
|
|
|
|
|
int io_sync_cancel(struct io_ring_ctx *ctx, void __user *arg)
|
|
|
|
__must_hold(&ctx->uring_lock)
|
|
|
|
{
|
|
|
|
struct io_cancel_data cd = {
|
|
|
|
.ctx = ctx,
|
|
|
|
.seq = atomic_inc_return(&ctx->cancel_seq),
|
|
|
|
};
|
|
|
|
ktime_t timeout = KTIME_MAX;
|
|
|
|
struct io_uring_sync_cancel_reg sc;
|
|
|
|
struct fd f = { };
|
|
|
|
DEFINE_WAIT(wait);
|
|
|
|
int ret;
|
|
|
|
|
|
|
|
if (copy_from_user(&sc, arg, sizeof(sc)))
|
|
|
|
return -EFAULT;
|
|
|
|
if (sc.flags & ~CANCEL_FLAGS)
|
|
|
|
return -EINVAL;
|
|
|
|
if (sc.pad[0] || sc.pad[1] || sc.pad[2] || sc.pad[3])
|
|
|
|
return -EINVAL;
|
|
|
|
|
|
|
|
cd.data = sc.addr;
|
|
|
|
cd.flags = sc.flags;
|
|
|
|
|
|
|
|
/* we can grab a normal file descriptor upfront */
|
|
|
|
if ((cd.flags & IORING_ASYNC_CANCEL_FD) &&
|
|
|
|
!(cd.flags & IORING_ASYNC_CANCEL_FD_FIXED)) {
|
|
|
|
f = fdget(sc.fd);
|
|
|
|
if (!f.file)
|
|
|
|
return -EBADF;
|
|
|
|
cd.file = f.file;
|
|
|
|
}
|
|
|
|
|
|
|
|
ret = __io_sync_cancel(current->io_uring, &cd, sc.fd);
|
|
|
|
|
|
|
|
/* found something, done! */
|
|
|
|
if (ret != -EALREADY)
|
|
|
|
goto out;
|
|
|
|
|
|
|
|
if (sc.timeout.tv_sec != -1UL || sc.timeout.tv_nsec != -1UL) {
|
|
|
|
struct timespec64 ts = {
|
|
|
|
.tv_sec = sc.timeout.tv_sec,
|
|
|
|
.tv_nsec = sc.timeout.tv_nsec
|
|
|
|
};
|
|
|
|
|
|
|
|
timeout = ktime_add_ns(timespec64_to_ktime(ts), ktime_get_ns());
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Keep looking until we get -ENOENT. we'll get woken everytime
|
|
|
|
* every time a request completes and will retry the cancelation.
|
|
|
|
*/
|
|
|
|
do {
|
|
|
|
cd.seq = atomic_inc_return(&ctx->cancel_seq);
|
|
|
|
|
|
|
|
prepare_to_wait(&ctx->cq_wait, &wait, TASK_INTERRUPTIBLE);
|
|
|
|
|
|
|
|
ret = __io_sync_cancel(current->io_uring, &cd, sc.fd);
|
|
|
|
|
2022-12-21 14:11:33 +00:00
|
|
|
mutex_unlock(&ctx->uring_lock);
|
io_uring: add sync cancelation API through io_uring_register()
The io_uring cancelation API is async, like any other API that we expose
there. For the case of finding a request to cancel, or not finding one,
it is fully sync in that when submission returns, the CQE for both the
cancelation request and the targeted request have been posted to the
CQ ring.
However, if the targeted work is being executed by io-wq, the API can
only start the act of canceling it. This makes it difficult to use in
some circumstances, as the caller then has to wait for the CQEs to come
in and match on the same cancelation data there.
Provide a IORING_REGISTER_SYNC_CANCEL command for io_uring_register()
that does sync cancelations, always. For the io-wq case, it'll wait
for the cancelation to come in before returning. The only expected
returns from this API is:
0 Request found and canceled fine.
> 0 Requests found and canceled. Only happens if asked to
cancel multiple requests, and if the work wasn't in
progress.
-ENOENT Request not found.
-ETIME A timeout on the operation was requested, but the timeout
expired before we could cancel.
and we won't get -EALREADY via this API.
If the timeout value passed in is -1 (tv_sec and tv_nsec), then that
means that no timeout is requested. Otherwise, the timespec passed in
is the amount of time the sync cancel will wait for a successful
cancelation.
Link: https://github.com/axboe/liburing/discussions/608
Signed-off-by: Jens Axboe <axboe@kernel.dk>
2022-06-18 16:00:50 +00:00
|
|
|
if (ret != -EALREADY)
|
|
|
|
break;
|
|
|
|
|
2022-08-30 12:50:10 +00:00
|
|
|
ret = io_run_task_work_sig(ctx);
|
2022-12-21 14:11:33 +00:00
|
|
|
if (ret < 0)
|
io_uring: add sync cancelation API through io_uring_register()
The io_uring cancelation API is async, like any other API that we expose
there. For the case of finding a request to cancel, or not finding one,
it is fully sync in that when submission returns, the CQE for both the
cancelation request and the targeted request have been posted to the
CQ ring.
However, if the targeted work is being executed by io-wq, the API can
only start the act of canceling it. This makes it difficult to use in
some circumstances, as the caller then has to wait for the CQEs to come
in and match on the same cancelation data there.
Provide a IORING_REGISTER_SYNC_CANCEL command for io_uring_register()
that does sync cancelations, always. For the io-wq case, it'll wait
for the cancelation to come in before returning. The only expected
returns from this API is:
0 Request found and canceled fine.
> 0 Requests found and canceled. Only happens if asked to
cancel multiple requests, and if the work wasn't in
progress.
-ENOENT Request not found.
-ETIME A timeout on the operation was requested, but the timeout
expired before we could cancel.
and we won't get -EALREADY via this API.
If the timeout value passed in is -1 (tv_sec and tv_nsec), then that
means that no timeout is requested. Otherwise, the timespec passed in
is the amount of time the sync cancel will wait for a successful
cancelation.
Link: https://github.com/axboe/liburing/discussions/608
Signed-off-by: Jens Axboe <axboe@kernel.dk>
2022-06-18 16:00:50 +00:00
|
|
|
break;
|
|
|
|
ret = schedule_hrtimeout(&timeout, HRTIMER_MODE_ABS);
|
|
|
|
if (!ret) {
|
|
|
|
ret = -ETIME;
|
|
|
|
break;
|
|
|
|
}
|
2022-12-21 14:11:33 +00:00
|
|
|
mutex_lock(&ctx->uring_lock);
|
io_uring: add sync cancelation API through io_uring_register()
The io_uring cancelation API is async, like any other API that we expose
there. For the case of finding a request to cancel, or not finding one,
it is fully sync in that when submission returns, the CQE for both the
cancelation request and the targeted request have been posted to the
CQ ring.
However, if the targeted work is being executed by io-wq, the API can
only start the act of canceling it. This makes it difficult to use in
some circumstances, as the caller then has to wait for the CQEs to come
in and match on the same cancelation data there.
Provide a IORING_REGISTER_SYNC_CANCEL command for io_uring_register()
that does sync cancelations, always. For the io-wq case, it'll wait
for the cancelation to come in before returning. The only expected
returns from this API is:
0 Request found and canceled fine.
> 0 Requests found and canceled. Only happens if asked to
cancel multiple requests, and if the work wasn't in
progress.
-ENOENT Request not found.
-ETIME A timeout on the operation was requested, but the timeout
expired before we could cancel.
and we won't get -EALREADY via this API.
If the timeout value passed in is -1 (tv_sec and tv_nsec), then that
means that no timeout is requested. Otherwise, the timespec passed in
is the amount of time the sync cancel will wait for a successful
cancelation.
Link: https://github.com/axboe/liburing/discussions/608
Signed-off-by: Jens Axboe <axboe@kernel.dk>
2022-06-18 16:00:50 +00:00
|
|
|
} while (1);
|
|
|
|
|
|
|
|
finish_wait(&ctx->cq_wait, &wait);
|
2022-12-21 14:11:33 +00:00
|
|
|
mutex_lock(&ctx->uring_lock);
|
io_uring: add sync cancelation API through io_uring_register()
The io_uring cancelation API is async, like any other API that we expose
there. For the case of finding a request to cancel, or not finding one,
it is fully sync in that when submission returns, the CQE for both the
cancelation request and the targeted request have been posted to the
CQ ring.
However, if the targeted work is being executed by io-wq, the API can
only start the act of canceling it. This makes it difficult to use in
some circumstances, as the caller then has to wait for the CQEs to come
in and match on the same cancelation data there.
Provide a IORING_REGISTER_SYNC_CANCEL command for io_uring_register()
that does sync cancelations, always. For the io-wq case, it'll wait
for the cancelation to come in before returning. The only expected
returns from this API is:
0 Request found and canceled fine.
> 0 Requests found and canceled. Only happens if asked to
cancel multiple requests, and if the work wasn't in
progress.
-ENOENT Request not found.
-ETIME A timeout on the operation was requested, but the timeout
expired before we could cancel.
and we won't get -EALREADY via this API.
If the timeout value passed in is -1 (tv_sec and tv_nsec), then that
means that no timeout is requested. Otherwise, the timespec passed in
is the amount of time the sync cancel will wait for a successful
cancelation.
Link: https://github.com/axboe/liburing/discussions/608
Signed-off-by: Jens Axboe <axboe@kernel.dk>
2022-06-18 16:00:50 +00:00
|
|
|
|
|
|
|
if (ret == -ENOENT || ret > 0)
|
|
|
|
ret = 0;
|
|
|
|
out:
|
|
|
|
fdput(f);
|
|
|
|
return ret;
|
|
|
|
}
|