License cleanup: add SPDX GPL-2.0 license identifier to files with no license
Many source files in the tree are missing licensing information, which
makes it harder for compliance tools to determine the correct license.
By default all files without license information are under the default
license of the kernel, which is GPL version 2.
Update the files which contain no license information with the 'GPL-2.0'
SPDX license identifier. The SPDX identifier is a legally binding
shorthand, which can be used instead of the full boiler plate text.
This patch is based on work done by Thomas Gleixner and Kate Stewart and
Philippe Ombredanne.
How this work was done:
Patches were generated and checked against linux-4.14-rc6 for a subset of
the use cases:
- file had no licensing information it it.
- file was a */uapi/* one with no licensing information in it,
- file was a */uapi/* one with existing licensing information,
Further patches will be generated in subsequent months to fix up cases
where non-standard license headers were used, and references to license
had to be inferred by heuristics based on keywords.
The analysis to determine which SPDX License Identifier to be applied to
a file was done in a spreadsheet of side by side results from of the
output of two independent scanners (ScanCode & Windriver) producing SPDX
tag:value files created by Philippe Ombredanne. Philippe prepared the
base worksheet, and did an initial spot review of a few 1000 files.
The 4.13 kernel was the starting point of the analysis with 60,537 files
assessed. Kate Stewart did a file by file comparison of the scanner
results in the spreadsheet to determine which SPDX license identifier(s)
to be applied to the file. She confirmed any determination that was not
immediately clear with lawyers working with the Linux Foundation.
Criteria used to select files for SPDX license identifier tagging was:
- Files considered eligible had to be source code files.
- Make and config files were included as candidates if they contained >5
lines of source
- File already had some variant of a license header in it (even if <5
lines).
All documentation files were explicitly excluded.
The following heuristics were used to determine which SPDX license
identifiers to apply.
- when both scanners couldn't find any license traces, file was
considered to have no license information in it, and the top level
COPYING file license applied.
For non */uapi/* files that summary was:
SPDX license identifier # files
---------------------------------------------------|-------
GPL-2.0 11139
and resulted in the first patch in this series.
If that file was a */uapi/* path one, it was "GPL-2.0 WITH
Linux-syscall-note" otherwise it was "GPL-2.0". Results of that was:
SPDX license identifier # files
---------------------------------------------------|-------
GPL-2.0 WITH Linux-syscall-note 930
and resulted in the second patch in this series.
- if a file had some form of licensing information in it, and was one
of the */uapi/* ones, it was denoted with the Linux-syscall-note if
any GPL family license was found in the file or had no licensing in
it (per prior point). Results summary:
SPDX license identifier # files
---------------------------------------------------|------
GPL-2.0 WITH Linux-syscall-note 270
GPL-2.0+ WITH Linux-syscall-note 169
((GPL-2.0 WITH Linux-syscall-note) OR BSD-2-Clause) 21
((GPL-2.0 WITH Linux-syscall-note) OR BSD-3-Clause) 17
LGPL-2.1+ WITH Linux-syscall-note 15
GPL-1.0+ WITH Linux-syscall-note 14
((GPL-2.0+ WITH Linux-syscall-note) OR BSD-3-Clause) 5
LGPL-2.0+ WITH Linux-syscall-note 4
LGPL-2.1 WITH Linux-syscall-note 3
((GPL-2.0 WITH Linux-syscall-note) OR MIT) 3
((GPL-2.0 WITH Linux-syscall-note) AND MIT) 1
and that resulted in the third patch in this series.
- when the two scanners agreed on the detected license(s), that became
the concluded license(s).
- when there was disagreement between the two scanners (one detected a
license but the other didn't, or they both detected different
licenses) a manual inspection of the file occurred.
- In most cases a manual inspection of the information in the file
resulted in a clear resolution of the license that should apply (and
which scanner probably needed to revisit its heuristics).
- When it was not immediately clear, the license identifier was
confirmed with lawyers working with the Linux Foundation.
- If there was any question as to the appropriate license identifier,
the file was flagged for further research and to be revisited later
in time.
In total, over 70 hours of logged manual review was done on the
spreadsheet to determine the SPDX license identifiers to apply to the
source files by Kate, Philippe, Thomas and, in some cases, confirmation
by lawyers working with the Linux Foundation.
Kate also obtained a third independent scan of the 4.13 code base from
FOSSology, and compared selected files where the other two scanners
disagreed against that SPDX file, to see if there was new insights. The
Windriver scanner is based on an older version of FOSSology in part, so
they are related.
Thomas did random spot checks in about 500 files from the spreadsheets
for the uapi headers and agreed with SPDX license identifier in the
files he inspected. For the non-uapi files Thomas did random spot checks
in about 15000 files.
In initial set of patches against 4.14-rc6, 3 files were found to have
copy/paste license identifier errors, and have been fixed to reflect the
correct identifier.
Additionally Philippe spent 10 hours this week doing a detailed manual
inspection and review of the 12,461 patched files from the initial patch
version early this week with:
- a full scancode scan run, collecting the matched texts, detected
license ids and scores
- reviewing anything where there was a license detected (about 500+
files) to ensure that the applied SPDX license was correct
- reviewing anything where there was no detection but the patch license
was not GPL-2.0 WITH Linux-syscall-note to ensure that the applied
SPDX license was correct
This produced a worksheet with 20 files needing minor correction. This
worksheet was then exported into 3 different .csv files for the
different types of files to be modified.
These .csv files were then reviewed by Greg. Thomas wrote a script to
parse the csv files and add the proper SPDX tag to the file, in the
format that the file expected. This script was further refined by Greg
based on the output to detect more types of files automatically and to
distinguish between header and source .c files (which need different
comment types.) Finally Greg ran the script using the .csv files to
generate the patches.
Reviewed-by: Kate Stewart <kstewart@linuxfoundation.org>
Reviewed-by: Philippe Ombredanne <pombredanne@nexb.com>
Reviewed-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2017-11-01 14:07:57 +00:00
|
|
|
# SPDX-License-Identifier: GPL-2.0
|
2005-04-16 22:20:36 +00:00
|
|
|
# ===========================================================================
|
|
|
|
|
# Module versions
|
|
|
|
|
# ===========================================================================
|
|
|
|
|
#
|
|
|
|
|
# Stage one of module building created the following:
|
|
|
|
|
# a) The individual .o files used for the module
|
2006-03-24 17:23:14 +00:00
|
|
|
# b) A <module>.o file which is the .o files above linked together
|
kbuild: create *.mod with full directory path and remove MODVERDIR
While descending directories, Kbuild produces objects for modules,
but do not link final *.ko files; it is done in the modpost.
To keep track of modules, Kbuild creates a *.mod file in $(MODVERDIR)
for every module it is building. Some post-processing steps read the
necessary information from *.mod files. This avoids descending into
directories again. This mechanism was introduced in 2003 or so.
Later, commit 551559e13af1 ("kbuild: implement modules.order") added
modules.order. So, we can simply read it out to know all the modules
with directory paths. This is easier than parsing the first line of
*.mod files.
$(MODVERDIR) has a flat directory structure, that is, *.mod files
are named only with base names. This is based on the assumption that
the module name is unique across the tree. This assumption is really
fragile.
Stephen Rothwell reported a race condition caused by a module name
conflict:
https://lkml.org/lkml/2019/5/13/991
In parallel building, two different threads could write to the same
$(MODVERDIR)/*.mod simultaneously.
Non-unique module names are the source of all kind of troubles, hence
commit 3a48a91901c5 ("kbuild: check uniqueness of module names")
introduced a new checker script.
However, it is still fragile in the build system point of view because
this race happens before scripts/modules-check.sh is invoked. If it
happens again, the modpost will emit unclear error messages.
To fix this issue completely, create *.mod with full directory path
so that two threads never attempt to write to the same file.
$(MODVERDIR) is no longer needed.
Since modules with directory paths are listed in modules.order, Kbuild
is still able to find *.mod files without additional descending.
I also killed cmd_secanalysis; scripts/mod/sumversion.c computes MD4 hash
for modules with MODULE_VERSION(). When CONFIG_DEBUG_SECTION_MISMATCH=y,
it occurs not only in the modpost stage, but also during directory
descending, where sumversion.c may parse stale *.mod files. It would emit
'No such file or directory' warning when an object consisting a module is
renamed, or when a single-obj module is turned into a multi-obj module or
vice versa.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Acked-by: Nicolas Pitre <nico@fluxnic.net>
2019-07-17 06:17:57 +00:00
|
|
|
# c) A <module>.mod file, listing the name of the preliminary <module>.o file,
|
|
|
|
|
# plus all .o files
|
2019-07-17 06:17:55 +00:00
|
|
|
# d) modules.order, which lists all the modules
|
2005-04-16 22:20:36 +00:00
|
|
|
|
|
|
|
|
# Stage 2 is handled by this file and does the following
|
2019-07-17 06:17:55 +00:00
|
|
|
# 1) Find all modules listed in modules.order
|
2005-04-16 22:20:36 +00:00
|
|
|
# 2) modpost is then used to
|
|
|
|
|
# 3) create one <module>.mod.c file pr. module
|
|
|
|
|
# 4) create one Module.symvers file with CRC for all exported symbols
|
|
|
|
|
|
|
|
|
|
# Step 3 is used to place certain information in the module's ELF
|
|
|
|
|
# section, including information such as:
|
2011-05-25 09:09:59 +00:00
|
|
|
# Version magic (see include/linux/vermagic.h for full details)
|
2005-04-16 22:20:36 +00:00
|
|
|
# - Kernel release
|
|
|
|
|
# - SMP is CONFIG_SMP
|
2019-07-28 18:27:41 +00:00
|
|
|
# - PREEMPT is CONFIG_PREEMPT[_RT]
|
2005-04-16 22:20:36 +00:00
|
|
|
# - GCC Version
|
|
|
|
|
# Module info
|
|
|
|
|
# - Module version (MODULE_VERSION)
|
|
|
|
|
# - Module alias'es (MODULE_ALIAS)
|
|
|
|
|
# - Module license (MODULE_LICENSE)
|
|
|
|
|
# - See include/linux/module.h for more details
|
|
|
|
|
|
|
|
|
|
# Step 4 is solely used to allow module versioning in external modules,
|
2010-07-30 18:43:20 +00:00
|
|
|
# where the CRC of each module is retrieved from the Module.symvers file.
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2006-10-01 09:35:24 +00:00
|
|
|
# KBUILD_MODPOST_WARN can be set to avoid error out in case of undefined
|
|
|
|
|
# symbols in the final module linking stage
|
|
|
|
|
# KBUILD_MODPOST_NOFINAL can be set to skip the final link of modules.
|
2011-03-31 01:57:33 +00:00
|
|
|
# This is solely useful to speed up test compiles
|
2019-07-30 15:59:02 +00:00
|
|
|
|
|
|
|
|
PHONY := __modpost
|
|
|
|
|
__modpost:
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2006-06-09 05:12:39 +00:00
|
|
|
include include/config/auto.conf
|
2005-07-25 20:10:36 +00:00
|
|
|
include scripts/Kbuild.include
|
2008-02-28 08:40:58 +00:00
|
|
|
|
2020-03-06 16:02:06 +00:00
|
|
|
MODPOST = scripts/mod/modpost \
|
|
|
|
|
$(if $(CONFIG_MODVERSIONS),-m) \
|
|
|
|
|
$(if $(CONFIG_MODULE_SRCVERSION_ALL),-a) \
|
|
|
|
|
$(if $(CONFIG_SECTION_MISMATCH_WARN_ONLY),,-E) \
|
2020-06-01 05:57:09 +00:00
|
|
|
$(if $(KBUILD_MODPOST_WARN),-w) \
|
|
|
|
|
-o $@
|
2019-07-30 15:59:02 +00:00
|
|
|
|
|
|
|
|
ifdef MODPOST_VMLINUX
|
|
|
|
|
|
2020-06-01 05:57:09 +00:00
|
|
|
quiet_cmd_modpost = MODPOST $@
|
|
|
|
|
cmd_modpost = $(MODPOST) $<
|
2019-07-30 15:59:02 +00:00
|
|
|
|
modpost: generate vmlinux.symvers and reuse it for the second modpost
The full build runs modpost twice, first for vmlinux.o and second for
modules.
The first pass dumps all the vmlinux symbols into Module.symvers, but
the second pass parses vmlinux again instead of reusing the dump file,
presumably because it needs to avoid accumulating stale symbols.
Loading symbol info from a dump file is faster than parsing an ELF object.
Besides, modpost deals with various issues to parse vmlinux in the second
pass.
A solution is to make the first pass dumps symbols into a separate file,
vmlinux.symvers. The second pass reads it, and parses module .o files.
The merged symbol information is dumped into Module.symvers in the same
way as before.
This makes further modpost cleanups possible.
Also, it fixes the problem of 'make vmlinux', which previously overwrote
Module.symvers, throwing away module symbols.
I slightly touched scripts/link-vmlinux.sh so that vmlinux is re-linked
when you cross this commit. Otherwise, vmlinux.symvers would not be
generated.
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
2020-06-01 05:57:11 +00:00
|
|
|
vmlinux.symvers: vmlinux.o
|
2019-07-30 15:59:02 +00:00
|
|
|
$(call cmd,modpost)
|
|
|
|
|
|
modpost: generate vmlinux.symvers and reuse it for the second modpost
The full build runs modpost twice, first for vmlinux.o and second for
modules.
The first pass dumps all the vmlinux symbols into Module.symvers, but
the second pass parses vmlinux again instead of reusing the dump file,
presumably because it needs to avoid accumulating stale symbols.
Loading symbol info from a dump file is faster than parsing an ELF object.
Besides, modpost deals with various issues to parse vmlinux in the second
pass.
A solution is to make the first pass dumps symbols into a separate file,
vmlinux.symvers. The second pass reads it, and parses module .o files.
The merged symbol information is dumped into Module.symvers in the same
way as before.
This makes further modpost cleanups possible.
Also, it fixes the problem of 'make vmlinux', which previously overwrote
Module.symvers, throwing away module symbols.
I slightly touched scripts/link-vmlinux.sh so that vmlinux is re-linked
when you cross this commit. Otherwise, vmlinux.symvers would not be
generated.
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
2020-06-01 05:57:11 +00:00
|
|
|
__modpost: vmlinux.symvers
|
2020-06-01 05:57:09 +00:00
|
|
|
|
2019-07-30 15:59:02 +00:00
|
|
|
else
|
|
|
|
|
|
2019-10-03 10:29:13 +00:00
|
|
|
ifeq ($(KBUILD_EXTMOD),)
|
modpost: generate vmlinux.symvers and reuse it for the second modpost
The full build runs modpost twice, first for vmlinux.o and second for
modules.
The first pass dumps all the vmlinux symbols into Module.symvers, but
the second pass parses vmlinux again instead of reusing the dump file,
presumably because it needs to avoid accumulating stale symbols.
Loading symbol info from a dump file is faster than parsing an ELF object.
Besides, modpost deals with various issues to parse vmlinux in the second
pass.
A solution is to make the first pass dumps symbols into a separate file,
vmlinux.symvers. The second pass reads it, and parses module .o files.
The merged symbol information is dumped into Module.symvers in the same
way as before.
This makes further modpost cleanups possible.
Also, it fixes the problem of 'make vmlinux', which previously overwrote
Module.symvers, throwing away module symbols.
I slightly touched scripts/link-vmlinux.sh so that vmlinux is re-linked
when you cross this commit. Otherwise, vmlinux.symvers would not be
generated.
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
2020-06-01 05:57:11 +00:00
|
|
|
|
|
|
|
|
input-symdump := vmlinux.symvers
|
2020-06-01 05:57:09 +00:00
|
|
|
output-symdump := Module.symvers
|
|
|
|
|
|
2019-10-03 10:29:13 +00:00
|
|
|
else
|
2008-05-31 20:28:40 +00:00
|
|
|
|
2019-11-06 14:52:15 +00:00
|
|
|
# set src + obj - they may be used in the modules's Makefile
|
2008-05-31 20:28:40 +00:00
|
|
|
obj := $(KBUILD_EXTMOD)
|
|
|
|
|
src := $(obj)
|
|
|
|
|
|
2008-02-28 08:40:58 +00:00
|
|
|
# Include the module's Makefile to find KBUILD_EXTRA_SYMBOLS
|
|
|
|
|
include $(if $(wildcard $(KBUILD_EXTMOD)/Kbuild), \
|
|
|
|
|
$(KBUILD_EXTMOD)/Kbuild, $(KBUILD_EXTMOD)/Makefile)
|
2020-06-01 05:57:08 +00:00
|
|
|
|
|
|
|
|
# modpost option for external modules
|
|
|
|
|
MODPOST += -e
|
|
|
|
|
|
2020-06-01 05:57:10 +00:00
|
|
|
input-symdump := Module.symvers $(KBUILD_EXTRA_SYMBOLS)
|
2020-06-01 05:57:09 +00:00
|
|
|
output-symdump := $(KBUILD_EXTMOD)/Module.symvers
|
|
|
|
|
|
2008-02-28 08:40:58 +00:00
|
|
|
endif
|
|
|
|
|
|
2020-06-01 05:57:03 +00:00
|
|
|
# modpost options for modules (both in-kernel and external)
|
|
|
|
|
MODPOST += \
|
2020-06-01 05:57:12 +00:00
|
|
|
$(addprefix -i ,$(wildcard $(input-symdump))) \
|
2020-06-01 05:57:23 +00:00
|
|
|
$(if $(KBUILD_NSDEPS),-d $(MODULES_NSDEPS)) \
|
2020-06-01 05:57:03 +00:00
|
|
|
$(if $(CONFIG_MODULE_ALLOW_MISSING_NAMESPACE_IMPORTS)$(KBUILD_NSDEPS),-N)
|
|
|
|
|
|
modpost: fix -i (--ignore-errors) MAKEFLAGS detection
$(filter -i,$(MAKEFLAGS)) works only in limited use-cases.
The representation of $(MAKEFLAGS) depends on various factors:
- GNU Make version (version 3.8x or version 4.x)
- The presence of other flags like -j
In my experiments, $(MAKEFLAGS) is expanded as follows:
* GNU Make 3.8x:
* without -j option:
--no-print-directory -Rri
* with -j option:
--no-print-directory -Rr --jobserver-fds=3,4 -j -i
* GNU Make 4.x:
* without -j option:
irR --no-print-directory
* with -j option:
irR -j --jobserver-fds=3,4 --no-print-directory
For GNU Make 4.x, the flags are grouped as 'irR', which does not work.
For the single thread build with GNU Make 3.8x, the flags are grouped
as '-Rri', which does not work either.
To make it work for all cases, do likewise as commit 6f0fa58e4596
("kbuild: simplify silent build (-s) detection").
BTW, since commit ff9b45c55b26 ("kbuild: modpost: read modules.order
instead of $(MODVERDIR)/*.mod"), you also need to pass -k option to
build final *.ko files. 'make -i -k' ignores compile errors in modules,
and build as many remaining *.ko as possible.
Please note this feature is kind of dangerous if other modules depend
on the broken module because the generated modules will lack the correct
module dependency or CRC. Honestly, I am not a big fan of it, but I am
keeping this feature.
Fixes: eed380f3f593 ("modpost: Optionally ignore secondary errors seen if a single module build fails")
Cc: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
2020-06-01 05:57:01 +00:00
|
|
|
# 'make -i -k' ignores compile errors, and builds as many modules as possible.
|
|
|
|
|
ifneq ($(findstring i,$(filter-out --%,$(MAKEFLAGS))),)
|
|
|
|
|
MODPOST += -n
|
|
|
|
|
endif
|
|
|
|
|
|
2020-06-01 05:57:14 +00:00
|
|
|
# Clear VPATH to not search for *.symvers in $(srctree). Check only $(objtree).
|
|
|
|
|
VPATH :=
|
2020-06-01 05:57:12 +00:00
|
|
|
$(input-symdump):
|
2020-06-01 05:57:14 +00:00
|
|
|
@echo >&2 'WARNING: Symbol version dump "$@" is missing.'
|
|
|
|
|
@echo >&2 ' Modules may not have dependencies or modversions.'
|
2020-06-01 05:57:12 +00:00
|
|
|
|
2020-06-01 05:57:09 +00:00
|
|
|
# Read out modules.order to pass in modpost.
|
2019-08-14 16:06:23 +00:00
|
|
|
# Otherwise, allmodconfig would fail with "Argument list too long".
|
2020-06-01 05:57:09 +00:00
|
|
|
quiet_cmd_modpost = MODPOST $@
|
2020-06-01 05:57:12 +00:00
|
|
|
cmd_modpost = sed 's/ko$$/o/' $< | $(MODPOST) -T -
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2020-06-01 05:57:12 +00:00
|
|
|
$(output-symdump): $(MODORDER) $(input-symdump) FORCE
|
|
|
|
|
$(call if_changed,modpost)
|
|
|
|
|
|
|
|
|
|
targets += $(output-symdump)
|
2020-06-01 05:57:09 +00:00
|
|
|
|
|
|
|
|
__modpost: $(output-symdump)
|
2019-08-14 16:06:23 +00:00
|
|
|
ifneq ($(KBUILD_MODPOST_NOFINAL),1)
|
|
|
|
|
$(Q)$(MAKE) -f $(srctree)/scripts/Makefile.modfinal
|
|
|
|
|
endif
|
2006-03-05 22:14:10 +00:00
|
|
|
|
2020-06-01 05:57:09 +00:00
|
|
|
PHONY += FORCE
|
|
|
|
|
FORCE:
|
|
|
|
|
|
2020-06-01 05:57:12 +00:00
|
|
|
existing-targets := $(wildcard $(sort $(targets)))
|
|
|
|
|
|
|
|
|
|
-include $(foreach f,$(existing-targets),$(dir $(f)).$(notdir $(f)).cmd)
|
|
|
|
|
|
2019-07-30 15:59:02 +00:00
|
|
|
endif
|
|
|
|
|
|
2006-03-05 22:14:10 +00:00
|
|
|
.PHONY: $(PHONY)
|
