2008-03-03 17:12:54 +00:00
|
|
|
#include <linux/init.h>
|
|
|
|
|
|
|
|
#include <linux/mm.h>
|
|
|
|
#include <linux/spinlock.h>
|
|
|
|
#include <linux/smp.h>
|
|
|
|
#include <linux/interrupt.h>
|
2009-01-21 08:26:06 +00:00
|
|
|
#include <linux/module.h>
|
x86: Spread tlb flush vector between nodes
Currently flush tlb vector allocation is based on below equation:
sender = smp_processor_id() % 8
This isn't optimal, CPUs from different node can have the same vector, this
causes a lot of lock contention. Instead, we can assign the same vectors to
CPUs from the same node, while different node has different vectors. This has
below advantages:
a. if there is lock contention, the lock contention is between CPUs from one
node. This should be much cheaper than the contention between nodes.
b. completely avoid lock contention between nodes. This especially benefits
kswapd, which is the biggest user of tlb flush, since kswapd sets its affinity
to specific node.
In my test, this could reduce > 20% CPU overhead in extreme case.The test
machine has 4 nodes and each node has 16 CPUs. I then bind each node's kswapd
to the first CPU of the node. I run a workload with 4 sequential mmap file
read thread. The files are empty sparse file. This workload will trigger a
lot of page reclaim and tlbflush. The kswapd bind is to easy trigger the
extreme tlb flush lock contention because otherwise kswapd keeps migrating
between CPUs of a node and I can't get stable result. Sure in real workload,
we can't always see so big tlb flush lock contention, but it's possible.
[ hpa: folded in fix from Eric Dumazet to use this_cpu_read() ]
Signed-off-by: Shaohua Li <shaohua.li@intel.com>
LKML-Reference: <1287544023.4571.8.camel@sli10-conroe.sh.intel.com>
Cc: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: H. Peter Anvin <hpa@linux.intel.com>
2010-10-20 03:07:03 +00:00
|
|
|
#include <linux/cpu.h>
|
2008-03-03 17:12:54 +00:00
|
|
|
|
|
|
|
#include <asm/tlbflush.h>
|
|
|
|
#include <asm/mmu_context.h>
|
2009-11-13 11:54:40 +00:00
|
|
|
#include <asm/cache.h>
|
2009-01-21 08:26:06 +00:00
|
|
|
#include <asm/apic.h>
|
2009-01-21 08:26:06 +00:00
|
|
|
#include <asm/uv/uv.h>
|
2008-03-25 16:28:56 +00:00
|
|
|
|
2009-01-18 15:38:57 +00:00
|
|
|
DEFINE_PER_CPU_SHARED_ALIGNED(struct tlb_state, cpu_tlbstate)
|
|
|
|
= { &init_mm, 0, };
|
|
|
|
|
2008-03-03 17:12:54 +00:00
|
|
|
/*
|
|
|
|
* Smarter SMP flushing macros.
|
|
|
|
* c/o Linus Torvalds.
|
|
|
|
*
|
|
|
|
* These mean you can really definitely utterly forget about
|
|
|
|
* writing to user space from interrupts. (Its not allowed anyway).
|
|
|
|
*
|
|
|
|
* Optimizations Manfred Spraul <manfred@colorfullife.com>
|
|
|
|
*
|
|
|
|
* More scalable flush, from Andi Kleen
|
|
|
|
*
|
|
|
|
* To avoid global state use 8 different call vectors.
|
|
|
|
* Each CPU uses a specific vector to trigger flushes on other
|
|
|
|
* CPUs. Depending on the received vector the target CPUs look into
|
2009-01-12 21:35:42 +00:00
|
|
|
* the right array slot for the flush data.
|
2008-03-03 17:12:54 +00:00
|
|
|
*
|
|
|
|
* With more than 8 CPUs they are hashed to the 8 available
|
|
|
|
* vectors. The limited global vector space forces us to this right now.
|
|
|
|
* In future when interrupts are split into per CPU domains this could be
|
|
|
|
* fixed, at the cost of triggering multiple IPIs in some cases.
|
|
|
|
*/
|
|
|
|
|
|
|
|
union smp_flush_state {
|
|
|
|
struct {
|
|
|
|
struct mm_struct *flush_mm;
|
|
|
|
unsigned long flush_va;
|
2009-07-25 17:15:48 +00:00
|
|
|
raw_spinlock_t tlbstate_lock;
|
2009-01-11 05:58:09 +00:00
|
|
|
DECLARE_BITMAP(flush_cpumask, NR_CPUS);
|
2008-03-03 17:12:54 +00:00
|
|
|
};
|
2009-11-13 11:54:40 +00:00
|
|
|
char pad[INTERNODE_CACHE_BYTES];
|
2009-01-12 21:35:42 +00:00
|
|
|
} ____cacheline_internodealigned_in_smp;
|
2008-03-03 17:12:54 +00:00
|
|
|
|
|
|
|
/* State is put into the per CPU data section, but padded
|
|
|
|
to a full cache line because other CPUs can access it and we don't
|
|
|
|
want false sharing in the per cpu data segment. */
|
2009-01-12 21:35:42 +00:00
|
|
|
static union smp_flush_state flush_state[NUM_INVALIDATE_TLB_VECTORS];
|
2008-03-03 17:12:54 +00:00
|
|
|
|
x86: Spread tlb flush vector between nodes
Currently flush tlb vector allocation is based on below equation:
sender = smp_processor_id() % 8
This isn't optimal, CPUs from different node can have the same vector, this
causes a lot of lock contention. Instead, we can assign the same vectors to
CPUs from the same node, while different node has different vectors. This has
below advantages:
a. if there is lock contention, the lock contention is between CPUs from one
node. This should be much cheaper than the contention between nodes.
b. completely avoid lock contention between nodes. This especially benefits
kswapd, which is the biggest user of tlb flush, since kswapd sets its affinity
to specific node.
In my test, this could reduce > 20% CPU overhead in extreme case.The test
machine has 4 nodes and each node has 16 CPUs. I then bind each node's kswapd
to the first CPU of the node. I run a workload with 4 sequential mmap file
read thread. The files are empty sparse file. This workload will trigger a
lot of page reclaim and tlbflush. The kswapd bind is to easy trigger the
extreme tlb flush lock contention because otherwise kswapd keeps migrating
between CPUs of a node and I can't get stable result. Sure in real workload,
we can't always see so big tlb flush lock contention, but it's possible.
[ hpa: folded in fix from Eric Dumazet to use this_cpu_read() ]
Signed-off-by: Shaohua Li <shaohua.li@intel.com>
LKML-Reference: <1287544023.4571.8.camel@sli10-conroe.sh.intel.com>
Cc: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: H. Peter Anvin <hpa@linux.intel.com>
2010-10-20 03:07:03 +00:00
|
|
|
static DEFINE_PER_CPU_READ_MOSTLY(int, tlb_vector_offset);
|
|
|
|
|
2008-03-03 17:12:54 +00:00
|
|
|
/*
|
|
|
|
* We cannot call mmdrop() because we are in interrupt context,
|
|
|
|
* instead update mm->cpu_vm_mask.
|
|
|
|
*/
|
|
|
|
void leave_mm(int cpu)
|
|
|
|
{
|
2012-05-23 18:06:59 +00:00
|
|
|
struct mm_struct *active_mm = this_cpu_read(cpu_tlbstate.active_mm);
|
2012-05-11 07:35:27 +00:00
|
|
|
if (this_cpu_read(cpu_tlbstate.state) == TLBSTATE_OK)
|
2008-03-03 17:12:54 +00:00
|
|
|
BUG();
|
2012-03-23 00:01:25 +00:00
|
|
|
if (cpumask_test_cpu(cpu, mm_cpumask(active_mm))) {
|
|
|
|
cpumask_clear_cpu(cpu, mm_cpumask(active_mm));
|
|
|
|
load_cr3(swapper_pg_dir);
|
|
|
|
}
|
2008-03-03 17:12:54 +00:00
|
|
|
}
|
|
|
|
EXPORT_SYMBOL_GPL(leave_mm);
|
|
|
|
|
|
|
|
/*
|
|
|
|
*
|
|
|
|
* The flush IPI assumes that a thread switch happens in this order:
|
|
|
|
* [cpu0: the cpu that switches]
|
|
|
|
* 1) switch_mm() either 1a) or 1b)
|
|
|
|
* 1a) thread switch to a different mm
|
|
|
|
* 1a1) cpu_clear(cpu, old_mm->cpu_vm_mask);
|
|
|
|
* Stop ipi delivery for the old mm. This is not synchronized with
|
|
|
|
* the other cpus, but smp_invalidate_interrupt ignore flush ipis
|
|
|
|
* for the wrong mm, and in the worst case we perform a superfluous
|
|
|
|
* tlb flush.
|
|
|
|
* 1a2) set cpu mmu_state to TLBSTATE_OK
|
|
|
|
* Now the smp_invalidate_interrupt won't call leave_mm if cpu0
|
|
|
|
* was in lazy tlb mode.
|
|
|
|
* 1a3) update cpu active_mm
|
|
|
|
* Now cpu0 accepts tlb flushes for the new mm.
|
|
|
|
* 1a4) cpu_set(cpu, new_mm->cpu_vm_mask);
|
|
|
|
* Now the other cpus will send tlb flush ipis.
|
|
|
|
* 1a4) change cr3.
|
|
|
|
* 1b) thread switch without mm change
|
|
|
|
* cpu active_mm is correct, cpu0 already handles
|
|
|
|
* flush ipis.
|
|
|
|
* 1b1) set cpu mmu_state to TLBSTATE_OK
|
|
|
|
* 1b2) test_and_set the cpu bit in cpu_vm_mask.
|
|
|
|
* Atomically set the bit [other cpus will start sending flush ipis],
|
|
|
|
* and test the bit.
|
|
|
|
* 1b3) if the bit was 0: leave_mm was called, flush the tlb.
|
|
|
|
* 2) switch %%esp, ie current
|
|
|
|
*
|
|
|
|
* The interrupt must handle 2 special cases:
|
|
|
|
* - cr3 is changed before %%esp, ie. it cannot use current->{active_,}mm.
|
|
|
|
* - the cpu performs speculative tlb reads, i.e. even if the cpu only
|
|
|
|
* runs in kernel space, the cpu could load tlb entries for user space
|
|
|
|
* pages.
|
|
|
|
*
|
|
|
|
* The good news is that cpu mmu_state is local to each cpu, no
|
|
|
|
* write/read ordering problems.
|
|
|
|
*/
|
|
|
|
|
|
|
|
/*
|
|
|
|
* TLB flush IPI:
|
|
|
|
*
|
|
|
|
* 1) Flush the tlb entries if the cpu uses the mm that's being flushed.
|
|
|
|
* 2) Leave the mm if we are in the lazy tlb mode.
|
|
|
|
*
|
|
|
|
* Interrupts are disabled.
|
|
|
|
*/
|
|
|
|
|
2009-01-21 08:26:06 +00:00
|
|
|
/*
|
|
|
|
* FIXME: use of asmlinkage is not consistent. On x86_64 it's noop
|
|
|
|
* but still used for documentation purpose but the usage is slightly
|
|
|
|
* inconsistent. On x86_32, asmlinkage is regparm(0) but interrupt
|
|
|
|
* entry calls in with the first parameter in %eax. Maybe define
|
|
|
|
* intrlinkage?
|
|
|
|
*/
|
|
|
|
#ifdef CONFIG_X86_64
|
|
|
|
asmlinkage
|
|
|
|
#endif
|
|
|
|
void smp_invalidate_interrupt(struct pt_regs *regs)
|
2008-03-03 17:12:54 +00:00
|
|
|
{
|
2009-01-21 08:26:06 +00:00
|
|
|
unsigned int cpu;
|
|
|
|
unsigned int sender;
|
2008-03-03 17:12:54 +00:00
|
|
|
union smp_flush_state *f;
|
|
|
|
|
|
|
|
cpu = smp_processor_id();
|
|
|
|
/*
|
|
|
|
* orig_rax contains the negated interrupt vector.
|
|
|
|
* Use that to determine where the sender put the data.
|
|
|
|
*/
|
|
|
|
sender = ~regs->orig_ax - INVALIDATE_TLB_VECTOR_START;
|
2009-01-12 21:35:42 +00:00
|
|
|
f = &flush_state[sender];
|
2008-03-03 17:12:54 +00:00
|
|
|
|
2009-01-11 05:58:09 +00:00
|
|
|
if (!cpumask_test_cpu(cpu, to_cpumask(f->flush_cpumask)))
|
2008-03-03 17:12:54 +00:00
|
|
|
goto out;
|
|
|
|
/*
|
|
|
|
* This was a BUG() but until someone can quote me the
|
|
|
|
* line from the intel manual that guarantees an IPI to
|
|
|
|
* multiple CPUs is retried _only_ on the erroring CPUs
|
|
|
|
* its staying as a return
|
|
|
|
*
|
|
|
|
* BUG();
|
|
|
|
*/
|
|
|
|
|
2012-05-11 07:35:27 +00:00
|
|
|
if (f->flush_mm == this_cpu_read(cpu_tlbstate.active_mm)) {
|
|
|
|
if (this_cpu_read(cpu_tlbstate.state) == TLBSTATE_OK) {
|
2008-03-03 17:12:54 +00:00
|
|
|
if (f->flush_va == TLB_FLUSH_ALL)
|
|
|
|
local_flush_tlb();
|
|
|
|
else
|
|
|
|
__flush_tlb_one(f->flush_va);
|
|
|
|
} else
|
|
|
|
leave_mm(cpu);
|
|
|
|
}
|
|
|
|
out:
|
|
|
|
ack_APIC_irq();
|
2009-01-21 08:26:06 +00:00
|
|
|
smp_mb__before_clear_bit();
|
2009-01-11 05:58:09 +00:00
|
|
|
cpumask_clear_cpu(cpu, to_cpumask(f->flush_cpumask));
|
2009-01-21 08:26:06 +00:00
|
|
|
smp_mb__after_clear_bit();
|
2008-12-12 23:52:26 +00:00
|
|
|
inc_irq_stat(irq_tlb_count);
|
2008-03-03 17:12:54 +00:00
|
|
|
}
|
|
|
|
|
2009-01-11 05:58:09 +00:00
|
|
|
static void flush_tlb_others_ipi(const struct cpumask *cpumask,
|
|
|
|
struct mm_struct *mm, unsigned long va)
|
2008-03-03 17:12:54 +00:00
|
|
|
{
|
2009-01-21 08:26:06 +00:00
|
|
|
unsigned int sender;
|
2008-03-03 17:12:54 +00:00
|
|
|
union smp_flush_state *f;
|
2008-06-02 13:56:14 +00:00
|
|
|
|
2008-03-03 17:12:54 +00:00
|
|
|
/* Caller has disabled preemption */
|
x86: Spread tlb flush vector between nodes
Currently flush tlb vector allocation is based on below equation:
sender = smp_processor_id() % 8
This isn't optimal, CPUs from different node can have the same vector, this
causes a lot of lock contention. Instead, we can assign the same vectors to
CPUs from the same node, while different node has different vectors. This has
below advantages:
a. if there is lock contention, the lock contention is between CPUs from one
node. This should be much cheaper than the contention between nodes.
b. completely avoid lock contention between nodes. This especially benefits
kswapd, which is the biggest user of tlb flush, since kswapd sets its affinity
to specific node.
In my test, this could reduce > 20% CPU overhead in extreme case.The test
machine has 4 nodes and each node has 16 CPUs. I then bind each node's kswapd
to the first CPU of the node. I run a workload with 4 sequential mmap file
read thread. The files are empty sparse file. This workload will trigger a
lot of page reclaim and tlbflush. The kswapd bind is to easy trigger the
extreme tlb flush lock contention because otherwise kswapd keeps migrating
between CPUs of a node and I can't get stable result. Sure in real workload,
we can't always see so big tlb flush lock contention, but it's possible.
[ hpa: folded in fix from Eric Dumazet to use this_cpu_read() ]
Signed-off-by: Shaohua Li <shaohua.li@intel.com>
LKML-Reference: <1287544023.4571.8.camel@sli10-conroe.sh.intel.com>
Cc: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: H. Peter Anvin <hpa@linux.intel.com>
2010-10-20 03:07:03 +00:00
|
|
|
sender = this_cpu_read(tlb_vector_offset);
|
2009-01-12 21:35:42 +00:00
|
|
|
f = &flush_state[sender];
|
2008-03-03 17:12:54 +00:00
|
|
|
|
2011-01-17 02:52:10 +00:00
|
|
|
if (nr_cpu_ids > NUM_INVALIDATE_TLB_VECTORS)
|
|
|
|
raw_spin_lock(&f->tlbstate_lock);
|
2008-03-03 17:12:54 +00:00
|
|
|
|
|
|
|
f->flush_mm = mm;
|
|
|
|
f->flush_va = va;
|
x86: don't call '->send_IPI_mask()' with an empty mask
As noted in 83d349f35e1ae72268c5104dbf9ab2ae635425d4 ("x86: don't send
an IPI to the empty set of CPU's"), some APIC's will be very unhappy
with an empty destination mask. That commit added a WARN_ON() for that
case, and avoided the resulting problem, but didn't fix the underlying
reason for why those empty mask cases happened.
This fixes that, by checking the result of 'cpumask_andnot()' of the
current CPU actually has any other CPU's left in the set of CPU's to be
sent a TLB flush, and not calling down to the IPI code if the mask is
empty.
The reason this started happening at all is that we started passing just
the CPU mask pointers around in commit 4595f9620 ("x86: change
flush_tlb_others to take a const struct cpumask"), and when we did that,
the cpumask was no longer thread-local.
Before that commit, flush_tlb_mm() used to create it's own copy of
'mm->cpu_vm_mask' and pass that copy down to the low-level flush
routines after having tested that it was not empty. But after changing
it to just pass down the CPU mask pointer, the lower level TLB flush
routines would now get a pointer to that 'mm->cpu_vm_mask', and that
could still change - and become empty - after the test due to other
CPU's having flushed their own TLB's.
See
http://bugzilla.kernel.org/show_bug.cgi?id=13933
for details.
Tested-by: Thomas Björnell <thomas.bjornell@gmail.com>
Cc: stable@kernel.org
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2009-08-21 16:48:10 +00:00
|
|
|
if (cpumask_andnot(to_cpumask(f->flush_cpumask), cpumask, cpumask_of(smp_processor_id()))) {
|
|
|
|
/*
|
|
|
|
* We have to send the IPI only to
|
|
|
|
* CPUs affected.
|
|
|
|
*/
|
|
|
|
apic->send_IPI_mask(to_cpumask(f->flush_cpumask),
|
|
|
|
INVALIDATE_TLB_VECTOR_START + sender);
|
2008-03-03 17:12:54 +00:00
|
|
|
|
x86: don't call '->send_IPI_mask()' with an empty mask
As noted in 83d349f35e1ae72268c5104dbf9ab2ae635425d4 ("x86: don't send
an IPI to the empty set of CPU's"), some APIC's will be very unhappy
with an empty destination mask. That commit added a WARN_ON() for that
case, and avoided the resulting problem, but didn't fix the underlying
reason for why those empty mask cases happened.
This fixes that, by checking the result of 'cpumask_andnot()' of the
current CPU actually has any other CPU's left in the set of CPU's to be
sent a TLB flush, and not calling down to the IPI code if the mask is
empty.
The reason this started happening at all is that we started passing just
the CPU mask pointers around in commit 4595f9620 ("x86: change
flush_tlb_others to take a const struct cpumask"), and when we did that,
the cpumask was no longer thread-local.
Before that commit, flush_tlb_mm() used to create it's own copy of
'mm->cpu_vm_mask' and pass that copy down to the low-level flush
routines after having tested that it was not empty. But after changing
it to just pass down the CPU mask pointer, the lower level TLB flush
routines would now get a pointer to that 'mm->cpu_vm_mask', and that
could still change - and become empty - after the test due to other
CPU's having flushed their own TLB's.
See
http://bugzilla.kernel.org/show_bug.cgi?id=13933
for details.
Tested-by: Thomas Björnell <thomas.bjornell@gmail.com>
Cc: stable@kernel.org
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2009-08-21 16:48:10 +00:00
|
|
|
while (!cpumask_empty(to_cpumask(f->flush_cpumask)))
|
|
|
|
cpu_relax();
|
|
|
|
}
|
2008-03-03 17:12:54 +00:00
|
|
|
|
|
|
|
f->flush_mm = NULL;
|
|
|
|
f->flush_va = 0;
|
2011-01-17 02:52:10 +00:00
|
|
|
if (nr_cpu_ids > NUM_INVALIDATE_TLB_VECTORS)
|
|
|
|
raw_spin_unlock(&f->tlbstate_lock);
|
2008-03-03 17:12:54 +00:00
|
|
|
}
|
|
|
|
|
2009-01-11 05:58:09 +00:00
|
|
|
void native_flush_tlb_others(const struct cpumask *cpumask,
|
|
|
|
struct mm_struct *mm, unsigned long va)
|
|
|
|
{
|
|
|
|
if (is_uv_system()) {
|
2009-01-21 08:26:06 +00:00
|
|
|
unsigned int cpu;
|
2009-01-11 05:58:10 +00:00
|
|
|
|
2011-03-15 01:57:37 +00:00
|
|
|
cpu = smp_processor_id();
|
2009-01-21 08:26:06 +00:00
|
|
|
cpumask = uv_flush_tlb_others(cpumask, mm, va, cpu);
|
|
|
|
if (cpumask)
|
|
|
|
flush_tlb_others_ipi(cpumask, mm, va);
|
2009-01-11 05:58:10 +00:00
|
|
|
return;
|
2009-01-11 05:58:09 +00:00
|
|
|
}
|
|
|
|
flush_tlb_others_ipi(cpumask, mm, va);
|
|
|
|
}
|
|
|
|
|
x86: Spread tlb flush vector between nodes
Currently flush tlb vector allocation is based on below equation:
sender = smp_processor_id() % 8
This isn't optimal, CPUs from different node can have the same vector, this
causes a lot of lock contention. Instead, we can assign the same vectors to
CPUs from the same node, while different node has different vectors. This has
below advantages:
a. if there is lock contention, the lock contention is between CPUs from one
node. This should be much cheaper than the contention between nodes.
b. completely avoid lock contention between nodes. This especially benefits
kswapd, which is the biggest user of tlb flush, since kswapd sets its affinity
to specific node.
In my test, this could reduce > 20% CPU overhead in extreme case.The test
machine has 4 nodes and each node has 16 CPUs. I then bind each node's kswapd
to the first CPU of the node. I run a workload with 4 sequential mmap file
read thread. The files are empty sparse file. This workload will trigger a
lot of page reclaim and tlbflush. The kswapd bind is to easy trigger the
extreme tlb flush lock contention because otherwise kswapd keeps migrating
between CPUs of a node and I can't get stable result. Sure in real workload,
we can't always see so big tlb flush lock contention, but it's possible.
[ hpa: folded in fix from Eric Dumazet to use this_cpu_read() ]
Signed-off-by: Shaohua Li <shaohua.li@intel.com>
LKML-Reference: <1287544023.4571.8.camel@sli10-conroe.sh.intel.com>
Cc: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: H. Peter Anvin <hpa@linux.intel.com>
2010-10-20 03:07:03 +00:00
|
|
|
static void __cpuinit calculate_tlb_offset(void)
|
|
|
|
{
|
2010-11-13 18:52:09 +00:00
|
|
|
int cpu, node, nr_node_vecs, idx = 0;
|
x86: Spread tlb flush vector between nodes
Currently flush tlb vector allocation is based on below equation:
sender = smp_processor_id() % 8
This isn't optimal, CPUs from different node can have the same vector, this
causes a lot of lock contention. Instead, we can assign the same vectors to
CPUs from the same node, while different node has different vectors. This has
below advantages:
a. if there is lock contention, the lock contention is between CPUs from one
node. This should be much cheaper than the contention between nodes.
b. completely avoid lock contention between nodes. This especially benefits
kswapd, which is the biggest user of tlb flush, since kswapd sets its affinity
to specific node.
In my test, this could reduce > 20% CPU overhead in extreme case.The test
machine has 4 nodes and each node has 16 CPUs. I then bind each node's kswapd
to the first CPU of the node. I run a workload with 4 sequential mmap file
read thread. The files are empty sparse file. This workload will trigger a
lot of page reclaim and tlbflush. The kswapd bind is to easy trigger the
extreme tlb flush lock contention because otherwise kswapd keeps migrating
between CPUs of a node and I can't get stable result. Sure in real workload,
we can't always see so big tlb flush lock contention, but it's possible.
[ hpa: folded in fix from Eric Dumazet to use this_cpu_read() ]
Signed-off-by: Shaohua Li <shaohua.li@intel.com>
LKML-Reference: <1287544023.4571.8.camel@sli10-conroe.sh.intel.com>
Cc: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: H. Peter Anvin <hpa@linux.intel.com>
2010-10-20 03:07:03 +00:00
|
|
|
/*
|
|
|
|
* we are changing tlb_vector_offset for each CPU in runtime, but this
|
|
|
|
* will not cause inconsistency, as the write is atomic under X86. we
|
|
|
|
* might see more lock contentions in a short time, but after all CPU's
|
|
|
|
* tlb_vector_offset are changed, everything should go normal
|
|
|
|
*
|
|
|
|
* Note: if NUM_INVALIDATE_TLB_VECTORS % nr_online_nodes !=0, we might
|
|
|
|
* waste some vectors.
|
|
|
|
**/
|
|
|
|
if (nr_online_nodes > NUM_INVALIDATE_TLB_VECTORS)
|
|
|
|
nr_node_vecs = 1;
|
|
|
|
else
|
|
|
|
nr_node_vecs = NUM_INVALIDATE_TLB_VECTORS/nr_online_nodes;
|
|
|
|
|
|
|
|
for_each_online_node(node) {
|
2010-11-13 18:52:09 +00:00
|
|
|
int node_offset = (idx % NUM_INVALIDATE_TLB_VECTORS) *
|
x86: Spread tlb flush vector between nodes
Currently flush tlb vector allocation is based on below equation:
sender = smp_processor_id() % 8
This isn't optimal, CPUs from different node can have the same vector, this
causes a lot of lock contention. Instead, we can assign the same vectors to
CPUs from the same node, while different node has different vectors. This has
below advantages:
a. if there is lock contention, the lock contention is between CPUs from one
node. This should be much cheaper than the contention between nodes.
b. completely avoid lock contention between nodes. This especially benefits
kswapd, which is the biggest user of tlb flush, since kswapd sets its affinity
to specific node.
In my test, this could reduce > 20% CPU overhead in extreme case.The test
machine has 4 nodes and each node has 16 CPUs. I then bind each node's kswapd
to the first CPU of the node. I run a workload with 4 sequential mmap file
read thread. The files are empty sparse file. This workload will trigger a
lot of page reclaim and tlbflush. The kswapd bind is to easy trigger the
extreme tlb flush lock contention because otherwise kswapd keeps migrating
between CPUs of a node and I can't get stable result. Sure in real workload,
we can't always see so big tlb flush lock contention, but it's possible.
[ hpa: folded in fix from Eric Dumazet to use this_cpu_read() ]
Signed-off-by: Shaohua Li <shaohua.li@intel.com>
LKML-Reference: <1287544023.4571.8.camel@sli10-conroe.sh.intel.com>
Cc: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: H. Peter Anvin <hpa@linux.intel.com>
2010-10-20 03:07:03 +00:00
|
|
|
nr_node_vecs;
|
|
|
|
int cpu_offset = 0;
|
|
|
|
for_each_cpu(cpu, cpumask_of_node(node)) {
|
|
|
|
per_cpu(tlb_vector_offset, cpu) = node_offset +
|
|
|
|
cpu_offset;
|
|
|
|
cpu_offset++;
|
|
|
|
cpu_offset = cpu_offset % nr_node_vecs;
|
|
|
|
}
|
2010-11-13 18:52:09 +00:00
|
|
|
idx++;
|
x86: Spread tlb flush vector between nodes
Currently flush tlb vector allocation is based on below equation:
sender = smp_processor_id() % 8
This isn't optimal, CPUs from different node can have the same vector, this
causes a lot of lock contention. Instead, we can assign the same vectors to
CPUs from the same node, while different node has different vectors. This has
below advantages:
a. if there is lock contention, the lock contention is between CPUs from one
node. This should be much cheaper than the contention between nodes.
b. completely avoid lock contention between nodes. This especially benefits
kswapd, which is the biggest user of tlb flush, since kswapd sets its affinity
to specific node.
In my test, this could reduce > 20% CPU overhead in extreme case.The test
machine has 4 nodes and each node has 16 CPUs. I then bind each node's kswapd
to the first CPU of the node. I run a workload with 4 sequential mmap file
read thread. The files are empty sparse file. This workload will trigger a
lot of page reclaim and tlbflush. The kswapd bind is to easy trigger the
extreme tlb flush lock contention because otherwise kswapd keeps migrating
between CPUs of a node and I can't get stable result. Sure in real workload,
we can't always see so big tlb flush lock contention, but it's possible.
[ hpa: folded in fix from Eric Dumazet to use this_cpu_read() ]
Signed-off-by: Shaohua Li <shaohua.li@intel.com>
LKML-Reference: <1287544023.4571.8.camel@sli10-conroe.sh.intel.com>
Cc: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: H. Peter Anvin <hpa@linux.intel.com>
2010-10-20 03:07:03 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2010-11-01 06:53:50 +00:00
|
|
|
static int __cpuinit tlb_cpuhp_notify(struct notifier_block *n,
|
x86: Spread tlb flush vector between nodes
Currently flush tlb vector allocation is based on below equation:
sender = smp_processor_id() % 8
This isn't optimal, CPUs from different node can have the same vector, this
causes a lot of lock contention. Instead, we can assign the same vectors to
CPUs from the same node, while different node has different vectors. This has
below advantages:
a. if there is lock contention, the lock contention is between CPUs from one
node. This should be much cheaper than the contention between nodes.
b. completely avoid lock contention between nodes. This especially benefits
kswapd, which is the biggest user of tlb flush, since kswapd sets its affinity
to specific node.
In my test, this could reduce > 20% CPU overhead in extreme case.The test
machine has 4 nodes and each node has 16 CPUs. I then bind each node's kswapd
to the first CPU of the node. I run a workload with 4 sequential mmap file
read thread. The files are empty sparse file. This workload will trigger a
lot of page reclaim and tlbflush. The kswapd bind is to easy trigger the
extreme tlb flush lock contention because otherwise kswapd keeps migrating
between CPUs of a node and I can't get stable result. Sure in real workload,
we can't always see so big tlb flush lock contention, but it's possible.
[ hpa: folded in fix from Eric Dumazet to use this_cpu_read() ]
Signed-off-by: Shaohua Li <shaohua.li@intel.com>
LKML-Reference: <1287544023.4571.8.camel@sli10-conroe.sh.intel.com>
Cc: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: H. Peter Anvin <hpa@linux.intel.com>
2010-10-20 03:07:03 +00:00
|
|
|
unsigned long action, void *hcpu)
|
|
|
|
{
|
|
|
|
switch (action & 0xf) {
|
|
|
|
case CPU_ONLINE:
|
|
|
|
case CPU_DEAD:
|
|
|
|
calculate_tlb_offset();
|
|
|
|
}
|
|
|
|
return NOTIFY_OK;
|
|
|
|
}
|
|
|
|
|
2008-04-23 11:20:56 +00:00
|
|
|
static int __cpuinit init_smp_flush(void)
|
2008-03-03 17:12:54 +00:00
|
|
|
{
|
|
|
|
int i;
|
|
|
|
|
2009-01-12 21:35:42 +00:00
|
|
|
for (i = 0; i < ARRAY_SIZE(flush_state); i++)
|
2009-07-25 17:15:48 +00:00
|
|
|
raw_spin_lock_init(&flush_state[i].tlbstate_lock);
|
2008-04-19 14:55:17 +00:00
|
|
|
|
x86: Spread tlb flush vector between nodes
Currently flush tlb vector allocation is based on below equation:
sender = smp_processor_id() % 8
This isn't optimal, CPUs from different node can have the same vector, this
causes a lot of lock contention. Instead, we can assign the same vectors to
CPUs from the same node, while different node has different vectors. This has
below advantages:
a. if there is lock contention, the lock contention is between CPUs from one
node. This should be much cheaper than the contention between nodes.
b. completely avoid lock contention between nodes. This especially benefits
kswapd, which is the biggest user of tlb flush, since kswapd sets its affinity
to specific node.
In my test, this could reduce > 20% CPU overhead in extreme case.The test
machine has 4 nodes and each node has 16 CPUs. I then bind each node's kswapd
to the first CPU of the node. I run a workload with 4 sequential mmap file
read thread. The files are empty sparse file. This workload will trigger a
lot of page reclaim and tlbflush. The kswapd bind is to easy trigger the
extreme tlb flush lock contention because otherwise kswapd keeps migrating
between CPUs of a node and I can't get stable result. Sure in real workload,
we can't always see so big tlb flush lock contention, but it's possible.
[ hpa: folded in fix from Eric Dumazet to use this_cpu_read() ]
Signed-off-by: Shaohua Li <shaohua.li@intel.com>
LKML-Reference: <1287544023.4571.8.camel@sli10-conroe.sh.intel.com>
Cc: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: H. Peter Anvin <hpa@linux.intel.com>
2010-10-20 03:07:03 +00:00
|
|
|
calculate_tlb_offset();
|
|
|
|
hotcpu_notifier(tlb_cpuhp_notify, 0);
|
2008-03-03 17:12:54 +00:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
core_initcall(init_smp_flush);
|
|
|
|
|
|
|
|
void flush_tlb_current_task(void)
|
|
|
|
{
|
|
|
|
struct mm_struct *mm = current->mm;
|
|
|
|
|
|
|
|
preempt_disable();
|
|
|
|
|
|
|
|
local_flush_tlb();
|
2009-09-24 15:34:51 +00:00
|
|
|
if (cpumask_any_but(mm_cpumask(mm), smp_processor_id()) < nr_cpu_ids)
|
|
|
|
flush_tlb_others(mm_cpumask(mm), mm, TLB_FLUSH_ALL);
|
2008-03-03 17:12:54 +00:00
|
|
|
preempt_enable();
|
|
|
|
}
|
|
|
|
|
|
|
|
void flush_tlb_mm(struct mm_struct *mm)
|
|
|
|
{
|
|
|
|
preempt_disable();
|
|
|
|
|
|
|
|
if (current->active_mm == mm) {
|
|
|
|
if (current->mm)
|
|
|
|
local_flush_tlb();
|
|
|
|
else
|
|
|
|
leave_mm(smp_processor_id());
|
|
|
|
}
|
2009-09-24 15:34:51 +00:00
|
|
|
if (cpumask_any_but(mm_cpumask(mm), smp_processor_id()) < nr_cpu_ids)
|
|
|
|
flush_tlb_others(mm_cpumask(mm), mm, TLB_FLUSH_ALL);
|
2008-03-03 17:12:54 +00:00
|
|
|
|
|
|
|
preempt_enable();
|
|
|
|
}
|
|
|
|
|
|
|
|
void flush_tlb_page(struct vm_area_struct *vma, unsigned long va)
|
|
|
|
{
|
|
|
|
struct mm_struct *mm = vma->vm_mm;
|
|
|
|
|
|
|
|
preempt_disable();
|
|
|
|
|
|
|
|
if (current->active_mm == mm) {
|
|
|
|
if (current->mm)
|
|
|
|
__flush_tlb_one(va);
|
|
|
|
else
|
|
|
|
leave_mm(smp_processor_id());
|
|
|
|
}
|
|
|
|
|
2009-09-24 15:34:51 +00:00
|
|
|
if (cpumask_any_but(mm_cpumask(mm), smp_processor_id()) < nr_cpu_ids)
|
|
|
|
flush_tlb_others(mm_cpumask(mm), mm, va);
|
2008-03-03 17:12:54 +00:00
|
|
|
|
|
|
|
preempt_enable();
|
|
|
|
}
|
|
|
|
|
|
|
|
static void do_flush_tlb_all(void *info)
|
|
|
|
{
|
|
|
|
__flush_tlb_all();
|
2012-05-11 07:35:27 +00:00
|
|
|
if (this_cpu_read(cpu_tlbstate.state) == TLBSTATE_LAZY)
|
2010-07-21 12:47:05 +00:00
|
|
|
leave_mm(smp_processor_id());
|
2008-03-03 17:12:54 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
void flush_tlb_all(void)
|
|
|
|
{
|
2008-05-09 07:39:44 +00:00
|
|
|
on_each_cpu(do_flush_tlb_all, NULL, 1);
|
2008-03-03 17:12:54 +00:00
|
|
|
}
|