2005-04-16 22:20:36 +00:00
|
|
|
#
|
|
|
|
|
# Makefile for the Linux/MIPS kernel.
|
|
|
|
|
#
|
|
|
|
|
|
2012-05-03 09:02:55 +00:00
|
|
|
extra-y := head.o vmlinux.lds
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2013-05-21 08:53:37 +00:00
|
|
|
obj-y += cpu-probe.o branch.o entry.o genex.o idle.o irq.o process.o \
|
2013-04-11 05:34:59 +00:00
|
|
|
prom.o ptrace.o reset.o setup.o signal.o syscall.o \
|
2010-02-19 00:13:04 +00:00
|
|
|
time.o topology.o traps.o unaligned.o watch.o vdso.o
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2009-11-20 12:34:29 +00:00
|
|
|
ifdef CONFIG_FUNCTION_TRACER
|
MIPS: Tracing: Add dynamic function tracer support
With dynamic function tracer, by default, _mcount is defined as an
"empty" function, it returns directly without any more action . When
enabling it in user-space, it will jump to a real tracing
function(ftrace_caller), and do the real job for us.
Differ from the static function tracer, dynamic function tracer provides
two functions ftrace_make_call()/ftrace_make_nop() to enable/disable the
tracing of some indicated kernel functions(set_ftrace_filter).
In the -v4 version, the implementation of this support is basically the same as
X86 version does: _mcount is implemented as an empty function and ftrace_caller
is implemented as a real tracing function respectively.
But in this version, to support module tracing with the help of
-mlong-calls in arch/mips/Makefile:
MODFLAGS += -mlong-calls.
The stuff becomes a little more complex. We need to cope with two
different type of calling to _mcount.
For the kernel part, the calling to _mcount(result of "objdump -hdr
vmlinux"). is like this:
108: 03e0082d move at,ra
10c: 0c000000 jal 0 <fpcsr_pending>
10c: R_MIPS_26 _mcount
10c: R_MIPS_NONE *ABS*
10c: R_MIPS_NONE *ABS*
110: 00020021 nop
For the module with -mlong-calls, it looks like this:
c: 3c030000 lui v1,0x0
c: R_MIPS_HI16 _mcount
c: R_MIPS_NONE *ABS*
c: R_MIPS_NONE *ABS*
10: 64630000 daddiu v1,v1,0
10: R_MIPS_LO16 _mcount
10: R_MIPS_NONE *ABS*
10: R_MIPS_NONE *ABS*
14: 03e0082d move at,ra
18: 0060f809 jalr v1
In the kernel version, there is only one "_mcount" string for every
kernel function, so, we just need to match this one in mcount_regex of
scripts/recordmcount.pl, but in the module version, we need to choose
one of the two to match. Herein, I choose the first one with
"R_MIPS_HI16 _mcount".
and In the kernel verion, without module tracing support, we just need
to replace "jal _mcount" by "jal ftrace_caller" to do real tracing, and
filter the tracing of some kernel functions via replacing it by a nop
instruction.
but as we have described before, the instruction "jal ftrace_caller" only left
32bit length for the address of ftrace_caller, it will fail when calling from
the module space. so, herein, we must replace something else.
the basic idea is loading the address of ftrace_caller to v1 via changing these
two instructions:
lui v1,0x0
addiu v1,v1,0
If we want to enable the tracing, we need to replace the above instructions to:
lui v1, HI_16BIT_ftrace_caller
addiu v1, v1, LOW_16BIT_ftrace_caller
If we want to stop the tracing of the indicated kernel functions, we
just need to replace the "jalr v1" to a nop instruction. but we need to
replace two instructions and encode the above two instructions
oursevles.
Is there a simpler solution? Yes! Here it is, in this version, we put _mcount
and ftrace_caller together, which means the address of _mcount and
ftrace_caller is the same:
_mcount:
ftrace_caller:
j ftrace_stub
nop
...(do real tracing here)...
ftrace_stub:
jr ra
move ra, at
By default, the kernel functions call _mcount, and then jump to ftrace_stub and
return. and when we want to do real tracing, we just need to remove that "j
ftrace_stub", and it will run through the two "nop" instructions and then do
the real tracing job.
what about filtering job? we just need to do this:
lui v1, hi_16bit_of_mcount <--> b 1f (0x10000004)
addiu v1, v1, low_16bit_of_mcount
move at, ra
jalr v1
nop
1f: (rec->ip + 12)
In linux-mips64, there will be some local symbols, whose name are
prefixed by $L, which need to be filtered. thanks goes to Steven for
writing the mips64-specific function_regex.
In a conclusion, with RISC, things becomes easier with such a "stupid"
trick, RISC is something like K.I.S.S, and also, there are lots of
"simple" tricks in the whole ftrace support, thanks goes to Steven and
the other folks for providing such a wonderful tracing framework!
Signed-off-by: Wu Zhangjin <wuzhangjin@gmail.com>
Cc: Nicholas Mc Guire <der.herr@hofr.at>
Cc: zhangfx@lemote.com
Cc: Wu Zhangjin <wuzhangjin@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: linux-kernel@vger.kernel.org
Cc: linux-mips@linux-mips.org
Patchwork: http://patchwork.linux-mips.org/patch/675/
Acked-by: Steven Rostedt <rostedt@goodmis.org>
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
2009-11-20 12:34:32 +00:00
|
|
|
CFLAGS_REMOVE_ftrace.o = -pg
|
2009-11-20 12:34:29 +00:00
|
|
|
CFLAGS_REMOVE_early_printk.o = -pg
|
2011-09-24 00:29:55 +00:00
|
|
|
CFLAGS_REMOVE_perf_event.o = -pg
|
|
|
|
|
CFLAGS_REMOVE_perf_event_mipsxx.o = -pg
|
2009-11-20 12:34:29 +00:00
|
|
|
endif
|
|
|
|
|
|
2007-11-01 01:57:55 +00:00
|
|
|
obj-$(CONFIG_CEVT_BCM1480) += cevt-bcm1480.o
|
2012-11-30 16:27:27 +00:00
|
|
|
obj-$(CONFIG_CEVT_R4K) += cevt-r4k.o
|
2008-04-25 03:11:44 +00:00
|
|
|
obj-$(CONFIG_CEVT_DS1287) += cevt-ds1287.o
|
2013-04-10 21:30:12 +00:00
|
|
|
obj-$(CONFIG_CEVT_GIC) += cevt-gic.o
|
2007-10-22 10:43:15 +00:00
|
|
|
obj-$(CONFIG_CEVT_GT641XX) += cevt-gt641xx.o
|
2007-11-01 01:57:55 +00:00
|
|
|
obj-$(CONFIG_CEVT_SB1250) += cevt-sb1250.o
|
2007-10-24 16:34:09 +00:00
|
|
|
obj-$(CONFIG_CEVT_TXX9) += cevt-txx9.o
|
2007-11-01 01:57:55 +00:00
|
|
|
obj-$(CONFIG_CSRC_BCM1480) += csrc-bcm1480.o
|
2013-04-10 21:28:36 +00:00
|
|
|
obj-$(CONFIG_CSRC_GIC) += csrc-gic.o
|
2008-04-24 00:48:40 +00:00
|
|
|
obj-$(CONFIG_CSRC_IOASIC) += csrc-ioasic.o
|
2012-11-15 05:34:17 +00:00
|
|
|
obj-$(CONFIG_CSRC_R4K) += csrc-r4k.o
|
2007-11-01 01:57:55 +00:00
|
|
|
obj-$(CONFIG_CSRC_SB1250) += csrc-sb1250.o
|
2008-04-28 16:14:26 +00:00
|
|
|
obj-$(CONFIG_SYNC_R4K) += sync-r4k.o
|
2007-10-18 16:48:11 +00:00
|
|
|
|
2013-11-14 16:12:32 +00:00
|
|
|
obj-$(CONFIG_DEBUG_FS) += segment.o
|
2006-09-26 14:44:01 +00:00
|
|
|
obj-$(CONFIG_STACKTRACE) += stacktrace.o
|
2005-02-21 10:45:09 +00:00
|
|
|
obj-$(CONFIG_MODULES) += mips_ksyms.o module.o
|
2012-09-28 05:01:03 +00:00
|
|
|
obj-$(CONFIG_MODULES_USE_ELF_RELA) += module-rela.o
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2012-07-13 21:38:17 +00:00
|
|
|
obj-$(CONFIG_FTRACE_SYSCALLS) += ftrace.o
|
MIPS: Tracing: Add dynamic function tracer support
With dynamic function tracer, by default, _mcount is defined as an
"empty" function, it returns directly without any more action . When
enabling it in user-space, it will jump to a real tracing
function(ftrace_caller), and do the real job for us.
Differ from the static function tracer, dynamic function tracer provides
two functions ftrace_make_call()/ftrace_make_nop() to enable/disable the
tracing of some indicated kernel functions(set_ftrace_filter).
In the -v4 version, the implementation of this support is basically the same as
X86 version does: _mcount is implemented as an empty function and ftrace_caller
is implemented as a real tracing function respectively.
But in this version, to support module tracing with the help of
-mlong-calls in arch/mips/Makefile:
MODFLAGS += -mlong-calls.
The stuff becomes a little more complex. We need to cope with two
different type of calling to _mcount.
For the kernel part, the calling to _mcount(result of "objdump -hdr
vmlinux"). is like this:
108: 03e0082d move at,ra
10c: 0c000000 jal 0 <fpcsr_pending>
10c: R_MIPS_26 _mcount
10c: R_MIPS_NONE *ABS*
10c: R_MIPS_NONE *ABS*
110: 00020021 nop
For the module with -mlong-calls, it looks like this:
c: 3c030000 lui v1,0x0
c: R_MIPS_HI16 _mcount
c: R_MIPS_NONE *ABS*
c: R_MIPS_NONE *ABS*
10: 64630000 daddiu v1,v1,0
10: R_MIPS_LO16 _mcount
10: R_MIPS_NONE *ABS*
10: R_MIPS_NONE *ABS*
14: 03e0082d move at,ra
18: 0060f809 jalr v1
In the kernel version, there is only one "_mcount" string for every
kernel function, so, we just need to match this one in mcount_regex of
scripts/recordmcount.pl, but in the module version, we need to choose
one of the two to match. Herein, I choose the first one with
"R_MIPS_HI16 _mcount".
and In the kernel verion, without module tracing support, we just need
to replace "jal _mcount" by "jal ftrace_caller" to do real tracing, and
filter the tracing of some kernel functions via replacing it by a nop
instruction.
but as we have described before, the instruction "jal ftrace_caller" only left
32bit length for the address of ftrace_caller, it will fail when calling from
the module space. so, herein, we must replace something else.
the basic idea is loading the address of ftrace_caller to v1 via changing these
two instructions:
lui v1,0x0
addiu v1,v1,0
If we want to enable the tracing, we need to replace the above instructions to:
lui v1, HI_16BIT_ftrace_caller
addiu v1, v1, LOW_16BIT_ftrace_caller
If we want to stop the tracing of the indicated kernel functions, we
just need to replace the "jalr v1" to a nop instruction. but we need to
replace two instructions and encode the above two instructions
oursevles.
Is there a simpler solution? Yes! Here it is, in this version, we put _mcount
and ftrace_caller together, which means the address of _mcount and
ftrace_caller is the same:
_mcount:
ftrace_caller:
j ftrace_stub
nop
...(do real tracing here)...
ftrace_stub:
jr ra
move ra, at
By default, the kernel functions call _mcount, and then jump to ftrace_stub and
return. and when we want to do real tracing, we just need to remove that "j
ftrace_stub", and it will run through the two "nop" instructions and then do
the real tracing job.
what about filtering job? we just need to do this:
lui v1, hi_16bit_of_mcount <--> b 1f (0x10000004)
addiu v1, v1, low_16bit_of_mcount
move at, ra
jalr v1
nop
1f: (rec->ip + 12)
In linux-mips64, there will be some local symbols, whose name are
prefixed by $L, which need to be filtered. thanks goes to Steven for
writing the mips64-specific function_regex.
In a conclusion, with RISC, things becomes easier with such a "stupid"
trick, RISC is something like K.I.S.S, and also, there are lots of
"simple" tricks in the whole ftrace support, thanks goes to Steven and
the other folks for providing such a wonderful tracing framework!
Signed-off-by: Wu Zhangjin <wuzhangjin@gmail.com>
Cc: Nicholas Mc Guire <der.herr@hofr.at>
Cc: zhangfx@lemote.com
Cc: Wu Zhangjin <wuzhangjin@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: linux-kernel@vger.kernel.org
Cc: linux-mips@linux-mips.org
Patchwork: http://patchwork.linux-mips.org/patch/675/
Acked-by: Steven Rostedt <rostedt@goodmis.org>
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
2009-11-20 12:34:32 +00:00
|
|
|
obj-$(CONFIG_FUNCTION_TRACER) += mcount.o ftrace.o
|
2009-11-20 12:34:29 +00:00
|
|
|
|
2012-01-31 17:18:44 +00:00
|
|
|
obj-$(CONFIG_CPU_R4K_FPU) += r4k_fpu.o r4k_switch.o
|
2005-04-16 22:20:36 +00:00
|
|
|
obj-$(CONFIG_CPU_R3000) += r2300_fpu.o r2300_switch.o
|
2007-06-06 06:52:43 +00:00
|
|
|
obj-$(CONFIG_CPU_R6000) += r6000_fpu.o r4k_switch.o
|
|
|
|
|
obj-$(CONFIG_CPU_TX39XX) += r2300_fpu.o r2300_switch.o
|
2014-05-28 21:52:04 +00:00
|
|
|
obj-$(CONFIG_CPU_CAVIUM_OCTEON) += r4k_fpu.o octeon_switch.o
|
2005-04-16 22:20:36 +00:00
|
|
|
|
|
|
|
|
obj-$(CONFIG_SMP) += smp.o
|
2007-11-24 22:33:28 +00:00
|
|
|
obj-$(CONFIG_SMP_UP) += smp-up.o
|
2011-11-16 01:25:45 +00:00
|
|
|
obj-$(CONFIG_CPU_BMIPS) += smp-bmips.o bmips_vec.o
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2006-04-05 08:45:45 +00:00
|
|
|
obj-$(CONFIG_MIPS_MT) += mips-mt.o
|
2007-07-03 13:37:43 +00:00
|
|
|
obj-$(CONFIG_MIPS_MT_FPAFF) += mips-mt-fpaff.o
|
2006-04-05 08:45:45 +00:00
|
|
|
obj-$(CONFIG_MIPS_MT_SMP) += smp-mt.o
|
2008-04-28 16:14:26 +00:00
|
|
|
obj-$(CONFIG_MIPS_CMP) += smp-cmp.o
|
2014-01-15 10:31:53 +00:00
|
|
|
obj-$(CONFIG_MIPS_CPS) += smp-cps.o cps-vec.o
|
2014-01-15 10:31:50 +00:00
|
|
|
obj-$(CONFIG_MIPS_GIC_IPI) += smp-gic.o
|
2007-09-13 11:32:02 +00:00
|
|
|
obj-$(CONFIG_CPU_MIPSR2) += spram.o
|
2005-08-17 17:44:08 +00:00
|
|
|
|
2005-07-14 15:57:16 +00:00
|
|
|
obj-$(CONFIG_MIPS_VPE_LOADER) += vpe.o
|
2013-10-30 20:52:07 +00:00
|
|
|
obj-$(CONFIG_MIPS_VPE_LOADER_CMP) += vpe-cmp.o
|
2013-10-30 20:52:06 +00:00
|
|
|
obj-$(CONFIG_MIPS_VPE_LOADER_MT) += vpe-mt.o
|
2013-01-22 11:59:30 +00:00
|
|
|
obj-$(CONFIG_MIPS_VPE_APSP_API) += rtlx.o
|
2014-01-01 15:29:03 +00:00
|
|
|
obj-$(CONFIG_MIPS_VPE_APSP_API_CMP) += rtlx-cmp.o
|
2014-01-01 15:26:46 +00:00
|
|
|
obj-$(CONFIG_MIPS_VPE_APSP_API_MT) += rtlx-mt.o
|
2005-07-14 15:57:16 +00:00
|
|
|
|
2005-04-16 22:20:36 +00:00
|
|
|
obj-$(CONFIG_I8259) += i8259.o
|
|
|
|
|
obj-$(CONFIG_IRQ_CPU) += irq_cpu.o
|
|
|
|
|
obj-$(CONFIG_IRQ_CPU_RM7K) += irq-rm7000.o
|
2008-07-15 17:44:34 +00:00
|
|
|
obj-$(CONFIG_MIPS_MSC) += irq-msc01.o
|
2007-08-02 14:35:53 +00:00
|
|
|
obj-$(CONFIG_IRQ_TXX9) += irq_txx9.o
|
2007-09-13 14:51:26 +00:00
|
|
|
obj-$(CONFIG_IRQ_GT641XX) += irq-gt641xx.o
|
2008-04-28 16:14:26 +00:00
|
|
|
obj-$(CONFIG_IRQ_GIC) += irq-gic.o
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2010-08-03 18:22:20 +00:00
|
|
|
obj-$(CONFIG_KPROBES) += kprobes.o
|
2005-09-03 22:56:16 +00:00
|
|
|
obj-$(CONFIG_32BIT) += scall32-o32.o
|
|
|
|
|
obj-$(CONFIG_64BIT) += scall64-64.o
|
2007-02-15 01:53:00 +00:00
|
|
|
obj-$(CONFIG_MIPS32_COMPAT) += linux32.o ptrace32.o signal32.o
|
2005-04-16 22:20:36 +00:00
|
|
|
obj-$(CONFIG_MIPS32_N32) += binfmt_elfn32.o scall64-n32.o signal_n32.o
|
2007-02-15 01:53:00 +00:00
|
|
|
obj-$(CONFIG_MIPS32_O32) += binfmt_elfo32.o scall64-o32.o
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2008-07-29 20:58:53 +00:00
|
|
|
obj-$(CONFIG_KGDB) += kgdb.o
|
2005-04-16 22:20:36 +00:00
|
|
|
obj-$(CONFIG_PROC_FS) += proc.o
|
|
|
|
|
|
2005-09-03 22:56:16 +00:00
|
|
|
obj-$(CONFIG_64BIT) += cpu-bugs64.o
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2007-10-11 22:46:10 +00:00
|
|
|
obj-$(CONFIG_I8253) += i8253.o
|
2006-03-14 05:11:50 +00:00
|
|
|
|
2008-04-04 15:55:41 +00:00
|
|
|
obj-$(CONFIG_GPIO_TXX9) += gpio_txx9.o
|
|
|
|
|
|
2012-10-11 16:14:58 +00:00
|
|
|
obj-$(CONFIG_KEXEC) += machine_kexec.o relocate_kernel.o crash.o
|
|
|
|
|
obj-$(CONFIG_CRASH_DUMP) += crash_dump.o
|
2007-03-01 11:56:43 +00:00
|
|
|
obj-$(CONFIG_EARLY_PRINTK) += early_printk.o
|
2010-02-08 11:59:39 +00:00
|
|
|
obj-$(CONFIG_EARLY_PRINTK_8250) += early_printk_8250.o
|
2010-02-16 23:26:35 +00:00
|
|
|
obj-$(CONFIG_SPINLOCK_TEST) += spinlock_test.o
|
2010-11-23 15:06:25 +00:00
|
|
|
obj-$(CONFIG_MIPS_MACHINE) += mips_machine.o
|
2006-10-18 13:14:55 +00:00
|
|
|
|
2012-10-02 14:42:36 +00:00
|
|
|
CFLAGS_cpu-bugs64.o = $(shell if $(CC) $(KBUILD_CFLAGS) -Wa,-mdaddi -c -o /dev/null -x c /dev/null >/dev/null 2>&1; then echo "-DHAVE_AS_SET_DADDI"; fi)
|
2007-07-10 16:33:01 +00:00
|
|
|
|
|
|
|
|
obj-$(CONFIG_HAVE_STD_PC_SERIAL_PORT) += 8250-platform.o
|
2007-07-30 10:48:58 +00:00
|
|
|
|
2011-09-24 00:29:55 +00:00
|
|
|
obj-$(CONFIG_PERF_EVENTS) += perf_event.o
|
|
|
|
|
obj-$(CONFIG_HW_PERF_EVENTS) += perf_event_mipsxx.o
|
2010-10-12 11:37:22 +00:00
|
|
|
|
2010-12-28 21:26:23 +00:00
|
|
|
obj-$(CONFIG_JUMP_LABEL) += jump_label.o
|
|
|
|
|
|
2014-01-15 10:31:51 +00:00
|
|
|
obj-$(CONFIG_MIPS_CM) += mips-cm.o
|
2014-01-15 10:31:52 +00:00
|
|
|
obj-$(CONFIG_MIPS_CPC) += mips-cpc.o
|
2014-01-15 10:31:51 +00:00
|
|
|
|
2014-03-04 10:11:39 +00:00
|
|
|
obj-$(CONFIG_CPU_PM) += pm.o
|
2014-04-14 10:00:56 +00:00
|
|
|
obj-$(CONFIG_MIPS_CPS_PM) += pm-cps.o
|
2014-03-04 10:11:39 +00:00
|
|
|
|
2013-01-03 19:01:52 +00:00
|
|
|
#
|
MIPS: Fix code generation for non-DSP capable CPUs
Commit 32a7ede (MIPS: dsp: Add assembler support for DSP ASEs) has
enabled the use of DSP ASE specific instructions such as rddsp and wrdsp
under the idea that all code path that will make use of these two
instructions are properly checking for cpu_has_dsp to ensure that the
particular CPU we are running on *actually* supports DSP ASE.
This commit actually causes the following oops on QEMU Malta emulating a
MIPS 24Kc without the DSP ASE implemented:
[ 7.960000] Reserved instruction in kernel
[ 7.960000] Cpu 0
[ 7.960000] $ 0 : 00000000 00000000 00000014 00000005
[ 7.960000] $ 4 : 8fc2de48 00000001 00000000 8f59ddb0
[ 7.960000] $ 8 : 8f5ceec4 00000018 00000c00 00800000
[ 7.960000] $12 : 00000100 00000200 00000000 00457b84
[ 7.960000] $16 : 00000000 8fc2ba78 8f4ec980 00000001
[ 7.960000] $20 : 80418f90 00000000 00000000 000002dd
[ 7.960000] $24 : 0000009c 7730d7b8
[ 7.960000] $28 : 8f59c000 8f59dd38 00000001 80104248
[ 7.960000] Hi : 0000001d
[ 7.960000] Lo : 0000000b
[ 7.960000] epc : 801041ec thread_saved_pc+0x2c/0x38
[ 7.960000] Not tainted
[ 7.960000] ra : 80104248 get_wchan+0x48/0xac
[ 7.960000] Status: 1000b703 KERNEL EXL IE
[ 7.960000] Cause : 10800028
[ 7.960000] PrId : 00019300 (MIPS 24Kc)
[ 7.960000] Modules linked in:
[ 7.960000] Process killall (pid: 1574, threadinfo=8f59c000,
task=8fd14558, tls=773aa440)
[ 7.960000] Stack : 8fc2ba78 8012b008 0000000c 0000001d 00000000
00000000 8f58a380
8f58a380 8fc2ba78 80202668 8f59de78 8f468600 8f59de28
801b2a3c 8f59df00 8f98ba20 74696e69
8f468600 8f59de28 801b7308 0081c007 00000000 00000000
00000000 00000000 00000000 00000000
00000000 8fc2bbb4 00000001 0000001d 0000000b 77f038cc
7fe80648 ffffffff ffffffff 00000000
00000001 0016e000 00000000 ...
[ 7.960000] Call Trace:
[ 7.960000] [<801041ec>] thread_saved_pc+0x2c/0x38
[ 7.960000] [<80104248>] get_wchan+0x48/0xac
The disassembly of thread_saved_pc points to the following:
000006d0 <thread_saved_pc>:
6d0: 8c820208 lw v0,520(a0)
6d4: 3c030000 lui v1,0x0
6d8: 24630000 addiu v1,v1,0
6dc: 10430008 beq v0,v1,700 <thread_saved_pc+0x30>
6e0: 00000000 nop
6e4: 3c020000 lui v0,0x0
6e8: 8c43000c lw v1,12(v0)
6ec: 04620004 bltzl v1,700 <thread_saved_pc+0x30>
6f0: 00001021 move v0,zero
6f4: 8c840200 lw a0,512(a0)
6f8: 00031080 sll v0,v1,0x2
6fc: 7c44100a lwx v0,a0(v0) <------------
700: 03e00008 jr ra
704: 00000000 nop
If we specifically disable -mdsp/-mdspr2 for arch/mips/kernel/process.o,
we get the following (non-crashing) assembly:
00000708 <thread_saved_pc>:
708: 8c820208 lw v0,520(a0)
70c: 3c030000 lui v1,0x0
710: 24630000 addiu v1,v1,0
714: 10430009 beq v0,v1,73c <thread_saved_pc+0x34>
718: 00000000 nop
71c: 3c020000 lui v0,0x0
720: 8c42000c lw v0,12(v0)
724: 04420005 bltzl v0,73c <thread_saved_pc+0x34>
728: 00001021 move v0,zero
72c: 8c830200 lw v1,512(a0)
730: 00021080 sll v0,v0,0x2
734: 00431021 addu v0,v0,v1
738: 8c420000 lw v0,0(v0)
73c: 03e00008 jr ra
740: 00000000 nop
The specific line that leads a different assembly being produced is:
unsigned long thread_saved_pc(struct task_struct *tsk)
...
return ((unsigned long *)t->reg29)[schedule_mfi.pc_offset]; <---
The problem here is that the compiler was given the right to use DSP
instructions with the -mdsp / -mdspr2 command-line switches and
performed some optimization for us and used DSP ASE instructions where
we are not checking that the running CPU actually supports DSP ASE.
This patch fixes the issue by partially reverting commit 32a7ede for
arch/mips/kernel/Makefile in order to remove the -mdsp / -mdspr2
compiler command-line switches such that we are now guaranteed that the
compiler will not optimize using DSP ASE reserved instructions. We also
need to fixup the rddsp/wrdsp and m{t,h}{hi,lo}{0,1,2,3} macros in
arch/mips/include/asm/mipsregs.h to tell the assembler that we are going
to explicitely use DSP ASE reserved instructions. The comment in
arch/mips/kernel/Makefile is also updated to reflect that.
Signed-off-by: Florian Fainelli <florian@openwrt.org>
Acked-by: Steven J. Hill <Steven.Hill@imgtec.com>
Cc: linux-mips@linux-mips.org
Cc: blogic@openwrt.org
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
2013-03-18 15:56:10 +00:00
|
|
|
# DSP ASE supported for MIPS32 or MIPS64 Release 2 cores only. It is not
|
|
|
|
|
# safe to unconditionnaly use the assembler -mdsp / -mdspr2 switches
|
|
|
|
|
# here because the compiler may use DSP ASE instructions (such as lwx) in
|
|
|
|
|
# code paths where we cannot check that the CPU we are running on supports it.
|
|
|
|
|
# Proper abstraction using HAVE_AS_DSP and macros is done in
|
|
|
|
|
# arch/mips/include/asm/mipsregs.h.
|
2013-01-03 19:01:52 +00:00
|
|
|
#
|
|
|
|
|
ifeq ($(CONFIG_CPU_MIPSR2), y)
|
|
|
|
|
CFLAGS_DSP = -DHAVE_AS_DSP
|
|
|
|
|
|
|
|
|
|
CFLAGS_signal.o = $(CFLAGS_DSP)
|
|
|
|
|
CFLAGS_signal32.o = $(CFLAGS_DSP)
|
|
|
|
|
CFLAGS_process.o = $(CFLAGS_DSP)
|
|
|
|
|
CFLAGS_branch.o = $(CFLAGS_DSP)
|
|
|
|
|
CFLAGS_ptrace.o = $(CFLAGS_DSP)
|
|
|
|
|
endif
|
|
|
|
|
|
2009-12-17 01:57:36 +00:00
|
|
|
CPPFLAGS_vmlinux.lds := $(KBUILD_CFLAGS)
|
