2008-01-30 12:30:09 +00:00
|
|
|
/*
|
2005-04-16 22:20:36 +00:00
|
|
|
* Firmware replacement code.
|
2008-01-30 12:30:09 +00:00
|
|
|
*
|
2008-11-26 16:15:27 +00:00
|
|
|
* Work around broken BIOSes that don't set an aperture, only set the
|
|
|
|
* aperture in the AGP bridge, or set too small aperture.
|
|
|
|
*
|
2008-01-30 12:30:09 +00:00
|
|
|
* If all fails map the aperture over some low memory. This is cheaper than
|
|
|
|
* doing bounce buffering. The memory is lost. This is done at early boot
|
|
|
|
* because only the bootmem allocator can allocate 32+MB.
|
|
|
|
*
|
2005-04-16 22:20:36 +00:00
|
|
|
* Copyright 2002 Andi Kleen, SuSE Labs.
|
|
|
|
*/
|
|
|
|
#include <linux/kernel.h>
|
|
|
|
#include <linux/types.h>
|
|
|
|
#include <linux/init.h>
|
2010-12-18 00:58:40 +00:00
|
|
|
#include <linux/memblock.h>
|
2005-04-16 22:20:36 +00:00
|
|
|
#include <linux/mmzone.h>
|
|
|
|
#include <linux/pci_ids.h>
|
|
|
|
#include <linux/pci.h>
|
|
|
|
#include <linux/bitops.h>
|
2006-09-26 08:52:40 +00:00
|
|
|
#include <linux/ioport.h>
|
2008-03-13 22:05:41 +00:00
|
|
|
#include <linux/suspend.h>
|
2009-08-27 13:29:20 +00:00
|
|
|
#include <linux/kmemleak.h>
|
2005-04-16 22:20:36 +00:00
|
|
|
#include <asm/e820.h>
|
|
|
|
#include <asm/io.h>
|
2008-07-11 01:23:42 +00:00
|
|
|
#include <asm/iommu.h>
|
2007-10-24 10:49:47 +00:00
|
|
|
#include <asm/gart.h>
|
2005-04-16 22:20:36 +00:00
|
|
|
#include <asm/pci-direct.h>
|
2006-01-11 21:44:27 +00:00
|
|
|
#include <asm/dma.h>
|
2010-09-17 16:03:43 +00:00
|
|
|
#include <asm/amd_nb.h>
|
2009-11-10 10:46:14 +00:00
|
|
|
#include <asm/x86_init.h>
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2011-04-18 13:45:43 +00:00
|
|
|
/*
|
|
|
|
* Using 512M as goal, in case kexec will load kernel_big
|
|
|
|
* that will do the on-position decompress, and could overlap with
|
|
|
|
* with the gart aperture that is used.
|
|
|
|
* Sequence:
|
|
|
|
* kernel_small
|
|
|
|
* ==> kexec (with kdump trigger path or gart still enabled)
|
|
|
|
* ==> kernel_small (gart area become e820_reserved)
|
|
|
|
* ==> kexec (with kdump trigger path or gart still enabled)
|
|
|
|
* ==> kerne_big (uncompressed size will be big than 64M or 128M)
|
|
|
|
* So don't use 512M below as gart iommu, leave the space for kernel
|
|
|
|
* code for safe.
|
|
|
|
*/
|
|
|
|
#define GART_MIN_ADDR (512ULL << 20)
|
|
|
|
#define GART_MAX_ADDR (1ULL << 32)
|
|
|
|
|
2007-10-24 10:49:50 +00:00
|
|
|
int gart_iommu_aperture;
|
2008-03-13 10:03:58 +00:00
|
|
|
int gart_iommu_aperture_disabled __initdata;
|
|
|
|
int gart_iommu_aperture_allowed __initdata;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
|
|
|
int fallback_aper_order __initdata = 1; /* 64MB */
|
2008-03-13 10:03:58 +00:00
|
|
|
int fallback_aper_force __initdata;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
|
|
|
int fix_aperture __initdata = 1;
|
|
|
|
|
2006-09-26 08:52:40 +00:00
|
|
|
static struct resource gart_resource = {
|
|
|
|
.name = "GART",
|
|
|
|
.flags = IORESOURCE_MEM,
|
|
|
|
};
|
|
|
|
|
|
|
|
static void __init insert_aperture_resource(u32 aper_base, u32 aper_size)
|
|
|
|
{
|
|
|
|
gart_resource.start = aper_base;
|
|
|
|
gart_resource.end = aper_base + aper_size - 1;
|
|
|
|
insert_resource(&iomem_resource, &gart_resource);
|
|
|
|
}
|
|
|
|
|
2005-06-08 22:49:25 +00:00
|
|
|
/* This code runs before the PCI subsystem is initialized, so just
|
|
|
|
access the northbridge directly. */
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2008-01-30 12:30:09 +00:00
|
|
|
static u32 __init allocate_aperture(void)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
|
|
|
u32 aper_size;
|
2010-12-18 00:58:40 +00:00
|
|
|
unsigned long addr;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2008-04-15 03:40:37 +00:00
|
|
|
/* aper_size should <= 1G */
|
|
|
|
if (fallback_aper_order > 5)
|
|
|
|
fallback_aper_order = 5;
|
2008-01-30 12:30:09 +00:00
|
|
|
aper_size = (32 * 1024 * 1024) << fallback_aper_order;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2008-01-30 12:30:09 +00:00
|
|
|
/*
|
|
|
|
* Aperture has to be naturally aligned. This means a 2GB aperture
|
|
|
|
* won't have much chance of finding a place in the lower 4GB of
|
|
|
|
* memory. Unfortunately we cannot move it up because that would
|
|
|
|
* make the IOMMU useless.
|
2005-04-16 22:20:36 +00:00
|
|
|
*/
|
2011-04-18 13:45:43 +00:00
|
|
|
addr = memblock_find_in_range(GART_MIN_ADDR, GART_MAX_ADDR,
|
|
|
|
aper_size, aper_size);
|
2011-07-12 07:58:09 +00:00
|
|
|
if (!addr || addr + aper_size > GART_MAX_ADDR) {
|
2010-12-18 00:58:40 +00:00
|
|
|
printk(KERN_ERR
|
|
|
|
"Cannot allocate aperture memory hole (%lx,%uK)\n",
|
|
|
|
addr, aper_size>>10);
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
memblock_x86_reserve_range(addr, addr + aper_size, "aperture64");
|
2009-08-27 13:29:20 +00:00
|
|
|
/*
|
|
|
|
* Kmemleak should not scan this block as it may not be mapped via the
|
|
|
|
* kernel direct mapping.
|
|
|
|
*/
|
2010-12-18 00:58:40 +00:00
|
|
|
kmemleak_ignore(phys_to_virt(addr));
|
2008-01-30 12:30:10 +00:00
|
|
|
printk(KERN_INFO "Mapping aperture over %d KB of RAM @ %lx\n",
|
2010-12-18 00:58:40 +00:00
|
|
|
aper_size >> 10, addr);
|
|
|
|
insert_aperture_resource((u32)addr, aper_size);
|
|
|
|
register_nosave_region(addr >> PAGE_SHIFT,
|
|
|
|
(addr+aper_size) >> PAGE_SHIFT);
|
2008-01-30 12:30:09 +00:00
|
|
|
|
2010-12-18 00:58:40 +00:00
|
|
|
return (u32)addr;
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
|
2005-06-08 22:49:25 +00:00
|
|
|
/* Find a PCI capability */
|
2008-05-27 16:03:56 +00:00
|
|
|
static u32 __init find_cap(int bus, int slot, int func, int cap)
|
2008-01-30 12:30:09 +00:00
|
|
|
{
|
2005-04-16 22:20:36 +00:00
|
|
|
int bytes;
|
2008-01-30 12:30:09 +00:00
|
|
|
u8 pos;
|
|
|
|
|
2008-04-19 08:31:11 +00:00
|
|
|
if (!(read_pci_config_16(bus, slot, func, PCI_STATUS) &
|
2008-01-30 12:30:09 +00:00
|
|
|
PCI_STATUS_CAP_LIST))
|
2005-04-16 22:20:36 +00:00
|
|
|
return 0;
|
2008-01-30 12:30:09 +00:00
|
|
|
|
2008-04-19 08:31:11 +00:00
|
|
|
pos = read_pci_config_byte(bus, slot, func, PCI_CAPABILITY_LIST);
|
2008-01-30 12:30:09 +00:00
|
|
|
for (bytes = 0; bytes < 48 && pos >= 0x40; bytes++) {
|
2005-04-16 22:20:36 +00:00
|
|
|
u8 id;
|
2008-01-30 12:30:09 +00:00
|
|
|
|
|
|
|
pos &= ~3;
|
2008-04-19 08:31:11 +00:00
|
|
|
id = read_pci_config_byte(bus, slot, func, pos+PCI_CAP_LIST_ID);
|
2005-04-16 22:20:36 +00:00
|
|
|
if (id == 0xff)
|
|
|
|
break;
|
2008-01-30 12:30:09 +00:00
|
|
|
if (id == cap)
|
|
|
|
return pos;
|
2008-04-19 08:31:11 +00:00
|
|
|
pos = read_pci_config_byte(bus, slot, func,
|
2008-01-30 12:30:09 +00:00
|
|
|
pos+PCI_CAP_LIST_NEXT);
|
|
|
|
}
|
2005-04-16 22:20:36 +00:00
|
|
|
return 0;
|
2008-01-30 12:30:09 +00:00
|
|
|
}
|
2005-04-16 22:20:36 +00:00
|
|
|
|
|
|
|
/* Read a standard AGPv3 bridge header */
|
2008-05-27 16:03:56 +00:00
|
|
|
static u32 __init read_agp(int bus, int slot, int func, int cap, u32 *order)
|
2008-01-30 12:30:09 +00:00
|
|
|
{
|
2005-04-16 22:20:36 +00:00
|
|
|
u32 apsize;
|
|
|
|
u32 apsizereg;
|
|
|
|
int nbits;
|
|
|
|
u32 aper_low, aper_hi;
|
|
|
|
u64 aper;
|
2008-04-13 08:11:41 +00:00
|
|
|
u32 old_order;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2008-04-19 08:31:11 +00:00
|
|
|
printk(KERN_INFO "AGP bridge at %02x:%02x:%02x\n", bus, slot, func);
|
|
|
|
apsizereg = read_pci_config_16(bus, slot, func, cap + 0x14);
|
2005-04-16 22:20:36 +00:00
|
|
|
if (apsizereg == 0xffffffff) {
|
2008-01-30 12:30:10 +00:00
|
|
|
printk(KERN_ERR "APSIZE in AGP bridge unreadable\n");
|
2005-04-16 22:20:36 +00:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2008-04-13 08:11:41 +00:00
|
|
|
/* old_order could be the value from NB gart setting */
|
|
|
|
old_order = *order;
|
|
|
|
|
2005-04-16 22:20:36 +00:00
|
|
|
apsize = apsizereg & 0xfff;
|
|
|
|
/* Some BIOS use weird encodings not in the AGPv3 table. */
|
2008-01-30 12:30:09 +00:00
|
|
|
if (apsize & 0xff)
|
|
|
|
apsize |= 0xf00;
|
2005-04-16 22:20:36 +00:00
|
|
|
nbits = hweight16(apsize);
|
|
|
|
*order = 7 - nbits;
|
|
|
|
if ((int)*order < 0) /* < 32MB */
|
|
|
|
*order = 0;
|
2008-01-30 12:30:09 +00:00
|
|
|
|
2008-04-19 08:31:11 +00:00
|
|
|
aper_low = read_pci_config(bus, slot, func, 0x10);
|
|
|
|
aper_hi = read_pci_config(bus, slot, func, 0x14);
|
2005-04-16 22:20:36 +00:00
|
|
|
aper = (aper_low & ~((1<<22)-1)) | ((u64)aper_hi << 32);
|
|
|
|
|
2008-04-13 08:11:41 +00:00
|
|
|
/*
|
|
|
|
* On some sick chips, APSIZE is 0. It means it wants 4G
|
|
|
|
* so let double check that order, and lets trust AMD NB settings:
|
|
|
|
*/
|
2008-04-14 01:42:31 +00:00
|
|
|
printk(KERN_INFO "Aperture from AGP @ %Lx old size %u MB\n",
|
|
|
|
aper, 32 << old_order);
|
|
|
|
if (aper + (32ULL<<(20 + *order)) > 0x100000000ULL) {
|
2008-04-13 08:11:41 +00:00
|
|
|
printk(KERN_INFO "Aperture size %u MB (APSIZE %x) is not right, using settings from NB\n",
|
|
|
|
32 << *order, apsizereg);
|
|
|
|
*order = old_order;
|
|
|
|
}
|
|
|
|
|
2008-01-30 12:30:10 +00:00
|
|
|
printk(KERN_INFO "Aperture from AGP @ %Lx size %u MB (APSIZE %x)\n",
|
|
|
|
aper, 32 << *order, apsizereg);
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2008-04-14 01:42:31 +00:00
|
|
|
if (!aperture_valid(aper, (32*1024*1024) << *order, 32<<20))
|
2008-01-30 12:30:09 +00:00
|
|
|
return 0;
|
|
|
|
return (u32)aper;
|
|
|
|
}
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2008-01-30 12:30:09 +00:00
|
|
|
/*
|
|
|
|
* Look for an AGP bridge. Windows only expects the aperture in the
|
|
|
|
* AGP bridge and some BIOS forget to initialize the Northbridge too.
|
|
|
|
* Work around this here.
|
|
|
|
*
|
|
|
|
* Do an PCI bus scan by hand because we're running before the PCI
|
|
|
|
* subsystem.
|
|
|
|
*
|
2010-10-29 15:14:30 +00:00
|
|
|
* All AMD AGP bridges are AGPv3 compliant, so we can do this scan
|
2008-01-30 12:30:09 +00:00
|
|
|
* generically. It's probably overkill to always scan all slots because
|
|
|
|
* the AGP bridges should be always an own bus on the HT hierarchy,
|
|
|
|
* but do it here for future safety.
|
|
|
|
*/
|
2008-05-27 16:03:56 +00:00
|
|
|
static u32 __init search_agp_bridge(u32 *order, int *valid_agp)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
2008-04-19 08:31:11 +00:00
|
|
|
int bus, slot, func;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
|
|
|
/* Poor man's PCI discovery */
|
2008-04-19 08:31:11 +00:00
|
|
|
for (bus = 0; bus < 256; bus++) {
|
2008-01-30 12:30:09 +00:00
|
|
|
for (slot = 0; slot < 32; slot++) {
|
|
|
|
for (func = 0; func < 8; func++) {
|
2005-04-16 22:20:36 +00:00
|
|
|
u32 class, cap;
|
|
|
|
u8 type;
|
2008-04-19 08:31:11 +00:00
|
|
|
class = read_pci_config(bus, slot, func,
|
2005-04-16 22:20:36 +00:00
|
|
|
PCI_CLASS_REVISION);
|
|
|
|
if (class == 0xffffffff)
|
2008-01-30 12:30:09 +00:00
|
|
|
break;
|
|
|
|
|
|
|
|
switch (class >> 16) {
|
2005-04-16 22:20:36 +00:00
|
|
|
case PCI_CLASS_BRIDGE_HOST:
|
|
|
|
case PCI_CLASS_BRIDGE_OTHER: /* needed? */
|
|
|
|
/* AGP bridge? */
|
2008-04-19 08:31:11 +00:00
|
|
|
cap = find_cap(bus, slot, func,
|
2008-01-30 12:30:09 +00:00
|
|
|
PCI_CAP_ID_AGP);
|
2005-04-16 22:20:36 +00:00
|
|
|
if (!cap)
|
|
|
|
break;
|
2008-01-30 12:30:09 +00:00
|
|
|
*valid_agp = 1;
|
2008-04-19 08:31:11 +00:00
|
|
|
return read_agp(bus, slot, func, cap,
|
2008-01-30 12:30:09 +00:00
|
|
|
order);
|
|
|
|
}
|
|
|
|
|
2005-04-16 22:20:36 +00:00
|
|
|
/* No multi-function device? */
|
2008-04-19 08:31:11 +00:00
|
|
|
type = read_pci_config_byte(bus, slot, func,
|
2005-04-16 22:20:36 +00:00
|
|
|
PCI_HEADER_TYPE);
|
|
|
|
if (!(type & 0x80))
|
|
|
|
break;
|
2008-01-30 12:30:09 +00:00
|
|
|
}
|
|
|
|
}
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
2008-01-30 12:30:10 +00:00
|
|
|
printk(KERN_INFO "No AGP bridge found\n");
|
2008-01-30 12:30:09 +00:00
|
|
|
|
2005-04-16 22:20:36 +00:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
x86: disable the GART early, 64-bit
For K8 system: 4G RAM with memory hole remapping enabled, or more than
4G RAM installed.
when try to use kexec second kernel, and the first doesn't include
gart_shutdown. the second kernel could have different aper position than
the first kernel. and second kernel could use that hole as RAM that is
still used by GART set by the first kernel. esp. when try to kexec
2.6.24 with sparse mem enable from previous kernel (from RHEL 5 or SLES
10). the new kernel will use aper by GART (set by first kernel) for
vmemmap. and after new kernel setting one new GART. the position will be
real RAM. the _mapcount set is lost.
Bad page state in process 'swapper'
page:ffffe2000e600020 flags:0x0000000000000000 mapping:0000000000000000 mapcount:1 count:0
Trying to fix it up, but a reboot is needed
Backtrace:
Pid: 0, comm: swapper Not tainted 2.6.24-rc7-smp-gcdf71a10-dirty #13
Call Trace:
[<ffffffff8026401f>] bad_page+0x63/0x8d
[<ffffffff80264169>] __free_pages_ok+0x7c/0x2a5
[<ffffffff80ba75d1>] free_all_bootmem_core+0xd0/0x198
[<ffffffff80ba3a42>] numa_free_all_bootmem+0x3b/0x76
[<ffffffff80ba3461>] mem_init+0x3b/0x152
[<ffffffff80b959d3>] start_kernel+0x236/0x2c2
[<ffffffff80b9511a>] _sinittext+0x11a/0x121
and
[ffffe2000e600000-ffffe2000e7fffff] PMD ->ffff81001c200000 on node 0
phys addr is : 0x1c200000
RHEL 5.1 kernel -53 said:
PCI-DMA: aperture base @ 1c000000 size 65536 KB
new kernel said:
Mapping aperture over 65536 KB of RAM @ 3c000000
So could try to disable that GART if possible.
According to Ingo
> hm, i'm wondering, instead of modifying the GART, why dont we simply
> _detect_ whatever GART settings we have inherited, and propagate that
> into our e820 maps? I.e. if there's inconsistency, then punch that out
> from the memory maps and just dont use that memory.
>
> that way it would not matter whether the GART settings came from a [old
> or crashing] Linux kernel that has not called gart_iommu_shutdown(), or
> whether it's a BIOS that has set up an aperture hole inconsistent with
> the memory map it passed. (or the memory map we _think_ i tried to pass
> us)
>
> it would also be more robust to only read and do a memory map quirk
> based on that, than actively trying to change the GART so early in the
> bootup. Later on we have to re-enable the GART _anyway_ and have to
> punch a hole for it.
>
> and as a bonus, we would have shored up our defenses against crappy
> BIOSes as well.
add e820 modification for gart inconsistent setting.
gart_fix_e820=off could be used to disable e820 fix.
Signed-off-by: Yinghai Lu <yinghai.lu@sun.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
2008-01-30 12:33:09 +00:00
|
|
|
static int gart_fix_e820 __initdata = 1;
|
|
|
|
|
|
|
|
static int __init parse_gart_mem(char *p)
|
|
|
|
{
|
|
|
|
if (!p)
|
|
|
|
return -EINVAL;
|
|
|
|
|
|
|
|
if (!strncmp(p, "off", 3))
|
|
|
|
gart_fix_e820 = 0;
|
|
|
|
else if (!strncmp(p, "on", 2))
|
|
|
|
gart_fix_e820 = 1;
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
early_param("gart_fix_e820", parse_gart_mem);
|
|
|
|
|
|
|
|
void __init early_gart_iommu_check(void)
|
|
|
|
{
|
|
|
|
/*
|
|
|
|
* in case it is enabled before, esp for kexec/kdump,
|
|
|
|
* previous kernel already enable that. memset called
|
|
|
|
* by allocate_aperture/__alloc_bootmem_nopanic cause restart.
|
|
|
|
* or second kernel have different position for GART hole. and new
|
|
|
|
* kernel could use hole as RAM that is still used by GART set by
|
|
|
|
* first kernel
|
|
|
|
* or BIOS forget to put that in reserved.
|
|
|
|
* try to update e820 to make that region as reserved.
|
|
|
|
*/
|
2010-07-20 22:19:49 +00:00
|
|
|
u32 agp_aper_order = 0;
|
2009-12-14 02:52:15 +00:00
|
|
|
int i, fix, slot, valid_agp = 0;
|
x86: disable the GART early, 64-bit
For K8 system: 4G RAM with memory hole remapping enabled, or more than
4G RAM installed.
when try to use kexec second kernel, and the first doesn't include
gart_shutdown. the second kernel could have different aper position than
the first kernel. and second kernel could use that hole as RAM that is
still used by GART set by the first kernel. esp. when try to kexec
2.6.24 with sparse mem enable from previous kernel (from RHEL 5 or SLES
10). the new kernel will use aper by GART (set by first kernel) for
vmemmap. and after new kernel setting one new GART. the position will be
real RAM. the _mapcount set is lost.
Bad page state in process 'swapper'
page:ffffe2000e600020 flags:0x0000000000000000 mapping:0000000000000000 mapcount:1 count:0
Trying to fix it up, but a reboot is needed
Backtrace:
Pid: 0, comm: swapper Not tainted 2.6.24-rc7-smp-gcdf71a10-dirty #13
Call Trace:
[<ffffffff8026401f>] bad_page+0x63/0x8d
[<ffffffff80264169>] __free_pages_ok+0x7c/0x2a5
[<ffffffff80ba75d1>] free_all_bootmem_core+0xd0/0x198
[<ffffffff80ba3a42>] numa_free_all_bootmem+0x3b/0x76
[<ffffffff80ba3461>] mem_init+0x3b/0x152
[<ffffffff80b959d3>] start_kernel+0x236/0x2c2
[<ffffffff80b9511a>] _sinittext+0x11a/0x121
and
[ffffe2000e600000-ffffe2000e7fffff] PMD ->ffff81001c200000 on node 0
phys addr is : 0x1c200000
RHEL 5.1 kernel -53 said:
PCI-DMA: aperture base @ 1c000000 size 65536 KB
new kernel said:
Mapping aperture over 65536 KB of RAM @ 3c000000
So could try to disable that GART if possible.
According to Ingo
> hm, i'm wondering, instead of modifying the GART, why dont we simply
> _detect_ whatever GART settings we have inherited, and propagate that
> into our e820 maps? I.e. if there's inconsistency, then punch that out
> from the memory maps and just dont use that memory.
>
> that way it would not matter whether the GART settings came from a [old
> or crashing] Linux kernel that has not called gart_iommu_shutdown(), or
> whether it's a BIOS that has set up an aperture hole inconsistent with
> the memory map it passed. (or the memory map we _think_ i tried to pass
> us)
>
> it would also be more robust to only read and do a memory map quirk
> based on that, than actively trying to change the GART so early in the
> bootup. Later on we have to re-enable the GART _anyway_ and have to
> punch a hole for it.
>
> and as a bonus, we would have shored up our defenses against crappy
> BIOSes as well.
add e820 modification for gart inconsistent setting.
gart_fix_e820=off could be used to disable e820 fix.
Signed-off-by: Yinghai Lu <yinghai.lu@sun.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
2008-01-30 12:33:09 +00:00
|
|
|
u32 ctl;
|
|
|
|
u32 aper_size = 0, aper_order = 0, last_aper_order = 0;
|
|
|
|
u64 aper_base = 0, last_aper_base = 0;
|
aperture_64.c: duplicated code, buggy?
Hi!
void __init early_gart_iommu_check(void)
contains
for (num = 24; num < 32; num++) {
if (!early_is_k8_nb(read_pci_config(0, num, 3, 0x00)))
continue;
loop, with very similar loop duplicated in
void __init gart_iommu_hole_init(void)
. First copy of a loop seems to be buggy, too. It uses 0 as a "nothing
set" value, which may actually bite us in last_aper_enabled case
(because it may be often zero).
(Beware, it is hard to test this patch, because this code has about
2^8 different code paths, depending on hardware and cmdline settings).
Plus, the second loop does not check for consistency of
aper_enabled. Should it?
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
2008-05-26 18:40:47 +00:00
|
|
|
int aper_enabled = 0, last_aper_enabled = 0, last_valid = 0;
|
x86: disable the GART early, 64-bit
For K8 system: 4G RAM with memory hole remapping enabled, or more than
4G RAM installed.
when try to use kexec second kernel, and the first doesn't include
gart_shutdown. the second kernel could have different aper position than
the first kernel. and second kernel could use that hole as RAM that is
still used by GART set by the first kernel. esp. when try to kexec
2.6.24 with sparse mem enable from previous kernel (from RHEL 5 or SLES
10). the new kernel will use aper by GART (set by first kernel) for
vmemmap. and after new kernel setting one new GART. the position will be
real RAM. the _mapcount set is lost.
Bad page state in process 'swapper'
page:ffffe2000e600020 flags:0x0000000000000000 mapping:0000000000000000 mapcount:1 count:0
Trying to fix it up, but a reboot is needed
Backtrace:
Pid: 0, comm: swapper Not tainted 2.6.24-rc7-smp-gcdf71a10-dirty #13
Call Trace:
[<ffffffff8026401f>] bad_page+0x63/0x8d
[<ffffffff80264169>] __free_pages_ok+0x7c/0x2a5
[<ffffffff80ba75d1>] free_all_bootmem_core+0xd0/0x198
[<ffffffff80ba3a42>] numa_free_all_bootmem+0x3b/0x76
[<ffffffff80ba3461>] mem_init+0x3b/0x152
[<ffffffff80b959d3>] start_kernel+0x236/0x2c2
[<ffffffff80b9511a>] _sinittext+0x11a/0x121
and
[ffffe2000e600000-ffffe2000e7fffff] PMD ->ffff81001c200000 on node 0
phys addr is : 0x1c200000
RHEL 5.1 kernel -53 said:
PCI-DMA: aperture base @ 1c000000 size 65536 KB
new kernel said:
Mapping aperture over 65536 KB of RAM @ 3c000000
So could try to disable that GART if possible.
According to Ingo
> hm, i'm wondering, instead of modifying the GART, why dont we simply
> _detect_ whatever GART settings we have inherited, and propagate that
> into our e820 maps? I.e. if there's inconsistency, then punch that out
> from the memory maps and just dont use that memory.
>
> that way it would not matter whether the GART settings came from a [old
> or crashing] Linux kernel that has not called gart_iommu_shutdown(), or
> whether it's a BIOS that has set up an aperture hole inconsistent with
> the memory map it passed. (or the memory map we _think_ i tried to pass
> us)
>
> it would also be more robust to only read and do a memory map quirk
> based on that, than actively trying to change the GART so early in the
> bootup. Later on we have to re-enable the GART _anyway_ and have to
> punch a hole for it.
>
> and as a bonus, we would have shored up our defenses against crappy
> BIOSes as well.
add e820 modification for gart inconsistent setting.
gart_fix_e820=off could be used to disable e820 fix.
Signed-off-by: Yinghai Lu <yinghai.lu@sun.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
2008-01-30 12:33:09 +00:00
|
|
|
|
|
|
|
if (!early_pci_allowed())
|
|
|
|
return;
|
|
|
|
|
aperture_64.c: duplicated code, buggy?
Hi!
void __init early_gart_iommu_check(void)
contains
for (num = 24; num < 32; num++) {
if (!early_is_k8_nb(read_pci_config(0, num, 3, 0x00)))
continue;
loop, with very similar loop duplicated in
void __init gart_iommu_hole_init(void)
. First copy of a loop seems to be buggy, too. It uses 0 as a "nothing
set" value, which may actually bite us in last_aper_enabled case
(because it may be often zero).
(Beware, it is hard to test this patch, because this code has about
2^8 different code paths, depending on hardware and cmdline settings).
Plus, the second loop does not check for consistency of
aper_enabled. Should it?
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
2008-05-26 18:40:47 +00:00
|
|
|
/* This is mostly duplicate of iommu_hole_init */
|
2010-07-20 22:19:49 +00:00
|
|
|
search_agp_bridge(&agp_aper_order, &valid_agp);
|
2009-12-14 02:52:15 +00:00
|
|
|
|
x86: disable the GART early, 64-bit
For K8 system: 4G RAM with memory hole remapping enabled, or more than
4G RAM installed.
when try to use kexec second kernel, and the first doesn't include
gart_shutdown. the second kernel could have different aper position than
the first kernel. and second kernel could use that hole as RAM that is
still used by GART set by the first kernel. esp. when try to kexec
2.6.24 with sparse mem enable from previous kernel (from RHEL 5 or SLES
10). the new kernel will use aper by GART (set by first kernel) for
vmemmap. and after new kernel setting one new GART. the position will be
real RAM. the _mapcount set is lost.
Bad page state in process 'swapper'
page:ffffe2000e600020 flags:0x0000000000000000 mapping:0000000000000000 mapcount:1 count:0
Trying to fix it up, but a reboot is needed
Backtrace:
Pid: 0, comm: swapper Not tainted 2.6.24-rc7-smp-gcdf71a10-dirty #13
Call Trace:
[<ffffffff8026401f>] bad_page+0x63/0x8d
[<ffffffff80264169>] __free_pages_ok+0x7c/0x2a5
[<ffffffff80ba75d1>] free_all_bootmem_core+0xd0/0x198
[<ffffffff80ba3a42>] numa_free_all_bootmem+0x3b/0x76
[<ffffffff80ba3461>] mem_init+0x3b/0x152
[<ffffffff80b959d3>] start_kernel+0x236/0x2c2
[<ffffffff80b9511a>] _sinittext+0x11a/0x121
and
[ffffe2000e600000-ffffe2000e7fffff] PMD ->ffff81001c200000 on node 0
phys addr is : 0x1c200000
RHEL 5.1 kernel -53 said:
PCI-DMA: aperture base @ 1c000000 size 65536 KB
new kernel said:
Mapping aperture over 65536 KB of RAM @ 3c000000
So could try to disable that GART if possible.
According to Ingo
> hm, i'm wondering, instead of modifying the GART, why dont we simply
> _detect_ whatever GART settings we have inherited, and propagate that
> into our e820 maps? I.e. if there's inconsistency, then punch that out
> from the memory maps and just dont use that memory.
>
> that way it would not matter whether the GART settings came from a [old
> or crashing] Linux kernel that has not called gart_iommu_shutdown(), or
> whether it's a BIOS that has set up an aperture hole inconsistent with
> the memory map it passed. (or the memory map we _think_ i tried to pass
> us)
>
> it would also be more robust to only read and do a memory map quirk
> based on that, than actively trying to change the GART so early in the
> bootup. Later on we have to re-enable the GART _anyway_ and have to
> punch a hole for it.
>
> and as a bonus, we would have shored up our defenses against crappy
> BIOSes as well.
add e820 modification for gart inconsistent setting.
gart_fix_e820=off could be used to disable e820 fix.
Signed-off-by: Yinghai Lu <yinghai.lu@sun.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
2008-01-30 12:33:09 +00:00
|
|
|
fix = 0;
|
2011-01-10 16:20:23 +00:00
|
|
|
for (i = 0; amd_nb_bus_dev_ranges[i].dev_limit; i++) {
|
2008-04-19 08:31:11 +00:00
|
|
|
int bus;
|
|
|
|
int dev_base, dev_limit;
|
|
|
|
|
2011-01-10 16:20:23 +00:00
|
|
|
bus = amd_nb_bus_dev_ranges[i].bus;
|
|
|
|
dev_base = amd_nb_bus_dev_ranges[i].dev_base;
|
|
|
|
dev_limit = amd_nb_bus_dev_ranges[i].dev_limit;
|
2008-04-19 08:31:11 +00:00
|
|
|
|
|
|
|
for (slot = dev_base; slot < dev_limit; slot++) {
|
2010-10-29 15:14:30 +00:00
|
|
|
if (!early_is_amd_nb(read_pci_config(bus, slot, 3, 0x00)))
|
2008-04-19 08:31:11 +00:00
|
|
|
continue;
|
|
|
|
|
|
|
|
ctl = read_pci_config(bus, slot, 3, AMD64_GARTAPERTURECTL);
|
2010-09-03 16:39:39 +00:00
|
|
|
aper_enabled = ctl & GARTEN;
|
2008-04-19 08:31:11 +00:00
|
|
|
aper_order = (ctl >> 1) & 7;
|
|
|
|
aper_size = (32 * 1024 * 1024) << aper_order;
|
|
|
|
aper_base = read_pci_config(bus, slot, 3, AMD64_GARTAPERTUREBASE) & 0x7fff;
|
|
|
|
aper_base <<= 25;
|
|
|
|
|
aperture_64.c: duplicated code, buggy?
Hi!
void __init early_gart_iommu_check(void)
contains
for (num = 24; num < 32; num++) {
if (!early_is_k8_nb(read_pci_config(0, num, 3, 0x00)))
continue;
loop, with very similar loop duplicated in
void __init gart_iommu_hole_init(void)
. First copy of a loop seems to be buggy, too. It uses 0 as a "nothing
set" value, which may actually bite us in last_aper_enabled case
(because it may be often zero).
(Beware, it is hard to test this patch, because this code has about
2^8 different code paths, depending on hardware and cmdline settings).
Plus, the second loop does not check for consistency of
aper_enabled. Should it?
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
2008-05-26 18:40:47 +00:00
|
|
|
if (last_valid) {
|
|
|
|
if ((aper_order != last_aper_order) ||
|
|
|
|
(aper_base != last_aper_base) ||
|
|
|
|
(aper_enabled != last_aper_enabled)) {
|
|
|
|
fix = 1;
|
|
|
|
break;
|
|
|
|
}
|
2008-04-19 08:31:11 +00:00
|
|
|
}
|
aperture_64.c: duplicated code, buggy?
Hi!
void __init early_gart_iommu_check(void)
contains
for (num = 24; num < 32; num++) {
if (!early_is_k8_nb(read_pci_config(0, num, 3, 0x00)))
continue;
loop, with very similar loop duplicated in
void __init gart_iommu_hole_init(void)
. First copy of a loop seems to be buggy, too. It uses 0 as a "nothing
set" value, which may actually bite us in last_aper_enabled case
(because it may be often zero).
(Beware, it is hard to test this patch, because this code has about
2^8 different code paths, depending on hardware and cmdline settings).
Plus, the second loop does not check for consistency of
aper_enabled. Should it?
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
2008-05-26 18:40:47 +00:00
|
|
|
|
2008-04-19 08:31:11 +00:00
|
|
|
last_aper_order = aper_order;
|
|
|
|
last_aper_base = aper_base;
|
|
|
|
last_aper_enabled = aper_enabled;
|
aperture_64.c: duplicated code, buggy?
Hi!
void __init early_gart_iommu_check(void)
contains
for (num = 24; num < 32; num++) {
if (!early_is_k8_nb(read_pci_config(0, num, 3, 0x00)))
continue;
loop, with very similar loop duplicated in
void __init gart_iommu_hole_init(void)
. First copy of a loop seems to be buggy, too. It uses 0 as a "nothing
set" value, which may actually bite us in last_aper_enabled case
(because it may be often zero).
(Beware, it is hard to test this patch, because this code has about
2^8 different code paths, depending on hardware and cmdline settings).
Plus, the second loop does not check for consistency of
aper_enabled. Should it?
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
2008-05-26 18:40:47 +00:00
|
|
|
last_valid = 1;
|
x86: disable the GART early, 64-bit
For K8 system: 4G RAM with memory hole remapping enabled, or more than
4G RAM installed.
when try to use kexec second kernel, and the first doesn't include
gart_shutdown. the second kernel could have different aper position than
the first kernel. and second kernel could use that hole as RAM that is
still used by GART set by the first kernel. esp. when try to kexec
2.6.24 with sparse mem enable from previous kernel (from RHEL 5 or SLES
10). the new kernel will use aper by GART (set by first kernel) for
vmemmap. and after new kernel setting one new GART. the position will be
real RAM. the _mapcount set is lost.
Bad page state in process 'swapper'
page:ffffe2000e600020 flags:0x0000000000000000 mapping:0000000000000000 mapcount:1 count:0
Trying to fix it up, but a reboot is needed
Backtrace:
Pid: 0, comm: swapper Not tainted 2.6.24-rc7-smp-gcdf71a10-dirty #13
Call Trace:
[<ffffffff8026401f>] bad_page+0x63/0x8d
[<ffffffff80264169>] __free_pages_ok+0x7c/0x2a5
[<ffffffff80ba75d1>] free_all_bootmem_core+0xd0/0x198
[<ffffffff80ba3a42>] numa_free_all_bootmem+0x3b/0x76
[<ffffffff80ba3461>] mem_init+0x3b/0x152
[<ffffffff80b959d3>] start_kernel+0x236/0x2c2
[<ffffffff80b9511a>] _sinittext+0x11a/0x121
and
[ffffe2000e600000-ffffe2000e7fffff] PMD ->ffff81001c200000 on node 0
phys addr is : 0x1c200000
RHEL 5.1 kernel -53 said:
PCI-DMA: aperture base @ 1c000000 size 65536 KB
new kernel said:
Mapping aperture over 65536 KB of RAM @ 3c000000
So could try to disable that GART if possible.
According to Ingo
> hm, i'm wondering, instead of modifying the GART, why dont we simply
> _detect_ whatever GART settings we have inherited, and propagate that
> into our e820 maps? I.e. if there's inconsistency, then punch that out
> from the memory maps and just dont use that memory.
>
> that way it would not matter whether the GART settings came from a [old
> or crashing] Linux kernel that has not called gart_iommu_shutdown(), or
> whether it's a BIOS that has set up an aperture hole inconsistent with
> the memory map it passed. (or the memory map we _think_ i tried to pass
> us)
>
> it would also be more robust to only read and do a memory map quirk
> based on that, than actively trying to change the GART so early in the
> bootup. Later on we have to re-enable the GART _anyway_ and have to
> punch a hole for it.
>
> and as a bonus, we would have shored up our defenses against crappy
> BIOSes as well.
add e820 modification for gart inconsistent setting.
gart_fix_e820=off could be used to disable e820 fix.
Signed-off-by: Yinghai Lu <yinghai.lu@sun.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
2008-01-30 12:33:09 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
if (!fix && !aper_enabled)
|
|
|
|
return;
|
|
|
|
|
|
|
|
if (!aper_base || !aper_size || aper_base + aper_size > 0x100000000UL)
|
|
|
|
fix = 1;
|
|
|
|
|
|
|
|
if (gart_fix_e820 && !fix && aper_enabled) {
|
2008-06-21 10:50:47 +00:00
|
|
|
if (e820_any_mapped(aper_base, aper_base + aper_size,
|
|
|
|
E820_RAM)) {
|
2008-05-20 14:27:17 +00:00
|
|
|
/* reserve it, so we can reuse it in second kernel */
|
x86: disable the GART early, 64-bit
For K8 system: 4G RAM with memory hole remapping enabled, or more than
4G RAM installed.
when try to use kexec second kernel, and the first doesn't include
gart_shutdown. the second kernel could have different aper position than
the first kernel. and second kernel could use that hole as RAM that is
still used by GART set by the first kernel. esp. when try to kexec
2.6.24 with sparse mem enable from previous kernel (from RHEL 5 or SLES
10). the new kernel will use aper by GART (set by first kernel) for
vmemmap. and after new kernel setting one new GART. the position will be
real RAM. the _mapcount set is lost.
Bad page state in process 'swapper'
page:ffffe2000e600020 flags:0x0000000000000000 mapping:0000000000000000 mapcount:1 count:0
Trying to fix it up, but a reboot is needed
Backtrace:
Pid: 0, comm: swapper Not tainted 2.6.24-rc7-smp-gcdf71a10-dirty #13
Call Trace:
[<ffffffff8026401f>] bad_page+0x63/0x8d
[<ffffffff80264169>] __free_pages_ok+0x7c/0x2a5
[<ffffffff80ba75d1>] free_all_bootmem_core+0xd0/0x198
[<ffffffff80ba3a42>] numa_free_all_bootmem+0x3b/0x76
[<ffffffff80ba3461>] mem_init+0x3b/0x152
[<ffffffff80b959d3>] start_kernel+0x236/0x2c2
[<ffffffff80b9511a>] _sinittext+0x11a/0x121
and
[ffffe2000e600000-ffffe2000e7fffff] PMD ->ffff81001c200000 on node 0
phys addr is : 0x1c200000
RHEL 5.1 kernel -53 said:
PCI-DMA: aperture base @ 1c000000 size 65536 KB
new kernel said:
Mapping aperture over 65536 KB of RAM @ 3c000000
So could try to disable that GART if possible.
According to Ingo
> hm, i'm wondering, instead of modifying the GART, why dont we simply
> _detect_ whatever GART settings we have inherited, and propagate that
> into our e820 maps? I.e. if there's inconsistency, then punch that out
> from the memory maps and just dont use that memory.
>
> that way it would not matter whether the GART settings came from a [old
> or crashing] Linux kernel that has not called gart_iommu_shutdown(), or
> whether it's a BIOS that has set up an aperture hole inconsistent with
> the memory map it passed. (or the memory map we _think_ i tried to pass
> us)
>
> it would also be more robust to only read and do a memory map quirk
> based on that, than actively trying to change the GART so early in the
> bootup. Later on we have to re-enable the GART _anyway_ and have to
> punch a hole for it.
>
> and as a bonus, we would have shored up our defenses against crappy
> BIOSes as well.
add e820 modification for gart inconsistent setting.
gart_fix_e820=off could be used to disable e820 fix.
Signed-off-by: Yinghai Lu <yinghai.lu@sun.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
2008-01-30 12:33:09 +00:00
|
|
|
printk(KERN_INFO "update e820 for GART\n");
|
2008-06-16 01:58:51 +00:00
|
|
|
e820_add_region(aper_base, aper_size, E820_RESERVED);
|
x86: disable the GART early, 64-bit
For K8 system: 4G RAM with memory hole remapping enabled, or more than
4G RAM installed.
when try to use kexec second kernel, and the first doesn't include
gart_shutdown. the second kernel could have different aper position than
the first kernel. and second kernel could use that hole as RAM that is
still used by GART set by the first kernel. esp. when try to kexec
2.6.24 with sparse mem enable from previous kernel (from RHEL 5 or SLES
10). the new kernel will use aper by GART (set by first kernel) for
vmemmap. and after new kernel setting one new GART. the position will be
real RAM. the _mapcount set is lost.
Bad page state in process 'swapper'
page:ffffe2000e600020 flags:0x0000000000000000 mapping:0000000000000000 mapcount:1 count:0
Trying to fix it up, but a reboot is needed
Backtrace:
Pid: 0, comm: swapper Not tainted 2.6.24-rc7-smp-gcdf71a10-dirty #13
Call Trace:
[<ffffffff8026401f>] bad_page+0x63/0x8d
[<ffffffff80264169>] __free_pages_ok+0x7c/0x2a5
[<ffffffff80ba75d1>] free_all_bootmem_core+0xd0/0x198
[<ffffffff80ba3a42>] numa_free_all_bootmem+0x3b/0x76
[<ffffffff80ba3461>] mem_init+0x3b/0x152
[<ffffffff80b959d3>] start_kernel+0x236/0x2c2
[<ffffffff80b9511a>] _sinittext+0x11a/0x121
and
[ffffe2000e600000-ffffe2000e7fffff] PMD ->ffff81001c200000 on node 0
phys addr is : 0x1c200000
RHEL 5.1 kernel -53 said:
PCI-DMA: aperture base @ 1c000000 size 65536 KB
new kernel said:
Mapping aperture over 65536 KB of RAM @ 3c000000
So could try to disable that GART if possible.
According to Ingo
> hm, i'm wondering, instead of modifying the GART, why dont we simply
> _detect_ whatever GART settings we have inherited, and propagate that
> into our e820 maps? I.e. if there's inconsistency, then punch that out
> from the memory maps and just dont use that memory.
>
> that way it would not matter whether the GART settings came from a [old
> or crashing] Linux kernel that has not called gart_iommu_shutdown(), or
> whether it's a BIOS that has set up an aperture hole inconsistent with
> the memory map it passed. (or the memory map we _think_ i tried to pass
> us)
>
> it would also be more robust to only read and do a memory map quirk
> based on that, than actively trying to change the GART so early in the
> bootup. Later on we have to re-enable the GART _anyway_ and have to
> punch a hole for it.
>
> and as a bonus, we would have shored up our defenses against crappy
> BIOSes as well.
add e820 modification for gart inconsistent setting.
gart_fix_e820=off could be used to disable e820 fix.
Signed-off-by: Yinghai Lu <yinghai.lu@sun.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
2008-01-30 12:33:09 +00:00
|
|
|
update_e820();
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2009-12-14 02:52:15 +00:00
|
|
|
if (valid_agp)
|
2008-05-26 19:17:30 +00:00
|
|
|
return;
|
|
|
|
|
2009-12-14 02:52:15 +00:00
|
|
|
/* disable them all at first */
|
2011-01-10 16:20:23 +00:00
|
|
|
for (i = 0; i < amd_nb_bus_dev_ranges[i].dev_limit; i++) {
|
2008-04-19 08:31:11 +00:00
|
|
|
int bus;
|
|
|
|
int dev_base, dev_limit;
|
|
|
|
|
2011-01-10 16:20:23 +00:00
|
|
|
bus = amd_nb_bus_dev_ranges[i].bus;
|
|
|
|
dev_base = amd_nb_bus_dev_ranges[i].dev_base;
|
|
|
|
dev_limit = amd_nb_bus_dev_ranges[i].dev_limit;
|
x86: disable the GART early, 64-bit
For K8 system: 4G RAM with memory hole remapping enabled, or more than
4G RAM installed.
when try to use kexec second kernel, and the first doesn't include
gart_shutdown. the second kernel could have different aper position than
the first kernel. and second kernel could use that hole as RAM that is
still used by GART set by the first kernel. esp. when try to kexec
2.6.24 with sparse mem enable from previous kernel (from RHEL 5 or SLES
10). the new kernel will use aper by GART (set by first kernel) for
vmemmap. and after new kernel setting one new GART. the position will be
real RAM. the _mapcount set is lost.
Bad page state in process 'swapper'
page:ffffe2000e600020 flags:0x0000000000000000 mapping:0000000000000000 mapcount:1 count:0
Trying to fix it up, but a reboot is needed
Backtrace:
Pid: 0, comm: swapper Not tainted 2.6.24-rc7-smp-gcdf71a10-dirty #13
Call Trace:
[<ffffffff8026401f>] bad_page+0x63/0x8d
[<ffffffff80264169>] __free_pages_ok+0x7c/0x2a5
[<ffffffff80ba75d1>] free_all_bootmem_core+0xd0/0x198
[<ffffffff80ba3a42>] numa_free_all_bootmem+0x3b/0x76
[<ffffffff80ba3461>] mem_init+0x3b/0x152
[<ffffffff80b959d3>] start_kernel+0x236/0x2c2
[<ffffffff80b9511a>] _sinittext+0x11a/0x121
and
[ffffe2000e600000-ffffe2000e7fffff] PMD ->ffff81001c200000 on node 0
phys addr is : 0x1c200000
RHEL 5.1 kernel -53 said:
PCI-DMA: aperture base @ 1c000000 size 65536 KB
new kernel said:
Mapping aperture over 65536 KB of RAM @ 3c000000
So could try to disable that GART if possible.
According to Ingo
> hm, i'm wondering, instead of modifying the GART, why dont we simply
> _detect_ whatever GART settings we have inherited, and propagate that
> into our e820 maps? I.e. if there's inconsistency, then punch that out
> from the memory maps and just dont use that memory.
>
> that way it would not matter whether the GART settings came from a [old
> or crashing] Linux kernel that has not called gart_iommu_shutdown(), or
> whether it's a BIOS that has set up an aperture hole inconsistent with
> the memory map it passed. (or the memory map we _think_ i tried to pass
> us)
>
> it would also be more robust to only read and do a memory map quirk
> based on that, than actively trying to change the GART so early in the
> bootup. Later on we have to re-enable the GART _anyway_ and have to
> punch a hole for it.
>
> and as a bonus, we would have shored up our defenses against crappy
> BIOSes as well.
add e820 modification for gart inconsistent setting.
gart_fix_e820=off could be used to disable e820 fix.
Signed-off-by: Yinghai Lu <yinghai.lu@sun.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
2008-01-30 12:33:09 +00:00
|
|
|
|
2008-04-19 08:31:11 +00:00
|
|
|
for (slot = dev_base; slot < dev_limit; slot++) {
|
2010-10-29 15:14:30 +00:00
|
|
|
if (!early_is_amd_nb(read_pci_config(bus, slot, 3, 0x00)))
|
2008-04-19 08:31:11 +00:00
|
|
|
continue;
|
|
|
|
|
|
|
|
ctl = read_pci_config(bus, slot, 3, AMD64_GARTAPERTURECTL);
|
2010-09-03 16:39:39 +00:00
|
|
|
ctl &= ~GARTEN;
|
2008-04-19 08:31:11 +00:00
|
|
|
write_pci_config(bus, slot, 3, AMD64_GARTAPERTURECTL, ctl);
|
|
|
|
}
|
x86: disable the GART early, 64-bit
For K8 system: 4G RAM with memory hole remapping enabled, or more than
4G RAM installed.
when try to use kexec second kernel, and the first doesn't include
gart_shutdown. the second kernel could have different aper position than
the first kernel. and second kernel could use that hole as RAM that is
still used by GART set by the first kernel. esp. when try to kexec
2.6.24 with sparse mem enable from previous kernel (from RHEL 5 or SLES
10). the new kernel will use aper by GART (set by first kernel) for
vmemmap. and after new kernel setting one new GART. the position will be
real RAM. the _mapcount set is lost.
Bad page state in process 'swapper'
page:ffffe2000e600020 flags:0x0000000000000000 mapping:0000000000000000 mapcount:1 count:0
Trying to fix it up, but a reboot is needed
Backtrace:
Pid: 0, comm: swapper Not tainted 2.6.24-rc7-smp-gcdf71a10-dirty #13
Call Trace:
[<ffffffff8026401f>] bad_page+0x63/0x8d
[<ffffffff80264169>] __free_pages_ok+0x7c/0x2a5
[<ffffffff80ba75d1>] free_all_bootmem_core+0xd0/0x198
[<ffffffff80ba3a42>] numa_free_all_bootmem+0x3b/0x76
[<ffffffff80ba3461>] mem_init+0x3b/0x152
[<ffffffff80b959d3>] start_kernel+0x236/0x2c2
[<ffffffff80b9511a>] _sinittext+0x11a/0x121
and
[ffffe2000e600000-ffffe2000e7fffff] PMD ->ffff81001c200000 on node 0
phys addr is : 0x1c200000
RHEL 5.1 kernel -53 said:
PCI-DMA: aperture base @ 1c000000 size 65536 KB
new kernel said:
Mapping aperture over 65536 KB of RAM @ 3c000000
So could try to disable that GART if possible.
According to Ingo
> hm, i'm wondering, instead of modifying the GART, why dont we simply
> _detect_ whatever GART settings we have inherited, and propagate that
> into our e820 maps? I.e. if there's inconsistency, then punch that out
> from the memory maps and just dont use that memory.
>
> that way it would not matter whether the GART settings came from a [old
> or crashing] Linux kernel that has not called gart_iommu_shutdown(), or
> whether it's a BIOS that has set up an aperture hole inconsistent with
> the memory map it passed. (or the memory map we _think_ i tried to pass
> us)
>
> it would also be more robust to only read and do a memory map quirk
> based on that, than actively trying to change the GART so early in the
> bootup. Later on we have to re-enable the GART _anyway_ and have to
> punch a hole for it.
>
> and as a bonus, we would have shored up our defenses against crappy
> BIOSes as well.
add e820 modification for gart inconsistent setting.
gart_fix_e820=off could be used to disable e820 fix.
Signed-off-by: Yinghai Lu <yinghai.lu@sun.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
2008-01-30 12:33:09 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
}
|
|
|
|
|
2008-04-14 01:42:31 +00:00
|
|
|
static int __initdata printed_gart_size_msg;
|
|
|
|
|
2010-08-26 17:57:57 +00:00
|
|
|
int __init gart_iommu_hole_init(void)
|
2008-01-30 12:30:09 +00:00
|
|
|
{
|
2008-04-14 01:42:31 +00:00
|
|
|
u32 agp_aper_base = 0, agp_aper_order = 0;
|
2005-11-05 16:25:53 +00:00
|
|
|
u32 aper_size, aper_alloc = 0, aper_order = 0, last_aper_order = 0;
|
2005-04-16 22:20:36 +00:00
|
|
|
u64 aper_base, last_aper_base = 0;
|
2008-04-19 08:31:11 +00:00
|
|
|
int fix, slot, valid_agp = 0;
|
|
|
|
int i, node;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2007-10-24 10:49:50 +00:00
|
|
|
if (gart_iommu_aperture_disabled || !fix_aperture ||
|
|
|
|
!early_pci_allowed())
|
2010-08-26 17:57:57 +00:00
|
|
|
return -ENODEV;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2007-07-21 15:11:36 +00:00
|
|
|
printk(KERN_INFO "Checking aperture...\n");
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2008-04-14 01:42:31 +00:00
|
|
|
if (!fallback_aper_force)
|
|
|
|
agp_aper_base = search_agp_bridge(&agp_aper_order, &valid_agp);
|
|
|
|
|
2005-04-16 22:20:36 +00:00
|
|
|
fix = 0;
|
2008-01-30 12:33:18 +00:00
|
|
|
node = 0;
|
2011-01-10 16:20:23 +00:00
|
|
|
for (i = 0; i < amd_nb_bus_dev_ranges[i].dev_limit; i++) {
|
2008-04-19 08:31:11 +00:00
|
|
|
int bus;
|
|
|
|
int dev_base, dev_limit;
|
2010-04-07 10:57:35 +00:00
|
|
|
u32 ctl;
|
2008-04-19 08:31:11 +00:00
|
|
|
|
2011-01-10 16:20:23 +00:00
|
|
|
bus = amd_nb_bus_dev_ranges[i].bus;
|
|
|
|
dev_base = amd_nb_bus_dev_ranges[i].dev_base;
|
|
|
|
dev_limit = amd_nb_bus_dev_ranges[i].dev_limit;
|
2008-04-19 08:31:11 +00:00
|
|
|
|
|
|
|
for (slot = dev_base; slot < dev_limit; slot++) {
|
2010-10-29 15:14:30 +00:00
|
|
|
if (!early_is_amd_nb(read_pci_config(bus, slot, 3, 0x00)))
|
2008-04-19 08:31:11 +00:00
|
|
|
continue;
|
|
|
|
|
|
|
|
iommu_detected = 1;
|
|
|
|
gart_iommu_aperture = 1;
|
2009-11-10 10:46:14 +00:00
|
|
|
x86_init.iommu.iommu_init = gart_iommu_init;
|
2008-04-19 08:31:11 +00:00
|
|
|
|
2010-04-07 10:57:35 +00:00
|
|
|
ctl = read_pci_config(bus, slot, 3,
|
|
|
|
AMD64_GARTAPERTURECTL);
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Before we do anything else disable the GART. It may
|
|
|
|
* still be enabled if we boot into a crash-kernel here.
|
|
|
|
* Reconfiguring the GART while it is enabled could have
|
|
|
|
* unknown side-effects.
|
|
|
|
*/
|
|
|
|
ctl &= ~GARTEN;
|
|
|
|
write_pci_config(bus, slot, 3, AMD64_GARTAPERTURECTL, ctl);
|
|
|
|
|
|
|
|
aper_order = (ctl >> 1) & 7;
|
2008-04-19 08:31:11 +00:00
|
|
|
aper_size = (32 * 1024 * 1024) << aper_order;
|
|
|
|
aper_base = read_pci_config(bus, slot, 3, AMD64_GARTAPERTUREBASE) & 0x7fff;
|
|
|
|
aper_base <<= 25;
|
|
|
|
|
|
|
|
printk(KERN_INFO "Node %d: aperture @ %Lx size %u MB\n",
|
|
|
|
node, aper_base, aper_size >> 20);
|
|
|
|
node++;
|
|
|
|
|
|
|
|
if (!aperture_valid(aper_base, aper_size, 64<<20)) {
|
|
|
|
if (valid_agp && agp_aper_base &&
|
|
|
|
agp_aper_base == aper_base &&
|
|
|
|
agp_aper_order == aper_order) {
|
|
|
|
/* the same between two setting from NB and agp */
|
2008-06-25 05:14:09 +00:00
|
|
|
if (!no_iommu &&
|
|
|
|
max_pfn > MAX_DMA32_PFN &&
|
|
|
|
!printed_gart_size_msg) {
|
2008-04-19 08:31:11 +00:00
|
|
|
printk(KERN_ERR "you are using iommu with agp, but GART size is less than 64M\n");
|
|
|
|
printk(KERN_ERR "please increase GART size in your BIOS setup\n");
|
|
|
|
printk(KERN_ERR "if BIOS doesn't have that option, contact your HW vendor!\n");
|
|
|
|
printed_gart_size_msg = 1;
|
|
|
|
}
|
|
|
|
} else {
|
|
|
|
fix = 1;
|
|
|
|
goto out;
|
2008-04-14 01:42:31 +00:00
|
|
|
}
|
|
|
|
}
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2008-04-19 08:31:11 +00:00
|
|
|
if ((last_aper_order && aper_order != last_aper_order) ||
|
|
|
|
(last_aper_base && aper_base != last_aper_base)) {
|
|
|
|
fix = 1;
|
|
|
|
goto out;
|
|
|
|
}
|
|
|
|
last_aper_order = aper_order;
|
|
|
|
last_aper_base = aper_base;
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
2008-01-30 12:30:09 +00:00
|
|
|
}
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2008-04-19 08:31:11 +00:00
|
|
|
out:
|
2006-09-26 08:52:40 +00:00
|
|
|
if (!fix && !fallback_aper_force) {
|
|
|
|
if (last_aper_base) {
|
|
|
|
unsigned long n = (32 * 1024 * 1024) << last_aper_order;
|
2008-01-30 12:30:09 +00:00
|
|
|
|
2006-09-26 08:52:40 +00:00
|
|
|
insert_aperture_resource((u32)last_aper_base, n);
|
2010-08-26 17:57:57 +00:00
|
|
|
return 1;
|
2006-09-26 08:52:40 +00:00
|
|
|
}
|
2010-08-26 17:57:57 +00:00
|
|
|
return 0;
|
2006-09-26 08:52:40 +00:00
|
|
|
}
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2008-04-14 01:42:31 +00:00
|
|
|
if (!fallback_aper_force) {
|
|
|
|
aper_alloc = agp_aper_base;
|
|
|
|
aper_order = agp_aper_order;
|
|
|
|
}
|
2008-01-30 12:30:09 +00:00
|
|
|
|
|
|
|
if (aper_alloc) {
|
2005-04-16 22:20:36 +00:00
|
|
|
/* Got the aperture from the AGP bridge */
|
2008-06-25 05:14:09 +00:00
|
|
|
} else if ((!no_iommu && max_pfn > MAX_DMA32_PFN) ||
|
2005-04-16 22:20:36 +00:00
|
|
|
force_iommu ||
|
|
|
|
valid_agp ||
|
2008-01-30 12:30:09 +00:00
|
|
|
fallback_aper_force) {
|
2008-09-29 18:52:03 +00:00
|
|
|
printk(KERN_INFO
|
2008-01-30 12:30:10 +00:00
|
|
|
"Your BIOS doesn't leave a aperture memory hole\n");
|
2008-09-29 18:52:03 +00:00
|
|
|
printk(KERN_INFO
|
2008-01-30 12:30:10 +00:00
|
|
|
"Please enable the IOMMU option in the BIOS setup\n");
|
2008-09-29 18:52:03 +00:00
|
|
|
printk(KERN_INFO
|
2008-01-30 12:30:10 +00:00
|
|
|
"This costs you %d MB of RAM\n",
|
|
|
|
32 << fallback_aper_order);
|
2005-04-16 22:20:36 +00:00
|
|
|
|
|
|
|
aper_order = fallback_aper_order;
|
|
|
|
aper_alloc = allocate_aperture();
|
2008-01-30 12:30:09 +00:00
|
|
|
if (!aper_alloc) {
|
|
|
|
/*
|
|
|
|
* Could disable AGP and IOMMU here, but it's
|
|
|
|
* probably not worth it. But the later users
|
|
|
|
* cannot deal with bad apertures and turning
|
|
|
|
* on the aperture over memory causes very
|
|
|
|
* strange problems, so it's better to panic
|
|
|
|
* early.
|
|
|
|
*/
|
2005-04-16 22:20:36 +00:00
|
|
|
panic("Not enough memory for aperture");
|
|
|
|
}
|
2008-01-30 12:30:09 +00:00
|
|
|
} else {
|
2010-08-26 17:57:57 +00:00
|
|
|
return 0;
|
2008-01-30 12:30:09 +00:00
|
|
|
}
|
2005-04-16 22:20:36 +00:00
|
|
|
|
|
|
|
/* Fix up the north bridges */
|
2011-01-10 16:20:23 +00:00
|
|
|
for (i = 0; i < amd_nb_bus_dev_ranges[i].dev_limit; i++) {
|
2010-09-03 16:39:40 +00:00
|
|
|
int bus, dev_base, dev_limit;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Don't enable translation yet but enable GART IO and CPU
|
|
|
|
* accesses and set DISTLBWALKPRB since GART table memory is UC.
|
|
|
|
*/
|
2011-04-18 13:45:45 +00:00
|
|
|
u32 ctl = aper_order << 1;
|
2008-04-19 08:31:11 +00:00
|
|
|
|
2011-01-10 16:20:23 +00:00
|
|
|
bus = amd_nb_bus_dev_ranges[i].bus;
|
|
|
|
dev_base = amd_nb_bus_dev_ranges[i].dev_base;
|
|
|
|
dev_limit = amd_nb_bus_dev_ranges[i].dev_limit;
|
2008-04-19 08:31:11 +00:00
|
|
|
for (slot = dev_base; slot < dev_limit; slot++) {
|
2010-10-29 15:14:30 +00:00
|
|
|
if (!early_is_amd_nb(read_pci_config(bus, slot, 3, 0x00)))
|
2008-04-19 08:31:11 +00:00
|
|
|
continue;
|
|
|
|
|
2010-09-03 16:39:40 +00:00
|
|
|
write_pci_config(bus, slot, 3, AMD64_GARTAPERTURECTL, ctl);
|
2008-04-19 08:31:11 +00:00
|
|
|
write_pci_config(bus, slot, 3, AMD64_GARTAPERTUREBASE, aper_alloc >> 25);
|
|
|
|
}
|
2008-01-30 12:30:09 +00:00
|
|
|
}
|
2008-06-09 22:10:48 +00:00
|
|
|
|
|
|
|
set_up_gart_resume(aper_order, aper_alloc);
|
2010-08-26 17:57:57 +00:00
|
|
|
|
|
|
|
return 1;
|
2008-01-30 12:30:09 +00:00
|
|
|
}
|