2011-07-19 12:00:19 +00:00
|
|
|
/*
|
|
|
|
|
* x86 semaphore implementation.
|
|
|
|
|
*
|
|
|
|
|
* (C) Copyright 1999 Linus Torvalds
|
|
|
|
|
*
|
|
|
|
|
* Portions Copyright 1999 Red Hat, Inc.
|
|
|
|
|
*
|
|
|
|
|
* This program is free software; you can redistribute it and/or
|
|
|
|
|
* modify it under the terms of the GNU General Public License
|
|
|
|
|
* as published by the Free Software Foundation; either version
|
|
|
|
|
* 2 of the License, or (at your option) any later version.
|
|
|
|
|
*
|
|
|
|
|
* rw semaphores implemented November 1999 by Benjamin LaHaise <bcrl@kvack.org>
|
|
|
|
|
*/
|
|
|
|
|
|
|
|
|
|
#include <linux/linkage.h>
|
|
|
|
|
#include <asm/alternative-asm.h>
|
2016-01-21 22:49:22 +00:00
|
|
|
#include <asm/frame.h>
|
2011-07-19 12:00:19 +00:00
|
|
|
|
|
|
|
|
#define __ASM_HALF_REG(reg) __ASM_SEL(reg, e##reg)
|
|
|
|
|
#define __ASM_HALF_SIZE(inst) __ASM_SEL(inst##w, inst##l)
|
|
|
|
|
|
|
|
|
|
#ifdef CONFIG_X86_32
|
|
|
|
|
|
|
|
|
|
/*
|
|
|
|
|
* The semaphore operations have a special calling sequence that
|
|
|
|
|
* allow us to do a simpler in-line version of them. These routines
|
|
|
|
|
* need to convert that sequence back into the C sequence when
|
|
|
|
|
* there is contention on the semaphore.
|
|
|
|
|
*
|
|
|
|
|
* %eax contains the semaphore pointer on entry. Save the C-clobbered
|
2016-05-16 09:34:28 +00:00
|
|
|
* registers (%eax, %edx and %ecx) except %eax which is either a return
|
|
|
|
|
* value or just gets clobbered. Same is true for %edx so make sure GCC
|
|
|
|
|
* reloads it after the slow path, by making it hold a temporary, for
|
|
|
|
|
* example see ____down_write().
|
2011-07-19 12:00:19 +00:00
|
|
|
*/
|
|
|
|
|
|
|
|
|
|
#define save_common_regs \
|
x86/debug: Remove perpetually broken, unmaintainable dwarf annotations
So the dwarf2 annotations in low level assembly code have
become an increasing hindrance: unreadable, messy macros
mixed into some of the most security sensitive code paths
of the Linux kernel.
These debug info annotations don't even buy the upstream
kernel anything: dwarf driven stack unwinding has caused
problems in the past so it's out of tree, and the upstream
kernel only uses the much more robust framepointers based
stack unwinding method.
In addition to that there's a steady, slow bitrot going
on with these annotations, requiring frequent fixups.
There's no tooling and no functionality upstream that
keeps it correct.
So burn down the sick forest, allowing new, healthier growth:
27 files changed, 350 insertions(+), 1101 deletions(-)
Someone who has the willingness and time to do this
properly can attempt to reintroduce dwarf debuginfo in x86
assembly code plus dwarf unwinding from first principles,
with the following conditions:
- it should be maximally readable, and maximally low-key to
'ordinary' code reading and maintenance.
- find a build time method to insert dwarf annotations
automatically in the most common cases, for pop/push
instructions that manipulate the stack pointer. This could
be done for example via a preprocessing step that just
looks for common patterns - plus special annotations for
the few cases where we want to depart from the default.
We have hundreds of CFI annotations, so automating most of
that makes sense.
- it should come with build tooling checks that ensure that
CFI annotations are sensible. We've seen such efforts from
the framepointer side, and there's no reason it couldn't be
done on the dwarf side.
Cc: Andy Lutomirski <luto@amacapital.net>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Brian Gerst <brgerst@gmail.com>
Cc: Denys Vlasenko <dvlasenk@redhat.com>
Cc: Frédéric Weisbecker <fweisbec@gmail.com
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Jan Beulich <JBeulich@suse.com>
Cc: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Ingo Molnar <mingo@kernel.org>
2015-05-28 10:21:47 +00:00
|
|
|
pushl %ecx
|
2011-07-19 12:00:19 +00:00
|
|
|
|
|
|
|
|
#define restore_common_regs \
|
x86/debug: Remove perpetually broken, unmaintainable dwarf annotations
So the dwarf2 annotations in low level assembly code have
become an increasing hindrance: unreadable, messy macros
mixed into some of the most security sensitive code paths
of the Linux kernel.
These debug info annotations don't even buy the upstream
kernel anything: dwarf driven stack unwinding has caused
problems in the past so it's out of tree, and the upstream
kernel only uses the much more robust framepointers based
stack unwinding method.
In addition to that there's a steady, slow bitrot going
on with these annotations, requiring frequent fixups.
There's no tooling and no functionality upstream that
keeps it correct.
So burn down the sick forest, allowing new, healthier growth:
27 files changed, 350 insertions(+), 1101 deletions(-)
Someone who has the willingness and time to do this
properly can attempt to reintroduce dwarf debuginfo in x86
assembly code plus dwarf unwinding from first principles,
with the following conditions:
- it should be maximally readable, and maximally low-key to
'ordinary' code reading and maintenance.
- find a build time method to insert dwarf annotations
automatically in the most common cases, for pop/push
instructions that manipulate the stack pointer. This could
be done for example via a preprocessing step that just
looks for common patterns - plus special annotations for
the few cases where we want to depart from the default.
We have hundreds of CFI annotations, so automating most of
that makes sense.
- it should come with build tooling checks that ensure that
CFI annotations are sensible. We've seen such efforts from
the framepointer side, and there's no reason it couldn't be
done on the dwarf side.
Cc: Andy Lutomirski <luto@amacapital.net>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Brian Gerst <brgerst@gmail.com>
Cc: Denys Vlasenko <dvlasenk@redhat.com>
Cc: Frédéric Weisbecker <fweisbec@gmail.com
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Jan Beulich <JBeulich@suse.com>
Cc: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Ingo Molnar <mingo@kernel.org>
2015-05-28 10:21:47 +00:00
|
|
|
popl %ecx
|
2011-07-19 12:00:19 +00:00
|
|
|
|
|
|
|
|
/* Avoid uglifying the argument copying x86-64 needs to do. */
|
|
|
|
|
.macro movq src, dst
|
|
|
|
|
.endm
|
|
|
|
|
|
|
|
|
|
#else
|
|
|
|
|
|
2010-01-13 02:16:42 +00:00
|
|
|
/*
|
|
|
|
|
* x86-64 rwsem wrappers
|
|
|
|
|
*
|
|
|
|
|
* This interfaces the inline asm code to the slow-path
|
|
|
|
|
* C routines. We need to save the call-clobbered regs
|
|
|
|
|
* that the asm does not mark as clobbered, and move the
|
|
|
|
|
* argument from %rax to %rdi.
|
|
|
|
|
*
|
|
|
|
|
* NOTE! We don't need to save %rax, because the functions
|
|
|
|
|
* will always return the semaphore pointer in %rax (which
|
|
|
|
|
* is also the input argument to these helpers)
|
|
|
|
|
*
|
|
|
|
|
* The following can clobber %rdx because the asm clobbers it:
|
|
|
|
|
* call_rwsem_down_write_failed
|
|
|
|
|
* call_rwsem_wake
|
|
|
|
|
* but %rdi, %rsi, %rcx, %r8-r11 always need saving.
|
|
|
|
|
*/
|
|
|
|
|
|
|
|
|
|
#define save_common_regs \
|
x86/debug: Remove perpetually broken, unmaintainable dwarf annotations
So the dwarf2 annotations in low level assembly code have
become an increasing hindrance: unreadable, messy macros
mixed into some of the most security sensitive code paths
of the Linux kernel.
These debug info annotations don't even buy the upstream
kernel anything: dwarf driven stack unwinding has caused
problems in the past so it's out of tree, and the upstream
kernel only uses the much more robust framepointers based
stack unwinding method.
In addition to that there's a steady, slow bitrot going
on with these annotations, requiring frequent fixups.
There's no tooling and no functionality upstream that
keeps it correct.
So burn down the sick forest, allowing new, healthier growth:
27 files changed, 350 insertions(+), 1101 deletions(-)
Someone who has the willingness and time to do this
properly can attempt to reintroduce dwarf debuginfo in x86
assembly code plus dwarf unwinding from first principles,
with the following conditions:
- it should be maximally readable, and maximally low-key to
'ordinary' code reading and maintenance.
- find a build time method to insert dwarf annotations
automatically in the most common cases, for pop/push
instructions that manipulate the stack pointer. This could
be done for example via a preprocessing step that just
looks for common patterns - plus special annotations for
the few cases where we want to depart from the default.
We have hundreds of CFI annotations, so automating most of
that makes sense.
- it should come with build tooling checks that ensure that
CFI annotations are sensible. We've seen such efforts from
the framepointer side, and there's no reason it couldn't be
done on the dwarf side.
Cc: Andy Lutomirski <luto@amacapital.net>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Brian Gerst <brgerst@gmail.com>
Cc: Denys Vlasenko <dvlasenk@redhat.com>
Cc: Frédéric Weisbecker <fweisbec@gmail.com
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Jan Beulich <JBeulich@suse.com>
Cc: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Ingo Molnar <mingo@kernel.org>
2015-05-28 10:21:47 +00:00
|
|
|
pushq %rdi; \
|
|
|
|
|
pushq %rsi; \
|
|
|
|
|
pushq %rcx; \
|
|
|
|
|
pushq %r8; \
|
|
|
|
|
pushq %r9; \
|
|
|
|
|
pushq %r10; \
|
|
|
|
|
pushq %r11
|
2010-01-13 02:16:42 +00:00
|
|
|
|
|
|
|
|
#define restore_common_regs \
|
x86/debug: Remove perpetually broken, unmaintainable dwarf annotations
So the dwarf2 annotations in low level assembly code have
become an increasing hindrance: unreadable, messy macros
mixed into some of the most security sensitive code paths
of the Linux kernel.
These debug info annotations don't even buy the upstream
kernel anything: dwarf driven stack unwinding has caused
problems in the past so it's out of tree, and the upstream
kernel only uses the much more robust framepointers based
stack unwinding method.
In addition to that there's a steady, slow bitrot going
on with these annotations, requiring frequent fixups.
There's no tooling and no functionality upstream that
keeps it correct.
So burn down the sick forest, allowing new, healthier growth:
27 files changed, 350 insertions(+), 1101 deletions(-)
Someone who has the willingness and time to do this
properly can attempt to reintroduce dwarf debuginfo in x86
assembly code plus dwarf unwinding from first principles,
with the following conditions:
- it should be maximally readable, and maximally low-key to
'ordinary' code reading and maintenance.
- find a build time method to insert dwarf annotations
automatically in the most common cases, for pop/push
instructions that manipulate the stack pointer. This could
be done for example via a preprocessing step that just
looks for common patterns - plus special annotations for
the few cases where we want to depart from the default.
We have hundreds of CFI annotations, so automating most of
that makes sense.
- it should come with build tooling checks that ensure that
CFI annotations are sensible. We've seen such efforts from
the framepointer side, and there's no reason it couldn't be
done on the dwarf side.
Cc: Andy Lutomirski <luto@amacapital.net>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Brian Gerst <brgerst@gmail.com>
Cc: Denys Vlasenko <dvlasenk@redhat.com>
Cc: Frédéric Weisbecker <fweisbec@gmail.com
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Jan Beulich <JBeulich@suse.com>
Cc: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Ingo Molnar <mingo@kernel.org>
2015-05-28 10:21:47 +00:00
|
|
|
popq %r11; \
|
|
|
|
|
popq %r10; \
|
|
|
|
|
popq %r9; \
|
|
|
|
|
popq %r8; \
|
|
|
|
|
popq %rcx; \
|
|
|
|
|
popq %rsi; \
|
|
|
|
|
popq %rdi
|
2010-01-13 02:16:42 +00:00
|
|
|
|
2011-07-19 12:00:19 +00:00
|
|
|
#endif
|
|
|
|
|
|
2010-01-13 02:16:42 +00:00
|
|
|
/* Fix up special calling conventions */
|
|
|
|
|
ENTRY(call_rwsem_down_read_failed)
|
2016-01-21 22:49:22 +00:00
|
|
|
FRAME_BEGIN
|
2010-01-13 02:16:42 +00:00
|
|
|
save_common_regs
|
x86/debug: Remove perpetually broken, unmaintainable dwarf annotations
So the dwarf2 annotations in low level assembly code have
become an increasing hindrance: unreadable, messy macros
mixed into some of the most security sensitive code paths
of the Linux kernel.
These debug info annotations don't even buy the upstream
kernel anything: dwarf driven stack unwinding has caused
problems in the past so it's out of tree, and the upstream
kernel only uses the much more robust framepointers based
stack unwinding method.
In addition to that there's a steady, slow bitrot going
on with these annotations, requiring frequent fixups.
There's no tooling and no functionality upstream that
keeps it correct.
So burn down the sick forest, allowing new, healthier growth:
27 files changed, 350 insertions(+), 1101 deletions(-)
Someone who has the willingness and time to do this
properly can attempt to reintroduce dwarf debuginfo in x86
assembly code plus dwarf unwinding from first principles,
with the following conditions:
- it should be maximally readable, and maximally low-key to
'ordinary' code reading and maintenance.
- find a build time method to insert dwarf annotations
automatically in the most common cases, for pop/push
instructions that manipulate the stack pointer. This could
be done for example via a preprocessing step that just
looks for common patterns - plus special annotations for
the few cases where we want to depart from the default.
We have hundreds of CFI annotations, so automating most of
that makes sense.
- it should come with build tooling checks that ensure that
CFI annotations are sensible. We've seen such efforts from
the framepointer side, and there's no reason it couldn't be
done on the dwarf side.
Cc: Andy Lutomirski <luto@amacapital.net>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Brian Gerst <brgerst@gmail.com>
Cc: Denys Vlasenko <dvlasenk@redhat.com>
Cc: Frédéric Weisbecker <fweisbec@gmail.com
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Jan Beulich <JBeulich@suse.com>
Cc: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Ingo Molnar <mingo@kernel.org>
2015-05-28 10:21:47 +00:00
|
|
|
__ASM_SIZE(push,) %__ASM_REG(dx)
|
2010-01-13 02:16:42 +00:00
|
|
|
movq %rax,%rdi
|
|
|
|
|
call rwsem_down_read_failed
|
x86/debug: Remove perpetually broken, unmaintainable dwarf annotations
So the dwarf2 annotations in low level assembly code have
become an increasing hindrance: unreadable, messy macros
mixed into some of the most security sensitive code paths
of the Linux kernel.
These debug info annotations don't even buy the upstream
kernel anything: dwarf driven stack unwinding has caused
problems in the past so it's out of tree, and the upstream
kernel only uses the much more robust framepointers based
stack unwinding method.
In addition to that there's a steady, slow bitrot going
on with these annotations, requiring frequent fixups.
There's no tooling and no functionality upstream that
keeps it correct.
So burn down the sick forest, allowing new, healthier growth:
27 files changed, 350 insertions(+), 1101 deletions(-)
Someone who has the willingness and time to do this
properly can attempt to reintroduce dwarf debuginfo in x86
assembly code plus dwarf unwinding from first principles,
with the following conditions:
- it should be maximally readable, and maximally low-key to
'ordinary' code reading and maintenance.
- find a build time method to insert dwarf annotations
automatically in the most common cases, for pop/push
instructions that manipulate the stack pointer. This could
be done for example via a preprocessing step that just
looks for common patterns - plus special annotations for
the few cases where we want to depart from the default.
We have hundreds of CFI annotations, so automating most of
that makes sense.
- it should come with build tooling checks that ensure that
CFI annotations are sensible. We've seen such efforts from
the framepointer side, and there's no reason it couldn't be
done on the dwarf side.
Cc: Andy Lutomirski <luto@amacapital.net>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Brian Gerst <brgerst@gmail.com>
Cc: Denys Vlasenko <dvlasenk@redhat.com>
Cc: Frédéric Weisbecker <fweisbec@gmail.com
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Jan Beulich <JBeulich@suse.com>
Cc: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Ingo Molnar <mingo@kernel.org>
2015-05-28 10:21:47 +00:00
|
|
|
__ASM_SIZE(pop,) %__ASM_REG(dx)
|
2010-01-13 02:16:42 +00:00
|
|
|
restore_common_regs
|
2016-01-21 22:49:22 +00:00
|
|
|
FRAME_END
|
2010-01-13 02:16:42 +00:00
|
|
|
ret
|
2011-02-28 15:31:59 +00:00
|
|
|
ENDPROC(call_rwsem_down_read_failed)
|
2010-01-13 02:16:42 +00:00
|
|
|
|
2017-09-29 16:06:28 +00:00
|
|
|
ENTRY(call_rwsem_down_read_failed_killable)
|
|
|
|
|
FRAME_BEGIN
|
|
|
|
|
save_common_regs
|
|
|
|
|
__ASM_SIZE(push,) %__ASM_REG(dx)
|
|
|
|
|
movq %rax,%rdi
|
|
|
|
|
call rwsem_down_read_failed_killable
|
|
|
|
|
__ASM_SIZE(pop,) %__ASM_REG(dx)
|
|
|
|
|
restore_common_regs
|
|
|
|
|
FRAME_END
|
|
|
|
|
ret
|
|
|
|
|
ENDPROC(call_rwsem_down_read_failed_killable)
|
|
|
|
|
|
2010-01-13 02:16:42 +00:00
|
|
|
ENTRY(call_rwsem_down_write_failed)
|
2016-01-21 22:49:22 +00:00
|
|
|
FRAME_BEGIN
|
2010-01-13 02:16:42 +00:00
|
|
|
save_common_regs
|
|
|
|
|
movq %rax,%rdi
|
|
|
|
|
call rwsem_down_write_failed
|
|
|
|
|
restore_common_regs
|
2016-01-21 22:49:22 +00:00
|
|
|
FRAME_END
|
2010-01-13 02:16:42 +00:00
|
|
|
ret
|
2011-02-28 15:31:59 +00:00
|
|
|
ENDPROC(call_rwsem_down_write_failed)
|
2010-01-13 02:16:42 +00:00
|
|
|
|
2016-04-07 15:12:30 +00:00
|
|
|
ENTRY(call_rwsem_down_write_failed_killable)
|
2016-04-13 09:57:12 +00:00
|
|
|
FRAME_BEGIN
|
2016-04-07 15:12:30 +00:00
|
|
|
save_common_regs
|
|
|
|
|
movq %rax,%rdi
|
|
|
|
|
call rwsem_down_write_failed_killable
|
|
|
|
|
restore_common_regs
|
2016-04-13 09:57:12 +00:00
|
|
|
FRAME_END
|
2016-04-07 15:12:30 +00:00
|
|
|
ret
|
|
|
|
|
ENDPROC(call_rwsem_down_write_failed_killable)
|
|
|
|
|
|
2010-01-13 02:16:42 +00:00
|
|
|
ENTRY(call_rwsem_wake)
|
2016-01-21 22:49:22 +00:00
|
|
|
FRAME_BEGIN
|
2011-07-19 12:00:19 +00:00
|
|
|
/* do nothing if still outstanding active readers */
|
|
|
|
|
__ASM_HALF_SIZE(dec) %__ASM_HALF_REG(dx)
|
2010-01-13 02:16:42 +00:00
|
|
|
jnz 1f
|
|
|
|
|
save_common_regs
|
|
|
|
|
movq %rax,%rdi
|
|
|
|
|
call rwsem_wake
|
|
|
|
|
restore_common_regs
|
2016-01-21 22:49:22 +00:00
|
|
|
1: FRAME_END
|
|
|
|
|
ret
|
2011-02-28 15:31:59 +00:00
|
|
|
ENDPROC(call_rwsem_wake)
|
2010-01-13 02:16:42 +00:00
|
|
|
|
|
|
|
|
ENTRY(call_rwsem_downgrade_wake)
|
2016-01-21 22:49:22 +00:00
|
|
|
FRAME_BEGIN
|
2010-01-13 02:16:42 +00:00
|
|
|
save_common_regs
|
x86/debug: Remove perpetually broken, unmaintainable dwarf annotations
So the dwarf2 annotations in low level assembly code have
become an increasing hindrance: unreadable, messy macros
mixed into some of the most security sensitive code paths
of the Linux kernel.
These debug info annotations don't even buy the upstream
kernel anything: dwarf driven stack unwinding has caused
problems in the past so it's out of tree, and the upstream
kernel only uses the much more robust framepointers based
stack unwinding method.
In addition to that there's a steady, slow bitrot going
on with these annotations, requiring frequent fixups.
There's no tooling and no functionality upstream that
keeps it correct.
So burn down the sick forest, allowing new, healthier growth:
27 files changed, 350 insertions(+), 1101 deletions(-)
Someone who has the willingness and time to do this
properly can attempt to reintroduce dwarf debuginfo in x86
assembly code plus dwarf unwinding from first principles,
with the following conditions:
- it should be maximally readable, and maximally low-key to
'ordinary' code reading and maintenance.
- find a build time method to insert dwarf annotations
automatically in the most common cases, for pop/push
instructions that manipulate the stack pointer. This could
be done for example via a preprocessing step that just
looks for common patterns - plus special annotations for
the few cases where we want to depart from the default.
We have hundreds of CFI annotations, so automating most of
that makes sense.
- it should come with build tooling checks that ensure that
CFI annotations are sensible. We've seen such efforts from
the framepointer side, and there's no reason it couldn't be
done on the dwarf side.
Cc: Andy Lutomirski <luto@amacapital.net>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Brian Gerst <brgerst@gmail.com>
Cc: Denys Vlasenko <dvlasenk@redhat.com>
Cc: Frédéric Weisbecker <fweisbec@gmail.com
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Jan Beulich <JBeulich@suse.com>
Cc: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Ingo Molnar <mingo@kernel.org>
2015-05-28 10:21:47 +00:00
|
|
|
__ASM_SIZE(push,) %__ASM_REG(dx)
|
2010-01-13 02:16:42 +00:00
|
|
|
movq %rax,%rdi
|
|
|
|
|
call rwsem_downgrade_wake
|
x86/debug: Remove perpetually broken, unmaintainable dwarf annotations
So the dwarf2 annotations in low level assembly code have
become an increasing hindrance: unreadable, messy macros
mixed into some of the most security sensitive code paths
of the Linux kernel.
These debug info annotations don't even buy the upstream
kernel anything: dwarf driven stack unwinding has caused
problems in the past so it's out of tree, and the upstream
kernel only uses the much more robust framepointers based
stack unwinding method.
In addition to that there's a steady, slow bitrot going
on with these annotations, requiring frequent fixups.
There's no tooling and no functionality upstream that
keeps it correct.
So burn down the sick forest, allowing new, healthier growth:
27 files changed, 350 insertions(+), 1101 deletions(-)
Someone who has the willingness and time to do this
properly can attempt to reintroduce dwarf debuginfo in x86
assembly code plus dwarf unwinding from first principles,
with the following conditions:
- it should be maximally readable, and maximally low-key to
'ordinary' code reading and maintenance.
- find a build time method to insert dwarf annotations
automatically in the most common cases, for pop/push
instructions that manipulate the stack pointer. This could
be done for example via a preprocessing step that just
looks for common patterns - plus special annotations for
the few cases where we want to depart from the default.
We have hundreds of CFI annotations, so automating most of
that makes sense.
- it should come with build tooling checks that ensure that
CFI annotations are sensible. We've seen such efforts from
the framepointer side, and there's no reason it couldn't be
done on the dwarf side.
Cc: Andy Lutomirski <luto@amacapital.net>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Brian Gerst <brgerst@gmail.com>
Cc: Denys Vlasenko <dvlasenk@redhat.com>
Cc: Frédéric Weisbecker <fweisbec@gmail.com
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Jan Beulich <JBeulich@suse.com>
Cc: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Ingo Molnar <mingo@kernel.org>
2015-05-28 10:21:47 +00:00
|
|
|
__ASM_SIZE(pop,) %__ASM_REG(dx)
|
2010-01-13 02:16:42 +00:00
|
|
|
restore_common_regs
|
2016-01-21 22:49:22 +00:00
|
|
|
FRAME_END
|
2010-01-13 02:16:42 +00:00
|
|
|
ret
|
2011-02-28 15:31:59 +00:00
|
|
|
ENDPROC(call_rwsem_downgrade_wake)
|
