2019-05-29 14:18:01 +00:00
|
|
|
// SPDX-License-Identifier: GPL-2.0-only
|
2008-06-27 11:12:54 +00:00
|
|
|
/*
|
|
|
|
* linux/drivers/firmware/memmap.c
|
|
|
|
* Copyright (C) 2008 SUSE LINUX Products GmbH
|
2009-02-18 22:48:40 +00:00
|
|
|
* by Bernhard Walle <bernhard.walle@gmx.de>
|
2008-06-27 11:12:54 +00:00
|
|
|
*/
|
|
|
|
|
|
|
|
#include <linux/string.h>
|
|
|
|
#include <linux/firmware-map.h>
|
|
|
|
#include <linux/kernel.h>
|
|
|
|
#include <linux/module.h>
|
|
|
|
#include <linux/types.h>
|
2018-10-30 22:09:49 +00:00
|
|
|
#include <linux/memblock.h>
|
include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h
percpu.h is included by sched.h and module.h and thus ends up being
included when building most .c files. percpu.h includes slab.h which
in turn includes gfp.h making everything defined by the two files
universally available and complicating inclusion dependencies.
percpu.h -> slab.h dependency is about to be removed. Prepare for
this change by updating users of gfp and slab facilities include those
headers directly instead of assuming availability. As this conversion
needs to touch large number of source files, the following script is
used as the basis of conversion.
http://userweb.kernel.org/~tj/misc/slabh-sweep.py
The script does the followings.
* Scan files for gfp and slab usages and update includes such that
only the necessary includes are there. ie. if only gfp is used,
gfp.h, if slab is used, slab.h.
* When the script inserts a new include, it looks at the include
blocks and try to put the new include such that its order conforms
to its surrounding. It's put in the include block which contains
core kernel includes, in the same order that the rest are ordered -
alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
doesn't seem to be any matching order.
* If the script can't find a place to put a new include (mostly
because the file doesn't have fitting include block), it prints out
an error message indicating which .h file needs to be added to the
file.
The conversion was done in the following steps.
1. The initial automatic conversion of all .c files updated slightly
over 4000 files, deleting around 700 includes and adding ~480 gfp.h
and ~3000 slab.h inclusions. The script emitted errors for ~400
files.
2. Each error was manually checked. Some didn't need the inclusion,
some needed manual addition while adding it to implementation .h or
embedding .c file was more appropriate for others. This step added
inclusions to around 150 files.
3. The script was run again and the output was compared to the edits
from #2 to make sure no file was left behind.
4. Several build tests were done and a couple of problems were fixed.
e.g. lib/decompress_*.c used malloc/free() wrappers around slab
APIs requiring slab.h to be added manually.
5. The script was run on all .h files but without automatically
editing them as sprinkling gfp.h and slab.h inclusions around .h
files could easily lead to inclusion dependency hell. Most gfp.h
inclusion directives were ignored as stuff from gfp.h was usually
wildly available and often used in preprocessor macros. Each
slab.h inclusion directive was examined and added manually as
necessary.
6. percpu.h was updated not to include slab.h.
7. Build test were done on the following configurations and failures
were fixed. CONFIG_GCOV_KERNEL was turned off for all tests (as my
distributed build env didn't work with gcov compiles) and a few
more options had to be turned off depending on archs to make things
build (like ipr on powerpc/64 which failed due to missing writeq).
* x86 and x86_64 UP and SMP allmodconfig and a custom test config.
* powerpc and powerpc64 SMP allmodconfig
* sparc and sparc64 SMP allmodconfig
* ia64 SMP allmodconfig
* s390 SMP allmodconfig
* alpha SMP allmodconfig
* um on x86_64 SMP allmodconfig
8. percpu.h modifications were reverted so that it could be applied as
a separate patch and serve as bisection point.
Given the fact that I had only a couple of failures from tests on step
6, I'm fairly confident about the coverage of this conversion patch.
If there is a breakage, it's likely to be something in one of the arch
headers which should be easily discoverable easily on most builds of
the specific arch.
Signed-off-by: Tejun Heo <tj@kernel.org>
Guess-its-ok-by: Christoph Lameter <cl@linux-foundation.org>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
2010-03-24 08:04:11 +00:00
|
|
|
#include <linux/slab.h>
|
2013-02-23 00:32:56 +00:00
|
|
|
#include <linux/mm.h>
|
2008-06-27 11:12:54 +00:00
|
|
|
|
|
|
|
/*
|
|
|
|
* Data types ------------------------------------------------------------------
|
|
|
|
*/
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Firmware map entry. Because firmware memory maps are flat and not
|
|
|
|
* hierarchical, it's ok to organise them in a linked list. No parent
|
|
|
|
* information is necessary as for the resource tree.
|
|
|
|
*/
|
|
|
|
struct firmware_map_entry {
|
2009-06-16 22:31:16 +00:00
|
|
|
/*
|
|
|
|
* start and end must be u64 rather than resource_size_t, because e820
|
|
|
|
* resources can lie at addresses above 4G.
|
|
|
|
*/
|
|
|
|
u64 start; /* start of the memory range */
|
|
|
|
u64 end; /* end of the memory range (incl.) */
|
2008-06-27 11:12:54 +00:00
|
|
|
const char *type; /* type of the memory range */
|
|
|
|
struct list_head list; /* entry for the linked list */
|
|
|
|
struct kobject kobj; /* kobject for each entry */
|
|
|
|
};
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Forward declarations --------------------------------------------------------
|
|
|
|
*/
|
|
|
|
static ssize_t memmap_attr_show(struct kobject *kobj,
|
|
|
|
struct attribute *attr, char *buf);
|
|
|
|
static ssize_t start_show(struct firmware_map_entry *entry, char *buf);
|
|
|
|
static ssize_t end_show(struct firmware_map_entry *entry, char *buf);
|
|
|
|
static ssize_t type_show(struct firmware_map_entry *entry, char *buf);
|
|
|
|
|
2013-02-23 00:32:56 +00:00
|
|
|
static struct firmware_map_entry * __meminit
|
|
|
|
firmware_map_find_entry(u64 start, u64 end, const char *type);
|
|
|
|
|
2008-06-27 11:12:54 +00:00
|
|
|
/*
|
|
|
|
* Static data -----------------------------------------------------------------
|
|
|
|
*/
|
|
|
|
|
|
|
|
struct memmap_attribute {
|
|
|
|
struct attribute attr;
|
|
|
|
ssize_t (*show)(struct firmware_map_entry *entry, char *buf);
|
|
|
|
};
|
|
|
|
|
2009-01-08 02:09:15 +00:00
|
|
|
static struct memmap_attribute memmap_start_attr = __ATTR_RO(start);
|
|
|
|
static struct memmap_attribute memmap_end_attr = __ATTR_RO(end);
|
|
|
|
static struct memmap_attribute memmap_type_attr = __ATTR_RO(type);
|
2008-06-27 11:12:54 +00:00
|
|
|
|
|
|
|
/*
|
|
|
|
* These are default attributes that are added for every memmap entry.
|
|
|
|
*/
|
|
|
|
static struct attribute *def_attrs[] = {
|
|
|
|
&memmap_start_attr.attr,
|
|
|
|
&memmap_end_attr.attr,
|
|
|
|
&memmap_type_attr.attr,
|
|
|
|
NULL
|
|
|
|
};
|
|
|
|
|
2010-01-19 01:58:23 +00:00
|
|
|
static const struct sysfs_ops memmap_attr_ops = {
|
2008-06-27 11:12:54 +00:00
|
|
|
.show = memmap_attr_show,
|
|
|
|
};
|
|
|
|
|
2013-02-23 00:32:56 +00:00
|
|
|
/* Firmware memory map entries. */
|
|
|
|
static LIST_HEAD(map_entries);
|
|
|
|
static DEFINE_SPINLOCK(map_entries_lock);
|
|
|
|
|
|
|
|
/*
|
|
|
|
* For memory hotplug, there is no way to free memory map entries allocated
|
|
|
|
* by boot mem after the system is up. So when we hot-remove memory whose
|
|
|
|
* map entry is allocated by bootmem, we need to remember the storage and
|
|
|
|
* reuse it when the memory is hot-added again.
|
|
|
|
*/
|
|
|
|
static LIST_HEAD(map_entries_bootmem);
|
|
|
|
static DEFINE_SPINLOCK(map_entries_bootmem_lock);
|
|
|
|
|
|
|
|
|
|
|
|
static inline struct firmware_map_entry *
|
|
|
|
to_memmap_entry(struct kobject *kobj)
|
|
|
|
{
|
|
|
|
return container_of(kobj, struct firmware_map_entry, kobj);
|
|
|
|
}
|
|
|
|
|
|
|
|
static void __meminit release_firmware_map_entry(struct kobject *kobj)
|
|
|
|
{
|
|
|
|
struct firmware_map_entry *entry = to_memmap_entry(kobj);
|
|
|
|
|
|
|
|
if (PageReserved(virt_to_page(entry))) {
|
|
|
|
/*
|
|
|
|
* Remember the storage allocated by bootmem, and reuse it when
|
|
|
|
* the memory is hot-added again. The entry will be added to
|
|
|
|
* map_entries_bootmem here, and deleted from &map_entries in
|
|
|
|
* firmware_map_remove_entry().
|
|
|
|
*/
|
2013-04-29 22:08:39 +00:00
|
|
|
spin_lock(&map_entries_bootmem_lock);
|
|
|
|
list_add(&entry->list, &map_entries_bootmem);
|
|
|
|
spin_unlock(&map_entries_bootmem_lock);
|
2013-02-23 00:32:56 +00:00
|
|
|
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
kfree(entry);
|
|
|
|
}
|
|
|
|
|
|
|
|
static struct kobj_type __refdata memmap_ktype = {
|
|
|
|
.release = release_firmware_map_entry,
|
2008-06-27 11:12:54 +00:00
|
|
|
.sysfs_ops = &memmap_attr_ops,
|
|
|
|
.default_attrs = def_attrs,
|
|
|
|
};
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Registration functions ------------------------------------------------------
|
|
|
|
*/
|
|
|
|
|
|
|
|
/**
|
2008-08-12 22:09:14 +00:00
|
|
|
* firmware_map_add_entry() - Does the real work to add a firmware memmap entry.
|
2008-06-27 11:12:54 +00:00
|
|
|
* @start: Start of the memory range.
|
2012-07-30 21:41:13 +00:00
|
|
|
* @end: End of the memory range (exclusive).
|
2008-06-27 11:12:54 +00:00
|
|
|
* @type: Type of the memory range.
|
|
|
|
* @entry: Pre-allocated (either kmalloc() or bootmem allocator), uninitialised
|
|
|
|
* entry.
|
2008-08-12 22:09:14 +00:00
|
|
|
*
|
|
|
|
* Common implementation of firmware_map_add() and firmware_map_add_early()
|
|
|
|
* which expects a pre-allocated struct firmware_map_entry.
|
2015-06-25 22:02:43 +00:00
|
|
|
*
|
|
|
|
* Return: 0 always
|
|
|
|
*/
|
2009-06-16 22:31:16 +00:00
|
|
|
static int firmware_map_add_entry(u64 start, u64 end,
|
2008-06-27 11:12:54 +00:00
|
|
|
const char *type,
|
|
|
|
struct firmware_map_entry *entry)
|
|
|
|
{
|
|
|
|
BUG_ON(start > end);
|
|
|
|
|
|
|
|
entry->start = start;
|
2012-07-30 21:41:13 +00:00
|
|
|
entry->end = end - 1;
|
2008-06-27 11:12:54 +00:00
|
|
|
entry->type = type;
|
|
|
|
INIT_LIST_HEAD(&entry->list);
|
|
|
|
kobject_init(&entry->kobj, &memmap_ktype);
|
|
|
|
|
2013-02-23 00:32:56 +00:00
|
|
|
spin_lock(&map_entries_lock);
|
2008-06-27 11:12:54 +00:00
|
|
|
list_add_tail(&entry->list, &map_entries);
|
2013-02-23 00:32:56 +00:00
|
|
|
spin_unlock(&map_entries_lock);
|
2008-06-27 11:12:54 +00:00
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2013-02-23 00:32:56 +00:00
|
|
|
/**
|
|
|
|
* firmware_map_remove_entry() - Does the real work to remove a firmware
|
|
|
|
* memmap entry.
|
|
|
|
* @entry: removed entry.
|
|
|
|
*
|
|
|
|
* The caller must hold map_entries_lock, and release it properly.
|
2015-06-25 22:02:43 +00:00
|
|
|
*/
|
2013-02-23 00:32:56 +00:00
|
|
|
static inline void firmware_map_remove_entry(struct firmware_map_entry *entry)
|
|
|
|
{
|
|
|
|
list_del(&entry->list);
|
|
|
|
}
|
|
|
|
|
2010-03-05 21:41:58 +00:00
|
|
|
/*
|
|
|
|
* Add memmap entry on sysfs
|
|
|
|
*/
|
|
|
|
static int add_sysfs_fw_map_entry(struct firmware_map_entry *entry)
|
|
|
|
{
|
|
|
|
static int map_entries_nr;
|
|
|
|
static struct kset *mmap_kset;
|
|
|
|
|
2014-10-09 22:29:07 +00:00
|
|
|
if (entry->kobj.state_in_sysfs)
|
|
|
|
return -EEXIST;
|
|
|
|
|
2010-03-05 21:41:58 +00:00
|
|
|
if (!mmap_kset) {
|
|
|
|
mmap_kset = kset_create_and_add("memmap", NULL, firmware_kobj);
|
|
|
|
if (!mmap_kset)
|
|
|
|
return -ENOMEM;
|
|
|
|
}
|
|
|
|
|
|
|
|
entry->kobj.kset = mmap_kset;
|
|
|
|
if (kobject_add(&entry->kobj, NULL, "%d", map_entries_nr++))
|
|
|
|
kobject_put(&entry->kobj);
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2013-02-23 00:32:56 +00:00
|
|
|
/*
|
|
|
|
* Remove memmap entry on sysfs
|
|
|
|
*/
|
|
|
|
static inline void remove_sysfs_fw_map_entry(struct firmware_map_entry *entry)
|
|
|
|
{
|
|
|
|
kobject_put(&entry->kobj);
|
|
|
|
}
|
|
|
|
|
2015-06-25 22:02:43 +00:00
|
|
|
/**
|
2013-02-23 00:32:56 +00:00
|
|
|
* firmware_map_find_entry_in_list() - Search memmap entry in a given list.
|
|
|
|
* @start: Start of the memory range.
|
|
|
|
* @end: End of the memory range (exclusive).
|
|
|
|
* @type: Type of the memory range.
|
|
|
|
* @list: In which to find the entry.
|
|
|
|
*
|
|
|
|
* This function is to find the memmap entey of a given memory range in a
|
|
|
|
* given list. The caller must hold map_entries_lock, and must not release
|
|
|
|
* the lock until the processing of the returned entry has completed.
|
|
|
|
*
|
|
|
|
* Return: Pointer to the entry to be found on success, or NULL on failure.
|
|
|
|
*/
|
|
|
|
static struct firmware_map_entry * __meminit
|
|
|
|
firmware_map_find_entry_in_list(u64 start, u64 end, const char *type,
|
|
|
|
struct list_head *list)
|
|
|
|
{
|
|
|
|
struct firmware_map_entry *entry;
|
|
|
|
|
|
|
|
list_for_each_entry(entry, list, list)
|
|
|
|
if ((entry->start == start) && (entry->end == end) &&
|
|
|
|
(!strcmp(entry->type, type))) {
|
|
|
|
return entry;
|
|
|
|
}
|
|
|
|
|
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
|
2015-06-25 22:02:43 +00:00
|
|
|
/**
|
2013-02-23 00:32:56 +00:00
|
|
|
* firmware_map_find_entry() - Search memmap entry in map_entries.
|
|
|
|
* @start: Start of the memory range.
|
|
|
|
* @end: End of the memory range (exclusive).
|
|
|
|
* @type: Type of the memory range.
|
|
|
|
*
|
|
|
|
* This function is to find the memmap entey of a given memory range.
|
|
|
|
* The caller must hold map_entries_lock, and must not release the lock
|
|
|
|
* until the processing of the returned entry has completed.
|
|
|
|
*
|
|
|
|
* Return: Pointer to the entry to be found on success, or NULL on failure.
|
|
|
|
*/
|
|
|
|
static struct firmware_map_entry * __meminit
|
|
|
|
firmware_map_find_entry(u64 start, u64 end, const char *type)
|
|
|
|
{
|
|
|
|
return firmware_map_find_entry_in_list(start, end, type, &map_entries);
|
|
|
|
}
|
|
|
|
|
2015-06-25 22:02:43 +00:00
|
|
|
/**
|
2013-02-23 00:32:56 +00:00
|
|
|
* firmware_map_find_entry_bootmem() - Search memmap entry in map_entries_bootmem.
|
|
|
|
* @start: Start of the memory range.
|
|
|
|
* @end: End of the memory range (exclusive).
|
|
|
|
* @type: Type of the memory range.
|
|
|
|
*
|
|
|
|
* This function is similar to firmware_map_find_entry except that it find the
|
|
|
|
* given entry in map_entries_bootmem.
|
|
|
|
*
|
|
|
|
* Return: Pointer to the entry to be found on success, or NULL on failure.
|
|
|
|
*/
|
|
|
|
static struct firmware_map_entry * __meminit
|
|
|
|
firmware_map_find_entry_bootmem(u64 start, u64 end, const char *type)
|
|
|
|
{
|
|
|
|
return firmware_map_find_entry_in_list(start, end, type,
|
|
|
|
&map_entries_bootmem);
|
|
|
|
}
|
|
|
|
|
2008-08-12 22:09:14 +00:00
|
|
|
/**
|
2010-03-05 21:41:58 +00:00
|
|
|
* firmware_map_add_hotplug() - Adds a firmware mapping entry when we do
|
|
|
|
* memory hotplug.
|
2008-08-12 22:09:14 +00:00
|
|
|
* @start: Start of the memory range.
|
2012-07-30 21:41:13 +00:00
|
|
|
* @end: End of the memory range (exclusive)
|
2008-08-12 22:09:14 +00:00
|
|
|
* @type: Type of the memory range.
|
|
|
|
*
|
2010-03-05 21:41:58 +00:00
|
|
|
* Adds a firmware mapping entry. This function is for memory hotplug, it is
|
|
|
|
* similar to function firmware_map_add_early(). The only difference is that
|
|
|
|
* it will create the syfs entry dynamically.
|
2008-08-12 22:09:14 +00:00
|
|
|
*
|
2015-06-25 22:02:43 +00:00
|
|
|
* Return: 0 on success, or -ENOMEM if no memory could be allocated.
|
|
|
|
*/
|
2010-03-05 21:41:58 +00:00
|
|
|
int __meminit firmware_map_add_hotplug(u64 start, u64 end, const char *type)
|
2008-06-27 11:12:54 +00:00
|
|
|
{
|
|
|
|
struct firmware_map_entry *entry;
|
|
|
|
|
drivers/firmware/memmap.c: don't allocate firmware_map_entry of same memory range
When limiting memory by mem= and ACPI DSDT table has PNP0C80,
firmware_map_entrys of same memory range are allocated and memmap X
sysfses which have same memory range are created as follows:
# cat /sys/firmware/memmap/0/*
0x407ffffffff
0x40000000000
System RAM
# cat /sys/firmware/memmap/33/*
0x407ffffffff
0x40000000000
System RAM
# cat /sys/firmware/memmap/35/*
0x407ffffffff
0x40000000000
System RAM
In this case, when hot-removing memory, kernel panic occurs, showing
following call trace:
BUG: unable to handle kernel paging request at 00000001003e000b
IP: sysfs_open_file+0x46/0x2b0
PGD 203a89fe067 PUD 0
Oops: 0000 [#1] SMP
...
Call Trace:
do_dentry_open+0x1ef/0x2a0
finish_open+0x31/0x40
do_last+0x57c/0x1220
path_openat+0xc2/0x4c0
do_filp_open+0x4b/0xb0
do_sys_open+0xf3/0x1f0
SyS_open+0x1e/0x20
system_call_fastpath+0x16/0x1b
The problem occurs as follows:
When calling e820_reserve_resources(), firmware_map_entrys of all e820
memory map are allocated. And all firmware_map_entrys is added
map_entries list as follows:
map_entries
-> +--- entry A --------+ -> ...
| start 0x407ffffffff|
| end 0x40000000000|
| type System RAM |
+--------------------+
After that, if ACPI DSDT table has PNP0C80 and the memory range is
limited by mem=, the PNP0C80 is hot-added. Then firmware_map_entry of
PNP0C80 is allocated and added map_entries list as follows:
map_entries
-> +--- entry A --------+ -> ... -> +--- entry B --------+
| start 0x407ffffffff| | start 0x407ffffffff|
| end 0x40000000000| | end 0x40000000000|
| type System RAM | | type System RAM |
+--------------------+ +--------------------+
Then memmap 0 sysfs for entry B is created.
After that, firmware_memmap_init() creates memmap sysfses of all
firmware_map_entrys in map_entries list. As a result, memmap 33 sysfs
for entry A and memmap 35 sysfs for entry B are created. But kobject of
entry B has been used by memmap 0 sysfs. So when creating memmap 35
sysfs, the kobject is broken.
If hot-removing memory, memmap 0 sysfs is destroyed and kobject of
memmap 0 sysfs is freed. But the kobject can be accessed via memmap 35
sysfs. So when open memmap 35 sysfs, kernel panic occurs.
This patch checks whether there is firmware_map_entry of same memory
range in map_entries list and don't allocate firmware_map_entry of same
memroy range.
Signed-off-by: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
Cc: Santosh Shilimkar <santosh.shilimkar@ti.com>
Cc: Toshi Kani <toshi.kani@hp.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2014-08-06 23:07:03 +00:00
|
|
|
entry = firmware_map_find_entry(start, end - 1, type);
|
|
|
|
if (entry)
|
|
|
|
return 0;
|
|
|
|
|
2014-08-06 23:07:00 +00:00
|
|
|
entry = firmware_map_find_entry_bootmem(start, end - 1, type);
|
2013-02-23 00:32:56 +00:00
|
|
|
if (!entry) {
|
|
|
|
entry = kzalloc(sizeof(struct firmware_map_entry), GFP_ATOMIC);
|
|
|
|
if (!entry)
|
|
|
|
return -ENOMEM;
|
|
|
|
} else {
|
|
|
|
/* Reuse storage allocated by bootmem. */
|
|
|
|
spin_lock(&map_entries_bootmem_lock);
|
|
|
|
list_del(&entry->list);
|
|
|
|
spin_unlock(&map_entries_bootmem_lock);
|
|
|
|
|
|
|
|
memset(entry, 0, sizeof(*entry));
|
|
|
|
}
|
2008-06-27 11:12:54 +00:00
|
|
|
|
2010-03-05 21:41:58 +00:00
|
|
|
firmware_map_add_entry(start, end, type, entry);
|
|
|
|
/* create the memmap entry */
|
|
|
|
add_sysfs_fw_map_entry(entry);
|
|
|
|
|
|
|
|
return 0;
|
2008-06-27 11:12:54 +00:00
|
|
|
}
|
|
|
|
|
2008-08-12 22:09:14 +00:00
|
|
|
/**
|
|
|
|
* firmware_map_add_early() - Adds a firmware mapping entry.
|
|
|
|
* @start: Start of the memory range.
|
2012-07-30 21:41:13 +00:00
|
|
|
* @end: End of the memory range.
|
2008-08-12 22:09:14 +00:00
|
|
|
* @type: Type of the memory range.
|
|
|
|
*
|
|
|
|
* Adds a firmware mapping entry. This function uses the bootmem allocator
|
2010-03-05 21:41:58 +00:00
|
|
|
* for memory allocation.
|
2008-08-12 22:09:14 +00:00
|
|
|
*
|
|
|
|
* That function must be called before late_initcall.
|
|
|
|
*
|
2015-06-25 22:02:43 +00:00
|
|
|
* Return: 0 on success, or -ENOMEM if no memory could be allocated.
|
|
|
|
*/
|
2009-06-16 22:31:16 +00:00
|
|
|
int __init firmware_map_add_early(u64 start, u64 end, const char *type)
|
2008-06-27 11:12:54 +00:00
|
|
|
{
|
|
|
|
struct firmware_map_entry *entry;
|
|
|
|
|
2019-03-12 06:30:42 +00:00
|
|
|
entry = memblock_alloc(sizeof(struct firmware_map_entry),
|
memblock: stop using implicit alignment to SMP_CACHE_BYTES
When a memblock allocation APIs are called with align = 0, the alignment
is implicitly set to SMP_CACHE_BYTES.
Implicit alignment is done deep in the memblock allocator and it can
come as a surprise. Not that such an alignment would be wrong even
when used incorrectly but it is better to be explicit for the sake of
clarity and the prinicple of the least surprise.
Replace all such uses of memblock APIs with the 'align' parameter
explicitly set to SMP_CACHE_BYTES and stop implicit alignment assignment
in the memblock internal allocation functions.
For the case when memblock APIs are used via helper functions, e.g. like
iommu_arena_new_node() in Alpha, the helper functions were detected with
Coccinelle's help and then manually examined and updated where
appropriate.
The direct memblock APIs users were updated using the semantic patch below:
@@
expression size, min_addr, max_addr, nid;
@@
(
|
- memblock_alloc_try_nid_raw(size, 0, min_addr, max_addr, nid)
+ memblock_alloc_try_nid_raw(size, SMP_CACHE_BYTES, min_addr, max_addr,
nid)
|
- memblock_alloc_try_nid_nopanic(size, 0, min_addr, max_addr, nid)
+ memblock_alloc_try_nid_nopanic(size, SMP_CACHE_BYTES, min_addr, max_addr,
nid)
|
- memblock_alloc_try_nid(size, 0, min_addr, max_addr, nid)
+ memblock_alloc_try_nid(size, SMP_CACHE_BYTES, min_addr, max_addr, nid)
|
- memblock_alloc(size, 0)
+ memblock_alloc(size, SMP_CACHE_BYTES)
|
- memblock_alloc_raw(size, 0)
+ memblock_alloc_raw(size, SMP_CACHE_BYTES)
|
- memblock_alloc_from(size, 0, min_addr)
+ memblock_alloc_from(size, SMP_CACHE_BYTES, min_addr)
|
- memblock_alloc_nopanic(size, 0)
+ memblock_alloc_nopanic(size, SMP_CACHE_BYTES)
|
- memblock_alloc_low(size, 0)
+ memblock_alloc_low(size, SMP_CACHE_BYTES)
|
- memblock_alloc_low_nopanic(size, 0)
+ memblock_alloc_low_nopanic(size, SMP_CACHE_BYTES)
|
- memblock_alloc_from_nopanic(size, 0, min_addr)
+ memblock_alloc_from_nopanic(size, SMP_CACHE_BYTES, min_addr)
|
- memblock_alloc_node(size, 0, nid)
+ memblock_alloc_node(size, SMP_CACHE_BYTES, nid)
)
[mhocko@suse.com: changelog update]
[akpm@linux-foundation.org: coding-style fixes]
[rppt@linux.ibm.com: fix missed uses of implicit alignment]
Link: http://lkml.kernel.org/r/20181016133656.GA10925@rapoport-lnx
Link: http://lkml.kernel.org/r/1538687224-17535-1-git-send-email-rppt@linux.vnet.ibm.com
Signed-off-by: Mike Rapoport <rppt@linux.vnet.ibm.com>
Suggested-by: Michal Hocko <mhocko@suse.com>
Acked-by: Paul Burton <paul.burton@mips.com> [MIPS]
Acked-by: Michael Ellerman <mpe@ellerman.id.au> [powerpc]
Acked-by: Michal Hocko <mhocko@suse.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: Chris Zankel <chris@zankel.net>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Guan Xuetao <gxt@pku.edu.cn>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Matt Turner <mattst88@gmail.com>
Cc: Michal Simek <monstr@monstr.eu>
Cc: Richard Weinberger <richard@nod.at>
Cc: Russell King <linux@armlinux.org.uk>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Tony Luck <tony.luck@intel.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2018-10-30 22:09:57 +00:00
|
|
|
SMP_CACHE_BYTES);
|
2008-08-12 22:09:14 +00:00
|
|
|
if (WARN_ON(!entry))
|
2008-06-27 11:12:54 +00:00
|
|
|
return -ENOMEM;
|
|
|
|
|
|
|
|
return firmware_map_add_entry(start, end, type, entry);
|
|
|
|
}
|
|
|
|
|
2013-02-23 00:32:56 +00:00
|
|
|
/**
|
|
|
|
* firmware_map_remove() - remove a firmware mapping entry
|
|
|
|
* @start: Start of the memory range.
|
|
|
|
* @end: End of the memory range.
|
|
|
|
* @type: Type of the memory range.
|
|
|
|
*
|
|
|
|
* removes a firmware mapping entry.
|
|
|
|
*
|
2015-06-25 22:02:43 +00:00
|
|
|
* Return: 0 on success, or -EINVAL if no entry.
|
|
|
|
*/
|
2013-02-23 00:32:56 +00:00
|
|
|
int __meminit firmware_map_remove(u64 start, u64 end, const char *type)
|
|
|
|
{
|
|
|
|
struct firmware_map_entry *entry;
|
|
|
|
|
|
|
|
spin_lock(&map_entries_lock);
|
|
|
|
entry = firmware_map_find_entry(start, end - 1, type);
|
|
|
|
if (!entry) {
|
|
|
|
spin_unlock(&map_entries_lock);
|
|
|
|
return -EINVAL;
|
|
|
|
}
|
|
|
|
|
|
|
|
firmware_map_remove_entry(entry);
|
|
|
|
spin_unlock(&map_entries_lock);
|
|
|
|
|
|
|
|
/* remove the memmap entry */
|
|
|
|
remove_sysfs_fw_map_entry(entry);
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2008-06-27 11:12:54 +00:00
|
|
|
/*
|
|
|
|
* Sysfs functions -------------------------------------------------------------
|
|
|
|
*/
|
|
|
|
|
|
|
|
static ssize_t start_show(struct firmware_map_entry *entry, char *buf)
|
|
|
|
{
|
2008-07-26 22:22:28 +00:00
|
|
|
return snprintf(buf, PAGE_SIZE, "0x%llx\n",
|
|
|
|
(unsigned long long)entry->start);
|
2008-06-27 11:12:54 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
static ssize_t end_show(struct firmware_map_entry *entry, char *buf)
|
|
|
|
{
|
2008-07-26 22:22:28 +00:00
|
|
|
return snprintf(buf, PAGE_SIZE, "0x%llx\n",
|
|
|
|
(unsigned long long)entry->end);
|
2008-06-27 11:12:54 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
static ssize_t type_show(struct firmware_map_entry *entry, char *buf)
|
|
|
|
{
|
|
|
|
return snprintf(buf, PAGE_SIZE, "%s\n", entry->type);
|
|
|
|
}
|
|
|
|
|
2013-02-23 00:32:56 +00:00
|
|
|
static inline struct memmap_attribute *to_memmap_attr(struct attribute *attr)
|
|
|
|
{
|
|
|
|
return container_of(attr, struct memmap_attribute, attr);
|
|
|
|
}
|
2008-06-27 11:12:54 +00:00
|
|
|
|
|
|
|
static ssize_t memmap_attr_show(struct kobject *kobj,
|
|
|
|
struct attribute *attr, char *buf)
|
|
|
|
{
|
|
|
|
struct firmware_map_entry *entry = to_memmap_entry(kobj);
|
|
|
|
struct memmap_attribute *memmap_attr = to_memmap_attr(attr);
|
|
|
|
|
|
|
|
return memmap_attr->show(entry, buf);
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Initialises stuff and adds the entries in the map_entries list to
|
|
|
|
* sysfs. Important is that firmware_map_add() and firmware_map_add_early()
|
2008-08-12 22:09:14 +00:00
|
|
|
* must be called before late_initcall. That's just because that function
|
|
|
|
* is called as late_initcall() function, which means that if you call
|
|
|
|
* firmware_map_add() or firmware_map_add_early() afterwards, the entries
|
|
|
|
* are not added to sysfs.
|
2008-06-27 11:12:54 +00:00
|
|
|
*/
|
2012-10-19 20:56:55 +00:00
|
|
|
static int __init firmware_memmap_init(void)
|
2008-06-27 11:12:54 +00:00
|
|
|
{
|
|
|
|
struct firmware_map_entry *entry;
|
|
|
|
|
2010-03-05 21:41:58 +00:00
|
|
|
list_for_each_entry(entry, &map_entries, list)
|
|
|
|
add_sysfs_fw_map_entry(entry);
|
2008-06-27 11:12:54 +00:00
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
2012-10-19 20:56:55 +00:00
|
|
|
late_initcall(firmware_memmap_init);
|
2008-06-27 11:12:54 +00:00
|
|
|
|