2019-05-27 06:55:01 +00:00
|
|
|
// SPDX-License-Identifier: GPL-2.0-or-later
|
2005-04-16 22:20:36 +00:00
|
|
|
/*
|
|
|
|
* Forwarding decision
|
|
|
|
* Linux ethernet bridge
|
|
|
|
*
|
|
|
|
* Authors:
|
|
|
|
* Lennert Buytenhek <buytenh@gnu.org>
|
|
|
|
*/
|
|
|
|
|
2010-02-27 19:41:43 +00:00
|
|
|
#include <linux/err.h>
|
include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h
percpu.h is included by sched.h and module.h and thus ends up being
included when building most .c files. percpu.h includes slab.h which
in turn includes gfp.h making everything defined by the two files
universally available and complicating inclusion dependencies.
percpu.h -> slab.h dependency is about to be removed. Prepare for
this change by updating users of gfp and slab facilities include those
headers directly instead of assuming availability. As this conversion
needs to touch large number of source files, the following script is
used as the basis of conversion.
http://userweb.kernel.org/~tj/misc/slabh-sweep.py
The script does the followings.
* Scan files for gfp and slab usages and update includes such that
only the necessary includes are there. ie. if only gfp is used,
gfp.h, if slab is used, slab.h.
* When the script inserts a new include, it looks at the include
blocks and try to put the new include such that its order conforms
to its surrounding. It's put in the include block which contains
core kernel includes, in the same order that the rest are ordered -
alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
doesn't seem to be any matching order.
* If the script can't find a place to put a new include (mostly
because the file doesn't have fitting include block), it prints out
an error message indicating which .h file needs to be added to the
file.
The conversion was done in the following steps.
1. The initial automatic conversion of all .c files updated slightly
over 4000 files, deleting around 700 includes and adding ~480 gfp.h
and ~3000 slab.h inclusions. The script emitted errors for ~400
files.
2. Each error was manually checked. Some didn't need the inclusion,
some needed manual addition while adding it to implementation .h or
embedding .c file was more appropriate for others. This step added
inclusions to around 150 files.
3. The script was run again and the output was compared to the edits
from #2 to make sure no file was left behind.
4. Several build tests were done and a couple of problems were fixed.
e.g. lib/decompress_*.c used malloc/free() wrappers around slab
APIs requiring slab.h to be added manually.
5. The script was run on all .h files but without automatically
editing them as sprinkling gfp.h and slab.h inclusions around .h
files could easily lead to inclusion dependency hell. Most gfp.h
inclusion directives were ignored as stuff from gfp.h was usually
wildly available and often used in preprocessor macros. Each
slab.h inclusion directive was examined and added manually as
necessary.
6. percpu.h was updated not to include slab.h.
7. Build test were done on the following configurations and failures
were fixed. CONFIG_GCOV_KERNEL was turned off for all tests (as my
distributed build env didn't work with gcov compiles) and a few
more options had to be turned off depending on archs to make things
build (like ipr on powerpc/64 which failed due to missing writeq).
* x86 and x86_64 UP and SMP allmodconfig and a custom test config.
* powerpc and powerpc64 SMP allmodconfig
* sparc and sparc64 SMP allmodconfig
* ia64 SMP allmodconfig
* s390 SMP allmodconfig
* alpha SMP allmodconfig
* um on x86_64 SMP allmodconfig
8. percpu.h modifications were reverted so that it could be applied as
a separate patch and serve as bisection point.
Given the fact that I had only a couple of failures from tests on step
6, I'm fairly confident about the coverage of this conversion patch.
If there is a breakage, it's likely to be something in one of the arch
headers which should be easily discoverable easily on most builds of
the specific arch.
Signed-off-by: Tejun Heo <tj@kernel.org>
Guess-its-ok-by: Christoph Lameter <cl@linux-foundation.org>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
2010-03-24 08:04:11 +00:00
|
|
|
#include <linux/slab.h>
|
2005-04-16 22:20:36 +00:00
|
|
|
#include <linux/kernel.h>
|
|
|
|
#include <linux/netdevice.h>
|
2010-05-06 07:48:24 +00:00
|
|
|
#include <linux/netpoll.h>
|
2005-04-16 22:20:36 +00:00
|
|
|
#include <linux/skbuff.h>
|
2006-04-26 09:39:19 +00:00
|
|
|
#include <linux/if_vlan.h>
|
2005-04-16 22:20:36 +00:00
|
|
|
#include <linux/netfilter_bridge.h>
|
|
|
|
#include "br_private.h"
|
|
|
|
|
2013-12-16 13:32:46 +00:00
|
|
|
/* Don't forward packets to originating port or forwarding disabled */
|
2007-02-09 14:24:35 +00:00
|
|
|
static inline int should_deliver(const struct net_bridge_port *p,
|
2005-04-16 22:20:36 +00:00
|
|
|
const struct sk_buff *skb)
|
|
|
|
{
|
bridge: vlan: add per-vlan struct and move to rhashtables
This patch changes the bridge vlan implementation to use rhashtables
instead of bitmaps. The main motivation behind this change is that we
need extensible per-vlan structures (both per-port and global) so more
advanced features can be introduced and the vlan support can be
extended. I've tried to break this up but the moment net_port_vlans is
changed and the whole API goes away, thus this is a larger patch.
A few short goals of this patch are:
- Extensible per-vlan structs stored in rhashtables and a sorted list
- Keep user-visible behaviour (compressed vlans etc)
- Keep fastpath ingress/egress logic the same (optimizations to come
later)
Here's a brief list of some of the new features we'd like to introduce:
- per-vlan counters
- vlan ingress/egress mapping
- per-vlan igmp configuration
- vlan priorities
- avoid fdb entries replication (e.g. local fdb scaling issues)
The structure is kept single for both global and per-port entries so to
avoid code duplication where possible and also because we'll soon introduce
"port0 / aka bridge as port" which should simplify things further
(thanks to Vlad for the suggestion!).
Now we have per-vlan global rhashtable (bridge-wide) and per-vlan port
rhashtable, if an entry is added to a port it'll get a pointer to its
global context so it can be quickly accessed later. There's also a
sorted vlan list which is used for stable walks and some user-visible
behaviour such as the vlan ranges, also for error paths.
VLANs are stored in a "vlan group" which currently contains the
rhashtable, sorted vlan list and the number of "real" vlan entries.
A good side-effect of this change is that it resembles how hw keeps
per-vlan data.
One important note after this change is that if a VLAN is being looked up
in the bridge's rhashtable for filtering purposes (or to check if it's an
existing usable entry, not just a global context) then the new helper
br_vlan_should_use() needs to be used if the vlan is found. In case the
lookup is done only with a port's vlan group, then this check can be
skipped.
Things tested so far:
- basic vlan ingress/egress
- pvids
- untagged vlans
- undef CONFIG_BRIDGE_VLAN_FILTERING
- adding/deleting vlans in different scenarios (with/without global ctx,
while transmitting traffic, in ranges etc)
- loading/removing the module while having/adding/deleting vlans
- extracting bridge vlan information (user ABI), compressed requests
- adding/deleting fdbs on vlans
- bridge mac change, promisc mode
- default pvid change
- kmemleak ON during the whole time
Signed-off-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2015-09-25 17:00:11 +00:00
|
|
|
struct net_bridge_vlan_group *vg;
|
|
|
|
|
2015-10-12 19:47:02 +00:00
|
|
|
vg = nbp_vlan_group_rcu(p);
|
2013-12-19 05:28:11 +00:00
|
|
|
return ((p->flags & BR_HAIRPIN_MODE) || skb->dev != p->dev) &&
|
2024-07-12 01:31:33 +00:00
|
|
|
(br_mst_is_enabled(p->br) || p->state == BR_STATE_FORWARDING) &&
|
|
|
|
br_allowed_egress(vg, skb) && nbp_switchdev_allowed_egress(p, skb) &&
|
2018-05-24 08:56:48 +00:00
|
|
|
!br_skb_isolated(p, skb);
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
|
2015-09-16 01:04:18 +00:00
|
|
|
int br_dev_queue_push_xmit(struct net *net, struct sock *sk, struct sk_buff *skb)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
2019-01-17 01:46:41 +00:00
|
|
|
skb_push(skb, ETH_HLEN);
|
2015-07-28 10:05:37 +00:00
|
|
|
if (!is_skb_forwardable(skb->dev, skb))
|
|
|
|
goto drop;
|
|
|
|
|
|
|
|
br_drop_fake_rtable(skb);
|
|
|
|
|
|
|
|
if (skb->ip_summed == CHECKSUM_PARTIAL &&
|
2021-01-17 08:09:50 +00:00
|
|
|
eth_type_vlan(skb->protocol)) {
|
2015-07-28 10:05:37 +00:00
|
|
|
int depth;
|
|
|
|
|
2023-05-09 13:18:57 +00:00
|
|
|
if (!vlan_get_protocol_and_depth(skb, skb->protocol, &depth))
|
2015-07-28 10:05:37 +00:00
|
|
|
goto drop;
|
|
|
|
|
|
|
|
skb_set_network_header(skb, depth);
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
|
2021-07-23 20:49:11 +00:00
|
|
|
br_switchdev_frame_set_offload_fwd_mark(skb);
|
2021-07-22 15:55:38 +00:00
|
|
|
|
2015-07-28 10:05:37 +00:00
|
|
|
dev_queue_xmit(skb);
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
drop:
|
|
|
|
kfree_skb(skb);
|
2005-04-16 22:20:36 +00:00
|
|
|
return 0;
|
|
|
|
}
|
2014-09-18 09:29:03 +00:00
|
|
|
EXPORT_SYMBOL_GPL(br_dev_queue_push_xmit);
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2015-09-16 01:04:18 +00:00
|
|
|
int br_forward_finish(struct net *net, struct sock *sk, struct sk_buff *skb)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
2022-03-02 19:55:31 +00:00
|
|
|
skb_clear_tstamp(skb);
|
2015-09-16 01:04:16 +00:00
|
|
|
return NF_HOOK(NFPROTO_BRIDGE, NF_BR_POST_ROUTING,
|
|
|
|
net, sk, skb, NULL, skb->dev,
|
2006-05-25 22:58:54 +00:00
|
|
|
br_dev_queue_push_xmit);
|
2005-04-16 22:20:36 +00:00
|
|
|
|
|
|
|
}
|
2014-09-18 09:29:03 +00:00
|
|
|
EXPORT_SYMBOL_GPL(br_forward_finish);
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2016-07-14 03:10:02 +00:00
|
|
|
static void __br_forward(const struct net_bridge_port *to,
|
|
|
|
struct sk_buff *skb, bool local_orig)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
bridge: vlan: add per-vlan struct and move to rhashtables
This patch changes the bridge vlan implementation to use rhashtables
instead of bitmaps. The main motivation behind this change is that we
need extensible per-vlan structures (both per-port and global) so more
advanced features can be introduced and the vlan support can be
extended. I've tried to break this up but the moment net_port_vlans is
changed and the whole API goes away, thus this is a larger patch.
A few short goals of this patch are:
- Extensible per-vlan structs stored in rhashtables and a sorted list
- Keep user-visible behaviour (compressed vlans etc)
- Keep fastpath ingress/egress logic the same (optimizations to come
later)
Here's a brief list of some of the new features we'd like to introduce:
- per-vlan counters
- vlan ingress/egress mapping
- per-vlan igmp configuration
- vlan priorities
- avoid fdb entries replication (e.g. local fdb scaling issues)
The structure is kept single for both global and per-port entries so to
avoid code duplication where possible and also because we'll soon introduce
"port0 / aka bridge as port" which should simplify things further
(thanks to Vlad for the suggestion!).
Now we have per-vlan global rhashtable (bridge-wide) and per-vlan port
rhashtable, if an entry is added to a port it'll get a pointer to its
global context so it can be quickly accessed later. There's also a
sorted vlan list which is used for stable walks and some user-visible
behaviour such as the vlan ranges, also for error paths.
VLANs are stored in a "vlan group" which currently contains the
rhashtable, sorted vlan list and the number of "real" vlan entries.
A good side-effect of this change is that it resembles how hw keeps
per-vlan data.
One important note after this change is that if a VLAN is being looked up
in the bridge's rhashtable for filtering purposes (or to check if it's an
existing usable entry, not just a global context) then the new helper
br_vlan_should_use() needs to be used if the vlan is found. In case the
lookup is done only with a port's vlan group, then this check can be
skipped.
Things tested so far:
- basic vlan ingress/egress
- pvids
- untagged vlans
- undef CONFIG_BRIDGE_VLAN_FILTERING
- adding/deleting vlans in different scenarios (with/without global ctx,
while transmitting traffic, in ranges etc)
- loading/removing the module while having/adding/deleting vlans
- extracting bridge vlan information (user ABI), compressed requests
- adding/deleting fdbs on vlans
- bridge mac change, promisc mode
- default pvid change
- kmemleak ON during the whole time
Signed-off-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2015-09-25 17:00:11 +00:00
|
|
|
struct net_bridge_vlan_group *vg;
|
2016-07-14 03:10:02 +00:00
|
|
|
struct net_device *indev;
|
|
|
|
struct net *net;
|
|
|
|
int br_hook;
|
bridge: vlan: add per-vlan struct and move to rhashtables
This patch changes the bridge vlan implementation to use rhashtables
instead of bitmaps. The main motivation behind this change is that we
need extensible per-vlan structures (both per-port and global) so more
advanced features can be introduced and the vlan support can be
extended. I've tried to break this up but the moment net_port_vlans is
changed and the whole API goes away, thus this is a larger patch.
A few short goals of this patch are:
- Extensible per-vlan structs stored in rhashtables and a sorted list
- Keep user-visible behaviour (compressed vlans etc)
- Keep fastpath ingress/egress logic the same (optimizations to come
later)
Here's a brief list of some of the new features we'd like to introduce:
- per-vlan counters
- vlan ingress/egress mapping
- per-vlan igmp configuration
- vlan priorities
- avoid fdb entries replication (e.g. local fdb scaling issues)
The structure is kept single for both global and per-port entries so to
avoid code duplication where possible and also because we'll soon introduce
"port0 / aka bridge as port" which should simplify things further
(thanks to Vlad for the suggestion!).
Now we have per-vlan global rhashtable (bridge-wide) and per-vlan port
rhashtable, if an entry is added to a port it'll get a pointer to its
global context so it can be quickly accessed later. There's also a
sorted vlan list which is used for stable walks and some user-visible
behaviour such as the vlan ranges, also for error paths.
VLANs are stored in a "vlan group" which currently contains the
rhashtable, sorted vlan list and the number of "real" vlan entries.
A good side-effect of this change is that it resembles how hw keeps
per-vlan data.
One important note after this change is that if a VLAN is being looked up
in the bridge's rhashtable for filtering purposes (or to check if it's an
existing usable entry, not just a global context) then the new helper
br_vlan_should_use() needs to be used if the vlan is found. In case the
lookup is done only with a port's vlan group, then this check can be
skipped.
Things tested so far:
- basic vlan ingress/egress
- pvids
- untagged vlans
- undef CONFIG_BRIDGE_VLAN_FILTERING
- adding/deleting vlans in different scenarios (with/without global ctx,
while transmitting traffic, in ranges etc)
- loading/removing the module while having/adding/deleting vlans
- extracting bridge vlan information (user ABI), compressed requests
- adding/deleting fdbs on vlans
- bridge mac change, promisc mode
- default pvid change
- kmemleak ON during the whole time
Signed-off-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2015-09-25 17:00:11 +00:00
|
|
|
|
2021-07-22 15:55:38 +00:00
|
|
|
/* Mark the skb for forwarding offload early so that br_handle_vlan()
|
|
|
|
* can know whether to pop the VLAN header on egress or keep it.
|
|
|
|
*/
|
|
|
|
nbp_switchdev_frame_mark_tx_fwd_offload(to, skb);
|
|
|
|
|
2015-10-12 19:47:02 +00:00
|
|
|
vg = nbp_vlan_group_rcu(to);
|
2017-02-01 06:59:55 +00:00
|
|
|
skb = br_handle_vlan(to->br, to, vg, skb);
|
2013-02-13 12:00:14 +00:00
|
|
|
if (!skb)
|
|
|
|
return;
|
|
|
|
|
2016-07-14 03:10:02 +00:00
|
|
|
indev = skb->dev;
|
2005-04-16 22:20:36 +00:00
|
|
|
skb->dev = to->dev;
|
2016-07-14 03:10:02 +00:00
|
|
|
if (!local_orig) {
|
|
|
|
if (skb_warn_if_lro(skb)) {
|
2010-06-10 16:12:50 +00:00
|
|
|
kfree_skb(skb);
|
2016-07-14 03:10:02 +00:00
|
|
|
return;
|
2010-06-10 16:12:50 +00:00
|
|
|
}
|
2016-07-14 03:10:02 +00:00
|
|
|
br_hook = NF_BR_FORWARD;
|
|
|
|
skb_forward_csum(skb);
|
|
|
|
net = dev_net(indev);
|
|
|
|
} else {
|
|
|
|
if (unlikely(netpoll_tx_running(to->br->dev))) {
|
2019-01-17 01:46:41 +00:00
|
|
|
skb_push(skb, ETH_HLEN);
|
|
|
|
if (!is_skb_forwardable(skb->dev, skb))
|
2016-07-14 03:10:02 +00:00
|
|
|
kfree_skb(skb);
|
2019-01-17 01:46:41 +00:00
|
|
|
else
|
2016-07-14 03:10:02 +00:00
|
|
|
br_netpoll_send_skb(to, skb);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
br_hook = NF_BR_LOCAL_OUT;
|
|
|
|
net = dev_net(skb->dev);
|
|
|
|
indev = NULL;
|
2010-06-10 16:12:50 +00:00
|
|
|
}
|
|
|
|
|
2016-07-14 03:10:02 +00:00
|
|
|
NF_HOOK(NFPROTO_BRIDGE, br_hook,
|
|
|
|
net, NULL, skb, indev, skb->dev,
|
2010-03-23 03:07:21 +00:00
|
|
|
br_forward_finish);
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
|
2016-07-14 03:10:02 +00:00
|
|
|
static int deliver_clone(const struct net_bridge_port *prev,
|
|
|
|
struct sk_buff *skb, bool local_orig)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
2016-07-14 03:10:02 +00:00
|
|
|
struct net_device *dev = BR_INPUT_SKB_CB(skb)->brdev;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2016-07-14 03:10:02 +00:00
|
|
|
skb = skb_clone(skb, GFP_ATOMIC);
|
|
|
|
if (!skb) {
|
2023-09-18 09:13:51 +00:00
|
|
|
DEV_STATS_INC(dev, tx_dropped);
|
2016-07-14 03:10:02 +00:00
|
|
|
return -ENOMEM;
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
|
2016-07-14 03:10:02 +00:00
|
|
|
__br_forward(prev, skb, local_orig);
|
|
|
|
return 0;
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
|
2016-07-14 03:10:02 +00:00
|
|
|
/**
|
|
|
|
* br_forward - forward a packet to a specific port
|
|
|
|
* @to: destination port
|
|
|
|
* @skb: packet being forwarded
|
|
|
|
* @local_rcv: packet will be received locally after forwarding
|
|
|
|
* @local_orig: packet is locally originated
|
|
|
|
*
|
|
|
|
* Should be called with rcu_read_lock.
|
|
|
|
*/
|
|
|
|
void br_forward(const struct net_bridge_port *to,
|
|
|
|
struct sk_buff *skb, bool local_rcv, bool local_orig)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
2018-07-23 08:16:59 +00:00
|
|
|
if (unlikely(!to))
|
|
|
|
goto out;
|
|
|
|
|
|
|
|
/* redirect to backup link if the destination port is down */
|
|
|
|
if (rcu_access_pointer(to->backup_port) && !netif_carrier_ok(to->dev)) {
|
|
|
|
struct net_bridge_port *backup_port;
|
|
|
|
|
|
|
|
backup_port = rcu_dereference(to->backup_port);
|
|
|
|
if (unlikely(!backup_port))
|
|
|
|
goto out;
|
bridge: Add backup nexthop ID support
Add a new bridge port attribute that allows attaching a nexthop object
ID to an skb that is redirected to a backup bridge port with VLAN
tunneling enabled.
Specifically, when redirecting a known unicast packet, read the backup
nexthop ID from the bridge port that lost its carrier and set it in the
bridge control block of the skb before forwarding it via the backup
port. Note that reading the ID from the bridge port should not result in
a cache miss as the ID is added next to the 'backup_port' field that was
already accessed. After this change, the 'state' field still stays on
the first cache line, together with other data path related fields such
as 'flags and 'vlgrp':
struct net_bridge_port {
struct net_bridge * br; /* 0 8 */
struct net_device * dev; /* 8 8 */
netdevice_tracker dev_tracker; /* 16 0 */
struct list_head list; /* 16 16 */
long unsigned int flags; /* 32 8 */
struct net_bridge_vlan_group * vlgrp; /* 40 8 */
struct net_bridge_port * backup_port; /* 48 8 */
u32 backup_nhid; /* 56 4 */
u8 priority; /* 60 1 */
u8 state; /* 61 1 */
u16 port_no; /* 62 2 */
/* --- cacheline 1 boundary (64 bytes) --- */
[...]
} __attribute__((__aligned__(8)));
When forwarding an skb via a bridge port that has VLAN tunneling
enabled, check if the backup nexthop ID stored in the bridge control
block is valid (i.e., not zero). If so, instead of attaching the
pre-allocated metadata (that only has the tunnel key set), allocate a
new metadata, set both the tunnel key and the nexthop object ID and
attach it to the skb.
By default, do not dump the new attribute to user space as a value of
zero is an invalid nexthop object ID.
The above is useful for EVPN multihoming. When one of the links
composing an Ethernet Segment (ES) fails, traffic needs to be redirected
towards the host via one of the other ES peers. For example, if a host
is multihomed to three different VTEPs, the backup port of each ES link
needs to be set to the VXLAN device and the backup nexthop ID needs to
point to an FDB nexthop group that includes the IP addresses of the
other two VTEPs. The VXLAN driver will extract the ID from the metadata
of the redirected skb, calculate its flow hash and forward it towards
one of the other VTEPs. If the ID does not exist, or represents an
invalid nexthop object, the VXLAN driver will drop the skb. This
relieves the bridge driver from the need to validate the ID.
Signed-off-by: Ido Schimmel <idosch@nvidia.com>
Acked-by: Nikolay Aleksandrov <razor@blackwall.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
2023-07-17 08:12:28 +00:00
|
|
|
BR_INPUT_SKB_CB(skb)->backup_nhid = READ_ONCE(to->backup_nhid);
|
2018-07-23 08:16:59 +00:00
|
|
|
to = backup_port;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (should_deliver(to, skb)) {
|
2016-07-14 03:10:01 +00:00
|
|
|
if (local_rcv)
|
2016-07-14 03:10:02 +00:00
|
|
|
deliver_clone(to, skb, local_orig);
|
2010-03-16 07:26:22 +00:00
|
|
|
else
|
2016-07-14 03:10:02 +00:00
|
|
|
__br_forward(to, skb, local_orig);
|
2005-04-16 22:20:36 +00:00
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2018-07-23 08:16:59 +00:00
|
|
|
out:
|
2016-07-14 03:10:01 +00:00
|
|
|
if (!local_rcv)
|
2010-03-16 07:26:22 +00:00
|
|
|
kfree_skb(skb);
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
2016-07-14 03:10:02 +00:00
|
|
|
EXPORT_SYMBOL_GPL(br_forward);
|
2010-02-27 19:41:43 +00:00
|
|
|
|
|
|
|
static struct net_bridge_port *maybe_deliver(
|
|
|
|
struct net_bridge_port *prev, struct net_bridge_port *p,
|
2016-07-14 03:10:02 +00:00
|
|
|
struct sk_buff *skb, bool local_orig)
|
2010-02-27 19:41:43 +00:00
|
|
|
{
|
2019-04-04 11:56:38 +00:00
|
|
|
u8 igmp_type = br_multicast_igmp_type(skb);
|
2010-02-27 19:41:43 +00:00
|
|
|
int err;
|
|
|
|
|
|
|
|
if (!should_deliver(p, skb))
|
|
|
|
return prev;
|
|
|
|
|
2021-07-22 15:55:38 +00:00
|
|
|
nbp_switchdev_frame_mark_tx_fwd_to_hwdom(p, skb);
|
|
|
|
|
2010-02-27 19:41:43 +00:00
|
|
|
if (!prev)
|
|
|
|
goto out;
|
|
|
|
|
2016-07-14 03:10:02 +00:00
|
|
|
err = deliver_clone(prev, skb, local_orig);
|
2010-02-27 19:41:43 +00:00
|
|
|
if (err)
|
|
|
|
return ERR_PTR(err);
|
|
|
|
out:
|
2019-04-04 11:56:38 +00:00
|
|
|
br_multicast_count(p->br, p, skb, igmp_type, BR_MCAST_DIR_TX);
|
|
|
|
|
2010-02-27 19:41:43 +00:00
|
|
|
return p;
|
|
|
|
}
|
|
|
|
|
2016-07-14 03:10:02 +00:00
|
|
|
/* called under rcu_read_lock */
|
|
|
|
void br_flood(struct net_bridge *br, struct sk_buff *skb,
|
2023-04-19 15:34:53 +00:00
|
|
|
enum br_pkt_type pkt_type, bool local_rcv, bool local_orig,
|
|
|
|
u16 vid)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
2016-07-14 03:10:02 +00:00
|
|
|
struct net_bridge_port *prev = NULL;
|
2016-06-28 14:57:06 +00:00
|
|
|
struct net_bridge_port *p;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
skbuff: bridge: Add layer 2 miss indication
For EVPN non-DF (Designated Forwarder) filtering we need to be able to
prevent decapsulated traffic from being flooded to a multi-homed host.
Filtering of multicast and broadcast traffic can be achieved using the
following flower filter:
# tc filter add dev bond0 egress pref 1 proto all flower indev vxlan0 dst_mac 01:00:00:00:00:00/01:00:00:00:00:00 action drop
Unlike broadcast and multicast traffic, it is not currently possible to
filter unknown unicast traffic. The classification into unknown unicast
is performed by the bridge driver, but is not visible to other layers
such as tc.
Solve this by adding a new 'l2_miss' bit to the tc skb extension. Clear
the bit whenever a packet enters the bridge (received from a bridge port
or transmitted via the bridge) and set it if the packet did not match an
FDB or MDB entry. If there is no skb extension and the bit needs to be
cleared, then do not allocate one as no extension is equivalent to the
bit being cleared. The bit is not set for broadcast packets as they
never perform a lookup and therefore never incur a miss.
A bit that is set for every flooded packet would also work for the
current use case, but it does not allow us to differentiate between
registered and unregistered multicast traffic, which might be useful in
the future.
To keep the performance impact to a minimum, the marking of packets is
guarded by the 'tc_skb_ext_tc' static key. When 'false', the skb is not
touched and an skb extension is not allocated. Instead, only a
5 bytes nop is executed, as demonstrated below for the call site in
br_handle_frame().
Before the patch:
```
memset(skb->cb, 0, sizeof(struct br_input_skb_cb));
c37b09: 49 c7 44 24 28 00 00 movq $0x0,0x28(%r12)
c37b10: 00 00
p = br_port_get_rcu(skb->dev);
c37b12: 49 8b 44 24 10 mov 0x10(%r12),%rax
memset(skb->cb, 0, sizeof(struct br_input_skb_cb));
c37b17: 49 c7 44 24 30 00 00 movq $0x0,0x30(%r12)
c37b1e: 00 00
c37b20: 49 c7 44 24 38 00 00 movq $0x0,0x38(%r12)
c37b27: 00 00
```
After the patch (when static key is disabled):
```
memset(skb->cb, 0, sizeof(struct br_input_skb_cb));
c37c29: 49 c7 44 24 28 00 00 movq $0x0,0x28(%r12)
c37c30: 00 00
c37c32: 49 8d 44 24 28 lea 0x28(%r12),%rax
c37c37: 48 c7 40 08 00 00 00 movq $0x0,0x8(%rax)
c37c3e: 00
c37c3f: 48 c7 40 10 00 00 00 movq $0x0,0x10(%rax)
c37c46: 00
#ifdef CONFIG_HAVE_JUMP_LABEL_HACK
static __always_inline bool arch_static_branch(struct static_key *key, bool branch)
{
asm_volatile_goto("1:"
c37c47: 0f 1f 44 00 00 nopl 0x0(%rax,%rax,1)
br_tc_skb_miss_set(skb, false);
p = br_port_get_rcu(skb->dev);
c37c4c: 49 8b 44 24 10 mov 0x10(%r12),%rax
```
Subsequent patches will extend the flower classifier to be able to match
on the new 'l2_miss' bit and enable / disable the static key when
filters that match on it are added / deleted.
Signed-off-by: Ido Schimmel <idosch@nvidia.com>
Acked-by: Nikolay Aleksandrov <razor@blackwall.org>
Acked-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
2023-05-29 11:48:28 +00:00
|
|
|
br_tc_skb_miss_set(skb, pkt_type != BR_PKT_BROADCAST);
|
|
|
|
|
2005-04-16 22:20:36 +00:00
|
|
|
list_for_each_entry_rcu(p, &br->port_list, list) {
|
2017-04-26 13:48:09 +00:00
|
|
|
/* Do not flood unicast traffic to ports that turn it off, nor
|
|
|
|
* other traffic if flood off, except for traffic we originate
|
|
|
|
*/
|
|
|
|
switch (pkt_type) {
|
|
|
|
case BR_PKT_UNICAST:
|
|
|
|
if (!(p->flags & BR_FLOOD))
|
|
|
|
continue;
|
|
|
|
break;
|
|
|
|
case BR_PKT_MULTICAST:
|
|
|
|
if (!(p->flags & BR_MCAST_FLOOD) && skb->dev != br->dev)
|
|
|
|
continue;
|
|
|
|
break;
|
|
|
|
case BR_PKT_BROADCAST:
|
|
|
|
if (!(p->flags & BR_BCAST_FLOOD) && skb->dev != br->dev)
|
|
|
|
continue;
|
|
|
|
break;
|
|
|
|
}
|
2014-10-23 21:49:17 +00:00
|
|
|
|
|
|
|
/* Do not flood to ports that enable proxy ARP */
|
|
|
|
if (p->flags & BR_PROXYARP)
|
|
|
|
continue;
|
2023-04-19 15:34:52 +00:00
|
|
|
if (BR_INPUT_SKB_CB(skb)->proxyarp_replied &&
|
2023-04-19 15:34:56 +00:00
|
|
|
((p->flags & BR_PROXYARP_WIFI) ||
|
|
|
|
br_is_neigh_suppress_enabled(p, vid)))
|
2015-03-04 10:54:21 +00:00
|
|
|
continue;
|
2014-10-23 21:49:17 +00:00
|
|
|
|
2016-07-14 03:10:02 +00:00
|
|
|
prev = maybe_deliver(prev, p, skb, local_orig);
|
2010-02-27 19:41:43 +00:00
|
|
|
if (IS_ERR(prev))
|
|
|
|
goto out;
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
|
2010-02-27 19:41:41 +00:00
|
|
|
if (!prev)
|
|
|
|
goto out;
|
|
|
|
|
2016-07-14 03:10:01 +00:00
|
|
|
if (local_rcv)
|
2016-07-14 03:10:02 +00:00
|
|
|
deliver_clone(prev, skb, local_orig);
|
2010-02-27 19:41:43 +00:00
|
|
|
else
|
2016-07-14 03:10:02 +00:00
|
|
|
__br_forward(prev, skb, local_orig);
|
2010-02-27 19:41:41 +00:00
|
|
|
return;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2010-02-27 19:41:41 +00:00
|
|
|
out:
|
2016-07-14 03:10:01 +00:00
|
|
|
if (!local_rcv)
|
2010-02-27 19:41:41 +00:00
|
|
|
kfree_skb(skb);
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
|
2010-02-27 19:41:46 +00:00
|
|
|
#ifdef CONFIG_BRIDGE_IGMP_SNOOPING
|
2017-01-25 22:29:33 +00:00
|
|
|
static void maybe_deliver_addr(struct net_bridge_port *p, struct sk_buff *skb,
|
|
|
|
const unsigned char *addr, bool local_orig)
|
|
|
|
{
|
|
|
|
struct net_device *dev = BR_INPUT_SKB_CB(skb)->brdev;
|
|
|
|
const unsigned char *src = eth_hdr(skb)->h_source;
|
2024-05-05 18:42:38 +00:00
|
|
|
struct sk_buff *nskb;
|
2017-01-25 22:29:33 +00:00
|
|
|
|
|
|
|
if (!should_deliver(p, skb))
|
|
|
|
return;
|
|
|
|
|
|
|
|
/* Even with hairpin, no soliloquies - prevent breaking IPv6 DAD */
|
|
|
|
if (skb->dev == p->dev && ether_addr_equal(src, addr))
|
|
|
|
return;
|
|
|
|
|
2024-05-05 18:42:38 +00:00
|
|
|
__skb_push(skb, ETH_HLEN);
|
|
|
|
nskb = pskb_copy(skb, GFP_ATOMIC);
|
|
|
|
__skb_pull(skb, ETH_HLEN);
|
|
|
|
if (!nskb) {
|
2023-09-18 09:13:51 +00:00
|
|
|
DEV_STATS_INC(dev, tx_dropped);
|
2017-01-25 22:29:33 +00:00
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2024-05-05 18:42:38 +00:00
|
|
|
skb = nskb;
|
|
|
|
__skb_pull(skb, ETH_HLEN);
|
2017-01-25 22:29:33 +00:00
|
|
|
if (!is_broadcast_ether_addr(addr))
|
|
|
|
memcpy(eth_hdr(skb)->h_dest, addr, ETH_ALEN);
|
|
|
|
|
|
|
|
__br_forward(p, skb, local_orig);
|
|
|
|
}
|
|
|
|
|
2010-02-27 19:41:46 +00:00
|
|
|
/* called with rcu_read_lock */
|
2016-07-14 03:10:02 +00:00
|
|
|
void br_multicast_flood(struct net_bridge_mdb_entry *mdst,
|
|
|
|
struct sk_buff *skb,
|
2021-07-19 17:06:25 +00:00
|
|
|
struct net_bridge_mcast *brmctx,
|
2016-07-14 03:10:02 +00:00
|
|
|
bool local_rcv, bool local_orig)
|
2010-02-27 19:41:46 +00:00
|
|
|
{
|
2010-04-27 15:01:07 +00:00
|
|
|
struct net_bridge_port *prev = NULL;
|
2010-02-27 19:41:46 +00:00
|
|
|
struct net_bridge_port_group *p;
|
2020-09-22 07:30:27 +00:00
|
|
|
bool allow_mode_include = true;
|
2010-02-27 19:41:46 +00:00
|
|
|
struct hlist_node *rp;
|
|
|
|
|
2021-07-19 17:06:25 +00:00
|
|
|
rp = br_multicast_get_first_rport_node(brmctx, skb);
|
2021-05-13 13:20:44 +00:00
|
|
|
|
2020-09-22 07:30:27 +00:00
|
|
|
if (mdst) {
|
|
|
|
p = rcu_dereference(mdst->ports);
|
2021-07-19 17:06:25 +00:00
|
|
|
if (br_multicast_should_handle_mode(brmctx, mdst->addr.proto) &&
|
2020-09-22 07:30:27 +00:00
|
|
|
br_multicast_is_star_g(&mdst->addr))
|
|
|
|
allow_mode_include = false;
|
|
|
|
} else {
|
|
|
|
p = NULL;
|
skbuff: bridge: Add layer 2 miss indication
For EVPN non-DF (Designated Forwarder) filtering we need to be able to
prevent decapsulated traffic from being flooded to a multi-homed host.
Filtering of multicast and broadcast traffic can be achieved using the
following flower filter:
# tc filter add dev bond0 egress pref 1 proto all flower indev vxlan0 dst_mac 01:00:00:00:00:00/01:00:00:00:00:00 action drop
Unlike broadcast and multicast traffic, it is not currently possible to
filter unknown unicast traffic. The classification into unknown unicast
is performed by the bridge driver, but is not visible to other layers
such as tc.
Solve this by adding a new 'l2_miss' bit to the tc skb extension. Clear
the bit whenever a packet enters the bridge (received from a bridge port
or transmitted via the bridge) and set it if the packet did not match an
FDB or MDB entry. If there is no skb extension and the bit needs to be
cleared, then do not allocate one as no extension is equivalent to the
bit being cleared. The bit is not set for broadcast packets as they
never perform a lookup and therefore never incur a miss.
A bit that is set for every flooded packet would also work for the
current use case, but it does not allow us to differentiate between
registered and unregistered multicast traffic, which might be useful in
the future.
To keep the performance impact to a minimum, the marking of packets is
guarded by the 'tc_skb_ext_tc' static key. When 'false', the skb is not
touched and an skb extension is not allocated. Instead, only a
5 bytes nop is executed, as demonstrated below for the call site in
br_handle_frame().
Before the patch:
```
memset(skb->cb, 0, sizeof(struct br_input_skb_cb));
c37b09: 49 c7 44 24 28 00 00 movq $0x0,0x28(%r12)
c37b10: 00 00
p = br_port_get_rcu(skb->dev);
c37b12: 49 8b 44 24 10 mov 0x10(%r12),%rax
memset(skb->cb, 0, sizeof(struct br_input_skb_cb));
c37b17: 49 c7 44 24 30 00 00 movq $0x0,0x30(%r12)
c37b1e: 00 00
c37b20: 49 c7 44 24 38 00 00 movq $0x0,0x38(%r12)
c37b27: 00 00
```
After the patch (when static key is disabled):
```
memset(skb->cb, 0, sizeof(struct br_input_skb_cb));
c37c29: 49 c7 44 24 28 00 00 movq $0x0,0x28(%r12)
c37c30: 00 00
c37c32: 49 8d 44 24 28 lea 0x28(%r12),%rax
c37c37: 48 c7 40 08 00 00 00 movq $0x0,0x8(%rax)
c37c3e: 00
c37c3f: 48 c7 40 10 00 00 00 movq $0x0,0x10(%rax)
c37c46: 00
#ifdef CONFIG_HAVE_JUMP_LABEL_HACK
static __always_inline bool arch_static_branch(struct static_key *key, bool branch)
{
asm_volatile_goto("1:"
c37c47: 0f 1f 44 00 00 nopl 0x0(%rax,%rax,1)
br_tc_skb_miss_set(skb, false);
p = br_port_get_rcu(skb->dev);
c37c4c: 49 8b 44 24 10 mov 0x10(%r12),%rax
```
Subsequent patches will extend the flower classifier to be able to match
on the new 'l2_miss' bit and enable / disable the static key when
filters that match on it are added / deleted.
Signed-off-by: Ido Schimmel <idosch@nvidia.com>
Acked-by: Nikolay Aleksandrov <razor@blackwall.org>
Acked-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
2023-05-29 11:48:28 +00:00
|
|
|
br_tc_skb_miss_set(skb, true);
|
2020-09-22 07:30:27 +00:00
|
|
|
}
|
|
|
|
|
2010-02-27 19:41:46 +00:00
|
|
|
while (p || rp) {
|
2010-04-27 15:01:07 +00:00
|
|
|
struct net_bridge_port *port, *lport, *rport;
|
|
|
|
|
2020-09-22 07:30:22 +00:00
|
|
|
lport = p ? p->key.port : NULL;
|
2021-05-13 13:20:44 +00:00
|
|
|
rport = br_multicast_rport_from_node_skb(rp, skb);
|
2010-02-27 19:41:46 +00:00
|
|
|
|
2017-01-21 20:01:32 +00:00
|
|
|
if ((unsigned long)lport > (unsigned long)rport) {
|
|
|
|
port = lport;
|
|
|
|
|
|
|
|
if (port->flags & BR_MULTICAST_TO_UNICAST) {
|
|
|
|
maybe_deliver_addr(lport, skb, p->eth_addr,
|
|
|
|
local_orig);
|
|
|
|
goto delivered;
|
|
|
|
}
|
2020-09-22 07:30:27 +00:00
|
|
|
if ((!allow_mode_include &&
|
|
|
|
p->filter_mode == MCAST_INCLUDE) ||
|
|
|
|
(p->flags & MDB_PG_FLAGS_BLOCKED))
|
|
|
|
goto delivered;
|
2017-01-21 20:01:32 +00:00
|
|
|
} else {
|
|
|
|
port = rport;
|
|
|
|
}
|
2010-02-27 19:41:46 +00:00
|
|
|
|
2016-07-14 03:10:02 +00:00
|
|
|
prev = maybe_deliver(prev, port, skb, local_orig);
|
2010-02-27 19:41:46 +00:00
|
|
|
if (IS_ERR(prev))
|
|
|
|
goto out;
|
2019-04-04 11:56:38 +00:00
|
|
|
delivered:
|
2010-02-27 19:41:46 +00:00
|
|
|
if ((unsigned long)lport >= (unsigned long)port)
|
2010-04-27 15:01:06 +00:00
|
|
|
p = rcu_dereference(p->next);
|
2010-02-27 19:41:46 +00:00
|
|
|
if ((unsigned long)rport >= (unsigned long)port)
|
2010-11-15 06:38:10 +00:00
|
|
|
rp = rcu_dereference(hlist_next_rcu(rp));
|
2010-02-27 19:41:46 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
if (!prev)
|
|
|
|
goto out;
|
|
|
|
|
2016-07-14 03:10:01 +00:00
|
|
|
if (local_rcv)
|
2016-07-14 03:10:02 +00:00
|
|
|
deliver_clone(prev, skb, local_orig);
|
2010-02-27 19:41:46 +00:00
|
|
|
else
|
2016-07-14 03:10:02 +00:00
|
|
|
__br_forward(prev, skb, local_orig);
|
2010-02-27 19:41:46 +00:00
|
|
|
return;
|
|
|
|
|
|
|
|
out:
|
2016-07-14 03:10:01 +00:00
|
|
|
if (!local_rcv)
|
2010-02-27 19:41:46 +00:00
|
|
|
kfree_skb(skb);
|
|
|
|
}
|
|
|
|
#endif
|