2005-04-16 22:20:36 +00:00
|
|
|
/* Postprocess module symbol versions
|
|
|
|
*
|
|
|
|
* Copyright 2003 Kai Germaschewski
|
|
|
|
* Copyright 2002-2004 Rusty Russell, IBM Corporation
|
2008-01-11 18:17:15 +00:00
|
|
|
* Copyright 2006-2008 Sam Ravnborg
|
2005-04-16 22:20:36 +00:00
|
|
|
* Based in part on module-init-tools/depmod.c,file2alias
|
|
|
|
*
|
|
|
|
* This software may be used and distributed according to the terms
|
|
|
|
* of the GNU General Public License, incorporated herein by reference.
|
|
|
|
*
|
|
|
|
* Usage: modpost vmlinux module1.o module2.o ...
|
|
|
|
*/
|
|
|
|
|
2008-02-13 23:03:39 +00:00
|
|
|
#define _GNU_SOURCE
|
2020-01-04 15:36:51 +00:00
|
|
|
#include <elf.h>
|
2022-05-30 09:01:39 +00:00
|
|
|
#include <fnmatch.h>
|
2008-02-13 23:03:39 +00:00
|
|
|
#include <stdio.h>
|
2005-04-16 22:20:36 +00:00
|
|
|
#include <ctype.h>
|
2010-08-11 07:42:26 +00:00
|
|
|
#include <string.h>
|
2013-04-04 07:07:38 +00:00
|
|
|
#include <limits.h>
|
2021-08-28 09:50:59 +00:00
|
|
|
#include <stdbool.h>
|
2013-09-23 05:53:54 +00:00
|
|
|
#include <errno.h>
|
2005-04-16 22:20:36 +00:00
|
|
|
#include "modpost.h"
|
2006-06-09 19:53:55 +00:00
|
|
|
#include "../../include/linux/license.h"
|
2023-03-31 09:15:52 +00:00
|
|
|
#include "../../include/linux/module_symbol.h"
|
2009-11-07 21:03:54 +00:00
|
|
|
|
2023-07-16 10:15:54 +00:00
|
|
|
static bool module_enabled;
|
2005-04-16 22:20:36 +00:00
|
|
|
/* Are we using CONFIG_MODVERSIONS? */
|
2022-05-01 08:40:07 +00:00
|
|
|
static bool modversions;
|
2005-04-16 22:20:36 +00:00
|
|
|
/* Is CONFIG_MODULE_SRCVERSION_ALL set? */
|
2022-05-01 08:40:07 +00:00
|
|
|
static bool all_versions;
|
2006-01-28 21:15:55 +00:00
|
|
|
/* If we are modposting external module set to 1 */
|
2022-05-01 08:40:07 +00:00
|
|
|
static bool external_module;
|
2006-09-07 20:08:54 +00:00
|
|
|
/* Only warn about unresolved symbols */
|
2022-05-01 08:40:07 +00:00
|
|
|
static bool warn_unresolved;
|
2022-05-08 19:06:19 +00:00
|
|
|
|
2022-04-05 11:33:53 +00:00
|
|
|
static int sec_mismatch_count;
|
2022-05-01 08:40:07 +00:00
|
|
|
static bool sec_mismatch_warn_only = true;
|
kbuild: implement CONFIG_TRIM_UNUSED_KSYMS without recursion
When CONFIG_TRIM_UNUSED_KSYMS is enabled, Kbuild recursively traverses
the directory tree to determine which EXPORT_SYMBOL to trim. If an
EXPORT_SYMBOL turns out to be unused by anyone, Kbuild begins the
second traverse, where some source files are recompiled with their
EXPORT_SYMBOL() tuned into a no-op.
Linus stated negative opinions about this slowness in commits:
- 5cf0fd591f2e ("Kbuild: disable TRIM_UNUSED_KSYMS option")
- a555bdd0c58c ("Kbuild: enable TRIM_UNUSED_KSYMS again, with some guarding")
We can do this better now. The final data structures of EXPORT_SYMBOL
are generated by the modpost stage, so modpost can selectively emit
KSYMTAB entries that are really used by modules.
Commit f73edc8951b2 ("kbuild: unify two modpost invocations") is another
ground-work to do this in a one-pass algorithm. With the list of modules,
modpost sets sym->used if it is used by a module. modpost emits KSYMTAB
only for symbols with sym->used==true.
BTW, Nicolas explained why the trimming was implemented with recursion:
https://lore.kernel.org/all/2o2rpn97-79nq-p7s2-nq5-8p83391473r@syhkavp.arg/
Actually, we never achieved that level of optimization where the chain
reaction of trimming comes into play because:
- CONFIG_LTO_CLANG cannot remove any unused symbols
- CONFIG_LD_DEAD_CODE_DATA_ELIMINATION is enabled only for vmlinux,
but not modules
If deeper trimming is required, we need to revisit this, but I guess
that is unlikely to happen.
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
2023-06-11 15:50:57 +00:00
|
|
|
/* Trim EXPORT_SYMBOLs that are unused by in-tree modules */
|
|
|
|
static bool trim_unused_exports;
|
|
|
|
|
2013-09-23 05:53:54 +00:00
|
|
|
/* ignore missing files */
|
2022-05-01 08:40:07 +00:00
|
|
|
static bool ignore_missing_files;
|
2020-03-06 16:02:06 +00:00
|
|
|
/* If set to 1, only warn (instead of error) about missing ns imports */
|
2022-05-01 08:40:07 +00:00
|
|
|
static bool allow_missing_ns_imports;
|
2008-01-24 20:12:37 +00:00
|
|
|
|
2020-12-01 10:34:15 +00:00
|
|
|
static bool error_occurred;
|
|
|
|
|
2023-06-06 09:41:59 +00:00
|
|
|
static bool extra_warn;
|
|
|
|
|
kbuild: fix false-positive modpost warning when all symbols are trimmed
Nathan reports that the mips defconfig emits the following warning:
WARNING: modpost: Symbol info of vmlinux is missing. Unresolved symbol check will be entirely skipped.
This false-positive happens when CONFIG_TRIM_UNUSED_KSYMS is enabled,
but no CONFIG option is set to 'm'.
Commit a0590473c5e6 ("nfs: fix PNFS_FLEXFILE_LAYOUT Kconfig default")
turned the last 'm' into 'y' for the mips defconfig, and uncovered
this issue.
In this case, the module feature itself is enabled, but we have no
module to build. As a result, CONFIG_TRIM_UNUSED_KSYMS drops all the
instances of EXPORT_SYMBOL. Then, modpost wrongly assumes vmlinux is
missing because vmlinux.symvers is empty. (As another false-positive
case, you can create a module that does not use any symbol of vmlinux).
The current behavior is to entirely suppress the unresolved symbol
warnings when vmlinux is missing just because there are too many.
I found the origin of this code in the historical git tree. [1]
If this is a matter of noisiness, I think modpost can display the
first 10 warnings, and the number of suppressed warnings at the end.
You will get a bit noisier logs when you run 'make modules' without
vmlinux, but such warnings are better to show because you never know
the resulting modules are actually loadable or not.
This commit changes the following:
- If any of input *.symver files is missing, pass -w option to let
the module build keep going with warnings instead of errors.
- If there are too many (10+) unresolved symbol warnings, show only
the first 10, and also the number of suppressed warnings.
[1]: https://git.kernel.org/pub/scm/linux/kernel/git/history/history.git/commit/?id=1cc0e0529569bf6a94f6d49770aa6d4b599d2c46
Reported-by: Nathan Chancellor <nathan@kernel.org>
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
2021-03-25 18:54:11 +00:00
|
|
|
/*
|
|
|
|
* Cut off the warnings when there are too many. This typically occurs when
|
|
|
|
* vmlinux is missing. ('make modules' without building vmlinux.)
|
|
|
|
*/
|
|
|
|
#define MAX_UNRESOLVED_REPORTS 10
|
|
|
|
static unsigned int nr_unresolved;
|
|
|
|
|
2017-06-30 14:07:03 +00:00
|
|
|
/* In kernel, this size is defined in linux/module.h;
|
|
|
|
* here we use Elf_Addr instead of long for covering cross-compile
|
|
|
|
*/
|
|
|
|
|
|
|
|
#define MODULE_NAME_LEN (64 - sizeof(Elf_Addr))
|
|
|
|
|
2020-03-06 16:02:05 +00:00
|
|
|
void __attribute__((format(printf, 2, 3)))
|
|
|
|
modpost_log(enum loglevel loglevel, const char *fmt, ...)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
|
|
|
va_list arglist;
|
|
|
|
|
2020-03-06 16:02:05 +00:00
|
|
|
switch (loglevel) {
|
|
|
|
case LOG_WARN:
|
|
|
|
fprintf(stderr, "WARNING: ");
|
|
|
|
break;
|
|
|
|
case LOG_ERROR:
|
|
|
|
fprintf(stderr, "ERROR: ");
|
|
|
|
break;
|
|
|
|
case LOG_FATAL:
|
|
|
|
fprintf(stderr, "FATAL: ");
|
|
|
|
break;
|
|
|
|
default: /* invalid loglevel, ignore */
|
|
|
|
break;
|
|
|
|
}
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2020-03-06 16:02:05 +00:00
|
|
|
fprintf(stderr, "modpost: ");
|
2005-04-16 22:20:36 +00:00
|
|
|
|
|
|
|
va_start(arglist, fmt);
|
|
|
|
vfprintf(stderr, fmt, arglist);
|
|
|
|
va_end(arglist);
|
2006-10-07 11:35:32 +00:00
|
|
|
|
2020-03-06 16:02:05 +00:00
|
|
|
if (loglevel == LOG_FATAL)
|
|
|
|
exit(1);
|
2020-12-01 10:34:15 +00:00
|
|
|
if (loglevel == LOG_ERROR)
|
|
|
|
error_occurred = true;
|
2006-10-07 11:35:32 +00:00
|
|
|
}
|
|
|
|
|
2021-08-28 09:50:59 +00:00
|
|
|
static inline bool strends(const char *str, const char *postfix)
|
|
|
|
{
|
|
|
|
if (strlen(str) < strlen(postfix))
|
|
|
|
return false;
|
|
|
|
|
|
|
|
return strcmp(str + strlen(str) - strlen(postfix), postfix) == 0;
|
|
|
|
}
|
|
|
|
|
2005-04-16 22:20:36 +00:00
|
|
|
void *do_nofail(void *ptr, const char *expr)
|
2006-01-28 21:15:55 +00:00
|
|
|
{
|
2008-01-11 18:17:15 +00:00
|
|
|
if (!ptr)
|
2020-03-06 16:02:05 +00:00
|
|
|
fatal("Memory allocation failure: %s.\n", expr);
|
2006-01-28 21:15:55 +00:00
|
|
|
|
2005-04-16 22:20:36 +00:00
|
|
|
return ptr;
|
|
|
|
}
|
|
|
|
|
2020-06-01 05:57:17 +00:00
|
|
|
char *read_text_file(const char *filename)
|
|
|
|
{
|
|
|
|
struct stat st;
|
|
|
|
size_t nbytes;
|
|
|
|
int fd;
|
|
|
|
char *buf;
|
|
|
|
|
|
|
|
fd = open(filename, O_RDONLY);
|
|
|
|
if (fd < 0) {
|
|
|
|
perror(filename);
|
|
|
|
exit(1);
|
|
|
|
}
|
2006-01-28 21:15:55 +00:00
|
|
|
|
2020-06-01 05:57:17 +00:00
|
|
|
if (fstat(fd, &st) < 0) {
|
|
|
|
perror(filename);
|
|
|
|
exit(1);
|
|
|
|
}
|
|
|
|
|
|
|
|
buf = NOFAIL(malloc(st.st_size + 1));
|
|
|
|
|
|
|
|
nbytes = st.st_size;
|
|
|
|
|
|
|
|
while (nbytes) {
|
|
|
|
ssize_t bytes_read;
|
|
|
|
|
|
|
|
bytes_read = read(fd, buf, nbytes);
|
|
|
|
if (bytes_read < 0) {
|
|
|
|
perror(filename);
|
|
|
|
exit(1);
|
|
|
|
}
|
|
|
|
|
|
|
|
nbytes -= bytes_read;
|
|
|
|
}
|
|
|
|
buf[st.st_size] = '\0';
|
|
|
|
|
|
|
|
close(fd);
|
|
|
|
|
|
|
|
return buf;
|
2006-01-28 21:15:55 +00:00
|
|
|
}
|
|
|
|
|
2020-06-01 05:57:17 +00:00
|
|
|
char *get_line(char **stringp)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
2020-07-01 06:18:27 +00:00
|
|
|
char *orig = *stringp, *next;
|
|
|
|
|
2020-06-01 05:57:17 +00:00
|
|
|
/* do not return the unwanted extra line at EOF */
|
2020-07-01 06:18:27 +00:00
|
|
|
if (!orig || *orig == '\0')
|
2020-06-01 05:57:17 +00:00
|
|
|
return NULL;
|
2008-01-11 18:17:15 +00:00
|
|
|
|
2020-07-26 21:44:19 +00:00
|
|
|
/* don't use strsep here, it is not available everywhere */
|
2020-07-01 06:18:27 +00:00
|
|
|
next = strchr(orig, '\n');
|
|
|
|
if (next)
|
|
|
|
*next++ = '\0';
|
|
|
|
|
|
|
|
*stringp = next;
|
|
|
|
|
|
|
|
return orig;
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
/* A list of all modules we processed */
|
2022-05-01 08:40:10 +00:00
|
|
|
LIST_HEAD(modules);
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2018-05-09 09:50:40 +00:00
|
|
|
static struct module *find_module(const char *modname)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
|
|
|
struct module *mod;
|
|
|
|
|
2022-05-01 08:40:10 +00:00
|
|
|
list_for_each_entry(mod, &modules, list) {
|
2005-04-16 22:20:36 +00:00
|
|
|
if (strcmp(mod->name, modname) == 0)
|
2022-05-01 08:40:10 +00:00
|
|
|
return mod;
|
|
|
|
}
|
|
|
|
return NULL;
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
|
2022-05-30 09:01:38 +00:00
|
|
|
static struct module *new_module(const char *name, size_t namelen)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
|
|
|
struct module *mod;
|
2006-03-03 15:46:04 +00:00
|
|
|
|
2022-05-30 09:01:38 +00:00
|
|
|
mod = NOFAIL(malloc(sizeof(*mod) + namelen + 1));
|
2005-04-16 22:20:36 +00:00
|
|
|
memset(mod, 0, sizeof(*mod));
|
|
|
|
|
2022-05-01 08:40:15 +00:00
|
|
|
INIT_LIST_HEAD(&mod->exported_symbols);
|
2022-05-01 08:40:12 +00:00
|
|
|
INIT_LIST_HEAD(&mod->unresolved_symbols);
|
2022-05-01 08:40:14 +00:00
|
|
|
INIT_LIST_HEAD(&mod->missing_namespaces);
|
|
|
|
INIT_LIST_HEAD(&mod->imported_namespaces);
|
2022-05-01 08:40:12 +00:00
|
|
|
|
2022-05-30 09:01:38 +00:00
|
|
|
memcpy(mod->name, name, namelen);
|
|
|
|
mod->name[namelen] = '\0';
|
|
|
|
mod->is_vmlinux = (strcmp(mod->name, "vmlinux") == 0);
|
modpost: change mod->gpl_compatible to bool type
Currently, mod->gpl_compatible is tristate; it is set to -1 by default,
then to 1 or 0 when MODULE_LICENSE() is found.
Maybe, -1 was chosen to represent the 'unknown' license, but it is not
useful.
The current code:
if (!mod->gpl_compatible)
check_for_gpl_usage(exp->export, basename, exp->name);
... only cares whether gpl_compatible is zero or not.
Change it to a bool type with the initial value 'true', which has no
functional change.
The default value should be 'true' instead of 'false'.
Since commit 1d6cd3929360 ("modpost: turn missing MODULE_LICENSE() into
error"), unknown module license is an error.
The error message, "missing MODULE_LICENSE()" is enough to explain the
issue. It is not sensible to show another message, "GPL-incompatible
module ... uses GPL-only symbol".
Add comments to explain this.
While I was here, I renamed gpl_compatible to is_gpl_compatible for
clarification, and also slightly refactored the code.
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
2022-05-01 08:40:08 +00:00
|
|
|
|
|
|
|
/*
|
|
|
|
* Set mod->is_gpl_compatible to true by default. If MODULE_LICENSE()
|
|
|
|
* is missing, do not check the use for EXPORT_SYMBOL_GPL() becasue
|
|
|
|
* modpost will exit wiht error anyway.
|
|
|
|
*/
|
|
|
|
mod->is_gpl_compatible = true;
|
|
|
|
|
2022-05-01 08:40:10 +00:00
|
|
|
list_add_tail(&mod->list, &modules);
|
2005-04-16 22:20:36 +00:00
|
|
|
|
|
|
|
return mod;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* A hash of all exported symbols,
|
|
|
|
* struct symbol is also used for lists of unresolved symbols */
|
|
|
|
|
|
|
|
#define SYMBOL_HASH_SIZE 1024
|
|
|
|
|
|
|
|
struct symbol {
|
|
|
|
struct symbol *next;
|
2022-05-01 08:40:15 +00:00
|
|
|
struct list_head list; /* link to module::exported_symbols or module::unresolved_symbols */
|
2005-04-16 22:20:36 +00:00
|
|
|
struct module *module;
|
modpost: fix broken sym->namespace for external module builds
Currently, external module builds produce tons of false-positives:
WARNING: module <mod> uses symbol <sym> from namespace <ns>, but does not import it.
Here, the <ns> part shows a random string.
When you build external modules, the symbol info of vmlinux and
in-kernel modules are read from $(objtree)/Module.symvers, but
read_dump() is buggy in multiple ways:
[1] When the modpost is run for vmlinux and in-kernel modules,
sym_extract_namespace() allocates memory for the namespace. On the
other hand, read_dump() does not, then sym->namespace will point to
somewhere in the line buffer of get_next_line(). The data in the
buffer will be replaced soon, and sym->namespace will end up with
pointing to unrelated data. As a result, check_exports() will show
random strings in the warning messages.
[2] When there is no namespace, sym_extract_namespace() returns NULL.
On the other hand, read_dump() sets namespace to an empty string "".
(but, it will be later replaced with unrelated data due to bug [1].)
The check_exports() shows a warning unless exp->namespace is NULL,
so every symbol read from read_dump() emits the warning, which is
mostly false positive.
To address [1], sym_add_exported() calls strdup() for s->namespace.
The namespace from sym_extract_namespace() must be freed to avoid
memory leak.
For [2], I changed the if-conditional in check_exports().
This commit also fixes sym_add_exported() to set s->namespace correctly
when the symbol is preloaded.
Reviewed-by: Matthias Maennich <maennich@google.com>
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Jessica Yu <jeyu@kernel.org>
2019-10-03 07:58:22 +00:00
|
|
|
char *namespace;
|
2022-05-01 08:40:07 +00:00
|
|
|
unsigned int crc;
|
|
|
|
bool crc_valid;
|
|
|
|
bool weak;
|
kbuild: generate KSYMTAB entries by modpost
Commit 7b4537199a4a ("kbuild: link symbol CRCs at final link, removing
CONFIG_MODULE_REL_CRCS") made modpost output CRCs in the same way
whether the EXPORT_SYMBOL() is placed in *.c or *.S.
For further cleanups, this commit applies a similar approach to the
entire data structure of EXPORT_SYMBOL().
The EXPORT_SYMBOL() compilation is split into two stages.
When a source file is compiled, EXPORT_SYMBOL() will be converted into
a dummy symbol in the .export_symbol section.
For example,
EXPORT_SYMBOL(foo);
EXPORT_SYMBOL_NS_GPL(bar, BAR_NAMESPACE);
will be encoded into the following assembly code:
.section ".export_symbol","a"
__export_symbol_foo:
.asciz "" /* license */
.asciz "" /* name space */
.balign 8
.quad foo /* symbol reference */
.previous
.section ".export_symbol","a"
__export_symbol_bar:
.asciz "GPL" /* license */
.asciz "BAR_NAMESPACE" /* name space */
.balign 8
.quad bar /* symbol reference */
.previous
They are mere markers to tell modpost the name, license, and namespace
of the symbols. They will be dropped from the final vmlinux and modules
because the *(.export_symbol) will go into /DISCARD/ in the linker script.
Then, modpost extracts all the information about EXPORT_SYMBOL() from the
.export_symbol section, and generates the final C code:
KSYMTAB_FUNC(foo, "", "");
KSYMTAB_FUNC(bar, "_gpl", "BAR_NAMESPACE");
KSYMTAB_FUNC() (or KSYMTAB_DATA() if it is data) is expanded to struct
kernel_symbol that will be linked to the vmlinux or a module.
With this change, EXPORT_SYMBOL() works in the same way for *.c and *.S
files, providing the following benefits.
[1] Deprecate EXPORT_DATA_SYMBOL()
In the old days, EXPORT_SYMBOL() was only available in C files. To export
a symbol in *.S, EXPORT_SYMBOL() was placed in a separate *.c file.
arch/arm/kernel/armksyms.c is one example written in the classic manner.
Commit 22823ab419d8 ("EXPORT_SYMBOL() for asm") removed this limitation.
Since then, EXPORT_SYMBOL() can be placed close to the symbol definition
in *.S files. It was a nice improvement.
However, as that commit mentioned, you need to use EXPORT_DATA_SYMBOL()
for data objects on some architectures.
In the new approach, modpost checks symbol's type (STT_FUNC or not),
and outputs KSYMTAB_FUNC() or KSYMTAB_DATA() accordingly.
There are only two users of EXPORT_DATA_SYMBOL:
EXPORT_DATA_SYMBOL_GPL(empty_zero_page) (arch/ia64/kernel/head.S)
EXPORT_DATA_SYMBOL(ia64_ivt) (arch/ia64/kernel/ivt.S)
They are transformed as follows and output into .vmlinux.export.c
KSYMTAB_DATA(empty_zero_page, "_gpl", "");
KSYMTAB_DATA(ia64_ivt, "", "");
The other EXPORT_SYMBOL users in ia64 assembly are output as
KSYMTAB_FUNC().
EXPORT_DATA_SYMBOL() is now deprecated.
[2] merge <linux/export.h> and <asm-generic/export.h>
There are two similar header implementations:
include/linux/export.h for .c files
include/asm-generic/export.h for .S files
Ideally, the functionality should be consistent between them, but they
tend to diverge.
Commit 8651ec01daed ("module: add support for symbol namespaces.") did
not support the namespace for *.S files.
This commit shifts the essential implementation part to C, which supports
EXPORT_SYMBOL_NS() for *.S files.
<asm/export.h> and <asm-generic/export.h> will remain as a wrapper of
<linux/export.h> for a while.
They will be removed after #include <asm/export.h> directives are all
replaced with #include <linux/export.h>.
[3] Implement CONFIG_TRIM_UNUSED_KSYMS in one-pass algorithm (by a later commit)
When CONFIG_TRIM_UNUSED_KSYMS is enabled, Kbuild recursively traverses
the directory tree to determine which EXPORT_SYMBOL to trim. If an
EXPORT_SYMBOL turns out to be unused by anyone, Kbuild begins the
second traverse, where some source files are recompiled with their
EXPORT_SYMBOL() tuned into a no-op.
We can do this better now; modpost can selectively emit KSYMTAB entries
that are really used by modules.
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
2023-06-11 15:50:52 +00:00
|
|
|
bool is_func;
|
2022-05-08 19:06:19 +00:00
|
|
|
bool is_gpl_only; /* exported by EXPORT_SYMBOL_GPL */
|
kbuild: implement CONFIG_TRIM_UNUSED_KSYMS without recursion
When CONFIG_TRIM_UNUSED_KSYMS is enabled, Kbuild recursively traverses
the directory tree to determine which EXPORT_SYMBOL to trim. If an
EXPORT_SYMBOL turns out to be unused by anyone, Kbuild begins the
second traverse, where some source files are recompiled with their
EXPORT_SYMBOL() tuned into a no-op.
Linus stated negative opinions about this slowness in commits:
- 5cf0fd591f2e ("Kbuild: disable TRIM_UNUSED_KSYMS option")
- a555bdd0c58c ("Kbuild: enable TRIM_UNUSED_KSYMS again, with some guarding")
We can do this better now. The final data structures of EXPORT_SYMBOL
are generated by the modpost stage, so modpost can selectively emit
KSYMTAB entries that are really used by modules.
Commit f73edc8951b2 ("kbuild: unify two modpost invocations") is another
ground-work to do this in a one-pass algorithm. With the list of modules,
modpost sets sym->used if it is used by a module. modpost emits KSYMTAB
only for symbols with sym->used==true.
BTW, Nicolas explained why the trimming was implemented with recursion:
https://lore.kernel.org/all/2o2rpn97-79nq-p7s2-nq5-8p83391473r@syhkavp.arg/
Actually, we never achieved that level of optimization where the chain
reaction of trimming comes into play because:
- CONFIG_LTO_CLANG cannot remove any unused symbols
- CONFIG_LD_DEAD_CODE_DATA_ELIMINATION is enabled only for vmlinux,
but not modules
If deeper trimming is required, we need to revisit this, but I guess
that is unlikely to happen.
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
2023-06-11 15:50:57 +00:00
|
|
|
bool used; /* there exists a user of this symbol */
|
modpost,fixdep: Replace zero-length array with flexible-array
The current codebase makes use of the zero-length array language
extension to the C90 standard, but the preferred mechanism to declare
variable-length types such as these ones is a flexible array member[1][2],
introduced in C99:
struct foo {
int stuff;
struct boo array[];
};
By making use of the mechanism above, we will get a compiler warning
in case the flexible array does not occur last in the structure, which
will help us prevent some kind of undefined behavior bugs from being
inadvertently introduced[3] to the codebase from now on.
Also, notice that, dynamic memory allocations won't be affected by
this change:
"Flexible array members have incomplete type, and so the sizeof operator
may not be applied. As a quirk of the original implementation of
zero-length arrays, sizeof evaluates to zero."[1]
sizeof(flexible-array-member) triggers a warning because flexible array
members have incomplete type[1]. There are some instances of code in
which the sizeof operator is being incorrectly/erroneously applied to
zero-length arrays and the result is zero. Such instances may be hiding
some bugs. So, this work (flexible-array member conversions) will also
help to get completely rid of those sorts of issues.
This issue was found with the help of Coccinelle.
[1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html
[2] https://github.com/KSPP/linux/issues/21
[3] commit 76497732932f ("cxgb3/l2t: Fix undefined behaviour")
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
2020-05-07 18:56:01 +00:00
|
|
|
char name[];
|
2005-04-16 22:20:36 +00:00
|
|
|
};
|
|
|
|
|
|
|
|
static struct symbol *symbolhash[SYMBOL_HASH_SIZE];
|
|
|
|
|
2021-03-26 05:52:19 +00:00
|
|
|
/* This is based on the hash algorithm from gdbm, via tdb */
|
2005-04-16 22:20:36 +00:00
|
|
|
static inline unsigned int tdb_hash(const char *name)
|
|
|
|
{
|
|
|
|
unsigned value; /* Used to compute the hash value. */
|
|
|
|
unsigned i; /* Used to cycle through random values. */
|
|
|
|
|
|
|
|
/* Set the initial value from the key size. */
|
2008-01-11 18:17:15 +00:00
|
|
|
for (value = 0x238F13AF * strlen(name), i = 0; name[i]; i++)
|
2005-04-16 22:20:36 +00:00
|
|
|
value = (value + (((unsigned char *)name)[i] << (i*5 % 24)));
|
|
|
|
|
|
|
|
return (1103515243 * value + 12345);
|
|
|
|
}
|
|
|
|
|
2006-01-28 16:19:35 +00:00
|
|
|
/**
|
|
|
|
* Allocate a new symbols for use in the hash of exported symbols or
|
|
|
|
* the list of unresolved symbols per module
|
|
|
|
**/
|
2022-05-01 08:40:19 +00:00
|
|
|
static struct symbol *alloc_symbol(const char *name)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
|
|
|
struct symbol *s = NOFAIL(malloc(sizeof(*s) + strlen(name) + 1));
|
|
|
|
|
|
|
|
memset(s, 0, sizeof(*s));
|
|
|
|
strcpy(s->name, name);
|
2022-05-27 10:01:51 +00:00
|
|
|
|
2005-04-16 22:20:36 +00:00
|
|
|
return s;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* For the hash of exported symbols */
|
2022-05-01 08:40:19 +00:00
|
|
|
static void hash_add_symbol(struct symbol *sym)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
|
|
|
unsigned int hash;
|
|
|
|
|
2022-05-01 08:40:19 +00:00
|
|
|
hash = tdb_hash(sym->name) % SYMBOL_HASH_SIZE;
|
|
|
|
sym->next = symbolhash[hash];
|
|
|
|
symbolhash[hash] = sym;
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
|
2022-05-01 08:40:11 +00:00
|
|
|
static void sym_add_unresolved(const char *name, struct module *mod, bool weak)
|
|
|
|
{
|
2022-05-01 08:40:12 +00:00
|
|
|
struct symbol *sym;
|
|
|
|
|
2022-05-01 08:40:19 +00:00
|
|
|
sym = alloc_symbol(name);
|
2022-05-01 08:40:12 +00:00
|
|
|
sym->weak = weak;
|
|
|
|
|
|
|
|
list_add_tail(&sym->list, &mod->unresolved_symbols);
|
2022-05-01 08:40:11 +00:00
|
|
|
}
|
|
|
|
|
2022-05-11 16:45:04 +00:00
|
|
|
static struct symbol *sym_find_with_module(const char *name, struct module *mod)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
|
|
|
struct symbol *s;
|
|
|
|
|
|
|
|
/* For our purposes, .foo matches foo. PPC64 needs this. */
|
|
|
|
if (name[0] == '.')
|
|
|
|
name++;
|
|
|
|
|
2008-01-11 18:17:15 +00:00
|
|
|
for (s = symbolhash[tdb_hash(name) % SYMBOL_HASH_SIZE]; s; s = s->next) {
|
2022-05-11 16:45:04 +00:00
|
|
|
if (strcmp(s->name, name) == 0 && (!mod || s->module == mod))
|
2005-04-16 22:20:36 +00:00
|
|
|
return s;
|
|
|
|
}
|
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
|
2022-05-11 16:45:04 +00:00
|
|
|
static struct symbol *find_symbol(const char *name)
|
|
|
|
{
|
|
|
|
return sym_find_with_module(name, NULL);
|
|
|
|
}
|
|
|
|
|
2022-04-24 19:07:56 +00:00
|
|
|
struct namespace_list {
|
2022-05-01 08:40:14 +00:00
|
|
|
struct list_head list;
|
2022-04-24 19:07:56 +00:00
|
|
|
char namespace[];
|
|
|
|
};
|
|
|
|
|
2022-05-01 08:40:14 +00:00
|
|
|
static bool contains_namespace(struct list_head *head, const char *namespace)
|
2019-09-06 10:32:28 +00:00
|
|
|
{
|
2022-05-01 08:40:14 +00:00
|
|
|
struct namespace_list *list;
|
|
|
|
|
2023-06-11 15:50:56 +00:00
|
|
|
/*
|
|
|
|
* The default namespace is null string "", which is always implicitly
|
|
|
|
* contained.
|
|
|
|
*/
|
|
|
|
if (!namespace[0])
|
|
|
|
return true;
|
|
|
|
|
2022-05-01 08:40:14 +00:00
|
|
|
list_for_each_entry(list, head, list) {
|
2019-10-29 12:38:09 +00:00
|
|
|
if (!strcmp(list->namespace, namespace))
|
2019-09-06 10:32:28 +00:00
|
|
|
return true;
|
2022-05-01 08:40:14 +00:00
|
|
|
}
|
2019-09-06 10:32:28 +00:00
|
|
|
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
2022-05-01 08:40:14 +00:00
|
|
|
static void add_namespace(struct list_head *head, const char *namespace)
|
2019-09-06 10:32:28 +00:00
|
|
|
{
|
|
|
|
struct namespace_list *ns_entry;
|
|
|
|
|
2022-05-01 08:40:14 +00:00
|
|
|
if (!contains_namespace(head, namespace)) {
|
|
|
|
ns_entry = NOFAIL(malloc(sizeof(*ns_entry) +
|
2019-09-06 10:32:28 +00:00
|
|
|
strlen(namespace) + 1));
|
|
|
|
strcpy(ns_entry->namespace, namespace);
|
2022-05-01 08:40:14 +00:00
|
|
|
list_add_tail(&ns_entry->list, head);
|
2019-09-06 10:32:28 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2020-05-25 05:47:04 +00:00
|
|
|
static void *sym_get_data_by_offset(const struct elf_info *info,
|
|
|
|
unsigned int secindex, unsigned long offset)
|
2017-09-06 23:19:05 +00:00
|
|
|
{
|
2020-03-18 10:34:16 +00:00
|
|
|
Elf_Shdr *sechdr = &info->sechdrs[secindex];
|
2017-09-06 23:19:05 +00:00
|
|
|
|
2019-11-14 17:42:21 +00:00
|
|
|
return (void *)info->hdr + sechdr->sh_offset + offset;
|
2017-09-06 23:19:05 +00:00
|
|
|
}
|
2011-07-14 06:51:16 +00:00
|
|
|
|
2022-07-19 16:53:00 +00:00
|
|
|
void *sym_get_data(const struct elf_info *info, const Elf_Sym *sym)
|
2019-11-14 17:42:21 +00:00
|
|
|
{
|
2020-05-25 05:47:04 +00:00
|
|
|
return sym_get_data_by_offset(info, get_secindex(info, sym),
|
|
|
|
sym->st_value);
|
|
|
|
}
|
2019-11-14 17:42:21 +00:00
|
|
|
|
2020-05-25 05:47:05 +00:00
|
|
|
static const char *sech_name(const struct elf_info *info, Elf_Shdr *sechdr)
|
|
|
|
{
|
|
|
|
return sym_get_data_by_offset(info, info->secindex_strings,
|
|
|
|
sechdr->sh_name);
|
|
|
|
}
|
2019-11-14 17:42:21 +00:00
|
|
|
|
2022-07-30 17:36:34 +00:00
|
|
|
static const char *sec_name(const struct elf_info *info, unsigned int secindex)
|
2020-05-25 05:47:05 +00:00
|
|
|
{
|
2022-07-30 17:36:34 +00:00
|
|
|
/*
|
|
|
|
* If sym->st_shndx is a special section index, there is no
|
|
|
|
* corresponding section header.
|
|
|
|
* Return "" if the index is out of range of info->sechdrs[] array.
|
|
|
|
*/
|
|
|
|
if (secindex >= info->num_sections)
|
|
|
|
return "";
|
|
|
|
|
2020-05-25 05:47:05 +00:00
|
|
|
return sech_name(info, &info->sechdrs[secindex]);
|
2019-11-14 17:42:21 +00:00
|
|
|
}
|
|
|
|
|
2011-07-14 06:51:16 +00:00
|
|
|
#define strstarts(str, prefix) (strncmp(str, prefix, strlen(prefix)) == 0)
|
|
|
|
|
2019-10-18 09:31:41 +00:00
|
|
|
static struct symbol *sym_add_exported(const char *name, struct module *mod,
|
2023-06-11 15:50:55 +00:00
|
|
|
bool gpl_only, const char *namespace)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
|
|
|
struct symbol *s = find_symbol(name);
|
|
|
|
|
2022-05-01 08:40:18 +00:00
|
|
|
if (s && (!external_module || s->module->is_vmlinux || s->module == mod)) {
|
2022-05-01 08:40:17 +00:00
|
|
|
error("%s: '%s' exported twice. Previous export was in %s%s\n",
|
|
|
|
mod->name, name, s->module->name,
|
|
|
|
s->module->is_vmlinux ? "" : ".ko");
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
2019-11-14 17:42:26 +00:00
|
|
|
|
2022-05-01 08:40:19 +00:00
|
|
|
s = alloc_symbol(name);
|
2019-11-14 17:42:26 +00:00
|
|
|
s->module = mod;
|
2022-05-08 19:06:19 +00:00
|
|
|
s->is_gpl_only = gpl_only;
|
2023-06-11 15:50:56 +00:00
|
|
|
s->namespace = NOFAIL(strdup(namespace));
|
2022-05-01 08:40:18 +00:00
|
|
|
list_add_tail(&s->list, &mod->exported_symbols);
|
2022-05-01 08:40:19 +00:00
|
|
|
hash_add_symbol(s);
|
2022-05-01 08:40:18 +00:00
|
|
|
|
2006-01-28 21:15:55 +00:00
|
|
|
return s;
|
|
|
|
}
|
|
|
|
|
2022-05-13 11:39:21 +00:00
|
|
|
static void sym_set_crc(struct symbol *sym, unsigned int crc)
|
2006-01-28 21:15:55 +00:00
|
|
|
{
|
2022-05-13 11:39:21 +00:00
|
|
|
sym->crc = crc;
|
|
|
|
sym->crc_valid = true;
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
|
2020-06-01 05:57:31 +00:00
|
|
|
static void *grab_file(const char *filename, size_t *size)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
|
|
|
struct stat st;
|
2012-05-23 12:58:49 +00:00
|
|
|
void *map = MAP_FAILED;
|
2005-04-16 22:20:36 +00:00
|
|
|
int fd;
|
|
|
|
|
|
|
|
fd = open(filename, O_RDONLY);
|
2012-05-23 12:58:49 +00:00
|
|
|
if (fd < 0)
|
2005-04-16 22:20:36 +00:00
|
|
|
return NULL;
|
2012-05-23 12:58:49 +00:00
|
|
|
if (fstat(fd, &st))
|
|
|
|
goto failed;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
|
|
|
*size = st.st_size;
|
|
|
|
map = mmap(NULL, *size, PROT_READ|PROT_WRITE, MAP_PRIVATE, fd, 0);
|
|
|
|
|
2012-05-23 12:58:49 +00:00
|
|
|
failed:
|
|
|
|
close(fd);
|
2005-04-16 22:20:36 +00:00
|
|
|
if (map == MAP_FAILED)
|
|
|
|
return NULL;
|
|
|
|
return map;
|
|
|
|
}
|
|
|
|
|
2020-06-01 05:57:31 +00:00
|
|
|
static void release_file(void *file, size_t size)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
|
|
|
munmap(file, size);
|
|
|
|
}
|
|
|
|
|
2007-02-26 14:33:52 +00:00
|
|
|
static int parse_elf(struct elf_info *info, const char *filename)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
|
|
|
unsigned int i;
|
2007-02-26 14:33:52 +00:00
|
|
|
Elf_Ehdr *hdr;
|
2005-04-16 22:20:36 +00:00
|
|
|
Elf_Shdr *sechdrs;
|
|
|
|
Elf_Sym *sym;
|
2010-07-28 23:47:53 +00:00
|
|
|
const char *secstrings;
|
|
|
|
unsigned int symtab_idx = ~0U, symtab_shndx_idx = ~0U;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
|
|
|
hdr = grab_file(filename, &info->size);
|
|
|
|
if (!hdr) {
|
2013-09-23 05:53:54 +00:00
|
|
|
if (ignore_missing_files) {
|
|
|
|
fprintf(stderr, "%s: %s (ignored)\n", filename,
|
|
|
|
strerror(errno));
|
|
|
|
return 0;
|
|
|
|
}
|
2005-04-16 22:20:36 +00:00
|
|
|
perror(filename);
|
2006-06-24 21:46:54 +00:00
|
|
|
exit(1);
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
info->hdr = hdr;
|
2007-02-26 14:33:52 +00:00
|
|
|
if (info->size < sizeof(*hdr)) {
|
|
|
|
/* file too small, assume this is an empty .o file */
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
/* Is this a valid ELF file? */
|
|
|
|
if ((hdr->e_ident[EI_MAG0] != ELFMAG0) ||
|
|
|
|
(hdr->e_ident[EI_MAG1] != ELFMAG1) ||
|
|
|
|
(hdr->e_ident[EI_MAG2] != ELFMAG2) ||
|
|
|
|
(hdr->e_ident[EI_MAG3] != ELFMAG3)) {
|
|
|
|
/* Not an ELF file - silently ignore it */
|
|
|
|
return 0;
|
|
|
|
}
|
2005-04-16 22:20:36 +00:00
|
|
|
/* Fix endianness in ELF header */
|
2009-05-03 20:02:55 +00:00
|
|
|
hdr->e_type = TO_NATIVE(hdr->e_type);
|
|
|
|
hdr->e_machine = TO_NATIVE(hdr->e_machine);
|
|
|
|
hdr->e_version = TO_NATIVE(hdr->e_version);
|
|
|
|
hdr->e_entry = TO_NATIVE(hdr->e_entry);
|
|
|
|
hdr->e_phoff = TO_NATIVE(hdr->e_phoff);
|
|
|
|
hdr->e_shoff = TO_NATIVE(hdr->e_shoff);
|
|
|
|
hdr->e_flags = TO_NATIVE(hdr->e_flags);
|
|
|
|
hdr->e_ehsize = TO_NATIVE(hdr->e_ehsize);
|
|
|
|
hdr->e_phentsize = TO_NATIVE(hdr->e_phentsize);
|
|
|
|
hdr->e_phnum = TO_NATIVE(hdr->e_phnum);
|
|
|
|
hdr->e_shentsize = TO_NATIVE(hdr->e_shentsize);
|
|
|
|
hdr->e_shnum = TO_NATIVE(hdr->e_shnum);
|
|
|
|
hdr->e_shstrndx = TO_NATIVE(hdr->e_shstrndx);
|
2005-04-16 22:20:36 +00:00
|
|
|
sechdrs = (void *)hdr + hdr->e_shoff;
|
|
|
|
info->sechdrs = sechdrs;
|
|
|
|
|
2022-07-19 16:52:59 +00:00
|
|
|
/* modpost only works for relocatable objects */
|
|
|
|
if (hdr->e_type != ET_REL)
|
|
|
|
fatal("%s: not relocatable object.", filename);
|
|
|
|
|
2007-08-27 10:15:07 +00:00
|
|
|
/* Check if file offset is correct */
|
|
|
|
if (hdr->e_shoff > info->size) {
|
2020-06-01 05:57:31 +00:00
|
|
|
fatal("section header offset=%lu in file '%s' is bigger than filesize=%zu\n",
|
|
|
|
(unsigned long)hdr->e_shoff, filename, info->size);
|
2007-08-27 10:15:07 +00:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2011-05-19 22:55:27 +00:00
|
|
|
if (hdr->e_shnum == SHN_UNDEF) {
|
2010-07-28 23:47:53 +00:00
|
|
|
/*
|
|
|
|
* There are more than 64k sections,
|
|
|
|
* read count from .sh_size.
|
|
|
|
*/
|
|
|
|
info->num_sections = TO_NATIVE(sechdrs[0].sh_size);
|
|
|
|
}
|
|
|
|
else {
|
|
|
|
info->num_sections = hdr->e_shnum;
|
|
|
|
}
|
|
|
|
if (hdr->e_shstrndx == SHN_XINDEX) {
|
2011-05-19 22:55:27 +00:00
|
|
|
info->secindex_strings = TO_NATIVE(sechdrs[0].sh_link);
|
2010-07-28 23:47:53 +00:00
|
|
|
}
|
|
|
|
else {
|
|
|
|
info->secindex_strings = hdr->e_shstrndx;
|
|
|
|
}
|
|
|
|
|
2005-04-16 22:20:36 +00:00
|
|
|
/* Fix endianness in section headers */
|
2010-07-28 23:47:53 +00:00
|
|
|
for (i = 0; i < info->num_sections; i++) {
|
2009-05-03 20:02:55 +00:00
|
|
|
sechdrs[i].sh_name = TO_NATIVE(sechdrs[i].sh_name);
|
|
|
|
sechdrs[i].sh_type = TO_NATIVE(sechdrs[i].sh_type);
|
|
|
|
sechdrs[i].sh_flags = TO_NATIVE(sechdrs[i].sh_flags);
|
|
|
|
sechdrs[i].sh_addr = TO_NATIVE(sechdrs[i].sh_addr);
|
|
|
|
sechdrs[i].sh_offset = TO_NATIVE(sechdrs[i].sh_offset);
|
|
|
|
sechdrs[i].sh_size = TO_NATIVE(sechdrs[i].sh_size);
|
|
|
|
sechdrs[i].sh_link = TO_NATIVE(sechdrs[i].sh_link);
|
|
|
|
sechdrs[i].sh_info = TO_NATIVE(sechdrs[i].sh_info);
|
|
|
|
sechdrs[i].sh_addralign = TO_NATIVE(sechdrs[i].sh_addralign);
|
|
|
|
sechdrs[i].sh_entsize = TO_NATIVE(sechdrs[i].sh_entsize);
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
/* Find symbol table. */
|
2010-07-28 23:47:53 +00:00
|
|
|
secstrings = (void *)hdr + sechdrs[info->secindex_strings].sh_offset;
|
|
|
|
for (i = 1; i < info->num_sections; i++) {
|
2006-06-09 05:12:53 +00:00
|
|
|
const char *secname;
|
2009-02-05 15:48:02 +00:00
|
|
|
int nobits = sechdrs[i].sh_type == SHT_NOBITS;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2009-02-05 15:48:02 +00:00
|
|
|
if (!nobits && sechdrs[i].sh_offset > info->size) {
|
2022-11-09 13:30:55 +00:00
|
|
|
fatal("%s is truncated. sechdrs[i].sh_offset=%lu > sizeof(*hrd)=%zu\n",
|
|
|
|
filename, (unsigned long)sechdrs[i].sh_offset,
|
2008-01-11 18:17:15 +00:00
|
|
|
sizeof(*hdr));
|
2007-02-26 14:33:52 +00:00
|
|
|
return 0;
|
|
|
|
}
|
2006-06-09 05:12:53 +00:00
|
|
|
secname = secstrings + sechdrs[i].sh_name;
|
|
|
|
if (strcmp(secname, ".modinfo") == 0) {
|
2009-02-05 15:48:02 +00:00
|
|
|
if (nobits)
|
|
|
|
fatal("%s has NOBITS .modinfo\n", filename);
|
2005-04-16 22:20:36 +00:00
|
|
|
info->modinfo = (void *)hdr + sechdrs[i].sh_offset;
|
|
|
|
info->modinfo_len = sechdrs[i].sh_size;
|
kbuild: generate KSYMTAB entries by modpost
Commit 7b4537199a4a ("kbuild: link symbol CRCs at final link, removing
CONFIG_MODULE_REL_CRCS") made modpost output CRCs in the same way
whether the EXPORT_SYMBOL() is placed in *.c or *.S.
For further cleanups, this commit applies a similar approach to the
entire data structure of EXPORT_SYMBOL().
The EXPORT_SYMBOL() compilation is split into two stages.
When a source file is compiled, EXPORT_SYMBOL() will be converted into
a dummy symbol in the .export_symbol section.
For example,
EXPORT_SYMBOL(foo);
EXPORT_SYMBOL_NS_GPL(bar, BAR_NAMESPACE);
will be encoded into the following assembly code:
.section ".export_symbol","a"
__export_symbol_foo:
.asciz "" /* license */
.asciz "" /* name space */
.balign 8
.quad foo /* symbol reference */
.previous
.section ".export_symbol","a"
__export_symbol_bar:
.asciz "GPL" /* license */
.asciz "BAR_NAMESPACE" /* name space */
.balign 8
.quad bar /* symbol reference */
.previous
They are mere markers to tell modpost the name, license, and namespace
of the symbols. They will be dropped from the final vmlinux and modules
because the *(.export_symbol) will go into /DISCARD/ in the linker script.
Then, modpost extracts all the information about EXPORT_SYMBOL() from the
.export_symbol section, and generates the final C code:
KSYMTAB_FUNC(foo, "", "");
KSYMTAB_FUNC(bar, "_gpl", "BAR_NAMESPACE");
KSYMTAB_FUNC() (or KSYMTAB_DATA() if it is data) is expanded to struct
kernel_symbol that will be linked to the vmlinux or a module.
With this change, EXPORT_SYMBOL() works in the same way for *.c and *.S
files, providing the following benefits.
[1] Deprecate EXPORT_DATA_SYMBOL()
In the old days, EXPORT_SYMBOL() was only available in C files. To export
a symbol in *.S, EXPORT_SYMBOL() was placed in a separate *.c file.
arch/arm/kernel/armksyms.c is one example written in the classic manner.
Commit 22823ab419d8 ("EXPORT_SYMBOL() for asm") removed this limitation.
Since then, EXPORT_SYMBOL() can be placed close to the symbol definition
in *.S files. It was a nice improvement.
However, as that commit mentioned, you need to use EXPORT_DATA_SYMBOL()
for data objects on some architectures.
In the new approach, modpost checks symbol's type (STT_FUNC or not),
and outputs KSYMTAB_FUNC() or KSYMTAB_DATA() accordingly.
There are only two users of EXPORT_DATA_SYMBOL:
EXPORT_DATA_SYMBOL_GPL(empty_zero_page) (arch/ia64/kernel/head.S)
EXPORT_DATA_SYMBOL(ia64_ivt) (arch/ia64/kernel/ivt.S)
They are transformed as follows and output into .vmlinux.export.c
KSYMTAB_DATA(empty_zero_page, "_gpl", "");
KSYMTAB_DATA(ia64_ivt, "", "");
The other EXPORT_SYMBOL users in ia64 assembly are output as
KSYMTAB_FUNC().
EXPORT_DATA_SYMBOL() is now deprecated.
[2] merge <linux/export.h> and <asm-generic/export.h>
There are two similar header implementations:
include/linux/export.h for .c files
include/asm-generic/export.h for .S files
Ideally, the functionality should be consistent between them, but they
tend to diverge.
Commit 8651ec01daed ("module: add support for symbol namespaces.") did
not support the namespace for *.S files.
This commit shifts the essential implementation part to C, which supports
EXPORT_SYMBOL_NS() for *.S files.
<asm/export.h> and <asm-generic/export.h> will remain as a wrapper of
<linux/export.h> for a while.
They will be removed after #include <asm/export.h> directives are all
replaced with #include <linux/export.h>.
[3] Implement CONFIG_TRIM_UNUSED_KSYMS in one-pass algorithm (by a later commit)
When CONFIG_TRIM_UNUSED_KSYMS is enabled, Kbuild recursively traverses
the directory tree to determine which EXPORT_SYMBOL to trim. If an
EXPORT_SYMBOL turns out to be unused by anyone, Kbuild begins the
second traverse, where some source files are recompiled with their
EXPORT_SYMBOL() tuned into a no-op.
We can do this better now; modpost can selectively emit KSYMTAB entries
that are really used by modules.
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
2023-06-11 15:50:52 +00:00
|
|
|
} else if (!strcmp(secname, ".export_symbol")) {
|
|
|
|
info->export_symbol_secndx = i;
|
modpost: remove useless export_from_sec()
With commit 1743694eb235 ("modpost: stop symbol preloading for
modversion CRC") applied, now export_from_sec() is useless.
handle_symbol() is called for every symbol in the ELF.
When 'symname' does not start with "__ksymtab", export_from_sec() is
called, and the returned value is stored in 'export'.
It is used in the last part of handle_symbol():
if (strstarts(symname, "__ksymtab_")) {
name = symname + strlen("__ksymtab_");
sym_add_exported(name, mod, export);
}
'export' is used only when 'symname' starts with "__ksymtab_".
So, the value returned by export_from_sec() is never used.
Remove useless export_from_sec(). This makes further cleanups possible.
I put the temporary code:
export = export_unknown;
Otherwise, I would get the compiler warning:
warning: 'export' may be used uninitialized in this function [-Wmaybe-uninitialized]
This is apparently false positive because
if (strstarts(symname, "__ksymtab_")
... is a stronger condition than:
if (strstarts(symname, "__ksymtab")
Anyway, this part will be cleaned up by the next commit.
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
2022-04-05 11:33:51 +00:00
|
|
|
}
|
2006-06-09 05:12:53 +00:00
|
|
|
|
2010-07-28 23:47:53 +00:00
|
|
|
if (sechdrs[i].sh_type == SHT_SYMTAB) {
|
|
|
|
unsigned int sh_link_idx;
|
|
|
|
symtab_idx = i;
|
|
|
|
info->symtab_start = (void *)hdr +
|
|
|
|
sechdrs[i].sh_offset;
|
|
|
|
info->symtab_stop = (void *)hdr +
|
|
|
|
sechdrs[i].sh_offset + sechdrs[i].sh_size;
|
2011-05-19 22:55:27 +00:00
|
|
|
sh_link_idx = sechdrs[i].sh_link;
|
2010-07-28 23:47:53 +00:00
|
|
|
info->strtab = (void *)hdr +
|
|
|
|
sechdrs[sh_link_idx].sh_offset;
|
|
|
|
}
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2010-07-28 23:47:53 +00:00
|
|
|
/* 32bit section no. table? ("more than 64k sections") */
|
|
|
|
if (sechdrs[i].sh_type == SHT_SYMTAB_SHNDX) {
|
|
|
|
symtab_shndx_idx = i;
|
|
|
|
info->symtab_shndx_start = (void *)hdr +
|
|
|
|
sechdrs[i].sh_offset;
|
|
|
|
info->symtab_shndx_stop = (void *)hdr +
|
|
|
|
sechdrs[i].sh_offset + sechdrs[i].sh_size;
|
|
|
|
}
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
2008-01-11 18:17:15 +00:00
|
|
|
if (!info->symtab_start)
|
2006-01-28 15:57:26 +00:00
|
|
|
fatal("%s has no symtab?\n", filename);
|
2008-01-11 18:17:15 +00:00
|
|
|
|
2005-04-16 22:20:36 +00:00
|
|
|
/* Fix endianness in symbols */
|
|
|
|
for (sym = info->symtab_start; sym < info->symtab_stop; sym++) {
|
|
|
|
sym->st_shndx = TO_NATIVE(sym->st_shndx);
|
|
|
|
sym->st_name = TO_NATIVE(sym->st_name);
|
|
|
|
sym->st_value = TO_NATIVE(sym->st_value);
|
|
|
|
sym->st_size = TO_NATIVE(sym->st_size);
|
|
|
|
}
|
2010-07-28 23:47:53 +00:00
|
|
|
|
|
|
|
if (symtab_shndx_idx != ~0U) {
|
|
|
|
Elf32_Word *p;
|
2011-05-19 22:55:27 +00:00
|
|
|
if (symtab_idx != sechdrs[symtab_shndx_idx].sh_link)
|
2010-07-28 23:47:53 +00:00
|
|
|
fatal("%s: SYMTAB_SHNDX has bad sh_link: %u!=%u\n",
|
2011-05-19 22:55:27 +00:00
|
|
|
filename, sechdrs[symtab_shndx_idx].sh_link,
|
2010-07-28 23:47:53 +00:00
|
|
|
symtab_idx);
|
|
|
|
/* Fix endianness */
|
|
|
|
for (p = info->symtab_shndx_start; p < info->symtab_shndx_stop;
|
|
|
|
p++)
|
|
|
|
*p = TO_NATIVE(*p);
|
|
|
|
}
|
|
|
|
|
2007-02-26 14:33:52 +00:00
|
|
|
return 1;
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
|
2006-01-28 16:19:35 +00:00
|
|
|
static void parse_elf_finish(struct elf_info *info)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
|
|
|
release_file(info->hdr, info->size);
|
|
|
|
}
|
|
|
|
|
2008-06-12 13:02:55 +00:00
|
|
|
static int ignore_undef_symbol(struct elf_info *info, const char *symname)
|
|
|
|
{
|
|
|
|
/* ignore __this_module, it will be resolved shortly */
|
2018-05-09 07:23:45 +00:00
|
|
|
if (strcmp(symname, "__this_module") == 0)
|
2008-06-12 13:02:55 +00:00
|
|
|
return 1;
|
|
|
|
/* ignore global offset table */
|
|
|
|
if (strcmp(symname, "_GLOBAL_OFFSET_TABLE_") == 0)
|
|
|
|
return 1;
|
|
|
|
if (info->hdr->e_machine == EM_PPC)
|
|
|
|
/* Special register function linked on all modules during final link of .ko */
|
2018-05-09 09:50:38 +00:00
|
|
|
if (strstarts(symname, "_restgpr_") ||
|
|
|
|
strstarts(symname, "_savegpr_") ||
|
|
|
|
strstarts(symname, "_rest32gpr_") ||
|
|
|
|
strstarts(symname, "_save32gpr_") ||
|
|
|
|
strstarts(symname, "_restvr_") ||
|
|
|
|
strstarts(symname, "_savevr_"))
|
2008-06-12 13:02:55 +00:00
|
|
|
return 1;
|
2010-06-29 20:08:42 +00:00
|
|
|
if (info->hdr->e_machine == EM_PPC64)
|
|
|
|
/* Special register function linked on all modules during final link of .ko */
|
2018-05-09 09:50:38 +00:00
|
|
|
if (strstarts(symname, "_restgpr0_") ||
|
|
|
|
strstarts(symname, "_savegpr0_") ||
|
|
|
|
strstarts(symname, "_restvr_") ||
|
|
|
|
strstarts(symname, "_savevr_") ||
|
2016-01-15 09:52:22 +00:00
|
|
|
strcmp(symname, ".TOC.") == 0)
|
2010-06-29 20:08:42 +00:00
|
|
|
return 1;
|
2022-03-06 19:56:07 +00:00
|
|
|
|
|
|
|
if (info->hdr->e_machine == EM_S390)
|
|
|
|
/* Expoline thunks are linked on all kernel modules during final link of .ko */
|
|
|
|
if (strstarts(symname, "__s390_indirect_jump_r"))
|
|
|
|
return 1;
|
2008-06-12 13:02:55 +00:00
|
|
|
/* Do not ignore this symbol */
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2019-11-14 17:42:23 +00:00
|
|
|
static void handle_symbol(struct module *mod, struct elf_info *info,
|
|
|
|
const Elf_Sym *sym, const char *symname)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
|
|
|
switch (sym->st_shndx) {
|
|
|
|
case SHN_COMMON:
|
2018-05-09 09:50:38 +00:00
|
|
|
if (strstarts(symname, "__gnu_lto_")) {
|
2014-02-08 08:01:17 +00:00
|
|
|
/* Should warn here, but modpost runs before the linker */
|
|
|
|
} else
|
|
|
|
warn("\"%s\" [%s] is COMMON symbol\n", symname, mod->name);
|
2005-04-16 22:20:36 +00:00
|
|
|
break;
|
|
|
|
case SHN_UNDEF:
|
|
|
|
/* undefined symbol */
|
|
|
|
if (ELF_ST_BIND(sym->st_info) != STB_GLOBAL &&
|
|
|
|
ELF_ST_BIND(sym->st_info) != STB_WEAK)
|
|
|
|
break;
|
2008-06-12 13:02:55 +00:00
|
|
|
if (ignore_undef_symbol(info, symname))
|
2005-04-16 22:20:36 +00:00
|
|
|
break;
|
|
|
|
if (info->hdr->e_machine == EM_SPARC ||
|
|
|
|
info->hdr->e_machine == EM_SPARCV9) {
|
|
|
|
/* Ignore register directives. */
|
2005-08-19 20:44:57 +00:00
|
|
|
if (ELF_ST_TYPE(sym->st_info) == STT_SPARC_REGISTER)
|
2005-04-16 22:20:36 +00:00
|
|
|
break;
|
2006-03-03 15:46:04 +00:00
|
|
|
if (symname[0] == '.') {
|
2018-08-15 19:30:38 +00:00
|
|
|
char *munged = NOFAIL(strdup(symname));
|
2006-03-03 15:46:04 +00:00
|
|
|
munged[0] = '_';
|
|
|
|
munged[1] = toupper(munged[1]);
|
|
|
|
symname = munged;
|
|
|
|
}
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
2006-03-03 15:46:04 +00:00
|
|
|
|
2022-05-01 08:40:11 +00:00
|
|
|
sym_add_unresolved(symname, mod,
|
|
|
|
ELF_ST_BIND(sym->st_info) == STB_WEAK);
|
2005-04-16 22:20:36 +00:00
|
|
|
break;
|
|
|
|
default:
|
2018-05-09 07:23:45 +00:00
|
|
|
if (strcmp(symname, "init_module") == 0)
|
2022-05-01 08:40:07 +00:00
|
|
|
mod->has_init = true;
|
2018-05-09 07:23:45 +00:00
|
|
|
if (strcmp(symname, "cleanup_module") == 0)
|
2022-05-01 08:40:07 +00:00
|
|
|
mod->has_cleanup = true;
|
2005-04-16 22:20:36 +00:00
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2006-01-28 16:19:35 +00:00
|
|
|
/**
|
|
|
|
* Parse tag=value strings from .modinfo section
|
|
|
|
**/
|
2005-04-16 22:20:36 +00:00
|
|
|
static char *next_string(char *string, unsigned long *secsize)
|
|
|
|
{
|
|
|
|
/* Skip non-zero chars */
|
|
|
|
while (string[0]) {
|
|
|
|
string++;
|
|
|
|
if ((*secsize)-- <= 1)
|
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Skip any zero padding. */
|
|
|
|
while (!string[0]) {
|
|
|
|
string++;
|
|
|
|
if ((*secsize)-- <= 1)
|
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
return string;
|
|
|
|
}
|
|
|
|
|
2018-05-09 09:50:37 +00:00
|
|
|
static char *get_next_modinfo(struct elf_info *info, const char *tag,
|
|
|
|
char *prev)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
|
|
|
char *p;
|
|
|
|
unsigned int taglen = strlen(tag);
|
2018-05-09 09:50:37 +00:00
|
|
|
char *modinfo = info->modinfo;
|
|
|
|
unsigned long size = info->modinfo_len;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2018-05-09 09:50:37 +00:00
|
|
|
if (prev) {
|
|
|
|
size -= prev - modinfo;
|
|
|
|
modinfo = next_string(prev, &size);
|
2006-06-09 19:53:55 +00:00
|
|
|
}
|
|
|
|
|
2005-04-16 22:20:36 +00:00
|
|
|
for (p = modinfo; p; p = next_string(p, &size)) {
|
|
|
|
if (strncmp(p, tag, taglen) == 0 && p[taglen] == '=')
|
|
|
|
return p + taglen + 1;
|
|
|
|
}
|
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
|
2018-05-09 09:50:37 +00:00
|
|
|
static char *get_modinfo(struct elf_info *info, const char *tag)
|
2006-06-09 19:53:55 +00:00
|
|
|
|
|
|
|
{
|
2018-05-09 09:50:37 +00:00
|
|
|
return get_next_modinfo(info, tag, NULL);
|
2006-06-09 19:53:55 +00:00
|
|
|
}
|
|
|
|
|
2008-01-23 18:54:27 +00:00
|
|
|
static const char *sym_name(struct elf_info *elf, Elf_Sym *sym)
|
|
|
|
{
|
2008-01-23 20:13:50 +00:00
|
|
|
if (sym)
|
|
|
|
return elf->strtab + sym->st_name;
|
|
|
|
else
|
2008-02-06 20:51:18 +00:00
|
|
|
return "(unknown)";
|
2008-01-23 18:54:27 +00:00
|
|
|
}
|
|
|
|
|
2022-05-30 09:01:39 +00:00
|
|
|
/*
|
|
|
|
* Check whether the 'string' argument matches one of the 'patterns',
|
|
|
|
* an array of shell wildcard patterns (glob).
|
|
|
|
*
|
|
|
|
* Return true is there is a match.
|
2008-01-13 21:21:31 +00:00
|
|
|
*/
|
2022-05-30 09:01:39 +00:00
|
|
|
static bool match(const char *string, const char *const patterns[])
|
2008-01-13 21:21:31 +00:00
|
|
|
{
|
2022-05-30 09:01:39 +00:00
|
|
|
const char *pattern;
|
2008-01-13 21:21:31 +00:00
|
|
|
|
2022-05-30 09:01:39 +00:00
|
|
|
while ((pattern = *patterns++)) {
|
|
|
|
if (!fnmatch(pattern, string, 0))
|
|
|
|
return true;
|
2008-01-13 21:21:31 +00:00
|
|
|
}
|
2022-05-30 09:01:39 +00:00
|
|
|
|
|
|
|
return false;
|
2008-01-13 21:21:31 +00:00
|
|
|
}
|
|
|
|
|
modpost: add PATTERNS() helper macro
This will be useful to define a NULL-terminated array inside a function
call.
Currently, string arrays passed to match() are defined in separate
places:
static const char *const init_sections[] = { ALL_INIT_SECTIONS, NULL };
static const char *const text_sections[] = { ALL_TEXT_SECTIONS, NULL };
static const char *const optim_symbols[] = { "*.constprop.*", NULL };
...
/* Check for pattern 5 */
if (match(fromsec, text_sections) &&
match(tosec, init_sections) &&
match(fromsym, optim_symbols))
return 0;
With the new helper macro, you can list the patterns directly in the
function call, like this:
/* Check for pattern 5 */
if (match(fromsec, PATTERNS(ALL_TEXT_SECTIONS)) &&
match(tosec, PATTERNS(ALL_INIT_SECTIONS)) &&
match(fromsym, PATTERNS("*.contprop.*")))
return 0;
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
2022-08-01 09:39:00 +00:00
|
|
|
/* useful to pass patterns to match() directly */
|
|
|
|
#define PATTERNS(...) \
|
|
|
|
({ \
|
|
|
|
static const char *const patterns[] = {__VA_ARGS__, NULL}; \
|
|
|
|
patterns; \
|
|
|
|
})
|
|
|
|
|
2008-01-13 21:21:31 +00:00
|
|
|
/* sections that we do not want to do full section mismatch check on */
|
2014-08-27 10:58:53 +00:00
|
|
|
static const char *const section_white_list[] =
|
2009-05-04 11:05:26 +00:00
|
|
|
{
|
|
|
|
".comment*",
|
|
|
|
".debug*",
|
2010-12-16 01:11:22 +00:00
|
|
|
".zdebug*", /* Compressed debug sections. */
|
2018-03-08 09:48:46 +00:00
|
|
|
".GCC.command.line", /* record-gcc-switches */
|
2009-05-04 11:05:26 +00:00
|
|
|
".mdebug*", /* alpha, score, mips etc. */
|
|
|
|
".pdr", /* alpha, score, mips etc. */
|
|
|
|
".stab*",
|
|
|
|
".note*",
|
|
|
|
".got*",
|
|
|
|
".toc*",
|
2012-09-17 01:44:38 +00:00
|
|
|
".xt.prop", /* xtensa */
|
|
|
|
".xt.lit", /* xtensa */
|
2013-01-21 06:48:57 +00:00
|
|
|
".arcextmap*", /* arc */
|
|
|
|
".gnu.linkonce.arcext*", /* arc : modules */
|
2015-10-26 09:21:46 +00:00
|
|
|
".cmem*", /* EZchip */
|
|
|
|
".fmt_slot*", /* EZchip */
|
2014-02-08 08:01:17 +00:00
|
|
|
".gnu.lto*",
|
2017-03-01 18:04:44 +00:00
|
|
|
".discard.*",
|
2009-05-04 11:05:26 +00:00
|
|
|
NULL
|
|
|
|
};
|
2008-01-13 21:21:31 +00:00
|
|
|
|
2008-01-28 19:13:13 +00:00
|
|
|
/*
|
2009-04-23 20:49:33 +00:00
|
|
|
* This is used to find sections missing the SHF_ALLOC flag.
|
2008-01-28 19:13:13 +00:00
|
|
|
* The cause of this is often a section specified in assembler
|
2009-04-23 20:49:33 +00:00
|
|
|
* without "ax" / "aw".
|
2008-01-28 19:13:13 +00:00
|
|
|
*/
|
2009-04-23 20:49:33 +00:00
|
|
|
static void check_section(const char *modname, struct elf_info *elf,
|
2014-06-10 10:08:13 +00:00
|
|
|
Elf_Shdr *sechdr)
|
2008-01-28 19:13:13 +00:00
|
|
|
{
|
2009-04-23 20:49:33 +00:00
|
|
|
const char *sec = sech_name(elf, sechdr);
|
|
|
|
|
|
|
|
if (sechdr->sh_type == SHT_PROGBITS &&
|
|
|
|
!(sechdr->sh_flags & SHF_ALLOC) &&
|
|
|
|
!match(sec, section_white_list)) {
|
|
|
|
warn("%s (%s): unexpected non-allocatable section.\n"
|
|
|
|
"Did you forget to use \"ax\"/\"aw\" in a .S file?\n"
|
|
|
|
"Note that for example <linux/init.h> contains\n"
|
|
|
|
"section definitions for use in .S files.\n\n",
|
|
|
|
modname, sec);
|
2008-01-28 19:13:13 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
|
2008-01-20 19:07:28 +00:00
|
|
|
#define ALL_INIT_DATA_SECTIONS \
|
2014-07-26 21:58:01 +00:00
|
|
|
".init.setup", ".init.rodata", ".meminit.rodata", \
|
|
|
|
".init.data", ".meminit.data"
|
2008-01-20 19:07:28 +00:00
|
|
|
#define ALL_EXIT_DATA_SECTIONS \
|
2014-07-26 21:58:01 +00:00
|
|
|
".exit.data", ".memexit.data"
|
2008-01-13 21:21:31 +00:00
|
|
|
|
2008-01-20 19:07:28 +00:00
|
|
|
#define ALL_INIT_TEXT_SECTIONS \
|
2014-07-26 21:58:01 +00:00
|
|
|
".init.text", ".meminit.text"
|
2008-01-20 19:07:28 +00:00
|
|
|
#define ALL_EXIT_TEXT_SECTIONS \
|
2014-07-26 21:58:01 +00:00
|
|
|
".exit.text", ".memexit.text"
|
2008-01-13 21:21:31 +00:00
|
|
|
|
2012-06-03 18:48:17 +00:00
|
|
|
#define ALL_PCI_INIT_SECTIONS \
|
2014-07-26 21:58:01 +00:00
|
|
|
".pci_fixup_early", ".pci_fixup_header", ".pci_fixup_final", \
|
|
|
|
".pci_fixup_enable", ".pci_fixup_resume", \
|
|
|
|
".pci_fixup_resume_early", ".pci_fixup_suspend"
|
2012-06-03 18:48:17 +00:00
|
|
|
|
2013-06-19 23:30:48 +00:00
|
|
|
#define ALL_XXXINIT_SECTIONS MEM_INIT_SECTIONS
|
|
|
|
#define ALL_XXXEXIT_SECTIONS MEM_EXIT_SECTIONS
|
2010-01-29 11:04:26 +00:00
|
|
|
|
|
|
|
#define ALL_INIT_SECTIONS INIT_SECTIONS, ALL_XXXINIT_SECTIONS
|
|
|
|
#define ALL_EXIT_SECTIONS EXIT_SECTIONS, ALL_XXXEXIT_SECTIONS
|
2008-01-13 21:21:31 +00:00
|
|
|
|
2014-07-26 21:58:01 +00:00
|
|
|
#define DATA_SECTIONS ".data", ".data.rel"
|
2022-12-13 18:35:29 +00:00
|
|
|
#define TEXT_SECTIONS ".text", ".text.*", ".sched.text", \
|
2020-03-09 21:47:17 +00:00
|
|
|
".kprobes.text", ".cpuidle.text", ".noinstr.text"
|
2015-04-13 11:22:53 +00:00
|
|
|
#define OTHER_TEXT_SECTIONS ".ref.text", ".head.text", ".spinlock.text", \
|
2022-12-13 18:35:29 +00:00
|
|
|
".fixup", ".entry.text", ".exception.text", \
|
powerpc/bug: Provide better flexibility to WARN_ON/__WARN_FLAGS() with asm goto
Using asm goto in __WARN_FLAGS() and WARN_ON() allows more
flexibility to GCC.
For that add an entry to the exception table so that
program_check_exception() knowns where to resume execution
after a WARNING.
Here are two exemples. The first one is done on PPC32 (which
benefits from the previous patch), the second is on PPC64.
unsigned long test(struct pt_regs *regs)
{
int ret;
WARN_ON(regs->msr & MSR_PR);
return regs->gpr[3];
}
unsigned long test9w(unsigned long a, unsigned long b)
{
if (WARN_ON(!b))
return 0;
return a / b;
}
Before the patch:
000003a8 <test>:
3a8: 81 23 00 84 lwz r9,132(r3)
3ac: 71 29 40 00 andi. r9,r9,16384
3b0: 40 82 00 0c bne 3bc <test+0x14>
3b4: 80 63 00 0c lwz r3,12(r3)
3b8: 4e 80 00 20 blr
3bc: 0f e0 00 00 twui r0,0
3c0: 80 63 00 0c lwz r3,12(r3)
3c4: 4e 80 00 20 blr
0000000000000bf0 <.test9w>:
bf0: 7c 89 00 74 cntlzd r9,r4
bf4: 79 29 d1 82 rldicl r9,r9,58,6
bf8: 0b 09 00 00 tdnei r9,0
bfc: 2c 24 00 00 cmpdi r4,0
c00: 41 82 00 0c beq c0c <.test9w+0x1c>
c04: 7c 63 23 92 divdu r3,r3,r4
c08: 4e 80 00 20 blr
c0c: 38 60 00 00 li r3,0
c10: 4e 80 00 20 blr
After the patch:
000003a8 <test>:
3a8: 81 23 00 84 lwz r9,132(r3)
3ac: 71 29 40 00 andi. r9,r9,16384
3b0: 40 82 00 0c bne 3bc <test+0x14>
3b4: 80 63 00 0c lwz r3,12(r3)
3b8: 4e 80 00 20 blr
3bc: 0f e0 00 00 twui r0,0
0000000000000c50 <.test9w>:
c50: 7c 89 00 74 cntlzd r9,r4
c54: 79 29 d1 82 rldicl r9,r9,58,6
c58: 0b 09 00 00 tdnei r9,0
c5c: 7c 63 23 92 divdu r3,r3,r4
c60: 4e 80 00 20 blr
c70: 38 60 00 00 li r3,0
c74: 4e 80 00 20 blr
In the first exemple, we see GCC doesn't need to duplicate what
happens after the trap.
In the second exemple, we see that GCC doesn't need to emit a test
and a branch in the likely path in addition to the trap.
We've got some WARN_ON() in .softirqentry.text section so it needs
to be added in the OTHER_TEXT_SECTIONS in modpost.c
Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/389962b1b702e3c78d169e59bcfac56282889173.1618331882.git.christophe.leroy@csgroup.eu
2021-04-13 16:38:10 +00:00
|
|
|
".coldtext", ".softirqentry.text"
|
2008-01-13 21:21:31 +00:00
|
|
|
|
2009-03-12 10:58:33 +00:00
|
|
|
#define INIT_SECTIONS ".init.*"
|
|
|
|
#define MEM_INIT_SECTIONS ".meminit.*"
|
2008-01-20 19:07:28 +00:00
|
|
|
|
2009-03-12 10:58:33 +00:00
|
|
|
#define EXIT_SECTIONS ".exit.*"
|
|
|
|
#define MEM_EXIT_SECTIONS ".memexit.*"
|
2008-01-20 19:07:28 +00:00
|
|
|
|
2015-04-13 11:22:53 +00:00
|
|
|
#define ALL_TEXT_SECTIONS ALL_INIT_TEXT_SECTIONS, ALL_EXIT_TEXT_SECTIONS, \
|
|
|
|
TEXT_SECTIONS, OTHER_TEXT_SECTIONS
|
|
|
|
|
2008-01-24 20:12:37 +00:00
|
|
|
enum mismatch {
|
2010-01-30 15:35:47 +00:00
|
|
|
TEXT_TO_ANY_INIT,
|
|
|
|
DATA_TO_ANY_INIT,
|
2023-05-21 16:04:22 +00:00
|
|
|
TEXTDATA_TO_ANY_EXIT,
|
2010-01-30 15:35:47 +00:00
|
|
|
XXXINIT_TO_SOME_INIT,
|
|
|
|
XXXEXIT_TO_SOME_EXIT,
|
|
|
|
ANY_INIT_TO_ANY_EXIT,
|
|
|
|
ANY_EXIT_TO_ANY_INIT,
|
2015-04-13 11:22:53 +00:00
|
|
|
EXTABLE_TO_NON_TEXT,
|
2008-01-24 20:12:37 +00:00
|
|
|
};
|
|
|
|
|
2015-04-13 11:25:15 +00:00
|
|
|
/**
|
2021-03-26 05:52:19 +00:00
|
|
|
* Describe how to match sections on different criteria:
|
2015-04-13 11:25:15 +00:00
|
|
|
*
|
|
|
|
* @fromsec: Array of sections to be matched.
|
|
|
|
*
|
|
|
|
* @bad_tosec: Relocations applied to a section in @fromsec to a section in
|
|
|
|
* this array is forbidden (black-list). Can be empty.
|
|
|
|
*
|
|
|
|
* @good_tosec: Relocations applied to a section in @fromsec must be
|
2021-03-26 05:52:19 +00:00
|
|
|
* targeting sections in this array (white-list). Can be empty.
|
2015-04-13 11:25:15 +00:00
|
|
|
*
|
|
|
|
* @mismatch: Type of mismatch.
|
|
|
|
*/
|
2008-01-13 21:21:31 +00:00
|
|
|
struct sectioncheck {
|
|
|
|
const char *fromsec[20];
|
2015-04-13 11:11:04 +00:00
|
|
|
const char *bad_tosec[20];
|
|
|
|
const char *good_tosec[20];
|
2008-01-24 20:12:37 +00:00
|
|
|
enum mismatch mismatch;
|
2008-01-13 21:21:31 +00:00
|
|
|
};
|
|
|
|
|
2014-08-27 10:58:53 +00:00
|
|
|
static const struct sectioncheck sectioncheck[] = {
|
2008-01-13 21:21:31 +00:00
|
|
|
/* Do not reference init/exit code/data from
|
|
|
|
* normal code and data
|
|
|
|
*/
|
|
|
|
{
|
2008-01-24 20:12:37 +00:00
|
|
|
.fromsec = { TEXT_SECTIONS, NULL },
|
2015-04-13 11:11:04 +00:00
|
|
|
.bad_tosec = { ALL_INIT_SECTIONS, NULL },
|
2010-01-30 15:35:47 +00:00
|
|
|
.mismatch = TEXT_TO_ANY_INIT,
|
2008-01-24 20:12:37 +00:00
|
|
|
},
|
|
|
|
{
|
|
|
|
.fromsec = { DATA_SECTIONS, NULL },
|
2023-05-21 16:04:21 +00:00
|
|
|
.bad_tosec = { ALL_XXXINIT_SECTIONS, INIT_SECTIONS, NULL },
|
2010-01-30 20:14:23 +00:00
|
|
|
.mismatch = DATA_TO_ANY_INIT,
|
|
|
|
},
|
2008-01-24 20:12:37 +00:00
|
|
|
{
|
2023-05-21 16:04:22 +00:00
|
|
|
.fromsec = { TEXT_SECTIONS, DATA_SECTIONS, NULL },
|
2015-04-13 11:11:04 +00:00
|
|
|
.bad_tosec = { ALL_EXIT_SECTIONS, NULL },
|
2023-05-21 16:04:22 +00:00
|
|
|
.mismatch = TEXTDATA_TO_ANY_EXIT,
|
2008-01-20 19:07:28 +00:00
|
|
|
},
|
2013-06-19 23:30:48 +00:00
|
|
|
/* Do not reference init code/data from meminit code/data */
|
2008-01-20 19:07:28 +00:00
|
|
|
{
|
2010-01-29 11:04:26 +00:00
|
|
|
.fromsec = { ALL_XXXINIT_SECTIONS, NULL },
|
2015-04-13 11:11:04 +00:00
|
|
|
.bad_tosec = { INIT_SECTIONS, NULL },
|
2010-01-30 15:35:47 +00:00
|
|
|
.mismatch = XXXINIT_TO_SOME_INIT,
|
2008-01-20 19:07:28 +00:00
|
|
|
},
|
2013-06-19 23:30:48 +00:00
|
|
|
/* Do not reference exit code/data from memexit code/data */
|
2008-01-20 19:07:28 +00:00
|
|
|
{
|
2010-01-29 11:04:26 +00:00
|
|
|
.fromsec = { ALL_XXXEXIT_SECTIONS, NULL },
|
2015-04-13 11:11:04 +00:00
|
|
|
.bad_tosec = { EXIT_SECTIONS, NULL },
|
2010-01-30 15:35:47 +00:00
|
|
|
.mismatch = XXXEXIT_TO_SOME_EXIT,
|
2008-01-13 21:21:31 +00:00
|
|
|
},
|
|
|
|
/* Do not use exit code/data from init code */
|
|
|
|
{
|
2008-01-20 19:07:28 +00:00
|
|
|
.fromsec = { ALL_INIT_SECTIONS, NULL },
|
2015-04-13 11:11:04 +00:00
|
|
|
.bad_tosec = { ALL_EXIT_SECTIONS, NULL },
|
2010-01-30 15:35:47 +00:00
|
|
|
.mismatch = ANY_INIT_TO_ANY_EXIT,
|
2008-01-13 21:21:31 +00:00
|
|
|
},
|
|
|
|
/* Do not use init code/data from exit code */
|
|
|
|
{
|
2008-01-20 19:07:28 +00:00
|
|
|
.fromsec = { ALL_EXIT_SECTIONS, NULL },
|
2015-04-13 11:11:04 +00:00
|
|
|
.bad_tosec = { ALL_INIT_SECTIONS, NULL },
|
2010-01-30 15:35:47 +00:00
|
|
|
.mismatch = ANY_EXIT_TO_ANY_INIT,
|
2008-01-13 21:21:31 +00:00
|
|
|
},
|
2012-06-03 18:48:17 +00:00
|
|
|
{
|
|
|
|
.fromsec = { ALL_PCI_INIT_SECTIONS, NULL },
|
2015-04-13 11:11:04 +00:00
|
|
|
.bad_tosec = { INIT_SECTIONS, NULL },
|
2012-06-03 18:48:17 +00:00
|
|
|
.mismatch = ANY_INIT_TO_ANY_EXIT,
|
|
|
|
},
|
2015-04-13 11:22:53 +00:00
|
|
|
{
|
|
|
|
.fromsec = { "__ex_table", NULL },
|
|
|
|
/* If you're adding any new black-listed sections in here, consider
|
|
|
|
* adding a special 'printer' for them in scripts/check_extable.
|
|
|
|
*/
|
|
|
|
.bad_tosec = { ".altinstr_replacement", NULL },
|
|
|
|
.good_tosec = {ALL_TEXT_SECTIONS , NULL},
|
|
|
|
.mismatch = EXTABLE_TO_NON_TEXT,
|
2008-01-13 21:21:31 +00:00
|
|
|
}
|
|
|
|
};
|
|
|
|
|
2010-01-30 15:56:20 +00:00
|
|
|
static const struct sectioncheck *section_mismatch(
|
|
|
|
const char *fromsec, const char *tosec)
|
2008-01-13 21:21:31 +00:00
|
|
|
{
|
|
|
|
int i;
|
|
|
|
|
2015-04-16 03:46:41 +00:00
|
|
|
/*
|
|
|
|
* The target section could be the SHT_NUL section when we're
|
|
|
|
* handling relocations to un-resolved symbols, trying to match it
|
2018-03-08 09:48:46 +00:00
|
|
|
* doesn't make much sense and causes build failures on parisc
|
|
|
|
* architectures.
|
2015-04-16 03:46:41 +00:00
|
|
|
*/
|
|
|
|
if (*tosec == '\0')
|
|
|
|
return NULL;
|
|
|
|
|
2022-05-23 16:46:25 +00:00
|
|
|
for (i = 0; i < ARRAY_SIZE(sectioncheck); i++) {
|
|
|
|
const struct sectioncheck *check = §ioncheck[i];
|
|
|
|
|
2015-04-13 11:11:04 +00:00
|
|
|
if (match(fromsec, check->fromsec)) {
|
|
|
|
if (check->bad_tosec[0] && match(tosec, check->bad_tosec))
|
|
|
|
return check;
|
|
|
|
if (check->good_tosec[0] && !match(tosec, check->good_tosec))
|
|
|
|
return check;
|
|
|
|
}
|
2008-01-13 21:21:31 +00:00
|
|
|
}
|
2010-01-30 15:56:20 +00:00
|
|
|
return NULL;
|
2008-01-13 21:21:31 +00:00
|
|
|
}
|
|
|
|
|
2006-02-26 21:18:11 +00:00
|
|
|
/**
|
|
|
|
* Whitelist to allow certain references to pass with no warning.
|
2007-05-17 18:14:48 +00:00
|
|
|
*
|
2006-02-26 21:18:11 +00:00
|
|
|
* Pattern 1:
|
|
|
|
* If a module parameter is declared __initdata and permissions=0
|
|
|
|
* then this is legal despite the warning generated.
|
|
|
|
* We cannot see value of permissions here, so just ignore
|
|
|
|
* this pattern.
|
|
|
|
* The pattern is identified by:
|
|
|
|
* tosec = .init.data
|
2006-03-04 23:16:26 +00:00
|
|
|
* fromsec = .data*
|
2006-02-26 21:18:11 +00:00
|
|
|
* atsym =__param*
|
2006-03-03 15:46:04 +00:00
|
|
|
*
|
2010-08-12 05:04:16 +00:00
|
|
|
* Pattern 1a:
|
|
|
|
* module_param_call() ops can refer to __init set function if permissions=0
|
|
|
|
* The pattern is identified by:
|
|
|
|
* tosec = .init.text
|
|
|
|
* fromsec = .data*
|
|
|
|
* atsym = __param_ops_*
|
|
|
|
*
|
2007-01-11 00:52:44 +00:00
|
|
|
* Pattern 3:
|
2009-04-26 09:17:42 +00:00
|
|
|
* Whitelist all references from .head.text to any init section
|
2007-02-26 16:49:06 +00:00
|
|
|
*
|
2007-06-02 22:41:22 +00:00
|
|
|
* Pattern 4:
|
2007-01-11 00:52:44 +00:00
|
|
|
* Some symbols belong to init section but still it is ok to reference
|
|
|
|
* these from non-init sections as these symbols don't have any memory
|
|
|
|
* allocated for them and symbol address and value are same. So even
|
|
|
|
* if init section is freed, its ok to reference those symbols.
|
|
|
|
* For ex. symbols marking the init section boundaries.
|
|
|
|
* This pattern is identified by
|
|
|
|
* refsymname = __init_begin, _sinittext, _einittext
|
2007-02-26 16:49:06 +00:00
|
|
|
*
|
2015-04-20 00:50:40 +00:00
|
|
|
* Pattern 5:
|
|
|
|
* GCC may optimize static inlines when fed constant arg(s) resulting
|
|
|
|
* in functions like cpumask_empty() -- generating an associated symbol
|
|
|
|
* cpumask_empty.constprop.3 that appears in the audit. If the const that
|
|
|
|
* is passed in comes from __init, like say nmi_ipi_mask, we get a
|
|
|
|
* meaningless section warning. May need to add isra symbols too...
|
|
|
|
* This pattern is identified by
|
|
|
|
* tosec = init section
|
|
|
|
* fromsec = text section
|
|
|
|
* refsymname = *.constprop.*
|
|
|
|
*
|
2006-02-26 21:18:11 +00:00
|
|
|
**/
|
2023-05-21 16:04:09 +00:00
|
|
|
static int secref_whitelist(const char *fromsec, const char *fromsym,
|
2008-01-23 20:13:50 +00:00
|
|
|
const char *tosec, const char *tosym)
|
2006-02-26 21:18:11 +00:00
|
|
|
{
|
|
|
|
/* Check for pattern 1 */
|
2023-05-21 16:04:23 +00:00
|
|
|
if (match(tosec, PATTERNS(ALL_INIT_DATA_SECTIONS)) &&
|
|
|
|
match(fromsec, PATTERNS(DATA_SECTIONS)) &&
|
2018-05-09 09:50:38 +00:00
|
|
|
strstarts(fromsym, "__param"))
|
2008-01-23 20:13:50 +00:00
|
|
|
return 0;
|
2006-02-26 21:18:11 +00:00
|
|
|
|
2010-08-12 05:04:16 +00:00
|
|
|
/* Check for pattern 1a */
|
|
|
|
if (strcmp(tosec, ".init.text") == 0 &&
|
2023-05-21 16:04:23 +00:00
|
|
|
match(fromsec, PATTERNS(DATA_SECTIONS)) &&
|
2018-05-09 09:50:38 +00:00
|
|
|
strstarts(fromsym, "__param_ops_"))
|
2010-08-12 05:04:16 +00:00
|
|
|
return 0;
|
|
|
|
|
2022-08-01 09:39:02 +00:00
|
|
|
/* symbols in data sections that may refer to any init/exit sections */
|
|
|
|
if (match(fromsec, PATTERNS(DATA_SECTIONS)) &&
|
|
|
|
match(tosec, PATTERNS(ALL_INIT_SECTIONS, ALL_EXIT_SECTIONS)) &&
|
|
|
|
match(fromsym, PATTERNS("*_template", // scsi uses *_template a lot
|
|
|
|
"*_timer", // arm uses ops structures named _timer a lot
|
|
|
|
"*_sht", // scsi also used *_sht to some extent
|
|
|
|
"*_ops",
|
|
|
|
"*_probe",
|
|
|
|
"*_probe_one",
|
|
|
|
"*_console")))
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
/* symbols in data sections that may refer to meminit/exit sections */
|
|
|
|
if (match(fromsec, PATTERNS(DATA_SECTIONS)) &&
|
|
|
|
match(tosec, PATTERNS(ALL_XXXINIT_SECTIONS, ALL_EXIT_SECTIONS)) &&
|
|
|
|
match(fromsym, PATTERNS("*driver")))
|
2008-01-23 20:13:50 +00:00
|
|
|
return 0;
|
2006-02-26 21:18:11 +00:00
|
|
|
|
2007-02-26 16:49:06 +00:00
|
|
|
/* Check for pattern 3 */
|
2023-05-21 16:04:23 +00:00
|
|
|
if (strstarts(fromsec, ".head.text") &&
|
|
|
|
match(tosec, PATTERNS(ALL_INIT_SECTIONS)))
|
2008-01-23 20:13:50 +00:00
|
|
|
return 0;
|
2007-02-26 16:49:06 +00:00
|
|
|
|
2007-06-02 22:41:22 +00:00
|
|
|
/* Check for pattern 4 */
|
2023-05-21 16:04:23 +00:00
|
|
|
if (match(tosym, PATTERNS("__init_begin", "_sinittext", "_einittext")))
|
2008-01-23 20:13:50 +00:00
|
|
|
return 0;
|
2007-02-26 16:49:06 +00:00
|
|
|
|
2015-04-20 00:50:40 +00:00
|
|
|
/* Check for pattern 5 */
|
2023-05-21 16:04:23 +00:00
|
|
|
if (match(fromsec, PATTERNS(ALL_TEXT_SECTIONS)) &&
|
|
|
|
match(tosec, PATTERNS(ALL_INIT_SECTIONS)) &&
|
|
|
|
match(fromsym, PATTERNS("*.constprop.*")))
|
modpost: skip ELF local symbols during section mismatch check
During development of a serial console driver with a gcc 8.2.0
toolchain for RISC-V, the following modpost warning appeared:
----
WARNING: vmlinux.o(.data+0x19b10): Section mismatch in reference from the variable .LANCHOR1 to the function .init.text:sifive_serial_console_setup()
The variable .LANCHOR1 references
the function __init sifive_serial_console_setup()
If the reference is valid then annotate the
variable with __init* or __refdata (see linux/init.h) or name the variable:
*_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console
----
".LANCHOR1" is an ELF local symbol, automatically created by gcc's section
anchor generation code:
https://gcc.gnu.org/onlinedocs/gccint/Anchored-Addresses.html
https://gcc.gnu.org/git/?p=gcc.git;a=blob;f=gcc/varasm.c;h=cd9591a45617464946dcf9a126dde277d9de9804;hb=9fb89fa845c1b2e0a18d85ada0b077c84508ab78#l7473
This was verified by compiling the kernel with -fno-section-anchors
and observing that the ".LANCHOR1" ELF local symbol disappeared, and
modpost no longer warned about the section mismatch. The serial
driver code idiom triggering the warning is standard Linux serial
driver practice that has a specific whitelist inclusion in modpost.c.
I'm neither a modpost nor an ELF expert, but naively, it doesn't seem
useful for modpost to report section mismatch warnings caused by ELF
local symbols by default. Local symbols have compiler-generated
names, and thus bypass modpost's whitelisting algorithm, which relies
on the presence of a non-autogenerated symbol name. This increases
the likelihood that false positive warnings will be generated (as in
the above case).
Thus, disable section mismatch reporting on ELF local symbols. The
rationale here is similar to that of commit 2e3a10a1551d ("ARM: avoid
ARM binutils leaking ELF local symbols") and of similar code already
present in modpost.c:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/scripts/mod/modpost.c?h=v4.19-rc4&id=7876320f88802b22d4e2daf7eb027dd14175a0f8#n1256
This third version of the patch implements a suggestion from Masahiro
Yamada <yamada.masahiro@socionext.com> to restructure the code as an
additional pattern matching step inside secref_whitelist(), and
further improves the patch description.
Signed-off-by: Paul Walmsley <paul.walmsley@sifive.com>
Signed-off-by: Paul Walmsley <paul@pwsan.com>
Acked-by: Sam Ravnborg <sam@ravnborg.org>
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
2018-11-21 21:14:13 +00:00
|
|
|
return 0;
|
|
|
|
|
2008-01-23 20:13:50 +00:00
|
|
|
return 1;
|
2006-02-26 21:18:11 +00:00
|
|
|
}
|
|
|
|
|
2018-10-23 22:15:35 +00:00
|
|
|
/*
|
|
|
|
* If there's no name there, ignore it; likewise, ignore it if it's
|
2023-03-31 09:15:53 +00:00
|
|
|
* one of the magic symbols emitted used by current tools.
|
2018-10-23 22:15:35 +00:00
|
|
|
*
|
|
|
|
* Otherwise if find_symbols_between() returns those symbols, they'll
|
|
|
|
* fail the whitelist tests and cause lots of false alarms ... fixable
|
|
|
|
* only by merging __exit and __init sections into __text, bloating
|
|
|
|
* the kernel (which is especially evil on embedded platforms).
|
|
|
|
*/
|
|
|
|
static inline int is_valid_name(struct elf_info *elf, Elf_Sym *sym)
|
|
|
|
{
|
|
|
|
const char *name = elf->strtab + sym->st_name;
|
|
|
|
|
|
|
|
if (!name || !strlen(name))
|
|
|
|
return 0;
|
2023-03-31 09:15:53 +00:00
|
|
|
return !is_mapping_symbol(name);
|
2018-10-23 22:15:35 +00:00
|
|
|
}
|
|
|
|
|
2023-06-01 12:09:58 +00:00
|
|
|
/* Look up the nearest symbol based on the section and the address */
|
|
|
|
static Elf_Sym *find_nearest_sym(struct elf_info *elf, Elf_Addr addr,
|
|
|
|
unsigned int secndx, bool allow_negative,
|
|
|
|
Elf_Addr min_distance)
|
2006-02-19 10:53:35 +00:00
|
|
|
{
|
|
|
|
Elf_Sym *sym;
|
2008-01-18 20:04:34 +00:00
|
|
|
Elf_Sym *near = NULL;
|
modpost: detect section mismatch for R_ARM_THM_{MOVW_ABS_NC,MOVT_ABS}
When CONFIG_THUMB2_KERNEL is enabled, modpost fails to detect some
types of section mismatches.
[test code]
#include <linux/init.h>
int __initdata foo;
int get_foo(void) { return foo; }
It is apparently a bad reference, but modpost does not report anything.
The test code above produces the following relocations.
Relocation section '.rel.text' at offset 0x1e8 contains 2 entries:
Offset Info Type Sym.Value Sym. Name
00000000 0000052f R_ARM_THM_MOVW_AB 00000000 .LANCHOR0
00000004 00000530 R_ARM_THM_MOVT_AB 00000000 .LANCHOR0
Currently, R_ARM_THM_MOVW_ABS_NC and R_ARM_THM_MOVT_ABS are just skipped.
Add code to handle them. I checked arch/arm/kernel/module.c to learn
how the offset is encoded in the instruction.
One more thing to note for Thumb instructions - the st_value is an odd
value, so you need to mask the bit 0 to get the offset. Otherwise, you
will get an off-by-one error in the nearest symbol look-up.
It is documented in "ELF for the ARM Architecture" [1]:
In addition to the normal rules for symbol values the following rules
shall also apply to symbols of type STT_FUNC:
* If the symbol addresses an Arm instruction, its value is the
address of the instruction (in a relocatable object, the offset
of the instruction from the start of the section containing it).
* If the symbol addresses a Thumb instruction, its value is the
address of the instruction with bit zero set (in a relocatable
object, the section offset with bit zero set).
* For the purposes of relocation the value used shall be the address
of the instruction (st_value & ~1).
[1]: https://github.com/ARM-software/abi-aa/blob/main/aaelf32/aaelf32.rst
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
2023-06-01 12:09:59 +00:00
|
|
|
Elf_Addr sym_addr, distance;
|
|
|
|
bool is_arm = (elf->hdr->e_machine == EM_ARM);
|
2010-07-28 23:47:53 +00:00
|
|
|
|
2006-02-19 10:53:35 +00:00
|
|
|
for (sym = elf->symtab_start; sym < elf->symtab_stop; sym++) {
|
2023-06-01 12:09:58 +00:00
|
|
|
if (get_secindex(elf, sym) != secndx)
|
2007-05-22 09:27:39 +00:00
|
|
|
continue;
|
2018-10-23 22:15:35 +00:00
|
|
|
if (!is_valid_name(elf, sym))
|
|
|
|
continue;
|
2006-02-19 10:53:35 +00:00
|
|
|
|
modpost: detect section mismatch for R_ARM_THM_{MOVW_ABS_NC,MOVT_ABS}
When CONFIG_THUMB2_KERNEL is enabled, modpost fails to detect some
types of section mismatches.
[test code]
#include <linux/init.h>
int __initdata foo;
int get_foo(void) { return foo; }
It is apparently a bad reference, but modpost does not report anything.
The test code above produces the following relocations.
Relocation section '.rel.text' at offset 0x1e8 contains 2 entries:
Offset Info Type Sym.Value Sym. Name
00000000 0000052f R_ARM_THM_MOVW_AB 00000000 .LANCHOR0
00000004 00000530 R_ARM_THM_MOVT_AB 00000000 .LANCHOR0
Currently, R_ARM_THM_MOVW_ABS_NC and R_ARM_THM_MOVT_ABS are just skipped.
Add code to handle them. I checked arch/arm/kernel/module.c to learn
how the offset is encoded in the instruction.
One more thing to note for Thumb instructions - the st_value is an odd
value, so you need to mask the bit 0 to get the offset. Otherwise, you
will get an off-by-one error in the nearest symbol look-up.
It is documented in "ELF for the ARM Architecture" [1]:
In addition to the normal rules for symbol values the following rules
shall also apply to symbols of type STT_FUNC:
* If the symbol addresses an Arm instruction, its value is the
address of the instruction (in a relocatable object, the offset
of the instruction from the start of the section containing it).
* If the symbol addresses a Thumb instruction, its value is the
address of the instruction with bit zero set (in a relocatable
object, the section offset with bit zero set).
* For the purposes of relocation the value used shall be the address
of the instruction (st_value & ~1).
[1]: https://github.com/ARM-software/abi-aa/blob/main/aaelf32/aaelf32.rst
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
2023-06-01 12:09:59 +00:00
|
|
|
sym_addr = sym->st_value;
|
2006-03-03 15:46:04 +00:00
|
|
|
|
modpost: detect section mismatch for R_ARM_THM_{MOVW_ABS_NC,MOVT_ABS}
When CONFIG_THUMB2_KERNEL is enabled, modpost fails to detect some
types of section mismatches.
[test code]
#include <linux/init.h>
int __initdata foo;
int get_foo(void) { return foo; }
It is apparently a bad reference, but modpost does not report anything.
The test code above produces the following relocations.
Relocation section '.rel.text' at offset 0x1e8 contains 2 entries:
Offset Info Type Sym.Value Sym. Name
00000000 0000052f R_ARM_THM_MOVW_AB 00000000 .LANCHOR0
00000004 00000530 R_ARM_THM_MOVT_AB 00000000 .LANCHOR0
Currently, R_ARM_THM_MOVW_ABS_NC and R_ARM_THM_MOVT_ABS are just skipped.
Add code to handle them. I checked arch/arm/kernel/module.c to learn
how the offset is encoded in the instruction.
One more thing to note for Thumb instructions - the st_value is an odd
value, so you need to mask the bit 0 to get the offset. Otherwise, you
will get an off-by-one error in the nearest symbol look-up.
It is documented in "ELF for the ARM Architecture" [1]:
In addition to the normal rules for symbol values the following rules
shall also apply to symbols of type STT_FUNC:
* If the symbol addresses an Arm instruction, its value is the
address of the instruction (in a relocatable object, the offset
of the instruction from the start of the section containing it).
* If the symbol addresses a Thumb instruction, its value is the
address of the instruction with bit zero set (in a relocatable
object, the section offset with bit zero set).
* For the purposes of relocation the value used shall be the address
of the instruction (st_value & ~1).
[1]: https://github.com/ARM-software/abi-aa/blob/main/aaelf32/aaelf32.rst
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
2023-06-01 12:09:59 +00:00
|
|
|
/*
|
|
|
|
* For ARM Thumb instruction, the bit 0 of st_value is set
|
|
|
|
* if the symbol is STT_FUNC type. Mask it to get the address.
|
|
|
|
*/
|
|
|
|
if (is_arm && ELF_ST_TYPE(sym->st_info) == STT_FUNC)
|
|
|
|
sym_addr &= ~1;
|
2006-02-17 21:42:02 +00:00
|
|
|
|
modpost: detect section mismatch for R_ARM_THM_{MOVW_ABS_NC,MOVT_ABS}
When CONFIG_THUMB2_KERNEL is enabled, modpost fails to detect some
types of section mismatches.
[test code]
#include <linux/init.h>
int __initdata foo;
int get_foo(void) { return foo; }
It is apparently a bad reference, but modpost does not report anything.
The test code above produces the following relocations.
Relocation section '.rel.text' at offset 0x1e8 contains 2 entries:
Offset Info Type Sym.Value Sym. Name
00000000 0000052f R_ARM_THM_MOVW_AB 00000000 .LANCHOR0
00000004 00000530 R_ARM_THM_MOVT_AB 00000000 .LANCHOR0
Currently, R_ARM_THM_MOVW_ABS_NC and R_ARM_THM_MOVT_ABS are just skipped.
Add code to handle them. I checked arch/arm/kernel/module.c to learn
how the offset is encoded in the instruction.
One more thing to note for Thumb instructions - the st_value is an odd
value, so you need to mask the bit 0 to get the offset. Otherwise, you
will get an off-by-one error in the nearest symbol look-up.
It is documented in "ELF for the ARM Architecture" [1]:
In addition to the normal rules for symbol values the following rules
shall also apply to symbols of type STT_FUNC:
* If the symbol addresses an Arm instruction, its value is the
address of the instruction (in a relocatable object, the offset
of the instruction from the start of the section containing it).
* If the symbol addresses a Thumb instruction, its value is the
address of the instruction with bit zero set (in a relocatable
object, the section offset with bit zero set).
* For the purposes of relocation the value used shall be the address
of the instruction (st_value & ~1).
[1]: https://github.com/ARM-software/abi-aa/blob/main/aaelf32/aaelf32.rst
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
2023-06-01 12:09:59 +00:00
|
|
|
if (addr >= sym_addr)
|
|
|
|
distance = addr - sym_addr;
|
2023-06-01 12:09:58 +00:00
|
|
|
else if (allow_negative)
|
modpost: detect section mismatch for R_ARM_THM_{MOVW_ABS_NC,MOVT_ABS}
When CONFIG_THUMB2_KERNEL is enabled, modpost fails to detect some
types of section mismatches.
[test code]
#include <linux/init.h>
int __initdata foo;
int get_foo(void) { return foo; }
It is apparently a bad reference, but modpost does not report anything.
The test code above produces the following relocations.
Relocation section '.rel.text' at offset 0x1e8 contains 2 entries:
Offset Info Type Sym.Value Sym. Name
00000000 0000052f R_ARM_THM_MOVW_AB 00000000 .LANCHOR0
00000004 00000530 R_ARM_THM_MOVT_AB 00000000 .LANCHOR0
Currently, R_ARM_THM_MOVW_ABS_NC and R_ARM_THM_MOVT_ABS are just skipped.
Add code to handle them. I checked arch/arm/kernel/module.c to learn
how the offset is encoded in the instruction.
One more thing to note for Thumb instructions - the st_value is an odd
value, so you need to mask the bit 0 to get the offset. Otherwise, you
will get an off-by-one error in the nearest symbol look-up.
It is documented in "ELF for the ARM Architecture" [1]:
In addition to the normal rules for symbol values the following rules
shall also apply to symbols of type STT_FUNC:
* If the symbol addresses an Arm instruction, its value is the
address of the instruction (in a relocatable object, the offset
of the instruction from the start of the section containing it).
* If the symbol addresses a Thumb instruction, its value is the
address of the instruction with bit zero set (in a relocatable
object, the section offset with bit zero set).
* For the purposes of relocation the value used shall be the address
of the instruction (st_value & ~1).
[1]: https://github.com/ARM-software/abi-aa/blob/main/aaelf32/aaelf32.rst
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
2023-06-01 12:09:59 +00:00
|
|
|
distance = sym_addr - addr;
|
2023-06-01 12:09:58 +00:00
|
|
|
else
|
2007-02-20 21:58:16 +00:00
|
|
|
continue;
|
2023-06-01 12:09:58 +00:00
|
|
|
|
|
|
|
if (distance <= min_distance) {
|
|
|
|
min_distance = distance;
|
2022-05-23 16:46:26 +00:00
|
|
|
near = sym;
|
2006-02-17 21:42:02 +00:00
|
|
|
}
|
2023-06-01 12:09:58 +00:00
|
|
|
|
|
|
|
if (min_distance == 0)
|
|
|
|
break;
|
2006-02-17 21:42:02 +00:00
|
|
|
}
|
2008-01-22 20:44:32 +00:00
|
|
|
return near;
|
2006-02-17 21:42:02 +00:00
|
|
|
}
|
|
|
|
|
2023-05-14 15:27:28 +00:00
|
|
|
static Elf_Sym *find_fromsym(struct elf_info *elf, Elf_Addr addr,
|
|
|
|
unsigned int secndx)
|
2008-01-24 20:12:37 +00:00
|
|
|
{
|
2023-06-01 12:09:58 +00:00
|
|
|
return find_nearest_sym(elf, addr, secndx, false, ~0);
|
2008-01-24 20:12:37 +00:00
|
|
|
}
|
|
|
|
|
2023-06-01 12:09:58 +00:00
|
|
|
static Elf_Sym *find_tosym(struct elf_info *elf, Elf_Addr addr, Elf_Sym *sym)
|
2015-04-13 11:13:34 +00:00
|
|
|
{
|
2023-06-01 12:09:58 +00:00
|
|
|
/* If the supplied symbol has a valid name, return it */
|
|
|
|
if (is_valid_name(elf, sym))
|
|
|
|
return sym;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Strive to find a better symbol name, but the resulting name may not
|
|
|
|
* match the symbol referenced in the original code.
|
|
|
|
*/
|
|
|
|
return find_nearest_sym(elf, addr, get_secindex(elf, sym), true, 20);
|
2015-04-13 11:13:34 +00:00
|
|
|
}
|
|
|
|
|
2023-05-14 15:27:24 +00:00
|
|
|
static bool is_executable_section(struct elf_info *elf, unsigned int secndx)
|
2008-01-24 20:12:37 +00:00
|
|
|
{
|
2023-06-08 08:23:40 +00:00
|
|
|
if (secndx >= elf->num_sections)
|
2023-05-14 15:27:24 +00:00
|
|
|
return false;
|
2008-02-02 17:57:18 +00:00
|
|
|
|
2023-05-14 15:27:24 +00:00
|
|
|
return (elf->sechdrs[secndx].sh_flags & SHF_EXECINSTR) != 0;
|
2008-01-23 20:13:50 +00:00
|
|
|
}
|
|
|
|
|
2015-04-13 11:13:17 +00:00
|
|
|
static void default_mismatch_handler(const char *modname, struct elf_info *elf,
|
|
|
|
const struct sectioncheck* const mismatch,
|
2023-05-21 16:04:12 +00:00
|
|
|
Elf_Sym *tsym,
|
|
|
|
unsigned int fsecndx, const char *fromsec, Elf_Addr faddr,
|
|
|
|
const char *tosec, Elf_Addr taddr)
|
2008-01-23 20:13:50 +00:00
|
|
|
{
|
2015-04-13 11:13:17 +00:00
|
|
|
Elf_Sym *from;
|
|
|
|
const char *tosym;
|
|
|
|
const char *fromsym;
|
2008-01-23 20:13:50 +00:00
|
|
|
|
2023-05-21 16:04:12 +00:00
|
|
|
from = find_fromsym(elf, faddr, fsecndx);
|
2015-04-13 11:13:17 +00:00
|
|
|
fromsym = sym_name(elf, from);
|
|
|
|
|
2023-05-21 16:04:12 +00:00
|
|
|
tsym = find_tosym(elf, taddr, tsym);
|
2023-05-21 16:04:11 +00:00
|
|
|
tosym = sym_name(elf, tsym);
|
2015-04-13 11:13:45 +00:00
|
|
|
|
2015-04-13 11:13:17 +00:00
|
|
|
/* check whitelist - we may ignore it */
|
2023-05-21 16:04:09 +00:00
|
|
|
if (!secref_whitelist(fromsec, fromsym, tosec, tosym))
|
2023-05-14 15:27:23 +00:00
|
|
|
return;
|
|
|
|
|
2008-02-02 17:57:18 +00:00
|
|
|
sec_mismatch_count++;
|
|
|
|
|
2023-06-11 15:50:59 +00:00
|
|
|
warn("%s: section mismatch in reference: %s+0x%x (section: %s) -> %s (section: %s)\n",
|
|
|
|
modname, fromsym, (unsigned int)(faddr - from->st_value), fromsec, tosym, tosec);
|
2023-05-14 15:27:25 +00:00
|
|
|
|
2023-06-11 15:50:58 +00:00
|
|
|
if (mismatch->mismatch == EXTABLE_TO_NON_TEXT) {
|
2023-05-14 15:27:25 +00:00
|
|
|
if (match(tosec, mismatch->bad_tosec))
|
|
|
|
fatal("The relocation at %s+0x%lx references\n"
|
|
|
|
"section \"%s\" which is black-listed.\n"
|
|
|
|
"Something is seriously wrong and should be fixed.\n"
|
|
|
|
"You might get more information about where this is\n"
|
|
|
|
"coming from by using scripts/check_extable.sh %s\n",
|
2023-05-21 16:04:12 +00:00
|
|
|
fromsec, (long)faddr, tosec, modname);
|
2023-05-21 16:04:11 +00:00
|
|
|
else if (is_executable_section(elf, get_secindex(elf, tsym)))
|
2023-05-14 15:27:25 +00:00
|
|
|
warn("The relocation at %s+0x%lx references\n"
|
|
|
|
"section \"%s\" which is not in the list of\n"
|
|
|
|
"authorized sections. If you're adding a new section\n"
|
|
|
|
"and/or if this reference is valid, add \"%s\" to the\n"
|
|
|
|
"list of authorized sections to jump to on fault.\n"
|
|
|
|
"This can be achieved by adding \"%s\" to\n"
|
|
|
|
"OTHER_TEXT_SECTIONS in scripts/mod/modpost.c.\n",
|
2023-05-21 16:04:12 +00:00
|
|
|
fromsec, (long)faddr, tosec, tosec, tosec);
|
2023-05-14 15:27:25 +00:00
|
|
|
else
|
|
|
|
error("%s+0x%lx references non-executable section '%s'\n",
|
2023-05-21 16:04:12 +00:00
|
|
|
fromsec, (long)faddr, tosec);
|
2015-04-13 11:13:17 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
kbuild: generate KSYMTAB entries by modpost
Commit 7b4537199a4a ("kbuild: link symbol CRCs at final link, removing
CONFIG_MODULE_REL_CRCS") made modpost output CRCs in the same way
whether the EXPORT_SYMBOL() is placed in *.c or *.S.
For further cleanups, this commit applies a similar approach to the
entire data structure of EXPORT_SYMBOL().
The EXPORT_SYMBOL() compilation is split into two stages.
When a source file is compiled, EXPORT_SYMBOL() will be converted into
a dummy symbol in the .export_symbol section.
For example,
EXPORT_SYMBOL(foo);
EXPORT_SYMBOL_NS_GPL(bar, BAR_NAMESPACE);
will be encoded into the following assembly code:
.section ".export_symbol","a"
__export_symbol_foo:
.asciz "" /* license */
.asciz "" /* name space */
.balign 8
.quad foo /* symbol reference */
.previous
.section ".export_symbol","a"
__export_symbol_bar:
.asciz "GPL" /* license */
.asciz "BAR_NAMESPACE" /* name space */
.balign 8
.quad bar /* symbol reference */
.previous
They are mere markers to tell modpost the name, license, and namespace
of the symbols. They will be dropped from the final vmlinux and modules
because the *(.export_symbol) will go into /DISCARD/ in the linker script.
Then, modpost extracts all the information about EXPORT_SYMBOL() from the
.export_symbol section, and generates the final C code:
KSYMTAB_FUNC(foo, "", "");
KSYMTAB_FUNC(bar, "_gpl", "BAR_NAMESPACE");
KSYMTAB_FUNC() (or KSYMTAB_DATA() if it is data) is expanded to struct
kernel_symbol that will be linked to the vmlinux or a module.
With this change, EXPORT_SYMBOL() works in the same way for *.c and *.S
files, providing the following benefits.
[1] Deprecate EXPORT_DATA_SYMBOL()
In the old days, EXPORT_SYMBOL() was only available in C files. To export
a symbol in *.S, EXPORT_SYMBOL() was placed in a separate *.c file.
arch/arm/kernel/armksyms.c is one example written in the classic manner.
Commit 22823ab419d8 ("EXPORT_SYMBOL() for asm") removed this limitation.
Since then, EXPORT_SYMBOL() can be placed close to the symbol definition
in *.S files. It was a nice improvement.
However, as that commit mentioned, you need to use EXPORT_DATA_SYMBOL()
for data objects on some architectures.
In the new approach, modpost checks symbol's type (STT_FUNC or not),
and outputs KSYMTAB_FUNC() or KSYMTAB_DATA() accordingly.
There are only two users of EXPORT_DATA_SYMBOL:
EXPORT_DATA_SYMBOL_GPL(empty_zero_page) (arch/ia64/kernel/head.S)
EXPORT_DATA_SYMBOL(ia64_ivt) (arch/ia64/kernel/ivt.S)
They are transformed as follows and output into .vmlinux.export.c
KSYMTAB_DATA(empty_zero_page, "_gpl", "");
KSYMTAB_DATA(ia64_ivt, "", "");
The other EXPORT_SYMBOL users in ia64 assembly are output as
KSYMTAB_FUNC().
EXPORT_DATA_SYMBOL() is now deprecated.
[2] merge <linux/export.h> and <asm-generic/export.h>
There are two similar header implementations:
include/linux/export.h for .c files
include/asm-generic/export.h for .S files
Ideally, the functionality should be consistent between them, but they
tend to diverge.
Commit 8651ec01daed ("module: add support for symbol namespaces.") did
not support the namespace for *.S files.
This commit shifts the essential implementation part to C, which supports
EXPORT_SYMBOL_NS() for *.S files.
<asm/export.h> and <asm-generic/export.h> will remain as a wrapper of
<linux/export.h> for a while.
They will be removed after #include <asm/export.h> directives are all
replaced with #include <linux/export.h>.
[3] Implement CONFIG_TRIM_UNUSED_KSYMS in one-pass algorithm (by a later commit)
When CONFIG_TRIM_UNUSED_KSYMS is enabled, Kbuild recursively traverses
the directory tree to determine which EXPORT_SYMBOL to trim. If an
EXPORT_SYMBOL turns out to be unused by anyone, Kbuild begins the
second traverse, where some source files are recompiled with their
EXPORT_SYMBOL() tuned into a no-op.
We can do this better now; modpost can selectively emit KSYMTAB entries
that are really used by modules.
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
2023-06-11 15:50:52 +00:00
|
|
|
static void check_export_symbol(struct module *mod, struct elf_info *elf,
|
|
|
|
Elf_Addr faddr, const char *secname,
|
|
|
|
Elf_Sym *sym)
|
2015-04-13 11:22:53 +00:00
|
|
|
{
|
kbuild: generate KSYMTAB entries by modpost
Commit 7b4537199a4a ("kbuild: link symbol CRCs at final link, removing
CONFIG_MODULE_REL_CRCS") made modpost output CRCs in the same way
whether the EXPORT_SYMBOL() is placed in *.c or *.S.
For further cleanups, this commit applies a similar approach to the
entire data structure of EXPORT_SYMBOL().
The EXPORT_SYMBOL() compilation is split into two stages.
When a source file is compiled, EXPORT_SYMBOL() will be converted into
a dummy symbol in the .export_symbol section.
For example,
EXPORT_SYMBOL(foo);
EXPORT_SYMBOL_NS_GPL(bar, BAR_NAMESPACE);
will be encoded into the following assembly code:
.section ".export_symbol","a"
__export_symbol_foo:
.asciz "" /* license */
.asciz "" /* name space */
.balign 8
.quad foo /* symbol reference */
.previous
.section ".export_symbol","a"
__export_symbol_bar:
.asciz "GPL" /* license */
.asciz "BAR_NAMESPACE" /* name space */
.balign 8
.quad bar /* symbol reference */
.previous
They are mere markers to tell modpost the name, license, and namespace
of the symbols. They will be dropped from the final vmlinux and modules
because the *(.export_symbol) will go into /DISCARD/ in the linker script.
Then, modpost extracts all the information about EXPORT_SYMBOL() from the
.export_symbol section, and generates the final C code:
KSYMTAB_FUNC(foo, "", "");
KSYMTAB_FUNC(bar, "_gpl", "BAR_NAMESPACE");
KSYMTAB_FUNC() (or KSYMTAB_DATA() if it is data) is expanded to struct
kernel_symbol that will be linked to the vmlinux or a module.
With this change, EXPORT_SYMBOL() works in the same way for *.c and *.S
files, providing the following benefits.
[1] Deprecate EXPORT_DATA_SYMBOL()
In the old days, EXPORT_SYMBOL() was only available in C files. To export
a symbol in *.S, EXPORT_SYMBOL() was placed in a separate *.c file.
arch/arm/kernel/armksyms.c is one example written in the classic manner.
Commit 22823ab419d8 ("EXPORT_SYMBOL() for asm") removed this limitation.
Since then, EXPORT_SYMBOL() can be placed close to the symbol definition
in *.S files. It was a nice improvement.
However, as that commit mentioned, you need to use EXPORT_DATA_SYMBOL()
for data objects on some architectures.
In the new approach, modpost checks symbol's type (STT_FUNC or not),
and outputs KSYMTAB_FUNC() or KSYMTAB_DATA() accordingly.
There are only two users of EXPORT_DATA_SYMBOL:
EXPORT_DATA_SYMBOL_GPL(empty_zero_page) (arch/ia64/kernel/head.S)
EXPORT_DATA_SYMBOL(ia64_ivt) (arch/ia64/kernel/ivt.S)
They are transformed as follows and output into .vmlinux.export.c
KSYMTAB_DATA(empty_zero_page, "_gpl", "");
KSYMTAB_DATA(ia64_ivt, "", "");
The other EXPORT_SYMBOL users in ia64 assembly are output as
KSYMTAB_FUNC().
EXPORT_DATA_SYMBOL() is now deprecated.
[2] merge <linux/export.h> and <asm-generic/export.h>
There are two similar header implementations:
include/linux/export.h for .c files
include/asm-generic/export.h for .S files
Ideally, the functionality should be consistent between them, but they
tend to diverge.
Commit 8651ec01daed ("module: add support for symbol namespaces.") did
not support the namespace for *.S files.
This commit shifts the essential implementation part to C, which supports
EXPORT_SYMBOL_NS() for *.S files.
<asm/export.h> and <asm-generic/export.h> will remain as a wrapper of
<linux/export.h> for a while.
They will be removed after #include <asm/export.h> directives are all
replaced with #include <linux/export.h>.
[3] Implement CONFIG_TRIM_UNUSED_KSYMS in one-pass algorithm (by a later commit)
When CONFIG_TRIM_UNUSED_KSYMS is enabled, Kbuild recursively traverses
the directory tree to determine which EXPORT_SYMBOL to trim. If an
EXPORT_SYMBOL turns out to be unused by anyone, Kbuild begins the
second traverse, where some source files are recompiled with their
EXPORT_SYMBOL() tuned into a no-op.
We can do this better now; modpost can selectively emit KSYMTAB entries
that are really used by modules.
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
2023-06-11 15:50:52 +00:00
|
|
|
static const char *prefix = "__export_symbol_";
|
|
|
|
const char *label_name, *name, *data;
|
|
|
|
Elf_Sym *label;
|
|
|
|
struct symbol *s;
|
|
|
|
bool is_gpl;
|
2015-04-13 11:22:53 +00:00
|
|
|
|
kbuild: generate KSYMTAB entries by modpost
Commit 7b4537199a4a ("kbuild: link symbol CRCs at final link, removing
CONFIG_MODULE_REL_CRCS") made modpost output CRCs in the same way
whether the EXPORT_SYMBOL() is placed in *.c or *.S.
For further cleanups, this commit applies a similar approach to the
entire data structure of EXPORT_SYMBOL().
The EXPORT_SYMBOL() compilation is split into two stages.
When a source file is compiled, EXPORT_SYMBOL() will be converted into
a dummy symbol in the .export_symbol section.
For example,
EXPORT_SYMBOL(foo);
EXPORT_SYMBOL_NS_GPL(bar, BAR_NAMESPACE);
will be encoded into the following assembly code:
.section ".export_symbol","a"
__export_symbol_foo:
.asciz "" /* license */
.asciz "" /* name space */
.balign 8
.quad foo /* symbol reference */
.previous
.section ".export_symbol","a"
__export_symbol_bar:
.asciz "GPL" /* license */
.asciz "BAR_NAMESPACE" /* name space */
.balign 8
.quad bar /* symbol reference */
.previous
They are mere markers to tell modpost the name, license, and namespace
of the symbols. They will be dropped from the final vmlinux and modules
because the *(.export_symbol) will go into /DISCARD/ in the linker script.
Then, modpost extracts all the information about EXPORT_SYMBOL() from the
.export_symbol section, and generates the final C code:
KSYMTAB_FUNC(foo, "", "");
KSYMTAB_FUNC(bar, "_gpl", "BAR_NAMESPACE");
KSYMTAB_FUNC() (or KSYMTAB_DATA() if it is data) is expanded to struct
kernel_symbol that will be linked to the vmlinux or a module.
With this change, EXPORT_SYMBOL() works in the same way for *.c and *.S
files, providing the following benefits.
[1] Deprecate EXPORT_DATA_SYMBOL()
In the old days, EXPORT_SYMBOL() was only available in C files. To export
a symbol in *.S, EXPORT_SYMBOL() was placed in a separate *.c file.
arch/arm/kernel/armksyms.c is one example written in the classic manner.
Commit 22823ab419d8 ("EXPORT_SYMBOL() for asm") removed this limitation.
Since then, EXPORT_SYMBOL() can be placed close to the symbol definition
in *.S files. It was a nice improvement.
However, as that commit mentioned, you need to use EXPORT_DATA_SYMBOL()
for data objects on some architectures.
In the new approach, modpost checks symbol's type (STT_FUNC or not),
and outputs KSYMTAB_FUNC() or KSYMTAB_DATA() accordingly.
There are only two users of EXPORT_DATA_SYMBOL:
EXPORT_DATA_SYMBOL_GPL(empty_zero_page) (arch/ia64/kernel/head.S)
EXPORT_DATA_SYMBOL(ia64_ivt) (arch/ia64/kernel/ivt.S)
They are transformed as follows and output into .vmlinux.export.c
KSYMTAB_DATA(empty_zero_page, "_gpl", "");
KSYMTAB_DATA(ia64_ivt, "", "");
The other EXPORT_SYMBOL users in ia64 assembly are output as
KSYMTAB_FUNC().
EXPORT_DATA_SYMBOL() is now deprecated.
[2] merge <linux/export.h> and <asm-generic/export.h>
There are two similar header implementations:
include/linux/export.h for .c files
include/asm-generic/export.h for .S files
Ideally, the functionality should be consistent between them, but they
tend to diverge.
Commit 8651ec01daed ("module: add support for symbol namespaces.") did
not support the namespace for *.S files.
This commit shifts the essential implementation part to C, which supports
EXPORT_SYMBOL_NS() for *.S files.
<asm/export.h> and <asm-generic/export.h> will remain as a wrapper of
<linux/export.h> for a while.
They will be removed after #include <asm/export.h> directives are all
replaced with #include <linux/export.h>.
[3] Implement CONFIG_TRIM_UNUSED_KSYMS in one-pass algorithm (by a later commit)
When CONFIG_TRIM_UNUSED_KSYMS is enabled, Kbuild recursively traverses
the directory tree to determine which EXPORT_SYMBOL to trim. If an
EXPORT_SYMBOL turns out to be unused by anyone, Kbuild begins the
second traverse, where some source files are recompiled with their
EXPORT_SYMBOL() tuned into a no-op.
We can do this better now; modpost can selectively emit KSYMTAB entries
that are really used by modules.
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
2023-06-11 15:50:52 +00:00
|
|
|
label = find_fromsym(elf, faddr, elf->export_symbol_secndx);
|
|
|
|
label_name = sym_name(elf, label);
|
2015-04-13 11:22:53 +00:00
|
|
|
|
kbuild: generate KSYMTAB entries by modpost
Commit 7b4537199a4a ("kbuild: link symbol CRCs at final link, removing
CONFIG_MODULE_REL_CRCS") made modpost output CRCs in the same way
whether the EXPORT_SYMBOL() is placed in *.c or *.S.
For further cleanups, this commit applies a similar approach to the
entire data structure of EXPORT_SYMBOL().
The EXPORT_SYMBOL() compilation is split into two stages.
When a source file is compiled, EXPORT_SYMBOL() will be converted into
a dummy symbol in the .export_symbol section.
For example,
EXPORT_SYMBOL(foo);
EXPORT_SYMBOL_NS_GPL(bar, BAR_NAMESPACE);
will be encoded into the following assembly code:
.section ".export_symbol","a"
__export_symbol_foo:
.asciz "" /* license */
.asciz "" /* name space */
.balign 8
.quad foo /* symbol reference */
.previous
.section ".export_symbol","a"
__export_symbol_bar:
.asciz "GPL" /* license */
.asciz "BAR_NAMESPACE" /* name space */
.balign 8
.quad bar /* symbol reference */
.previous
They are mere markers to tell modpost the name, license, and namespace
of the symbols. They will be dropped from the final vmlinux and modules
because the *(.export_symbol) will go into /DISCARD/ in the linker script.
Then, modpost extracts all the information about EXPORT_SYMBOL() from the
.export_symbol section, and generates the final C code:
KSYMTAB_FUNC(foo, "", "");
KSYMTAB_FUNC(bar, "_gpl", "BAR_NAMESPACE");
KSYMTAB_FUNC() (or KSYMTAB_DATA() if it is data) is expanded to struct
kernel_symbol that will be linked to the vmlinux or a module.
With this change, EXPORT_SYMBOL() works in the same way for *.c and *.S
files, providing the following benefits.
[1] Deprecate EXPORT_DATA_SYMBOL()
In the old days, EXPORT_SYMBOL() was only available in C files. To export
a symbol in *.S, EXPORT_SYMBOL() was placed in a separate *.c file.
arch/arm/kernel/armksyms.c is one example written in the classic manner.
Commit 22823ab419d8 ("EXPORT_SYMBOL() for asm") removed this limitation.
Since then, EXPORT_SYMBOL() can be placed close to the symbol definition
in *.S files. It was a nice improvement.
However, as that commit mentioned, you need to use EXPORT_DATA_SYMBOL()
for data objects on some architectures.
In the new approach, modpost checks symbol's type (STT_FUNC or not),
and outputs KSYMTAB_FUNC() or KSYMTAB_DATA() accordingly.
There are only two users of EXPORT_DATA_SYMBOL:
EXPORT_DATA_SYMBOL_GPL(empty_zero_page) (arch/ia64/kernel/head.S)
EXPORT_DATA_SYMBOL(ia64_ivt) (arch/ia64/kernel/ivt.S)
They are transformed as follows and output into .vmlinux.export.c
KSYMTAB_DATA(empty_zero_page, "_gpl", "");
KSYMTAB_DATA(ia64_ivt, "", "");
The other EXPORT_SYMBOL users in ia64 assembly are output as
KSYMTAB_FUNC().
EXPORT_DATA_SYMBOL() is now deprecated.
[2] merge <linux/export.h> and <asm-generic/export.h>
There are two similar header implementations:
include/linux/export.h for .c files
include/asm-generic/export.h for .S files
Ideally, the functionality should be consistent between them, but they
tend to diverge.
Commit 8651ec01daed ("module: add support for symbol namespaces.") did
not support the namespace for *.S files.
This commit shifts the essential implementation part to C, which supports
EXPORT_SYMBOL_NS() for *.S files.
<asm/export.h> and <asm-generic/export.h> will remain as a wrapper of
<linux/export.h> for a while.
They will be removed after #include <asm/export.h> directives are all
replaced with #include <linux/export.h>.
[3] Implement CONFIG_TRIM_UNUSED_KSYMS in one-pass algorithm (by a later commit)
When CONFIG_TRIM_UNUSED_KSYMS is enabled, Kbuild recursively traverses
the directory tree to determine which EXPORT_SYMBOL to trim. If an
EXPORT_SYMBOL turns out to be unused by anyone, Kbuild begins the
second traverse, where some source files are recompiled with their
EXPORT_SYMBOL() tuned into a no-op.
We can do this better now; modpost can selectively emit KSYMTAB entries
that are really used by modules.
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
2023-06-11 15:50:52 +00:00
|
|
|
if (!strstarts(label_name, prefix)) {
|
|
|
|
error("%s: .export_symbol section contains strange symbol '%s'\n",
|
|
|
|
mod->name, label_name);
|
|
|
|
return;
|
|
|
|
}
|
2015-04-16 03:35:36 +00:00
|
|
|
|
2023-06-11 15:50:54 +00:00
|
|
|
if (ELF_ST_BIND(sym->st_info) != STB_GLOBAL &&
|
|
|
|
ELF_ST_BIND(sym->st_info) != STB_WEAK) {
|
|
|
|
error("%s: local symbol '%s' was exported\n", mod->name,
|
|
|
|
label_name + strlen(prefix));
|
|
|
|
return;
|
|
|
|
}
|
2015-04-13 11:22:53 +00:00
|
|
|
|
kbuild: generate KSYMTAB entries by modpost
Commit 7b4537199a4a ("kbuild: link symbol CRCs at final link, removing
CONFIG_MODULE_REL_CRCS") made modpost output CRCs in the same way
whether the EXPORT_SYMBOL() is placed in *.c or *.S.
For further cleanups, this commit applies a similar approach to the
entire data structure of EXPORT_SYMBOL().
The EXPORT_SYMBOL() compilation is split into two stages.
When a source file is compiled, EXPORT_SYMBOL() will be converted into
a dummy symbol in the .export_symbol section.
For example,
EXPORT_SYMBOL(foo);
EXPORT_SYMBOL_NS_GPL(bar, BAR_NAMESPACE);
will be encoded into the following assembly code:
.section ".export_symbol","a"
__export_symbol_foo:
.asciz "" /* license */
.asciz "" /* name space */
.balign 8
.quad foo /* symbol reference */
.previous
.section ".export_symbol","a"
__export_symbol_bar:
.asciz "GPL" /* license */
.asciz "BAR_NAMESPACE" /* name space */
.balign 8
.quad bar /* symbol reference */
.previous
They are mere markers to tell modpost the name, license, and namespace
of the symbols. They will be dropped from the final vmlinux and modules
because the *(.export_symbol) will go into /DISCARD/ in the linker script.
Then, modpost extracts all the information about EXPORT_SYMBOL() from the
.export_symbol section, and generates the final C code:
KSYMTAB_FUNC(foo, "", "");
KSYMTAB_FUNC(bar, "_gpl", "BAR_NAMESPACE");
KSYMTAB_FUNC() (or KSYMTAB_DATA() if it is data) is expanded to struct
kernel_symbol that will be linked to the vmlinux or a module.
With this change, EXPORT_SYMBOL() works in the same way for *.c and *.S
files, providing the following benefits.
[1] Deprecate EXPORT_DATA_SYMBOL()
In the old days, EXPORT_SYMBOL() was only available in C files. To export
a symbol in *.S, EXPORT_SYMBOL() was placed in a separate *.c file.
arch/arm/kernel/armksyms.c is one example written in the classic manner.
Commit 22823ab419d8 ("EXPORT_SYMBOL() for asm") removed this limitation.
Since then, EXPORT_SYMBOL() can be placed close to the symbol definition
in *.S files. It was a nice improvement.
However, as that commit mentioned, you need to use EXPORT_DATA_SYMBOL()
for data objects on some architectures.
In the new approach, modpost checks symbol's type (STT_FUNC or not),
and outputs KSYMTAB_FUNC() or KSYMTAB_DATA() accordingly.
There are only two users of EXPORT_DATA_SYMBOL:
EXPORT_DATA_SYMBOL_GPL(empty_zero_page) (arch/ia64/kernel/head.S)
EXPORT_DATA_SYMBOL(ia64_ivt) (arch/ia64/kernel/ivt.S)
They are transformed as follows and output into .vmlinux.export.c
KSYMTAB_DATA(empty_zero_page, "_gpl", "");
KSYMTAB_DATA(ia64_ivt, "", "");
The other EXPORT_SYMBOL users in ia64 assembly are output as
KSYMTAB_FUNC().
EXPORT_DATA_SYMBOL() is now deprecated.
[2] merge <linux/export.h> and <asm-generic/export.h>
There are two similar header implementations:
include/linux/export.h for .c files
include/asm-generic/export.h for .S files
Ideally, the functionality should be consistent between them, but they
tend to diverge.
Commit 8651ec01daed ("module: add support for symbol namespaces.") did
not support the namespace for *.S files.
This commit shifts the essential implementation part to C, which supports
EXPORT_SYMBOL_NS() for *.S files.
<asm/export.h> and <asm-generic/export.h> will remain as a wrapper of
<linux/export.h> for a while.
They will be removed after #include <asm/export.h> directives are all
replaced with #include <linux/export.h>.
[3] Implement CONFIG_TRIM_UNUSED_KSYMS in one-pass algorithm (by a later commit)
When CONFIG_TRIM_UNUSED_KSYMS is enabled, Kbuild recursively traverses
the directory tree to determine which EXPORT_SYMBOL to trim. If an
EXPORT_SYMBOL turns out to be unused by anyone, Kbuild begins the
second traverse, where some source files are recompiled with their
EXPORT_SYMBOL() tuned into a no-op.
We can do this better now; modpost can selectively emit KSYMTAB entries
that are really used by modules.
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
2023-06-11 15:50:52 +00:00
|
|
|
name = sym_name(elf, sym);
|
|
|
|
if (strcmp(label_name + strlen(prefix), name)) {
|
|
|
|
error("%s: .export_symbol section references '%s', but it does not seem to be an export symbol\n",
|
|
|
|
mod->name, name);
|
|
|
|
return;
|
|
|
|
}
|
2015-04-13 11:22:53 +00:00
|
|
|
|
kbuild: generate KSYMTAB entries by modpost
Commit 7b4537199a4a ("kbuild: link symbol CRCs at final link, removing
CONFIG_MODULE_REL_CRCS") made modpost output CRCs in the same way
whether the EXPORT_SYMBOL() is placed in *.c or *.S.
For further cleanups, this commit applies a similar approach to the
entire data structure of EXPORT_SYMBOL().
The EXPORT_SYMBOL() compilation is split into two stages.
When a source file is compiled, EXPORT_SYMBOL() will be converted into
a dummy symbol in the .export_symbol section.
For example,
EXPORT_SYMBOL(foo);
EXPORT_SYMBOL_NS_GPL(bar, BAR_NAMESPACE);
will be encoded into the following assembly code:
.section ".export_symbol","a"
__export_symbol_foo:
.asciz "" /* license */
.asciz "" /* name space */
.balign 8
.quad foo /* symbol reference */
.previous
.section ".export_symbol","a"
__export_symbol_bar:
.asciz "GPL" /* license */
.asciz "BAR_NAMESPACE" /* name space */
.balign 8
.quad bar /* symbol reference */
.previous
They are mere markers to tell modpost the name, license, and namespace
of the symbols. They will be dropped from the final vmlinux and modules
because the *(.export_symbol) will go into /DISCARD/ in the linker script.
Then, modpost extracts all the information about EXPORT_SYMBOL() from the
.export_symbol section, and generates the final C code:
KSYMTAB_FUNC(foo, "", "");
KSYMTAB_FUNC(bar, "_gpl", "BAR_NAMESPACE");
KSYMTAB_FUNC() (or KSYMTAB_DATA() if it is data) is expanded to struct
kernel_symbol that will be linked to the vmlinux or a module.
With this change, EXPORT_SYMBOL() works in the same way for *.c and *.S
files, providing the following benefits.
[1] Deprecate EXPORT_DATA_SYMBOL()
In the old days, EXPORT_SYMBOL() was only available in C files. To export
a symbol in *.S, EXPORT_SYMBOL() was placed in a separate *.c file.
arch/arm/kernel/armksyms.c is one example written in the classic manner.
Commit 22823ab419d8 ("EXPORT_SYMBOL() for asm") removed this limitation.
Since then, EXPORT_SYMBOL() can be placed close to the symbol definition
in *.S files. It was a nice improvement.
However, as that commit mentioned, you need to use EXPORT_DATA_SYMBOL()
for data objects on some architectures.
In the new approach, modpost checks symbol's type (STT_FUNC or not),
and outputs KSYMTAB_FUNC() or KSYMTAB_DATA() accordingly.
There are only two users of EXPORT_DATA_SYMBOL:
EXPORT_DATA_SYMBOL_GPL(empty_zero_page) (arch/ia64/kernel/head.S)
EXPORT_DATA_SYMBOL(ia64_ivt) (arch/ia64/kernel/ivt.S)
They are transformed as follows and output into .vmlinux.export.c
KSYMTAB_DATA(empty_zero_page, "_gpl", "");
KSYMTAB_DATA(ia64_ivt, "", "");
The other EXPORT_SYMBOL users in ia64 assembly are output as
KSYMTAB_FUNC().
EXPORT_DATA_SYMBOL() is now deprecated.
[2] merge <linux/export.h> and <asm-generic/export.h>
There are two similar header implementations:
include/linux/export.h for .c files
include/asm-generic/export.h for .S files
Ideally, the functionality should be consistent between them, but they
tend to diverge.
Commit 8651ec01daed ("module: add support for symbol namespaces.") did
not support the namespace for *.S files.
This commit shifts the essential implementation part to C, which supports
EXPORT_SYMBOL_NS() for *.S files.
<asm/export.h> and <asm-generic/export.h> will remain as a wrapper of
<linux/export.h> for a while.
They will be removed after #include <asm/export.h> directives are all
replaced with #include <linux/export.h>.
[3] Implement CONFIG_TRIM_UNUSED_KSYMS in one-pass algorithm (by a later commit)
When CONFIG_TRIM_UNUSED_KSYMS is enabled, Kbuild recursively traverses
the directory tree to determine which EXPORT_SYMBOL to trim. If an
EXPORT_SYMBOL turns out to be unused by anyone, Kbuild begins the
second traverse, where some source files are recompiled with their
EXPORT_SYMBOL() tuned into a no-op.
We can do this better now; modpost can selectively emit KSYMTAB entries
that are really used by modules.
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
2023-06-11 15:50:52 +00:00
|
|
|
data = sym_get_data(elf, label); /* license */
|
|
|
|
if (!strcmp(data, "GPL")) {
|
|
|
|
is_gpl = true;
|
|
|
|
} else if (!strcmp(data, "")) {
|
|
|
|
is_gpl = false;
|
|
|
|
} else {
|
|
|
|
error("%s: unknown license '%s' was specified for '%s'\n",
|
|
|
|
mod->name, data, name);
|
|
|
|
return;
|
2015-04-13 11:22:53 +00:00
|
|
|
}
|
kbuild: generate KSYMTAB entries by modpost
Commit 7b4537199a4a ("kbuild: link symbol CRCs at final link, removing
CONFIG_MODULE_REL_CRCS") made modpost output CRCs in the same way
whether the EXPORT_SYMBOL() is placed in *.c or *.S.
For further cleanups, this commit applies a similar approach to the
entire data structure of EXPORT_SYMBOL().
The EXPORT_SYMBOL() compilation is split into two stages.
When a source file is compiled, EXPORT_SYMBOL() will be converted into
a dummy symbol in the .export_symbol section.
For example,
EXPORT_SYMBOL(foo);
EXPORT_SYMBOL_NS_GPL(bar, BAR_NAMESPACE);
will be encoded into the following assembly code:
.section ".export_symbol","a"
__export_symbol_foo:
.asciz "" /* license */
.asciz "" /* name space */
.balign 8
.quad foo /* symbol reference */
.previous
.section ".export_symbol","a"
__export_symbol_bar:
.asciz "GPL" /* license */
.asciz "BAR_NAMESPACE" /* name space */
.balign 8
.quad bar /* symbol reference */
.previous
They are mere markers to tell modpost the name, license, and namespace
of the symbols. They will be dropped from the final vmlinux and modules
because the *(.export_symbol) will go into /DISCARD/ in the linker script.
Then, modpost extracts all the information about EXPORT_SYMBOL() from the
.export_symbol section, and generates the final C code:
KSYMTAB_FUNC(foo, "", "");
KSYMTAB_FUNC(bar, "_gpl", "BAR_NAMESPACE");
KSYMTAB_FUNC() (or KSYMTAB_DATA() if it is data) is expanded to struct
kernel_symbol that will be linked to the vmlinux or a module.
With this change, EXPORT_SYMBOL() works in the same way for *.c and *.S
files, providing the following benefits.
[1] Deprecate EXPORT_DATA_SYMBOL()
In the old days, EXPORT_SYMBOL() was only available in C files. To export
a symbol in *.S, EXPORT_SYMBOL() was placed in a separate *.c file.
arch/arm/kernel/armksyms.c is one example written in the classic manner.
Commit 22823ab419d8 ("EXPORT_SYMBOL() for asm") removed this limitation.
Since then, EXPORT_SYMBOL() can be placed close to the symbol definition
in *.S files. It was a nice improvement.
However, as that commit mentioned, you need to use EXPORT_DATA_SYMBOL()
for data objects on some architectures.
In the new approach, modpost checks symbol's type (STT_FUNC or not),
and outputs KSYMTAB_FUNC() or KSYMTAB_DATA() accordingly.
There are only two users of EXPORT_DATA_SYMBOL:
EXPORT_DATA_SYMBOL_GPL(empty_zero_page) (arch/ia64/kernel/head.S)
EXPORT_DATA_SYMBOL(ia64_ivt) (arch/ia64/kernel/ivt.S)
They are transformed as follows and output into .vmlinux.export.c
KSYMTAB_DATA(empty_zero_page, "_gpl", "");
KSYMTAB_DATA(ia64_ivt, "", "");
The other EXPORT_SYMBOL users in ia64 assembly are output as
KSYMTAB_FUNC().
EXPORT_DATA_SYMBOL() is now deprecated.
[2] merge <linux/export.h> and <asm-generic/export.h>
There are two similar header implementations:
include/linux/export.h for .c files
include/asm-generic/export.h for .S files
Ideally, the functionality should be consistent between them, but they
tend to diverge.
Commit 8651ec01daed ("module: add support for symbol namespaces.") did
not support the namespace for *.S files.
This commit shifts the essential implementation part to C, which supports
EXPORT_SYMBOL_NS() for *.S files.
<asm/export.h> and <asm-generic/export.h> will remain as a wrapper of
<linux/export.h> for a while.
They will be removed after #include <asm/export.h> directives are all
replaced with #include <linux/export.h>.
[3] Implement CONFIG_TRIM_UNUSED_KSYMS in one-pass algorithm (by a later commit)
When CONFIG_TRIM_UNUSED_KSYMS is enabled, Kbuild recursively traverses
the directory tree to determine which EXPORT_SYMBOL to trim. If an
EXPORT_SYMBOL turns out to be unused by anyone, Kbuild begins the
second traverse, where some source files are recompiled with their
EXPORT_SYMBOL() tuned into a no-op.
We can do this better now; modpost can selectively emit KSYMTAB entries
that are really used by modules.
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
2023-06-11 15:50:52 +00:00
|
|
|
|
|
|
|
data += strlen(data) + 1; /* namespace */
|
2023-06-11 15:50:55 +00:00
|
|
|
s = sym_add_exported(name, mod, is_gpl, data);
|
kbuild: generate KSYMTAB entries by modpost
Commit 7b4537199a4a ("kbuild: link symbol CRCs at final link, removing
CONFIG_MODULE_REL_CRCS") made modpost output CRCs in the same way
whether the EXPORT_SYMBOL() is placed in *.c or *.S.
For further cleanups, this commit applies a similar approach to the
entire data structure of EXPORT_SYMBOL().
The EXPORT_SYMBOL() compilation is split into two stages.
When a source file is compiled, EXPORT_SYMBOL() will be converted into
a dummy symbol in the .export_symbol section.
For example,
EXPORT_SYMBOL(foo);
EXPORT_SYMBOL_NS_GPL(bar, BAR_NAMESPACE);
will be encoded into the following assembly code:
.section ".export_symbol","a"
__export_symbol_foo:
.asciz "" /* license */
.asciz "" /* name space */
.balign 8
.quad foo /* symbol reference */
.previous
.section ".export_symbol","a"
__export_symbol_bar:
.asciz "GPL" /* license */
.asciz "BAR_NAMESPACE" /* name space */
.balign 8
.quad bar /* symbol reference */
.previous
They are mere markers to tell modpost the name, license, and namespace
of the symbols. They will be dropped from the final vmlinux and modules
because the *(.export_symbol) will go into /DISCARD/ in the linker script.
Then, modpost extracts all the information about EXPORT_SYMBOL() from the
.export_symbol section, and generates the final C code:
KSYMTAB_FUNC(foo, "", "");
KSYMTAB_FUNC(bar, "_gpl", "BAR_NAMESPACE");
KSYMTAB_FUNC() (or KSYMTAB_DATA() if it is data) is expanded to struct
kernel_symbol that will be linked to the vmlinux or a module.
With this change, EXPORT_SYMBOL() works in the same way for *.c and *.S
files, providing the following benefits.
[1] Deprecate EXPORT_DATA_SYMBOL()
In the old days, EXPORT_SYMBOL() was only available in C files. To export
a symbol in *.S, EXPORT_SYMBOL() was placed in a separate *.c file.
arch/arm/kernel/armksyms.c is one example written in the classic manner.
Commit 22823ab419d8 ("EXPORT_SYMBOL() for asm") removed this limitation.
Since then, EXPORT_SYMBOL() can be placed close to the symbol definition
in *.S files. It was a nice improvement.
However, as that commit mentioned, you need to use EXPORT_DATA_SYMBOL()
for data objects on some architectures.
In the new approach, modpost checks symbol's type (STT_FUNC or not),
and outputs KSYMTAB_FUNC() or KSYMTAB_DATA() accordingly.
There are only two users of EXPORT_DATA_SYMBOL:
EXPORT_DATA_SYMBOL_GPL(empty_zero_page) (arch/ia64/kernel/head.S)
EXPORT_DATA_SYMBOL(ia64_ivt) (arch/ia64/kernel/ivt.S)
They are transformed as follows and output into .vmlinux.export.c
KSYMTAB_DATA(empty_zero_page, "_gpl", "");
KSYMTAB_DATA(ia64_ivt, "", "");
The other EXPORT_SYMBOL users in ia64 assembly are output as
KSYMTAB_FUNC().
EXPORT_DATA_SYMBOL() is now deprecated.
[2] merge <linux/export.h> and <asm-generic/export.h>
There are two similar header implementations:
include/linux/export.h for .c files
include/asm-generic/export.h for .S files
Ideally, the functionality should be consistent between them, but they
tend to diverge.
Commit 8651ec01daed ("module: add support for symbol namespaces.") did
not support the namespace for *.S files.
This commit shifts the essential implementation part to C, which supports
EXPORT_SYMBOL_NS() for *.S files.
<asm/export.h> and <asm-generic/export.h> will remain as a wrapper of
<linux/export.h> for a while.
They will be removed after #include <asm/export.h> directives are all
replaced with #include <linux/export.h>.
[3] Implement CONFIG_TRIM_UNUSED_KSYMS in one-pass algorithm (by a later commit)
When CONFIG_TRIM_UNUSED_KSYMS is enabled, Kbuild recursively traverses
the directory tree to determine which EXPORT_SYMBOL to trim. If an
EXPORT_SYMBOL turns out to be unused by anyone, Kbuild begins the
second traverse, where some source files are recompiled with their
EXPORT_SYMBOL() tuned into a no-op.
We can do this better now; modpost can selectively emit KSYMTAB entries
that are really used by modules.
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
2023-06-11 15:50:52 +00:00
|
|
|
|
|
|
|
/*
|
|
|
|
* We need to be aware whether we are exporting a function or
|
|
|
|
* a data on some architectures.
|
|
|
|
*/
|
|
|
|
s->is_func = (ELF_ST_TYPE(sym->st_info) == STT_FUNC);
|
|
|
|
|
|
|
|
if (match(secname, PATTERNS(INIT_SECTIONS)))
|
|
|
|
warn("%s: %s: EXPORT_SYMBOL used for init symbol. Remove __init or EXPORT_SYMBOL.\n",
|
|
|
|
mod->name, name);
|
|
|
|
else if (match(secname, PATTERNS(EXIT_SECTIONS)))
|
|
|
|
warn("%s: %s: EXPORT_SYMBOL used for exit symbol. Remove __exit or EXPORT_SYMBOL.\n",
|
|
|
|
mod->name, name);
|
2015-04-13 11:22:53 +00:00
|
|
|
}
|
|
|
|
|
2023-06-11 15:50:51 +00:00
|
|
|
static void check_section_mismatch(struct module *mod, struct elf_info *elf,
|
2023-05-21 16:04:12 +00:00
|
|
|
Elf_Sym *sym,
|
|
|
|
unsigned int fsecndx, const char *fromsec,
|
|
|
|
Elf_Addr faddr, Elf_Addr taddr)
|
2015-04-13 11:13:17 +00:00
|
|
|
{
|
2018-01-16 13:21:29 +00:00
|
|
|
const char *tosec = sec_name(elf, get_secindex(elf, sym));
|
kbuild: generate KSYMTAB entries by modpost
Commit 7b4537199a4a ("kbuild: link symbol CRCs at final link, removing
CONFIG_MODULE_REL_CRCS") made modpost output CRCs in the same way
whether the EXPORT_SYMBOL() is placed in *.c or *.S.
For further cleanups, this commit applies a similar approach to the
entire data structure of EXPORT_SYMBOL().
The EXPORT_SYMBOL() compilation is split into two stages.
When a source file is compiled, EXPORT_SYMBOL() will be converted into
a dummy symbol in the .export_symbol section.
For example,
EXPORT_SYMBOL(foo);
EXPORT_SYMBOL_NS_GPL(bar, BAR_NAMESPACE);
will be encoded into the following assembly code:
.section ".export_symbol","a"
__export_symbol_foo:
.asciz "" /* license */
.asciz "" /* name space */
.balign 8
.quad foo /* symbol reference */
.previous
.section ".export_symbol","a"
__export_symbol_bar:
.asciz "GPL" /* license */
.asciz "BAR_NAMESPACE" /* name space */
.balign 8
.quad bar /* symbol reference */
.previous
They are mere markers to tell modpost the name, license, and namespace
of the symbols. They will be dropped from the final vmlinux and modules
because the *(.export_symbol) will go into /DISCARD/ in the linker script.
Then, modpost extracts all the information about EXPORT_SYMBOL() from the
.export_symbol section, and generates the final C code:
KSYMTAB_FUNC(foo, "", "");
KSYMTAB_FUNC(bar, "_gpl", "BAR_NAMESPACE");
KSYMTAB_FUNC() (or KSYMTAB_DATA() if it is data) is expanded to struct
kernel_symbol that will be linked to the vmlinux or a module.
With this change, EXPORT_SYMBOL() works in the same way for *.c and *.S
files, providing the following benefits.
[1] Deprecate EXPORT_DATA_SYMBOL()
In the old days, EXPORT_SYMBOL() was only available in C files. To export
a symbol in *.S, EXPORT_SYMBOL() was placed in a separate *.c file.
arch/arm/kernel/armksyms.c is one example written in the classic manner.
Commit 22823ab419d8 ("EXPORT_SYMBOL() for asm") removed this limitation.
Since then, EXPORT_SYMBOL() can be placed close to the symbol definition
in *.S files. It was a nice improvement.
However, as that commit mentioned, you need to use EXPORT_DATA_SYMBOL()
for data objects on some architectures.
In the new approach, modpost checks symbol's type (STT_FUNC or not),
and outputs KSYMTAB_FUNC() or KSYMTAB_DATA() accordingly.
There are only two users of EXPORT_DATA_SYMBOL:
EXPORT_DATA_SYMBOL_GPL(empty_zero_page) (arch/ia64/kernel/head.S)
EXPORT_DATA_SYMBOL(ia64_ivt) (arch/ia64/kernel/ivt.S)
They are transformed as follows and output into .vmlinux.export.c
KSYMTAB_DATA(empty_zero_page, "_gpl", "");
KSYMTAB_DATA(ia64_ivt, "", "");
The other EXPORT_SYMBOL users in ia64 assembly are output as
KSYMTAB_FUNC().
EXPORT_DATA_SYMBOL() is now deprecated.
[2] merge <linux/export.h> and <asm-generic/export.h>
There are two similar header implementations:
include/linux/export.h for .c files
include/asm-generic/export.h for .S files
Ideally, the functionality should be consistent between them, but they
tend to diverge.
Commit 8651ec01daed ("module: add support for symbol namespaces.") did
not support the namespace for *.S files.
This commit shifts the essential implementation part to C, which supports
EXPORT_SYMBOL_NS() for *.S files.
<asm/export.h> and <asm-generic/export.h> will remain as a wrapper of
<linux/export.h> for a while.
They will be removed after #include <asm/export.h> directives are all
replaced with #include <linux/export.h>.
[3] Implement CONFIG_TRIM_UNUSED_KSYMS in one-pass algorithm (by a later commit)
When CONFIG_TRIM_UNUSED_KSYMS is enabled, Kbuild recursively traverses
the directory tree to determine which EXPORT_SYMBOL to trim. If an
EXPORT_SYMBOL turns out to be unused by anyone, Kbuild begins the
second traverse, where some source files are recompiled with their
EXPORT_SYMBOL() tuned into a no-op.
We can do this better now; modpost can selectively emit KSYMTAB entries
that are really used by modules.
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
2023-06-11 15:50:52 +00:00
|
|
|
const struct sectioncheck *mismatch;
|
2015-04-13 11:13:17 +00:00
|
|
|
|
2023-07-16 10:15:54 +00:00
|
|
|
if (module_enabled && elf->export_symbol_secndx == fsecndx) {
|
kbuild: generate KSYMTAB entries by modpost
Commit 7b4537199a4a ("kbuild: link symbol CRCs at final link, removing
CONFIG_MODULE_REL_CRCS") made modpost output CRCs in the same way
whether the EXPORT_SYMBOL() is placed in *.c or *.S.
For further cleanups, this commit applies a similar approach to the
entire data structure of EXPORT_SYMBOL().
The EXPORT_SYMBOL() compilation is split into two stages.
When a source file is compiled, EXPORT_SYMBOL() will be converted into
a dummy symbol in the .export_symbol section.
For example,
EXPORT_SYMBOL(foo);
EXPORT_SYMBOL_NS_GPL(bar, BAR_NAMESPACE);
will be encoded into the following assembly code:
.section ".export_symbol","a"
__export_symbol_foo:
.asciz "" /* license */
.asciz "" /* name space */
.balign 8
.quad foo /* symbol reference */
.previous
.section ".export_symbol","a"
__export_symbol_bar:
.asciz "GPL" /* license */
.asciz "BAR_NAMESPACE" /* name space */
.balign 8
.quad bar /* symbol reference */
.previous
They are mere markers to tell modpost the name, license, and namespace
of the symbols. They will be dropped from the final vmlinux and modules
because the *(.export_symbol) will go into /DISCARD/ in the linker script.
Then, modpost extracts all the information about EXPORT_SYMBOL() from the
.export_symbol section, and generates the final C code:
KSYMTAB_FUNC(foo, "", "");
KSYMTAB_FUNC(bar, "_gpl", "BAR_NAMESPACE");
KSYMTAB_FUNC() (or KSYMTAB_DATA() if it is data) is expanded to struct
kernel_symbol that will be linked to the vmlinux or a module.
With this change, EXPORT_SYMBOL() works in the same way for *.c and *.S
files, providing the following benefits.
[1] Deprecate EXPORT_DATA_SYMBOL()
In the old days, EXPORT_SYMBOL() was only available in C files. To export
a symbol in *.S, EXPORT_SYMBOL() was placed in a separate *.c file.
arch/arm/kernel/armksyms.c is one example written in the classic manner.
Commit 22823ab419d8 ("EXPORT_SYMBOL() for asm") removed this limitation.
Since then, EXPORT_SYMBOL() can be placed close to the symbol definition
in *.S files. It was a nice improvement.
However, as that commit mentioned, you need to use EXPORT_DATA_SYMBOL()
for data objects on some architectures.
In the new approach, modpost checks symbol's type (STT_FUNC or not),
and outputs KSYMTAB_FUNC() or KSYMTAB_DATA() accordingly.
There are only two users of EXPORT_DATA_SYMBOL:
EXPORT_DATA_SYMBOL_GPL(empty_zero_page) (arch/ia64/kernel/head.S)
EXPORT_DATA_SYMBOL(ia64_ivt) (arch/ia64/kernel/ivt.S)
They are transformed as follows and output into .vmlinux.export.c
KSYMTAB_DATA(empty_zero_page, "_gpl", "");
KSYMTAB_DATA(ia64_ivt, "", "");
The other EXPORT_SYMBOL users in ia64 assembly are output as
KSYMTAB_FUNC().
EXPORT_DATA_SYMBOL() is now deprecated.
[2] merge <linux/export.h> and <asm-generic/export.h>
There are two similar header implementations:
include/linux/export.h for .c files
include/asm-generic/export.h for .S files
Ideally, the functionality should be consistent between them, but they
tend to diverge.
Commit 8651ec01daed ("module: add support for symbol namespaces.") did
not support the namespace for *.S files.
This commit shifts the essential implementation part to C, which supports
EXPORT_SYMBOL_NS() for *.S files.
<asm/export.h> and <asm-generic/export.h> will remain as a wrapper of
<linux/export.h> for a while.
They will be removed after #include <asm/export.h> directives are all
replaced with #include <linux/export.h>.
[3] Implement CONFIG_TRIM_UNUSED_KSYMS in one-pass algorithm (by a later commit)
When CONFIG_TRIM_UNUSED_KSYMS is enabled, Kbuild recursively traverses
the directory tree to determine which EXPORT_SYMBOL to trim. If an
EXPORT_SYMBOL turns out to be unused by anyone, Kbuild begins the
second traverse, where some source files are recompiled with their
EXPORT_SYMBOL() tuned into a no-op.
We can do this better now; modpost can selectively emit KSYMTAB entries
that are really used by modules.
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
2023-06-11 15:50:52 +00:00
|
|
|
check_export_symbol(mod, elf, faddr, tosec, sym);
|
|
|
|
return;
|
2006-02-17 21:42:02 +00:00
|
|
|
}
|
|
|
|
|
kbuild: generate KSYMTAB entries by modpost
Commit 7b4537199a4a ("kbuild: link symbol CRCs at final link, removing
CONFIG_MODULE_REL_CRCS") made modpost output CRCs in the same way
whether the EXPORT_SYMBOL() is placed in *.c or *.S.
For further cleanups, this commit applies a similar approach to the
entire data structure of EXPORT_SYMBOL().
The EXPORT_SYMBOL() compilation is split into two stages.
When a source file is compiled, EXPORT_SYMBOL() will be converted into
a dummy symbol in the .export_symbol section.
For example,
EXPORT_SYMBOL(foo);
EXPORT_SYMBOL_NS_GPL(bar, BAR_NAMESPACE);
will be encoded into the following assembly code:
.section ".export_symbol","a"
__export_symbol_foo:
.asciz "" /* license */
.asciz "" /* name space */
.balign 8
.quad foo /* symbol reference */
.previous
.section ".export_symbol","a"
__export_symbol_bar:
.asciz "GPL" /* license */
.asciz "BAR_NAMESPACE" /* name space */
.balign 8
.quad bar /* symbol reference */
.previous
They are mere markers to tell modpost the name, license, and namespace
of the symbols. They will be dropped from the final vmlinux and modules
because the *(.export_symbol) will go into /DISCARD/ in the linker script.
Then, modpost extracts all the information about EXPORT_SYMBOL() from the
.export_symbol section, and generates the final C code:
KSYMTAB_FUNC(foo, "", "");
KSYMTAB_FUNC(bar, "_gpl", "BAR_NAMESPACE");
KSYMTAB_FUNC() (or KSYMTAB_DATA() if it is data) is expanded to struct
kernel_symbol that will be linked to the vmlinux or a module.
With this change, EXPORT_SYMBOL() works in the same way for *.c and *.S
files, providing the following benefits.
[1] Deprecate EXPORT_DATA_SYMBOL()
In the old days, EXPORT_SYMBOL() was only available in C files. To export
a symbol in *.S, EXPORT_SYMBOL() was placed in a separate *.c file.
arch/arm/kernel/armksyms.c is one example written in the classic manner.
Commit 22823ab419d8 ("EXPORT_SYMBOL() for asm") removed this limitation.
Since then, EXPORT_SYMBOL() can be placed close to the symbol definition
in *.S files. It was a nice improvement.
However, as that commit mentioned, you need to use EXPORT_DATA_SYMBOL()
for data objects on some architectures.
In the new approach, modpost checks symbol's type (STT_FUNC or not),
and outputs KSYMTAB_FUNC() or KSYMTAB_DATA() accordingly.
There are only two users of EXPORT_DATA_SYMBOL:
EXPORT_DATA_SYMBOL_GPL(empty_zero_page) (arch/ia64/kernel/head.S)
EXPORT_DATA_SYMBOL(ia64_ivt) (arch/ia64/kernel/ivt.S)
They are transformed as follows and output into .vmlinux.export.c
KSYMTAB_DATA(empty_zero_page, "_gpl", "");
KSYMTAB_DATA(ia64_ivt, "", "");
The other EXPORT_SYMBOL users in ia64 assembly are output as
KSYMTAB_FUNC().
EXPORT_DATA_SYMBOL() is now deprecated.
[2] merge <linux/export.h> and <asm-generic/export.h>
There are two similar header implementations:
include/linux/export.h for .c files
include/asm-generic/export.h for .S files
Ideally, the functionality should be consistent between them, but they
tend to diverge.
Commit 8651ec01daed ("module: add support for symbol namespaces.") did
not support the namespace for *.S files.
This commit shifts the essential implementation part to C, which supports
EXPORT_SYMBOL_NS() for *.S files.
<asm/export.h> and <asm-generic/export.h> will remain as a wrapper of
<linux/export.h> for a while.
They will be removed after #include <asm/export.h> directives are all
replaced with #include <linux/export.h>.
[3] Implement CONFIG_TRIM_UNUSED_KSYMS in one-pass algorithm (by a later commit)
When CONFIG_TRIM_UNUSED_KSYMS is enabled, Kbuild recursively traverses
the directory tree to determine which EXPORT_SYMBOL to trim. If an
EXPORT_SYMBOL turns out to be unused by anyone, Kbuild begins the
second traverse, where some source files are recompiled with their
EXPORT_SYMBOL() tuned into a no-op.
We can do this better now; modpost can selectively emit KSYMTAB entries
that are really used by modules.
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
2023-06-11 15:50:52 +00:00
|
|
|
mismatch = section_mismatch(fromsec, tosec);
|
2023-05-14 15:27:25 +00:00
|
|
|
if (!mismatch)
|
|
|
|
return;
|
|
|
|
|
2023-06-11 15:50:51 +00:00
|
|
|
default_mismatch_handler(mod->name, elf, mismatch, sym,
|
2023-05-21 16:04:12 +00:00
|
|
|
fsecndx, fromsec, faddr,
|
|
|
|
tosec, taddr);
|
2007-05-22 09:27:39 +00:00
|
|
|
}
|
|
|
|
|
2023-06-20 12:05:19 +00:00
|
|
|
static int addend_386_rel(uint32_t *location, Elf_Rela *r)
|
2007-05-22 09:27:39 +00:00
|
|
|
{
|
|
|
|
unsigned int r_typ = ELF_R_TYPE(r->r_info);
|
|
|
|
|
|
|
|
switch (r_typ) {
|
|
|
|
case R_386_32:
|
|
|
|
r->r_addend = TO_NATIVE(*location);
|
|
|
|
break;
|
|
|
|
case R_386_PC32:
|
|
|
|
r->r_addend = TO_NATIVE(*location) + 4;
|
|
|
|
break;
|
2023-06-20 12:05:21 +00:00
|
|
|
default:
|
|
|
|
r->r_addend = (Elf_Addr)(-1);
|
2007-05-22 09:27:39 +00:00
|
|
|
}
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2012-02-14 20:58:56 +00:00
|
|
|
#ifndef R_ARM_CALL
|
|
|
|
#define R_ARM_CALL 28
|
|
|
|
#endif
|
|
|
|
#ifndef R_ARM_JUMP24
|
|
|
|
#define R_ARM_JUMP24 29
|
|
|
|
#endif
|
|
|
|
|
2014-02-14 21:41:18 +00:00
|
|
|
#ifndef R_ARM_THM_CALL
|
|
|
|
#define R_ARM_THM_CALL 10
|
|
|
|
#endif
|
|
|
|
#ifndef R_ARM_THM_JUMP24
|
|
|
|
#define R_ARM_THM_JUMP24 30
|
|
|
|
#endif
|
2023-06-27 16:32:05 +00:00
|
|
|
|
|
|
|
#ifndef R_ARM_MOVW_ABS_NC
|
|
|
|
#define R_ARM_MOVW_ABS_NC 43
|
|
|
|
#endif
|
|
|
|
|
|
|
|
#ifndef R_ARM_MOVT_ABS
|
|
|
|
#define R_ARM_MOVT_ABS 44
|
|
|
|
#endif
|
|
|
|
|
|
|
|
#ifndef R_ARM_THM_MOVW_ABS_NC
|
|
|
|
#define R_ARM_THM_MOVW_ABS_NC 47
|
|
|
|
#endif
|
|
|
|
|
|
|
|
#ifndef R_ARM_THM_MOVT_ABS
|
|
|
|
#define R_ARM_THM_MOVT_ABS 48
|
|
|
|
#endif
|
|
|
|
|
2014-02-14 21:41:18 +00:00
|
|
|
#ifndef R_ARM_THM_JUMP19
|
|
|
|
#define R_ARM_THM_JUMP19 51
|
|
|
|
#endif
|
|
|
|
|
modpost: fix section mismatch message for R_ARM_{PC24,CALL,JUMP24}
addend_arm_rel() processes R_ARM_PC24, R_ARM_CALL, R_ARM_JUMP24 in a
wrong way.
Here, test code.
[test code for R_ARM_JUMP24]
.section .init.text,"ax"
bar:
bx lr
.section .text,"ax"
.globl foo
foo:
b bar
[test code for R_ARM_CALL]
.section .init.text,"ax"
bar:
bx lr
.section .text,"ax"
.globl foo
foo:
push {lr}
bl bar
pop {pc}
If you compile it with ARM multi_v7_defconfig, modpost will show the
symbol name, (unknown).
WARNING: modpost: vmlinux.o: section mismatch in reference: foo (section: .text) -> (unknown) (section: .init.text)
(You need to use GNU linker instead of LLD to reproduce it.)
Fix the code to make modpost show the correct symbol name.
I imported (with adjustment) sign_extend32() from include/linux/bitops.h.
The '+8' is the compensation for pc-relative instruction. It is
documented in "ELF for the Arm Architecture" [1].
"If the relocation is pc-relative then compensation for the PC bias
(the PC value is 8 bytes ahead of the executing instruction in Arm
state and 4 bytes in Thumb state) must be encoded in the relocation
by the object producer."
[1]: https://github.com/ARM-software/abi-aa/blob/main/aaelf32/aaelf32.rst
Fixes: 56a974fa2d59 ("kbuild: make better section mismatch reports on arm")
Fixes: 6e2e340b59d2 ("ARM: 7324/1: modpost: Fix section warnings for ARM for many compilers")
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
2023-06-01 12:09:56 +00:00
|
|
|
static int32_t sign_extend32(int32_t value, int index)
|
|
|
|
{
|
|
|
|
uint8_t shift = 31 - index;
|
|
|
|
|
|
|
|
return (int32_t)(value << shift) >> shift;
|
|
|
|
}
|
|
|
|
|
2023-06-20 12:05:20 +00:00
|
|
|
static int addend_arm_rel(void *loc, Elf_Sym *sym, Elf_Rela *r)
|
2007-07-16 20:39:35 +00:00
|
|
|
{
|
|
|
|
unsigned int r_typ = ELF_R_TYPE(r->r_info);
|
modpost: fix section_mismatch message for R_ARM_THM_{CALL,JUMP24,JUMP19}
addend_arm_rel() processes R_ARM_THM_CALL, R_ARM_THM_JUMP24,
R_ARM_THM_JUMP19 in a wrong way.
Here, test code.
[test code for R_ARM_THM_JUMP24]
.section .init.text,"ax"
bar:
bx lr
.section .text,"ax"
.globl foo
foo:
b bar
[test code for R_ARM_THM_CALL]
.section .init.text,"ax"
bar:
bx lr
.section .text,"ax"
.globl foo
foo:
push {lr}
bl bar
pop {pc}
If you compile it with CONFIG_THUMB2_KERNEL=y, modpost will show the
symbol name, (unknown).
WARNING: modpost: vmlinux.o: section mismatch in reference: foo (section: .text) -> (unknown) (section: .init.text)
(You need to use GNU linker instead of LLD to reproduce it.)
Fix the code to make modpost show the correct symbol name. I checked
arch/arm/kernel/module.c to learn the encoding of R_ARM_THM_CALL and
R_ARM_THM_JUMP24. The module does not support R_ARM_THM_JUMP19, but
I checked its encoding in ARM ARM.
The '+4' is the compensation for pc-relative instruction. It is
documented in "ELF for the Arm Architecture" [1].
"If the relocation is pc-relative then compensation for the PC bias
(the PC value is 8 bytes ahead of the executing instruction in Arm
state and 4 bytes in Thumb state) must be encoded in the relocation
by the object producer."
[1]: https://github.com/ARM-software/abi-aa/blob/main/aaelf32/aaelf32.rst
Fixes: c9698e5cd6ad ("ARM: 7964/1: Detect section mismatches in thumb relocations")
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
2023-06-01 12:10:00 +00:00
|
|
|
uint32_t inst, upper, lower, sign, j1, j2;
|
modpost: fix section mismatch message for R_ARM_{PC24,CALL,JUMP24}
addend_arm_rel() processes R_ARM_PC24, R_ARM_CALL, R_ARM_JUMP24 in a
wrong way.
Here, test code.
[test code for R_ARM_JUMP24]
.section .init.text,"ax"
bar:
bx lr
.section .text,"ax"
.globl foo
foo:
b bar
[test code for R_ARM_CALL]
.section .init.text,"ax"
bar:
bx lr
.section .text,"ax"
.globl foo
foo:
push {lr}
bl bar
pop {pc}
If you compile it with ARM multi_v7_defconfig, modpost will show the
symbol name, (unknown).
WARNING: modpost: vmlinux.o: section mismatch in reference: foo (section: .text) -> (unknown) (section: .init.text)
(You need to use GNU linker instead of LLD to reproduce it.)
Fix the code to make modpost show the correct symbol name.
I imported (with adjustment) sign_extend32() from include/linux/bitops.h.
The '+8' is the compensation for pc-relative instruction. It is
documented in "ELF for the Arm Architecture" [1].
"If the relocation is pc-relative then compensation for the PC bias
(the PC value is 8 bytes ahead of the executing instruction in Arm
state and 4 bytes in Thumb state) must be encoded in the relocation
by the object producer."
[1]: https://github.com/ARM-software/abi-aa/blob/main/aaelf32/aaelf32.rst
Fixes: 56a974fa2d59 ("kbuild: make better section mismatch reports on arm")
Fixes: 6e2e340b59d2 ("ARM: 7324/1: modpost: Fix section warnings for ARM for many compilers")
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
2023-06-01 12:09:56 +00:00
|
|
|
int32_t offset;
|
2007-07-16 20:39:35 +00:00
|
|
|
|
|
|
|
switch (r_typ) {
|
|
|
|
case R_ARM_ABS32:
|
2023-06-01 12:10:01 +00:00
|
|
|
case R_ARM_REL32:
|
modpost: fix section mismatch message for R_ARM_ABS32
addend_arm_rel() processes R_ARM_ABS32 in a wrong way.
Here, test code.
[test code 1]
#include <linux/init.h>
int __initdata foo;
int get_foo(void) { return foo; }
If you compile it with ARM versatile_defconfig, modpost will show the
symbol name, (unknown).
WARNING: modpost: vmlinux.o: section mismatch in reference: get_foo (section: .text) -> (unknown) (section: .init.data)
(You need to use GNU linker instead of LLD to reproduce it.)
If you compile it for other architectures, modpost will show the correct
symbol name.
WARNING: modpost: vmlinux.o: section mismatch in reference: get_foo (section: .text) -> foo (section: .init.data)
For R_ARM_ABS32, addend_arm_rel() sets r->r_addend to a wrong value.
I just mimicked the code in arch/arm/kernel/module.c.
However, there is more difficulty for ARM.
Here, test code.
[test code 2]
#include <linux/init.h>
int __initdata foo;
int get_foo(void) { return foo; }
int __initdata bar;
int get_bar(void) { return bar; }
With this commit applied, modpost will show the following messages
for ARM versatile_defconfig:
WARNING: modpost: vmlinux.o: section mismatch in reference: get_foo (section: .text) -> foo (section: .init.data)
WARNING: modpost: vmlinux.o: section mismatch in reference: get_bar (section: .text) -> foo (section: .init.data)
The reference from 'get_bar' to 'foo' seems wrong.
I have no solution for this because it is true in assembly level.
In the following output, relocation at 0x1c is no longer associated
with 'bar'. The two relocation entries point to the same symbol, and
the offset to 'bar' is encoded in the instruction 'r0, [r3, #4]'.
Disassembly of section .text:
00000000 <get_foo>:
0: e59f3004 ldr r3, [pc, #4] @ c <get_foo+0xc>
4: e5930000 ldr r0, [r3]
8: e12fff1e bx lr
c: 00000000 .word 0x00000000
00000010 <get_bar>:
10: e59f3004 ldr r3, [pc, #4] @ 1c <get_bar+0xc>
14: e5930004 ldr r0, [r3, #4]
18: e12fff1e bx lr
1c: 00000000 .word 0x00000000
Relocation section '.rel.text' at offset 0x244 contains 2 entries:
Offset Info Type Sym.Value Sym. Name
0000000c 00000c02 R_ARM_ABS32 00000000 .init.data
0000001c 00000c02 R_ARM_ABS32 00000000 .init.data
When find_elf_symbol() gets into a situation where relsym->st_name is
zero, there is no guarantee to get the symbol name as written in C.
I am keeping the current logic because it is useful in many architectures,
but the symbol name is not always correct depending on the optimization.
I left some comments in find_tosym().
Fixes: 56a974fa2d59 ("kbuild: make better section mismatch reports on arm")
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
2023-06-01 12:09:55 +00:00
|
|
|
inst = TO_NATIVE(*(uint32_t *)loc);
|
|
|
|
r->r_addend = inst + sym->st_value;
|
2007-07-16 20:39:35 +00:00
|
|
|
break;
|
2023-06-01 12:09:57 +00:00
|
|
|
case R_ARM_MOVW_ABS_NC:
|
|
|
|
case R_ARM_MOVT_ABS:
|
|
|
|
inst = TO_NATIVE(*(uint32_t *)loc);
|
|
|
|
offset = sign_extend32(((inst & 0xf0000) >> 4) | (inst & 0xfff),
|
|
|
|
15);
|
|
|
|
r->r_addend = offset + sym->st_value;
|
2007-07-16 20:39:35 +00:00
|
|
|
break;
|
|
|
|
case R_ARM_PC24:
|
2012-02-14 20:58:56 +00:00
|
|
|
case R_ARM_CALL:
|
|
|
|
case R_ARM_JUMP24:
|
modpost: fix section mismatch message for R_ARM_{PC24,CALL,JUMP24}
addend_arm_rel() processes R_ARM_PC24, R_ARM_CALL, R_ARM_JUMP24 in a
wrong way.
Here, test code.
[test code for R_ARM_JUMP24]
.section .init.text,"ax"
bar:
bx lr
.section .text,"ax"
.globl foo
foo:
b bar
[test code for R_ARM_CALL]
.section .init.text,"ax"
bar:
bx lr
.section .text,"ax"
.globl foo
foo:
push {lr}
bl bar
pop {pc}
If you compile it with ARM multi_v7_defconfig, modpost will show the
symbol name, (unknown).
WARNING: modpost: vmlinux.o: section mismatch in reference: foo (section: .text) -> (unknown) (section: .init.text)
(You need to use GNU linker instead of LLD to reproduce it.)
Fix the code to make modpost show the correct symbol name.
I imported (with adjustment) sign_extend32() from include/linux/bitops.h.
The '+8' is the compensation for pc-relative instruction. It is
documented in "ELF for the Arm Architecture" [1].
"If the relocation is pc-relative then compensation for the PC bias
(the PC value is 8 bytes ahead of the executing instruction in Arm
state and 4 bytes in Thumb state) must be encoded in the relocation
by the object producer."
[1]: https://github.com/ARM-software/abi-aa/blob/main/aaelf32/aaelf32.rst
Fixes: 56a974fa2d59 ("kbuild: make better section mismatch reports on arm")
Fixes: 6e2e340b59d2 ("ARM: 7324/1: modpost: Fix section warnings for ARM for many compilers")
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
2023-06-01 12:09:56 +00:00
|
|
|
inst = TO_NATIVE(*(uint32_t *)loc);
|
|
|
|
offset = sign_extend32((inst & 0x00ffffff) << 2, 25);
|
|
|
|
r->r_addend = offset + sym->st_value + 8;
|
|
|
|
break;
|
modpost: detect section mismatch for R_ARM_THM_{MOVW_ABS_NC,MOVT_ABS}
When CONFIG_THUMB2_KERNEL is enabled, modpost fails to detect some
types of section mismatches.
[test code]
#include <linux/init.h>
int __initdata foo;
int get_foo(void) { return foo; }
It is apparently a bad reference, but modpost does not report anything.
The test code above produces the following relocations.
Relocation section '.rel.text' at offset 0x1e8 contains 2 entries:
Offset Info Type Sym.Value Sym. Name
00000000 0000052f R_ARM_THM_MOVW_AB 00000000 .LANCHOR0
00000004 00000530 R_ARM_THM_MOVT_AB 00000000 .LANCHOR0
Currently, R_ARM_THM_MOVW_ABS_NC and R_ARM_THM_MOVT_ABS are just skipped.
Add code to handle them. I checked arch/arm/kernel/module.c to learn
how the offset is encoded in the instruction.
One more thing to note for Thumb instructions - the st_value is an odd
value, so you need to mask the bit 0 to get the offset. Otherwise, you
will get an off-by-one error in the nearest symbol look-up.
It is documented in "ELF for the ARM Architecture" [1]:
In addition to the normal rules for symbol values the following rules
shall also apply to symbols of type STT_FUNC:
* If the symbol addresses an Arm instruction, its value is the
address of the instruction (in a relocatable object, the offset
of the instruction from the start of the section containing it).
* If the symbol addresses a Thumb instruction, its value is the
address of the instruction with bit zero set (in a relocatable
object, the section offset with bit zero set).
* For the purposes of relocation the value used shall be the address
of the instruction (st_value & ~1).
[1]: https://github.com/ARM-software/abi-aa/blob/main/aaelf32/aaelf32.rst
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
2023-06-01 12:09:59 +00:00
|
|
|
case R_ARM_THM_MOVW_ABS_NC:
|
|
|
|
case R_ARM_THM_MOVT_ABS:
|
|
|
|
upper = TO_NATIVE(*(uint16_t *)loc);
|
|
|
|
lower = TO_NATIVE(*((uint16_t *)loc + 1));
|
|
|
|
offset = sign_extend32(((upper & 0x000f) << 12) |
|
|
|
|
((upper & 0x0400) << 1) |
|
|
|
|
((lower & 0x7000) >> 4) |
|
|
|
|
(lower & 0x00ff),
|
|
|
|
15);
|
|
|
|
r->r_addend = offset + sym->st_value;
|
|
|
|
break;
|
modpost: fix section_mismatch message for R_ARM_THM_{CALL,JUMP24,JUMP19}
addend_arm_rel() processes R_ARM_THM_CALL, R_ARM_THM_JUMP24,
R_ARM_THM_JUMP19 in a wrong way.
Here, test code.
[test code for R_ARM_THM_JUMP24]
.section .init.text,"ax"
bar:
bx lr
.section .text,"ax"
.globl foo
foo:
b bar
[test code for R_ARM_THM_CALL]
.section .init.text,"ax"
bar:
bx lr
.section .text,"ax"
.globl foo
foo:
push {lr}
bl bar
pop {pc}
If you compile it with CONFIG_THUMB2_KERNEL=y, modpost will show the
symbol name, (unknown).
WARNING: modpost: vmlinux.o: section mismatch in reference: foo (section: .text) -> (unknown) (section: .init.text)
(You need to use GNU linker instead of LLD to reproduce it.)
Fix the code to make modpost show the correct symbol name. I checked
arch/arm/kernel/module.c to learn the encoding of R_ARM_THM_CALL and
R_ARM_THM_JUMP24. The module does not support R_ARM_THM_JUMP19, but
I checked its encoding in ARM ARM.
The '+4' is the compensation for pc-relative instruction. It is
documented in "ELF for the Arm Architecture" [1].
"If the relocation is pc-relative then compensation for the PC bias
(the PC value is 8 bytes ahead of the executing instruction in Arm
state and 4 bytes in Thumb state) must be encoded in the relocation
by the object producer."
[1]: https://github.com/ARM-software/abi-aa/blob/main/aaelf32/aaelf32.rst
Fixes: c9698e5cd6ad ("ARM: 7964/1: Detect section mismatches in thumb relocations")
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
2023-06-01 12:10:00 +00:00
|
|
|
case R_ARM_THM_JUMP19:
|
|
|
|
/*
|
|
|
|
* Encoding T3:
|
|
|
|
* S = upper[10]
|
|
|
|
* imm6 = upper[5:0]
|
|
|
|
* J1 = lower[13]
|
|
|
|
* J2 = lower[11]
|
|
|
|
* imm11 = lower[10:0]
|
|
|
|
* imm32 = SignExtend(S:J2:J1:imm6:imm11:'0')
|
|
|
|
*/
|
|
|
|
upper = TO_NATIVE(*(uint16_t *)loc);
|
|
|
|
lower = TO_NATIVE(*((uint16_t *)loc + 1));
|
|
|
|
|
|
|
|
sign = (upper >> 10) & 1;
|
|
|
|
j1 = (lower >> 13) & 1;
|
|
|
|
j2 = (lower >> 11) & 1;
|
|
|
|
offset = sign_extend32((sign << 20) | (j2 << 19) | (j1 << 18) |
|
|
|
|
((upper & 0x03f) << 12) |
|
|
|
|
((lower & 0x07ff) << 1),
|
|
|
|
20);
|
|
|
|
r->r_addend = offset + sym->st_value + 4;
|
|
|
|
break;
|
2014-02-14 21:41:18 +00:00
|
|
|
case R_ARM_THM_CALL:
|
|
|
|
case R_ARM_THM_JUMP24:
|
modpost: fix section_mismatch message for R_ARM_THM_{CALL,JUMP24,JUMP19}
addend_arm_rel() processes R_ARM_THM_CALL, R_ARM_THM_JUMP24,
R_ARM_THM_JUMP19 in a wrong way.
Here, test code.
[test code for R_ARM_THM_JUMP24]
.section .init.text,"ax"
bar:
bx lr
.section .text,"ax"
.globl foo
foo:
b bar
[test code for R_ARM_THM_CALL]
.section .init.text,"ax"
bar:
bx lr
.section .text,"ax"
.globl foo
foo:
push {lr}
bl bar
pop {pc}
If you compile it with CONFIG_THUMB2_KERNEL=y, modpost will show the
symbol name, (unknown).
WARNING: modpost: vmlinux.o: section mismatch in reference: foo (section: .text) -> (unknown) (section: .init.text)
(You need to use GNU linker instead of LLD to reproduce it.)
Fix the code to make modpost show the correct symbol name. I checked
arch/arm/kernel/module.c to learn the encoding of R_ARM_THM_CALL and
R_ARM_THM_JUMP24. The module does not support R_ARM_THM_JUMP19, but
I checked its encoding in ARM ARM.
The '+4' is the compensation for pc-relative instruction. It is
documented in "ELF for the Arm Architecture" [1].
"If the relocation is pc-relative then compensation for the PC bias
(the PC value is 8 bytes ahead of the executing instruction in Arm
state and 4 bytes in Thumb state) must be encoded in the relocation
by the object producer."
[1]: https://github.com/ARM-software/abi-aa/blob/main/aaelf32/aaelf32.rst
Fixes: c9698e5cd6ad ("ARM: 7964/1: Detect section mismatches in thumb relocations")
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
2023-06-01 12:10:00 +00:00
|
|
|
/*
|
|
|
|
* Encoding T4:
|
|
|
|
* S = upper[10]
|
|
|
|
* imm10 = upper[9:0]
|
|
|
|
* J1 = lower[13]
|
|
|
|
* J2 = lower[11]
|
|
|
|
* imm11 = lower[10:0]
|
|
|
|
* I1 = NOT(J1 XOR S)
|
|
|
|
* I2 = NOT(J2 XOR S)
|
|
|
|
* imm32 = SignExtend(S:I1:I2:imm10:imm11:'0')
|
|
|
|
*/
|
|
|
|
upper = TO_NATIVE(*(uint16_t *)loc);
|
|
|
|
lower = TO_NATIVE(*((uint16_t *)loc + 1));
|
|
|
|
|
|
|
|
sign = (upper >> 10) & 1;
|
|
|
|
j1 = (lower >> 13) & 1;
|
|
|
|
j2 = (lower >> 11) & 1;
|
|
|
|
offset = sign_extend32((sign << 24) |
|
|
|
|
((~(j1 ^ sign) & 1) << 23) |
|
|
|
|
((~(j2 ^ sign) & 1) << 22) |
|
|
|
|
((upper & 0x03ff) << 12) |
|
|
|
|
((lower & 0x07ff) << 1),
|
|
|
|
24);
|
|
|
|
r->r_addend = offset + sym->st_value + 4;
|
2007-07-16 20:39:35 +00:00
|
|
|
break;
|
|
|
|
default:
|
2023-06-20 12:05:21 +00:00
|
|
|
r->r_addend = (Elf_Addr)(-1);
|
2007-07-16 20:39:35 +00:00
|
|
|
}
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2023-06-20 12:05:19 +00:00
|
|
|
static int addend_mips_rel(uint32_t *location, Elf_Rela *r)
|
2007-05-22 09:27:39 +00:00
|
|
|
{
|
|
|
|
unsigned int r_typ = ELF_R_TYPE(r->r_info);
|
2023-06-20 12:05:19 +00:00
|
|
|
uint32_t inst;
|
2007-05-22 09:27:39 +00:00
|
|
|
|
|
|
|
inst = TO_NATIVE(*location);
|
|
|
|
switch (r_typ) {
|
|
|
|
case R_MIPS_LO16:
|
|
|
|
r->r_addend = inst & 0xffff;
|
|
|
|
break;
|
|
|
|
case R_MIPS_26:
|
|
|
|
r->r_addend = (inst & 0x03ffffff) << 2;
|
|
|
|
break;
|
|
|
|
case R_MIPS_32:
|
|
|
|
r->r_addend = inst;
|
|
|
|
break;
|
2023-06-20 12:05:21 +00:00
|
|
|
default:
|
|
|
|
r->r_addend = (Elf_Addr)(-1);
|
2007-05-22 09:27:39 +00:00
|
|
|
}
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2021-11-18 11:22:51 +00:00
|
|
|
#ifndef EM_RISCV
|
|
|
|
#define EM_RISCV 243
|
|
|
|
#endif
|
|
|
|
|
|
|
|
#ifndef R_RISCV_SUB32
|
|
|
|
#define R_RISCV_SUB32 39
|
|
|
|
#endif
|
|
|
|
|
2022-12-10 14:39:48 +00:00
|
|
|
#ifndef EM_LOONGARCH
|
|
|
|
#define EM_LOONGARCH 258
|
|
|
|
#endif
|
|
|
|
|
|
|
|
#ifndef R_LARCH_SUB32
|
|
|
|
#define R_LARCH_SUB32 55
|
|
|
|
#endif
|
|
|
|
|
2023-06-11 15:50:51 +00:00
|
|
|
static void section_rela(struct module *mod, struct elf_info *elf,
|
2014-06-10 10:08:13 +00:00
|
|
|
Elf_Shdr *sechdr)
|
2008-01-18 20:49:29 +00:00
|
|
|
{
|
|
|
|
Elf_Rela *rela;
|
|
|
|
Elf_Rela r;
|
|
|
|
unsigned int r_sym;
|
2023-05-14 15:27:27 +00:00
|
|
|
unsigned int fsecndx = sechdr->sh_info;
|
|
|
|
const char *fromsec = sec_name(elf, fsecndx);
|
2008-01-23 18:54:27 +00:00
|
|
|
Elf_Rela *start = (void *)elf->hdr + sechdr->sh_offset;
|
2008-01-18 20:49:29 +00:00
|
|
|
Elf_Rela *stop = (void *)start + sechdr->sh_size;
|
|
|
|
|
|
|
|
/* if from section (name) is know good then skip it */
|
2009-04-23 20:49:33 +00:00
|
|
|
if (match(fromsec, section_white_list))
|
2008-01-18 20:49:29 +00:00
|
|
|
return;
|
2008-01-28 19:13:13 +00:00
|
|
|
|
2008-01-18 20:49:29 +00:00
|
|
|
for (rela = start; rela < stop; rela++) {
|
|
|
|
r.r_offset = TO_NATIVE(rela->r_offset);
|
|
|
|
#if KERNEL_ELFCLASS == ELFCLASS64
|
2008-01-23 18:54:27 +00:00
|
|
|
if (elf->hdr->e_machine == EM_MIPS) {
|
2008-01-18 20:49:29 +00:00
|
|
|
unsigned int r_typ;
|
|
|
|
r_sym = ELF64_MIPS_R_SYM(rela->r_info);
|
|
|
|
r_sym = TO_NATIVE(r_sym);
|
|
|
|
r_typ = ELF64_MIPS_R_TYPE(rela->r_info);
|
|
|
|
r.r_info = ELF64_R_INFO(r_sym, r_typ);
|
|
|
|
} else {
|
|
|
|
r.r_info = TO_NATIVE(rela->r_info);
|
|
|
|
r_sym = ELF_R_SYM(r.r_info);
|
|
|
|
}
|
|
|
|
#else
|
|
|
|
r.r_info = TO_NATIVE(rela->r_info);
|
|
|
|
r_sym = ELF_R_SYM(r.r_info);
|
|
|
|
#endif
|
|
|
|
r.r_addend = TO_NATIVE(rela->r_addend);
|
2021-11-18 11:22:51 +00:00
|
|
|
switch (elf->hdr->e_machine) {
|
|
|
|
case EM_RISCV:
|
|
|
|
if (!strcmp("__ex_table", fromsec) &&
|
|
|
|
ELF_R_TYPE(r.r_info) == R_RISCV_SUB32)
|
|
|
|
continue;
|
|
|
|
break;
|
2022-12-10 14:39:48 +00:00
|
|
|
case EM_LOONGARCH:
|
|
|
|
if (!strcmp("__ex_table", fromsec) &&
|
|
|
|
ELF_R_TYPE(r.r_info) == R_LARCH_SUB32)
|
|
|
|
continue;
|
|
|
|
break;
|
2021-11-18 11:22:51 +00:00
|
|
|
}
|
2023-05-21 16:04:13 +00:00
|
|
|
|
2023-06-11 15:50:51 +00:00
|
|
|
check_section_mismatch(mod, elf, elf->symtab_start + r_sym,
|
2023-05-21 16:04:12 +00:00
|
|
|
fsecndx, fromsec, r.r_offset, r.r_addend);
|
2008-01-18 20:49:29 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2023-06-11 15:50:51 +00:00
|
|
|
static void section_rel(struct module *mod, struct elf_info *elf,
|
2014-06-10 10:08:13 +00:00
|
|
|
Elf_Shdr *sechdr)
|
2008-01-18 20:49:29 +00:00
|
|
|
{
|
|
|
|
Elf_Rel *rel;
|
|
|
|
Elf_Rela r;
|
|
|
|
unsigned int r_sym;
|
2023-05-14 15:27:27 +00:00
|
|
|
unsigned int fsecndx = sechdr->sh_info;
|
|
|
|
const char *fromsec = sec_name(elf, fsecndx);
|
2008-01-23 18:54:27 +00:00
|
|
|
Elf_Rel *start = (void *)elf->hdr + sechdr->sh_offset;
|
2008-01-18 20:49:29 +00:00
|
|
|
Elf_Rel *stop = (void *)start + sechdr->sh_size;
|
|
|
|
|
|
|
|
/* if from section (name) is know good then skip it */
|
2009-04-23 20:49:33 +00:00
|
|
|
if (match(fromsec, section_white_list))
|
2008-01-18 20:49:29 +00:00
|
|
|
return;
|
|
|
|
|
|
|
|
for (rel = start; rel < stop; rel++) {
|
2023-06-20 12:05:20 +00:00
|
|
|
Elf_Sym *tsym;
|
2023-06-20 12:05:19 +00:00
|
|
|
void *loc;
|
|
|
|
|
2008-01-18 20:49:29 +00:00
|
|
|
r.r_offset = TO_NATIVE(rel->r_offset);
|
|
|
|
#if KERNEL_ELFCLASS == ELFCLASS64
|
2008-01-23 18:54:27 +00:00
|
|
|
if (elf->hdr->e_machine == EM_MIPS) {
|
2008-01-18 20:49:29 +00:00
|
|
|
unsigned int r_typ;
|
|
|
|
r_sym = ELF64_MIPS_R_SYM(rel->r_info);
|
|
|
|
r_sym = TO_NATIVE(r_sym);
|
|
|
|
r_typ = ELF64_MIPS_R_TYPE(rel->r_info);
|
|
|
|
r.r_info = ELF64_R_INFO(r_sym, r_typ);
|
|
|
|
} else {
|
|
|
|
r.r_info = TO_NATIVE(rel->r_info);
|
|
|
|
r_sym = ELF_R_SYM(r.r_info);
|
|
|
|
}
|
|
|
|
#else
|
|
|
|
r.r_info = TO_NATIVE(rel->r_info);
|
|
|
|
r_sym = ELF_R_SYM(r.r_info);
|
|
|
|
#endif
|
|
|
|
r.r_addend = 0;
|
2023-06-20 12:05:19 +00:00
|
|
|
|
|
|
|
loc = sym_get_data_by_offset(elf, fsecndx, r.r_offset);
|
2023-06-20 12:05:21 +00:00
|
|
|
tsym = elf->symtab_start + r_sym;
|
2023-06-20 12:05:19 +00:00
|
|
|
|
2008-01-23 18:54:27 +00:00
|
|
|
switch (elf->hdr->e_machine) {
|
2008-01-18 20:49:29 +00:00
|
|
|
case EM_386:
|
2023-06-20 12:05:21 +00:00
|
|
|
addend_386_rel(loc, &r);
|
2008-01-18 20:49:29 +00:00
|
|
|
break;
|
|
|
|
case EM_ARM:
|
2023-06-20 12:05:21 +00:00
|
|
|
addend_arm_rel(loc, tsym, &r);
|
2008-01-18 20:49:29 +00:00
|
|
|
break;
|
|
|
|
case EM_MIPS:
|
2023-06-20 12:05:21 +00:00
|
|
|
addend_mips_rel(loc, &r);
|
2008-01-18 20:49:29 +00:00
|
|
|
break;
|
2023-05-11 16:24:22 +00:00
|
|
|
default:
|
|
|
|
fatal("Please add code to calculate addend for this architecture\n");
|
2008-01-18 20:49:29 +00:00
|
|
|
}
|
2023-05-21 16:04:13 +00:00
|
|
|
|
2023-06-20 12:05:20 +00:00
|
|
|
check_section_mismatch(mod, elf, tsym,
|
2023-05-21 16:04:12 +00:00
|
|
|
fsecndx, fromsec, r.r_offset, r.r_addend);
|
2008-01-18 20:49:29 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2006-02-17 21:42:02 +00:00
|
|
|
/**
|
|
|
|
* A module includes a number of sections that are discarded
|
|
|
|
* either when loaded or when used as built-in.
|
|
|
|
* For loaded modules all functions marked __init and all data
|
tree-wide: fix comment/printk typos
"gadget", "through", "command", "maintain", "maintain", "controller", "address",
"between", "initiali[zs]e", "instead", "function", "select", "already",
"equal", "access", "management", "hierarchy", "registration", "interest",
"relative", "memory", "offset", "already",
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
2010-11-01 19:38:34 +00:00
|
|
|
* marked __initdata will be discarded when the module has been initialized.
|
2006-02-17 21:42:02 +00:00
|
|
|
* Likewise for modules used built-in the sections marked __exit
|
|
|
|
* are discarded because __exit marked function are supposed to be called
|
2008-07-30 05:33:44 +00:00
|
|
|
* only when a module is unloaded which never happens for built-in modules.
|
2006-02-17 21:42:02 +00:00
|
|
|
* The check_sec_ref() function traverses all relocation records
|
|
|
|
* to find all references to a section that reference a section that will
|
|
|
|
* be discarded and warns about it.
|
|
|
|
**/
|
2023-06-11 15:50:51 +00:00
|
|
|
static void check_sec_ref(struct module *mod, struct elf_info *elf)
|
2006-02-17 21:42:02 +00:00
|
|
|
{
|
|
|
|
int i;
|
|
|
|
Elf_Shdr *sechdrs = elf->sechdrs;
|
2006-03-03 15:46:04 +00:00
|
|
|
|
2006-02-17 21:42:02 +00:00
|
|
|
/* Walk through all sections */
|
2010-07-28 23:47:53 +00:00
|
|
|
for (i = 0; i < elf->num_sections; i++) {
|
2023-06-11 15:50:51 +00:00
|
|
|
check_section(mod->name, elf, &elf->sechdrs[i]);
|
2006-02-17 21:42:02 +00:00
|
|
|
/* We want to process only relocation sections and not .init */
|
2008-01-18 20:49:29 +00:00
|
|
|
if (sechdrs[i].sh_type == SHT_RELA)
|
2023-06-11 15:50:51 +00:00
|
|
|
section_rela(mod, elf, &elf->sechdrs[i]);
|
2008-01-18 20:49:29 +00:00
|
|
|
else if (sechdrs[i].sh_type == SHT_REL)
|
2023-06-11 15:50:51 +00:00
|
|
|
section_rel(mod, elf, &elf->sechdrs[i]);
|
2006-02-17 21:42:02 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2014-02-08 08:01:12 +00:00
|
|
|
static char *remove_dot(char *s)
|
|
|
|
{
|
2014-07-26 21:57:01 +00:00
|
|
|
size_t n = strcspn(s, ".");
|
2014-02-08 08:01:12 +00:00
|
|
|
|
2014-07-26 21:57:01 +00:00
|
|
|
if (n && s[n]) {
|
|
|
|
size_t m = strspn(s + n + 1, "0123456789");
|
2022-05-24 15:27:18 +00:00
|
|
|
if (m && (s[n + m + 1] == '.' || s[n + m + 1] == 0))
|
2014-02-08 08:01:12 +00:00
|
|
|
s[n] = 0;
|
|
|
|
}
|
|
|
|
return s;
|
|
|
|
}
|
|
|
|
|
2022-05-13 11:39:21 +00:00
|
|
|
/*
|
|
|
|
* The CRCs are recorded in .*.cmd files in the form of:
|
|
|
|
* #SYMVER <name> <crc>
|
|
|
|
*/
|
|
|
|
static void extract_crcs_for_object(const char *object, struct module *mod)
|
|
|
|
{
|
|
|
|
char cmd_file[PATH_MAX];
|
|
|
|
char *buf, *p;
|
|
|
|
const char *base;
|
|
|
|
int dirlen, ret;
|
|
|
|
|
|
|
|
base = strrchr(object, '/');
|
|
|
|
if (base) {
|
|
|
|
base++;
|
|
|
|
dirlen = base - object;
|
|
|
|
} else {
|
|
|
|
dirlen = 0;
|
|
|
|
base = object;
|
|
|
|
}
|
|
|
|
|
|
|
|
ret = snprintf(cmd_file, sizeof(cmd_file), "%.*s.%s.cmd",
|
|
|
|
dirlen, object, base);
|
|
|
|
if (ret >= sizeof(cmd_file)) {
|
|
|
|
error("%s: too long path was truncated\n", cmd_file);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
buf = read_text_file(cmd_file);
|
|
|
|
p = buf;
|
|
|
|
|
|
|
|
while ((p = strstr(p, "\n#SYMVER "))) {
|
|
|
|
char *name;
|
|
|
|
size_t namelen;
|
|
|
|
unsigned int crc;
|
|
|
|
struct symbol *sym;
|
|
|
|
|
|
|
|
name = p + strlen("\n#SYMVER ");
|
|
|
|
|
|
|
|
p = strchr(name, ' ');
|
|
|
|
if (!p)
|
|
|
|
break;
|
|
|
|
|
|
|
|
namelen = p - name;
|
|
|
|
p++;
|
|
|
|
|
|
|
|
if (!isdigit(*p))
|
|
|
|
continue; /* skip this line */
|
|
|
|
|
2023-03-22 18:11:45 +00:00
|
|
|
crc = strtoul(p, &p, 0);
|
2022-05-13 11:39:21 +00:00
|
|
|
if (*p != '\n')
|
|
|
|
continue; /* skip this line */
|
|
|
|
|
|
|
|
name[namelen] = '\0';
|
|
|
|
|
|
|
|
/*
|
|
|
|
* sym_find_with_module() may return NULL here.
|
|
|
|
* It typically occurs when CONFIG_TRIM_UNUSED_KSYMS=y.
|
|
|
|
* Since commit e1327a127703, genksyms calculates CRCs of all
|
|
|
|
* symbols, including trimmed ones. Ignore orphan CRCs.
|
|
|
|
*/
|
|
|
|
sym = sym_find_with_module(name, mod);
|
|
|
|
if (sym)
|
|
|
|
sym_set_crc(sym, crc);
|
|
|
|
}
|
|
|
|
|
|
|
|
free(buf);
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* The symbol versions (CRC) are recorded in the .*.cmd files.
|
|
|
|
* Parse them to retrieve CRCs for the current module.
|
|
|
|
*/
|
|
|
|
static void mod_set_crcs(struct module *mod)
|
|
|
|
{
|
|
|
|
char objlist[PATH_MAX];
|
|
|
|
char *buf, *p, *obj;
|
|
|
|
int ret;
|
|
|
|
|
|
|
|
if (mod->is_vmlinux) {
|
|
|
|
strcpy(objlist, ".vmlinux.objs");
|
|
|
|
} else {
|
|
|
|
/* objects for a module are listed in the *.mod file. */
|
|
|
|
ret = snprintf(objlist, sizeof(objlist), "%s.mod", mod->name);
|
|
|
|
if (ret >= sizeof(objlist)) {
|
|
|
|
error("%s: too long path was truncated\n", objlist);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
buf = read_text_file(objlist);
|
|
|
|
p = buf;
|
|
|
|
|
|
|
|
while ((obj = strsep(&p, "\n")) && obj[0])
|
|
|
|
extract_crcs_for_object(obj, mod);
|
|
|
|
|
|
|
|
free(buf);
|
|
|
|
}
|
|
|
|
|
2018-05-09 09:50:40 +00:00
|
|
|
static void read_symbols(const char *modname)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
|
|
|
const char *symname;
|
|
|
|
char *version;
|
2006-06-09 19:53:55 +00:00
|
|
|
char *license;
|
2019-09-06 10:32:28 +00:00
|
|
|
char *namespace;
|
2005-04-16 22:20:36 +00:00
|
|
|
struct module *mod;
|
|
|
|
struct elf_info info = { };
|
|
|
|
Elf_Sym *sym;
|
|
|
|
|
2007-02-26 14:33:52 +00:00
|
|
|
if (!parse_elf(&info, modname))
|
|
|
|
return;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2022-05-30 09:01:38 +00:00
|
|
|
if (!strends(modname, ".o")) {
|
|
|
|
error("%s: filename must be suffixed with .o\n", modname);
|
|
|
|
return;
|
2020-06-01 05:57:29 +00:00
|
|
|
}
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2022-05-30 09:01:38 +00:00
|
|
|
/* strip trailing .o */
|
|
|
|
mod = new_module(modname, strlen(modname) - strlen(".o"));
|
|
|
|
|
2020-06-01 05:57:26 +00:00
|
|
|
if (!mod->is_vmlinux) {
|
2020-06-01 05:57:16 +00:00
|
|
|
license = get_modinfo(&info, "license");
|
|
|
|
if (!license)
|
2020-12-01 10:34:16 +00:00
|
|
|
error("missing MODULE_LICENSE() in %s\n", modname);
|
2020-06-01 05:57:16 +00:00
|
|
|
while (license) {
|
modpost: change mod->gpl_compatible to bool type
Currently, mod->gpl_compatible is tristate; it is set to -1 by default,
then to 1 or 0 when MODULE_LICENSE() is found.
Maybe, -1 was chosen to represent the 'unknown' license, but it is not
useful.
The current code:
if (!mod->gpl_compatible)
check_for_gpl_usage(exp->export, basename, exp->name);
... only cares whether gpl_compatible is zero or not.
Change it to a bool type with the initial value 'true', which has no
functional change.
The default value should be 'true' instead of 'false'.
Since commit 1d6cd3929360 ("modpost: turn missing MODULE_LICENSE() into
error"), unknown module license is an error.
The error message, "missing MODULE_LICENSE()" is enough to explain the
issue. It is not sensible to show another message, "GPL-incompatible
module ... uses GPL-only symbol".
Add comments to explain this.
While I was here, I renamed gpl_compatible to is_gpl_compatible for
clarification, and also slightly refactored the code.
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
2022-05-01 08:40:08 +00:00
|
|
|
if (!license_is_gpl_compatible(license)) {
|
|
|
|
mod->is_gpl_compatible = false;
|
2020-06-01 05:57:16 +00:00
|
|
|
break;
|
|
|
|
}
|
|
|
|
license = get_next_modinfo(&info, "license", license);
|
2006-06-09 19:53:55 +00:00
|
|
|
}
|
|
|
|
|
2020-06-01 05:57:16 +00:00
|
|
|
namespace = get_modinfo(&info, "import_ns");
|
|
|
|
while (namespace) {
|
|
|
|
add_namespace(&mod->imported_namespaces, namespace);
|
|
|
|
namespace = get_next_modinfo(&info, "import_ns",
|
|
|
|
namespace);
|
|
|
|
}
|
2019-09-06 10:32:28 +00:00
|
|
|
}
|
|
|
|
|
2023-06-15 23:40:37 +00:00
|
|
|
if (extra_warn && !get_modinfo(&info, "description"))
|
|
|
|
warn("missing MODULE_DESCRIPTION() in %s\n", modname);
|
2005-04-16 22:20:36 +00:00
|
|
|
for (sym = info.symtab_start; sym < info.symtab_stop; sym++) {
|
2014-02-08 08:01:12 +00:00
|
|
|
symname = remove_dot(info.strtab + sym->st_name);
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2019-11-14 17:42:23 +00:00
|
|
|
handle_symbol(mod, &info, sym, symname);
|
2005-04-16 22:20:36 +00:00
|
|
|
handle_moddevtable(mod, &info, sym, symname);
|
|
|
|
}
|
2019-08-01 06:06:57 +00:00
|
|
|
|
2023-06-11 15:50:51 +00:00
|
|
|
check_sec_ref(mod, &info);
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2020-06-01 05:57:26 +00:00
|
|
|
if (!mod->is_vmlinux) {
|
2020-06-01 05:57:16 +00:00
|
|
|
version = get_modinfo(&info, "version");
|
|
|
|
if (version || all_versions)
|
2021-08-28 09:50:59 +00:00
|
|
|
get_src_version(mod->name, mod->srcversion,
|
2020-06-01 05:57:16 +00:00
|
|
|
sizeof(mod->srcversion) - 1);
|
|
|
|
}
|
2005-04-16 22:20:36 +00:00
|
|
|
|
|
|
|
parse_elf_finish(&info);
|
|
|
|
|
2022-05-13 11:39:21 +00:00
|
|
|
if (modversions) {
|
|
|
|
/*
|
|
|
|
* Our trick to get versioning for module struct etc. - it's
|
|
|
|
* never passed as an argument to an exported function, so
|
|
|
|
* the automatic versioning doesn't pick it up, but it's really
|
|
|
|
* important anyhow.
|
|
|
|
*/
|
2022-05-01 08:40:11 +00:00
|
|
|
sym_add_unresolved("module_layout", mod, false);
|
2022-05-13 11:39:21 +00:00
|
|
|
|
|
|
|
mod_set_crcs(mod);
|
|
|
|
}
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
|
2013-04-04 07:07:38 +00:00
|
|
|
static void read_symbols_from_files(const char *filename)
|
|
|
|
{
|
|
|
|
FILE *in = stdin;
|
|
|
|
char fname[PATH_MAX];
|
|
|
|
|
2022-12-11 13:04:07 +00:00
|
|
|
in = fopen(filename, "r");
|
|
|
|
if (!in)
|
|
|
|
fatal("Can't open filenames file %s: %m", filename);
|
2013-04-04 07:07:38 +00:00
|
|
|
|
|
|
|
while (fgets(fname, PATH_MAX, in) != NULL) {
|
|
|
|
if (strends(fname, "\n"))
|
|
|
|
fname[strlen(fname)-1] = '\0';
|
|
|
|
read_symbols(fname);
|
|
|
|
}
|
|
|
|
|
2022-12-11 13:04:07 +00:00
|
|
|
fclose(in);
|
2013-04-04 07:07:38 +00:00
|
|
|
}
|
|
|
|
|
2005-04-16 22:20:36 +00:00
|
|
|
#define SZ 500
|
|
|
|
|
|
|
|
/* We first write the generated file into memory using the
|
|
|
|
* following helper, then compare to the file on disk and
|
|
|
|
* only update the later if anything changed */
|
|
|
|
|
2006-01-28 16:19:35 +00:00
|
|
|
void __attribute__((format(printf, 2, 3))) buf_printf(struct buffer *buf,
|
|
|
|
const char *fmt, ...)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
|
|
|
char tmp[SZ];
|
|
|
|
int len;
|
|
|
|
va_list ap;
|
2006-03-03 15:46:04 +00:00
|
|
|
|
2005-04-16 22:20:36 +00:00
|
|
|
va_start(ap, fmt);
|
|
|
|
len = vsnprintf(tmp, SZ, fmt, ap);
|
2006-03-17 07:04:08 +00:00
|
|
|
buf_write(buf, tmp, len);
|
2005-04-16 22:20:36 +00:00
|
|
|
va_end(ap);
|
|
|
|
}
|
|
|
|
|
2006-01-28 16:19:35 +00:00
|
|
|
void buf_write(struct buffer *buf, const char *s, int len)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
|
|
|
if (buf->size - buf->pos < len) {
|
2006-03-17 07:04:08 +00:00
|
|
|
buf->size += len + SZ;
|
2018-08-15 19:30:38 +00:00
|
|
|
buf->p = NOFAIL(realloc(buf->p, buf->size));
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
strncpy(buf->p + buf->pos, s, len);
|
|
|
|
buf->pos += len;
|
|
|
|
}
|
|
|
|
|
2020-12-01 10:34:15 +00:00
|
|
|
static void check_exports(struct module *mod)
|
2006-06-09 19:53:55 +00:00
|
|
|
{
|
|
|
|
struct symbol *s, *exp;
|
|
|
|
|
2022-05-01 08:40:12 +00:00
|
|
|
list_for_each_entry(s, &mod->unresolved_symbols, list) {
|
2006-06-10 03:45:06 +00:00
|
|
|
const char *basename;
|
2006-06-09 19:53:55 +00:00
|
|
|
exp = find_symbol(s->name);
|
2022-04-24 19:07:48 +00:00
|
|
|
if (!exp) {
|
kbuild: fix false-positive modpost warning when all symbols are trimmed
Nathan reports that the mips defconfig emits the following warning:
WARNING: modpost: Symbol info of vmlinux is missing. Unresolved symbol check will be entirely skipped.
This false-positive happens when CONFIG_TRIM_UNUSED_KSYMS is enabled,
but no CONFIG option is set to 'm'.
Commit a0590473c5e6 ("nfs: fix PNFS_FLEXFILE_LAYOUT Kconfig default")
turned the last 'm' into 'y' for the mips defconfig, and uncovered
this issue.
In this case, the module feature itself is enabled, but we have no
module to build. As a result, CONFIG_TRIM_UNUSED_KSYMS drops all the
instances of EXPORT_SYMBOL. Then, modpost wrongly assumes vmlinux is
missing because vmlinux.symvers is empty. (As another false-positive
case, you can create a module that does not use any symbol of vmlinux).
The current behavior is to entirely suppress the unresolved symbol
warnings when vmlinux is missing just because there are too many.
I found the origin of this code in the historical git tree. [1]
If this is a matter of noisiness, I think modpost can display the
first 10 warnings, and the number of suppressed warnings at the end.
You will get a bit noisier logs when you run 'make modules' without
vmlinux, but such warnings are better to show because you never know
the resulting modules are actually loadable or not.
This commit changes the following:
- If any of input *.symver files is missing, pass -w option to let
the module build keep going with warnings instead of errors.
- If there are too many (10+) unresolved symbol warnings, show only
the first 10, and also the number of suppressed warnings.
[1]: https://git.kernel.org/pub/scm/linux/kernel/git/history/history.git/commit/?id=1cc0e0529569bf6a94f6d49770aa6d4b599d2c46
Reported-by: Nathan Chancellor <nathan@kernel.org>
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
2021-03-25 18:54:11 +00:00
|
|
|
if (!s->weak && nr_unresolved++ < MAX_UNRESOLVED_REPORTS)
|
2020-03-06 16:02:05 +00:00
|
|
|
modpost_log(warn_unresolved ? LOG_WARN : LOG_ERROR,
|
|
|
|
"\"%s\" [%s.ko] undefined!\n",
|
|
|
|
s->name, mod->name);
|
2006-06-09 19:53:55 +00:00
|
|
|
continue;
|
2018-11-23 07:57:23 +00:00
|
|
|
}
|
2022-04-24 19:07:48 +00:00
|
|
|
if (exp->module == mod) {
|
|
|
|
error("\"%s\" [%s.ko] was exported without definition\n",
|
|
|
|
s->name, mod->name);
|
|
|
|
continue;
|
|
|
|
}
|
2022-04-24 19:07:49 +00:00
|
|
|
|
kbuild: implement CONFIG_TRIM_UNUSED_KSYMS without recursion
When CONFIG_TRIM_UNUSED_KSYMS is enabled, Kbuild recursively traverses
the directory tree to determine which EXPORT_SYMBOL to trim. If an
EXPORT_SYMBOL turns out to be unused by anyone, Kbuild begins the
second traverse, where some source files are recompiled with their
EXPORT_SYMBOL() tuned into a no-op.
Linus stated negative opinions about this slowness in commits:
- 5cf0fd591f2e ("Kbuild: disable TRIM_UNUSED_KSYMS option")
- a555bdd0c58c ("Kbuild: enable TRIM_UNUSED_KSYMS again, with some guarding")
We can do this better now. The final data structures of EXPORT_SYMBOL
are generated by the modpost stage, so modpost can selectively emit
KSYMTAB entries that are really used by modules.
Commit f73edc8951b2 ("kbuild: unify two modpost invocations") is another
ground-work to do this in a one-pass algorithm. With the list of modules,
modpost sets sym->used if it is used by a module. modpost emits KSYMTAB
only for symbols with sym->used==true.
BTW, Nicolas explained why the trimming was implemented with recursion:
https://lore.kernel.org/all/2o2rpn97-79nq-p7s2-nq5-8p83391473r@syhkavp.arg/
Actually, we never achieved that level of optimization where the chain
reaction of trimming comes into play because:
- CONFIG_LTO_CLANG cannot remove any unused symbols
- CONFIG_LD_DEAD_CODE_DATA_ELIMINATION is enabled only for vmlinux,
but not modules
If deeper trimming is required, we need to revisit this, but I guess
that is unlikely to happen.
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
2023-06-11 15:50:57 +00:00
|
|
|
exp->used = true;
|
2022-04-24 19:07:49 +00:00
|
|
|
s->module = exp->module;
|
|
|
|
s->crc_valid = exp->crc_valid;
|
|
|
|
s->crc = exp->crc;
|
|
|
|
|
2006-06-10 03:45:06 +00:00
|
|
|
basename = strrchr(mod->name, '/');
|
2006-06-09 19:53:55 +00:00
|
|
|
if (basename)
|
|
|
|
basename++;
|
2006-07-01 09:44:23 +00:00
|
|
|
else
|
|
|
|
basename = mod->name;
|
2019-09-06 10:32:28 +00:00
|
|
|
|
2023-06-11 15:50:56 +00:00
|
|
|
if (!contains_namespace(&mod->imported_namespaces, exp->namespace)) {
|
2020-03-06 16:02:06 +00:00
|
|
|
modpost_log(allow_missing_ns_imports ? LOG_WARN : LOG_ERROR,
|
|
|
|
"module %s uses symbol %s from namespace %s, but does not import it.\n",
|
|
|
|
basename, exp->name, exp->namespace);
|
2019-10-29 12:38:07 +00:00
|
|
|
add_namespace(&mod->missing_namespaces, exp->namespace);
|
2019-09-06 10:32:28 +00:00
|
|
|
}
|
|
|
|
|
2022-05-08 19:06:19 +00:00
|
|
|
if (!mod->is_gpl_compatible && exp->is_gpl_only)
|
|
|
|
error("GPL-incompatible module %s.ko uses GPL-only symbol '%s'\n",
|
|
|
|
basename, exp->name);
|
2008-01-11 18:17:15 +00:00
|
|
|
}
|
2006-06-09 19:53:55 +00:00
|
|
|
}
|
|
|
|
|
kbuild: implement CONFIG_TRIM_UNUSED_KSYMS without recursion
When CONFIG_TRIM_UNUSED_KSYMS is enabled, Kbuild recursively traverses
the directory tree to determine which EXPORT_SYMBOL to trim. If an
EXPORT_SYMBOL turns out to be unused by anyone, Kbuild begins the
second traverse, where some source files are recompiled with their
EXPORT_SYMBOL() tuned into a no-op.
Linus stated negative opinions about this slowness in commits:
- 5cf0fd591f2e ("Kbuild: disable TRIM_UNUSED_KSYMS option")
- a555bdd0c58c ("Kbuild: enable TRIM_UNUSED_KSYMS again, with some guarding")
We can do this better now. The final data structures of EXPORT_SYMBOL
are generated by the modpost stage, so modpost can selectively emit
KSYMTAB entries that are really used by modules.
Commit f73edc8951b2 ("kbuild: unify two modpost invocations") is another
ground-work to do this in a one-pass algorithm. With the list of modules,
modpost sets sym->used if it is used by a module. modpost emits KSYMTAB
only for symbols with sym->used==true.
BTW, Nicolas explained why the trimming was implemented with recursion:
https://lore.kernel.org/all/2o2rpn97-79nq-p7s2-nq5-8p83391473r@syhkavp.arg/
Actually, we never achieved that level of optimization where the chain
reaction of trimming comes into play because:
- CONFIG_LTO_CLANG cannot remove any unused symbols
- CONFIG_LD_DEAD_CODE_DATA_ELIMINATION is enabled only for vmlinux,
but not modules
If deeper trimming is required, we need to revisit this, but I guess
that is unlikely to happen.
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
2023-06-11 15:50:57 +00:00
|
|
|
static void handle_white_list_exports(const char *white_list)
|
|
|
|
{
|
|
|
|
char *buf, *p, *name;
|
|
|
|
|
|
|
|
buf = read_text_file(white_list);
|
|
|
|
p = buf;
|
|
|
|
|
|
|
|
while ((name = strsep(&p, "\n"))) {
|
|
|
|
struct symbol *sym = find_symbol(name);
|
|
|
|
|
|
|
|
if (sym)
|
|
|
|
sym->used = true;
|
|
|
|
}
|
|
|
|
|
|
|
|
free(buf);
|
|
|
|
}
|
|
|
|
|
2020-12-01 10:34:15 +00:00
|
|
|
static void check_modname_len(struct module *mod)
|
2017-06-30 14:07:03 +00:00
|
|
|
{
|
|
|
|
const char *mod_name;
|
|
|
|
|
|
|
|
mod_name = strrchr(mod->name, '/');
|
|
|
|
if (mod_name == NULL)
|
|
|
|
mod_name = mod->name;
|
|
|
|
else
|
|
|
|
mod_name++;
|
2020-12-01 10:34:15 +00:00
|
|
|
if (strlen(mod_name) >= MODULE_NAME_LEN)
|
modpost: rename merror() to error()
The log function names, warn(), merror(), fatal() are inconsistent.
Commit 2a11665945d5 ("kbuild: distinguish between errors and warnings
in modpost") intentionally chose merror() to avoid the conflict with
the library function error(). See man page of error(3).
But, we are already causing the conflict with warn() because it is also
a library function. See man page of warn(3). err() would be a problem
for the same reason.
The common technique to work around name conflicts is to use macros.
For example:
/* in a header */
#define error(fmt, ...) __error(fmt, ##__VA_ARGS__)
#define warn(fmt, ...) __warn(fmt, ##__VA_ARGS__)
/* function definition */
void __error(const char *fmt, ...)
{
<our implementation>
}
void __warn(const char *fmt, ...)
{
<our implementation>
}
In this way, we can implement our own warn() and error(), still we can
include <error.h> and <err.h> with no problem.
And, commit 93c95e526a4e ("modpost: rework and consolidate logging
interface") already did that.
Since the log functions are all macros, we can use error() without
causing "conflicting types" errors.
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
2020-12-01 10:34:14 +00:00
|
|
|
error("module name is too long [%s.ko]\n", mod->name);
|
2017-06-30 14:07:03 +00:00
|
|
|
}
|
|
|
|
|
2006-01-28 16:19:35 +00:00
|
|
|
/**
|
|
|
|
* Header for the generated file
|
|
|
|
**/
|
|
|
|
static void add_header(struct buffer *b, struct module *mod)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
|
|
|
buf_printf(b, "#include <linux/module.h>\n");
|
2020-03-20 14:53:41 +00:00
|
|
|
/*
|
|
|
|
* Include build-salt.h after module.h in order to
|
|
|
|
* inherit the definitions.
|
|
|
|
*/
|
2020-04-19 15:55:06 +00:00
|
|
|
buf_printf(b, "#define INCLUDE_VERMAGIC\n");
|
2020-03-20 14:53:41 +00:00
|
|
|
buf_printf(b, "#include <linux/build-salt.h>\n");
|
2021-04-01 23:27:23 +00:00
|
|
|
buf_printf(b, "#include <linux/elfnote-lto.h>\n");
|
kbuild: link symbol CRCs at final link, removing CONFIG_MODULE_REL_CRCS
include/{linux,asm-generic}/export.h defines a weak symbol, __crc_*
as a placeholder.
Genksyms writes the version CRCs into the linker script, which will be
used for filling the __crc_* symbols. The linker script format depends
on CONFIG_MODULE_REL_CRCS. If it is enabled, __crc_* holds the offset
to the reference of CRC.
It is time to get rid of this complexity.
Now that modpost parses text files (.*.cmd) to collect all the CRCs,
it can generate C code that will be linked to the vmlinux or modules.
Generate a new C file, .vmlinux.export.c, which contains the CRCs of
symbols exported by vmlinux. It is compiled and linked to vmlinux in
scripts/link-vmlinux.sh.
Put the CRCs of symbols exported by modules into the existing *.mod.c
files. No additional build step is needed for modules. As before,
*.mod.c are compiled and linked to *.ko in scripts/Makefile.modfinal.
No linker magic is used here. The new C implementation works in the
same way, whether CONFIG_RELOCATABLE is enabled or not.
CONFIG_MODULE_REL_CRCS is no longer needed.
Previously, Kbuild invoked additional $(LD) to update the CRCs in
objects, but this step is unneeded too.
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Tested-by: Nathan Chancellor <nathan@kernel.org>
Tested-by: Nicolas Schier <nicolas@fjasle.eu>
Reviewed-by: Nicolas Schier <nicolas@fjasle.eu>
Tested-by: Sedat Dilek <sedat.dilek@gmail.com> # LLVM-14 (x86-64)
2022-05-13 11:39:22 +00:00
|
|
|
buf_printf(b, "#include <linux/export-internal.h>\n");
|
2005-04-16 22:20:36 +00:00
|
|
|
buf_printf(b, "#include <linux/vermagic.h>\n");
|
|
|
|
buf_printf(b, "#include <linux/compiler.h>\n");
|
|
|
|
buf_printf(b, "\n");
|
x86/unwind/orc: Add ELF section with ORC version identifier
Commits ffb1b4a41016 ("x86/unwind/orc: Add 'signal' field to ORC
metadata") and fb799447ae29 ("x86,objtool: Split UNWIND_HINT_EMPTY in
two") changed the ORC format. Although ORC is internal to the kernel,
it's the only way for external tools to get reliable kernel stack traces
on x86-64. In particular, the drgn debugger [1] uses ORC for stack
unwinding, and these format changes broke it [2]. As the drgn
maintainer, I don't care how often or how much the kernel changes the
ORC format as long as I have a way to detect the change.
It suffices to store a version identifier in the vmlinux and kernel
module ELF files (to use when parsing ORC sections from ELF), and in
kernel memory (to use when parsing ORC from a core dump+symbol table).
Rather than hard-coding a version number that needs to be manually
bumped, Peterz suggested hashing the definitions from orc_types.h. If
there is a format change that isn't caught by this, the hashing script
can be updated.
This patch adds an .orc_header allocated ELF section containing the
20-byte hash to vmlinux and kernel modules, along with the corresponding
__start_orc_header and __stop_orc_header symbols in vmlinux.
1: https://github.com/osandov/drgn
2: https://github.com/osandov/drgn/issues/303
Fixes: ffb1b4a41016 ("x86/unwind/orc: Add 'signal' field to ORC metadata")
Fixes: fb799447ae29 ("x86,objtool: Split UNWIND_HINT_EMPTY in two")
Signed-off-by: Omar Sandoval <osandov@fb.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Acked-by: Josh Poimboeuf <jpoimboe@kernel.org>
Link: https://lkml.kernel.org/r/aef9c8dc43915b886a8c48509a12ec1b006ca1ca.1686690801.git.osandov@osandov.com
2023-06-13 21:14:56 +00:00
|
|
|
buf_printf(b, "#ifdef CONFIG_UNWINDER_ORC\n");
|
|
|
|
buf_printf(b, "#include <asm/orc_header.h>\n");
|
|
|
|
buf_printf(b, "ORC_HEADER;\n");
|
|
|
|
buf_printf(b, "#endif\n");
|
|
|
|
buf_printf(b, "\n");
|
2018-07-06 00:49:37 +00:00
|
|
|
buf_printf(b, "BUILD_SALT;\n");
|
2021-04-01 23:27:23 +00:00
|
|
|
buf_printf(b, "BUILD_LTO_INFO;\n");
|
2018-07-06 00:49:37 +00:00
|
|
|
buf_printf(b, "\n");
|
2005-04-16 22:20:36 +00:00
|
|
|
buf_printf(b, "MODULE_INFO(vermagic, VERMAGIC_STRING);\n");
|
2017-04-21 22:35:27 +00:00
|
|
|
buf_printf(b, "MODULE_INFO(name, KBUILD_MODNAME);\n");
|
2005-04-16 22:20:36 +00:00
|
|
|
buf_printf(b, "\n");
|
2013-10-23 00:27:58 +00:00
|
|
|
buf_printf(b, "__visible struct module __this_module\n");
|
2020-10-22 02:36:07 +00:00
|
|
|
buf_printf(b, "__section(\".gnu.linkonce.this_module\") = {\n");
|
2012-04-25 18:10:15 +00:00
|
|
|
buf_printf(b, "\t.name = KBUILD_MODNAME,\n");
|
2005-04-16 22:20:36 +00:00
|
|
|
if (mod->has_init)
|
2012-04-25 18:10:15 +00:00
|
|
|
buf_printf(b, "\t.init = init_module,\n");
|
2005-04-16 22:20:36 +00:00
|
|
|
if (mod->has_cleanup)
|
|
|
|
buf_printf(b, "#ifdef CONFIG_MODULE_UNLOAD\n"
|
2012-04-25 18:10:15 +00:00
|
|
|
"\t.exit = cleanup_module,\n"
|
2005-04-16 22:20:36 +00:00
|
|
|
"#endif\n");
|
2012-04-25 18:10:15 +00:00
|
|
|
buf_printf(b, "\t.arch = MODULE_ARCH_INIT,\n");
|
2005-04-16 22:20:36 +00:00
|
|
|
buf_printf(b, "};\n");
|
|
|
|
|
2022-05-05 07:22:32 +00:00
|
|
|
if (!external_module)
|
2011-10-24 13:12:28 +00:00
|
|
|
buf_printf(b, "\nMODULE_INFO(intree, \"Y\");\n");
|
|
|
|
|
2022-05-05 07:22:32 +00:00
|
|
|
buf_printf(b,
|
|
|
|
"\n"
|
|
|
|
"#ifdef CONFIG_RETPOLINE\n"
|
|
|
|
"MODULE_INFO(retpoline, \"Y\");\n"
|
|
|
|
"#endif\n");
|
2018-01-25 23:50:28 +00:00
|
|
|
|
2022-05-05 07:22:32 +00:00
|
|
|
if (strstarts(mod->name, "drivers/staging"))
|
2008-09-24 21:46:44 +00:00
|
|
|
buf_printf(b, "\nMODULE_INFO(staging, \"Y\");\n");
|
2022-07-08 04:48:45 +00:00
|
|
|
|
|
|
|
if (strstarts(mod->name, "tools/testing"))
|
|
|
|
buf_printf(b, "\nMODULE_INFO(test, \"Y\");\n");
|
2008-09-24 21:46:44 +00:00
|
|
|
}
|
|
|
|
|
kbuild: link symbol CRCs at final link, removing CONFIG_MODULE_REL_CRCS
include/{linux,asm-generic}/export.h defines a weak symbol, __crc_*
as a placeholder.
Genksyms writes the version CRCs into the linker script, which will be
used for filling the __crc_* symbols. The linker script format depends
on CONFIG_MODULE_REL_CRCS. If it is enabled, __crc_* holds the offset
to the reference of CRC.
It is time to get rid of this complexity.
Now that modpost parses text files (.*.cmd) to collect all the CRCs,
it can generate C code that will be linked to the vmlinux or modules.
Generate a new C file, .vmlinux.export.c, which contains the CRCs of
symbols exported by vmlinux. It is compiled and linked to vmlinux in
scripts/link-vmlinux.sh.
Put the CRCs of symbols exported by modules into the existing *.mod.c
files. No additional build step is needed for modules. As before,
*.mod.c are compiled and linked to *.ko in scripts/Makefile.modfinal.
No linker magic is used here. The new C implementation works in the
same way, whether CONFIG_RELOCATABLE is enabled or not.
CONFIG_MODULE_REL_CRCS is no longer needed.
Previously, Kbuild invoked additional $(LD) to update the CRCs in
objects, but this step is unneeded too.
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Tested-by: Nathan Chancellor <nathan@kernel.org>
Tested-by: Nicolas Schier <nicolas@fjasle.eu>
Reviewed-by: Nicolas Schier <nicolas@fjasle.eu>
Tested-by: Sedat Dilek <sedat.dilek@gmail.com> # LLVM-14 (x86-64)
2022-05-13 11:39:22 +00:00
|
|
|
static void add_exported_symbols(struct buffer *buf, struct module *mod)
|
2022-05-13 11:39:21 +00:00
|
|
|
{
|
|
|
|
struct symbol *sym;
|
|
|
|
|
kbuild: generate KSYMTAB entries by modpost
Commit 7b4537199a4a ("kbuild: link symbol CRCs at final link, removing
CONFIG_MODULE_REL_CRCS") made modpost output CRCs in the same way
whether the EXPORT_SYMBOL() is placed in *.c or *.S.
For further cleanups, this commit applies a similar approach to the
entire data structure of EXPORT_SYMBOL().
The EXPORT_SYMBOL() compilation is split into two stages.
When a source file is compiled, EXPORT_SYMBOL() will be converted into
a dummy symbol in the .export_symbol section.
For example,
EXPORT_SYMBOL(foo);
EXPORT_SYMBOL_NS_GPL(bar, BAR_NAMESPACE);
will be encoded into the following assembly code:
.section ".export_symbol","a"
__export_symbol_foo:
.asciz "" /* license */
.asciz "" /* name space */
.balign 8
.quad foo /* symbol reference */
.previous
.section ".export_symbol","a"
__export_symbol_bar:
.asciz "GPL" /* license */
.asciz "BAR_NAMESPACE" /* name space */
.balign 8
.quad bar /* symbol reference */
.previous
They are mere markers to tell modpost the name, license, and namespace
of the symbols. They will be dropped from the final vmlinux and modules
because the *(.export_symbol) will go into /DISCARD/ in the linker script.
Then, modpost extracts all the information about EXPORT_SYMBOL() from the
.export_symbol section, and generates the final C code:
KSYMTAB_FUNC(foo, "", "");
KSYMTAB_FUNC(bar, "_gpl", "BAR_NAMESPACE");
KSYMTAB_FUNC() (or KSYMTAB_DATA() if it is data) is expanded to struct
kernel_symbol that will be linked to the vmlinux or a module.
With this change, EXPORT_SYMBOL() works in the same way for *.c and *.S
files, providing the following benefits.
[1] Deprecate EXPORT_DATA_SYMBOL()
In the old days, EXPORT_SYMBOL() was only available in C files. To export
a symbol in *.S, EXPORT_SYMBOL() was placed in a separate *.c file.
arch/arm/kernel/armksyms.c is one example written in the classic manner.
Commit 22823ab419d8 ("EXPORT_SYMBOL() for asm") removed this limitation.
Since then, EXPORT_SYMBOL() can be placed close to the symbol definition
in *.S files. It was a nice improvement.
However, as that commit mentioned, you need to use EXPORT_DATA_SYMBOL()
for data objects on some architectures.
In the new approach, modpost checks symbol's type (STT_FUNC or not),
and outputs KSYMTAB_FUNC() or KSYMTAB_DATA() accordingly.
There are only two users of EXPORT_DATA_SYMBOL:
EXPORT_DATA_SYMBOL_GPL(empty_zero_page) (arch/ia64/kernel/head.S)
EXPORT_DATA_SYMBOL(ia64_ivt) (arch/ia64/kernel/ivt.S)
They are transformed as follows and output into .vmlinux.export.c
KSYMTAB_DATA(empty_zero_page, "_gpl", "");
KSYMTAB_DATA(ia64_ivt, "", "");
The other EXPORT_SYMBOL users in ia64 assembly are output as
KSYMTAB_FUNC().
EXPORT_DATA_SYMBOL() is now deprecated.
[2] merge <linux/export.h> and <asm-generic/export.h>
There are two similar header implementations:
include/linux/export.h for .c files
include/asm-generic/export.h for .S files
Ideally, the functionality should be consistent between them, but they
tend to diverge.
Commit 8651ec01daed ("module: add support for symbol namespaces.") did
not support the namespace for *.S files.
This commit shifts the essential implementation part to C, which supports
EXPORT_SYMBOL_NS() for *.S files.
<asm/export.h> and <asm-generic/export.h> will remain as a wrapper of
<linux/export.h> for a while.
They will be removed after #include <asm/export.h> directives are all
replaced with #include <linux/export.h>.
[3] Implement CONFIG_TRIM_UNUSED_KSYMS in one-pass algorithm (by a later commit)
When CONFIG_TRIM_UNUSED_KSYMS is enabled, Kbuild recursively traverses
the directory tree to determine which EXPORT_SYMBOL to trim. If an
EXPORT_SYMBOL turns out to be unused by anyone, Kbuild begins the
second traverse, where some source files are recompiled with their
EXPORT_SYMBOL() tuned into a no-op.
We can do this better now; modpost can selectively emit KSYMTAB entries
that are really used by modules.
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
2023-06-11 15:50:52 +00:00
|
|
|
/* generate struct for exported symbols */
|
|
|
|
buf_printf(buf, "\n");
|
kbuild: implement CONFIG_TRIM_UNUSED_KSYMS without recursion
When CONFIG_TRIM_UNUSED_KSYMS is enabled, Kbuild recursively traverses
the directory tree to determine which EXPORT_SYMBOL to trim. If an
EXPORT_SYMBOL turns out to be unused by anyone, Kbuild begins the
second traverse, where some source files are recompiled with their
EXPORT_SYMBOL() tuned into a no-op.
Linus stated negative opinions about this slowness in commits:
- 5cf0fd591f2e ("Kbuild: disable TRIM_UNUSED_KSYMS option")
- a555bdd0c58c ("Kbuild: enable TRIM_UNUSED_KSYMS again, with some guarding")
We can do this better now. The final data structures of EXPORT_SYMBOL
are generated by the modpost stage, so modpost can selectively emit
KSYMTAB entries that are really used by modules.
Commit f73edc8951b2 ("kbuild: unify two modpost invocations") is another
ground-work to do this in a one-pass algorithm. With the list of modules,
modpost sets sym->used if it is used by a module. modpost emits KSYMTAB
only for symbols with sym->used==true.
BTW, Nicolas explained why the trimming was implemented with recursion:
https://lore.kernel.org/all/2o2rpn97-79nq-p7s2-nq5-8p83391473r@syhkavp.arg/
Actually, we never achieved that level of optimization where the chain
reaction of trimming comes into play because:
- CONFIG_LTO_CLANG cannot remove any unused symbols
- CONFIG_LD_DEAD_CODE_DATA_ELIMINATION is enabled only for vmlinux,
but not modules
If deeper trimming is required, we need to revisit this, but I guess
that is unlikely to happen.
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
2023-06-11 15:50:57 +00:00
|
|
|
list_for_each_entry(sym, &mod->exported_symbols, list) {
|
|
|
|
if (trim_unused_exports && !sym->used)
|
|
|
|
continue;
|
|
|
|
|
kbuild: generate KSYMTAB entries by modpost
Commit 7b4537199a4a ("kbuild: link symbol CRCs at final link, removing
CONFIG_MODULE_REL_CRCS") made modpost output CRCs in the same way
whether the EXPORT_SYMBOL() is placed in *.c or *.S.
For further cleanups, this commit applies a similar approach to the
entire data structure of EXPORT_SYMBOL().
The EXPORT_SYMBOL() compilation is split into two stages.
When a source file is compiled, EXPORT_SYMBOL() will be converted into
a dummy symbol in the .export_symbol section.
For example,
EXPORT_SYMBOL(foo);
EXPORT_SYMBOL_NS_GPL(bar, BAR_NAMESPACE);
will be encoded into the following assembly code:
.section ".export_symbol","a"
__export_symbol_foo:
.asciz "" /* license */
.asciz "" /* name space */
.balign 8
.quad foo /* symbol reference */
.previous
.section ".export_symbol","a"
__export_symbol_bar:
.asciz "GPL" /* license */
.asciz "BAR_NAMESPACE" /* name space */
.balign 8
.quad bar /* symbol reference */
.previous
They are mere markers to tell modpost the name, license, and namespace
of the symbols. They will be dropped from the final vmlinux and modules
because the *(.export_symbol) will go into /DISCARD/ in the linker script.
Then, modpost extracts all the information about EXPORT_SYMBOL() from the
.export_symbol section, and generates the final C code:
KSYMTAB_FUNC(foo, "", "");
KSYMTAB_FUNC(bar, "_gpl", "BAR_NAMESPACE");
KSYMTAB_FUNC() (or KSYMTAB_DATA() if it is data) is expanded to struct
kernel_symbol that will be linked to the vmlinux or a module.
With this change, EXPORT_SYMBOL() works in the same way for *.c and *.S
files, providing the following benefits.
[1] Deprecate EXPORT_DATA_SYMBOL()
In the old days, EXPORT_SYMBOL() was only available in C files. To export
a symbol in *.S, EXPORT_SYMBOL() was placed in a separate *.c file.
arch/arm/kernel/armksyms.c is one example written in the classic manner.
Commit 22823ab419d8 ("EXPORT_SYMBOL() for asm") removed this limitation.
Since then, EXPORT_SYMBOL() can be placed close to the symbol definition
in *.S files. It was a nice improvement.
However, as that commit mentioned, you need to use EXPORT_DATA_SYMBOL()
for data objects on some architectures.
In the new approach, modpost checks symbol's type (STT_FUNC or not),
and outputs KSYMTAB_FUNC() or KSYMTAB_DATA() accordingly.
There are only two users of EXPORT_DATA_SYMBOL:
EXPORT_DATA_SYMBOL_GPL(empty_zero_page) (arch/ia64/kernel/head.S)
EXPORT_DATA_SYMBOL(ia64_ivt) (arch/ia64/kernel/ivt.S)
They are transformed as follows and output into .vmlinux.export.c
KSYMTAB_DATA(empty_zero_page, "_gpl", "");
KSYMTAB_DATA(ia64_ivt, "", "");
The other EXPORT_SYMBOL users in ia64 assembly are output as
KSYMTAB_FUNC().
EXPORT_DATA_SYMBOL() is now deprecated.
[2] merge <linux/export.h> and <asm-generic/export.h>
There are two similar header implementations:
include/linux/export.h for .c files
include/asm-generic/export.h for .S files
Ideally, the functionality should be consistent between them, but they
tend to diverge.
Commit 8651ec01daed ("module: add support for symbol namespaces.") did
not support the namespace for *.S files.
This commit shifts the essential implementation part to C, which supports
EXPORT_SYMBOL_NS() for *.S files.
<asm/export.h> and <asm-generic/export.h> will remain as a wrapper of
<linux/export.h> for a while.
They will be removed after #include <asm/export.h> directives are all
replaced with #include <linux/export.h>.
[3] Implement CONFIG_TRIM_UNUSED_KSYMS in one-pass algorithm (by a later commit)
When CONFIG_TRIM_UNUSED_KSYMS is enabled, Kbuild recursively traverses
the directory tree to determine which EXPORT_SYMBOL to trim. If an
EXPORT_SYMBOL turns out to be unused by anyone, Kbuild begins the
second traverse, where some source files are recompiled with their
EXPORT_SYMBOL() tuned into a no-op.
We can do this better now; modpost can selectively emit KSYMTAB entries
that are really used by modules.
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
2023-06-11 15:50:52 +00:00
|
|
|
buf_printf(buf, "KSYMTAB_%s(%s, \"%s\", \"%s\");\n",
|
|
|
|
sym->is_func ? "FUNC" : "DATA", sym->name,
|
2023-06-11 15:50:56 +00:00
|
|
|
sym->is_gpl_only ? "_gpl" : "", sym->namespace);
|
kbuild: implement CONFIG_TRIM_UNUSED_KSYMS without recursion
When CONFIG_TRIM_UNUSED_KSYMS is enabled, Kbuild recursively traverses
the directory tree to determine which EXPORT_SYMBOL to trim. If an
EXPORT_SYMBOL turns out to be unused by anyone, Kbuild begins the
second traverse, where some source files are recompiled with their
EXPORT_SYMBOL() tuned into a no-op.
Linus stated negative opinions about this slowness in commits:
- 5cf0fd591f2e ("Kbuild: disable TRIM_UNUSED_KSYMS option")
- a555bdd0c58c ("Kbuild: enable TRIM_UNUSED_KSYMS again, with some guarding")
We can do this better now. The final data structures of EXPORT_SYMBOL
are generated by the modpost stage, so modpost can selectively emit
KSYMTAB entries that are really used by modules.
Commit f73edc8951b2 ("kbuild: unify two modpost invocations") is another
ground-work to do this in a one-pass algorithm. With the list of modules,
modpost sets sym->used if it is used by a module. modpost emits KSYMTAB
only for symbols with sym->used==true.
BTW, Nicolas explained why the trimming was implemented with recursion:
https://lore.kernel.org/all/2o2rpn97-79nq-p7s2-nq5-8p83391473r@syhkavp.arg/
Actually, we never achieved that level of optimization where the chain
reaction of trimming comes into play because:
- CONFIG_LTO_CLANG cannot remove any unused symbols
- CONFIG_LD_DEAD_CODE_DATA_ELIMINATION is enabled only for vmlinux,
but not modules
If deeper trimming is required, we need to revisit this, but I guess
that is unlikely to happen.
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
2023-06-11 15:50:57 +00:00
|
|
|
}
|
kbuild: generate KSYMTAB entries by modpost
Commit 7b4537199a4a ("kbuild: link symbol CRCs at final link, removing
CONFIG_MODULE_REL_CRCS") made modpost output CRCs in the same way
whether the EXPORT_SYMBOL() is placed in *.c or *.S.
For further cleanups, this commit applies a similar approach to the
entire data structure of EXPORT_SYMBOL().
The EXPORT_SYMBOL() compilation is split into two stages.
When a source file is compiled, EXPORT_SYMBOL() will be converted into
a dummy symbol in the .export_symbol section.
For example,
EXPORT_SYMBOL(foo);
EXPORT_SYMBOL_NS_GPL(bar, BAR_NAMESPACE);
will be encoded into the following assembly code:
.section ".export_symbol","a"
__export_symbol_foo:
.asciz "" /* license */
.asciz "" /* name space */
.balign 8
.quad foo /* symbol reference */
.previous
.section ".export_symbol","a"
__export_symbol_bar:
.asciz "GPL" /* license */
.asciz "BAR_NAMESPACE" /* name space */
.balign 8
.quad bar /* symbol reference */
.previous
They are mere markers to tell modpost the name, license, and namespace
of the symbols. They will be dropped from the final vmlinux and modules
because the *(.export_symbol) will go into /DISCARD/ in the linker script.
Then, modpost extracts all the information about EXPORT_SYMBOL() from the
.export_symbol section, and generates the final C code:
KSYMTAB_FUNC(foo, "", "");
KSYMTAB_FUNC(bar, "_gpl", "BAR_NAMESPACE");
KSYMTAB_FUNC() (or KSYMTAB_DATA() if it is data) is expanded to struct
kernel_symbol that will be linked to the vmlinux or a module.
With this change, EXPORT_SYMBOL() works in the same way for *.c and *.S
files, providing the following benefits.
[1] Deprecate EXPORT_DATA_SYMBOL()
In the old days, EXPORT_SYMBOL() was only available in C files. To export
a symbol in *.S, EXPORT_SYMBOL() was placed in a separate *.c file.
arch/arm/kernel/armksyms.c is one example written in the classic manner.
Commit 22823ab419d8 ("EXPORT_SYMBOL() for asm") removed this limitation.
Since then, EXPORT_SYMBOL() can be placed close to the symbol definition
in *.S files. It was a nice improvement.
However, as that commit mentioned, you need to use EXPORT_DATA_SYMBOL()
for data objects on some architectures.
In the new approach, modpost checks symbol's type (STT_FUNC or not),
and outputs KSYMTAB_FUNC() or KSYMTAB_DATA() accordingly.
There are only two users of EXPORT_DATA_SYMBOL:
EXPORT_DATA_SYMBOL_GPL(empty_zero_page) (arch/ia64/kernel/head.S)
EXPORT_DATA_SYMBOL(ia64_ivt) (arch/ia64/kernel/ivt.S)
They are transformed as follows and output into .vmlinux.export.c
KSYMTAB_DATA(empty_zero_page, "_gpl", "");
KSYMTAB_DATA(ia64_ivt, "", "");
The other EXPORT_SYMBOL users in ia64 assembly are output as
KSYMTAB_FUNC().
EXPORT_DATA_SYMBOL() is now deprecated.
[2] merge <linux/export.h> and <asm-generic/export.h>
There are two similar header implementations:
include/linux/export.h for .c files
include/asm-generic/export.h for .S files
Ideally, the functionality should be consistent between them, but they
tend to diverge.
Commit 8651ec01daed ("module: add support for symbol namespaces.") did
not support the namespace for *.S files.
This commit shifts the essential implementation part to C, which supports
EXPORT_SYMBOL_NS() for *.S files.
<asm/export.h> and <asm-generic/export.h> will remain as a wrapper of
<linux/export.h> for a while.
They will be removed after #include <asm/export.h> directives are all
replaced with #include <linux/export.h>.
[3] Implement CONFIG_TRIM_UNUSED_KSYMS in one-pass algorithm (by a later commit)
When CONFIG_TRIM_UNUSED_KSYMS is enabled, Kbuild recursively traverses
the directory tree to determine which EXPORT_SYMBOL to trim. If an
EXPORT_SYMBOL turns out to be unused by anyone, Kbuild begins the
second traverse, where some source files are recompiled with their
EXPORT_SYMBOL() tuned into a no-op.
We can do this better now; modpost can selectively emit KSYMTAB entries
that are really used by modules.
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
2023-06-11 15:50:52 +00:00
|
|
|
|
2022-05-13 11:39:21 +00:00
|
|
|
if (!modversions)
|
|
|
|
return;
|
|
|
|
|
kbuild: link symbol CRCs at final link, removing CONFIG_MODULE_REL_CRCS
include/{linux,asm-generic}/export.h defines a weak symbol, __crc_*
as a placeholder.
Genksyms writes the version CRCs into the linker script, which will be
used for filling the __crc_* symbols. The linker script format depends
on CONFIG_MODULE_REL_CRCS. If it is enabled, __crc_* holds the offset
to the reference of CRC.
It is time to get rid of this complexity.
Now that modpost parses text files (.*.cmd) to collect all the CRCs,
it can generate C code that will be linked to the vmlinux or modules.
Generate a new C file, .vmlinux.export.c, which contains the CRCs of
symbols exported by vmlinux. It is compiled and linked to vmlinux in
scripts/link-vmlinux.sh.
Put the CRCs of symbols exported by modules into the existing *.mod.c
files. No additional build step is needed for modules. As before,
*.mod.c are compiled and linked to *.ko in scripts/Makefile.modfinal.
No linker magic is used here. The new C implementation works in the
same way, whether CONFIG_RELOCATABLE is enabled or not.
CONFIG_MODULE_REL_CRCS is no longer needed.
Previously, Kbuild invoked additional $(LD) to update the CRCs in
objects, but this step is unneeded too.
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Tested-by: Nathan Chancellor <nathan@kernel.org>
Tested-by: Nicolas Schier <nicolas@fjasle.eu>
Reviewed-by: Nicolas Schier <nicolas@fjasle.eu>
Tested-by: Sedat Dilek <sedat.dilek@gmail.com> # LLVM-14 (x86-64)
2022-05-13 11:39:22 +00:00
|
|
|
/* record CRCs for exported symbols */
|
|
|
|
buf_printf(buf, "\n");
|
2022-05-13 11:39:21 +00:00
|
|
|
list_for_each_entry(sym, &mod->exported_symbols, list) {
|
kbuild: implement CONFIG_TRIM_UNUSED_KSYMS without recursion
When CONFIG_TRIM_UNUSED_KSYMS is enabled, Kbuild recursively traverses
the directory tree to determine which EXPORT_SYMBOL to trim. If an
EXPORT_SYMBOL turns out to be unused by anyone, Kbuild begins the
second traverse, where some source files are recompiled with their
EXPORT_SYMBOL() tuned into a no-op.
Linus stated negative opinions about this slowness in commits:
- 5cf0fd591f2e ("Kbuild: disable TRIM_UNUSED_KSYMS option")
- a555bdd0c58c ("Kbuild: enable TRIM_UNUSED_KSYMS again, with some guarding")
We can do this better now. The final data structures of EXPORT_SYMBOL
are generated by the modpost stage, so modpost can selectively emit
KSYMTAB entries that are really used by modules.
Commit f73edc8951b2 ("kbuild: unify two modpost invocations") is another
ground-work to do this in a one-pass algorithm. With the list of modules,
modpost sets sym->used if it is used by a module. modpost emits KSYMTAB
only for symbols with sym->used==true.
BTW, Nicolas explained why the trimming was implemented with recursion:
https://lore.kernel.org/all/2o2rpn97-79nq-p7s2-nq5-8p83391473r@syhkavp.arg/
Actually, we never achieved that level of optimization where the chain
reaction of trimming comes into play because:
- CONFIG_LTO_CLANG cannot remove any unused symbols
- CONFIG_LD_DEAD_CODE_DATA_ELIMINATION is enabled only for vmlinux,
but not modules
If deeper trimming is required, we need to revisit this, but I guess
that is unlikely to happen.
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
2023-06-11 15:50:57 +00:00
|
|
|
if (trim_unused_exports && !sym->used)
|
|
|
|
continue;
|
|
|
|
|
modpost: fix module versioning when a symbol lacks valid CRC
Since commit 7b4537199a4a ("kbuild: link symbol CRCs at final link,
removing CONFIG_MODULE_REL_CRCS"), module versioning is broken on
some architectures. Loading a module fails with "disagrees about
version of symbol module_layout".
On such architectures (e.g. ARCH=sparc build with sparc64_defconfig),
modpost shows a warning, like follows:
WARNING: modpost: EXPORT symbol "_mcount" [vmlinux] version generation failed, symbol will not be versioned.
Is "_mcount" prototyped in <asm/asm-prototypes.h>?
Previously, it was a harmless warning (CRC check was just skipped),
but now wrong CRCs are used for comparison because invalid CRCs are
just skipped.
$ sparc64-linux-gnu-nm -n vmlinux
[snip]
0000000000c2cea0 r __ksymtab__kstrtol
0000000000c2ceb8 r __ksymtab__kstrtoul
0000000000c2ced0 r __ksymtab__local_bh_enable
0000000000c2cee8 r __ksymtab__mcount
0000000000c2cf00 r __ksymtab__printk
0000000000c2cf18 r __ksymtab__raw_read_lock
0000000000c2cf30 r __ksymtab__raw_read_lock_bh
[snip]
0000000000c53b34 D __crc__kstrtol
0000000000c53b38 D __crc__kstrtoul
0000000000c53b3c D __crc__local_bh_enable
0000000000c53b40 D __crc__printk
0000000000c53b44 D __crc__raw_read_lock
0000000000c53b48 D __crc__raw_read_lock_bh
Please notice __crc__mcount is missing here.
When the module subsystem looks up a CRC that comes after, it results
in reading out a wrong address. For example, when __crc__printk is
needed, the module subsystem reads 0xc53b44 instead of 0xc53b40.
All CRC entries must be output for correct index accessing. Invalid
CRCs will be unused, but are needed to keep the one-to-one mapping
between __ksymtab_* and __crc_*.
The best is to fix all modpost warnings, but several warnings are still
remaining on less popular architectures.
Fixes: 7b4537199a4a ("kbuild: link symbol CRCs at final link, removing CONFIG_MODULE_REL_CRCS")
Reported-by: matoro <matoro_mailinglist_kernel@matoro.tk>
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Tested-by: matoro <matoro_mailinglist_kernel@matoro.tk>
2022-08-09 14:11:17 +00:00
|
|
|
if (!sym->crc_valid)
|
2022-05-13 11:39:21 +00:00
|
|
|
warn("EXPORT symbol \"%s\" [%s%s] version generation failed, symbol will not be versioned.\n"
|
|
|
|
"Is \"%s\" prototyped in <asm/asm-prototypes.h>?\n",
|
|
|
|
sym->name, mod->name, mod->is_vmlinux ? "" : ".ko",
|
|
|
|
sym->name);
|
kbuild: link symbol CRCs at final link, removing CONFIG_MODULE_REL_CRCS
include/{linux,asm-generic}/export.h defines a weak symbol, __crc_*
as a placeholder.
Genksyms writes the version CRCs into the linker script, which will be
used for filling the __crc_* symbols. The linker script format depends
on CONFIG_MODULE_REL_CRCS. If it is enabled, __crc_* holds the offset
to the reference of CRC.
It is time to get rid of this complexity.
Now that modpost parses text files (.*.cmd) to collect all the CRCs,
it can generate C code that will be linked to the vmlinux or modules.
Generate a new C file, .vmlinux.export.c, which contains the CRCs of
symbols exported by vmlinux. It is compiled and linked to vmlinux in
scripts/link-vmlinux.sh.
Put the CRCs of symbols exported by modules into the existing *.mod.c
files. No additional build step is needed for modules. As before,
*.mod.c are compiled and linked to *.ko in scripts/Makefile.modfinal.
No linker magic is used here. The new C implementation works in the
same way, whether CONFIG_RELOCATABLE is enabled or not.
CONFIG_MODULE_REL_CRCS is no longer needed.
Previously, Kbuild invoked additional $(LD) to update the CRCs in
objects, but this step is unneeded too.
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Tested-by: Nathan Chancellor <nathan@kernel.org>
Tested-by: Nicolas Schier <nicolas@fjasle.eu>
Reviewed-by: Nicolas Schier <nicolas@fjasle.eu>
Tested-by: Sedat Dilek <sedat.dilek@gmail.com> # LLVM-14 (x86-64)
2022-05-13 11:39:22 +00:00
|
|
|
|
|
|
|
buf_printf(buf, "SYMBOL_CRC(%s, 0x%08x, \"%s\");\n",
|
|
|
|
sym->name, sym->crc, sym->is_gpl_only ? "_gpl" : "");
|
2022-05-13 11:39:21 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2006-01-28 16:19:35 +00:00
|
|
|
/**
|
|
|
|
* Record CRCs for unresolved symbols
|
|
|
|
**/
|
2020-12-01 10:34:15 +00:00
|
|
|
static void add_versions(struct buffer *b, struct module *mod)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
2022-04-24 19:07:49 +00:00
|
|
|
struct symbol *s;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
|
|
|
if (!modversions)
|
2020-12-01 10:34:15 +00:00
|
|
|
return;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
|
|
|
buf_printf(b, "\n");
|
|
|
|
buf_printf(b, "static const struct modversion_info ____versions[]\n");
|
2020-10-22 02:36:07 +00:00
|
|
|
buf_printf(b, "__used __section(\"__versions\") = {\n");
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2022-05-01 08:40:12 +00:00
|
|
|
list_for_each_entry(s, &mod->unresolved_symbols, list) {
|
2008-01-11 18:17:15 +00:00
|
|
|
if (!s->module)
|
2005-04-16 22:20:36 +00:00
|
|
|
continue;
|
|
|
|
if (!s->crc_valid) {
|
2006-01-28 15:57:26 +00:00
|
|
|
warn("\"%s\" [%s.ko] has no CRC!\n",
|
2005-04-16 22:20:36 +00:00
|
|
|
s->name, mod->name);
|
|
|
|
continue;
|
|
|
|
}
|
2015-08-08 05:46:20 +00:00
|
|
|
if (strlen(s->name) >= MODULE_NAME_LEN) {
|
modpost: rename merror() to error()
The log function names, warn(), merror(), fatal() are inconsistent.
Commit 2a11665945d5 ("kbuild: distinguish between errors and warnings
in modpost") intentionally chose merror() to avoid the conflict with
the library function error(). See man page of error(3).
But, we are already causing the conflict with warn() because it is also
a library function. See man page of warn(3). err() would be a problem
for the same reason.
The common technique to work around name conflicts is to use macros.
For example:
/* in a header */
#define error(fmt, ...) __error(fmt, ##__VA_ARGS__)
#define warn(fmt, ...) __warn(fmt, ##__VA_ARGS__)
/* function definition */
void __error(const char *fmt, ...)
{
<our implementation>
}
void __warn(const char *fmt, ...)
{
<our implementation>
}
In this way, we can implement our own warn() and error(), still we can
include <error.h> and <err.h> with no problem.
And, commit 93c95e526a4e ("modpost: rework and consolidate logging
interface") already did that.
Since the log functions are all macros, we can use error() without
causing "conflicting types" errors.
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
2020-12-01 10:34:14 +00:00
|
|
|
error("too long symbol \"%s\" [%s.ko]\n",
|
|
|
|
s->name, mod->name);
|
2015-08-08 05:46:20 +00:00
|
|
|
break;
|
|
|
|
}
|
2018-05-09 07:23:45 +00:00
|
|
|
buf_printf(b, "\t{ %#8x, \"%s\" },\n",
|
2013-03-18 09:08:56 +00:00
|
|
|
s->crc, s->name);
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
buf_printf(b, "};\n");
|
|
|
|
}
|
|
|
|
|
2018-11-23 07:57:21 +00:00
|
|
|
static void add_depends(struct buffer *b, struct module *mod)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
|
|
|
struct symbol *s;
|
|
|
|
int first = 1;
|
|
|
|
|
2018-11-23 07:57:21 +00:00
|
|
|
/* Clear ->seen flag of modules that own symbols needed by this. */
|
2022-05-01 08:40:12 +00:00
|
|
|
list_for_each_entry(s, &mod->unresolved_symbols, list) {
|
2018-11-23 07:57:21 +00:00
|
|
|
if (s->module)
|
2020-06-01 05:57:26 +00:00
|
|
|
s->module->seen = s->module->is_vmlinux;
|
2022-05-01 08:40:12 +00:00
|
|
|
}
|
2005-04-16 22:20:36 +00:00
|
|
|
|
|
|
|
buf_printf(b, "\n");
|
2019-09-09 11:34:22 +00:00
|
|
|
buf_printf(b, "MODULE_INFO(depends, \"");
|
2022-05-01 08:40:12 +00:00
|
|
|
list_for_each_entry(s, &mod->unresolved_symbols, list) {
|
2007-02-26 18:46:52 +00:00
|
|
|
const char *p;
|
2005-04-16 22:20:36 +00:00
|
|
|
if (!s->module)
|
|
|
|
continue;
|
|
|
|
|
|
|
|
if (s->module->seen)
|
|
|
|
continue;
|
|
|
|
|
2022-05-01 08:40:07 +00:00
|
|
|
s->module->seen = true;
|
2008-01-11 18:17:15 +00:00
|
|
|
p = strrchr(s->module->name, '/');
|
|
|
|
if (p)
|
2007-02-26 18:46:52 +00:00
|
|
|
p++;
|
|
|
|
else
|
|
|
|
p = s->module->name;
|
|
|
|
buf_printf(b, "%s%s", first ? "" : ",", p);
|
2005-04-16 22:20:36 +00:00
|
|
|
first = 0;
|
|
|
|
}
|
2019-09-09 11:34:22 +00:00
|
|
|
buf_printf(b, "\");\n");
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
|
2006-01-28 16:19:35 +00:00
|
|
|
static void add_srcversion(struct buffer *b, struct module *mod)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
|
|
|
if (mod->srcversion[0]) {
|
|
|
|
buf_printf(b, "\n");
|
|
|
|
buf_printf(b, "MODULE_INFO(srcversion, \"%s\");\n",
|
|
|
|
mod->srcversion);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2020-06-01 05:57:12 +00:00
|
|
|
static void write_buf(struct buffer *b, const char *fname)
|
|
|
|
{
|
|
|
|
FILE *file;
|
|
|
|
|
2022-04-24 19:07:46 +00:00
|
|
|
if (error_occurred)
|
|
|
|
return;
|
|
|
|
|
2020-06-01 05:57:12 +00:00
|
|
|
file = fopen(fname, "w");
|
|
|
|
if (!file) {
|
|
|
|
perror(fname);
|
|
|
|
exit(1);
|
|
|
|
}
|
|
|
|
if (fwrite(b->p, 1, b->pos, file) != b->pos) {
|
|
|
|
perror(fname);
|
|
|
|
exit(1);
|
|
|
|
}
|
|
|
|
if (fclose(file) != 0) {
|
|
|
|
perror(fname);
|
|
|
|
exit(1);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2006-01-28 16:19:35 +00:00
|
|
|
static void write_if_changed(struct buffer *b, const char *fname)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
|
|
|
char *tmp;
|
|
|
|
FILE *file;
|
|
|
|
struct stat st;
|
|
|
|
|
|
|
|
file = fopen(fname, "r");
|
|
|
|
if (!file)
|
|
|
|
goto write;
|
|
|
|
|
|
|
|
if (fstat(fileno(file), &st) < 0)
|
|
|
|
goto close_write;
|
|
|
|
|
|
|
|
if (st.st_size != b->pos)
|
|
|
|
goto close_write;
|
|
|
|
|
|
|
|
tmp = NOFAIL(malloc(b->pos));
|
|
|
|
if (fread(tmp, 1, b->pos, file) != b->pos)
|
|
|
|
goto free_write;
|
|
|
|
|
|
|
|
if (memcmp(tmp, b->p, b->pos) != 0)
|
|
|
|
goto free_write;
|
|
|
|
|
|
|
|
free(tmp);
|
|
|
|
fclose(file);
|
|
|
|
return;
|
|
|
|
|
|
|
|
free_write:
|
|
|
|
free(tmp);
|
|
|
|
close_write:
|
|
|
|
fclose(file);
|
|
|
|
write:
|
2020-06-01 05:57:12 +00:00
|
|
|
write_buf(b, fname);
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
|
kbuild: link symbol CRCs at final link, removing CONFIG_MODULE_REL_CRCS
include/{linux,asm-generic}/export.h defines a weak symbol, __crc_*
as a placeholder.
Genksyms writes the version CRCs into the linker script, which will be
used for filling the __crc_* symbols. The linker script format depends
on CONFIG_MODULE_REL_CRCS. If it is enabled, __crc_* holds the offset
to the reference of CRC.
It is time to get rid of this complexity.
Now that modpost parses text files (.*.cmd) to collect all the CRCs,
it can generate C code that will be linked to the vmlinux or modules.
Generate a new C file, .vmlinux.export.c, which contains the CRCs of
symbols exported by vmlinux. It is compiled and linked to vmlinux in
scripts/link-vmlinux.sh.
Put the CRCs of symbols exported by modules into the existing *.mod.c
files. No additional build step is needed for modules. As before,
*.mod.c are compiled and linked to *.ko in scripts/Makefile.modfinal.
No linker magic is used here. The new C implementation works in the
same way, whether CONFIG_RELOCATABLE is enabled or not.
CONFIG_MODULE_REL_CRCS is no longer needed.
Previously, Kbuild invoked additional $(LD) to update the CRCs in
objects, but this step is unneeded too.
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Tested-by: Nathan Chancellor <nathan@kernel.org>
Tested-by: Nicolas Schier <nicolas@fjasle.eu>
Reviewed-by: Nicolas Schier <nicolas@fjasle.eu>
Tested-by: Sedat Dilek <sedat.dilek@gmail.com> # LLVM-14 (x86-64)
2022-05-13 11:39:22 +00:00
|
|
|
static void write_vmlinux_export_c_file(struct module *mod)
|
|
|
|
{
|
|
|
|
struct buffer buf = { };
|
|
|
|
|
|
|
|
buf_printf(&buf,
|
|
|
|
"#include <linux/export-internal.h>\n");
|
|
|
|
|
|
|
|
add_exported_symbols(&buf, mod);
|
|
|
|
write_if_changed(&buf, ".vmlinux.export.c");
|
|
|
|
free(buf.p);
|
|
|
|
}
|
|
|
|
|
2022-05-05 07:22:33 +00:00
|
|
|
/* do sanity checks, and generate *.mod.c file */
|
|
|
|
static void write_mod_c_file(struct module *mod)
|
|
|
|
{
|
|
|
|
struct buffer buf = { };
|
|
|
|
char fname[PATH_MAX];
|
|
|
|
int ret;
|
|
|
|
|
|
|
|
add_header(&buf, mod);
|
kbuild: link symbol CRCs at final link, removing CONFIG_MODULE_REL_CRCS
include/{linux,asm-generic}/export.h defines a weak symbol, __crc_*
as a placeholder.
Genksyms writes the version CRCs into the linker script, which will be
used for filling the __crc_* symbols. The linker script format depends
on CONFIG_MODULE_REL_CRCS. If it is enabled, __crc_* holds the offset
to the reference of CRC.
It is time to get rid of this complexity.
Now that modpost parses text files (.*.cmd) to collect all the CRCs,
it can generate C code that will be linked to the vmlinux or modules.
Generate a new C file, .vmlinux.export.c, which contains the CRCs of
symbols exported by vmlinux. It is compiled and linked to vmlinux in
scripts/link-vmlinux.sh.
Put the CRCs of symbols exported by modules into the existing *.mod.c
files. No additional build step is needed for modules. As before,
*.mod.c are compiled and linked to *.ko in scripts/Makefile.modfinal.
No linker magic is used here. The new C implementation works in the
same way, whether CONFIG_RELOCATABLE is enabled or not.
CONFIG_MODULE_REL_CRCS is no longer needed.
Previously, Kbuild invoked additional $(LD) to update the CRCs in
objects, but this step is unneeded too.
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Tested-by: Nathan Chancellor <nathan@kernel.org>
Tested-by: Nicolas Schier <nicolas@fjasle.eu>
Reviewed-by: Nicolas Schier <nicolas@fjasle.eu>
Tested-by: Sedat Dilek <sedat.dilek@gmail.com> # LLVM-14 (x86-64)
2022-05-13 11:39:22 +00:00
|
|
|
add_exported_symbols(&buf, mod);
|
2022-05-05 07:22:33 +00:00
|
|
|
add_versions(&buf, mod);
|
|
|
|
add_depends(&buf, mod);
|
|
|
|
add_moddevtable(&buf, mod);
|
|
|
|
add_srcversion(&buf, mod);
|
|
|
|
|
|
|
|
ret = snprintf(fname, sizeof(fname), "%s.mod.c", mod->name);
|
|
|
|
if (ret >= sizeof(fname)) {
|
|
|
|
error("%s: too long path was truncated\n", fname);
|
|
|
|
goto free;
|
|
|
|
}
|
|
|
|
|
|
|
|
write_if_changed(&buf, fname);
|
|
|
|
|
|
|
|
free:
|
|
|
|
free(buf.p);
|
|
|
|
}
|
|
|
|
|
2006-06-09 05:12:53 +00:00
|
|
|
/* parse Module.symvers file. line format:
|
2020-03-11 17:01:20 +00:00
|
|
|
* 0x12345678<tab>symbol<tab>module<tab>export<tab>namespace
|
2006-06-09 05:12:53 +00:00
|
|
|
**/
|
2020-06-01 05:57:05 +00:00
|
|
|
static void read_dump(const char *fname)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
2020-06-01 05:57:20 +00:00
|
|
|
char *buf, *pos, *line;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2020-06-01 05:57:20 +00:00
|
|
|
buf = read_text_file(fname);
|
|
|
|
if (!buf)
|
2005-04-16 22:20:36 +00:00
|
|
|
/* No symbol versions, silently ignore */
|
|
|
|
return;
|
|
|
|
|
2020-06-01 05:57:20 +00:00
|
|
|
pos = buf;
|
|
|
|
|
|
|
|
while ((line = get_line(&pos))) {
|
2020-03-11 17:01:20 +00:00
|
|
|
char *symname, *namespace, *modname, *d, *export;
|
2005-04-16 22:20:36 +00:00
|
|
|
unsigned int crc;
|
|
|
|
struct module *mod;
|
2006-01-28 21:15:55 +00:00
|
|
|
struct symbol *s;
|
2022-05-08 19:06:19 +00:00
|
|
|
bool gpl_only;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
|
|
|
if (!(symname = strchr(line, '\t')))
|
|
|
|
goto fail;
|
|
|
|
*symname++ = '\0';
|
2020-03-11 17:01:20 +00:00
|
|
|
if (!(modname = strchr(symname, '\t')))
|
2005-04-16 22:20:36 +00:00
|
|
|
goto fail;
|
|
|
|
*modname++ = '\0';
|
2020-03-11 17:01:20 +00:00
|
|
|
if (!(export = strchr(modname, '\t')))
|
|
|
|
goto fail;
|
|
|
|
*export++ = '\0';
|
|
|
|
if (!(namespace = strchr(export, '\t')))
|
|
|
|
goto fail;
|
|
|
|
*namespace++ = '\0';
|
|
|
|
|
2005-04-16 22:20:36 +00:00
|
|
|
crc = strtoul(line, &d, 16);
|
|
|
|
if (*symname == '\0' || *modname == '\0' || *d != '\0')
|
|
|
|
goto fail;
|
2022-05-08 19:06:19 +00:00
|
|
|
|
|
|
|
if (!strcmp(export, "EXPORT_SYMBOL_GPL")) {
|
|
|
|
gpl_only = true;
|
|
|
|
} else if (!strcmp(export, "EXPORT_SYMBOL")) {
|
|
|
|
gpl_only = false;
|
|
|
|
} else {
|
|
|
|
error("%s: unknown license %s. skip", symname, export);
|
|
|
|
continue;
|
|
|
|
}
|
|
|
|
|
2008-01-11 18:17:15 +00:00
|
|
|
mod = find_module(modname);
|
|
|
|
if (!mod) {
|
2022-05-30 09:01:38 +00:00
|
|
|
mod = new_module(modname, strlen(modname));
|
2022-05-01 08:40:07 +00:00
|
|
|
mod->from_dump = true;
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
2023-06-11 15:50:55 +00:00
|
|
|
s = sym_add_exported(symname, mod, gpl_only, namespace);
|
2022-05-13 11:39:21 +00:00
|
|
|
sym_set_crc(s, crc);
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
2020-06-01 05:57:20 +00:00
|
|
|
free(buf);
|
2005-04-16 22:20:36 +00:00
|
|
|
return;
|
|
|
|
fail:
|
2020-06-01 05:57:20 +00:00
|
|
|
free(buf);
|
2005-04-16 22:20:36 +00:00
|
|
|
fatal("parse error in symbol dump file\n");
|
|
|
|
}
|
|
|
|
|
2006-01-28 16:19:35 +00:00
|
|
|
static void write_dump(const char *fname)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
|
|
|
struct buffer buf = { };
|
2022-05-01 08:40:15 +00:00
|
|
|
struct module *mod;
|
|
|
|
struct symbol *sym;
|
|
|
|
|
|
|
|
list_for_each_entry(mod, &modules, list) {
|
|
|
|
if (mod->from_dump)
|
|
|
|
continue;
|
|
|
|
list_for_each_entry(sym, &mod->exported_symbols, list) {
|
kbuild: implement CONFIG_TRIM_UNUSED_KSYMS without recursion
When CONFIG_TRIM_UNUSED_KSYMS is enabled, Kbuild recursively traverses
the directory tree to determine which EXPORT_SYMBOL to trim. If an
EXPORT_SYMBOL turns out to be unused by anyone, Kbuild begins the
second traverse, where some source files are recompiled with their
EXPORT_SYMBOL() tuned into a no-op.
Linus stated negative opinions about this slowness in commits:
- 5cf0fd591f2e ("Kbuild: disable TRIM_UNUSED_KSYMS option")
- a555bdd0c58c ("Kbuild: enable TRIM_UNUSED_KSYMS again, with some guarding")
We can do this better now. The final data structures of EXPORT_SYMBOL
are generated by the modpost stage, so modpost can selectively emit
KSYMTAB entries that are really used by modules.
Commit f73edc8951b2 ("kbuild: unify two modpost invocations") is another
ground-work to do this in a one-pass algorithm. With the list of modules,
modpost sets sym->used if it is used by a module. modpost emits KSYMTAB
only for symbols with sym->used==true.
BTW, Nicolas explained why the trimming was implemented with recursion:
https://lore.kernel.org/all/2o2rpn97-79nq-p7s2-nq5-8p83391473r@syhkavp.arg/
Actually, we never achieved that level of optimization where the chain
reaction of trimming comes into play because:
- CONFIG_LTO_CLANG cannot remove any unused symbols
- CONFIG_LD_DEAD_CODE_DATA_ELIMINATION is enabled only for vmlinux,
but not modules
If deeper trimming is required, we need to revisit this, but I guess
that is unlikely to happen.
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
2023-06-11 15:50:57 +00:00
|
|
|
if (trim_unused_exports && !sym->used)
|
|
|
|
continue;
|
|
|
|
|
2022-05-08 19:06:19 +00:00
|
|
|
buf_printf(&buf, "0x%08x\t%s\t%s\tEXPORT_SYMBOL%s\t%s\n",
|
2022-05-01 08:40:15 +00:00
|
|
|
sym->crc, sym->name, mod->name,
|
2022-05-08 19:06:19 +00:00
|
|
|
sym->is_gpl_only ? "_GPL" : "",
|
2023-06-11 15:50:56 +00:00
|
|
|
sym->namespace);
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
}
|
2020-06-01 05:57:12 +00:00
|
|
|
write_buf(&buf, fname);
|
2016-08-02 19:43:01 +00:00
|
|
|
free(buf.p);
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
|
2019-10-29 12:38:07 +00:00
|
|
|
static void write_namespace_deps_files(const char *fname)
|
2019-09-06 10:32:31 +00:00
|
|
|
{
|
|
|
|
struct module *mod;
|
|
|
|
struct namespace_list *ns;
|
|
|
|
struct buffer ns_deps_buf = {};
|
|
|
|
|
2022-05-01 08:40:10 +00:00
|
|
|
list_for_each_entry(mod, &modules, list) {
|
2019-09-06 10:32:31 +00:00
|
|
|
|
2022-05-01 08:40:14 +00:00
|
|
|
if (mod->from_dump || list_empty(&mod->missing_namespaces))
|
2019-09-06 10:32:31 +00:00
|
|
|
continue;
|
|
|
|
|
2019-10-29 12:38:07 +00:00
|
|
|
buf_printf(&ns_deps_buf, "%s.ko:", mod->name);
|
2019-09-06 10:32:31 +00:00
|
|
|
|
2022-05-01 08:40:14 +00:00
|
|
|
list_for_each_entry(ns, &mod->missing_namespaces, list)
|
2019-10-29 12:38:07 +00:00
|
|
|
buf_printf(&ns_deps_buf, " %s", ns->namespace);
|
2019-09-06 10:32:31 +00:00
|
|
|
|
2019-10-29 12:38:07 +00:00
|
|
|
buf_printf(&ns_deps_buf, "\n");
|
2019-09-06 10:32:31 +00:00
|
|
|
}
|
2019-11-06 15:19:59 +00:00
|
|
|
|
2019-10-29 12:38:07 +00:00
|
|
|
write_if_changed(&ns_deps_buf, fname);
|
2019-11-06 15:19:59 +00:00
|
|
|
free(ns_deps_buf.p);
|
2019-09-06 10:32:31 +00:00
|
|
|
}
|
|
|
|
|
2020-06-01 05:57:07 +00:00
|
|
|
struct dump_list {
|
2022-05-01 08:40:13 +00:00
|
|
|
struct list_head list;
|
2008-02-28 08:40:52 +00:00
|
|
|
const char *file;
|
|
|
|
};
|
|
|
|
|
2006-01-28 16:19:35 +00:00
|
|
|
int main(int argc, char **argv)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
|
|
|
struct module *mod;
|
2019-10-29 12:38:07 +00:00
|
|
|
char *missing_namespace_deps = NULL;
|
kbuild: implement CONFIG_TRIM_UNUSED_KSYMS without recursion
When CONFIG_TRIM_UNUSED_KSYMS is enabled, Kbuild recursively traverses
the directory tree to determine which EXPORT_SYMBOL to trim. If an
EXPORT_SYMBOL turns out to be unused by anyone, Kbuild begins the
second traverse, where some source files are recompiled with their
EXPORT_SYMBOL() tuned into a no-op.
Linus stated negative opinions about this slowness in commits:
- 5cf0fd591f2e ("Kbuild: disable TRIM_UNUSED_KSYMS option")
- a555bdd0c58c ("Kbuild: enable TRIM_UNUSED_KSYMS again, with some guarding")
We can do this better now. The final data structures of EXPORT_SYMBOL
are generated by the modpost stage, so modpost can selectively emit
KSYMTAB entries that are really used by modules.
Commit f73edc8951b2 ("kbuild: unify two modpost invocations") is another
ground-work to do this in a one-pass algorithm. With the list of modules,
modpost sets sym->used if it is used by a module. modpost emits KSYMTAB
only for symbols with sym->used==true.
BTW, Nicolas explained why the trimming was implemented with recursion:
https://lore.kernel.org/all/2o2rpn97-79nq-p7s2-nq5-8p83391473r@syhkavp.arg/
Actually, we never achieved that level of optimization where the chain
reaction of trimming comes into play because:
- CONFIG_LTO_CLANG cannot remove any unused symbols
- CONFIG_LD_DEAD_CODE_DATA_ELIMINATION is enabled only for vmlinux,
but not modules
If deeper trimming is required, we need to revisit this, but I guess
that is unlikely to happen.
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
2023-06-11 15:50:57 +00:00
|
|
|
char *unused_exports_white_list = NULL;
|
2013-04-04 07:07:38 +00:00
|
|
|
char *dump_write = NULL, *files_source = NULL;
|
2005-04-16 22:20:36 +00:00
|
|
|
int opt;
|
2022-05-01 08:40:13 +00:00
|
|
|
LIST_HEAD(dump_lists);
|
|
|
|
struct dump_list *dl, *dl2;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2023-07-16 10:15:54 +00:00
|
|
|
while ((opt = getopt(argc, argv, "ei:MmnT:to:au:WwENd:")) != -1) {
|
2008-01-11 18:17:15 +00:00
|
|
|
switch (opt) {
|
2008-02-28 08:40:52 +00:00
|
|
|
case 'e':
|
2022-05-01 08:40:07 +00:00
|
|
|
external_module = true;
|
2020-06-01 05:57:08 +00:00
|
|
|
break;
|
|
|
|
case 'i':
|
2022-05-01 08:40:13 +00:00
|
|
|
dl = NOFAIL(malloc(sizeof(*dl)));
|
|
|
|
dl->file = optarg;
|
|
|
|
list_add_tail(&dl->list, &dump_lists);
|
2008-02-28 08:40:52 +00:00
|
|
|
break;
|
2023-07-16 10:15:54 +00:00
|
|
|
case 'M':
|
|
|
|
module_enabled = true;
|
|
|
|
break;
|
2008-01-11 18:17:15 +00:00
|
|
|
case 'm':
|
2022-05-01 08:40:07 +00:00
|
|
|
modversions = true;
|
2008-01-11 18:17:15 +00:00
|
|
|
break;
|
2013-09-23 05:53:54 +00:00
|
|
|
case 'n':
|
2022-05-01 08:40:07 +00:00
|
|
|
ignore_missing_files = true;
|
2013-09-23 05:53:54 +00:00
|
|
|
break;
|
2008-01-11 18:17:15 +00:00
|
|
|
case 'o':
|
|
|
|
dump_write = optarg;
|
|
|
|
break;
|
|
|
|
case 'a':
|
2022-05-01 08:40:07 +00:00
|
|
|
all_versions = true;
|
2008-01-11 18:17:15 +00:00
|
|
|
break;
|
2013-04-04 07:07:38 +00:00
|
|
|
case 'T':
|
|
|
|
files_source = optarg;
|
|
|
|
break;
|
kbuild: implement CONFIG_TRIM_UNUSED_KSYMS without recursion
When CONFIG_TRIM_UNUSED_KSYMS is enabled, Kbuild recursively traverses
the directory tree to determine which EXPORT_SYMBOL to trim. If an
EXPORT_SYMBOL turns out to be unused by anyone, Kbuild begins the
second traverse, where some source files are recompiled with their
EXPORT_SYMBOL() tuned into a no-op.
Linus stated negative opinions about this slowness in commits:
- 5cf0fd591f2e ("Kbuild: disable TRIM_UNUSED_KSYMS option")
- a555bdd0c58c ("Kbuild: enable TRIM_UNUSED_KSYMS again, with some guarding")
We can do this better now. The final data structures of EXPORT_SYMBOL
are generated by the modpost stage, so modpost can selectively emit
KSYMTAB entries that are really used by modules.
Commit f73edc8951b2 ("kbuild: unify two modpost invocations") is another
ground-work to do this in a one-pass algorithm. With the list of modules,
modpost sets sym->used if it is used by a module. modpost emits KSYMTAB
only for symbols with sym->used==true.
BTW, Nicolas explained why the trimming was implemented with recursion:
https://lore.kernel.org/all/2o2rpn97-79nq-p7s2-nq5-8p83391473r@syhkavp.arg/
Actually, we never achieved that level of optimization where the chain
reaction of trimming comes into play because:
- CONFIG_LTO_CLANG cannot remove any unused symbols
- CONFIG_LD_DEAD_CODE_DATA_ELIMINATION is enabled only for vmlinux,
but not modules
If deeper trimming is required, we need to revisit this, but I guess
that is unlikely to happen.
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
2023-06-11 15:50:57 +00:00
|
|
|
case 't':
|
|
|
|
trim_unused_exports = true;
|
|
|
|
break;
|
|
|
|
case 'u':
|
|
|
|
unused_exports_white_list = optarg;
|
|
|
|
break;
|
2023-06-06 09:41:59 +00:00
|
|
|
case 'W':
|
|
|
|
extra_warn = true;
|
|
|
|
break;
|
2008-01-11 18:17:15 +00:00
|
|
|
case 'w':
|
2022-05-01 08:40:07 +00:00
|
|
|
warn_unresolved = true;
|
2008-01-11 18:17:15 +00:00
|
|
|
break;
|
2015-10-05 23:14:42 +00:00
|
|
|
case 'E':
|
2020-12-01 10:34:18 +00:00
|
|
|
sec_mismatch_warn_only = false;
|
2015-10-05 23:14:42 +00:00
|
|
|
break;
|
2020-03-06 16:02:06 +00:00
|
|
|
case 'N':
|
2022-05-01 08:40:07 +00:00
|
|
|
allow_missing_ns_imports = true;
|
2020-03-06 16:02:06 +00:00
|
|
|
break;
|
2019-09-06 10:32:31 +00:00
|
|
|
case 'd':
|
2019-10-29 12:38:07 +00:00
|
|
|
missing_namespace_deps = optarg;
|
2019-09-06 10:32:31 +00:00
|
|
|
break;
|
2008-01-11 18:17:15 +00:00
|
|
|
default:
|
|
|
|
exit(1);
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2022-05-01 08:40:13 +00:00
|
|
|
list_for_each_entry_safe(dl, dl2, &dump_lists, list) {
|
|
|
|
read_dump(dl->file);
|
|
|
|
list_del(&dl->list);
|
|
|
|
free(dl);
|
2008-02-28 08:40:52 +00:00
|
|
|
}
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2008-01-11 18:17:15 +00:00
|
|
|
while (optind < argc)
|
2005-04-16 22:20:36 +00:00
|
|
|
read_symbols(argv[optind++]);
|
|
|
|
|
2013-04-04 07:07:38 +00:00
|
|
|
if (files_source)
|
|
|
|
read_symbols_from_files(files_source);
|
|
|
|
|
kbuild: implement CONFIG_TRIM_UNUSED_KSYMS without recursion
When CONFIG_TRIM_UNUSED_KSYMS is enabled, Kbuild recursively traverses
the directory tree to determine which EXPORT_SYMBOL to trim. If an
EXPORT_SYMBOL turns out to be unused by anyone, Kbuild begins the
second traverse, where some source files are recompiled with their
EXPORT_SYMBOL() tuned into a no-op.
Linus stated negative opinions about this slowness in commits:
- 5cf0fd591f2e ("Kbuild: disable TRIM_UNUSED_KSYMS option")
- a555bdd0c58c ("Kbuild: enable TRIM_UNUSED_KSYMS again, with some guarding")
We can do this better now. The final data structures of EXPORT_SYMBOL
are generated by the modpost stage, so modpost can selectively emit
KSYMTAB entries that are really used by modules.
Commit f73edc8951b2 ("kbuild: unify two modpost invocations") is another
ground-work to do this in a one-pass algorithm. With the list of modules,
modpost sets sym->used if it is used by a module. modpost emits KSYMTAB
only for symbols with sym->used==true.
BTW, Nicolas explained why the trimming was implemented with recursion:
https://lore.kernel.org/all/2o2rpn97-79nq-p7s2-nq5-8p83391473r@syhkavp.arg/
Actually, we never achieved that level of optimization where the chain
reaction of trimming comes into play because:
- CONFIG_LTO_CLANG cannot remove any unused symbols
- CONFIG_LD_DEAD_CODE_DATA_ELIMINATION is enabled only for vmlinux,
but not modules
If deeper trimming is required, we need to revisit this, but I guess
that is unlikely to happen.
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
2023-06-11 15:50:57 +00:00
|
|
|
list_for_each_entry(mod, &modules, list) {
|
|
|
|
if (mod->from_dump || mod->is_vmlinux)
|
|
|
|
continue;
|
|
|
|
|
|
|
|
check_modname_len(mod);
|
|
|
|
check_exports(mod);
|
|
|
|
}
|
|
|
|
|
|
|
|
if (unused_exports_white_list)
|
|
|
|
handle_white_list_exports(unused_exports_white_list);
|
|
|
|
|
2022-05-01 08:40:10 +00:00
|
|
|
list_for_each_entry(mod, &modules, list) {
|
2022-05-05 07:22:33 +00:00
|
|
|
if (mod->from_dump)
|
2022-04-24 19:07:45 +00:00
|
|
|
continue;
|
|
|
|
|
kbuild: link symbol CRCs at final link, removing CONFIG_MODULE_REL_CRCS
include/{linux,asm-generic}/export.h defines a weak symbol, __crc_*
as a placeholder.
Genksyms writes the version CRCs into the linker script, which will be
used for filling the __crc_* symbols. The linker script format depends
on CONFIG_MODULE_REL_CRCS. If it is enabled, __crc_* holds the offset
to the reference of CRC.
It is time to get rid of this complexity.
Now that modpost parses text files (.*.cmd) to collect all the CRCs,
it can generate C code that will be linked to the vmlinux or modules.
Generate a new C file, .vmlinux.export.c, which contains the CRCs of
symbols exported by vmlinux. It is compiled and linked to vmlinux in
scripts/link-vmlinux.sh.
Put the CRCs of symbols exported by modules into the existing *.mod.c
files. No additional build step is needed for modules. As before,
*.mod.c are compiled and linked to *.ko in scripts/Makefile.modfinal.
No linker magic is used here. The new C implementation works in the
same way, whether CONFIG_RELOCATABLE is enabled or not.
CONFIG_MODULE_REL_CRCS is no longer needed.
Previously, Kbuild invoked additional $(LD) to update the CRCs in
objects, but this step is unneeded too.
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Tested-by: Nathan Chancellor <nathan@kernel.org>
Tested-by: Nicolas Schier <nicolas@fjasle.eu>
Reviewed-by: Nicolas Schier <nicolas@fjasle.eu>
Tested-by: Sedat Dilek <sedat.dilek@gmail.com> # LLVM-14 (x86-64)
2022-05-13 11:39:22 +00:00
|
|
|
if (mod->is_vmlinux)
|
|
|
|
write_vmlinux_export_c_file(mod);
|
|
|
|
else
|
2022-05-05 07:22:33 +00:00
|
|
|
write_mod_c_file(mod);
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
2019-09-06 10:32:31 +00:00
|
|
|
|
2019-10-29 12:38:07 +00:00
|
|
|
if (missing_namespace_deps)
|
|
|
|
write_namespace_deps_files(missing_namespace_deps);
|
2019-09-06 10:32:31 +00:00
|
|
|
|
2005-04-16 22:20:36 +00:00
|
|
|
if (dump_write)
|
|
|
|
write_dump(dump_write);
|
2020-12-01 10:34:18 +00:00
|
|
|
if (sec_mismatch_count && !sec_mismatch_warn_only)
|
|
|
|
error("Section mismatches detected.\n"
|
2019-02-01 04:50:45 +00:00
|
|
|
"Set CONFIG_SECTION_MISMATCH_WARN_ONLY=y to allow them.\n");
|
2019-08-01 06:06:57 +00:00
|
|
|
|
kbuild: fix false-positive modpost warning when all symbols are trimmed
Nathan reports that the mips defconfig emits the following warning:
WARNING: modpost: Symbol info of vmlinux is missing. Unresolved symbol check will be entirely skipped.
This false-positive happens when CONFIG_TRIM_UNUSED_KSYMS is enabled,
but no CONFIG option is set to 'm'.
Commit a0590473c5e6 ("nfs: fix PNFS_FLEXFILE_LAYOUT Kconfig default")
turned the last 'm' into 'y' for the mips defconfig, and uncovered
this issue.
In this case, the module feature itself is enabled, but we have no
module to build. As a result, CONFIG_TRIM_UNUSED_KSYMS drops all the
instances of EXPORT_SYMBOL. Then, modpost wrongly assumes vmlinux is
missing because vmlinux.symvers is empty. (As another false-positive
case, you can create a module that does not use any symbol of vmlinux).
The current behavior is to entirely suppress the unresolved symbol
warnings when vmlinux is missing just because there are too many.
I found the origin of this code in the historical git tree. [1]
If this is a matter of noisiness, I think modpost can display the
first 10 warnings, and the number of suppressed warnings at the end.
You will get a bit noisier logs when you run 'make modules' without
vmlinux, but such warnings are better to show because you never know
the resulting modules are actually loadable or not.
This commit changes the following:
- If any of input *.symver files is missing, pass -w option to let
the module build keep going with warnings instead of errors.
- If there are too many (10+) unresolved symbol warnings, show only
the first 10, and also the number of suppressed warnings.
[1]: https://git.kernel.org/pub/scm/linux/kernel/git/history/history.git/commit/?id=1cc0e0529569bf6a94f6d49770aa6d4b599d2c46
Reported-by: Nathan Chancellor <nathan@kernel.org>
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
2021-03-25 18:54:11 +00:00
|
|
|
if (nr_unresolved > MAX_UNRESOLVED_REPORTS)
|
|
|
|
warn("suppressed %u unresolved symbol warnings because there were too many)\n",
|
|
|
|
nr_unresolved - MAX_UNRESOLVED_REPORTS);
|
|
|
|
|
2020-12-01 10:34:15 +00:00
|
|
|
return error_occurred ? 1 : 0;
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|