2016-12-02 08:28:44 +00:00
|
|
|
/*
|
|
|
|
* Copyright (c) 2016 Avago Technologies. All rights reserved.
|
|
|
|
*
|
|
|
|
* This program is free software; you can redistribute it and/or modify
|
|
|
|
* it under the terms of version 2 of the GNU General Public License as
|
|
|
|
* published by the Free Software Foundation.
|
|
|
|
*
|
|
|
|
* This program is distributed in the hope that it will be useful.
|
|
|
|
* ALL EXPRESS OR IMPLIED CONDITIONS, REPRESENTATIONS AND WARRANTIES,
|
|
|
|
* INCLUDING ANY IMPLIED WARRANTY OF MERCHANTABILITY, FITNESS FOR A
|
|
|
|
* PARTICULAR PURPOSE, OR NON-INFRINGEMENT, ARE DISCLAIMED, EXCEPT TO
|
|
|
|
* THE EXTENT THAT SUCH DISCLAIMERS ARE HELD TO BE LEGALLY INVALID.
|
|
|
|
* See the GNU General Public License for more details, a copy of which
|
|
|
|
* can be found in the file COPYING included with this package
|
|
|
|
*/
|
|
|
|
#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
|
|
|
|
#include <linux/module.h>
|
|
|
|
#include <linux/parser.h>
|
|
|
|
#include <uapi/scsi/fc/fc_fs.h>
|
|
|
|
|
|
|
|
#include "../host/nvme.h"
|
|
|
|
#include "../target/nvmet.h"
|
|
|
|
#include <linux/nvme-fc-driver.h>
|
|
|
|
#include <linux/nvme-fc.h>
|
|
|
|
|
|
|
|
|
|
|
|
enum {
|
|
|
|
NVMF_OPT_ERR = 0,
|
|
|
|
NVMF_OPT_WWNN = 1 << 0,
|
|
|
|
NVMF_OPT_WWPN = 1 << 1,
|
|
|
|
NVMF_OPT_ROLES = 1 << 2,
|
|
|
|
NVMF_OPT_FCADDR = 1 << 3,
|
|
|
|
NVMF_OPT_LPWWNN = 1 << 4,
|
|
|
|
NVMF_OPT_LPWWPN = 1 << 5,
|
|
|
|
};
|
|
|
|
|
|
|
|
struct fcloop_ctrl_options {
|
|
|
|
int mask;
|
|
|
|
u64 wwnn;
|
|
|
|
u64 wwpn;
|
|
|
|
u32 roles;
|
|
|
|
u32 fcaddr;
|
|
|
|
u64 lpwwnn;
|
|
|
|
u64 lpwwpn;
|
|
|
|
};
|
|
|
|
|
|
|
|
static const match_table_t opt_tokens = {
|
|
|
|
{ NVMF_OPT_WWNN, "wwnn=%s" },
|
|
|
|
{ NVMF_OPT_WWPN, "wwpn=%s" },
|
|
|
|
{ NVMF_OPT_ROLES, "roles=%d" },
|
|
|
|
{ NVMF_OPT_FCADDR, "fcaddr=%x" },
|
|
|
|
{ NVMF_OPT_LPWWNN, "lpwwnn=%s" },
|
|
|
|
{ NVMF_OPT_LPWWPN, "lpwwpn=%s" },
|
|
|
|
{ NVMF_OPT_ERR, NULL }
|
|
|
|
};
|
|
|
|
|
|
|
|
static int
|
|
|
|
fcloop_parse_options(struct fcloop_ctrl_options *opts,
|
|
|
|
const char *buf)
|
|
|
|
{
|
|
|
|
substring_t args[MAX_OPT_ARGS];
|
|
|
|
char *options, *o, *p;
|
|
|
|
int token, ret = 0;
|
|
|
|
u64 token64;
|
|
|
|
|
|
|
|
options = o = kstrdup(buf, GFP_KERNEL);
|
|
|
|
if (!options)
|
|
|
|
return -ENOMEM;
|
|
|
|
|
|
|
|
while ((p = strsep(&o, ",\n")) != NULL) {
|
|
|
|
if (!*p)
|
|
|
|
continue;
|
|
|
|
|
|
|
|
token = match_token(p, opt_tokens, args);
|
|
|
|
opts->mask |= token;
|
|
|
|
switch (token) {
|
|
|
|
case NVMF_OPT_WWNN:
|
|
|
|
if (match_u64(args, &token64)) {
|
|
|
|
ret = -EINVAL;
|
|
|
|
goto out_free_options;
|
|
|
|
}
|
|
|
|
opts->wwnn = token64;
|
|
|
|
break;
|
|
|
|
case NVMF_OPT_WWPN:
|
|
|
|
if (match_u64(args, &token64)) {
|
|
|
|
ret = -EINVAL;
|
|
|
|
goto out_free_options;
|
|
|
|
}
|
|
|
|
opts->wwpn = token64;
|
|
|
|
break;
|
|
|
|
case NVMF_OPT_ROLES:
|
|
|
|
if (match_int(args, &token)) {
|
|
|
|
ret = -EINVAL;
|
|
|
|
goto out_free_options;
|
|
|
|
}
|
|
|
|
opts->roles = token;
|
|
|
|
break;
|
|
|
|
case NVMF_OPT_FCADDR:
|
|
|
|
if (match_hex(args, &token)) {
|
|
|
|
ret = -EINVAL;
|
|
|
|
goto out_free_options;
|
|
|
|
}
|
|
|
|
opts->fcaddr = token;
|
|
|
|
break;
|
|
|
|
case NVMF_OPT_LPWWNN:
|
|
|
|
if (match_u64(args, &token64)) {
|
|
|
|
ret = -EINVAL;
|
|
|
|
goto out_free_options;
|
|
|
|
}
|
|
|
|
opts->lpwwnn = token64;
|
|
|
|
break;
|
|
|
|
case NVMF_OPT_LPWWPN:
|
|
|
|
if (match_u64(args, &token64)) {
|
|
|
|
ret = -EINVAL;
|
|
|
|
goto out_free_options;
|
|
|
|
}
|
|
|
|
opts->lpwwpn = token64;
|
|
|
|
break;
|
|
|
|
default:
|
|
|
|
pr_warn("unknown parameter or missing value '%s'\n", p);
|
|
|
|
ret = -EINVAL;
|
|
|
|
goto out_free_options;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
out_free_options:
|
|
|
|
kfree(options);
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
static int
|
|
|
|
fcloop_parse_nm_options(struct device *dev, u64 *nname, u64 *pname,
|
|
|
|
const char *buf)
|
|
|
|
{
|
|
|
|
substring_t args[MAX_OPT_ARGS];
|
|
|
|
char *options, *o, *p;
|
|
|
|
int token, ret = 0;
|
|
|
|
u64 token64;
|
|
|
|
|
|
|
|
*nname = -1;
|
|
|
|
*pname = -1;
|
|
|
|
|
|
|
|
options = o = kstrdup(buf, GFP_KERNEL);
|
|
|
|
if (!options)
|
|
|
|
return -ENOMEM;
|
|
|
|
|
|
|
|
while ((p = strsep(&o, ",\n")) != NULL) {
|
|
|
|
if (!*p)
|
|
|
|
continue;
|
|
|
|
|
|
|
|
token = match_token(p, opt_tokens, args);
|
|
|
|
switch (token) {
|
|
|
|
case NVMF_OPT_WWNN:
|
|
|
|
if (match_u64(args, &token64)) {
|
|
|
|
ret = -EINVAL;
|
|
|
|
goto out_free_options;
|
|
|
|
}
|
|
|
|
*nname = token64;
|
|
|
|
break;
|
|
|
|
case NVMF_OPT_WWPN:
|
|
|
|
if (match_u64(args, &token64)) {
|
|
|
|
ret = -EINVAL;
|
|
|
|
goto out_free_options;
|
|
|
|
}
|
|
|
|
*pname = token64;
|
|
|
|
break;
|
|
|
|
default:
|
|
|
|
pr_warn("unknown parameter or missing value '%s'\n", p);
|
|
|
|
ret = -EINVAL;
|
|
|
|
goto out_free_options;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
out_free_options:
|
|
|
|
kfree(options);
|
|
|
|
|
|
|
|
if (!ret) {
|
|
|
|
if (*nname == -1)
|
|
|
|
return -EINVAL;
|
|
|
|
if (*pname == -1)
|
|
|
|
return -EINVAL;
|
|
|
|
}
|
|
|
|
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
#define LPORT_OPTS (NVMF_OPT_WWNN | NVMF_OPT_WWPN)
|
|
|
|
|
|
|
|
#define RPORT_OPTS (NVMF_OPT_WWNN | NVMF_OPT_WWPN | \
|
|
|
|
NVMF_OPT_LPWWNN | NVMF_OPT_LPWWPN)
|
|
|
|
|
|
|
|
#define TGTPORT_OPTS (NVMF_OPT_WWNN | NVMF_OPT_WWPN)
|
|
|
|
|
|
|
|
#define ALL_OPTS (NVMF_OPT_WWNN | NVMF_OPT_WWPN | NVMF_OPT_ROLES | \
|
|
|
|
NVMF_OPT_FCADDR | NVMF_OPT_LPWWNN | NVMF_OPT_LPWWPN)
|
|
|
|
|
|
|
|
|
|
|
|
static DEFINE_SPINLOCK(fcloop_lock);
|
|
|
|
static LIST_HEAD(fcloop_lports);
|
|
|
|
static LIST_HEAD(fcloop_nports);
|
|
|
|
|
|
|
|
struct fcloop_lport {
|
|
|
|
struct nvme_fc_local_port *localport;
|
|
|
|
struct list_head lport_list;
|
|
|
|
struct completion unreg_done;
|
|
|
|
};
|
|
|
|
|
|
|
|
struct fcloop_rport {
|
|
|
|
struct nvme_fc_remote_port *remoteport;
|
|
|
|
struct nvmet_fc_target_port *targetport;
|
|
|
|
struct fcloop_nport *nport;
|
|
|
|
struct fcloop_lport *lport;
|
|
|
|
};
|
|
|
|
|
|
|
|
struct fcloop_tport {
|
|
|
|
struct nvmet_fc_target_port *targetport;
|
|
|
|
struct nvme_fc_remote_port *remoteport;
|
|
|
|
struct fcloop_nport *nport;
|
|
|
|
struct fcloop_lport *lport;
|
|
|
|
};
|
|
|
|
|
|
|
|
struct fcloop_nport {
|
|
|
|
struct fcloop_rport *rport;
|
|
|
|
struct fcloop_tport *tport;
|
|
|
|
struct fcloop_lport *lport;
|
|
|
|
struct list_head nport_list;
|
|
|
|
struct kref ref;
|
|
|
|
struct completion rport_unreg_done;
|
|
|
|
struct completion tport_unreg_done;
|
|
|
|
u64 node_name;
|
|
|
|
u64 port_name;
|
|
|
|
u32 port_role;
|
|
|
|
u32 port_id;
|
|
|
|
};
|
|
|
|
|
|
|
|
struct fcloop_lsreq {
|
|
|
|
struct fcloop_tport *tport;
|
|
|
|
struct nvmefc_ls_req *lsreq;
|
|
|
|
struct work_struct work;
|
|
|
|
struct nvmefc_tgt_ls_req tgt_ls_req;
|
|
|
|
int status;
|
|
|
|
};
|
|
|
|
|
|
|
|
struct fcloop_fcpreq {
|
|
|
|
struct fcloop_tport *tport;
|
|
|
|
struct nvmefc_fcp_req *fcpreq;
|
nvmet_fc: Rework target side abort handling
target transport:
----------------------
There are cases when there is a need to abort in-progress target
operations (writedata) so that controller termination or errors can
clean up. That can't happen currently as the abort is another target
op type, so it can't be used till the running one finishes (and it may
not). Solve by removing the abort op type and creating a separate
downcall from the transport to the lldd to request an io to be aborted.
The transport will abort ios on queue teardown or io errors. In general
the transport tries to call the lldd abort only when the io state is
idle. Meaning: ops that transmit data (readdata or rsp) will always
finish their transmit (or the lldd will see a state on the
link or initiator port that fails the transmit) and the done call for
the operation will occur. The transport will wait for the op done
upcall before calling the abort function, and as the io is idle, the
io can be cleaned up immediately after the abort call; Similarly, ios
that are not waiting for data or transmitting data must be in the nvmet
layer being processed. The transport will wait for the nvmet layer
completion before calling the abort function, and as the io is idle,
the io can be cleaned up immediately after the abort call; As for ops
that are waiting for data (writedata), they may be outstanding
indefinitely if the lldd doesn't see a condition where the initiatior
port or link is bad. In those cases, the transport will call the abort
function and wait for the lldd's op done upcall for the operation, where
it will then clean up the io.
Additionally, if a lldd receives an ABTS and matches it to an outstanding
request in the transport, A new new transport upcall was created to abort
the outstanding request in the transport. The transport expects any
outstanding op call (readdata or writedata) will completed by the lldd and
the operation upcall made. The transport doesn't act on the reported
abort (e.g. clean up the io) until an op done upcall occurs, a new op is
attempted, or the nvmet layer completes the io processing.
fcloop:
----------------------
Updated to support the new target apis.
On fcp io aborts from the initiator, the loopback context is updated to
NULL out the half that has completed. The initiator side is immediately
called after the abort request with an io completion (abort status).
On fcp io aborts from the target, the io is stopped and the initiator side
sees it as an aborted io. Target side ops, perhaps in progress while the
initiator side is done, continue but noop the data movement as there's no
structure on the initiator side to reference.
patch also contains:
----------------------
Revised lpfc to support the new abort api
commonized rsp buffer syncing and nulling of private data based on
calling paths.
errors in op done calls don't take action on the fod. They're bad
operations which implies the fod may be bad.
Signed-off-by: James Smart <james.smart@broadcom.com>
Signed-off-by: Sagi Grimberg <sagi@grimberg.me>
2017-04-11 18:32:31 +00:00
|
|
|
spinlock_t reqlock;
|
2016-12-02 08:28:44 +00:00
|
|
|
u16 status;
|
nvmet_fc: Rework target side abort handling
target transport:
----------------------
There are cases when there is a need to abort in-progress target
operations (writedata) so that controller termination or errors can
clean up. That can't happen currently as the abort is another target
op type, so it can't be used till the running one finishes (and it may
not). Solve by removing the abort op type and creating a separate
downcall from the transport to the lldd to request an io to be aborted.
The transport will abort ios on queue teardown or io errors. In general
the transport tries to call the lldd abort only when the io state is
idle. Meaning: ops that transmit data (readdata or rsp) will always
finish their transmit (or the lldd will see a state on the
link or initiator port that fails the transmit) and the done call for
the operation will occur. The transport will wait for the op done
upcall before calling the abort function, and as the io is idle, the
io can be cleaned up immediately after the abort call; Similarly, ios
that are not waiting for data or transmitting data must be in the nvmet
layer being processed. The transport will wait for the nvmet layer
completion before calling the abort function, and as the io is idle,
the io can be cleaned up immediately after the abort call; As for ops
that are waiting for data (writedata), they may be outstanding
indefinitely if the lldd doesn't see a condition where the initiatior
port or link is bad. In those cases, the transport will call the abort
function and wait for the lldd's op done upcall for the operation, where
it will then clean up the io.
Additionally, if a lldd receives an ABTS and matches it to an outstanding
request in the transport, A new new transport upcall was created to abort
the outstanding request in the transport. The transport expects any
outstanding op call (readdata or writedata) will completed by the lldd and
the operation upcall made. The transport doesn't act on the reported
abort (e.g. clean up the io) until an op done upcall occurs, a new op is
attempted, or the nvmet layer completes the io processing.
fcloop:
----------------------
Updated to support the new target apis.
On fcp io aborts from the initiator, the loopback context is updated to
NULL out the half that has completed. The initiator side is immediately
called after the abort request with an io completion (abort status).
On fcp io aborts from the target, the io is stopped and the initiator side
sees it as an aborted io. Target side ops, perhaps in progress while the
initiator side is done, continue but noop the data movement as there's no
structure on the initiator side to reference.
patch also contains:
----------------------
Revised lpfc to support the new abort api
commonized rsp buffer syncing and nulling of private data based on
calling paths.
errors in op done calls don't take action on the fod. They're bad
operations which implies the fod may be bad.
Signed-off-by: James Smart <james.smart@broadcom.com>
Signed-off-by: Sagi Grimberg <sagi@grimberg.me>
2017-04-11 18:32:31 +00:00
|
|
|
bool active;
|
|
|
|
bool aborted;
|
2016-12-02 08:28:44 +00:00
|
|
|
struct work_struct work;
|
|
|
|
struct nvmefc_tgt_fcp_req tgt_fcp_req;
|
|
|
|
};
|
|
|
|
|
2017-04-11 18:32:30 +00:00
|
|
|
struct fcloop_ini_fcpreq {
|
|
|
|
struct nvmefc_fcp_req *fcpreq;
|
|
|
|
struct fcloop_fcpreq *tfcp_req;
|
nvmet_fc: Rework target side abort handling
target transport:
----------------------
There are cases when there is a need to abort in-progress target
operations (writedata) so that controller termination or errors can
clean up. That can't happen currently as the abort is another target
op type, so it can't be used till the running one finishes (and it may
not). Solve by removing the abort op type and creating a separate
downcall from the transport to the lldd to request an io to be aborted.
The transport will abort ios on queue teardown or io errors. In general
the transport tries to call the lldd abort only when the io state is
idle. Meaning: ops that transmit data (readdata or rsp) will always
finish their transmit (or the lldd will see a state on the
link or initiator port that fails the transmit) and the done call for
the operation will occur. The transport will wait for the op done
upcall before calling the abort function, and as the io is idle, the
io can be cleaned up immediately after the abort call; Similarly, ios
that are not waiting for data or transmitting data must be in the nvmet
layer being processed. The transport will wait for the nvmet layer
completion before calling the abort function, and as the io is idle,
the io can be cleaned up immediately after the abort call; As for ops
that are waiting for data (writedata), they may be outstanding
indefinitely if the lldd doesn't see a condition where the initiatior
port or link is bad. In those cases, the transport will call the abort
function and wait for the lldd's op done upcall for the operation, where
it will then clean up the io.
Additionally, if a lldd receives an ABTS and matches it to an outstanding
request in the transport, A new new transport upcall was created to abort
the outstanding request in the transport. The transport expects any
outstanding op call (readdata or writedata) will completed by the lldd and
the operation upcall made. The transport doesn't act on the reported
abort (e.g. clean up the io) until an op done upcall occurs, a new op is
attempted, or the nvmet layer completes the io processing.
fcloop:
----------------------
Updated to support the new target apis.
On fcp io aborts from the initiator, the loopback context is updated to
NULL out the half that has completed. The initiator side is immediately
called after the abort request with an io completion (abort status).
On fcp io aborts from the target, the io is stopped and the initiator side
sees it as an aborted io. Target side ops, perhaps in progress while the
initiator side is done, continue but noop the data movement as there's no
structure on the initiator side to reference.
patch also contains:
----------------------
Revised lpfc to support the new abort api
commonized rsp buffer syncing and nulling of private data based on
calling paths.
errors in op done calls don't take action on the fod. They're bad
operations which implies the fod may be bad.
Signed-off-by: James Smart <james.smart@broadcom.com>
Signed-off-by: Sagi Grimberg <sagi@grimberg.me>
2017-04-11 18:32:31 +00:00
|
|
|
struct work_struct iniwork;
|
2017-04-11 18:32:30 +00:00
|
|
|
};
|
2016-12-02 08:28:44 +00:00
|
|
|
|
|
|
|
static inline struct fcloop_lsreq *
|
|
|
|
tgt_ls_req_to_lsreq(struct nvmefc_tgt_ls_req *tgt_lsreq)
|
|
|
|
{
|
|
|
|
return container_of(tgt_lsreq, struct fcloop_lsreq, tgt_ls_req);
|
|
|
|
}
|
|
|
|
|
|
|
|
static inline struct fcloop_fcpreq *
|
|
|
|
tgt_fcp_req_to_fcpreq(struct nvmefc_tgt_fcp_req *tgt_fcpreq)
|
|
|
|
{
|
|
|
|
return container_of(tgt_fcpreq, struct fcloop_fcpreq, tgt_fcp_req);
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
static int
|
|
|
|
fcloop_create_queue(struct nvme_fc_local_port *localport,
|
|
|
|
unsigned int qidx, u16 qsize,
|
|
|
|
void **handle)
|
|
|
|
{
|
|
|
|
*handle = localport;
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static void
|
|
|
|
fcloop_delete_queue(struct nvme_fc_local_port *localport,
|
|
|
|
unsigned int idx, void *handle)
|
|
|
|
{
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Transmit of LS RSP done (e.g. buffers all set). call back up
|
|
|
|
* initiator "done" flows.
|
|
|
|
*/
|
|
|
|
static void
|
|
|
|
fcloop_tgt_lsrqst_done_work(struct work_struct *work)
|
|
|
|
{
|
|
|
|
struct fcloop_lsreq *tls_req =
|
|
|
|
container_of(work, struct fcloop_lsreq, work);
|
|
|
|
struct fcloop_tport *tport = tls_req->tport;
|
|
|
|
struct nvmefc_ls_req *lsreq = tls_req->lsreq;
|
|
|
|
|
|
|
|
if (tport->remoteport)
|
|
|
|
lsreq->done(lsreq, tls_req->status);
|
|
|
|
}
|
|
|
|
|
|
|
|
static int
|
|
|
|
fcloop_ls_req(struct nvme_fc_local_port *localport,
|
|
|
|
struct nvme_fc_remote_port *remoteport,
|
|
|
|
struct nvmefc_ls_req *lsreq)
|
|
|
|
{
|
|
|
|
struct fcloop_lsreq *tls_req = lsreq->private;
|
|
|
|
struct fcloop_rport *rport = remoteport->private;
|
|
|
|
int ret = 0;
|
|
|
|
|
|
|
|
tls_req->lsreq = lsreq;
|
|
|
|
INIT_WORK(&tls_req->work, fcloop_tgt_lsrqst_done_work);
|
|
|
|
|
|
|
|
if (!rport->targetport) {
|
|
|
|
tls_req->status = -ECONNREFUSED;
|
|
|
|
schedule_work(&tls_req->work);
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
tls_req->status = 0;
|
|
|
|
tls_req->tport = rport->targetport->private;
|
|
|
|
ret = nvmet_fc_rcv_ls_req(rport->targetport, &tls_req->tgt_ls_req,
|
|
|
|
lsreq->rqstaddr, lsreq->rqstlen);
|
|
|
|
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int
|
|
|
|
fcloop_xmt_ls_rsp(struct nvmet_fc_target_port *tport,
|
|
|
|
struct nvmefc_tgt_ls_req *tgt_lsreq)
|
|
|
|
{
|
|
|
|
struct fcloop_lsreq *tls_req = tgt_ls_req_to_lsreq(tgt_lsreq);
|
|
|
|
struct nvmefc_ls_req *lsreq = tls_req->lsreq;
|
|
|
|
|
|
|
|
memcpy(lsreq->rspaddr, tgt_lsreq->rspbuf,
|
|
|
|
((lsreq->rsplen < tgt_lsreq->rsplen) ?
|
|
|
|
lsreq->rsplen : tgt_lsreq->rsplen));
|
|
|
|
tgt_lsreq->done(tgt_lsreq);
|
|
|
|
|
|
|
|
schedule_work(&tls_req->work);
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
nvmet_fc: Rework target side abort handling
target transport:
----------------------
There are cases when there is a need to abort in-progress target
operations (writedata) so that controller termination or errors can
clean up. That can't happen currently as the abort is another target
op type, so it can't be used till the running one finishes (and it may
not). Solve by removing the abort op type and creating a separate
downcall from the transport to the lldd to request an io to be aborted.
The transport will abort ios on queue teardown or io errors. In general
the transport tries to call the lldd abort only when the io state is
idle. Meaning: ops that transmit data (readdata or rsp) will always
finish their transmit (or the lldd will see a state on the
link or initiator port that fails the transmit) and the done call for
the operation will occur. The transport will wait for the op done
upcall before calling the abort function, and as the io is idle, the
io can be cleaned up immediately after the abort call; Similarly, ios
that are not waiting for data or transmitting data must be in the nvmet
layer being processed. The transport will wait for the nvmet layer
completion before calling the abort function, and as the io is idle,
the io can be cleaned up immediately after the abort call; As for ops
that are waiting for data (writedata), they may be outstanding
indefinitely if the lldd doesn't see a condition where the initiatior
port or link is bad. In those cases, the transport will call the abort
function and wait for the lldd's op done upcall for the operation, where
it will then clean up the io.
Additionally, if a lldd receives an ABTS and matches it to an outstanding
request in the transport, A new new transport upcall was created to abort
the outstanding request in the transport. The transport expects any
outstanding op call (readdata or writedata) will completed by the lldd and
the operation upcall made. The transport doesn't act on the reported
abort (e.g. clean up the io) until an op done upcall occurs, a new op is
attempted, or the nvmet layer completes the io processing.
fcloop:
----------------------
Updated to support the new target apis.
On fcp io aborts from the initiator, the loopback context is updated to
NULL out the half that has completed. The initiator side is immediately
called after the abort request with an io completion (abort status).
On fcp io aborts from the target, the io is stopped and the initiator side
sees it as an aborted io. Target side ops, perhaps in progress while the
initiator side is done, continue but noop the data movement as there's no
structure on the initiator side to reference.
patch also contains:
----------------------
Revised lpfc to support the new abort api
commonized rsp buffer syncing and nulling of private data based on
calling paths.
errors in op done calls don't take action on the fod. They're bad
operations which implies the fod may be bad.
Signed-off-by: James Smart <james.smart@broadcom.com>
Signed-off-by: Sagi Grimberg <sagi@grimberg.me>
2017-04-11 18:32:31 +00:00
|
|
|
* FCP IO operation done by initiator abort.
|
|
|
|
* call back up initiator "done" flows.
|
|
|
|
*/
|
|
|
|
static void
|
|
|
|
fcloop_tgt_fcprqst_ini_done_work(struct work_struct *work)
|
|
|
|
{
|
|
|
|
struct fcloop_ini_fcpreq *inireq =
|
|
|
|
container_of(work, struct fcloop_ini_fcpreq, iniwork);
|
|
|
|
|
|
|
|
inireq->fcpreq->done(inireq->fcpreq);
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* FCP IO operation done by target completion.
|
|
|
|
* call back up initiator "done" flows.
|
2016-12-02 08:28:44 +00:00
|
|
|
*/
|
|
|
|
static void
|
|
|
|
fcloop_tgt_fcprqst_done_work(struct work_struct *work)
|
|
|
|
{
|
|
|
|
struct fcloop_fcpreq *tfcp_req =
|
|
|
|
container_of(work, struct fcloop_fcpreq, work);
|
|
|
|
struct fcloop_tport *tport = tfcp_req->tport;
|
nvmet_fc: Rework target side abort handling
target transport:
----------------------
There are cases when there is a need to abort in-progress target
operations (writedata) so that controller termination or errors can
clean up. That can't happen currently as the abort is another target
op type, so it can't be used till the running one finishes (and it may
not). Solve by removing the abort op type and creating a separate
downcall from the transport to the lldd to request an io to be aborted.
The transport will abort ios on queue teardown or io errors. In general
the transport tries to call the lldd abort only when the io state is
idle. Meaning: ops that transmit data (readdata or rsp) will always
finish their transmit (or the lldd will see a state on the
link or initiator port that fails the transmit) and the done call for
the operation will occur. The transport will wait for the op done
upcall before calling the abort function, and as the io is idle, the
io can be cleaned up immediately after the abort call; Similarly, ios
that are not waiting for data or transmitting data must be in the nvmet
layer being processed. The transport will wait for the nvmet layer
completion before calling the abort function, and as the io is idle,
the io can be cleaned up immediately after the abort call; As for ops
that are waiting for data (writedata), they may be outstanding
indefinitely if the lldd doesn't see a condition where the initiatior
port or link is bad. In those cases, the transport will call the abort
function and wait for the lldd's op done upcall for the operation, where
it will then clean up the io.
Additionally, if a lldd receives an ABTS and matches it to an outstanding
request in the transport, A new new transport upcall was created to abort
the outstanding request in the transport. The transport expects any
outstanding op call (readdata or writedata) will completed by the lldd and
the operation upcall made. The transport doesn't act on the reported
abort (e.g. clean up the io) until an op done upcall occurs, a new op is
attempted, or the nvmet layer completes the io processing.
fcloop:
----------------------
Updated to support the new target apis.
On fcp io aborts from the initiator, the loopback context is updated to
NULL out the half that has completed. The initiator side is immediately
called after the abort request with an io completion (abort status).
On fcp io aborts from the target, the io is stopped and the initiator side
sees it as an aborted io. Target side ops, perhaps in progress while the
initiator side is done, continue but noop the data movement as there's no
structure on the initiator side to reference.
patch also contains:
----------------------
Revised lpfc to support the new abort api
commonized rsp buffer syncing and nulling of private data based on
calling paths.
errors in op done calls don't take action on the fod. They're bad
operations which implies the fod may be bad.
Signed-off-by: James Smart <james.smart@broadcom.com>
Signed-off-by: Sagi Grimberg <sagi@grimberg.me>
2017-04-11 18:32:31 +00:00
|
|
|
struct nvmefc_fcp_req *fcpreq;
|
2016-12-02 08:28:44 +00:00
|
|
|
|
nvmet_fc: Rework target side abort handling
target transport:
----------------------
There are cases when there is a need to abort in-progress target
operations (writedata) so that controller termination or errors can
clean up. That can't happen currently as the abort is another target
op type, so it can't be used till the running one finishes (and it may
not). Solve by removing the abort op type and creating a separate
downcall from the transport to the lldd to request an io to be aborted.
The transport will abort ios on queue teardown or io errors. In general
the transport tries to call the lldd abort only when the io state is
idle. Meaning: ops that transmit data (readdata or rsp) will always
finish their transmit (or the lldd will see a state on the
link or initiator port that fails the transmit) and the done call for
the operation will occur. The transport will wait for the op done
upcall before calling the abort function, and as the io is idle, the
io can be cleaned up immediately after the abort call; Similarly, ios
that are not waiting for data or transmitting data must be in the nvmet
layer being processed. The transport will wait for the nvmet layer
completion before calling the abort function, and as the io is idle,
the io can be cleaned up immediately after the abort call; As for ops
that are waiting for data (writedata), they may be outstanding
indefinitely if the lldd doesn't see a condition where the initiatior
port or link is bad. In those cases, the transport will call the abort
function and wait for the lldd's op done upcall for the operation, where
it will then clean up the io.
Additionally, if a lldd receives an ABTS and matches it to an outstanding
request in the transport, A new new transport upcall was created to abort
the outstanding request in the transport. The transport expects any
outstanding op call (readdata or writedata) will completed by the lldd and
the operation upcall made. The transport doesn't act on the reported
abort (e.g. clean up the io) until an op done upcall occurs, a new op is
attempted, or the nvmet layer completes the io processing.
fcloop:
----------------------
Updated to support the new target apis.
On fcp io aborts from the initiator, the loopback context is updated to
NULL out the half that has completed. The initiator side is immediately
called after the abort request with an io completion (abort status).
On fcp io aborts from the target, the io is stopped and the initiator side
sees it as an aborted io. Target side ops, perhaps in progress while the
initiator side is done, continue but noop the data movement as there's no
structure on the initiator side to reference.
patch also contains:
----------------------
Revised lpfc to support the new abort api
commonized rsp buffer syncing and nulling of private data based on
calling paths.
errors in op done calls don't take action on the fod. They're bad
operations which implies the fod may be bad.
Signed-off-by: James Smart <james.smart@broadcom.com>
Signed-off-by: Sagi Grimberg <sagi@grimberg.me>
2017-04-11 18:32:31 +00:00
|
|
|
spin_lock(&tfcp_req->reqlock);
|
|
|
|
fcpreq = tfcp_req->fcpreq;
|
|
|
|
spin_unlock(&tfcp_req->reqlock);
|
|
|
|
|
|
|
|
if (tport->remoteport && fcpreq) {
|
2016-12-02 08:28:44 +00:00
|
|
|
fcpreq->status = tfcp_req->status;
|
|
|
|
fcpreq->done(fcpreq);
|
|
|
|
}
|
2017-04-11 18:32:30 +00:00
|
|
|
|
|
|
|
kfree(tfcp_req);
|
2016-12-02 08:28:44 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
static int
|
|
|
|
fcloop_fcp_req(struct nvme_fc_local_port *localport,
|
|
|
|
struct nvme_fc_remote_port *remoteport,
|
|
|
|
void *hw_queue_handle,
|
|
|
|
struct nvmefc_fcp_req *fcpreq)
|
|
|
|
{
|
|
|
|
struct fcloop_rport *rport = remoteport->private;
|
2017-04-11 18:32:30 +00:00
|
|
|
struct fcloop_ini_fcpreq *inireq = fcpreq->private;
|
|
|
|
struct fcloop_fcpreq *tfcp_req;
|
2016-12-02 08:28:44 +00:00
|
|
|
int ret = 0;
|
|
|
|
|
2017-04-11 18:32:30 +00:00
|
|
|
if (!rport->targetport)
|
|
|
|
return -ECONNREFUSED;
|
2016-12-02 08:28:44 +00:00
|
|
|
|
2017-04-11 18:32:30 +00:00
|
|
|
tfcp_req = kzalloc(sizeof(*tfcp_req), GFP_KERNEL);
|
|
|
|
if (!tfcp_req)
|
|
|
|
return -ENOMEM;
|
2016-12-02 08:28:44 +00:00
|
|
|
|
2017-04-11 18:32:30 +00:00
|
|
|
inireq->fcpreq = fcpreq;
|
|
|
|
inireq->tfcp_req = tfcp_req;
|
nvmet_fc: Rework target side abort handling
target transport:
----------------------
There are cases when there is a need to abort in-progress target
operations (writedata) so that controller termination or errors can
clean up. That can't happen currently as the abort is another target
op type, so it can't be used till the running one finishes (and it may
not). Solve by removing the abort op type and creating a separate
downcall from the transport to the lldd to request an io to be aborted.
The transport will abort ios on queue teardown or io errors. In general
the transport tries to call the lldd abort only when the io state is
idle. Meaning: ops that transmit data (readdata or rsp) will always
finish their transmit (or the lldd will see a state on the
link or initiator port that fails the transmit) and the done call for
the operation will occur. The transport will wait for the op done
upcall before calling the abort function, and as the io is idle, the
io can be cleaned up immediately after the abort call; Similarly, ios
that are not waiting for data or transmitting data must be in the nvmet
layer being processed. The transport will wait for the nvmet layer
completion before calling the abort function, and as the io is idle,
the io can be cleaned up immediately after the abort call; As for ops
that are waiting for data (writedata), they may be outstanding
indefinitely if the lldd doesn't see a condition where the initiatior
port or link is bad. In those cases, the transport will call the abort
function and wait for the lldd's op done upcall for the operation, where
it will then clean up the io.
Additionally, if a lldd receives an ABTS and matches it to an outstanding
request in the transport, A new new transport upcall was created to abort
the outstanding request in the transport. The transport expects any
outstanding op call (readdata or writedata) will completed by the lldd and
the operation upcall made. The transport doesn't act on the reported
abort (e.g. clean up the io) until an op done upcall occurs, a new op is
attempted, or the nvmet layer completes the io processing.
fcloop:
----------------------
Updated to support the new target apis.
On fcp io aborts from the initiator, the loopback context is updated to
NULL out the half that has completed. The initiator side is immediately
called after the abort request with an io completion (abort status).
On fcp io aborts from the target, the io is stopped and the initiator side
sees it as an aborted io. Target side ops, perhaps in progress while the
initiator side is done, continue but noop the data movement as there's no
structure on the initiator side to reference.
patch also contains:
----------------------
Revised lpfc to support the new abort api
commonized rsp buffer syncing and nulling of private data based on
calling paths.
errors in op done calls don't take action on the fod. They're bad
operations which implies the fod may be bad.
Signed-off-by: James Smart <james.smart@broadcom.com>
Signed-off-by: Sagi Grimberg <sagi@grimberg.me>
2017-04-11 18:32:31 +00:00
|
|
|
INIT_WORK(&inireq->iniwork, fcloop_tgt_fcprqst_ini_done_work);
|
2016-12-02 08:28:44 +00:00
|
|
|
tfcp_req->fcpreq = fcpreq;
|
|
|
|
tfcp_req->tport = rport->targetport->private;
|
nvmet_fc: Rework target side abort handling
target transport:
----------------------
There are cases when there is a need to abort in-progress target
operations (writedata) so that controller termination or errors can
clean up. That can't happen currently as the abort is another target
op type, so it can't be used till the running one finishes (and it may
not). Solve by removing the abort op type and creating a separate
downcall from the transport to the lldd to request an io to be aborted.
The transport will abort ios on queue teardown or io errors. In general
the transport tries to call the lldd abort only when the io state is
idle. Meaning: ops that transmit data (readdata or rsp) will always
finish their transmit (or the lldd will see a state on the
link or initiator port that fails the transmit) and the done call for
the operation will occur. The transport will wait for the op done
upcall before calling the abort function, and as the io is idle, the
io can be cleaned up immediately after the abort call; Similarly, ios
that are not waiting for data or transmitting data must be in the nvmet
layer being processed. The transport will wait for the nvmet layer
completion before calling the abort function, and as the io is idle,
the io can be cleaned up immediately after the abort call; As for ops
that are waiting for data (writedata), they may be outstanding
indefinitely if the lldd doesn't see a condition where the initiatior
port or link is bad. In those cases, the transport will call the abort
function and wait for the lldd's op done upcall for the operation, where
it will then clean up the io.
Additionally, if a lldd receives an ABTS and matches it to an outstanding
request in the transport, A new new transport upcall was created to abort
the outstanding request in the transport. The transport expects any
outstanding op call (readdata or writedata) will completed by the lldd and
the operation upcall made. The transport doesn't act on the reported
abort (e.g. clean up the io) until an op done upcall occurs, a new op is
attempted, or the nvmet layer completes the io processing.
fcloop:
----------------------
Updated to support the new target apis.
On fcp io aborts from the initiator, the loopback context is updated to
NULL out the half that has completed. The initiator side is immediately
called after the abort request with an io completion (abort status).
On fcp io aborts from the target, the io is stopped and the initiator side
sees it as an aborted io. Target side ops, perhaps in progress while the
initiator side is done, continue but noop the data movement as there's no
structure on the initiator side to reference.
patch also contains:
----------------------
Revised lpfc to support the new abort api
commonized rsp buffer syncing and nulling of private data based on
calling paths.
errors in op done calls don't take action on the fod. They're bad
operations which implies the fod may be bad.
Signed-off-by: James Smart <james.smart@broadcom.com>
Signed-off-by: Sagi Grimberg <sagi@grimberg.me>
2017-04-11 18:32:31 +00:00
|
|
|
spin_lock_init(&tfcp_req->reqlock);
|
2017-04-11 18:32:30 +00:00
|
|
|
INIT_WORK(&tfcp_req->work, fcloop_tgt_fcprqst_done_work);
|
2016-12-02 08:28:44 +00:00
|
|
|
|
|
|
|
ret = nvmet_fc_rcv_fcp_req(rport->targetport, &tfcp_req->tgt_fcp_req,
|
|
|
|
fcpreq->cmdaddr, fcpreq->cmdlen);
|
|
|
|
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
static void
|
|
|
|
fcloop_fcp_copy_data(u8 op, struct scatterlist *data_sg,
|
|
|
|
struct scatterlist *io_sg, u32 offset, u32 length)
|
|
|
|
{
|
|
|
|
void *data_p, *io_p;
|
|
|
|
u32 data_len, io_len, tlen;
|
|
|
|
|
|
|
|
io_p = sg_virt(io_sg);
|
|
|
|
io_len = io_sg->length;
|
|
|
|
|
|
|
|
for ( ; offset; ) {
|
|
|
|
tlen = min_t(u32, offset, io_len);
|
|
|
|
offset -= tlen;
|
|
|
|
io_len -= tlen;
|
|
|
|
if (!io_len) {
|
|
|
|
io_sg = sg_next(io_sg);
|
|
|
|
io_p = sg_virt(io_sg);
|
|
|
|
io_len = io_sg->length;
|
|
|
|
} else
|
|
|
|
io_p += tlen;
|
|
|
|
}
|
|
|
|
|
|
|
|
data_p = sg_virt(data_sg);
|
|
|
|
data_len = data_sg->length;
|
|
|
|
|
|
|
|
for ( ; length; ) {
|
|
|
|
tlen = min_t(u32, io_len, data_len);
|
|
|
|
tlen = min_t(u32, tlen, length);
|
|
|
|
|
|
|
|
if (op == NVMET_FCOP_WRITEDATA)
|
|
|
|
memcpy(data_p, io_p, tlen);
|
|
|
|
else
|
|
|
|
memcpy(io_p, data_p, tlen);
|
|
|
|
|
|
|
|
length -= tlen;
|
|
|
|
|
|
|
|
io_len -= tlen;
|
|
|
|
if ((!io_len) && (length)) {
|
|
|
|
io_sg = sg_next(io_sg);
|
|
|
|
io_p = sg_virt(io_sg);
|
|
|
|
io_len = io_sg->length;
|
|
|
|
} else
|
|
|
|
io_p += tlen;
|
|
|
|
|
|
|
|
data_len -= tlen;
|
|
|
|
if ((!data_len) && (length)) {
|
|
|
|
data_sg = sg_next(data_sg);
|
|
|
|
data_p = sg_virt(data_sg);
|
|
|
|
data_len = data_sg->length;
|
|
|
|
} else
|
|
|
|
data_p += tlen;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
static int
|
|
|
|
fcloop_fcp_op(struct nvmet_fc_target_port *tgtport,
|
|
|
|
struct nvmefc_tgt_fcp_req *tgt_fcpreq)
|
|
|
|
{
|
|
|
|
struct fcloop_fcpreq *tfcp_req = tgt_fcp_req_to_fcpreq(tgt_fcpreq);
|
nvmet_fc: Rework target side abort handling
target transport:
----------------------
There are cases when there is a need to abort in-progress target
operations (writedata) so that controller termination or errors can
clean up. That can't happen currently as the abort is another target
op type, so it can't be used till the running one finishes (and it may
not). Solve by removing the abort op type and creating a separate
downcall from the transport to the lldd to request an io to be aborted.
The transport will abort ios on queue teardown or io errors. In general
the transport tries to call the lldd abort only when the io state is
idle. Meaning: ops that transmit data (readdata or rsp) will always
finish their transmit (or the lldd will see a state on the
link or initiator port that fails the transmit) and the done call for
the operation will occur. The transport will wait for the op done
upcall before calling the abort function, and as the io is idle, the
io can be cleaned up immediately after the abort call; Similarly, ios
that are not waiting for data or transmitting data must be in the nvmet
layer being processed. The transport will wait for the nvmet layer
completion before calling the abort function, and as the io is idle,
the io can be cleaned up immediately after the abort call; As for ops
that are waiting for data (writedata), they may be outstanding
indefinitely if the lldd doesn't see a condition where the initiatior
port or link is bad. In those cases, the transport will call the abort
function and wait for the lldd's op done upcall for the operation, where
it will then clean up the io.
Additionally, if a lldd receives an ABTS and matches it to an outstanding
request in the transport, A new new transport upcall was created to abort
the outstanding request in the transport. The transport expects any
outstanding op call (readdata or writedata) will completed by the lldd and
the operation upcall made. The transport doesn't act on the reported
abort (e.g. clean up the io) until an op done upcall occurs, a new op is
attempted, or the nvmet layer completes the io processing.
fcloop:
----------------------
Updated to support the new target apis.
On fcp io aborts from the initiator, the loopback context is updated to
NULL out the half that has completed. The initiator side is immediately
called after the abort request with an io completion (abort status).
On fcp io aborts from the target, the io is stopped and the initiator side
sees it as an aborted io. Target side ops, perhaps in progress while the
initiator side is done, continue but noop the data movement as there's no
structure on the initiator side to reference.
patch also contains:
----------------------
Revised lpfc to support the new abort api
commonized rsp buffer syncing and nulling of private data based on
calling paths.
errors in op done calls don't take action on the fod. They're bad
operations which implies the fod may be bad.
Signed-off-by: James Smart <james.smart@broadcom.com>
Signed-off-by: Sagi Grimberg <sagi@grimberg.me>
2017-04-11 18:32:31 +00:00
|
|
|
struct nvmefc_fcp_req *fcpreq;
|
2016-12-02 08:28:44 +00:00
|
|
|
u32 rsplen = 0, xfrlen = 0;
|
nvmet_fc: Rework target side abort handling
target transport:
----------------------
There are cases when there is a need to abort in-progress target
operations (writedata) so that controller termination or errors can
clean up. That can't happen currently as the abort is another target
op type, so it can't be used till the running one finishes (and it may
not). Solve by removing the abort op type and creating a separate
downcall from the transport to the lldd to request an io to be aborted.
The transport will abort ios on queue teardown or io errors. In general
the transport tries to call the lldd abort only when the io state is
idle. Meaning: ops that transmit data (readdata or rsp) will always
finish their transmit (or the lldd will see a state on the
link or initiator port that fails the transmit) and the done call for
the operation will occur. The transport will wait for the op done
upcall before calling the abort function, and as the io is idle, the
io can be cleaned up immediately after the abort call; Similarly, ios
that are not waiting for data or transmitting data must be in the nvmet
layer being processed. The transport will wait for the nvmet layer
completion before calling the abort function, and as the io is idle,
the io can be cleaned up immediately after the abort call; As for ops
that are waiting for data (writedata), they may be outstanding
indefinitely if the lldd doesn't see a condition where the initiatior
port or link is bad. In those cases, the transport will call the abort
function and wait for the lldd's op done upcall for the operation, where
it will then clean up the io.
Additionally, if a lldd receives an ABTS and matches it to an outstanding
request in the transport, A new new transport upcall was created to abort
the outstanding request in the transport. The transport expects any
outstanding op call (readdata or writedata) will completed by the lldd and
the operation upcall made. The transport doesn't act on the reported
abort (e.g. clean up the io) until an op done upcall occurs, a new op is
attempted, or the nvmet layer completes the io processing.
fcloop:
----------------------
Updated to support the new target apis.
On fcp io aborts from the initiator, the loopback context is updated to
NULL out the half that has completed. The initiator side is immediately
called after the abort request with an io completion (abort status).
On fcp io aborts from the target, the io is stopped and the initiator side
sees it as an aborted io. Target side ops, perhaps in progress while the
initiator side is done, continue but noop the data movement as there's no
structure on the initiator side to reference.
patch also contains:
----------------------
Revised lpfc to support the new abort api
commonized rsp buffer syncing and nulling of private data based on
calling paths.
errors in op done calls don't take action on the fod. They're bad
operations which implies the fod may be bad.
Signed-off-by: James Smart <james.smart@broadcom.com>
Signed-off-by: Sagi Grimberg <sagi@grimberg.me>
2017-04-11 18:32:31 +00:00
|
|
|
int fcp_err = 0, active, aborted;
|
2016-12-02 08:28:44 +00:00
|
|
|
u8 op = tgt_fcpreq->op;
|
|
|
|
|
nvmet_fc: Rework target side abort handling
target transport:
----------------------
There are cases when there is a need to abort in-progress target
operations (writedata) so that controller termination or errors can
clean up. That can't happen currently as the abort is another target
op type, so it can't be used till the running one finishes (and it may
not). Solve by removing the abort op type and creating a separate
downcall from the transport to the lldd to request an io to be aborted.
The transport will abort ios on queue teardown or io errors. In general
the transport tries to call the lldd abort only when the io state is
idle. Meaning: ops that transmit data (readdata or rsp) will always
finish their transmit (or the lldd will see a state on the
link or initiator port that fails the transmit) and the done call for
the operation will occur. The transport will wait for the op done
upcall before calling the abort function, and as the io is idle, the
io can be cleaned up immediately after the abort call; Similarly, ios
that are not waiting for data or transmitting data must be in the nvmet
layer being processed. The transport will wait for the nvmet layer
completion before calling the abort function, and as the io is idle,
the io can be cleaned up immediately after the abort call; As for ops
that are waiting for data (writedata), they may be outstanding
indefinitely if the lldd doesn't see a condition where the initiatior
port or link is bad. In those cases, the transport will call the abort
function and wait for the lldd's op done upcall for the operation, where
it will then clean up the io.
Additionally, if a lldd receives an ABTS and matches it to an outstanding
request in the transport, A new new transport upcall was created to abort
the outstanding request in the transport. The transport expects any
outstanding op call (readdata or writedata) will completed by the lldd and
the operation upcall made. The transport doesn't act on the reported
abort (e.g. clean up the io) until an op done upcall occurs, a new op is
attempted, or the nvmet layer completes the io processing.
fcloop:
----------------------
Updated to support the new target apis.
On fcp io aborts from the initiator, the loopback context is updated to
NULL out the half that has completed. The initiator side is immediately
called after the abort request with an io completion (abort status).
On fcp io aborts from the target, the io is stopped and the initiator side
sees it as an aborted io. Target side ops, perhaps in progress while the
initiator side is done, continue but noop the data movement as there's no
structure on the initiator side to reference.
patch also contains:
----------------------
Revised lpfc to support the new abort api
commonized rsp buffer syncing and nulling of private data based on
calling paths.
errors in op done calls don't take action on the fod. They're bad
operations which implies the fod may be bad.
Signed-off-by: James Smart <james.smart@broadcom.com>
Signed-off-by: Sagi Grimberg <sagi@grimberg.me>
2017-04-11 18:32:31 +00:00
|
|
|
spin_lock(&tfcp_req->reqlock);
|
|
|
|
fcpreq = tfcp_req->fcpreq;
|
|
|
|
active = tfcp_req->active;
|
|
|
|
aborted = tfcp_req->aborted;
|
|
|
|
tfcp_req->active = true;
|
|
|
|
spin_unlock(&tfcp_req->reqlock);
|
|
|
|
|
|
|
|
if (unlikely(active))
|
|
|
|
/* illegal - call while i/o active */
|
|
|
|
return -EALREADY;
|
|
|
|
|
|
|
|
if (unlikely(aborted)) {
|
|
|
|
/* target transport has aborted i/o prior */
|
|
|
|
spin_lock(&tfcp_req->reqlock);
|
|
|
|
tfcp_req->active = false;
|
|
|
|
spin_unlock(&tfcp_req->reqlock);
|
|
|
|
tgt_fcpreq->transferred_length = 0;
|
|
|
|
tgt_fcpreq->fcp_error = -ECANCELED;
|
|
|
|
tgt_fcpreq->done(tgt_fcpreq);
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* if fcpreq is NULL, the I/O has been aborted (from
|
|
|
|
* initiator side). For the target side, act as if all is well
|
|
|
|
* but don't actually move data.
|
|
|
|
*/
|
|
|
|
|
2016-12-02 08:28:44 +00:00
|
|
|
switch (op) {
|
|
|
|
case NVMET_FCOP_WRITEDATA:
|
|
|
|
xfrlen = tgt_fcpreq->transfer_length;
|
nvmet_fc: Rework target side abort handling
target transport:
----------------------
There are cases when there is a need to abort in-progress target
operations (writedata) so that controller termination or errors can
clean up. That can't happen currently as the abort is another target
op type, so it can't be used till the running one finishes (and it may
not). Solve by removing the abort op type and creating a separate
downcall from the transport to the lldd to request an io to be aborted.
The transport will abort ios on queue teardown or io errors. In general
the transport tries to call the lldd abort only when the io state is
idle. Meaning: ops that transmit data (readdata or rsp) will always
finish their transmit (or the lldd will see a state on the
link or initiator port that fails the transmit) and the done call for
the operation will occur. The transport will wait for the op done
upcall before calling the abort function, and as the io is idle, the
io can be cleaned up immediately after the abort call; Similarly, ios
that are not waiting for data or transmitting data must be in the nvmet
layer being processed. The transport will wait for the nvmet layer
completion before calling the abort function, and as the io is idle,
the io can be cleaned up immediately after the abort call; As for ops
that are waiting for data (writedata), they may be outstanding
indefinitely if the lldd doesn't see a condition where the initiatior
port or link is bad. In those cases, the transport will call the abort
function and wait for the lldd's op done upcall for the operation, where
it will then clean up the io.
Additionally, if a lldd receives an ABTS and matches it to an outstanding
request in the transport, A new new transport upcall was created to abort
the outstanding request in the transport. The transport expects any
outstanding op call (readdata or writedata) will completed by the lldd and
the operation upcall made. The transport doesn't act on the reported
abort (e.g. clean up the io) until an op done upcall occurs, a new op is
attempted, or the nvmet layer completes the io processing.
fcloop:
----------------------
Updated to support the new target apis.
On fcp io aborts from the initiator, the loopback context is updated to
NULL out the half that has completed. The initiator side is immediately
called after the abort request with an io completion (abort status).
On fcp io aborts from the target, the io is stopped and the initiator side
sees it as an aborted io. Target side ops, perhaps in progress while the
initiator side is done, continue but noop the data movement as there's no
structure on the initiator side to reference.
patch also contains:
----------------------
Revised lpfc to support the new abort api
commonized rsp buffer syncing and nulling of private data based on
calling paths.
errors in op done calls don't take action on the fod. They're bad
operations which implies the fod may be bad.
Signed-off-by: James Smart <james.smart@broadcom.com>
Signed-off-by: Sagi Grimberg <sagi@grimberg.me>
2017-04-11 18:32:31 +00:00
|
|
|
if (fcpreq) {
|
|
|
|
fcloop_fcp_copy_data(op, tgt_fcpreq->sg,
|
|
|
|
fcpreq->first_sgl, tgt_fcpreq->offset,
|
|
|
|
xfrlen);
|
|
|
|
fcpreq->transferred_length += xfrlen;
|
|
|
|
}
|
2016-12-02 08:28:44 +00:00
|
|
|
break;
|
|
|
|
|
|
|
|
case NVMET_FCOP_READDATA:
|
|
|
|
case NVMET_FCOP_READDATA_RSP:
|
|
|
|
xfrlen = tgt_fcpreq->transfer_length;
|
nvmet_fc: Rework target side abort handling
target transport:
----------------------
There are cases when there is a need to abort in-progress target
operations (writedata) so that controller termination or errors can
clean up. That can't happen currently as the abort is another target
op type, so it can't be used till the running one finishes (and it may
not). Solve by removing the abort op type and creating a separate
downcall from the transport to the lldd to request an io to be aborted.
The transport will abort ios on queue teardown or io errors. In general
the transport tries to call the lldd abort only when the io state is
idle. Meaning: ops that transmit data (readdata or rsp) will always
finish their transmit (or the lldd will see a state on the
link or initiator port that fails the transmit) and the done call for
the operation will occur. The transport will wait for the op done
upcall before calling the abort function, and as the io is idle, the
io can be cleaned up immediately after the abort call; Similarly, ios
that are not waiting for data or transmitting data must be in the nvmet
layer being processed. The transport will wait for the nvmet layer
completion before calling the abort function, and as the io is idle,
the io can be cleaned up immediately after the abort call; As for ops
that are waiting for data (writedata), they may be outstanding
indefinitely if the lldd doesn't see a condition where the initiatior
port or link is bad. In those cases, the transport will call the abort
function and wait for the lldd's op done upcall for the operation, where
it will then clean up the io.
Additionally, if a lldd receives an ABTS and matches it to an outstanding
request in the transport, A new new transport upcall was created to abort
the outstanding request in the transport. The transport expects any
outstanding op call (readdata or writedata) will completed by the lldd and
the operation upcall made. The transport doesn't act on the reported
abort (e.g. clean up the io) until an op done upcall occurs, a new op is
attempted, or the nvmet layer completes the io processing.
fcloop:
----------------------
Updated to support the new target apis.
On fcp io aborts from the initiator, the loopback context is updated to
NULL out the half that has completed. The initiator side is immediately
called after the abort request with an io completion (abort status).
On fcp io aborts from the target, the io is stopped and the initiator side
sees it as an aborted io. Target side ops, perhaps in progress while the
initiator side is done, continue but noop the data movement as there's no
structure on the initiator side to reference.
patch also contains:
----------------------
Revised lpfc to support the new abort api
commonized rsp buffer syncing and nulling of private data based on
calling paths.
errors in op done calls don't take action on the fod. They're bad
operations which implies the fod may be bad.
Signed-off-by: James Smart <james.smart@broadcom.com>
Signed-off-by: Sagi Grimberg <sagi@grimberg.me>
2017-04-11 18:32:31 +00:00
|
|
|
if (fcpreq) {
|
|
|
|
fcloop_fcp_copy_data(op, tgt_fcpreq->sg,
|
|
|
|
fcpreq->first_sgl, tgt_fcpreq->offset,
|
|
|
|
xfrlen);
|
|
|
|
fcpreq->transferred_length += xfrlen;
|
|
|
|
}
|
2016-12-02 08:28:44 +00:00
|
|
|
if (op == NVMET_FCOP_READDATA)
|
|
|
|
break;
|
|
|
|
|
|
|
|
/* Fall-Thru to RSP handling */
|
|
|
|
|
|
|
|
case NVMET_FCOP_RSP:
|
nvmet_fc: Rework target side abort handling
target transport:
----------------------
There are cases when there is a need to abort in-progress target
operations (writedata) so that controller termination or errors can
clean up. That can't happen currently as the abort is another target
op type, so it can't be used till the running one finishes (and it may
not). Solve by removing the abort op type and creating a separate
downcall from the transport to the lldd to request an io to be aborted.
The transport will abort ios on queue teardown or io errors. In general
the transport tries to call the lldd abort only when the io state is
idle. Meaning: ops that transmit data (readdata or rsp) will always
finish their transmit (or the lldd will see a state on the
link or initiator port that fails the transmit) and the done call for
the operation will occur. The transport will wait for the op done
upcall before calling the abort function, and as the io is idle, the
io can be cleaned up immediately after the abort call; Similarly, ios
that are not waiting for data or transmitting data must be in the nvmet
layer being processed. The transport will wait for the nvmet layer
completion before calling the abort function, and as the io is idle,
the io can be cleaned up immediately after the abort call; As for ops
that are waiting for data (writedata), they may be outstanding
indefinitely if the lldd doesn't see a condition where the initiatior
port or link is bad. In those cases, the transport will call the abort
function and wait for the lldd's op done upcall for the operation, where
it will then clean up the io.
Additionally, if a lldd receives an ABTS and matches it to an outstanding
request in the transport, A new new transport upcall was created to abort
the outstanding request in the transport. The transport expects any
outstanding op call (readdata or writedata) will completed by the lldd and
the operation upcall made. The transport doesn't act on the reported
abort (e.g. clean up the io) until an op done upcall occurs, a new op is
attempted, or the nvmet layer completes the io processing.
fcloop:
----------------------
Updated to support the new target apis.
On fcp io aborts from the initiator, the loopback context is updated to
NULL out the half that has completed. The initiator side is immediately
called after the abort request with an io completion (abort status).
On fcp io aborts from the target, the io is stopped and the initiator side
sees it as an aborted io. Target side ops, perhaps in progress while the
initiator side is done, continue but noop the data movement as there's no
structure on the initiator side to reference.
patch also contains:
----------------------
Revised lpfc to support the new abort api
commonized rsp buffer syncing and nulling of private data based on
calling paths.
errors in op done calls don't take action on the fod. They're bad
operations which implies the fod may be bad.
Signed-off-by: James Smart <james.smart@broadcom.com>
Signed-off-by: Sagi Grimberg <sagi@grimberg.me>
2017-04-11 18:32:31 +00:00
|
|
|
if (fcpreq) {
|
|
|
|
rsplen = ((fcpreq->rsplen < tgt_fcpreq->rsplen) ?
|
|
|
|
fcpreq->rsplen : tgt_fcpreq->rsplen);
|
|
|
|
memcpy(fcpreq->rspaddr, tgt_fcpreq->rspaddr, rsplen);
|
|
|
|
if (rsplen < tgt_fcpreq->rsplen)
|
|
|
|
fcp_err = -E2BIG;
|
|
|
|
fcpreq->rcv_rsplen = rsplen;
|
|
|
|
fcpreq->status = 0;
|
|
|
|
}
|
2016-12-02 08:28:44 +00:00
|
|
|
tfcp_req->status = 0;
|
|
|
|
break;
|
|
|
|
|
|
|
|
default:
|
|
|
|
fcp_err = -EINVAL;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
nvmet_fc: Rework target side abort handling
target transport:
----------------------
There are cases when there is a need to abort in-progress target
operations (writedata) so that controller termination or errors can
clean up. That can't happen currently as the abort is another target
op type, so it can't be used till the running one finishes (and it may
not). Solve by removing the abort op type and creating a separate
downcall from the transport to the lldd to request an io to be aborted.
The transport will abort ios on queue teardown or io errors. In general
the transport tries to call the lldd abort only when the io state is
idle. Meaning: ops that transmit data (readdata or rsp) will always
finish their transmit (or the lldd will see a state on the
link or initiator port that fails the transmit) and the done call for
the operation will occur. The transport will wait for the op done
upcall before calling the abort function, and as the io is idle, the
io can be cleaned up immediately after the abort call; Similarly, ios
that are not waiting for data or transmitting data must be in the nvmet
layer being processed. The transport will wait for the nvmet layer
completion before calling the abort function, and as the io is idle,
the io can be cleaned up immediately after the abort call; As for ops
that are waiting for data (writedata), they may be outstanding
indefinitely if the lldd doesn't see a condition where the initiatior
port or link is bad. In those cases, the transport will call the abort
function and wait for the lldd's op done upcall for the operation, where
it will then clean up the io.
Additionally, if a lldd receives an ABTS and matches it to an outstanding
request in the transport, A new new transport upcall was created to abort
the outstanding request in the transport. The transport expects any
outstanding op call (readdata or writedata) will completed by the lldd and
the operation upcall made. The transport doesn't act on the reported
abort (e.g. clean up the io) until an op done upcall occurs, a new op is
attempted, or the nvmet layer completes the io processing.
fcloop:
----------------------
Updated to support the new target apis.
On fcp io aborts from the initiator, the loopback context is updated to
NULL out the half that has completed. The initiator side is immediately
called after the abort request with an io completion (abort status).
On fcp io aborts from the target, the io is stopped and the initiator side
sees it as an aborted io. Target side ops, perhaps in progress while the
initiator side is done, continue but noop the data movement as there's no
structure on the initiator side to reference.
patch also contains:
----------------------
Revised lpfc to support the new abort api
commonized rsp buffer syncing and nulling of private data based on
calling paths.
errors in op done calls don't take action on the fod. They're bad
operations which implies the fod may be bad.
Signed-off-by: James Smart <james.smart@broadcom.com>
Signed-off-by: Sagi Grimberg <sagi@grimberg.me>
2017-04-11 18:32:31 +00:00
|
|
|
spin_lock(&tfcp_req->reqlock);
|
|
|
|
tfcp_req->active = false;
|
|
|
|
spin_unlock(&tfcp_req->reqlock);
|
|
|
|
|
2016-12-02 08:28:44 +00:00
|
|
|
tgt_fcpreq->transferred_length = xfrlen;
|
|
|
|
tgt_fcpreq->fcp_error = fcp_err;
|
|
|
|
tgt_fcpreq->done(tgt_fcpreq);
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
nvmet_fc: Rework target side abort handling
target transport:
----------------------
There are cases when there is a need to abort in-progress target
operations (writedata) so that controller termination or errors can
clean up. That can't happen currently as the abort is another target
op type, so it can't be used till the running one finishes (and it may
not). Solve by removing the abort op type and creating a separate
downcall from the transport to the lldd to request an io to be aborted.
The transport will abort ios on queue teardown or io errors. In general
the transport tries to call the lldd abort only when the io state is
idle. Meaning: ops that transmit data (readdata or rsp) will always
finish their transmit (or the lldd will see a state on the
link or initiator port that fails the transmit) and the done call for
the operation will occur. The transport will wait for the op done
upcall before calling the abort function, and as the io is idle, the
io can be cleaned up immediately after the abort call; Similarly, ios
that are not waiting for data or transmitting data must be in the nvmet
layer being processed. The transport will wait for the nvmet layer
completion before calling the abort function, and as the io is idle,
the io can be cleaned up immediately after the abort call; As for ops
that are waiting for data (writedata), they may be outstanding
indefinitely if the lldd doesn't see a condition where the initiatior
port or link is bad. In those cases, the transport will call the abort
function and wait for the lldd's op done upcall for the operation, where
it will then clean up the io.
Additionally, if a lldd receives an ABTS and matches it to an outstanding
request in the transport, A new new transport upcall was created to abort
the outstanding request in the transport. The transport expects any
outstanding op call (readdata or writedata) will completed by the lldd and
the operation upcall made. The transport doesn't act on the reported
abort (e.g. clean up the io) until an op done upcall occurs, a new op is
attempted, or the nvmet layer completes the io processing.
fcloop:
----------------------
Updated to support the new target apis.
On fcp io aborts from the initiator, the loopback context is updated to
NULL out the half that has completed. The initiator side is immediately
called after the abort request with an io completion (abort status).
On fcp io aborts from the target, the io is stopped and the initiator side
sees it as an aborted io. Target side ops, perhaps in progress while the
initiator side is done, continue but noop the data movement as there's no
structure on the initiator side to reference.
patch also contains:
----------------------
Revised lpfc to support the new abort api
commonized rsp buffer syncing and nulling of private data based on
calling paths.
errors in op done calls don't take action on the fod. They're bad
operations which implies the fod may be bad.
Signed-off-by: James Smart <james.smart@broadcom.com>
Signed-off-by: Sagi Grimberg <sagi@grimberg.me>
2017-04-11 18:32:31 +00:00
|
|
|
static void
|
|
|
|
fcloop_tgt_fcp_abort(struct nvmet_fc_target_port *tgtport,
|
|
|
|
struct nvmefc_tgt_fcp_req *tgt_fcpreq)
|
|
|
|
{
|
|
|
|
struct fcloop_fcpreq *tfcp_req = tgt_fcp_req_to_fcpreq(tgt_fcpreq);
|
|
|
|
int active;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* mark aborted only in case there were 2 threads in transport
|
|
|
|
* (one doing io, other doing abort) and only kills ops posted
|
|
|
|
* after the abort request
|
|
|
|
*/
|
|
|
|
spin_lock(&tfcp_req->reqlock);
|
|
|
|
active = tfcp_req->active;
|
|
|
|
tfcp_req->aborted = true;
|
|
|
|
spin_unlock(&tfcp_req->reqlock);
|
|
|
|
|
|
|
|
tfcp_req->status = NVME_SC_FC_TRANSPORT_ABORTED;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* nothing more to do. If io wasn't active, the transport should
|
|
|
|
* immediately call the req_release. If it was active, the op
|
|
|
|
* will complete, and the lldd should call req_release.
|
|
|
|
*/
|
|
|
|
}
|
|
|
|
|
2017-04-11 18:32:29 +00:00
|
|
|
static void
|
|
|
|
fcloop_fcp_req_release(struct nvmet_fc_target_port *tgtport,
|
|
|
|
struct nvmefc_tgt_fcp_req *tgt_fcpreq)
|
|
|
|
{
|
|
|
|
struct fcloop_fcpreq *tfcp_req = tgt_fcp_req_to_fcpreq(tgt_fcpreq);
|
|
|
|
|
|
|
|
schedule_work(&tfcp_req->work);
|
|
|
|
}
|
|
|
|
|
2016-12-02 08:28:44 +00:00
|
|
|
static void
|
|
|
|
fcloop_ls_abort(struct nvme_fc_local_port *localport,
|
|
|
|
struct nvme_fc_remote_port *remoteport,
|
|
|
|
struct nvmefc_ls_req *lsreq)
|
|
|
|
{
|
|
|
|
}
|
|
|
|
|
|
|
|
static void
|
|
|
|
fcloop_fcp_abort(struct nvme_fc_local_port *localport,
|
|
|
|
struct nvme_fc_remote_port *remoteport,
|
|
|
|
void *hw_queue_handle,
|
|
|
|
struct nvmefc_fcp_req *fcpreq)
|
|
|
|
{
|
nvmet_fc: Rework target side abort handling
target transport:
----------------------
There are cases when there is a need to abort in-progress target
operations (writedata) so that controller termination or errors can
clean up. That can't happen currently as the abort is another target
op type, so it can't be used till the running one finishes (and it may
not). Solve by removing the abort op type and creating a separate
downcall from the transport to the lldd to request an io to be aborted.
The transport will abort ios on queue teardown or io errors. In general
the transport tries to call the lldd abort only when the io state is
idle. Meaning: ops that transmit data (readdata or rsp) will always
finish their transmit (or the lldd will see a state on the
link or initiator port that fails the transmit) and the done call for
the operation will occur. The transport will wait for the op done
upcall before calling the abort function, and as the io is idle, the
io can be cleaned up immediately after the abort call; Similarly, ios
that are not waiting for data or transmitting data must be in the nvmet
layer being processed. The transport will wait for the nvmet layer
completion before calling the abort function, and as the io is idle,
the io can be cleaned up immediately after the abort call; As for ops
that are waiting for data (writedata), they may be outstanding
indefinitely if the lldd doesn't see a condition where the initiatior
port or link is bad. In those cases, the transport will call the abort
function and wait for the lldd's op done upcall for the operation, where
it will then clean up the io.
Additionally, if a lldd receives an ABTS and matches it to an outstanding
request in the transport, A new new transport upcall was created to abort
the outstanding request in the transport. The transport expects any
outstanding op call (readdata or writedata) will completed by the lldd and
the operation upcall made. The transport doesn't act on the reported
abort (e.g. clean up the io) until an op done upcall occurs, a new op is
attempted, or the nvmet layer completes the io processing.
fcloop:
----------------------
Updated to support the new target apis.
On fcp io aborts from the initiator, the loopback context is updated to
NULL out the half that has completed. The initiator side is immediately
called after the abort request with an io completion (abort status).
On fcp io aborts from the target, the io is stopped and the initiator side
sees it as an aborted io. Target side ops, perhaps in progress while the
initiator side is done, continue but noop the data movement as there's no
structure on the initiator side to reference.
patch also contains:
----------------------
Revised lpfc to support the new abort api
commonized rsp buffer syncing and nulling of private data based on
calling paths.
errors in op done calls don't take action on the fod. They're bad
operations which implies the fod may be bad.
Signed-off-by: James Smart <james.smart@broadcom.com>
Signed-off-by: Sagi Grimberg <sagi@grimberg.me>
2017-04-11 18:32:31 +00:00
|
|
|
struct fcloop_rport *rport = remoteport->private;
|
|
|
|
struct fcloop_ini_fcpreq *inireq = fcpreq->private;
|
|
|
|
struct fcloop_fcpreq *tfcp_req = inireq->tfcp_req;
|
|
|
|
|
|
|
|
if (!tfcp_req)
|
|
|
|
/* abort has already been called */
|
|
|
|
return;
|
|
|
|
|
|
|
|
if (rport->targetport)
|
|
|
|
nvmet_fc_rcv_fcp_abort(rport->targetport,
|
|
|
|
&tfcp_req->tgt_fcp_req);
|
|
|
|
|
|
|
|
/* break initiator/target relationship for io */
|
|
|
|
spin_lock(&tfcp_req->reqlock);
|
|
|
|
inireq->tfcp_req = NULL;
|
|
|
|
tfcp_req->fcpreq = NULL;
|
|
|
|
spin_unlock(&tfcp_req->reqlock);
|
|
|
|
|
|
|
|
/* post the aborted io completion */
|
|
|
|
fcpreq->status = -ECANCELED;
|
|
|
|
schedule_work(&inireq->iniwork);
|
2016-12-02 08:28:44 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
static void
|
|
|
|
fcloop_localport_delete(struct nvme_fc_local_port *localport)
|
|
|
|
{
|
|
|
|
struct fcloop_lport *lport = localport->private;
|
|
|
|
|
|
|
|
/* release any threads waiting for the unreg to complete */
|
|
|
|
complete(&lport->unreg_done);
|
|
|
|
}
|
|
|
|
|
|
|
|
static void
|
|
|
|
fcloop_remoteport_delete(struct nvme_fc_remote_port *remoteport)
|
|
|
|
{
|
|
|
|
struct fcloop_rport *rport = remoteport->private;
|
|
|
|
|
|
|
|
/* release any threads waiting for the unreg to complete */
|
|
|
|
complete(&rport->nport->rport_unreg_done);
|
|
|
|
}
|
|
|
|
|
|
|
|
static void
|
|
|
|
fcloop_targetport_delete(struct nvmet_fc_target_port *targetport)
|
|
|
|
{
|
|
|
|
struct fcloop_tport *tport = targetport->private;
|
|
|
|
|
|
|
|
/* release any threads waiting for the unreg to complete */
|
|
|
|
complete(&tport->nport->tport_unreg_done);
|
|
|
|
}
|
|
|
|
|
|
|
|
#define FCLOOP_HW_QUEUES 4
|
|
|
|
#define FCLOOP_SGL_SEGS 256
|
|
|
|
#define FCLOOP_DMABOUND_4G 0xFFFFFFFF
|
|
|
|
|
2017-04-21 08:37:25 +00:00
|
|
|
static struct nvme_fc_port_template fctemplate = {
|
2016-12-02 08:28:44 +00:00
|
|
|
.localport_delete = fcloop_localport_delete,
|
|
|
|
.remoteport_delete = fcloop_remoteport_delete,
|
|
|
|
.create_queue = fcloop_create_queue,
|
|
|
|
.delete_queue = fcloop_delete_queue,
|
|
|
|
.ls_req = fcloop_ls_req,
|
|
|
|
.fcp_io = fcloop_fcp_req,
|
|
|
|
.ls_abort = fcloop_ls_abort,
|
|
|
|
.fcp_abort = fcloop_fcp_abort,
|
|
|
|
.max_hw_queues = FCLOOP_HW_QUEUES,
|
|
|
|
.max_sgl_segments = FCLOOP_SGL_SEGS,
|
|
|
|
.max_dif_sgl_segments = FCLOOP_SGL_SEGS,
|
|
|
|
.dma_boundary = FCLOOP_DMABOUND_4G,
|
|
|
|
/* sizes of additional private data for data structures */
|
|
|
|
.local_priv_sz = sizeof(struct fcloop_lport),
|
|
|
|
.remote_priv_sz = sizeof(struct fcloop_rport),
|
|
|
|
.lsrqst_priv_sz = sizeof(struct fcloop_lsreq),
|
2017-04-11 18:32:30 +00:00
|
|
|
.fcprqst_priv_sz = sizeof(struct fcloop_ini_fcpreq),
|
2016-12-02 08:28:44 +00:00
|
|
|
};
|
|
|
|
|
2017-04-21 08:37:25 +00:00
|
|
|
static struct nvmet_fc_target_template tgttemplate = {
|
2016-12-02 08:28:44 +00:00
|
|
|
.targetport_delete = fcloop_targetport_delete,
|
|
|
|
.xmt_ls_rsp = fcloop_xmt_ls_rsp,
|
|
|
|
.fcp_op = fcloop_fcp_op,
|
nvmet_fc: Rework target side abort handling
target transport:
----------------------
There are cases when there is a need to abort in-progress target
operations (writedata) so that controller termination or errors can
clean up. That can't happen currently as the abort is another target
op type, so it can't be used till the running one finishes (and it may
not). Solve by removing the abort op type and creating a separate
downcall from the transport to the lldd to request an io to be aborted.
The transport will abort ios on queue teardown or io errors. In general
the transport tries to call the lldd abort only when the io state is
idle. Meaning: ops that transmit data (readdata or rsp) will always
finish their transmit (or the lldd will see a state on the
link or initiator port that fails the transmit) and the done call for
the operation will occur. The transport will wait for the op done
upcall before calling the abort function, and as the io is idle, the
io can be cleaned up immediately after the abort call; Similarly, ios
that are not waiting for data or transmitting data must be in the nvmet
layer being processed. The transport will wait for the nvmet layer
completion before calling the abort function, and as the io is idle,
the io can be cleaned up immediately after the abort call; As for ops
that are waiting for data (writedata), they may be outstanding
indefinitely if the lldd doesn't see a condition where the initiatior
port or link is bad. In those cases, the transport will call the abort
function and wait for the lldd's op done upcall for the operation, where
it will then clean up the io.
Additionally, if a lldd receives an ABTS and matches it to an outstanding
request in the transport, A new new transport upcall was created to abort
the outstanding request in the transport. The transport expects any
outstanding op call (readdata or writedata) will completed by the lldd and
the operation upcall made. The transport doesn't act on the reported
abort (e.g. clean up the io) until an op done upcall occurs, a new op is
attempted, or the nvmet layer completes the io processing.
fcloop:
----------------------
Updated to support the new target apis.
On fcp io aborts from the initiator, the loopback context is updated to
NULL out the half that has completed. The initiator side is immediately
called after the abort request with an io completion (abort status).
On fcp io aborts from the target, the io is stopped and the initiator side
sees it as an aborted io. Target side ops, perhaps in progress while the
initiator side is done, continue but noop the data movement as there's no
structure on the initiator side to reference.
patch also contains:
----------------------
Revised lpfc to support the new abort api
commonized rsp buffer syncing and nulling of private data based on
calling paths.
errors in op done calls don't take action on the fod. They're bad
operations which implies the fod may be bad.
Signed-off-by: James Smart <james.smart@broadcom.com>
Signed-off-by: Sagi Grimberg <sagi@grimberg.me>
2017-04-11 18:32:31 +00:00
|
|
|
.fcp_abort = fcloop_tgt_fcp_abort,
|
2017-04-11 18:32:29 +00:00
|
|
|
.fcp_req_release = fcloop_fcp_req_release,
|
2016-12-02 08:28:44 +00:00
|
|
|
.max_hw_queues = FCLOOP_HW_QUEUES,
|
|
|
|
.max_sgl_segments = FCLOOP_SGL_SEGS,
|
|
|
|
.max_dif_sgl_segments = FCLOOP_SGL_SEGS,
|
|
|
|
.dma_boundary = FCLOOP_DMABOUND_4G,
|
|
|
|
/* optional features */
|
nvmet_fc: add target feature flags for upcall isr contexts
Two new feature flags were added to control whether upcalls to the
transport result in context switches or stay in the calling context.
NVMET_FCTGTFEAT_CMD_IN_ISR:
By default, if the flag is not set, the transport assumes the
lldd is in a non-isr context and in the cpu context it should be
for the io queue. As such, the cmd handler is called directly in the
calling context.
If the flag is set, indicating the upcall is an isr context, the
transport mandates a transition to a workqueue. The workqueue assigned
to the queue is used for the context.
NVMET_FCTGTFEAT_OPDONE_IN_ISR
By default, if the flag is not set, the transport assumes the
lldd is in a non-isr context and in the cpu context it should be
for the io queue. As such, the fcp operation done callback is called
directly in the calling context.
If the flag is set, indicating the upcall is an isr context, the
transport mandates a transition to a workqueue. The workqueue assigned
to the queue is used for the context.
Updated lpfc for flags
Signed-off-by: James Smart <james.smart@broadcom.com>
Signed-off-by: Sagi Grimberg <sagi@grimberg.me>
2017-04-11 18:32:28 +00:00
|
|
|
.target_features = NVMET_FCTGTFEAT_CMD_IN_ISR |
|
|
|
|
NVMET_FCTGTFEAT_OPDONE_IN_ISR,
|
2016-12-02 08:28:44 +00:00
|
|
|
/* sizes of additional private data for data structures */
|
|
|
|
.target_priv_sz = sizeof(struct fcloop_tport),
|
|
|
|
};
|
|
|
|
|
|
|
|
static ssize_t
|
|
|
|
fcloop_create_local_port(struct device *dev, struct device_attribute *attr,
|
|
|
|
const char *buf, size_t count)
|
|
|
|
{
|
|
|
|
struct nvme_fc_port_info pinfo;
|
|
|
|
struct fcloop_ctrl_options *opts;
|
|
|
|
struct nvme_fc_local_port *localport;
|
|
|
|
struct fcloop_lport *lport;
|
|
|
|
int ret;
|
|
|
|
|
|
|
|
opts = kzalloc(sizeof(*opts), GFP_KERNEL);
|
|
|
|
if (!opts)
|
|
|
|
return -ENOMEM;
|
|
|
|
|
|
|
|
ret = fcloop_parse_options(opts, buf);
|
|
|
|
if (ret)
|
|
|
|
goto out_free_opts;
|
|
|
|
|
|
|
|
/* everything there ? */
|
|
|
|
if ((opts->mask & LPORT_OPTS) != LPORT_OPTS) {
|
|
|
|
ret = -EINVAL;
|
|
|
|
goto out_free_opts;
|
|
|
|
}
|
|
|
|
|
|
|
|
pinfo.node_name = opts->wwnn;
|
|
|
|
pinfo.port_name = opts->wwpn;
|
|
|
|
pinfo.port_role = opts->roles;
|
|
|
|
pinfo.port_id = opts->fcaddr;
|
|
|
|
|
|
|
|
ret = nvme_fc_register_localport(&pinfo, &fctemplate, NULL, &localport);
|
|
|
|
if (!ret) {
|
|
|
|
unsigned long flags;
|
|
|
|
|
|
|
|
/* success */
|
|
|
|
lport = localport->private;
|
|
|
|
lport->localport = localport;
|
|
|
|
INIT_LIST_HEAD(&lport->lport_list);
|
|
|
|
|
|
|
|
spin_lock_irqsave(&fcloop_lock, flags);
|
|
|
|
list_add_tail(&lport->lport_list, &fcloop_lports);
|
|
|
|
spin_unlock_irqrestore(&fcloop_lock, flags);
|
|
|
|
|
|
|
|
/* mark all of the input buffer consumed */
|
|
|
|
ret = count;
|
|
|
|
}
|
|
|
|
|
|
|
|
out_free_opts:
|
|
|
|
kfree(opts);
|
|
|
|
return ret ? ret : count;
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
static void
|
|
|
|
__unlink_local_port(struct fcloop_lport *lport)
|
|
|
|
{
|
|
|
|
list_del(&lport->lport_list);
|
|
|
|
}
|
|
|
|
|
|
|
|
static int
|
|
|
|
__wait_localport_unreg(struct fcloop_lport *lport)
|
|
|
|
{
|
|
|
|
int ret;
|
|
|
|
|
|
|
|
init_completion(&lport->unreg_done);
|
|
|
|
|
|
|
|
ret = nvme_fc_unregister_localport(lport->localport);
|
|
|
|
|
|
|
|
wait_for_completion(&lport->unreg_done);
|
|
|
|
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
static ssize_t
|
|
|
|
fcloop_delete_local_port(struct device *dev, struct device_attribute *attr,
|
|
|
|
const char *buf, size_t count)
|
|
|
|
{
|
|
|
|
struct fcloop_lport *tlport, *lport = NULL;
|
|
|
|
u64 nodename, portname;
|
|
|
|
unsigned long flags;
|
|
|
|
int ret;
|
|
|
|
|
|
|
|
ret = fcloop_parse_nm_options(dev, &nodename, &portname, buf);
|
|
|
|
if (ret)
|
|
|
|
return ret;
|
|
|
|
|
|
|
|
spin_lock_irqsave(&fcloop_lock, flags);
|
|
|
|
|
|
|
|
list_for_each_entry(tlport, &fcloop_lports, lport_list) {
|
|
|
|
if (tlport->localport->node_name == nodename &&
|
|
|
|
tlport->localport->port_name == portname) {
|
|
|
|
lport = tlport;
|
|
|
|
__unlink_local_port(lport);
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
spin_unlock_irqrestore(&fcloop_lock, flags);
|
|
|
|
|
|
|
|
if (!lport)
|
|
|
|
return -ENOENT;
|
|
|
|
|
|
|
|
ret = __wait_localport_unreg(lport);
|
|
|
|
|
|
|
|
return ret ? ret : count;
|
|
|
|
}
|
|
|
|
|
|
|
|
static void
|
|
|
|
fcloop_nport_free(struct kref *ref)
|
|
|
|
{
|
|
|
|
struct fcloop_nport *nport =
|
|
|
|
container_of(ref, struct fcloop_nport, ref);
|
|
|
|
unsigned long flags;
|
|
|
|
|
|
|
|
spin_lock_irqsave(&fcloop_lock, flags);
|
|
|
|
list_del(&nport->nport_list);
|
|
|
|
spin_unlock_irqrestore(&fcloop_lock, flags);
|
|
|
|
|
|
|
|
kfree(nport);
|
|
|
|
}
|
|
|
|
|
|
|
|
static void
|
|
|
|
fcloop_nport_put(struct fcloop_nport *nport)
|
|
|
|
{
|
|
|
|
kref_put(&nport->ref, fcloop_nport_free);
|
|
|
|
}
|
|
|
|
|
|
|
|
static int
|
|
|
|
fcloop_nport_get(struct fcloop_nport *nport)
|
|
|
|
{
|
|
|
|
return kref_get_unless_zero(&nport->ref);
|
|
|
|
}
|
|
|
|
|
|
|
|
static struct fcloop_nport *
|
|
|
|
fcloop_alloc_nport(const char *buf, size_t count, bool remoteport)
|
|
|
|
{
|
|
|
|
struct fcloop_nport *newnport, *nport = NULL;
|
|
|
|
struct fcloop_lport *tmplport, *lport = NULL;
|
|
|
|
struct fcloop_ctrl_options *opts;
|
|
|
|
unsigned long flags;
|
|
|
|
u32 opts_mask = (remoteport) ? RPORT_OPTS : TGTPORT_OPTS;
|
|
|
|
int ret;
|
|
|
|
|
|
|
|
opts = kzalloc(sizeof(*opts), GFP_KERNEL);
|
|
|
|
if (!opts)
|
|
|
|
return NULL;
|
|
|
|
|
|
|
|
ret = fcloop_parse_options(opts, buf);
|
|
|
|
if (ret)
|
|
|
|
goto out_free_opts;
|
|
|
|
|
|
|
|
/* everything there ? */
|
|
|
|
if ((opts->mask & opts_mask) != opts_mask) {
|
|
|
|
ret = -EINVAL;
|
|
|
|
goto out_free_opts;
|
|
|
|
}
|
|
|
|
|
|
|
|
newnport = kzalloc(sizeof(*newnport), GFP_KERNEL);
|
|
|
|
if (!newnport)
|
|
|
|
goto out_free_opts;
|
|
|
|
|
|
|
|
INIT_LIST_HEAD(&newnport->nport_list);
|
|
|
|
newnport->node_name = opts->wwnn;
|
|
|
|
newnport->port_name = opts->wwpn;
|
|
|
|
if (opts->mask & NVMF_OPT_ROLES)
|
|
|
|
newnport->port_role = opts->roles;
|
|
|
|
if (opts->mask & NVMF_OPT_FCADDR)
|
|
|
|
newnport->port_id = opts->fcaddr;
|
|
|
|
kref_init(&newnport->ref);
|
|
|
|
|
|
|
|
spin_lock_irqsave(&fcloop_lock, flags);
|
|
|
|
|
|
|
|
list_for_each_entry(tmplport, &fcloop_lports, lport_list) {
|
|
|
|
if (tmplport->localport->node_name == opts->wwnn &&
|
|
|
|
tmplport->localport->port_name == opts->wwpn)
|
|
|
|
goto out_invalid_opts;
|
|
|
|
|
|
|
|
if (tmplport->localport->node_name == opts->lpwwnn &&
|
|
|
|
tmplport->localport->port_name == opts->lpwwpn)
|
|
|
|
lport = tmplport;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (remoteport) {
|
|
|
|
if (!lport)
|
|
|
|
goto out_invalid_opts;
|
|
|
|
newnport->lport = lport;
|
|
|
|
}
|
|
|
|
|
|
|
|
list_for_each_entry(nport, &fcloop_nports, nport_list) {
|
|
|
|
if (nport->node_name == opts->wwnn &&
|
|
|
|
nport->port_name == opts->wwpn) {
|
|
|
|
if ((remoteport && nport->rport) ||
|
|
|
|
(!remoteport && nport->tport)) {
|
|
|
|
nport = NULL;
|
|
|
|
goto out_invalid_opts;
|
|
|
|
}
|
|
|
|
|
|
|
|
fcloop_nport_get(nport);
|
|
|
|
|
|
|
|
spin_unlock_irqrestore(&fcloop_lock, flags);
|
|
|
|
|
|
|
|
if (remoteport)
|
|
|
|
nport->lport = lport;
|
|
|
|
if (opts->mask & NVMF_OPT_ROLES)
|
|
|
|
nport->port_role = opts->roles;
|
|
|
|
if (opts->mask & NVMF_OPT_FCADDR)
|
|
|
|
nport->port_id = opts->fcaddr;
|
|
|
|
goto out_free_newnport;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
list_add_tail(&newnport->nport_list, &fcloop_nports);
|
|
|
|
|
|
|
|
spin_unlock_irqrestore(&fcloop_lock, flags);
|
|
|
|
|
|
|
|
kfree(opts);
|
|
|
|
return newnport;
|
|
|
|
|
|
|
|
out_invalid_opts:
|
|
|
|
spin_unlock_irqrestore(&fcloop_lock, flags);
|
|
|
|
out_free_newnport:
|
|
|
|
kfree(newnport);
|
|
|
|
out_free_opts:
|
|
|
|
kfree(opts);
|
|
|
|
return nport;
|
|
|
|
}
|
|
|
|
|
|
|
|
static ssize_t
|
|
|
|
fcloop_create_remote_port(struct device *dev, struct device_attribute *attr,
|
|
|
|
const char *buf, size_t count)
|
|
|
|
{
|
|
|
|
struct nvme_fc_remote_port *remoteport;
|
|
|
|
struct fcloop_nport *nport;
|
|
|
|
struct fcloop_rport *rport;
|
|
|
|
struct nvme_fc_port_info pinfo;
|
|
|
|
int ret;
|
|
|
|
|
|
|
|
nport = fcloop_alloc_nport(buf, count, true);
|
|
|
|
if (!nport)
|
|
|
|
return -EIO;
|
|
|
|
|
|
|
|
pinfo.node_name = nport->node_name;
|
|
|
|
pinfo.port_name = nport->port_name;
|
|
|
|
pinfo.port_role = nport->port_role;
|
|
|
|
pinfo.port_id = nport->port_id;
|
|
|
|
|
|
|
|
ret = nvme_fc_register_remoteport(nport->lport->localport,
|
|
|
|
&pinfo, &remoteport);
|
|
|
|
if (ret || !remoteport) {
|
|
|
|
fcloop_nport_put(nport);
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* success */
|
|
|
|
rport = remoteport->private;
|
|
|
|
rport->remoteport = remoteport;
|
|
|
|
rport->targetport = (nport->tport) ? nport->tport->targetport : NULL;
|
|
|
|
if (nport->tport) {
|
|
|
|
nport->tport->remoteport = remoteport;
|
|
|
|
nport->tport->lport = nport->lport;
|
|
|
|
}
|
|
|
|
rport->nport = nport;
|
|
|
|
rport->lport = nport->lport;
|
|
|
|
nport->rport = rport;
|
|
|
|
|
2016-12-09 14:59:47 +00:00
|
|
|
return count;
|
2016-12-02 08:28:44 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
static struct fcloop_rport *
|
|
|
|
__unlink_remote_port(struct fcloop_nport *nport)
|
|
|
|
{
|
|
|
|
struct fcloop_rport *rport = nport->rport;
|
|
|
|
|
|
|
|
if (rport && nport->tport)
|
|
|
|
nport->tport->remoteport = NULL;
|
|
|
|
nport->rport = NULL;
|
|
|
|
|
|
|
|
return rport;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int
|
|
|
|
__wait_remoteport_unreg(struct fcloop_nport *nport, struct fcloop_rport *rport)
|
|
|
|
{
|
|
|
|
int ret;
|
|
|
|
|
|
|
|
if (!rport)
|
|
|
|
return -EALREADY;
|
|
|
|
|
|
|
|
init_completion(&nport->rport_unreg_done);
|
|
|
|
|
|
|
|
ret = nvme_fc_unregister_remoteport(rport->remoteport);
|
|
|
|
if (ret)
|
|
|
|
return ret;
|
|
|
|
|
|
|
|
wait_for_completion(&nport->rport_unreg_done);
|
|
|
|
|
|
|
|
fcloop_nport_put(nport);
|
|
|
|
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
static ssize_t
|
|
|
|
fcloop_delete_remote_port(struct device *dev, struct device_attribute *attr,
|
|
|
|
const char *buf, size_t count)
|
|
|
|
{
|
|
|
|
struct fcloop_nport *nport = NULL, *tmpport;
|
|
|
|
static struct fcloop_rport *rport;
|
|
|
|
u64 nodename, portname;
|
|
|
|
unsigned long flags;
|
|
|
|
int ret;
|
|
|
|
|
|
|
|
ret = fcloop_parse_nm_options(dev, &nodename, &portname, buf);
|
|
|
|
if (ret)
|
|
|
|
return ret;
|
|
|
|
|
|
|
|
spin_lock_irqsave(&fcloop_lock, flags);
|
|
|
|
|
|
|
|
list_for_each_entry(tmpport, &fcloop_nports, nport_list) {
|
|
|
|
if (tmpport->node_name == nodename &&
|
|
|
|
tmpport->port_name == portname && tmpport->rport) {
|
|
|
|
nport = tmpport;
|
|
|
|
rport = __unlink_remote_port(nport);
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
spin_unlock_irqrestore(&fcloop_lock, flags);
|
|
|
|
|
|
|
|
if (!nport)
|
|
|
|
return -ENOENT;
|
|
|
|
|
|
|
|
ret = __wait_remoteport_unreg(nport, rport);
|
|
|
|
|
|
|
|
return ret ? ret : count;
|
|
|
|
}
|
|
|
|
|
|
|
|
static ssize_t
|
|
|
|
fcloop_create_target_port(struct device *dev, struct device_attribute *attr,
|
|
|
|
const char *buf, size_t count)
|
|
|
|
{
|
|
|
|
struct nvmet_fc_target_port *targetport;
|
|
|
|
struct fcloop_nport *nport;
|
|
|
|
struct fcloop_tport *tport;
|
|
|
|
struct nvmet_fc_port_info tinfo;
|
|
|
|
int ret;
|
|
|
|
|
|
|
|
nport = fcloop_alloc_nport(buf, count, false);
|
|
|
|
if (!nport)
|
|
|
|
return -EIO;
|
|
|
|
|
|
|
|
tinfo.node_name = nport->node_name;
|
|
|
|
tinfo.port_name = nport->port_name;
|
|
|
|
tinfo.port_id = nport->port_id;
|
|
|
|
|
|
|
|
ret = nvmet_fc_register_targetport(&tinfo, &tgttemplate, NULL,
|
|
|
|
&targetport);
|
|
|
|
if (ret) {
|
|
|
|
fcloop_nport_put(nport);
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* success */
|
|
|
|
tport = targetport->private;
|
|
|
|
tport->targetport = targetport;
|
|
|
|
tport->remoteport = (nport->rport) ? nport->rport->remoteport : NULL;
|
|
|
|
if (nport->rport)
|
|
|
|
nport->rport->targetport = targetport;
|
|
|
|
tport->nport = nport;
|
|
|
|
tport->lport = nport->lport;
|
|
|
|
nport->tport = tport;
|
|
|
|
|
2016-12-09 14:59:47 +00:00
|
|
|
return count;
|
2016-12-02 08:28:44 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
static struct fcloop_tport *
|
|
|
|
__unlink_target_port(struct fcloop_nport *nport)
|
|
|
|
{
|
|
|
|
struct fcloop_tport *tport = nport->tport;
|
|
|
|
|
|
|
|
if (tport && nport->rport)
|
|
|
|
nport->rport->targetport = NULL;
|
|
|
|
nport->tport = NULL;
|
|
|
|
|
|
|
|
return tport;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int
|
|
|
|
__wait_targetport_unreg(struct fcloop_nport *nport, struct fcloop_tport *tport)
|
|
|
|
{
|
|
|
|
int ret;
|
|
|
|
|
|
|
|
if (!tport)
|
|
|
|
return -EALREADY;
|
|
|
|
|
|
|
|
init_completion(&nport->tport_unreg_done);
|
|
|
|
|
|
|
|
ret = nvmet_fc_unregister_targetport(tport->targetport);
|
|
|
|
if (ret)
|
|
|
|
return ret;
|
|
|
|
|
|
|
|
wait_for_completion(&nport->tport_unreg_done);
|
|
|
|
|
|
|
|
fcloop_nport_put(nport);
|
|
|
|
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
static ssize_t
|
|
|
|
fcloop_delete_target_port(struct device *dev, struct device_attribute *attr,
|
|
|
|
const char *buf, size_t count)
|
|
|
|
{
|
|
|
|
struct fcloop_nport *nport = NULL, *tmpport;
|
|
|
|
struct fcloop_tport *tport;
|
|
|
|
u64 nodename, portname;
|
|
|
|
unsigned long flags;
|
|
|
|
int ret;
|
|
|
|
|
|
|
|
ret = fcloop_parse_nm_options(dev, &nodename, &portname, buf);
|
|
|
|
if (ret)
|
|
|
|
return ret;
|
|
|
|
|
|
|
|
spin_lock_irqsave(&fcloop_lock, flags);
|
|
|
|
|
|
|
|
list_for_each_entry(tmpport, &fcloop_nports, nport_list) {
|
|
|
|
if (tmpport->node_name == nodename &&
|
|
|
|
tmpport->port_name == portname && tmpport->tport) {
|
|
|
|
nport = tmpport;
|
|
|
|
tport = __unlink_target_port(nport);
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
spin_unlock_irqrestore(&fcloop_lock, flags);
|
|
|
|
|
|
|
|
if (!nport)
|
|
|
|
return -ENOENT;
|
|
|
|
|
|
|
|
ret = __wait_targetport_unreg(nport, tport);
|
|
|
|
|
|
|
|
return ret ? ret : count;
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
static DEVICE_ATTR(add_local_port, 0200, NULL, fcloop_create_local_port);
|
|
|
|
static DEVICE_ATTR(del_local_port, 0200, NULL, fcloop_delete_local_port);
|
|
|
|
static DEVICE_ATTR(add_remote_port, 0200, NULL, fcloop_create_remote_port);
|
|
|
|
static DEVICE_ATTR(del_remote_port, 0200, NULL, fcloop_delete_remote_port);
|
|
|
|
static DEVICE_ATTR(add_target_port, 0200, NULL, fcloop_create_target_port);
|
|
|
|
static DEVICE_ATTR(del_target_port, 0200, NULL, fcloop_delete_target_port);
|
|
|
|
|
|
|
|
static struct attribute *fcloop_dev_attrs[] = {
|
|
|
|
&dev_attr_add_local_port.attr,
|
|
|
|
&dev_attr_del_local_port.attr,
|
|
|
|
&dev_attr_add_remote_port.attr,
|
|
|
|
&dev_attr_del_remote_port.attr,
|
|
|
|
&dev_attr_add_target_port.attr,
|
|
|
|
&dev_attr_del_target_port.attr,
|
|
|
|
NULL
|
|
|
|
};
|
|
|
|
|
|
|
|
static struct attribute_group fclopp_dev_attrs_group = {
|
|
|
|
.attrs = fcloop_dev_attrs,
|
|
|
|
};
|
|
|
|
|
|
|
|
static const struct attribute_group *fcloop_dev_attr_groups[] = {
|
|
|
|
&fclopp_dev_attrs_group,
|
|
|
|
NULL,
|
|
|
|
};
|
|
|
|
|
|
|
|
static struct class *fcloop_class;
|
|
|
|
static struct device *fcloop_device;
|
|
|
|
|
|
|
|
|
|
|
|
static int __init fcloop_init(void)
|
|
|
|
{
|
|
|
|
int ret;
|
|
|
|
|
|
|
|
fcloop_class = class_create(THIS_MODULE, "fcloop");
|
|
|
|
if (IS_ERR(fcloop_class)) {
|
|
|
|
pr_err("couldn't register class fcloop\n");
|
|
|
|
ret = PTR_ERR(fcloop_class);
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
fcloop_device = device_create_with_groups(
|
|
|
|
fcloop_class, NULL, MKDEV(0, 0), NULL,
|
|
|
|
fcloop_dev_attr_groups, "ctl");
|
|
|
|
if (IS_ERR(fcloop_device)) {
|
|
|
|
pr_err("couldn't create ctl device!\n");
|
|
|
|
ret = PTR_ERR(fcloop_device);
|
|
|
|
goto out_destroy_class;
|
|
|
|
}
|
|
|
|
|
|
|
|
get_device(fcloop_device);
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
out_destroy_class:
|
|
|
|
class_destroy(fcloop_class);
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
static void __exit fcloop_exit(void)
|
|
|
|
{
|
|
|
|
struct fcloop_lport *lport;
|
|
|
|
struct fcloop_nport *nport;
|
|
|
|
struct fcloop_tport *tport;
|
|
|
|
struct fcloop_rport *rport;
|
|
|
|
unsigned long flags;
|
|
|
|
int ret;
|
|
|
|
|
|
|
|
spin_lock_irqsave(&fcloop_lock, flags);
|
|
|
|
|
|
|
|
for (;;) {
|
|
|
|
nport = list_first_entry_or_null(&fcloop_nports,
|
|
|
|
typeof(*nport), nport_list);
|
|
|
|
if (!nport)
|
|
|
|
break;
|
|
|
|
|
|
|
|
tport = __unlink_target_port(nport);
|
|
|
|
rport = __unlink_remote_port(nport);
|
|
|
|
|
|
|
|
spin_unlock_irqrestore(&fcloop_lock, flags);
|
|
|
|
|
|
|
|
ret = __wait_targetport_unreg(nport, tport);
|
|
|
|
if (ret)
|
|
|
|
pr_warn("%s: Failed deleting target port\n", __func__);
|
|
|
|
|
|
|
|
ret = __wait_remoteport_unreg(nport, rport);
|
|
|
|
if (ret)
|
|
|
|
pr_warn("%s: Failed deleting remote port\n", __func__);
|
|
|
|
|
|
|
|
spin_lock_irqsave(&fcloop_lock, flags);
|
|
|
|
}
|
|
|
|
|
|
|
|
for (;;) {
|
|
|
|
lport = list_first_entry_or_null(&fcloop_lports,
|
|
|
|
typeof(*lport), lport_list);
|
|
|
|
if (!lport)
|
|
|
|
break;
|
|
|
|
|
|
|
|
__unlink_local_port(lport);
|
|
|
|
|
|
|
|
spin_unlock_irqrestore(&fcloop_lock, flags);
|
|
|
|
|
|
|
|
ret = __wait_localport_unreg(lport);
|
|
|
|
if (ret)
|
|
|
|
pr_warn("%s: Failed deleting local port\n", __func__);
|
|
|
|
|
|
|
|
spin_lock_irqsave(&fcloop_lock, flags);
|
|
|
|
}
|
|
|
|
|
|
|
|
spin_unlock_irqrestore(&fcloop_lock, flags);
|
|
|
|
|
|
|
|
put_device(fcloop_device);
|
|
|
|
|
|
|
|
device_destroy(fcloop_class, MKDEV(0, 0));
|
|
|
|
class_destroy(fcloop_class);
|
|
|
|
}
|
|
|
|
|
|
|
|
module_init(fcloop_init);
|
|
|
|
module_exit(fcloop_exit);
|
|
|
|
|
|
|
|
MODULE_LICENSE("GPL v2");
|