2019-08-28 06:07:37 +00:00
|
|
|
// SPDX-License-Identifier: GPL-2.0-or-later
|
2005-11-04 00:52:49 +00:00
|
|
|
/*
|
|
|
|
* PCI Error Recovery Driver for RPA-compliant PPC64 platform.
|
2007-05-23 17:28:01 +00:00
|
|
|
* Copyright IBM Corp. 2004 2005
|
|
|
|
* Copyright Linas Vepstas <linas@linas.org> 2004, 2005
|
2005-11-04 00:52:49 +00:00
|
|
|
*
|
2007-05-23 17:28:01 +00:00
|
|
|
* Send comments and feedback to Linas Vepstas <linas@austin.ibm.com>
|
2005-11-04 00:52:49 +00:00
|
|
|
*/
|
|
|
|
#include <linux/delay.h>
|
|
|
|
#include <linux/interrupt.h>
|
2006-04-19 04:05:21 +00:00
|
|
|
#include <linux/irq.h>
|
2012-09-17 04:34:27 +00:00
|
|
|
#include <linux/module.h>
|
2005-11-04 00:52:49 +00:00
|
|
|
#include <linux/pci.h>
|
2019-09-03 10:15:55 +00:00
|
|
|
#include <linux/pci_hotplug.h>
|
2005-11-04 00:52:49 +00:00
|
|
|
#include <asm/eeh.h>
|
|
|
|
#include <asm/eeh_event.h>
|
|
|
|
#include <asm/ppc-pci.h>
|
|
|
|
#include <asm/pci-bridge.h>
|
|
|
|
#include <asm/rtas.h>
|
|
|
|
|
2016-03-03 23:53:11 +00:00
|
|
|
struct eeh_rmv_data {
|
2018-09-12 01:23:27 +00:00
|
|
|
struct list_head removed_vf_list;
|
|
|
|
int removed_dev_count;
|
2016-03-03 23:53:11 +00:00
|
|
|
};
|
|
|
|
|
2018-05-25 03:11:34 +00:00
|
|
|
static int eeh_result_priority(enum pci_ers_result result)
|
|
|
|
{
|
|
|
|
switch (result) {
|
|
|
|
case PCI_ERS_RESULT_NONE:
|
|
|
|
return 1;
|
|
|
|
case PCI_ERS_RESULT_NO_AER_DRIVER:
|
|
|
|
return 2;
|
|
|
|
case PCI_ERS_RESULT_RECOVERED:
|
|
|
|
return 3;
|
|
|
|
case PCI_ERS_RESULT_CAN_RECOVER:
|
|
|
|
return 4;
|
|
|
|
case PCI_ERS_RESULT_DISCONNECT:
|
|
|
|
return 5;
|
|
|
|
case PCI_ERS_RESULT_NEED_RESET:
|
|
|
|
return 6;
|
|
|
|
default:
|
2023-10-11 05:37:10 +00:00
|
|
|
WARN_ONCE(1, "Unknown pci_ers_result value: %d\n", result);
|
2018-05-25 03:11:34 +00:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
};
|
|
|
|
|
2018-10-22 14:54:13 +00:00
|
|
|
static const char *pci_ers_result_name(enum pci_ers_result result)
|
2018-05-25 03:11:40 +00:00
|
|
|
{
|
|
|
|
switch (result) {
|
|
|
|
case PCI_ERS_RESULT_NONE:
|
|
|
|
return "none";
|
|
|
|
case PCI_ERS_RESULT_CAN_RECOVER:
|
|
|
|
return "can recover";
|
|
|
|
case PCI_ERS_RESULT_NEED_RESET:
|
|
|
|
return "need reset";
|
|
|
|
case PCI_ERS_RESULT_DISCONNECT:
|
|
|
|
return "disconnect";
|
|
|
|
case PCI_ERS_RESULT_RECOVERED:
|
|
|
|
return "recovered";
|
|
|
|
case PCI_ERS_RESULT_NO_AER_DRIVER:
|
|
|
|
return "no AER driver";
|
|
|
|
default:
|
2023-10-11 05:37:10 +00:00
|
|
|
WARN_ONCE(1, "Unknown result type: %d\n", result);
|
2018-05-25 03:11:40 +00:00
|
|
|
return "unknown";
|
|
|
|
}
|
|
|
|
};
|
|
|
|
|
2018-05-25 03:11:34 +00:00
|
|
|
static enum pci_ers_result pci_ers_merge_result(enum pci_ers_result old,
|
|
|
|
enum pci_ers_result new)
|
|
|
|
{
|
|
|
|
if (eeh_result_priority(new) > eeh_result_priority(old))
|
|
|
|
return new;
|
|
|
|
return old;
|
|
|
|
}
|
|
|
|
|
2018-05-25 03:11:36 +00:00
|
|
|
static bool eeh_dev_removed(struct eeh_dev *edev)
|
|
|
|
{
|
|
|
|
return !edev || (edev->mode & EEH_DEV_REMOVED);
|
|
|
|
}
|
|
|
|
|
|
|
|
static bool eeh_edev_actionable(struct eeh_dev *edev)
|
|
|
|
{
|
2019-09-03 10:15:54 +00:00
|
|
|
if (!edev->pdev)
|
|
|
|
return false;
|
|
|
|
if (edev->pdev->error_state == pci_channel_io_perm_failure)
|
|
|
|
return false;
|
|
|
|
if (eeh_dev_removed(edev))
|
|
|
|
return false;
|
|
|
|
if (eeh_pe_passed(edev->pe))
|
|
|
|
return false;
|
|
|
|
|
|
|
|
return true;
|
2018-05-25 03:11:36 +00:00
|
|
|
}
|
|
|
|
|
2012-09-17 04:34:27 +00:00
|
|
|
/**
|
|
|
|
* eeh_pcid_get - Get the PCI device driver
|
|
|
|
* @pdev: PCI device
|
|
|
|
*
|
|
|
|
* The function is used to retrieve the PCI device driver for
|
|
|
|
* the indicated PCI device. Besides, we will increase the reference
|
|
|
|
* of the PCI device driver to prevent that being unloaded on
|
|
|
|
* the fly. Otherwise, kernel crash would be seen.
|
|
|
|
*/
|
|
|
|
static inline struct pci_driver *eeh_pcid_get(struct pci_dev *pdev)
|
|
|
|
{
|
2021-10-12 21:37:55 +00:00
|
|
|
if (!pdev || !pdev->dev.driver)
|
2012-09-17 04:34:27 +00:00
|
|
|
return NULL;
|
|
|
|
|
2021-10-12 21:37:55 +00:00
|
|
|
if (!try_module_get(pdev->dev.driver->owner))
|
2012-09-17 04:34:27 +00:00
|
|
|
return NULL;
|
|
|
|
|
2021-10-12 21:37:55 +00:00
|
|
|
return to_pci_driver(pdev->dev.driver);
|
2012-09-17 04:34:27 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* eeh_pcid_put - Dereference on the PCI device driver
|
|
|
|
* @pdev: PCI device
|
|
|
|
*
|
|
|
|
* The function is called to do dereference on the PCI device
|
|
|
|
* driver of the indicated PCI device.
|
|
|
|
*/
|
|
|
|
static inline void eeh_pcid_put(struct pci_dev *pdev)
|
|
|
|
{
|
2021-10-12 21:37:55 +00:00
|
|
|
if (!pdev || !pdev->dev.driver)
|
2012-09-17 04:34:27 +00:00
|
|
|
return;
|
|
|
|
|
2021-10-12 21:37:55 +00:00
|
|
|
module_put(pdev->dev.driver->owner);
|
2012-09-17 04:34:27 +00:00
|
|
|
}
|
|
|
|
|
2009-02-10 11:12:21 +00:00
|
|
|
/**
|
2012-02-27 20:04:02 +00:00
|
|
|
* eeh_disable_irq - Disable interrupt for the recovering device
|
|
|
|
* @dev: PCI device
|
|
|
|
*
|
|
|
|
* This routine must be called when reporting temporary or permanent
|
|
|
|
* error to the particular PCI device to disable interrupt of that
|
|
|
|
* device. If the device has enabled MSI or MSI-X interrupt, we needn't
|
|
|
|
* do real work because EEH should freeze DMA transfers for those PCI
|
|
|
|
* devices encountering EEH errors, which includes MSI or MSI-X.
|
2009-02-10 11:12:21 +00:00
|
|
|
*/
|
2018-05-25 03:11:38 +00:00
|
|
|
static void eeh_disable_irq(struct eeh_dev *edev)
|
2009-02-10 11:12:21 +00:00
|
|
|
{
|
|
|
|
/* Don't disable MSI and MSI-X interrupts. They are
|
|
|
|
* effectively disabled by the DMA Stopped state
|
|
|
|
* when an EEH error occurs.
|
2012-02-27 20:04:02 +00:00
|
|
|
*/
|
2018-05-25 03:11:38 +00:00
|
|
|
if (edev->pdev->msi_enabled || edev->pdev->msix_enabled)
|
2009-02-10 11:12:21 +00:00
|
|
|
return;
|
|
|
|
|
2018-05-25 03:11:38 +00:00
|
|
|
if (!irq_has_action(edev->pdev->irq))
|
2009-02-10 11:12:21 +00:00
|
|
|
return;
|
|
|
|
|
2012-09-07 22:44:20 +00:00
|
|
|
edev->mode |= EEH_DEV_IRQ_DISABLED;
|
2018-05-25 03:11:38 +00:00
|
|
|
disable_irq_nosync(edev->pdev->irq);
|
2009-02-10 11:12:21 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
2012-02-27 20:04:02 +00:00
|
|
|
* eeh_enable_irq - Enable interrupt for the recovering device
|
|
|
|
* @dev: PCI device
|
|
|
|
*
|
|
|
|
* This routine must be called to enable interrupt while failed
|
|
|
|
* device could be resumed.
|
2009-02-10 11:12:21 +00:00
|
|
|
*/
|
2018-05-25 03:11:38 +00:00
|
|
|
static void eeh_enable_irq(struct eeh_dev *edev)
|
2009-02-10 11:12:21 +00:00
|
|
|
{
|
2012-09-07 22:44:20 +00:00
|
|
|
if ((edev->mode) & EEH_DEV_IRQ_DISABLED) {
|
|
|
|
edev->mode &= ~EEH_DEV_IRQ_DISABLED;
|
2014-02-23 21:40:09 +00:00
|
|
|
/*
|
|
|
|
* FIXME !!!!!
|
|
|
|
*
|
|
|
|
* This is just ass backwards. This maze has
|
|
|
|
* unbalanced irq_enable/disable calls. So instead of
|
|
|
|
* finding the root cause it works around the warning
|
|
|
|
* in the irq_enable code by conditionally calling
|
|
|
|
* into it.
|
|
|
|
*
|
|
|
|
* That's just wrong.The warning in the core code is
|
2016-06-01 06:34:37 +00:00
|
|
|
* there to tell people to fix their asymmetries in
|
2014-02-23 21:40:09 +00:00
|
|
|
* their own code, not by abusing the core information
|
|
|
|
* to avoid it.
|
|
|
|
*
|
|
|
|
* I so wish that the assymetry would be the other way
|
|
|
|
* round and a few more irq_disable calls render that
|
|
|
|
* shit unusable forever.
|
|
|
|
*
|
|
|
|
* tglx
|
|
|
|
*/
|
2018-05-25 03:11:38 +00:00
|
|
|
if (irqd_irq_disabled(irq_get_irq_data(edev->pdev->irq)))
|
|
|
|
enable_irq(edev->pdev->irq);
|
2014-03-04 23:06:11 +00:00
|
|
|
}
|
2009-02-10 11:12:21 +00:00
|
|
|
}
|
|
|
|
|
2019-08-16 04:48:15 +00:00
|
|
|
static void eeh_dev_save_state(struct eeh_dev *edev, void *userdata)
|
2014-09-30 02:39:07 +00:00
|
|
|
{
|
|
|
|
struct pci_dev *pdev;
|
|
|
|
|
|
|
|
if (!edev)
|
2019-08-16 04:48:15 +00:00
|
|
|
return;
|
2014-09-30 02:39:07 +00:00
|
|
|
|
2016-04-27 01:14:51 +00:00
|
|
|
/*
|
|
|
|
* We cannot access the config space on some adapters.
|
|
|
|
* Otherwise, it will cause fenced PHB. We don't save
|
|
|
|
* the content in their config space and will restore
|
|
|
|
* from the initial config space saved when the EEH
|
|
|
|
* device is created.
|
|
|
|
*/
|
|
|
|
if (edev->pe && (edev->pe->state & EEH_PE_CFG_RESTRICTED))
|
2019-08-16 04:48:15 +00:00
|
|
|
return;
|
2016-04-27 01:14:51 +00:00
|
|
|
|
2014-09-30 02:39:07 +00:00
|
|
|
pdev = eeh_dev_to_pci_dev(edev);
|
|
|
|
if (!pdev)
|
2019-08-16 04:48:15 +00:00
|
|
|
return;
|
2014-09-30 02:39:07 +00:00
|
|
|
|
|
|
|
pci_save_state(pdev);
|
|
|
|
}
|
|
|
|
|
2020-07-02 16:26:49 +00:00
|
|
|
static void eeh_set_channel_state(struct eeh_pe *root, pci_channel_state_t s)
|
2018-05-25 03:11:37 +00:00
|
|
|
{
|
|
|
|
struct eeh_pe *pe;
|
|
|
|
struct eeh_dev *edev, *tmp;
|
|
|
|
|
|
|
|
eeh_for_each_pe(root, pe)
|
|
|
|
eeh_pe_for_each_dev(pe, edev, tmp)
|
|
|
|
if (eeh_edev_actionable(edev))
|
|
|
|
edev->pdev->error_state = s;
|
|
|
|
}
|
|
|
|
|
2018-05-25 03:11:38 +00:00
|
|
|
static void eeh_set_irq_state(struct eeh_pe *root, bool enable)
|
|
|
|
{
|
|
|
|
struct eeh_pe *pe;
|
|
|
|
struct eeh_dev *edev, *tmp;
|
|
|
|
|
|
|
|
eeh_for_each_pe(root, pe) {
|
|
|
|
eeh_pe_for_each_dev(pe, edev, tmp) {
|
|
|
|
if (!eeh_edev_actionable(edev))
|
|
|
|
continue;
|
|
|
|
|
|
|
|
if (!eeh_pcid_get(edev->pdev))
|
|
|
|
continue;
|
|
|
|
|
|
|
|
if (enable)
|
|
|
|
eeh_enable_irq(edev);
|
|
|
|
else
|
|
|
|
eeh_disable_irq(edev);
|
|
|
|
|
|
|
|
eeh_pcid_put(edev->pdev);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2018-05-25 03:11:40 +00:00
|
|
|
typedef enum pci_ers_result (*eeh_report_fn)(struct eeh_dev *,
|
2019-08-16 04:48:14 +00:00
|
|
|
struct pci_dev *,
|
2018-05-25 03:11:40 +00:00
|
|
|
struct pci_driver *);
|
|
|
|
static void eeh_pe_report_edev(struct eeh_dev *edev, eeh_report_fn fn,
|
|
|
|
enum pci_ers_result *result)
|
2005-11-04 00:52:49 +00:00
|
|
|
{
|
2019-08-16 04:48:14 +00:00
|
|
|
struct pci_dev *pdev;
|
2012-09-17 04:34:27 +00:00
|
|
|
struct pci_driver *driver;
|
2018-05-25 03:11:40 +00:00
|
|
|
enum pci_ers_result new_result;
|
|
|
|
|
2019-08-16 04:48:14 +00:00
|
|
|
pci_lock_rescan_remove();
|
|
|
|
pdev = edev->pdev;
|
|
|
|
if (pdev)
|
|
|
|
get_device(&pdev->dev);
|
|
|
|
pci_unlock_rescan_remove();
|
|
|
|
if (!pdev) {
|
2018-09-12 01:23:21 +00:00
|
|
|
eeh_edev_info(edev, "no device");
|
|
|
|
return;
|
|
|
|
}
|
2019-08-16 04:48:14 +00:00
|
|
|
device_lock(&pdev->dev);
|
2018-05-25 03:11:40 +00:00
|
|
|
if (eeh_edev_actionable(edev)) {
|
2019-08-16 04:48:14 +00:00
|
|
|
driver = eeh_pcid_get(pdev);
|
2018-05-25 03:11:40 +00:00
|
|
|
|
|
|
|
if (!driver)
|
|
|
|
eeh_edev_info(edev, "no driver");
|
|
|
|
else if (!driver->err_handler)
|
|
|
|
eeh_edev_info(edev, "driver not EEH aware");
|
|
|
|
else if (edev->mode & EEH_DEV_NO_HANDLER)
|
|
|
|
eeh_edev_info(edev, "driver bound too late");
|
|
|
|
else {
|
2019-08-16 04:48:14 +00:00
|
|
|
new_result = fn(edev, pdev, driver);
|
2018-05-25 03:11:40 +00:00
|
|
|
eeh_edev_info(edev, "%s driver reports: '%s'",
|
|
|
|
driver->name,
|
|
|
|
pci_ers_result_name(new_result));
|
|
|
|
if (result)
|
|
|
|
*result = pci_ers_merge_result(*result,
|
|
|
|
new_result);
|
|
|
|
}
|
|
|
|
if (driver)
|
2019-08-16 04:48:14 +00:00
|
|
|
eeh_pcid_put(pdev);
|
2018-05-25 03:11:40 +00:00
|
|
|
} else {
|
2019-08-16 04:48:14 +00:00
|
|
|
eeh_edev_info(edev, "not actionable (%d,%d,%d)", !!pdev,
|
2018-05-25 03:11:40 +00:00
|
|
|
!eeh_dev_removed(edev), !eeh_pe_passed(edev->pe));
|
|
|
|
}
|
2019-08-16 04:48:14 +00:00
|
|
|
device_unlock(&pdev->dev);
|
|
|
|
if (edev->pdev != pdev)
|
|
|
|
eeh_edev_warn(edev, "Device changed during processing!\n");
|
|
|
|
put_device(&pdev->dev);
|
2018-05-25 03:11:40 +00:00
|
|
|
}
|
2005-11-04 00:52:49 +00:00
|
|
|
|
2018-05-25 03:11:40 +00:00
|
|
|
static void eeh_pe_report(const char *name, struct eeh_pe *root,
|
|
|
|
eeh_report_fn fn, enum pci_ers_result *result)
|
|
|
|
{
|
|
|
|
struct eeh_pe *pe;
|
|
|
|
struct eeh_dev *edev, *tmp;
|
2018-03-26 04:17:07 +00:00
|
|
|
|
2018-05-25 03:11:40 +00:00
|
|
|
pr_info("EEH: Beginning: '%s'\n", name);
|
|
|
|
eeh_for_each_pe(root, pe) eeh_pe_for_each_dev(pe, edev, tmp)
|
|
|
|
eeh_pe_report_edev(edev, fn, result);
|
|
|
|
if (result)
|
|
|
|
pr_info("EEH: Finished:'%s' with aggregate recovery state:'%s'\n",
|
|
|
|
name, pci_ers_result_name(*result));
|
|
|
|
else
|
|
|
|
pr_info("EEH: Finished:'%s'", name);
|
|
|
|
}
|
2005-11-04 00:52:49 +00:00
|
|
|
|
2018-05-25 03:11:40 +00:00
|
|
|
/**
|
|
|
|
* eeh_report_error - Report pci error to each device driver
|
|
|
|
* @edev: eeh device
|
|
|
|
* @driver: device's PCI driver
|
|
|
|
*
|
|
|
|
* Report an EEH error to each device driver.
|
|
|
|
*/
|
|
|
|
static enum pci_ers_result eeh_report_error(struct eeh_dev *edev,
|
2019-08-16 04:48:14 +00:00
|
|
|
struct pci_dev *pdev,
|
2018-05-25 03:11:40 +00:00
|
|
|
struct pci_driver *driver)
|
|
|
|
{
|
|
|
|
enum pci_ers_result rc;
|
2005-11-04 00:52:49 +00:00
|
|
|
|
2018-05-25 03:11:40 +00:00
|
|
|
if (!driver->err_handler->error_detected)
|
|
|
|
return PCI_ERS_RESULT_NONE;
|
2005-11-04 00:52:49 +00:00
|
|
|
|
2018-05-25 03:11:40 +00:00
|
|
|
eeh_edev_info(edev, "Invoking %s->error_detected(IO frozen)",
|
|
|
|
driver->name);
|
2019-08-16 04:48:14 +00:00
|
|
|
rc = driver->err_handler->error_detected(pdev, pci_channel_io_frozen);
|
2007-11-02 20:27:50 +00:00
|
|
|
|
2016-03-03 23:53:11 +00:00
|
|
|
edev->in_error = true;
|
2019-08-16 04:48:14 +00:00
|
|
|
pci_uevent_ers(pdev, PCI_ERS_RESULT_NONE);
|
2018-05-25 03:11:40 +00:00
|
|
|
return rc;
|
2006-09-15 23:58:59 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
2012-02-27 20:04:02 +00:00
|
|
|
* eeh_report_mmio_enabled - Tell drivers that MMIO has been enabled
|
2018-05-25 03:11:40 +00:00
|
|
|
* @edev: eeh device
|
|
|
|
* @driver: device's PCI driver
|
2006-09-15 23:58:59 +00:00
|
|
|
*
|
2007-11-02 20:25:55 +00:00
|
|
|
* Tells each device driver that IO ports, MMIO and config space I/O
|
2018-05-25 03:11:40 +00:00
|
|
|
* are now enabled.
|
2006-09-15 23:58:59 +00:00
|
|
|
*/
|
2018-05-25 03:11:40 +00:00
|
|
|
static enum pci_ers_result eeh_report_mmio_enabled(struct eeh_dev *edev,
|
2019-08-16 04:48:14 +00:00
|
|
|
struct pci_dev *pdev,
|
2018-05-25 03:11:40 +00:00
|
|
|
struct pci_driver *driver)
|
2006-09-15 23:58:59 +00:00
|
|
|
{
|
2018-05-25 03:11:40 +00:00
|
|
|
if (!driver->err_handler->mmio_enabled)
|
|
|
|
return PCI_ERS_RESULT_NONE;
|
|
|
|
eeh_edev_info(edev, "Invoking %s->mmio_enabled()", driver->name);
|
2019-08-16 04:48:14 +00:00
|
|
|
return driver->err_handler->mmio_enabled(pdev);
|
2005-11-04 00:52:49 +00:00
|
|
|
}
|
|
|
|
|
2006-09-15 23:56:35 +00:00
|
|
|
/**
|
2012-02-27 20:04:02 +00:00
|
|
|
* eeh_report_reset - Tell device that slot has been reset
|
2018-05-25 03:11:40 +00:00
|
|
|
* @edev: eeh device
|
|
|
|
* @driver: device's PCI driver
|
2012-02-27 20:04:02 +00:00
|
|
|
*
|
|
|
|
* This routine must be called while EEH tries to reset particular
|
|
|
|
* PCI device so that the associated PCI device driver could take
|
|
|
|
* some actions, usually to save data the driver needs so that the
|
|
|
|
* driver can work again while the device is recovered.
|
2005-11-04 00:52:49 +00:00
|
|
|
*/
|
2018-05-25 03:11:40 +00:00
|
|
|
static enum pci_ers_result eeh_report_reset(struct eeh_dev *edev,
|
2019-08-16 04:48:14 +00:00
|
|
|
struct pci_dev *pdev,
|
2018-05-25 03:11:40 +00:00
|
|
|
struct pci_driver *driver)
|
2005-11-04 00:52:49 +00:00
|
|
|
{
|
2018-05-25 03:11:40 +00:00
|
|
|
if (!driver->err_handler->slot_reset || !edev->in_error)
|
|
|
|
return PCI_ERS_RESULT_NONE;
|
|
|
|
eeh_edev_info(edev, "Invoking %s->slot_reset()", driver->name);
|
2019-08-16 04:48:14 +00:00
|
|
|
return driver->err_handler->slot_reset(pdev);
|
2005-11-04 00:52:49 +00:00
|
|
|
}
|
|
|
|
|
2019-08-16 04:48:15 +00:00
|
|
|
static void eeh_dev_restore_state(struct eeh_dev *edev, void *userdata)
|
2014-09-30 02:39:07 +00:00
|
|
|
{
|
|
|
|
struct pci_dev *pdev;
|
|
|
|
|
|
|
|
if (!edev)
|
2019-08-16 04:48:15 +00:00
|
|
|
return;
|
2014-09-30 02:39:07 +00:00
|
|
|
|
2016-04-27 01:14:51 +00:00
|
|
|
/*
|
|
|
|
* The content in the config space isn't saved because
|
|
|
|
* the blocked config space on some adapters. We have
|
|
|
|
* to restore the initial saved config space when the
|
|
|
|
* EEH device is created.
|
|
|
|
*/
|
|
|
|
if (edev->pe && (edev->pe->state & EEH_PE_CFG_RESTRICTED)) {
|
2018-09-12 01:23:26 +00:00
|
|
|
if (list_is_last(&edev->entry, &edev->pe->edevs))
|
2016-04-27 01:14:51 +00:00
|
|
|
eeh_pe_restore_bars(edev->pe);
|
|
|
|
|
2019-08-16 04:48:15 +00:00
|
|
|
return;
|
2016-04-27 01:14:51 +00:00
|
|
|
}
|
|
|
|
|
2014-09-30 02:39:07 +00:00
|
|
|
pdev = eeh_dev_to_pci_dev(edev);
|
|
|
|
if (!pdev)
|
2019-08-16 04:48:15 +00:00
|
|
|
return;
|
2014-09-30 02:39:07 +00:00
|
|
|
|
|
|
|
pci_restore_state(pdev);
|
|
|
|
}
|
|
|
|
|
2006-09-15 23:56:35 +00:00
|
|
|
/**
|
2012-02-27 20:04:02 +00:00
|
|
|
* eeh_report_resume - Tell device to resume normal operations
|
2018-05-25 03:11:40 +00:00
|
|
|
* @edev: eeh device
|
|
|
|
* @driver: device's PCI driver
|
2012-02-27 20:04:02 +00:00
|
|
|
*
|
|
|
|
* This routine must be called to notify the device driver that it
|
|
|
|
* could resume so that the device driver can do some initialization
|
|
|
|
* to make the recovered device work again.
|
2006-09-15 23:56:35 +00:00
|
|
|
*/
|
2018-05-25 03:11:40 +00:00
|
|
|
static enum pci_ers_result eeh_report_resume(struct eeh_dev *edev,
|
2019-08-16 04:48:14 +00:00
|
|
|
struct pci_dev *pdev,
|
2018-05-25 03:11:40 +00:00
|
|
|
struct pci_driver *driver)
|
2005-11-04 00:52:49 +00:00
|
|
|
{
|
2018-05-25 03:11:40 +00:00
|
|
|
if (!driver->err_handler->resume || !edev->in_error)
|
|
|
|
return PCI_ERS_RESULT_NONE;
|
2006-12-06 18:32:20 +00:00
|
|
|
|
2018-05-25 03:11:40 +00:00
|
|
|
eeh_edev_info(edev, "Invoking %s->resume()", driver->name);
|
2019-08-16 04:48:14 +00:00
|
|
|
driver->err_handler->resume(pdev);
|
2009-02-10 11:12:21 +00:00
|
|
|
|
2018-05-25 03:11:40 +00:00
|
|
|
pci_uevent_ers(edev->pdev, PCI_ERS_RESULT_RECOVERED);
|
2018-01-05 16:45:47 +00:00
|
|
|
#ifdef CONFIG_PCI_IOV
|
2020-07-25 08:12:25 +00:00
|
|
|
if (eeh_ops->notify_resume)
|
|
|
|
eeh_ops->notify_resume(edev);
|
2018-01-05 16:45:47 +00:00
|
|
|
#endif
|
2018-05-25 03:11:40 +00:00
|
|
|
return PCI_ERS_RESULT_NONE;
|
2005-11-04 00:52:49 +00:00
|
|
|
}
|
|
|
|
|
2006-09-15 23:56:35 +00:00
|
|
|
/**
|
2012-02-27 20:04:02 +00:00
|
|
|
* eeh_report_failure - Tell device driver that device is dead.
|
2018-05-25 03:11:40 +00:00
|
|
|
* @edev: eeh device
|
|
|
|
* @driver: device's PCI driver
|
2006-09-15 23:56:35 +00:00
|
|
|
*
|
|
|
|
* This informs the device driver that the device is permanently
|
|
|
|
* dead, and that no further recovery attempts will be made on it.
|
|
|
|
*/
|
2018-05-25 03:11:40 +00:00
|
|
|
static enum pci_ers_result eeh_report_failure(struct eeh_dev *edev,
|
2019-08-16 04:48:14 +00:00
|
|
|
struct pci_dev *pdev,
|
2018-05-25 03:11:40 +00:00
|
|
|
struct pci_driver *driver)
|
2005-11-04 00:52:49 +00:00
|
|
|
{
|
2018-05-25 03:11:40 +00:00
|
|
|
enum pci_ers_result rc;
|
2005-11-04 00:52:49 +00:00
|
|
|
|
2018-05-25 03:11:40 +00:00
|
|
|
if (!driver->err_handler->error_detected)
|
|
|
|
return PCI_ERS_RESULT_NONE;
|
2009-02-10 11:12:21 +00:00
|
|
|
|
2018-05-25 03:11:40 +00:00
|
|
|
eeh_edev_info(edev, "Invoking %s->error_detected(permanent failure)",
|
|
|
|
driver->name);
|
2019-08-16 04:48:14 +00:00
|
|
|
rc = driver->err_handler->error_detected(pdev,
|
2018-05-25 03:11:40 +00:00
|
|
|
pci_channel_io_perm_failure);
|
2009-06-16 05:34:38 +00:00
|
|
|
|
2019-08-16 04:48:14 +00:00
|
|
|
pci_uevent_ers(pdev, PCI_ERS_RESULT_DISCONNECT);
|
2018-05-25 03:11:40 +00:00
|
|
|
return rc;
|
2005-11-04 00:52:49 +00:00
|
|
|
}
|
|
|
|
|
2018-09-12 01:23:25 +00:00
|
|
|
static void *eeh_add_virt_device(struct eeh_dev *edev)
|
2016-03-03 23:53:11 +00:00
|
|
|
{
|
|
|
|
struct pci_driver *driver;
|
|
|
|
struct pci_dev *dev = eeh_dev_to_pci_dev(edev);
|
|
|
|
|
|
|
|
if (!(edev->physfn)) {
|
2019-08-16 04:48:13 +00:00
|
|
|
eeh_edev_warn(edev, "Not for VF\n");
|
2016-03-03 23:53:11 +00:00
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
|
|
|
|
driver = eeh_pcid_get(dev);
|
|
|
|
if (driver) {
|
2018-05-25 03:11:30 +00:00
|
|
|
if (driver->err_handler) {
|
|
|
|
eeh_pcid_put(dev);
|
2016-03-03 23:53:11 +00:00
|
|
|
return NULL;
|
2018-05-25 03:11:30 +00:00
|
|
|
}
|
|
|
|
eeh_pcid_put(dev);
|
2016-03-03 23:53:11 +00:00
|
|
|
}
|
|
|
|
|
2017-11-09 14:00:33 +00:00
|
|
|
#ifdef CONFIG_PCI_IOV
|
2020-07-25 08:12:20 +00:00
|
|
|
pci_iov_add_virtfn(edev->physfn, edev->vf_index);
|
2016-03-03 23:53:11 +00:00
|
|
|
#endif
|
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
|
2019-08-16 04:48:15 +00:00
|
|
|
static void eeh_rmv_device(struct eeh_dev *edev, void *userdata)
|
powerpc/eeh: Use partial hotplug for EEH unaware drivers
When EEH error happens to one specific PE, some devices with drivers
supporting EEH won't except hotplug on the device. However, there
might have other deivces without driver, or with driver without EEH
support. For the case, we need do partial hotplug in order to make
sure that the PE becomes absolutely quite during reset. Otherise,
the PE reset might fail and leads to failure of error recovery.
The current code doesn't handle that 'mixed' case properly, it either
uses the error callbacks to the drivers, or tries hotplug, but doesn't
handle a PE (EEH domain) composed of a combination of the two.
The patch intends to support so-called "partial" hotplug for EEH:
Before we do reset, we stop and remove those PCI devices without
EEH sensitive driver. The corresponding EEH devices are not detached
from its PE, but with special flag. After the reset is done, those
EEH devices with the special flag will be scanned one by one.
Signed-off-by: Gavin Shan <shangw@linux.vnet.ibm.com>
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
2013-07-24 02:24:58 +00:00
|
|
|
{
|
|
|
|
struct pci_driver *driver;
|
|
|
|
struct pci_dev *dev = eeh_dev_to_pci_dev(edev);
|
2016-03-03 23:53:11 +00:00
|
|
|
struct eeh_rmv_data *rmv_data = (struct eeh_rmv_data *)userdata;
|
powerpc/eeh: Use partial hotplug for EEH unaware drivers
When EEH error happens to one specific PE, some devices with drivers
supporting EEH won't except hotplug on the device. However, there
might have other deivces without driver, or with driver without EEH
support. For the case, we need do partial hotplug in order to make
sure that the PE becomes absolutely quite during reset. Otherise,
the PE reset might fail and leads to failure of error recovery.
The current code doesn't handle that 'mixed' case properly, it either
uses the error callbacks to the drivers, or tries hotplug, but doesn't
handle a PE (EEH domain) composed of a combination of the two.
The patch intends to support so-called "partial" hotplug for EEH:
Before we do reset, we stop and remove those PCI devices without
EEH sensitive driver. The corresponding EEH devices are not detached
from its PE, but with special flag. After the reset is done, those
EEH devices with the special flag will be scanned one by one.
Signed-off-by: Gavin Shan <shangw@linux.vnet.ibm.com>
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
2013-07-24 02:24:58 +00:00
|
|
|
|
|
|
|
/*
|
|
|
|
* Actually, we should remove the PCI bridges as well.
|
|
|
|
* However, that's lots of complexity to do that,
|
|
|
|
* particularly some of devices under the bridge might
|
|
|
|
* support EEH. So we just care about PCI devices for
|
|
|
|
* simplicity here.
|
|
|
|
*/
|
2018-11-29 03:16:41 +00:00
|
|
|
if (!eeh_edev_actionable(edev) ||
|
|
|
|
(dev->hdr_type == PCI_HEADER_TYPE_BRIDGE))
|
2019-08-16 04:48:15 +00:00
|
|
|
return;
|
powerpc/eeh: No hotplug on permanently removed dev
The issue was detected in a bit complicated test case where
we have multiple hierarchical PEs shown as following figure:
+-----------------+
| PE#3 p2p#0 |
| p2p#1 |
+-----------------+
|
+-----------------+
| PE#4 pdev#0 |
| pdev#1 |
+-----------------+
PE#4 (have 2 PCI devices) is the child of PE#3, which has 2 p2p
bridges. We accidentally had less-known scenario: PE#4 was removed
permanently from the system because of permanent failure (e.g.
exceeding the max allowd failure times in last hour), then we detects
EEH errors on PE#3 and tried to recover it. However, eeh_dev instances
for pdev#0/1 were not detached from PE#4, which was still connected to
PE#3. All of that was because of the fact that we rely on count-based
pcibios_release_device(), which isn't reliable enough. When doing
recovery for PE#3, we still apply hotplug on PE#4 and pdev#0/1, which
are not valid any more. Eventually, we run into kernel crash.
The patch fixes above issue from two aspects. For unplug, we simply
skip those permanently removed PE, whose state is (EEH_PE_STATE_ISOLATED
&& !EEH_PE_STATE_RECOVERING) and its frozen count should be greater
than EEH_MAX_ALLOWED_FREEZES. For plug, we marked all permanently
removed EEH devices with EEH_DEV_REMOVED and return 0xFF's on read
its PCI config so that PCI core will omit them.
Signed-off-by: Gavin Shan <gwshan@linux.vnet.ibm.com>
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
2014-04-24 08:00:19 +00:00
|
|
|
|
2018-09-12 01:23:27 +00:00
|
|
|
if (rmv_data) {
|
2018-05-25 03:11:30 +00:00
|
|
|
driver = eeh_pcid_get(dev);
|
|
|
|
if (driver) {
|
|
|
|
if (driver->err_handler &&
|
|
|
|
driver->err_handler->error_detected &&
|
|
|
|
driver->err_handler->slot_reset) {
|
|
|
|
eeh_pcid_put(dev);
|
2019-08-16 04:48:15 +00:00
|
|
|
return;
|
2018-05-25 03:11:30 +00:00
|
|
|
}
|
|
|
|
eeh_pcid_put(dev);
|
|
|
|
}
|
2014-02-05 18:20:45 +00:00
|
|
|
}
|
powerpc/eeh: Use partial hotplug for EEH unaware drivers
When EEH error happens to one specific PE, some devices with drivers
supporting EEH won't except hotplug on the device. However, there
might have other deivces without driver, or with driver without EEH
support. For the case, we need do partial hotplug in order to make
sure that the PE becomes absolutely quite during reset. Otherise,
the PE reset might fail and leads to failure of error recovery.
The current code doesn't handle that 'mixed' case properly, it either
uses the error callbacks to the drivers, or tries hotplug, but doesn't
handle a PE (EEH domain) composed of a combination of the two.
The patch intends to support so-called "partial" hotplug for EEH:
Before we do reset, we stop and remove those PCI devices without
EEH sensitive driver. The corresponding EEH devices are not detached
from its PE, but with special flag. After the reset is done, those
EEH devices with the special flag will be scanned one by one.
Signed-off-by: Gavin Shan <shangw@linux.vnet.ibm.com>
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
2013-07-24 02:24:58 +00:00
|
|
|
|
|
|
|
/* Remove it from PCI subsystem */
|
2018-11-29 03:16:41 +00:00
|
|
|
pr_info("EEH: Removing %s without EEH sensitive driver\n",
|
|
|
|
pci_name(dev));
|
powerpc/eeh: Use partial hotplug for EEH unaware drivers
When EEH error happens to one specific PE, some devices with drivers
supporting EEH won't except hotplug on the device. However, there
might have other deivces without driver, or with driver without EEH
support. For the case, we need do partial hotplug in order to make
sure that the PE becomes absolutely quite during reset. Otherise,
the PE reset might fail and leads to failure of error recovery.
The current code doesn't handle that 'mixed' case properly, it either
uses the error callbacks to the drivers, or tries hotplug, but doesn't
handle a PE (EEH domain) composed of a combination of the two.
The patch intends to support so-called "partial" hotplug for EEH:
Before we do reset, we stop and remove those PCI devices without
EEH sensitive driver. The corresponding EEH devices are not detached
from its PE, but with special flag. After the reset is done, those
EEH devices with the special flag will be scanned one by one.
Signed-off-by: Gavin Shan <shangw@linux.vnet.ibm.com>
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
2013-07-24 02:24:58 +00:00
|
|
|
edev->mode |= EEH_DEV_DISCONNECTED;
|
2018-09-12 01:23:27 +00:00
|
|
|
if (rmv_data)
|
|
|
|
rmv_data->removed_dev_count++;
|
powerpc/eeh: Use partial hotplug for EEH unaware drivers
When EEH error happens to one specific PE, some devices with drivers
supporting EEH won't except hotplug on the device. However, there
might have other deivces without driver, or with driver without EEH
support. For the case, we need do partial hotplug in order to make
sure that the PE becomes absolutely quite during reset. Otherise,
the PE reset might fail and leads to failure of error recovery.
The current code doesn't handle that 'mixed' case properly, it either
uses the error callbacks to the drivers, or tries hotplug, but doesn't
handle a PE (EEH domain) composed of a combination of the two.
The patch intends to support so-called "partial" hotplug for EEH:
Before we do reset, we stop and remove those PCI devices without
EEH sensitive driver. The corresponding EEH devices are not detached
from its PE, but with special flag. After the reset is done, those
EEH devices with the special flag will be scanned one by one.
Signed-off-by: Gavin Shan <shangw@linux.vnet.ibm.com>
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
2013-07-24 02:24:58 +00:00
|
|
|
|
2016-03-03 23:53:11 +00:00
|
|
|
if (edev->physfn) {
|
2017-11-09 14:00:33 +00:00
|
|
|
#ifdef CONFIG_PCI_IOV
|
2020-07-25 08:12:20 +00:00
|
|
|
pci_iov_remove_virtfn(edev->physfn, edev->vf_index);
|
2016-03-03 23:53:11 +00:00
|
|
|
edev->pdev = NULL;
|
|
|
|
#endif
|
|
|
|
if (rmv_data)
|
2018-09-12 01:23:27 +00:00
|
|
|
list_add(&edev->rmv_entry, &rmv_data->removed_vf_list);
|
2016-03-03 23:53:11 +00:00
|
|
|
} else {
|
|
|
|
pci_lock_rescan_remove();
|
|
|
|
pci_stop_and_remove_bus_device(dev);
|
|
|
|
pci_unlock_rescan_remove();
|
|
|
|
}
|
powerpc/eeh: Use partial hotplug for EEH unaware drivers
When EEH error happens to one specific PE, some devices with drivers
supporting EEH won't except hotplug on the device. However, there
might have other deivces without driver, or with driver without EEH
support. For the case, we need do partial hotplug in order to make
sure that the PE becomes absolutely quite during reset. Otherise,
the PE reset might fail and leads to failure of error recovery.
The current code doesn't handle that 'mixed' case properly, it either
uses the error callbacks to the drivers, or tries hotplug, but doesn't
handle a PE (EEH domain) composed of a combination of the two.
The patch intends to support so-called "partial" hotplug for EEH:
Before we do reset, we stop and remove those PCI devices without
EEH sensitive driver. The corresponding EEH devices are not detached
from its PE, but with special flag. After the reset is done, those
EEH devices with the special flag will be scanned one by one.
Signed-off-by: Gavin Shan <shangw@linux.vnet.ibm.com>
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
2013-07-24 02:24:58 +00:00
|
|
|
}
|
|
|
|
|
2018-05-25 03:11:32 +00:00
|
|
|
static void *eeh_pe_detach_dev(struct eeh_pe *pe, void *userdata)
|
powerpc/eeh: Use partial hotplug for EEH unaware drivers
When EEH error happens to one specific PE, some devices with drivers
supporting EEH won't except hotplug on the device. However, there
might have other deivces without driver, or with driver without EEH
support. For the case, we need do partial hotplug in order to make
sure that the PE becomes absolutely quite during reset. Otherise,
the PE reset might fail and leads to failure of error recovery.
The current code doesn't handle that 'mixed' case properly, it either
uses the error callbacks to the drivers, or tries hotplug, but doesn't
handle a PE (EEH domain) composed of a combination of the two.
The patch intends to support so-called "partial" hotplug for EEH:
Before we do reset, we stop and remove those PCI devices without
EEH sensitive driver. The corresponding EEH devices are not detached
from its PE, but with special flag. After the reset is done, those
EEH devices with the special flag will be scanned one by one.
Signed-off-by: Gavin Shan <shangw@linux.vnet.ibm.com>
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
2013-07-24 02:24:58 +00:00
|
|
|
{
|
|
|
|
struct eeh_dev *edev, *tmp;
|
|
|
|
|
|
|
|
eeh_pe_for_each_dev(pe, edev, tmp) {
|
|
|
|
if (!(edev->mode & EEH_DEV_DISCONNECTED))
|
|
|
|
continue;
|
|
|
|
|
|
|
|
edev->mode &= ~(EEH_DEV_DISCONNECTED | EEH_DEV_IRQ_DISABLED);
|
2020-07-25 08:12:29 +00:00
|
|
|
eeh_pe_tree_remove(edev);
|
powerpc/eeh: Use partial hotplug for EEH unaware drivers
When EEH error happens to one specific PE, some devices with drivers
supporting EEH won't except hotplug on the device. However, there
might have other deivces without driver, or with driver without EEH
support. For the case, we need do partial hotplug in order to make
sure that the PE becomes absolutely quite during reset. Otherise,
the PE reset might fail and leads to failure of error recovery.
The current code doesn't handle that 'mixed' case properly, it either
uses the error callbacks to the drivers, or tries hotplug, but doesn't
handle a PE (EEH domain) composed of a combination of the two.
The patch intends to support so-called "partial" hotplug for EEH:
Before we do reset, we stop and remove those PCI devices without
EEH sensitive driver. The corresponding EEH devices are not detached
from its PE, but with special flag. After the reset is done, those
EEH devices with the special flag will be scanned one by one.
Signed-off-by: Gavin Shan <shangw@linux.vnet.ibm.com>
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
2013-07-24 02:24:58 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
|
2014-04-24 08:00:14 +00:00
|
|
|
/*
|
|
|
|
* Explicitly clear PE's frozen state for PowerNV where
|
|
|
|
* we have frozen PE until BAR restore is completed. It's
|
|
|
|
* harmless to clear it for pSeries. To be consistent with
|
|
|
|
* PE reset (for 3 times), we try to clear the frozen state
|
|
|
|
* for 3 times as well.
|
|
|
|
*/
|
2018-11-29 03:16:40 +00:00
|
|
|
static int eeh_clear_pe_frozen_state(struct eeh_pe *root, bool include_passed)
|
2014-04-24 08:00:14 +00:00
|
|
|
{
|
2018-11-29 03:16:37 +00:00
|
|
|
struct eeh_pe *pe;
|
|
|
|
int i;
|
2014-04-24 08:00:14 +00:00
|
|
|
|
2018-11-29 03:16:37 +00:00
|
|
|
eeh_for_each_pe(root, pe) {
|
2018-11-29 03:16:40 +00:00
|
|
|
if (include_passed || !eeh_pe_passed(pe)) {
|
|
|
|
for (i = 0; i < 3; i++)
|
|
|
|
if (!eeh_unfreeze_pe(pe))
|
|
|
|
break;
|
|
|
|
if (i >= 3)
|
|
|
|
return -EIO;
|
|
|
|
}
|
2014-05-04 23:29:02 +00:00
|
|
|
}
|
2018-11-29 03:16:40 +00:00
|
|
|
eeh_pe_state_clear(root, EEH_PE_ISOLATED, include_passed);
|
2018-11-29 03:16:37 +00:00
|
|
|
return 0;
|
2014-04-24 08:00:14 +00:00
|
|
|
}
|
|
|
|
|
2014-09-30 02:39:07 +00:00
|
|
|
int eeh_pe_reset_and_recover(struct eeh_pe *pe)
|
|
|
|
{
|
2016-04-27 01:14:52 +00:00
|
|
|
int ret;
|
2014-09-30 02:39:07 +00:00
|
|
|
|
|
|
|
/* Bail if the PE is being recovered */
|
|
|
|
if (pe->state & EEH_PE_RECOVERING)
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
/* Put the PE into recovery mode */
|
|
|
|
eeh_pe_state_mark(pe, EEH_PE_RECOVERING);
|
|
|
|
|
|
|
|
/* Save states */
|
|
|
|
eeh_pe_dev_traverse(pe, eeh_dev_save_state, NULL);
|
|
|
|
|
|
|
|
/* Issue reset */
|
2018-11-29 03:16:41 +00:00
|
|
|
ret = eeh_pe_reset_full(pe, true);
|
2014-09-30 02:39:07 +00:00
|
|
|
if (ret) {
|
2018-11-29 03:16:39 +00:00
|
|
|
eeh_pe_state_clear(pe, EEH_PE_RECOVERING, true);
|
2014-09-30 02:39:07 +00:00
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Unfreeze the PE */
|
2018-11-29 03:16:40 +00:00
|
|
|
ret = eeh_clear_pe_frozen_state(pe, true);
|
2014-09-30 02:39:07 +00:00
|
|
|
if (ret) {
|
2018-11-29 03:16:39 +00:00
|
|
|
eeh_pe_state_clear(pe, EEH_PE_RECOVERING, true);
|
2014-09-30 02:39:07 +00:00
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Restore device state */
|
|
|
|
eeh_pe_dev_traverse(pe, eeh_dev_restore_state, NULL);
|
|
|
|
|
|
|
|
/* Clear recovery mode */
|
2018-11-29 03:16:39 +00:00
|
|
|
eeh_pe_state_clear(pe, EEH_PE_RECOVERING, true);
|
2014-09-30 02:39:07 +00:00
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2005-11-04 00:52:49 +00:00
|
|
|
/**
|
2012-02-27 20:04:02 +00:00
|
|
|
* eeh_reset_device - Perform actual reset of a pci slot
|
2018-03-19 02:48:55 +00:00
|
|
|
* @driver_eeh_aware: Does the device's driver provide EEH support?
|
2012-09-07 22:44:19 +00:00
|
|
|
* @pe: EEH PE
|
2012-02-27 20:04:02 +00:00
|
|
|
* @bus: PCI bus corresponding to the isolcated slot
|
2018-03-19 02:48:55 +00:00
|
|
|
* @rmv_data: Optional, list to record removed devices
|
2005-11-04 00:52:49 +00:00
|
|
|
*
|
2012-02-27 20:04:02 +00:00
|
|
|
* This routine must be called to do reset on the indicated PE.
|
|
|
|
* During the reset, udev might be invoked because those affected
|
|
|
|
* PCI devices will be removed and then added.
|
2005-11-04 00:52:49 +00:00
|
|
|
*/
|
2016-03-03 23:53:11 +00:00
|
|
|
static int eeh_reset_device(struct eeh_pe *pe, struct pci_bus *bus,
|
2018-03-19 02:48:55 +00:00
|
|
|
struct eeh_rmv_data *rmv_data,
|
|
|
|
bool driver_eeh_aware)
|
2005-11-04 00:52:49 +00:00
|
|
|
{
|
2017-11-04 21:26:52 +00:00
|
|
|
time64_t tstamp;
|
2016-03-03 23:53:11 +00:00
|
|
|
int cnt, rc;
|
|
|
|
struct eeh_dev *edev;
|
2018-11-29 03:16:41 +00:00
|
|
|
struct eeh_pe *tmp_pe;
|
|
|
|
bool any_passed = false;
|
|
|
|
|
|
|
|
eeh_for_each_pe(pe, tmp_pe)
|
|
|
|
any_passed |= eeh_pe_passed(tmp_pe);
|
2006-04-28 22:39:38 +00:00
|
|
|
|
|
|
|
/* pcibios will clear the counter; save the value */
|
2012-09-07 22:44:19 +00:00
|
|
|
cnt = pe->freeze_count;
|
2013-06-20 05:21:01 +00:00
|
|
|
tstamp = pe->tstamp;
|
2006-04-28 22:39:38 +00:00
|
|
|
|
2012-09-11 19:16:17 +00:00
|
|
|
/*
|
|
|
|
* We don't remove the corresponding PE instances because
|
|
|
|
* we need the information afterwords. The attached EEH
|
|
|
|
* devices are expected to be attached soon when calling
|
2016-05-03 05:41:37 +00:00
|
|
|
* into pci_hp_add_devices().
|
2012-09-11 19:16:17 +00:00
|
|
|
*/
|
powerpc/eeh: Use partial hotplug for EEH unaware drivers
When EEH error happens to one specific PE, some devices with drivers
supporting EEH won't except hotplug on the device. However, there
might have other deivces without driver, or with driver without EEH
support. For the case, we need do partial hotplug in order to make
sure that the PE becomes absolutely quite during reset. Otherise,
the PE reset might fail and leads to failure of error recovery.
The current code doesn't handle that 'mixed' case properly, it either
uses the error callbacks to the drivers, or tries hotplug, but doesn't
handle a PE (EEH domain) composed of a combination of the two.
The patch intends to support so-called "partial" hotplug for EEH:
Before we do reset, we stop and remove those PCI devices without
EEH sensitive driver. The corresponding EEH devices are not detached
from its PE, but with special flag. After the reset is done, those
EEH devices with the special flag will be scanned one by one.
Signed-off-by: Gavin Shan <shangw@linux.vnet.ibm.com>
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
2013-07-24 02:24:58 +00:00
|
|
|
eeh_pe_state_mark(pe, EEH_PE_KEEP);
|
2018-11-29 03:16:41 +00:00
|
|
|
if (any_passed || driver_eeh_aware || (pe->type & EEH_PE_VF)) {
|
2016-06-24 04:49:02 +00:00
|
|
|
eeh_pe_dev_traverse(pe, eeh_rmv_device, rmv_data);
|
2018-03-21 02:06:40 +00:00
|
|
|
} else {
|
|
|
|
pci_lock_rescan_remove();
|
|
|
|
pci_hp_remove_devices(bus);
|
|
|
|
pci_unlock_rescan_remove();
|
2014-01-15 13:33:20 +00:00
|
|
|
}
|
2005-11-04 00:52:49 +00:00
|
|
|
|
2014-04-24 08:00:12 +00:00
|
|
|
/*
|
|
|
|
* Reset the pci controller. (Asserts RST#; resets config space).
|
2005-11-04 00:54:54 +00:00
|
|
|
* Reconfigure bridges and devices. Don't try to bring the system
|
2012-02-27 20:04:02 +00:00
|
|
|
* up if the reset failed for some reason.
|
2014-04-24 08:00:12 +00:00
|
|
|
*
|
|
|
|
* During the reset, it's very dangerous to have uncontrolled PCI
|
|
|
|
* config accesses. So we prefer to block them. However, controlled
|
|
|
|
* PCI config accesses initiated from EEH itself are allowed.
|
2012-02-27 20:04:02 +00:00
|
|
|
*/
|
2018-11-29 03:16:41 +00:00
|
|
|
rc = eeh_pe_reset_full(pe, false);
|
2014-11-13 23:47:29 +00:00
|
|
|
if (rc)
|
2005-11-04 00:54:54 +00:00
|
|
|
return rc;
|
2005-11-04 00:52:49 +00:00
|
|
|
|
2014-01-15 13:33:20 +00:00
|
|
|
pci_lock_rescan_remove();
|
|
|
|
|
2012-09-07 22:44:19 +00:00
|
|
|
/* Restore PE */
|
|
|
|
eeh_ops->configure_bridge(pe);
|
|
|
|
eeh_pe_restore_bars(pe);
|
2005-11-04 00:52:49 +00:00
|
|
|
|
Revert "powerpc/eeh: Don't unfreeze PHB PE after reset"
This reverts commit 527d10ef3a315d3cb9dc098dacd61889a6c26439.
The reverted commit breaks cxlflash devices following an EEH reset (and
possibly other cxl devices, however this has not been tested).
The reverted commit changed the behaviour of eeh_reset_device() so that PHB
PEs are not unfrozen following the completion of the reset. This should not
be problematic, as no device resources should have been associated with the
PHB PE.
However, when attempting to load the cxlflash driver after a reset, the
driver attempts to read Vital Product Data through a call to
pci_read_vpd() (which is called on the physical cxl device, not on the
virtual AFU device). pci_read_vpd() in turn attempts to read from the cxl
device's config space. This fails, as the PE it's trying to read from is
still frozen. In turn, the driver gets an -ENODEV and fails to initialise.
It appears this issue only affects some parts of the VPD area, as "lspci
-vvv", which only reads a subset of the VPD bytes, is not broken by the
original patch.
At this stage, we don't fully understand why we're trying to read a frozen
PE, and we don't know how this affects other cxl devices. It is possible
that there is an underlying bug in the cxl driver or the powerpc CAPI
support code, or alternatively a bug in the PCI resource allocation/mapping
code that is incorrectly mapping resources to PE#0.
As such, this fix is incomplete, however it is necessary to prevent a
serious regression in CAPI support.
In the meantime, revert the commit, especially as it was intended to be a
non-functional change.
Cc: Gavin Shan <gwshan@linux.vnet.ibm.com>
Cc: Ian Munsie <imunsie@au1.ibm.com>
Cc: Daniel Axtens <dja@axtens.net>
Signed-off-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
2015-12-08 05:59:25 +00:00
|
|
|
/* Clear frozen state */
|
2018-11-29 03:16:41 +00:00
|
|
|
rc = eeh_clear_pe_frozen_state(pe, false);
|
2016-12-01 00:23:05 +00:00
|
|
|
if (rc) {
|
|
|
|
pci_unlock_rescan_remove();
|
Revert "powerpc/eeh: Don't unfreeze PHB PE after reset"
This reverts commit 527d10ef3a315d3cb9dc098dacd61889a6c26439.
The reverted commit breaks cxlflash devices following an EEH reset (and
possibly other cxl devices, however this has not been tested).
The reverted commit changed the behaviour of eeh_reset_device() so that PHB
PEs are not unfrozen following the completion of the reset. This should not
be problematic, as no device resources should have been associated with the
PHB PE.
However, when attempting to load the cxlflash driver after a reset, the
driver attempts to read Vital Product Data through a call to
pci_read_vpd() (which is called on the physical cxl device, not on the
virtual AFU device). pci_read_vpd() in turn attempts to read from the cxl
device's config space. This fails, as the PE it's trying to read from is
still frozen. In turn, the driver gets an -ENODEV and fails to initialise.
It appears this issue only affects some parts of the VPD area, as "lspci
-vvv", which only reads a subset of the VPD bytes, is not broken by the
original patch.
At this stage, we don't fully understand why we're trying to read a frozen
PE, and we don't know how this affects other cxl devices. It is possible
that there is an underlying bug in the cxl driver or the powerpc CAPI
support code, or alternatively a bug in the PCI resource allocation/mapping
code that is incorrectly mapping resources to PE#0.
As such, this fix is incomplete, however it is necessary to prevent a
serious regression in CAPI support.
In the meantime, revert the commit, especially as it was intended to be a
non-functional change.
Cc: Gavin Shan <gwshan@linux.vnet.ibm.com>
Cc: Ian Munsie <imunsie@au1.ibm.com>
Cc: Daniel Axtens <dja@axtens.net>
Signed-off-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
2015-12-08 05:59:25 +00:00
|
|
|
return rc;
|
2016-12-01 00:23:05 +00:00
|
|
|
}
|
2014-04-24 08:00:14 +00:00
|
|
|
|
2005-11-04 00:52:49 +00:00
|
|
|
/* Give the system 5 seconds to finish running the user-space
|
2013-06-20 05:20:51 +00:00
|
|
|
* hotplug shutdown scripts, e.g. ifdown for ethernet. Yes,
|
|
|
|
* this is a hack, but if we don't do this, and try to bring
|
|
|
|
* the device up before the scripts have taken it down,
|
2005-11-04 00:52:49 +00:00
|
|
|
* potentially weird things happen.
|
|
|
|
*/
|
2018-09-12 01:23:27 +00:00
|
|
|
if (!driver_eeh_aware || rmv_data->removed_dev_count) {
|
2018-03-21 02:06:40 +00:00
|
|
|
pr_info("EEH: Sleep 5s ahead of %s hotplug\n",
|
|
|
|
(driver_eeh_aware ? "partial" : "complete"));
|
2012-02-27 20:04:02 +00:00
|
|
|
ssleep(5);
|
powerpc/eeh: Use partial hotplug for EEH unaware drivers
When EEH error happens to one specific PE, some devices with drivers
supporting EEH won't except hotplug on the device. However, there
might have other deivces without driver, or with driver without EEH
support. For the case, we need do partial hotplug in order to make
sure that the PE becomes absolutely quite during reset. Otherise,
the PE reset might fail and leads to failure of error recovery.
The current code doesn't handle that 'mixed' case properly, it either
uses the error callbacks to the drivers, or tries hotplug, but doesn't
handle a PE (EEH domain) composed of a combination of the two.
The patch intends to support so-called "partial" hotplug for EEH:
Before we do reset, we stop and remove those PCI devices without
EEH sensitive driver. The corresponding EEH devices are not detached
from its PE, but with special flag. After the reset is done, those
EEH devices with the special flag will be scanned one by one.
Signed-off-by: Gavin Shan <shangw@linux.vnet.ibm.com>
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
2013-07-24 02:24:58 +00:00
|
|
|
|
|
|
|
/*
|
|
|
|
* The EEH device is still connected with its parent
|
|
|
|
* PE. We should disconnect it so the binding can be
|
|
|
|
* rebuilt when adding PCI devices.
|
|
|
|
*/
|
2018-09-12 01:23:26 +00:00
|
|
|
edev = list_first_entry(&pe->edevs, struct eeh_dev, entry);
|
powerpc/eeh: Use partial hotplug for EEH unaware drivers
When EEH error happens to one specific PE, some devices with drivers
supporting EEH won't except hotplug on the device. However, there
might have other deivces without driver, or with driver without EEH
support. For the case, we need do partial hotplug in order to make
sure that the PE becomes absolutely quite during reset. Otherise,
the PE reset might fail and leads to failure of error recovery.
The current code doesn't handle that 'mixed' case properly, it either
uses the error callbacks to the drivers, or tries hotplug, but doesn't
handle a PE (EEH domain) composed of a combination of the two.
The patch intends to support so-called "partial" hotplug for EEH:
Before we do reset, we stop and remove those PCI devices without
EEH sensitive driver. The corresponding EEH devices are not detached
from its PE, but with special flag. After the reset is done, those
EEH devices with the special flag will be scanned one by one.
Signed-off-by: Gavin Shan <shangw@linux.vnet.ibm.com>
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
2013-07-24 02:24:58 +00:00
|
|
|
eeh_pe_traverse(pe, eeh_pe_detach_dev, NULL);
|
2016-06-17 03:05:11 +00:00
|
|
|
if (pe->type & EEH_PE_VF) {
|
2018-09-12 01:23:25 +00:00
|
|
|
eeh_add_virt_device(edev);
|
2016-06-17 03:05:11 +00:00
|
|
|
} else {
|
2018-03-21 02:06:40 +00:00
|
|
|
if (!driver_eeh_aware)
|
2018-11-29 03:16:39 +00:00
|
|
|
eeh_pe_state_clear(pe, EEH_PE_PRI_BUS, true);
|
2016-05-03 05:41:37 +00:00
|
|
|
pci_hp_add_devices(bus);
|
2016-06-17 03:05:11 +00:00
|
|
|
}
|
2005-11-04 00:52:49 +00:00
|
|
|
}
|
2018-11-29 03:16:39 +00:00
|
|
|
eeh_pe_state_clear(pe, EEH_PE_KEEP, true);
|
2013-06-20 05:21:01 +00:00
|
|
|
|
|
|
|
pe->tstamp = tstamp;
|
2012-09-07 22:44:19 +00:00
|
|
|
pe->freeze_count = cnt;
|
2005-11-04 00:54:54 +00:00
|
|
|
|
2014-01-15 13:33:20 +00:00
|
|
|
pci_unlock_rescan_remove();
|
2005-11-04 00:54:54 +00:00
|
|
|
return 0;
|
2005-11-04 00:52:49 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
/* The longest amount of time to wait for a pci device
|
|
|
|
* to come back on line, in seconds.
|
|
|
|
*/
|
2013-11-25 22:27:54 +00:00
|
|
|
#define MAX_WAIT_FOR_RECOVERY 300
|
2005-11-04 00:52:49 +00:00
|
|
|
|
2019-09-03 10:15:52 +00:00
|
|
|
|
|
|
|
/* Walks the PE tree after processing an event to remove any stale PEs.
|
|
|
|
*
|
|
|
|
* NB: This needs to be recursive to ensure the leaf PEs get removed
|
|
|
|
* before their parents do. Although this is possible to do recursively
|
|
|
|
* we don't since this is easier to read and we need to garantee
|
|
|
|
* the leaf nodes will be handled first.
|
|
|
|
*/
|
|
|
|
static void eeh_pe_cleanup(struct eeh_pe *pe)
|
|
|
|
{
|
|
|
|
struct eeh_pe *child_pe, *tmp;
|
|
|
|
|
|
|
|
list_for_each_entry_safe(child_pe, tmp, &pe->child_list, child)
|
|
|
|
eeh_pe_cleanup(child_pe);
|
|
|
|
|
|
|
|
if (pe->state & EEH_PE_KEEP)
|
|
|
|
return;
|
|
|
|
|
|
|
|
if (!(pe->state & EEH_PE_INVALID))
|
|
|
|
return;
|
|
|
|
|
|
|
|
if (list_empty(&pe->edevs) && list_empty(&pe->child_list)) {
|
|
|
|
list_del(&pe->child);
|
|
|
|
kfree(pe);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2019-09-03 10:15:55 +00:00
|
|
|
/**
|
|
|
|
* eeh_check_slot_presence - Check if a device is still present in a slot
|
|
|
|
* @pdev: pci_dev to check
|
|
|
|
*
|
|
|
|
* This function may return a false positive if we can't determine the slot's
|
2022-07-18 09:51:58 +00:00
|
|
|
* presence state. This might happen for PCIe slots if the PE containing
|
2019-09-03 10:15:55 +00:00
|
|
|
* the upstream bridge is also frozen, or the bridge is part of the same PE
|
|
|
|
* as the device.
|
|
|
|
*
|
|
|
|
* This shouldn't happen often, but you might see it if you hotplug a PCIe
|
|
|
|
* switch.
|
|
|
|
*/
|
|
|
|
static bool eeh_slot_presence_check(struct pci_dev *pdev)
|
|
|
|
{
|
|
|
|
const struct hotplug_slot_ops *ops;
|
|
|
|
struct pci_slot *slot;
|
|
|
|
u8 state;
|
|
|
|
int rc;
|
|
|
|
|
|
|
|
if (!pdev)
|
|
|
|
return false;
|
|
|
|
|
|
|
|
if (pdev->error_state == pci_channel_io_perm_failure)
|
|
|
|
return false;
|
|
|
|
|
|
|
|
slot = pdev->slot;
|
|
|
|
if (!slot || !slot->hotplug)
|
|
|
|
return true;
|
|
|
|
|
|
|
|
ops = slot->hotplug->ops;
|
|
|
|
if (!ops || !ops->get_adapter_status)
|
|
|
|
return true;
|
|
|
|
|
2019-09-03 10:16:02 +00:00
|
|
|
/* set the attention indicator while we've got the slot ops */
|
|
|
|
if (ops->set_attention_status)
|
|
|
|
ops->set_attention_status(slot->hotplug, 1);
|
|
|
|
|
2019-09-03 10:15:55 +00:00
|
|
|
rc = ops->get_adapter_status(slot->hotplug, &state);
|
|
|
|
if (rc)
|
|
|
|
return true;
|
|
|
|
|
|
|
|
return !!state;
|
|
|
|
}
|
|
|
|
|
2019-09-03 10:16:02 +00:00
|
|
|
static void eeh_clear_slot_attention(struct pci_dev *pdev)
|
|
|
|
{
|
|
|
|
const struct hotplug_slot_ops *ops;
|
|
|
|
struct pci_slot *slot;
|
|
|
|
|
|
|
|
if (!pdev)
|
|
|
|
return;
|
|
|
|
|
|
|
|
if (pdev->error_state == pci_channel_io_perm_failure)
|
|
|
|
return;
|
|
|
|
|
|
|
|
slot = pdev->slot;
|
|
|
|
if (!slot || !slot->hotplug)
|
|
|
|
return;
|
|
|
|
|
|
|
|
ops = slot->hotplug->ops;
|
|
|
|
if (!ops || !ops->set_attention_status)
|
|
|
|
return;
|
|
|
|
|
|
|
|
ops->set_attention_status(slot->hotplug, 0);
|
|
|
|
}
|
|
|
|
|
2017-04-19 07:39:27 +00:00
|
|
|
/**
|
|
|
|
* eeh_handle_normal_event - Handle EEH events on a specific PE
|
2018-03-19 02:46:30 +00:00
|
|
|
* @pe: EEH PE - which should not be used after we return, as it may
|
|
|
|
* have been invalidated.
|
2017-04-19 07:39:27 +00:00
|
|
|
*
|
|
|
|
* Attempts to recover the given PE. If recovery fails or the PE has failed
|
|
|
|
* too many times, remove the PE.
|
|
|
|
*
|
2018-03-19 02:46:20 +00:00
|
|
|
* While PHB detects address or data parity errors on particular PCI
|
|
|
|
* slot, the associated PE will be frozen. Besides, DMA's occurring
|
|
|
|
* to wild addresses (which usually happen due to bugs in device
|
|
|
|
* drivers or in PCI adapter firmware) can cause EEH error. #SERR,
|
|
|
|
* #PERR or other misc PCI-related errors also can trigger EEH errors.
|
|
|
|
*
|
|
|
|
* Recovery process consists of unplugging the device driver (which
|
|
|
|
* generated hotplug events to userspace), then issuing a PCI #RST to
|
|
|
|
* the device, then reconfiguring the PCI config space for all bridges
|
|
|
|
* & devices under this slot, and then finally restarting the device
|
|
|
|
* drivers (which cause a second set of hotplug events to go out to
|
|
|
|
* userspace).
|
2017-04-19 07:39:27 +00:00
|
|
|
*/
|
2018-03-19 02:46:30 +00:00
|
|
|
void eeh_handle_normal_event(struct eeh_pe *pe)
|
2005-11-04 00:52:49 +00:00
|
|
|
{
|
2018-03-19 02:47:02 +00:00
|
|
|
struct pci_bus *bus;
|
2016-03-03 23:53:11 +00:00
|
|
|
struct eeh_dev *edev, *tmp;
|
2018-05-25 03:11:39 +00:00
|
|
|
struct eeh_pe *tmp_pe;
|
2005-11-04 00:54:54 +00:00
|
|
|
int rc = 0;
|
2005-11-29 06:17:02 +00:00
|
|
|
enum pci_ers_result result = PCI_ERS_RESULT_NONE;
|
2018-09-12 01:23:27 +00:00
|
|
|
struct eeh_rmv_data rmv_data =
|
|
|
|
{LIST_HEAD_INIT(rmv_data.removed_vf_list), 0};
|
2019-09-03 10:15:55 +00:00
|
|
|
int devices = 0;
|
2005-11-04 00:52:49 +00:00
|
|
|
|
2018-03-19 02:47:02 +00:00
|
|
|
bus = eeh_pe_bus_get(pe);
|
|
|
|
if (!bus) {
|
2016-11-16 03:02:15 +00:00
|
|
|
pr_err("%s: Cannot find PCI bus for PHB#%x-PE#%x\n",
|
2012-09-07 22:44:19 +00:00
|
|
|
__func__, pe->phb->global_number, pe->addr);
|
2018-03-19 02:46:30 +00:00
|
|
|
return;
|
2005-11-04 00:52:49 +00:00
|
|
|
}
|
|
|
|
|
2019-09-03 10:15:55 +00:00
|
|
|
/*
|
|
|
|
* When devices are hot-removed we might get an EEH due to
|
|
|
|
* a driver attempting to touch the MMIO space of a removed
|
|
|
|
* device. In this case we don't have a device to recover
|
|
|
|
* so suppress the event if we can't find any present devices.
|
|
|
|
*
|
|
|
|
* The hotplug driver should take care of tearing down the
|
|
|
|
* device itself.
|
|
|
|
*/
|
|
|
|
eeh_for_each_pe(pe, tmp_pe)
|
|
|
|
eeh_pe_for_each_dev(tmp_pe, edev, tmp)
|
|
|
|
if (eeh_slot_presence_check(edev->pdev))
|
|
|
|
devices++;
|
|
|
|
|
2019-09-03 10:15:56 +00:00
|
|
|
if (!devices) {
|
2024-04-22 07:57:37 +00:00
|
|
|
pr_warn("EEH: Frozen PHB#%x-PE#%x is empty!\n",
|
2019-09-03 10:15:56 +00:00
|
|
|
pe->phb->global_number, pe->addr);
|
2024-04-22 07:57:37 +00:00
|
|
|
/*
|
|
|
|
* The device is removed, tear down its state, on powernv
|
|
|
|
* hotplug driver would take care of it but not on pseries,
|
|
|
|
* permanently disable the card as it is hot removed.
|
|
|
|
*
|
|
|
|
* In the case of powernv, note that the removal of device
|
|
|
|
* is covered by pci rescan lock, so no problem even if hotplug
|
|
|
|
* driver attempts to remove the device.
|
|
|
|
*/
|
|
|
|
goto recover_failed;
|
2019-09-03 10:15:56 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
/* Log the event */
|
|
|
|
if (pe->type & EEH_PE_PHB) {
|
2019-10-17 04:59:37 +00:00
|
|
|
pr_err("EEH: Recovering PHB#%x, location: %s\n",
|
2019-09-03 10:15:56 +00:00
|
|
|
pe->phb->global_number, eeh_pe_loc_get(pe));
|
|
|
|
} else {
|
|
|
|
struct eeh_pe *phb_pe = eeh_phb_pe_get(pe->phb);
|
|
|
|
|
2019-10-17 04:59:37 +00:00
|
|
|
pr_err("EEH: Recovering PHB#%x-PE#%x\n",
|
2019-09-03 10:15:56 +00:00
|
|
|
pe->phb->global_number, pe->addr);
|
|
|
|
pr_err("EEH: PE location: %s, PHB location: %s\n",
|
|
|
|
eeh_pe_loc_get(pe), eeh_pe_loc_get(phb_pe));
|
|
|
|
}
|
|
|
|
|
2019-09-13 13:32:13 +00:00
|
|
|
#ifdef CONFIG_STACKTRACE
|
2019-09-03 10:15:56 +00:00
|
|
|
/*
|
|
|
|
* Print the saved stack trace now that we've verified there's
|
|
|
|
* something to recover.
|
|
|
|
*/
|
|
|
|
if (pe->trace_entries) {
|
|
|
|
void **ptrs = (void **) pe->stack_trace;
|
|
|
|
int i;
|
|
|
|
|
|
|
|
pr_err("EEH: Frozen PHB#%x-PE#%x detected\n",
|
|
|
|
pe->phb->global_number, pe->addr);
|
|
|
|
|
|
|
|
/* FIXME: Use the same format as dump_stack() */
|
|
|
|
pr_err("EEH: Call Trace:\n");
|
|
|
|
for (i = 0; i < pe->trace_entries; i++)
|
|
|
|
pr_err("EEH: [%pK] %pS\n", ptrs[i], ptrs[i]);
|
|
|
|
|
|
|
|
pe->trace_entries = 0;
|
|
|
|
}
|
2019-09-13 13:32:13 +00:00
|
|
|
#endif /* CONFIG_STACKTRACE */
|
2019-09-03 10:15:55 +00:00
|
|
|
|
2021-10-15 07:06:28 +00:00
|
|
|
eeh_for_each_pe(pe, tmp_pe)
|
|
|
|
eeh_pe_for_each_dev(tmp_pe, edev, tmp)
|
|
|
|
edev->mode &= ~EEH_DEV_NO_HANDLER;
|
|
|
|
|
2013-06-20 05:21:01 +00:00
|
|
|
eeh_pe_update_time_stamp(pe);
|
2012-09-07 22:44:19 +00:00
|
|
|
pe->freeze_count++;
|
2017-04-19 07:39:27 +00:00
|
|
|
if (pe->freeze_count > eeh_max_freezes) {
|
2018-05-25 03:11:28 +00:00
|
|
|
pr_err("EEH: PHB#%x-PE#%x has failed %d times in the last hour and has been permanently disabled.\n",
|
2017-04-19 07:39:27 +00:00
|
|
|
pe->phb->global_number, pe->addr,
|
|
|
|
pe->freeze_count);
|
2005-11-04 00:52:49 +00:00
|
|
|
|
2021-10-15 07:06:28 +00:00
|
|
|
goto recover_failed;
|
|
|
|
}
|
2019-08-16 04:48:06 +00:00
|
|
|
|
2005-11-04 00:52:49 +00:00
|
|
|
/* Walk the various device drivers attached to this slot through
|
|
|
|
* a reset sequence, giving each an opportunity to do what it needs
|
|
|
|
* to accomplish the reset. Each child gets a report of the
|
|
|
|
* status ... if any child can't handle the reset, then the entire
|
|
|
|
* slot is dlpar removed and added.
|
2015-10-08 03:58:54 +00:00
|
|
|
*
|
|
|
|
* When the PHB is fenced, we have to issue a reset to recover from
|
|
|
|
* the error. Override the result if necessary to have partially
|
|
|
|
* hotplug for this case.
|
2005-11-04 00:52:49 +00:00
|
|
|
*/
|
2021-10-15 07:06:28 +00:00
|
|
|
pr_warn("EEH: This PCI device has failed %d times in the last hour and will be permanently disabled after %d failures.\n",
|
|
|
|
pe->freeze_count, eeh_max_freezes);
|
|
|
|
pr_info("EEH: Notify device drivers to shutdown\n");
|
|
|
|
eeh_set_channel_state(pe, pci_channel_io_frozen);
|
|
|
|
eeh_set_irq_state(pe, false);
|
|
|
|
eeh_pe_report("error_detected(IO frozen)", pe,
|
|
|
|
eeh_report_error, &result);
|
|
|
|
if (result == PCI_ERS_RESULT_DISCONNECT)
|
|
|
|
goto recover_failed;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Error logged on a PHB are always fences which need a full
|
|
|
|
* PHB reset to clear so force that to happen.
|
|
|
|
*/
|
|
|
|
if ((pe->type & EEH_PE_PHB) && result != PCI_ERS_RESULT_NONE)
|
|
|
|
result = PCI_ERS_RESULT_NEED_RESET;
|
2005-11-04 00:52:49 +00:00
|
|
|
|
2007-11-15 18:58:36 +00:00
|
|
|
/* Get the current PCI slot state. This can take a long time,
|
2015-04-27 01:25:10 +00:00
|
|
|
* sometimes over 300 seconds for certain systems.
|
2012-02-27 20:04:02 +00:00
|
|
|
*/
|
2021-10-15 07:06:28 +00:00
|
|
|
rc = eeh_wait_state(pe, MAX_WAIT_FOR_RECOVERY * 1000);
|
|
|
|
if (rc < 0 || rc == EEH_STATE_NOT_SUPPORT) {
|
|
|
|
pr_warn("EEH: Permanent failure\n");
|
|
|
|
goto recover_failed;
|
2007-11-15 18:58:36 +00:00
|
|
|
}
|
|
|
|
|
2007-05-08 23:33:29 +00:00
|
|
|
/* Since rtas may enable MMIO when posting the error log,
|
|
|
|
* don't post the error log until after all dev drivers
|
2007-05-09 16:38:11 +00:00
|
|
|
* have been informed.
|
|
|
|
*/
|
2021-10-15 07:06:28 +00:00
|
|
|
pr_info("EEH: Collect temporary log\n");
|
|
|
|
eeh_slot_error_detail(pe, EEH_LOG_TEMP);
|
2007-05-08 23:33:29 +00:00
|
|
|
|
2005-11-04 00:52:49 +00:00
|
|
|
/* If all device drivers were EEH-unaware, then shut
|
|
|
|
* down all of the device drivers, and hope they
|
|
|
|
* go down willingly, without panicing the system.
|
|
|
|
*/
|
2005-11-29 06:17:02 +00:00
|
|
|
if (result == PCI_ERS_RESULT_NONE) {
|
2013-06-27 05:46:46 +00:00
|
|
|
pr_info("EEH: Reset with hotplug activity\n");
|
2018-03-19 02:48:55 +00:00
|
|
|
rc = eeh_reset_device(pe, bus, NULL, false);
|
2007-03-19 19:52:04 +00:00
|
|
|
if (rc) {
|
2021-10-15 07:06:28 +00:00
|
|
|
pr_warn("%s: Unable to reset, err=%d\n", __func__, rc);
|
|
|
|
goto recover_failed;
|
2007-03-19 19:52:04 +00:00
|
|
|
}
|
2005-11-04 00:52:49 +00:00
|
|
|
}
|
|
|
|
|
2006-09-15 23:58:59 +00:00
|
|
|
/* If all devices reported they can proceed, then re-enable MMIO */
|
|
|
|
if (result == PCI_ERS_RESULT_CAN_RECOVER) {
|
2013-06-27 05:46:46 +00:00
|
|
|
pr_info("EEH: Enable I/O for affected devices\n");
|
2012-09-07 22:44:19 +00:00
|
|
|
rc = eeh_pci_enable(pe, EEH_OPT_THAW_MMIO);
|
2021-10-15 07:06:28 +00:00
|
|
|
if (rc < 0)
|
|
|
|
goto recover_failed;
|
2006-09-15 23:58:59 +00:00
|
|
|
|
2021-10-15 07:06:28 +00:00
|
|
|
if (rc) {
|
2006-09-15 23:58:59 +00:00
|
|
|
result = PCI_ERS_RESULT_NEED_RESET;
|
|
|
|
} else {
|
2013-06-27 05:46:46 +00:00
|
|
|
pr_info("EEH: Notify device drivers to resume I/O\n");
|
2018-05-25 03:11:40 +00:00
|
|
|
eeh_pe_report("mmio_enabled", pe,
|
|
|
|
eeh_report_mmio_enabled, &result);
|
2006-09-15 23:58:59 +00:00
|
|
|
}
|
2005-11-04 00:52:49 +00:00
|
|
|
}
|
2005-11-29 06:17:02 +00:00
|
|
|
if (result == PCI_ERS_RESULT_CAN_RECOVER) {
|
2013-06-27 05:46:46 +00:00
|
|
|
pr_info("EEH: Enabled DMA for affected devices\n");
|
2012-09-07 22:44:19 +00:00
|
|
|
rc = eeh_pci_enable(pe, EEH_OPT_THAW_DMA);
|
2021-10-15 07:06:28 +00:00
|
|
|
if (rc < 0)
|
|
|
|
goto recover_failed;
|
2006-09-15 23:58:59 +00:00
|
|
|
|
2021-10-15 07:06:28 +00:00
|
|
|
if (rc) {
|
2006-09-15 23:58:59 +00:00
|
|
|
result = PCI_ERS_RESULT_NEED_RESET;
|
2014-04-24 08:00:26 +00:00
|
|
|
} else {
|
|
|
|
/*
|
|
|
|
* We didn't do PE reset for the case. The PE
|
|
|
|
* is still in frozen state. Clear it before
|
|
|
|
* resuming the PE.
|
|
|
|
*/
|
2018-11-29 03:16:39 +00:00
|
|
|
eeh_pe_state_clear(pe, EEH_PE_ISOLATED, true);
|
2006-12-06 18:32:20 +00:00
|
|
|
result = PCI_ERS_RESULT_RECOVERED;
|
2014-04-24 08:00:26 +00:00
|
|
|
}
|
2006-09-15 23:58:59 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
/* If any device called out for a reset, then reset the slot */
|
|
|
|
if (result == PCI_ERS_RESULT_NEED_RESET) {
|
2013-06-27 05:46:46 +00:00
|
|
|
pr_info("EEH: Reset without hotplug activity\n");
|
2018-03-19 02:48:55 +00:00
|
|
|
rc = eeh_reset_device(pe, bus, &rmv_data, true);
|
2007-03-19 19:52:04 +00:00
|
|
|
if (rc) {
|
2021-10-15 07:06:28 +00:00
|
|
|
pr_warn("%s: Cannot reset, err=%d\n", __func__, rc);
|
|
|
|
goto recover_failed;
|
2007-03-19 19:52:04 +00:00
|
|
|
}
|
2021-10-15 07:06:28 +00:00
|
|
|
|
|
|
|
result = PCI_ERS_RESULT_NONE;
|
|
|
|
eeh_set_channel_state(pe, pci_channel_io_normal);
|
|
|
|
eeh_set_irq_state(pe, true);
|
|
|
|
eeh_pe_report("slot_reset", pe, eeh_report_reset,
|
|
|
|
&result);
|
2007-03-19 19:52:04 +00:00
|
|
|
}
|
2006-09-15 23:58:59 +00:00
|
|
|
|
2018-09-12 01:23:33 +00:00
|
|
|
if ((result == PCI_ERS_RESULT_RECOVERED) ||
|
|
|
|
(result == PCI_ERS_RESULT_NONE)) {
|
|
|
|
/*
|
|
|
|
* For those hot removed VFs, we should add back them after PF
|
|
|
|
* get recovered properly.
|
|
|
|
*/
|
|
|
|
list_for_each_entry_safe(edev, tmp, &rmv_data.removed_vf_list,
|
|
|
|
rmv_entry) {
|
|
|
|
eeh_add_virt_device(edev);
|
|
|
|
list_del(&edev->rmv_entry);
|
2018-05-25 03:11:40 +00:00
|
|
|
}
|
2018-05-25 03:11:39 +00:00
|
|
|
|
2018-09-12 01:23:33 +00:00
|
|
|
/* Tell all device drivers that they can resume operations */
|
|
|
|
pr_info("EEH: Notify device driver to resume\n");
|
|
|
|
eeh_set_channel_state(pe, pci_channel_io_normal);
|
|
|
|
eeh_set_irq_state(pe, true);
|
|
|
|
eeh_pe_report("resume", pe, eeh_report_resume, NULL);
|
|
|
|
eeh_for_each_pe(pe, tmp_pe) {
|
|
|
|
eeh_pe_for_each_dev(tmp_pe, edev, tmp) {
|
|
|
|
edev->mode &= ~EEH_DEV_NO_HANDLER;
|
|
|
|
edev->in_error = false;
|
|
|
|
}
|
|
|
|
}
|
2013-06-20 05:20:51 +00:00
|
|
|
|
2018-09-12 01:23:33 +00:00
|
|
|
pr_info("EEH: Recovery successful.\n");
|
2021-10-15 07:06:27 +00:00
|
|
|
goto out;
|
|
|
|
}
|
2005-11-04 00:54:54 +00:00
|
|
|
|
2021-10-15 07:06:28 +00:00
|
|
|
recover_failed:
|
2021-10-15 07:06:27 +00:00
|
|
|
/*
|
|
|
|
* About 90% of all real-life EEH failures in the field
|
|
|
|
* are due to poorly seated PCI cards. Only 10% or so are
|
|
|
|
* due to actual, failed cards.
|
|
|
|
*/
|
|
|
|
pr_err("EEH: Unable to recover from failure from PHB#%x-PE#%x.\n"
|
|
|
|
"Please try reseating or replacing it\n",
|
|
|
|
pe->phb->global_number, pe->addr);
|
2005-11-04 00:54:54 +00:00
|
|
|
|
2021-10-15 07:06:27 +00:00
|
|
|
eeh_slot_error_detail(pe, EEH_LOG_PERM);
|
2005-11-04 00:54:54 +00:00
|
|
|
|
2021-10-15 07:06:27 +00:00
|
|
|
/* Notify all devices that they're about to go down. */
|
|
|
|
eeh_set_irq_state(pe, false);
|
|
|
|
eeh_pe_report("error_detected(permanent failure)", pe,
|
|
|
|
eeh_report_failure, NULL);
|
powerpc/eeh: Set channel state after notifying the drivers
When a PCI error is encountered 6th time in an hour we
set the channel state to perm_failure and notify the
driver about the permanent failure.
However, after upstream commit 38ddc011478e ("powerpc/eeh:
Make permanently failed devices non-actionable"), EEH handler
stops calling any routine once the device is marked as
permanent failure. This issue can lead to fatal consequences
like kernel hang with certain PCI devices.
Following log is observed with lpfc driver, with and without
this change, Without this change kernel hangs, If PCI error
is encountered 6 times for a device in an hour.
Without the change
EEH: Beginning: 'error_detected(permanent failure)'
PCI 0132:60:00.0#600000: EEH: not actionable (1,1,1)
PCI 0132:60:00.1#600000: EEH: not actionable (1,1,1)
EEH: Finished:'error_detected(permanent failure)'
With the change
EEH: Beginning: 'error_detected(permanent failure)'
EEH: Invoking lpfc->error_detected(permanent failure)
EEH: lpfc driver reports: 'disconnect'
EEH: Invoking lpfc->error_detected(permanent failure)
EEH: lpfc driver reports: 'disconnect'
EEH: Finished:'error_detected(permanent failure)'
To fix the issue, set channel state to permanent failure after
notifying the drivers.
Fixes: 38ddc011478e ("powerpc/eeh: Make permanently failed devices non-actionable")
Suggested-by: Mahesh Salgaonkar <mahesh@linux.ibm.com>
Signed-off-by: Ganesh Goudar <ganeshgr@linux.ibm.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20230209105649.127707-1-ganeshgr@linux.ibm.com
2023-02-09 10:56:49 +00:00
|
|
|
eeh_set_channel_state(pe, pci_channel_io_perm_failure);
|
powerpc/eeh: No hotplug on permanently removed dev
The issue was detected in a bit complicated test case where
we have multiple hierarchical PEs shown as following figure:
+-----------------+
| PE#3 p2p#0 |
| p2p#1 |
+-----------------+
|
+-----------------+
| PE#4 pdev#0 |
| pdev#1 |
+-----------------+
PE#4 (have 2 PCI devices) is the child of PE#3, which has 2 p2p
bridges. We accidentally had less-known scenario: PE#4 was removed
permanently from the system because of permanent failure (e.g.
exceeding the max allowd failure times in last hour), then we detects
EEH errors on PE#3 and tried to recover it. However, eeh_dev instances
for pdev#0/1 were not detached from PE#4, which was still connected to
PE#3. All of that was because of the fact that we rely on count-based
pcibios_release_device(), which isn't reliable enough. When doing
recovery for PE#3, we still apply hotplug on PE#4 and pdev#0/1, which
are not valid any more. Eventually, we run into kernel crash.
The patch fixes above issue from two aspects. For unplug, we simply
skip those permanently removed PE, whose state is (EEH_PE_STATE_ISOLATED
&& !EEH_PE_STATE_RECOVERING) and its frozen count should be greater
than EEH_MAX_ALLOWED_FREEZES. For plug, we marked all permanently
removed EEH devices with EEH_DEV_REMOVED and return 0xFF's on read
its PCI config so that PCI core will omit them.
Signed-off-by: Gavin Shan <gwshan@linux.vnet.ibm.com>
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
2014-04-24 08:00:19 +00:00
|
|
|
|
2021-10-15 07:06:27 +00:00
|
|
|
/* Mark the PE to be removed permanently */
|
|
|
|
eeh_pe_state_mark(pe, EEH_PE_REMOVED);
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Shut down the device drivers for good. We mark
|
|
|
|
* all removed devices correctly to avoid access
|
|
|
|
* the their PCI config any more.
|
|
|
|
*/
|
|
|
|
if (pe->type & EEH_PE_VF) {
|
|
|
|
eeh_pe_dev_traverse(pe, eeh_rmv_device, NULL);
|
|
|
|
eeh_pe_dev_mode_mark(pe, EEH_DEV_REMOVED);
|
|
|
|
} else {
|
|
|
|
eeh_pe_state_clear(pe, EEH_PE_PRI_BUS, true);
|
|
|
|
eeh_pe_dev_mode_mark(pe, EEH_DEV_REMOVED);
|
|
|
|
|
|
|
|
pci_lock_rescan_remove();
|
|
|
|
pci_hp_remove_devices(bus);
|
|
|
|
pci_unlock_rescan_remove();
|
|
|
|
/* The passed PE should no longer be used */
|
|
|
|
return;
|
2014-01-15 13:33:20 +00:00
|
|
|
}
|
2019-09-03 10:15:52 +00:00
|
|
|
|
2019-09-03 10:15:55 +00:00
|
|
|
out:
|
2019-09-03 10:15:52 +00:00
|
|
|
/*
|
|
|
|
* Clean up any PEs without devices. While marked as EEH_PE_RECOVERYING
|
|
|
|
* we don't want to modify the PE tree structure so we do it here.
|
|
|
|
*/
|
|
|
|
eeh_pe_cleanup(pe);
|
2019-09-03 10:16:02 +00:00
|
|
|
|
|
|
|
/* clear the slot attention LED for all recovered devices */
|
|
|
|
eeh_for_each_pe(pe, tmp_pe)
|
|
|
|
eeh_pe_for_each_dev(tmp_pe, edev, tmp)
|
|
|
|
eeh_clear_slot_attention(edev->pdev);
|
|
|
|
|
2018-11-29 03:16:39 +00:00
|
|
|
eeh_pe_state_clear(pe, EEH_PE_RECOVERING, true);
|
2005-11-04 00:52:49 +00:00
|
|
|
}
|
2013-06-20 05:21:04 +00:00
|
|
|
|
2017-04-19 07:39:27 +00:00
|
|
|
/**
|
|
|
|
* eeh_handle_special_event - Handle EEH events without a specific failing PE
|
|
|
|
*
|
|
|
|
* Called when an EEH event is detected but can't be narrowed down to a
|
|
|
|
* specific PE. Iterates through possible failures and handles them as
|
|
|
|
* necessary.
|
|
|
|
*/
|
2018-03-19 02:46:20 +00:00
|
|
|
void eeh_handle_special_event(void)
|
2013-06-20 05:21:04 +00:00
|
|
|
{
|
2019-08-16 04:48:06 +00:00
|
|
|
struct eeh_pe *pe, *phb_pe, *tmp_pe;
|
|
|
|
struct eeh_dev *edev, *tmp_edev;
|
2013-06-20 05:21:04 +00:00
|
|
|
struct pci_bus *bus;
|
2014-01-15 05:16:11 +00:00
|
|
|
struct pci_controller *hose;
|
2013-06-20 05:21:04 +00:00
|
|
|
unsigned long flags;
|
2014-01-15 05:16:11 +00:00
|
|
|
int rc;
|
2013-06-20 05:21:04 +00:00
|
|
|
|
|
|
|
|
2014-01-15 05:16:11 +00:00
|
|
|
do {
|
|
|
|
rc = eeh_ops->next_error(&pe);
|
|
|
|
|
|
|
|
switch (rc) {
|
|
|
|
case EEH_NEXT_ERR_DEAD_IOC:
|
|
|
|
/* Mark all PHBs in dead state */
|
|
|
|
eeh_serialize_lock(&flags);
|
|
|
|
|
|
|
|
/* Purge all events */
|
2014-06-04 07:31:52 +00:00
|
|
|
eeh_remove_event(NULL, true);
|
2014-01-15 05:16:11 +00:00
|
|
|
|
|
|
|
list_for_each_entry(hose, &hose_list, list_node) {
|
|
|
|
phb_pe = eeh_phb_pe_get(hose);
|
|
|
|
if (!phb_pe) continue;
|
|
|
|
|
2018-09-12 01:23:31 +00:00
|
|
|
eeh_pe_mark_isolated(phb_pe);
|
2014-01-15 05:16:11 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
eeh_serialize_unlock(flags);
|
|
|
|
|
|
|
|
break;
|
|
|
|
case EEH_NEXT_ERR_FROZEN_PE:
|
|
|
|
case EEH_NEXT_ERR_FENCED_PHB:
|
|
|
|
case EEH_NEXT_ERR_DEAD_PHB:
|
|
|
|
/* Mark the PE in fenced state */
|
|
|
|
eeh_serialize_lock(&flags);
|
|
|
|
|
|
|
|
/* Purge all events of the PHB */
|
2014-06-04 07:31:52 +00:00
|
|
|
eeh_remove_event(pe, true);
|
2014-01-15 05:16:11 +00:00
|
|
|
|
2018-09-12 01:23:31 +00:00
|
|
|
if (rc != EEH_NEXT_ERR_DEAD_PHB)
|
|
|
|
eeh_pe_state_mark(pe, EEH_PE_RECOVERING);
|
|
|
|
eeh_pe_mark_isolated(pe);
|
2014-01-15 05:16:11 +00:00
|
|
|
|
|
|
|
eeh_serialize_unlock(flags);
|
|
|
|
|
|
|
|
break;
|
|
|
|
case EEH_NEXT_ERR_NONE:
|
|
|
|
return;
|
|
|
|
default:
|
|
|
|
pr_warn("%s: Invalid value %d from next_error()\n",
|
|
|
|
__func__, rc);
|
|
|
|
return;
|
2013-06-20 05:21:04 +00:00
|
|
|
}
|
|
|
|
|
2014-01-15 05:16:11 +00:00
|
|
|
/*
|
|
|
|
* For fenced PHB and frozen PE, it's handled as normal
|
|
|
|
* event. We have to remove the affected PHBs for dead
|
|
|
|
* PHB and IOC
|
|
|
|
*/
|
|
|
|
if (rc == EEH_NEXT_ERR_FROZEN_PE ||
|
|
|
|
rc == EEH_NEXT_ERR_FENCED_PHB) {
|
2019-09-03 10:15:52 +00:00
|
|
|
eeh_pe_state_mark(pe, EEH_PE_RECOVERING);
|
2018-03-19 02:46:30 +00:00
|
|
|
eeh_handle_normal_event(pe);
|
2014-01-15 05:16:11 +00:00
|
|
|
} else {
|
2020-02-07 04:57:31 +00:00
|
|
|
eeh_for_each_pe(pe, tmp_pe)
|
|
|
|
eeh_pe_for_each_dev(tmp_pe, edev, tmp_edev)
|
|
|
|
edev->mode &= ~EEH_DEV_NO_HANDLER;
|
|
|
|
|
|
|
|
/* Notify all devices to be down */
|
|
|
|
eeh_pe_state_clear(pe, EEH_PE_PRI_BUS, true);
|
|
|
|
eeh_pe_report(
|
|
|
|
"error_detected(permanent failure)", pe,
|
|
|
|
eeh_report_failure, NULL);
|
powerpc/eeh: Set channel state after notifying the drivers
When a PCI error is encountered 6th time in an hour we
set the channel state to perm_failure and notify the
driver about the permanent failure.
However, after upstream commit 38ddc011478e ("powerpc/eeh:
Make permanently failed devices non-actionable"), EEH handler
stops calling any routine once the device is marked as
permanent failure. This issue can lead to fatal consequences
like kernel hang with certain PCI devices.
Following log is observed with lpfc driver, with and without
this change, Without this change kernel hangs, If PCI error
is encountered 6 times for a device in an hour.
Without the change
EEH: Beginning: 'error_detected(permanent failure)'
PCI 0132:60:00.0#600000: EEH: not actionable (1,1,1)
PCI 0132:60:00.1#600000: EEH: not actionable (1,1,1)
EEH: Finished:'error_detected(permanent failure)'
With the change
EEH: Beginning: 'error_detected(permanent failure)'
EEH: Invoking lpfc->error_detected(permanent failure)
EEH: lpfc driver reports: 'disconnect'
EEH: Invoking lpfc->error_detected(permanent failure)
EEH: lpfc driver reports: 'disconnect'
EEH: Finished:'error_detected(permanent failure)'
To fix the issue, set channel state to permanent failure after
notifying the drivers.
Fixes: 38ddc011478e ("powerpc/eeh: Make permanently failed devices non-actionable")
Suggested-by: Mahesh Salgaonkar <mahesh@linux.ibm.com>
Signed-off-by: Ganesh Goudar <ganeshgr@linux.ibm.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20230209105649.127707-1-ganeshgr@linux.ibm.com
2023-02-09 10:56:49 +00:00
|
|
|
eeh_set_channel_state(pe, pci_channel_io_perm_failure);
|
2020-02-07 04:57:31 +00:00
|
|
|
|
2014-01-28 05:11:26 +00:00
|
|
|
pci_lock_rescan_remove();
|
2014-01-15 05:16:11 +00:00
|
|
|
list_for_each_entry(hose, &hose_list, list_node) {
|
|
|
|
phb_pe = eeh_phb_pe_get(hose);
|
|
|
|
if (!phb_pe ||
|
2014-04-24 08:00:07 +00:00
|
|
|
!(phb_pe->state & EEH_PE_ISOLATED) ||
|
|
|
|
(phb_pe->state & EEH_PE_RECOVERING))
|
2014-01-15 05:16:11 +00:00
|
|
|
continue;
|
|
|
|
|
|
|
|
bus = eeh_pe_bus_get(phb_pe);
|
2016-09-12 04:17:22 +00:00
|
|
|
if (!bus) {
|
|
|
|
pr_err("%s: Cannot find PCI bus for "
|
2016-11-16 03:02:15 +00:00
|
|
|
"PHB#%x-PE#%x\n",
|
2016-09-12 04:17:22 +00:00
|
|
|
__func__,
|
|
|
|
pe->phb->global_number,
|
|
|
|
pe->addr);
|
|
|
|
break;
|
|
|
|
}
|
2016-05-03 05:41:37 +00:00
|
|
|
pci_hp_remove_devices(bus);
|
2014-01-15 05:16:11 +00:00
|
|
|
}
|
2014-01-28 05:11:26 +00:00
|
|
|
pci_unlock_rescan_remove();
|
2013-06-20 05:21:04 +00:00
|
|
|
}
|
2014-01-15 05:16:11 +00:00
|
|
|
|
|
|
|
/*
|
|
|
|
* If we have detected dead IOC, we needn't proceed
|
|
|
|
* any more since all PHBs would have been removed
|
|
|
|
*/
|
|
|
|
if (rc == EEH_NEXT_ERR_DEAD_IOC)
|
|
|
|
break;
|
|
|
|
} while (rc != EEH_NEXT_ERR_NONE);
|
2013-06-20 05:21:04 +00:00
|
|
|
}
|