2008-02-06 01:57:48 +00:00
|
|
|
/*
|
|
|
|
* Palmchip bk3710 IDE controller
|
|
|
|
*
|
|
|
|
* Copyright (C) 2006 Texas Instruments.
|
|
|
|
* Copyright (C) 2007 MontaVista Software, Inc., <source@mvista.com>
|
|
|
|
*
|
|
|
|
* ----------------------------------------------------------------------------
|
|
|
|
*
|
|
|
|
* This program is free software; you can redistribute it and/or modify
|
|
|
|
* it under the terms of the GNU General Public License as published by
|
|
|
|
* the Free Software Foundation; either version 2 of the License, or
|
|
|
|
* (at your option) any later version.
|
|
|
|
*
|
|
|
|
* This program is distributed in the hope that it will be useful,
|
|
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
|
|
* GNU General Public License for more details.
|
|
|
|
*
|
|
|
|
* You should have received a copy of the GNU General Public License
|
|
|
|
* along with this program; if not, write to the Free Software
|
|
|
|
* Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
|
|
|
|
* ----------------------------------------------------------------------------
|
|
|
|
*
|
|
|
|
*/
|
|
|
|
|
|
|
|
#include <linux/types.h>
|
|
|
|
#include <linux/module.h>
|
|
|
|
#include <linux/kernel.h>
|
|
|
|
#include <linux/ioport.h>
|
|
|
|
#include <linux/hdreg.h>
|
|
|
|
#include <linux/ide.h>
|
|
|
|
#include <linux/delay.h>
|
|
|
|
#include <linux/init.h>
|
|
|
|
#include <linux/clk.h>
|
|
|
|
#include <linux/platform_device.h>
|
|
|
|
|
|
|
|
/* Offset of the primary interface registers */
|
|
|
|
#define IDE_PALM_ATA_PRI_REG_OFFSET 0x1F0
|
|
|
|
|
|
|
|
/* Primary Control Offset */
|
|
|
|
#define IDE_PALM_ATA_PRI_CTL_OFFSET 0x3F6
|
|
|
|
|
|
|
|
/*
|
|
|
|
* PalmChip 3710 IDE Controller UDMA timing structure Definition
|
|
|
|
*/
|
|
|
|
struct palm_bk3710_udmatiming {
|
|
|
|
unsigned int rptime; /* Ready to pause time */
|
|
|
|
unsigned int cycletime; /* Cycle Time */
|
|
|
|
};
|
|
|
|
|
|
|
|
#define BK3710_BMICP 0x00
|
|
|
|
#define BK3710_BMISP 0x02
|
|
|
|
#define BK3710_BMIDTP 0x04
|
|
|
|
#define BK3710_BMICS 0x08
|
|
|
|
#define BK3710_BMISS 0x0A
|
|
|
|
#define BK3710_BMIDTS 0x0C
|
|
|
|
#define BK3710_IDETIMP 0x40
|
|
|
|
#define BK3710_IDETIMS 0x42
|
|
|
|
#define BK3710_SIDETIM 0x44
|
|
|
|
#define BK3710_SLEWCTL 0x45
|
|
|
|
#define BK3710_IDESTATUS 0x47
|
|
|
|
#define BK3710_UDMACTL 0x48
|
|
|
|
#define BK3710_UDMATIM 0x4A
|
|
|
|
#define BK3710_MISCCTL 0x50
|
|
|
|
#define BK3710_REGSTB 0x54
|
|
|
|
#define BK3710_REGRCVR 0x58
|
|
|
|
#define BK3710_DATSTB 0x5C
|
|
|
|
#define BK3710_DATRCVR 0x60
|
|
|
|
#define BK3710_DMASTB 0x64
|
|
|
|
#define BK3710_DMARCVR 0x68
|
|
|
|
#define BK3710_UDMASTB 0x6C
|
|
|
|
#define BK3710_UDMATRP 0x70
|
|
|
|
#define BK3710_UDMAENV 0x74
|
|
|
|
#define BK3710_IORDYTMP 0x78
|
|
|
|
#define BK3710_IORDYTMS 0x7C
|
|
|
|
|
|
|
|
#include "../ide-timing.h"
|
|
|
|
|
|
|
|
static long ide_palm_clk;
|
|
|
|
|
|
|
|
static const struct palm_bk3710_udmatiming palm_bk3710_udmatimings[6] = {
|
|
|
|
{160, 240}, /* UDMA Mode 0 */
|
|
|
|
{125, 160}, /* UDMA Mode 1 */
|
|
|
|
{100, 120}, /* UDMA Mode 2 */
|
|
|
|
{100, 90}, /* UDMA Mode 3 */
|
|
|
|
{85, 60}, /* UDMA Mode 4 */
|
|
|
|
};
|
|
|
|
|
|
|
|
static struct clk *ideclkp;
|
|
|
|
|
|
|
|
static void palm_bk3710_setudmamode(void __iomem *base, unsigned int dev,
|
|
|
|
unsigned int mode)
|
|
|
|
{
|
|
|
|
u8 tenv, trp, t0;
|
|
|
|
u32 val32;
|
|
|
|
u16 val16;
|
|
|
|
|
|
|
|
/* DMA Data Setup */
|
2008-04-26 15:36:35 +00:00
|
|
|
t0 = DIV_ROUND_UP(palm_bk3710_udmatimings[mode].cycletime,
|
|
|
|
ide_palm_clk) - 1;
|
|
|
|
tenv = DIV_ROUND_UP(20, ide_palm_clk) - 1;
|
|
|
|
trp = DIV_ROUND_UP(palm_bk3710_udmatimings[mode].rptime,
|
|
|
|
ide_palm_clk) - 1;
|
2008-02-06 01:57:48 +00:00
|
|
|
|
|
|
|
/* udmatim Register */
|
|
|
|
val16 = readw(base + BK3710_UDMATIM) & (dev ? 0xFF0F : 0xFFF0);
|
|
|
|
val16 |= (mode << (dev ? 4 : 0));
|
|
|
|
writew(val16, base + BK3710_UDMATIM);
|
|
|
|
|
|
|
|
/* udmastb Ultra DMA Access Strobe Width */
|
|
|
|
val32 = readl(base + BK3710_UDMASTB) & (0xFF << (dev ? 0 : 8));
|
|
|
|
val32 |= (t0 << (dev ? 8 : 0));
|
|
|
|
writel(val32, base + BK3710_UDMASTB);
|
|
|
|
|
|
|
|
/* udmatrp Ultra DMA Ready to Pause Time */
|
|
|
|
val32 = readl(base + BK3710_UDMATRP) & (0xFF << (dev ? 0 : 8));
|
|
|
|
val32 |= (trp << (dev ? 8 : 0));
|
|
|
|
writel(val32, base + BK3710_UDMATRP);
|
|
|
|
|
|
|
|
/* udmaenv Ultra DMA envelop Time */
|
|
|
|
val32 = readl(base + BK3710_UDMAENV) & (0xFF << (dev ? 0 : 8));
|
|
|
|
val32 |= (tenv << (dev ? 8 : 0));
|
|
|
|
writel(val32, base + BK3710_UDMAENV);
|
|
|
|
|
|
|
|
/* Enable UDMA for Device */
|
|
|
|
val16 = readw(base + BK3710_UDMACTL) | (1 << dev);
|
|
|
|
writew(val16, base + BK3710_UDMACTL);
|
|
|
|
}
|
|
|
|
|
|
|
|
static void palm_bk3710_setdmamode(void __iomem *base, unsigned int dev,
|
|
|
|
unsigned short min_cycle,
|
|
|
|
unsigned int mode)
|
|
|
|
{
|
|
|
|
u8 td, tkw, t0;
|
|
|
|
u32 val32;
|
|
|
|
u16 val16;
|
|
|
|
struct ide_timing *t;
|
|
|
|
int cycletime;
|
|
|
|
|
|
|
|
t = ide_timing_find_mode(mode);
|
|
|
|
cycletime = max_t(int, t->cycle, min_cycle);
|
|
|
|
|
|
|
|
/* DMA Data Setup */
|
2008-04-26 15:36:35 +00:00
|
|
|
t0 = DIV_ROUND_UP(cycletime, ide_palm_clk);
|
|
|
|
td = DIV_ROUND_UP(t->active, ide_palm_clk);
|
2008-02-06 01:57:48 +00:00
|
|
|
tkw = t0 - td - 1;
|
|
|
|
td -= 1;
|
|
|
|
|
|
|
|
val32 = readl(base + BK3710_DMASTB) & (0xFF << (dev ? 0 : 8));
|
|
|
|
val32 |= (td << (dev ? 8 : 0));
|
|
|
|
writel(val32, base + BK3710_DMASTB);
|
|
|
|
|
|
|
|
val32 = readl(base + BK3710_DMARCVR) & (0xFF << (dev ? 0 : 8));
|
|
|
|
val32 |= (tkw << (dev ? 8 : 0));
|
|
|
|
writel(val32, base + BK3710_DMARCVR);
|
|
|
|
|
|
|
|
/* Disable UDMA for Device */
|
|
|
|
val16 = readw(base + BK3710_UDMACTL) & ~(1 << dev);
|
|
|
|
writew(val16, base + BK3710_UDMACTL);
|
|
|
|
}
|
|
|
|
|
|
|
|
static void palm_bk3710_setpiomode(void __iomem *base, ide_drive_t *mate,
|
|
|
|
unsigned int dev, unsigned int cycletime,
|
|
|
|
unsigned int mode)
|
|
|
|
{
|
|
|
|
u8 t2, t2i, t0;
|
|
|
|
u32 val32;
|
|
|
|
struct ide_timing *t;
|
|
|
|
|
|
|
|
/* PIO Data Setup */
|
2008-04-26 15:36:35 +00:00
|
|
|
t0 = DIV_ROUND_UP(cycletime, ide_palm_clk);
|
|
|
|
t2 = DIV_ROUND_UP(ide_timing_find_mode(XFER_PIO_0 + mode)->active,
|
|
|
|
ide_palm_clk);
|
2008-02-06 01:57:48 +00:00
|
|
|
|
|
|
|
t2i = t0 - t2 - 1;
|
|
|
|
t2 -= 1;
|
|
|
|
|
|
|
|
val32 = readl(base + BK3710_DATSTB) & (0xFF << (dev ? 0 : 8));
|
|
|
|
val32 |= (t2 << (dev ? 8 : 0));
|
|
|
|
writel(val32, base + BK3710_DATSTB);
|
|
|
|
|
|
|
|
val32 = readl(base + BK3710_DATRCVR) & (0xFF << (dev ? 0 : 8));
|
|
|
|
val32 |= (t2i << (dev ? 8 : 0));
|
|
|
|
writel(val32, base + BK3710_DATRCVR);
|
|
|
|
|
|
|
|
if (mate && mate->present) {
|
|
|
|
u8 mode2 = ide_get_best_pio_mode(mate, 255, 4);
|
|
|
|
|
|
|
|
if (mode2 < mode)
|
|
|
|
mode = mode2;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* TASKFILE Setup */
|
|
|
|
t = ide_timing_find_mode(XFER_PIO_0 + mode);
|
2008-04-26 15:36:35 +00:00
|
|
|
t0 = DIV_ROUND_UP(t->cyc8b, ide_palm_clk);
|
|
|
|
t2 = DIV_ROUND_UP(t->act8b, ide_palm_clk);
|
2008-02-06 01:57:48 +00:00
|
|
|
|
|
|
|
t2i = t0 - t2 - 1;
|
|
|
|
t2 -= 1;
|
|
|
|
|
|
|
|
val32 = readl(base + BK3710_REGSTB) & (0xFF << (dev ? 0 : 8));
|
|
|
|
val32 |= (t2 << (dev ? 8 : 0));
|
|
|
|
writel(val32, base + BK3710_REGSTB);
|
|
|
|
|
|
|
|
val32 = readl(base + BK3710_REGRCVR) & (0xFF << (dev ? 0 : 8));
|
|
|
|
val32 |= (t2i << (dev ? 8 : 0));
|
|
|
|
writel(val32, base + BK3710_REGRCVR);
|
|
|
|
}
|
|
|
|
|
|
|
|
static void palm_bk3710_set_dma_mode(ide_drive_t *drive, u8 xferspeed)
|
|
|
|
{
|
|
|
|
int is_slave = drive->dn & 1;
|
|
|
|
void __iomem *base = (void *)drive->hwif->dma_base;
|
|
|
|
|
|
|
|
if (xferspeed >= XFER_UDMA_0) {
|
|
|
|
palm_bk3710_setudmamode(base, is_slave,
|
|
|
|
xferspeed - XFER_UDMA_0);
|
|
|
|
} else {
|
|
|
|
palm_bk3710_setdmamode(base, is_slave, drive->id->eide_dma_min,
|
|
|
|
xferspeed);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
static void palm_bk3710_set_pio_mode(ide_drive_t *drive, u8 pio)
|
|
|
|
{
|
|
|
|
unsigned int cycle_time;
|
|
|
|
int is_slave = drive->dn & 1;
|
|
|
|
ide_drive_t *mate;
|
|
|
|
void __iomem *base = (void *)drive->hwif->dma_base;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Obtain the drive PIO data for tuning the Palm Chip registers
|
|
|
|
*/
|
|
|
|
cycle_time = ide_pio_cycle_time(drive, pio);
|
|
|
|
mate = ide_get_paired_drive(drive);
|
|
|
|
palm_bk3710_setpiomode(base, mate, is_slave, cycle_time, pio);
|
|
|
|
}
|
|
|
|
|
|
|
|
static void __devinit palm_bk3710_chipinit(void __iomem *base)
|
|
|
|
{
|
|
|
|
/*
|
|
|
|
* enable the reset_en of ATA controller so that when ata signals
|
|
|
|
* are brought out, by writing into device config. at that
|
|
|
|
* time por_n signal should not be 'Z' and have a stable value.
|
|
|
|
*/
|
|
|
|
writel(0x0300, base + BK3710_MISCCTL);
|
|
|
|
|
|
|
|
/* wait for some time and deassert the reset of ATA Device. */
|
|
|
|
mdelay(100);
|
|
|
|
|
|
|
|
/* Deassert the Reset */
|
|
|
|
writel(0x0200, base + BK3710_MISCCTL);
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Program the IDETIMP Register Value based on the following assumptions
|
|
|
|
*
|
|
|
|
* (ATA_IDETIMP_IDEEN , ENABLE ) |
|
|
|
|
* (ATA_IDETIMP_SLVTIMEN , DISABLE) |
|
|
|
|
* (ATA_IDETIMP_RDYSMPL , 70NS) |
|
|
|
|
* (ATA_IDETIMP_RDYRCVRY , 50NS) |
|
|
|
|
* (ATA_IDETIMP_DMAFTIM1 , PIOCOMP) |
|
|
|
|
* (ATA_IDETIMP_PREPOST1 , DISABLE) |
|
|
|
|
* (ATA_IDETIMP_RDYSEN1 , DISABLE) |
|
|
|
|
* (ATA_IDETIMP_PIOFTIM1 , DISABLE) |
|
|
|
|
* (ATA_IDETIMP_DMAFTIM0 , PIOCOMP) |
|
|
|
|
* (ATA_IDETIMP_PREPOST0 , DISABLE) |
|
|
|
|
* (ATA_IDETIMP_RDYSEN0 , DISABLE) |
|
|
|
|
* (ATA_IDETIMP_PIOFTIM0 , DISABLE)
|
|
|
|
*/
|
|
|
|
writew(0xB388, base + BK3710_IDETIMP);
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Configure SIDETIM Register
|
|
|
|
* (ATA_SIDETIM_RDYSMPS1 ,120NS ) |
|
|
|
|
* (ATA_SIDETIM_RDYRCYS1 ,120NS )
|
|
|
|
*/
|
|
|
|
writeb(0, base + BK3710_SIDETIM);
|
|
|
|
|
|
|
|
/*
|
|
|
|
* UDMACTL Ultra-ATA DMA Control
|
|
|
|
* (ATA_UDMACTL_UDMAP1 , 0 ) |
|
|
|
|
* (ATA_UDMACTL_UDMAP0 , 0 )
|
|
|
|
*
|
|
|
|
*/
|
|
|
|
writew(0, base + BK3710_UDMACTL);
|
|
|
|
|
|
|
|
/*
|
|
|
|
* MISCCTL Miscellaneous Conrol Register
|
|
|
|
* (ATA_MISCCTL_RSTMODEP , 1) |
|
|
|
|
* (ATA_MISCCTL_RESETP , 0) |
|
|
|
|
* (ATA_MISCCTL_TIMORIDE , 1)
|
|
|
|
*/
|
|
|
|
writel(0x201, base + BK3710_MISCCTL);
|
|
|
|
|
|
|
|
/*
|
|
|
|
* IORDYTMP IORDY Timer for Primary Register
|
|
|
|
* (ATA_IORDYTMP_IORDYTMP , 0xffff )
|
|
|
|
*/
|
|
|
|
writel(0xFFFF, base + BK3710_IORDYTMP);
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Configure BMISP Register
|
|
|
|
* (ATA_BMISP_DMAEN1 , DISABLE ) |
|
|
|
|
* (ATA_BMISP_DMAEN0 , DISABLE ) |
|
|
|
|
* (ATA_BMISP_IORDYINT , CLEAR) |
|
|
|
|
* (ATA_BMISP_INTRSTAT , CLEAR) |
|
|
|
|
* (ATA_BMISP_DMAERROR , CLEAR)
|
|
|
|
*/
|
|
|
|
writew(0, base + BK3710_BMISP);
|
|
|
|
|
|
|
|
palm_bk3710_setpiomode(base, NULL, 0, 600, 0);
|
|
|
|
palm_bk3710_setpiomode(base, NULL, 1, 600, 0);
|
|
|
|
}
|
2008-02-10 23:32:13 +00:00
|
|
|
|
|
|
|
static u8 __devinit palm_bk3710_cable_detect(ide_hwif_t *hwif)
|
|
|
|
{
|
|
|
|
return ATA_CBL_PATA80;
|
|
|
|
}
|
|
|
|
|
2008-04-26 20:25:14 +00:00
|
|
|
static const struct ide_port_ops palm_bk3710_ports_ops = {
|
|
|
|
.set_pio_mode = palm_bk3710_set_pio_mode,
|
|
|
|
.set_dma_mode = palm_bk3710_set_dma_mode,
|
|
|
|
.cable_detect = palm_bk3710_cable_detect,
|
|
|
|
};
|
2008-02-10 23:32:13 +00:00
|
|
|
|
|
|
|
static const struct ide_port_info __devinitdata palm_bk3710_port_info = {
|
2008-04-26 20:25:14 +00:00
|
|
|
.port_ops = &palm_bk3710_ports_ops,
|
2008-02-10 23:32:13 +00:00
|
|
|
.host_flags = IDE_HFLAG_NO_DMA, /* hack (no PCI) */
|
|
|
|
.pio_mask = ATA_PIO4,
|
|
|
|
.udma_mask = ATA_UDMA4, /* (input clk 99MHz) */
|
|
|
|
.mwdma_mask = ATA_MWDMA2,
|
|
|
|
};
|
|
|
|
|
2008-02-06 01:57:48 +00:00
|
|
|
static int __devinit palm_bk3710_probe(struct platform_device *pdev)
|
|
|
|
{
|
|
|
|
struct clk *clkp;
|
|
|
|
struct resource *mem, *irq;
|
|
|
|
ide_hwif_t *hwif;
|
|
|
|
void __iomem *base;
|
2008-02-10 23:32:12 +00:00
|
|
|
int pribase, i;
|
|
|
|
hw_regs_t hw;
|
|
|
|
u8 idx[4] = { 0xff, 0xff, 0xff, 0xff };
|
2008-02-06 01:57:48 +00:00
|
|
|
|
|
|
|
clkp = clk_get(NULL, "IDECLK");
|
|
|
|
if (IS_ERR(clkp))
|
|
|
|
return -ENODEV;
|
|
|
|
|
|
|
|
ideclkp = clkp;
|
|
|
|
clk_enable(ideclkp);
|
|
|
|
ide_palm_clk = clk_get_rate(ideclkp)/100000;
|
|
|
|
ide_palm_clk = (10000/ide_palm_clk) + 1;
|
|
|
|
/* Register the IDE interface with Linux ATA Interface */
|
2008-02-10 23:32:12 +00:00
|
|
|
memset(&hw, 0, sizeof(hw));
|
2008-02-06 01:57:48 +00:00
|
|
|
|
|
|
|
mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
|
|
|
|
if (mem == NULL) {
|
|
|
|
printk(KERN_ERR "failed to get memory region resource\n");
|
|
|
|
return -ENODEV;
|
|
|
|
}
|
|
|
|
irq = platform_get_resource(pdev, IORESOURCE_IRQ, 0);
|
|
|
|
if (irq == NULL) {
|
|
|
|
printk(KERN_ERR "failed to get IRQ resource\n");
|
|
|
|
return -ENODEV;
|
|
|
|
}
|
|
|
|
|
|
|
|
base = (void *)mem->start;
|
|
|
|
|
|
|
|
/* Configure the Palm Chip controller */
|
|
|
|
palm_bk3710_chipinit(base);
|
|
|
|
|
|
|
|
pribase = mem->start + IDE_PALM_ATA_PRI_REG_OFFSET;
|
2008-02-10 23:32:12 +00:00
|
|
|
for (i = 0; i < IDE_NR_PORTS - 2; i++)
|
|
|
|
hw.io_ports[i] = pribase + i;
|
|
|
|
hw.io_ports[IDE_CONTROL_OFFSET] = mem->start +
|
2008-02-06 01:57:48 +00:00
|
|
|
IDE_PALM_ATA_PRI_CTL_OFFSET;
|
2008-02-10 23:32:12 +00:00
|
|
|
hw.irq = irq->start;
|
|
|
|
hw.chipset = ide_palm3710;
|
2008-02-06 01:57:48 +00:00
|
|
|
|
2008-04-26 15:36:32 +00:00
|
|
|
hwif = ide_find_port();
|
2008-02-10 23:32:12 +00:00
|
|
|
if (hwif == NULL)
|
|
|
|
goto out;
|
|
|
|
|
|
|
|
i = hwif->index;
|
|
|
|
|
|
|
|
if (hwif->present)
|
ide: remove broken/dangerous HDIO_[UNREGISTER,SCAN]_HWIF ioctls (take 3)
hdparm explicitely marks HDIO_[UNREGISTER,SCAN]_HWIF ioctls as DANGEROUS
and given the number of bugs we can assume that there are no real users:
* DMA has no chance of working because DMA resources are released by
ide_unregister() and they are never allocated again.
* Since ide_init_hwif_ports() is used for ->io_ports[] setup the ioctls
don't work for almost all hosts with "non-standard" (== non ISA-like)
layout of IDE taskfile registers (there is a lot of such host drivers).
* ide_port_init_devices() is not called when probing IDE devices so:
- drive->autotune is never set and IDE host/devices are not programmed
for the correct PIO/DMA transfer modes (=> possible data corruption)
- host specific I/O 32-bit and IRQ unmasking settings are not applied
(=> possible data corruption)
- host specific ->port_init_devs method is not called (=> no luck with
ht6560b, qd65xx and opti621 host drivers)
* ->rw_disk method is not preserved (=> no HPT3xxN chipsets support).
* ->serialized flag is not preserved (=> possible data corruption when
using icside, aec62xx (ATP850UF chipset), cmd640, cs5530, hpt366
(HPT3xxN chipsets), rz1000, sc1200, dtc2278 and ht6560b host drivers).
* ->ack_intr method is not preserved (=> needed by ide-cris, buddha,
gayle and macide host drivers).
* ->sata_scr[] and sata_misc[] is cleared by ide_unregister() and it
isn't initialized again (SiI3112 support needs them).
* To issue an ioctl() there need to be at least one IDE device present
in the system.
* ->cable_detect method is not preserved + it is not called when probing
IDE devices so cable detection is broken (however since DMA support is
also broken it doesn't really matter ;-).
* Some objects which may have already been freed in ide_unregister()
are restored by ide_hwif_restore() (i.e. ->hwgroup).
* ide_register_hw() may unregister unrelated IDE ports if free ide_hwifs[]
slot cannot be found.
* When IDE host drivers are modular unregistered port may be re-used by
different host driver that owned it first causing subtle bugs.
Since we now have a proper warm-plug support remove these ioctls,
then remove no longer needed:
- ide_register_hw() and ide_hwif_restore() functions
- 'init_default' and 'restore' arguments of ide_unregister()
- zeroeing of hwif->{dma,extra}_* fields in ide_unregister()
As an added bonus IDE core code size shrinks by ~3kB (x86-32).
v2:
* fix ide_unregister() arguments in cleanup_module() (Andrew Morton).
v3:
* fix ide_unregister() arguments in palm_bk3710.c.
Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
2008-04-17 22:46:24 +00:00
|
|
|
ide_unregister(i);
|
2008-04-17 22:46:24 +00:00
|
|
|
else
|
2008-02-10 23:32:12 +00:00
|
|
|
ide_init_port_data(hwif, i);
|
|
|
|
|
|
|
|
ide_init_port_hw(hwif, &hw);
|
|
|
|
|
2008-02-06 01:57:48 +00:00
|
|
|
hwif->mmio = 1;
|
|
|
|
default_hwif_mmiops(hwif);
|
|
|
|
|
2008-04-26 20:25:21 +00:00
|
|
|
printk(KERN_INFO " %s: MMIO-DMA\n", hwif->name);
|
|
|
|
|
|
|
|
if (ide_allocate_dma_engine(hwif) == 0)
|
|
|
|
ide_setup_dma(hwif, mem->start);
|
2008-02-06 01:57:48 +00:00
|
|
|
|
2008-02-10 23:32:13 +00:00
|
|
|
idx[0] = i;
|
|
|
|
|
2008-02-10 23:32:13 +00:00
|
|
|
ide_device_add(idx, &palm_bk3710_port_info);
|
2008-02-10 23:32:13 +00:00
|
|
|
|
|
|
|
if (!hwif->present)
|
|
|
|
goto out;
|
|
|
|
|
2008-02-06 01:57:48 +00:00
|
|
|
return 0;
|
2008-02-10 23:32:12 +00:00
|
|
|
out:
|
|
|
|
printk(KERN_WARNING "Palm Chip BK3710 IDE Register Fail\n");
|
|
|
|
return -ENODEV;
|
2008-02-06 01:57:48 +00:00
|
|
|
}
|
|
|
|
|
2008-04-18 20:41:57 +00:00
|
|
|
/* work with hotplug and coldplug */
|
|
|
|
MODULE_ALIAS("platform:palm_bk3710");
|
|
|
|
|
2008-02-06 01:57:48 +00:00
|
|
|
static struct platform_driver platform_bk_driver = {
|
|
|
|
.driver = {
|
|
|
|
.name = "palm_bk3710",
|
2008-04-18 20:41:57 +00:00
|
|
|
.owner = THIS_MODULE,
|
2008-02-06 01:57:48 +00:00
|
|
|
},
|
|
|
|
.probe = palm_bk3710_probe,
|
|
|
|
.remove = NULL,
|
|
|
|
};
|
|
|
|
|
|
|
|
static int __init palm_bk3710_init(void)
|
|
|
|
{
|
|
|
|
return platform_driver_register(&platform_bk_driver);
|
|
|
|
}
|
|
|
|
|
|
|
|
module_init(palm_bk3710_init);
|
|
|
|
MODULE_LICENSE("GPL");
|
|
|
|
|