License cleanup: add SPDX GPL-2.0 license identifier to files with no license
Many source files in the tree are missing licensing information, which
makes it harder for compliance tools to determine the correct license.
By default all files without license information are under the default
license of the kernel, which is GPL version 2.
Update the files which contain no license information with the 'GPL-2.0'
SPDX license identifier. The SPDX identifier is a legally binding
shorthand, which can be used instead of the full boiler plate text.
This patch is based on work done by Thomas Gleixner and Kate Stewart and
Philippe Ombredanne.
How this work was done:
Patches were generated and checked against linux-4.14-rc6 for a subset of
the use cases:
- file had no licensing information it it.
- file was a */uapi/* one with no licensing information in it,
- file was a */uapi/* one with existing licensing information,
Further patches will be generated in subsequent months to fix up cases
where non-standard license headers were used, and references to license
had to be inferred by heuristics based on keywords.
The analysis to determine which SPDX License Identifier to be applied to
a file was done in a spreadsheet of side by side results from of the
output of two independent scanners (ScanCode & Windriver) producing SPDX
tag:value files created by Philippe Ombredanne. Philippe prepared the
base worksheet, and did an initial spot review of a few 1000 files.
The 4.13 kernel was the starting point of the analysis with 60,537 files
assessed. Kate Stewart did a file by file comparison of the scanner
results in the spreadsheet to determine which SPDX license identifier(s)
to be applied to the file. She confirmed any determination that was not
immediately clear with lawyers working with the Linux Foundation.
Criteria used to select files for SPDX license identifier tagging was:
- Files considered eligible had to be source code files.
- Make and config files were included as candidates if they contained >5
lines of source
- File already had some variant of a license header in it (even if <5
lines).
All documentation files were explicitly excluded.
The following heuristics were used to determine which SPDX license
identifiers to apply.
- when both scanners couldn't find any license traces, file was
considered to have no license information in it, and the top level
COPYING file license applied.
For non */uapi/* files that summary was:
SPDX license identifier # files
---------------------------------------------------|-------
GPL-2.0 11139
and resulted in the first patch in this series.
If that file was a */uapi/* path one, it was "GPL-2.0 WITH
Linux-syscall-note" otherwise it was "GPL-2.0". Results of that was:
SPDX license identifier # files
---------------------------------------------------|-------
GPL-2.0 WITH Linux-syscall-note 930
and resulted in the second patch in this series.
- if a file had some form of licensing information in it, and was one
of the */uapi/* ones, it was denoted with the Linux-syscall-note if
any GPL family license was found in the file or had no licensing in
it (per prior point). Results summary:
SPDX license identifier # files
---------------------------------------------------|------
GPL-2.0 WITH Linux-syscall-note 270
GPL-2.0+ WITH Linux-syscall-note 169
((GPL-2.0 WITH Linux-syscall-note) OR BSD-2-Clause) 21
((GPL-2.0 WITH Linux-syscall-note) OR BSD-3-Clause) 17
LGPL-2.1+ WITH Linux-syscall-note 15
GPL-1.0+ WITH Linux-syscall-note 14
((GPL-2.0+ WITH Linux-syscall-note) OR BSD-3-Clause) 5
LGPL-2.0+ WITH Linux-syscall-note 4
LGPL-2.1 WITH Linux-syscall-note 3
((GPL-2.0 WITH Linux-syscall-note) OR MIT) 3
((GPL-2.0 WITH Linux-syscall-note) AND MIT) 1
and that resulted in the third patch in this series.
- when the two scanners agreed on the detected license(s), that became
the concluded license(s).
- when there was disagreement between the two scanners (one detected a
license but the other didn't, or they both detected different
licenses) a manual inspection of the file occurred.
- In most cases a manual inspection of the information in the file
resulted in a clear resolution of the license that should apply (and
which scanner probably needed to revisit its heuristics).
- When it was not immediately clear, the license identifier was
confirmed with lawyers working with the Linux Foundation.
- If there was any question as to the appropriate license identifier,
the file was flagged for further research and to be revisited later
in time.
In total, over 70 hours of logged manual review was done on the
spreadsheet to determine the SPDX license identifiers to apply to the
source files by Kate, Philippe, Thomas and, in some cases, confirmation
by lawyers working with the Linux Foundation.
Kate also obtained a third independent scan of the 4.13 code base from
FOSSology, and compared selected files where the other two scanners
disagreed against that SPDX file, to see if there was new insights. The
Windriver scanner is based on an older version of FOSSology in part, so
they are related.
Thomas did random spot checks in about 500 files from the spreadsheets
for the uapi headers and agreed with SPDX license identifier in the
files he inspected. For the non-uapi files Thomas did random spot checks
in about 15000 files.
In initial set of patches against 4.14-rc6, 3 files were found to have
copy/paste license identifier errors, and have been fixed to reflect the
correct identifier.
Additionally Philippe spent 10 hours this week doing a detailed manual
inspection and review of the 12,461 patched files from the initial patch
version early this week with:
- a full scancode scan run, collecting the matched texts, detected
license ids and scores
- reviewing anything where there was a license detected (about 500+
files) to ensure that the applied SPDX license was correct
- reviewing anything where there was no detection but the patch license
was not GPL-2.0 WITH Linux-syscall-note to ensure that the applied
SPDX license was correct
This produced a worksheet with 20 files needing minor correction. This
worksheet was then exported into 3 different .csv files for the
different types of files to be modified.
These .csv files were then reviewed by Greg. Thomas wrote a script to
parse the csv files and add the proper SPDX tag to the file, in the
format that the file expected. This script was further refined by Greg
based on the output to detect more types of files automatically and to
distinguish between header and source .c files (which need different
comment types.) Finally Greg ran the script using the .csv files to
generate the patches.
Reviewed-by: Kate Stewart <kstewart@linuxfoundation.org>
Reviewed-by: Philippe Ombredanne <pombredanne@nexb.com>
Reviewed-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2017-11-01 14:07:57 +00:00
|
|
|
// SPDX-License-Identifier: GPL-2.0
|
2006-03-24 11:15:25 +00:00
|
|
|
/*
|
|
|
|
* Character device driver for extended error reporting.
|
|
|
|
*
|
2012-07-20 09:15:04 +00:00
|
|
|
* Copyright IBM Corp. 2005
|
2006-03-24 11:15:25 +00:00
|
|
|
* extended error reporting for DASD ECKD devices
|
|
|
|
* Author(s): Stefan Weinhuber <wein@de.ibm.com>
|
|
|
|
*/
|
|
|
|
|
2009-09-11 08:28:30 +00:00
|
|
|
#define KMSG_COMPONENT "dasd-eckd"
|
2009-03-26 14:23:49 +00:00
|
|
|
|
2006-03-24 11:15:25 +00:00
|
|
|
#include <linux/init.h>
|
|
|
|
#include <linux/fs.h>
|
|
|
|
#include <linux/kernel.h>
|
|
|
|
#include <linux/miscdevice.h>
|
|
|
|
#include <linux/module.h>
|
|
|
|
#include <linux/moduleparam.h>
|
|
|
|
#include <linux/device.h>
|
|
|
|
#include <linux/poll.h>
|
2007-05-31 15:38:02 +00:00
|
|
|
#include <linux/mutex.h>
|
2008-08-21 17:46:30 +00:00
|
|
|
#include <linux/err.h>
|
include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h
percpu.h is included by sched.h and module.h and thus ends up being
included when building most .c files. percpu.h includes slab.h which
in turn includes gfp.h making everything defined by the two files
universally available and complicating inclusion dependencies.
percpu.h -> slab.h dependency is about to be removed. Prepare for
this change by updating users of gfp and slab facilities include those
headers directly instead of assuming availability. As this conversion
needs to touch large number of source files, the following script is
used as the basis of conversion.
http://userweb.kernel.org/~tj/misc/slabh-sweep.py
The script does the followings.
* Scan files for gfp and slab usages and update includes such that
only the necessary includes are there. ie. if only gfp is used,
gfp.h, if slab is used, slab.h.
* When the script inserts a new include, it looks at the include
blocks and try to put the new include such that its order conforms
to its surrounding. It's put in the include block which contains
core kernel includes, in the same order that the rest are ordered -
alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
doesn't seem to be any matching order.
* If the script can't find a place to put a new include (mostly
because the file doesn't have fitting include block), it prints out
an error message indicating which .h file needs to be added to the
file.
The conversion was done in the following steps.
1. The initial automatic conversion of all .c files updated slightly
over 4000 files, deleting around 700 includes and adding ~480 gfp.h
and ~3000 slab.h inclusions. The script emitted errors for ~400
files.
2. Each error was manually checked. Some didn't need the inclusion,
some needed manual addition while adding it to implementation .h or
embedding .c file was more appropriate for others. This step added
inclusions to around 150 files.
3. The script was run again and the output was compared to the edits
from #2 to make sure no file was left behind.
4. Several build tests were done and a couple of problems were fixed.
e.g. lib/decompress_*.c used malloc/free() wrappers around slab
APIs requiring slab.h to be added manually.
5. The script was run on all .h files but without automatically
editing them as sprinkling gfp.h and slab.h inclusions around .h
files could easily lead to inclusion dependency hell. Most gfp.h
inclusion directives were ignored as stuff from gfp.h was usually
wildly available and often used in preprocessor macros. Each
slab.h inclusion directive was examined and added manually as
necessary.
6. percpu.h was updated not to include slab.h.
7. Build test were done on the following configurations and failures
were fixed. CONFIG_GCOV_KERNEL was turned off for all tests (as my
distributed build env didn't work with gcov compiles) and a few
more options had to be turned off depending on archs to make things
build (like ipr on powerpc/64 which failed due to missing writeq).
* x86 and x86_64 UP and SMP allmodconfig and a custom test config.
* powerpc and powerpc64 SMP allmodconfig
* sparc and sparc64 SMP allmodconfig
* ia64 SMP allmodconfig
* s390 SMP allmodconfig
* alpha SMP allmodconfig
* um on x86_64 SMP allmodconfig
8. percpu.h modifications were reverted so that it could be applied as
a separate patch and serve as bisection point.
Given the fact that I had only a couple of failures from tests on step
6, I'm fairly confident about the coverage of this conversion patch.
If there is a breakage, it's likely to be something in one of the arch
headers which should be easily discoverable easily on most builds of
the specific arch.
Signed-off-by: Tejun Heo <tj@kernel.org>
Guess-its-ok-by: Christoph Lameter <cl@linux-foundation.org>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
2010-03-24 08:04:11 +00:00
|
|
|
#include <linux/slab.h>
|
2006-03-24 11:15:25 +00:00
|
|
|
|
2016-12-24 19:46:01 +00:00
|
|
|
#include <linux/uaccess.h>
|
2011-07-26 23:09:06 +00:00
|
|
|
#include <linux/atomic.h>
|
2006-03-24 11:15:25 +00:00
|
|
|
#include <asm/ebcdic.h>
|
|
|
|
|
|
|
|
#include "dasd_int.h"
|
|
|
|
#include "dasd_eckd.h"
|
|
|
|
|
|
|
|
#ifdef PRINTK_HEADER
|
|
|
|
#undef PRINTK_HEADER
|
|
|
|
#endif /* PRINTK_HEADER */
|
|
|
|
#define PRINTK_HEADER "dasd(eer):"
|
|
|
|
|
|
|
|
/*
|
|
|
|
* SECTION: the internal buffer
|
|
|
|
*/
|
|
|
|
|
|
|
|
/*
|
|
|
|
* The internal buffer is meant to store obaque blobs of data, so it does
|
|
|
|
* not know of higher level concepts like triggers.
|
|
|
|
* It consists of a number of pages that are used as a ringbuffer. Each data
|
|
|
|
* blob is stored in a simple record that consists of an integer, which
|
|
|
|
* contains the size of the following data, and the data bytes themselfes.
|
|
|
|
*
|
|
|
|
* To allow for multiple independent readers we create one internal buffer
|
|
|
|
* each time the device is opened and destroy the buffer when the file is
|
|
|
|
* closed again. The number of pages used for this buffer is determined by
|
|
|
|
* the module parmeter eer_pages.
|
|
|
|
*
|
|
|
|
* One record can be written to a buffer by using the functions
|
|
|
|
* - dasd_eer_start_record (one time per record to write the size to the
|
|
|
|
* buffer and reserve the space for the data)
|
|
|
|
* - dasd_eer_write_buffer (one or more times per record to write the data)
|
|
|
|
* The data can be written in several steps but you will have to compute
|
|
|
|
* the total size up front for the invocation of dasd_eer_start_record.
|
|
|
|
* If the ringbuffer is full, dasd_eer_start_record will remove the required
|
|
|
|
* number of old records.
|
|
|
|
*
|
|
|
|
* A record is typically read in two steps, first read the integer that
|
|
|
|
* specifies the size of the following data, then read the data.
|
|
|
|
* Both can be done by
|
|
|
|
* - dasd_eer_read_buffer
|
|
|
|
*
|
|
|
|
* For all mentioned functions you need to get the bufferlock first and keep
|
|
|
|
* it until a complete record is written or read.
|
|
|
|
*
|
|
|
|
* All information necessary to keep track of an internal buffer is kept in
|
|
|
|
* a struct eerbuffer. The buffer specific to a file pointer is strored in
|
|
|
|
* the private_data field of that file. To be able to write data to all
|
|
|
|
* existing buffers, each buffer is also added to the bufferlist.
|
|
|
|
* If the user does not want to read a complete record in one go, we have to
|
|
|
|
* keep track of the rest of the record. residual stores the number of bytes
|
|
|
|
* that are still to deliver. If the rest of the record is invalidated between
|
|
|
|
* two reads then residual will be set to -1 so that the next read will fail.
|
|
|
|
* All entries in the eerbuffer structure are protected with the bufferlock.
|
|
|
|
* To avoid races between writing to a buffer on the one side and creating
|
|
|
|
* and destroying buffers on the other side, the bufferlock must also be used
|
|
|
|
* to protect the bufferlist.
|
|
|
|
*/
|
|
|
|
|
|
|
|
static int eer_pages = 5;
|
|
|
|
module_param(eer_pages, int, S_IRUGO|S_IWUSR);
|
|
|
|
|
|
|
|
struct eerbuffer {
|
|
|
|
struct list_head list;
|
|
|
|
char **buffer;
|
|
|
|
int buffersize;
|
|
|
|
int buffer_page_count;
|
|
|
|
int head;
|
|
|
|
int tail;
|
|
|
|
int residual;
|
|
|
|
};
|
|
|
|
|
|
|
|
static LIST_HEAD(bufferlist);
|
2006-06-27 09:53:55 +00:00
|
|
|
static DEFINE_SPINLOCK(bufferlock);
|
2006-03-24 11:15:25 +00:00
|
|
|
static DECLARE_WAIT_QUEUE_HEAD(dasd_eer_read_wait_queue);
|
|
|
|
|
|
|
|
/*
|
|
|
|
* How many free bytes are available on the buffer.
|
|
|
|
* Needs to be called with bufferlock held.
|
|
|
|
*/
|
|
|
|
static int dasd_eer_get_free_bytes(struct eerbuffer *eerb)
|
|
|
|
{
|
|
|
|
if (eerb->head < eerb->tail)
|
|
|
|
return eerb->tail - eerb->head - 1;
|
|
|
|
return eerb->buffersize - eerb->head + eerb->tail -1;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* How many bytes of buffer space are used.
|
|
|
|
* Needs to be called with bufferlock held.
|
|
|
|
*/
|
|
|
|
static int dasd_eer_get_filled_bytes(struct eerbuffer *eerb)
|
|
|
|
{
|
|
|
|
|
|
|
|
if (eerb->head >= eerb->tail)
|
|
|
|
return eerb->head - eerb->tail;
|
|
|
|
return eerb->buffersize - eerb->tail + eerb->head;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* The dasd_eer_write_buffer function just copies count bytes of data
|
|
|
|
* to the buffer. Make sure to call dasd_eer_start_record first, to
|
|
|
|
* make sure that enough free space is available.
|
|
|
|
* Needs to be called with bufferlock held.
|
|
|
|
*/
|
|
|
|
static void dasd_eer_write_buffer(struct eerbuffer *eerb,
|
|
|
|
char *data, int count)
|
|
|
|
{
|
|
|
|
|
|
|
|
unsigned long headindex,localhead;
|
|
|
|
unsigned long rest, len;
|
|
|
|
char *nextdata;
|
|
|
|
|
|
|
|
nextdata = data;
|
|
|
|
rest = count;
|
|
|
|
while (rest > 0) {
|
|
|
|
headindex = eerb->head / PAGE_SIZE;
|
|
|
|
localhead = eerb->head % PAGE_SIZE;
|
|
|
|
len = min(rest, PAGE_SIZE - localhead);
|
|
|
|
memcpy(eerb->buffer[headindex]+localhead, nextdata, len);
|
|
|
|
nextdata += len;
|
|
|
|
rest -= len;
|
|
|
|
eerb->head += len;
|
|
|
|
if (eerb->head == eerb->buffersize)
|
|
|
|
eerb->head = 0; /* wrap around */
|
|
|
|
BUG_ON(eerb->head > eerb->buffersize);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Needs to be called with bufferlock held.
|
|
|
|
*/
|
|
|
|
static int dasd_eer_read_buffer(struct eerbuffer *eerb, char *data, int count)
|
|
|
|
{
|
|
|
|
|
|
|
|
unsigned long tailindex,localtail;
|
|
|
|
unsigned long rest, len, finalcount;
|
|
|
|
char *nextdata;
|
|
|
|
|
|
|
|
finalcount = min(count, dasd_eer_get_filled_bytes(eerb));
|
|
|
|
nextdata = data;
|
|
|
|
rest = finalcount;
|
|
|
|
while (rest > 0) {
|
|
|
|
tailindex = eerb->tail / PAGE_SIZE;
|
|
|
|
localtail = eerb->tail % PAGE_SIZE;
|
|
|
|
len = min(rest, PAGE_SIZE - localtail);
|
|
|
|
memcpy(nextdata, eerb->buffer[tailindex] + localtail, len);
|
|
|
|
nextdata += len;
|
|
|
|
rest -= len;
|
|
|
|
eerb->tail += len;
|
|
|
|
if (eerb->tail == eerb->buffersize)
|
|
|
|
eerb->tail = 0; /* wrap around */
|
|
|
|
BUG_ON(eerb->tail > eerb->buffersize);
|
|
|
|
}
|
|
|
|
return finalcount;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Whenever you want to write a blob of data to the internal buffer you
|
|
|
|
* have to start by using this function first. It will write the number
|
|
|
|
* of bytes that will be written to the buffer. If necessary it will remove
|
|
|
|
* old records to make room for the new one.
|
|
|
|
* Needs to be called with bufferlock held.
|
|
|
|
*/
|
|
|
|
static int dasd_eer_start_record(struct eerbuffer *eerb, int count)
|
|
|
|
{
|
|
|
|
int tailcount;
|
|
|
|
|
|
|
|
if (count + sizeof(count) > eerb->buffersize)
|
|
|
|
return -ENOMEM;
|
|
|
|
while (dasd_eer_get_free_bytes(eerb) < count + sizeof(count)) {
|
|
|
|
if (eerb->residual > 0) {
|
|
|
|
eerb->tail += eerb->residual;
|
|
|
|
if (eerb->tail >= eerb->buffersize)
|
|
|
|
eerb->tail -= eerb->buffersize;
|
|
|
|
eerb->residual = -1;
|
|
|
|
}
|
|
|
|
dasd_eer_read_buffer(eerb, (char *) &tailcount,
|
|
|
|
sizeof(tailcount));
|
|
|
|
eerb->tail += tailcount;
|
|
|
|
if (eerb->tail >= eerb->buffersize)
|
|
|
|
eerb->tail -= eerb->buffersize;
|
|
|
|
}
|
|
|
|
dasd_eer_write_buffer(eerb, (char*) &count, sizeof(count));
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
};
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Release pages that are not used anymore.
|
|
|
|
*/
|
|
|
|
static void dasd_eer_free_buffer_pages(char **buf, int no_pages)
|
|
|
|
{
|
|
|
|
int i;
|
|
|
|
|
|
|
|
for (i = 0; i < no_pages; i++)
|
|
|
|
free_page((unsigned long) buf[i]);
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Allocate a new set of memory pages.
|
|
|
|
*/
|
|
|
|
static int dasd_eer_allocate_buffer_pages(char **buf, int no_pages)
|
|
|
|
{
|
|
|
|
int i;
|
|
|
|
|
|
|
|
for (i = 0; i < no_pages; i++) {
|
|
|
|
buf[i] = (char *) get_zeroed_page(GFP_KERNEL);
|
|
|
|
if (!buf[i]) {
|
|
|
|
dasd_eer_free_buffer_pages(buf, i);
|
|
|
|
return -ENOMEM;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* SECTION: The extended error reporting functionality
|
|
|
|
*/
|
|
|
|
|
|
|
|
/*
|
|
|
|
* When a DASD device driver wants to report an error, it calls the
|
|
|
|
* function dasd_eer_write and gives the respective trigger ID as
|
|
|
|
* parameter. Currently there are four kinds of triggers:
|
|
|
|
*
|
|
|
|
* DASD_EER_FATALERROR: all kinds of unrecoverable I/O problems
|
|
|
|
* DASD_EER_PPRCSUSPEND: PPRC was suspended
|
|
|
|
* DASD_EER_NOPATH: There is no path to the device left.
|
|
|
|
* DASD_EER_STATECHANGE: The state of the device has changed.
|
|
|
|
*
|
|
|
|
* For the first three triggers all required information can be supplied by
|
|
|
|
* the caller. For these triggers a record is written by the function
|
|
|
|
* dasd_eer_write_standard_trigger.
|
|
|
|
*
|
|
|
|
* The DASD_EER_STATECHANGE trigger is special since a sense subsystem
|
|
|
|
* status ccw need to be executed to gather the necessary sense data first.
|
|
|
|
* The dasd_eer_snss function will queue the SNSS request and the request
|
|
|
|
* callback will then call dasd_eer_write with the DASD_EER_STATCHANGE
|
|
|
|
* trigger.
|
|
|
|
*
|
|
|
|
* To avoid memory allocations at runtime, the necessary memory is allocated
|
|
|
|
* when the extended error reporting is enabled for a device (by
|
|
|
|
* dasd_eer_probe). There is one sense subsystem status request for each
|
|
|
|
* eer enabled DASD device. The presence of the cqr in device->eer_cqr
|
|
|
|
* indicates that eer is enable for the device. The use of the snss request
|
|
|
|
* is protected by the DASD_FLAG_EER_IN_USE bit. When this flag indicates
|
|
|
|
* that the cqr is currently in use, dasd_eer_snss cannot start a second
|
|
|
|
* request but sets the DASD_FLAG_EER_SNSS flag instead. The callback of
|
|
|
|
* the SNSS request will check the bit and call dasd_eer_snss again.
|
|
|
|
*/
|
|
|
|
|
|
|
|
#define SNSS_DATA_SIZE 44
|
|
|
|
|
|
|
|
#define DASD_EER_BUSID_SIZE 10
|
|
|
|
struct dasd_eer_header {
|
|
|
|
__u32 total_size;
|
|
|
|
__u32 trigger;
|
|
|
|
__u64 tv_sec;
|
|
|
|
__u64 tv_usec;
|
|
|
|
char busid[DASD_EER_BUSID_SIZE];
|
2006-06-29 13:02:59 +00:00
|
|
|
} __attribute__ ((packed));
|
2006-03-24 11:15:25 +00:00
|
|
|
|
|
|
|
/*
|
|
|
|
* The following function can be used for those triggers that have
|
|
|
|
* all necessary data available when the function is called.
|
|
|
|
* If the parameter cqr is not NULL, the chain of requests will be searched
|
|
|
|
* for valid sense data, and all valid sense data sets will be added to
|
|
|
|
* the triggers data.
|
|
|
|
*/
|
|
|
|
static void dasd_eer_write_standard_trigger(struct dasd_device *device,
|
|
|
|
struct dasd_ccw_req *cqr,
|
|
|
|
int trigger)
|
|
|
|
{
|
|
|
|
struct dasd_ccw_req *temp_cqr;
|
|
|
|
int data_size;
|
2017-11-06 14:02:41 +00:00
|
|
|
struct timespec64 ts;
|
2006-03-24 11:15:25 +00:00
|
|
|
struct dasd_eer_header header;
|
|
|
|
unsigned long flags;
|
|
|
|
struct eerbuffer *eerb;
|
2009-03-26 14:23:48 +00:00
|
|
|
char *sense;
|
2006-03-24 11:15:25 +00:00
|
|
|
|
|
|
|
/* go through cqr chain and count the valid sense data sets */
|
|
|
|
data_size = 0;
|
|
|
|
for (temp_cqr = cqr; temp_cqr; temp_cqr = temp_cqr->refers)
|
2009-03-26 14:23:48 +00:00
|
|
|
if (dasd_get_sense(&temp_cqr->irb))
|
2006-03-24 11:15:25 +00:00
|
|
|
data_size += 32;
|
|
|
|
|
|
|
|
header.total_size = sizeof(header) + data_size + 4; /* "EOR" */
|
|
|
|
header.trigger = trigger;
|
2017-11-06 14:02:41 +00:00
|
|
|
ktime_get_real_ts64(&ts);
|
|
|
|
header.tv_sec = ts.tv_sec;
|
|
|
|
header.tv_usec = ts.tv_nsec / NSEC_PER_USEC;
|
s390/dasd,zfcp: fix gcc 8 stringop-truncation warnings
ccw "busid" should always be NUL-terminated, as evident from e.g.
get_ccwdev_by_busid doing "return (strcmp(bus_id, dev_name(dev)) == 0)".
Replace all strncpy initializing busid with strlcpy. This fixes the
following gcc 8 warnings:
drivers/s390/scsi/zfcp_aux.c:104:2: warning: 'strncpy' specified bound 20
equals destination size [-Wstringop-truncation]
strncpy(busid, token, ZFCP_BUS_ID_SIZE);
drivers/s390/block/dasd_eer.c:316:2: warning: 'strncpy' specified bound 10
equals destination size [-Wstringop-truncation]
strncpy(header.busid, dev_name(&device->cdev->dev), DASD_EER_BUSID_SIZE);
drivers/s390/block/dasd_eer.c:359:2: warning: 'strncpy' specified bound 10
equals destination size [-Wstringop-truncation]
strncpy(header.busid, dev_name(&device->cdev->dev), DASD_EER_BUSID_SIZE);
drivers/s390/block/dasd_devmap.c:429:3: warning: 'strncpy' specified bound
20 equals destination size [-Wstringop-truncation]
strncpy(new->bus_id, bus_id, DASD_BUS_ID_SIZE);
Acked-by: Stefan Haberland <sth@linux.ibm.com>
Acked-by: Steffen Maier <maier@linux.ibm.com>
Reviewed-by: Heiko Carstens <heiko.carstens@de.ibm.com>
Signed-off-by: Vasily Gorbik <gor@linux.ibm.com>
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
2018-06-17 09:56:17 +00:00
|
|
|
strlcpy(header.busid, dev_name(&device->cdev->dev),
|
2008-10-10 19:33:09 +00:00
|
|
|
DASD_EER_BUSID_SIZE);
|
2006-03-24 11:15:25 +00:00
|
|
|
|
|
|
|
spin_lock_irqsave(&bufferlock, flags);
|
|
|
|
list_for_each_entry(eerb, &bufferlist, list) {
|
|
|
|
dasd_eer_start_record(eerb, header.total_size);
|
|
|
|
dasd_eer_write_buffer(eerb, (char *) &header, sizeof(header));
|
2009-03-26 14:23:48 +00:00
|
|
|
for (temp_cqr = cqr; temp_cqr; temp_cqr = temp_cqr->refers) {
|
|
|
|
sense = dasd_get_sense(&temp_cqr->irb);
|
|
|
|
if (sense)
|
|
|
|
dasd_eer_write_buffer(eerb, sense, 32);
|
|
|
|
}
|
2006-03-24 11:15:25 +00:00
|
|
|
dasd_eer_write_buffer(eerb, "EOR", 4);
|
|
|
|
}
|
|
|
|
spin_unlock_irqrestore(&bufferlock, flags);
|
|
|
|
wake_up_interruptible(&dasd_eer_read_wait_queue);
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* This function writes a DASD_EER_STATECHANGE trigger.
|
|
|
|
*/
|
|
|
|
static void dasd_eer_write_snss_trigger(struct dasd_device *device,
|
|
|
|
struct dasd_ccw_req *cqr,
|
|
|
|
int trigger)
|
|
|
|
{
|
|
|
|
int data_size;
|
|
|
|
int snss_rc;
|
2017-11-06 14:02:41 +00:00
|
|
|
struct timespec64 ts;
|
2006-03-24 11:15:25 +00:00
|
|
|
struct dasd_eer_header header;
|
|
|
|
unsigned long flags;
|
|
|
|
struct eerbuffer *eerb;
|
|
|
|
|
2008-01-26 13:11:23 +00:00
|
|
|
snss_rc = (cqr->status == DASD_CQR_DONE) ? 0 : -EIO;
|
2006-03-24 11:15:25 +00:00
|
|
|
if (snss_rc)
|
|
|
|
data_size = 0;
|
|
|
|
else
|
|
|
|
data_size = SNSS_DATA_SIZE;
|
|
|
|
|
|
|
|
header.total_size = sizeof(header) + data_size + 4; /* "EOR" */
|
|
|
|
header.trigger = DASD_EER_STATECHANGE;
|
2017-11-06 14:02:41 +00:00
|
|
|
ktime_get_real_ts64(&ts);
|
|
|
|
header.tv_sec = ts.tv_sec;
|
|
|
|
header.tv_usec = ts.tv_nsec / NSEC_PER_USEC;
|
s390/dasd,zfcp: fix gcc 8 stringop-truncation warnings
ccw "busid" should always be NUL-terminated, as evident from e.g.
get_ccwdev_by_busid doing "return (strcmp(bus_id, dev_name(dev)) == 0)".
Replace all strncpy initializing busid with strlcpy. This fixes the
following gcc 8 warnings:
drivers/s390/scsi/zfcp_aux.c:104:2: warning: 'strncpy' specified bound 20
equals destination size [-Wstringop-truncation]
strncpy(busid, token, ZFCP_BUS_ID_SIZE);
drivers/s390/block/dasd_eer.c:316:2: warning: 'strncpy' specified bound 10
equals destination size [-Wstringop-truncation]
strncpy(header.busid, dev_name(&device->cdev->dev), DASD_EER_BUSID_SIZE);
drivers/s390/block/dasd_eer.c:359:2: warning: 'strncpy' specified bound 10
equals destination size [-Wstringop-truncation]
strncpy(header.busid, dev_name(&device->cdev->dev), DASD_EER_BUSID_SIZE);
drivers/s390/block/dasd_devmap.c:429:3: warning: 'strncpy' specified bound
20 equals destination size [-Wstringop-truncation]
strncpy(new->bus_id, bus_id, DASD_BUS_ID_SIZE);
Acked-by: Stefan Haberland <sth@linux.ibm.com>
Acked-by: Steffen Maier <maier@linux.ibm.com>
Reviewed-by: Heiko Carstens <heiko.carstens@de.ibm.com>
Signed-off-by: Vasily Gorbik <gor@linux.ibm.com>
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
2018-06-17 09:56:17 +00:00
|
|
|
strlcpy(header.busid, dev_name(&device->cdev->dev),
|
2008-10-10 19:33:09 +00:00
|
|
|
DASD_EER_BUSID_SIZE);
|
2006-03-24 11:15:25 +00:00
|
|
|
|
|
|
|
spin_lock_irqsave(&bufferlock, flags);
|
|
|
|
list_for_each_entry(eerb, &bufferlist, list) {
|
|
|
|
dasd_eer_start_record(eerb, header.total_size);
|
|
|
|
dasd_eer_write_buffer(eerb, (char *) &header , sizeof(header));
|
|
|
|
if (!snss_rc)
|
|
|
|
dasd_eer_write_buffer(eerb, cqr->data, SNSS_DATA_SIZE);
|
|
|
|
dasd_eer_write_buffer(eerb, "EOR", 4);
|
|
|
|
}
|
|
|
|
spin_unlock_irqrestore(&bufferlock, flags);
|
|
|
|
wake_up_interruptible(&dasd_eer_read_wait_queue);
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* This function is called for all triggers. It calls the appropriate
|
|
|
|
* function that writes the actual trigger records.
|
|
|
|
*/
|
|
|
|
void dasd_eer_write(struct dasd_device *device, struct dasd_ccw_req *cqr,
|
|
|
|
unsigned int id)
|
|
|
|
{
|
|
|
|
if (!device->eer_cqr)
|
|
|
|
return;
|
|
|
|
switch (id) {
|
|
|
|
case DASD_EER_FATALERROR:
|
|
|
|
case DASD_EER_PPRCSUSPEND:
|
|
|
|
dasd_eer_write_standard_trigger(device, cqr, id);
|
|
|
|
break;
|
|
|
|
case DASD_EER_NOPATH:
|
|
|
|
dasd_eer_write_standard_trigger(device, NULL, id);
|
|
|
|
break;
|
|
|
|
case DASD_EER_STATECHANGE:
|
|
|
|
dasd_eer_write_snss_trigger(device, cqr, id);
|
|
|
|
break;
|
|
|
|
default: /* unknown trigger, so we write it without any sense data */
|
|
|
|
dasd_eer_write_standard_trigger(device, NULL, id);
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
EXPORT_SYMBOL(dasd_eer_write);
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Start a sense subsystem status request.
|
|
|
|
* Needs to be called with the device held.
|
|
|
|
*/
|
|
|
|
void dasd_eer_snss(struct dasd_device *device)
|
|
|
|
{
|
|
|
|
struct dasd_ccw_req *cqr;
|
|
|
|
|
|
|
|
cqr = device->eer_cqr;
|
|
|
|
if (!cqr) /* Device not eer enabled. */
|
|
|
|
return;
|
|
|
|
if (test_and_set_bit(DASD_FLAG_EER_IN_USE, &device->flags)) {
|
|
|
|
/* Sense subsystem status request in use. */
|
|
|
|
set_bit(DASD_FLAG_EER_SNSS, &device->flags);
|
|
|
|
return;
|
|
|
|
}
|
2008-01-26 13:11:23 +00:00
|
|
|
/* cdev is already locked, can't use dasd_add_request_head */
|
2006-03-24 11:15:25 +00:00
|
|
|
clear_bit(DASD_FLAG_EER_SNSS, &device->flags);
|
|
|
|
cqr->status = DASD_CQR_QUEUED;
|
2008-01-26 13:11:23 +00:00
|
|
|
list_add(&cqr->devlist, &device->ccw_queue);
|
|
|
|
dasd_schedule_device_bh(device);
|
2006-03-24 11:15:25 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Callback function for use with sense subsystem status request.
|
|
|
|
*/
|
|
|
|
static void dasd_eer_snss_cb(struct dasd_ccw_req *cqr, void *data)
|
|
|
|
{
|
2008-01-26 13:11:23 +00:00
|
|
|
struct dasd_device *device = cqr->startdev;
|
2006-03-24 11:15:25 +00:00
|
|
|
unsigned long flags;
|
|
|
|
|
|
|
|
dasd_eer_write(device, cqr, DASD_EER_STATECHANGE);
|
|
|
|
spin_lock_irqsave(get_ccwdev_lock(device->cdev), flags);
|
|
|
|
if (device->eer_cqr == cqr) {
|
|
|
|
clear_bit(DASD_FLAG_EER_IN_USE, &device->flags);
|
|
|
|
if (test_bit(DASD_FLAG_EER_SNSS, &device->flags))
|
|
|
|
/* Another SNSS has been requested in the meantime. */
|
|
|
|
dasd_eer_snss(device);
|
|
|
|
cqr = NULL;
|
|
|
|
}
|
|
|
|
spin_unlock_irqrestore(get_ccwdev_lock(device->cdev), flags);
|
|
|
|
if (cqr)
|
|
|
|
/*
|
|
|
|
* Extended error recovery has been switched off while
|
|
|
|
* the SNSS request was running. It could even have
|
|
|
|
* been switched off and on again in which case there
|
|
|
|
* is a new ccw in device->eer_cqr. Free the "old"
|
|
|
|
* snss request now.
|
|
|
|
*/
|
2018-06-04 17:18:03 +00:00
|
|
|
dasd_sfree_request(cqr, device);
|
2006-03-24 11:15:25 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Enable error reporting on a given device.
|
|
|
|
*/
|
|
|
|
int dasd_eer_enable(struct dasd_device *device)
|
|
|
|
{
|
2016-10-12 10:51:04 +00:00
|
|
|
struct dasd_ccw_req *cqr = NULL;
|
2006-03-24 11:15:25 +00:00
|
|
|
unsigned long flags;
|
2009-03-26 14:23:48 +00:00
|
|
|
struct ccw1 *ccw;
|
2016-10-12 10:51:04 +00:00
|
|
|
int rc = 0;
|
2006-03-24 11:15:25 +00:00
|
|
|
|
2016-10-12 10:51:04 +00:00
|
|
|
spin_lock_irqsave(get_ccwdev_lock(device->cdev), flags);
|
2006-03-24 11:15:25 +00:00
|
|
|
if (device->eer_cqr)
|
2016-10-12 10:51:04 +00:00
|
|
|
goto out;
|
|
|
|
else if (!device->discipline ||
|
|
|
|
strcmp(device->discipline->name, "ECKD"))
|
|
|
|
rc = -EMEDIUMTYPE;
|
|
|
|
else if (test_bit(DASD_FLAG_OFFLINE, &device->flags))
|
|
|
|
rc = -EBUSY;
|
2006-03-24 11:15:25 +00:00
|
|
|
|
2016-10-12 10:51:04 +00:00
|
|
|
if (rc)
|
|
|
|
goto out;
|
2006-03-24 11:15:25 +00:00
|
|
|
|
2018-06-04 17:18:03 +00:00
|
|
|
cqr = dasd_smalloc_request(DASD_ECKD_MAGIC, 1 /* SNSS */,
|
|
|
|
SNSS_DATA_SIZE, device, NULL);
|
2016-10-12 10:51:04 +00:00
|
|
|
if (IS_ERR(cqr)) {
|
|
|
|
rc = -ENOMEM;
|
|
|
|
cqr = NULL;
|
|
|
|
goto out;
|
|
|
|
}
|
2006-03-24 11:15:25 +00:00
|
|
|
|
2008-01-26 13:11:23 +00:00
|
|
|
cqr->startdev = device;
|
2006-03-24 11:15:25 +00:00
|
|
|
cqr->retries = 255;
|
|
|
|
cqr->expires = 10 * HZ;
|
2007-03-05 22:35:52 +00:00
|
|
|
clear_bit(DASD_CQR_FLAGS_USE_ERP, &cqr->flags);
|
2011-01-05 11:48:04 +00:00
|
|
|
set_bit(DASD_CQR_ALLOW_SLOCK, &cqr->flags);
|
2006-03-24 11:15:25 +00:00
|
|
|
|
2009-03-26 14:23:48 +00:00
|
|
|
ccw = cqr->cpaddr;
|
|
|
|
ccw->cmd_code = DASD_ECKD_CCW_SNSS;
|
|
|
|
ccw->count = SNSS_DATA_SIZE;
|
|
|
|
ccw->flags = 0;
|
|
|
|
ccw->cda = (__u32)(addr_t) cqr->data;
|
2006-03-24 11:15:25 +00:00
|
|
|
|
2013-01-30 08:49:40 +00:00
|
|
|
cqr->buildclk = get_tod_clock();
|
2006-03-24 11:15:25 +00:00
|
|
|
cqr->status = DASD_CQR_FILLED;
|
|
|
|
cqr->callback = dasd_eer_snss_cb;
|
|
|
|
|
|
|
|
if (!device->eer_cqr) {
|
|
|
|
device->eer_cqr = cqr;
|
|
|
|
cqr = NULL;
|
|
|
|
}
|
2016-10-12 10:51:04 +00:00
|
|
|
|
|
|
|
out:
|
2006-03-24 11:15:25 +00:00
|
|
|
spin_unlock_irqrestore(get_ccwdev_lock(device->cdev), flags);
|
2016-10-12 10:51:04 +00:00
|
|
|
|
2006-03-24 11:15:25 +00:00
|
|
|
if (cqr)
|
2018-06-04 17:18:03 +00:00
|
|
|
dasd_sfree_request(cqr, device);
|
2016-10-12 10:51:04 +00:00
|
|
|
|
|
|
|
return rc;
|
2006-03-24 11:15:25 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Disable error reporting on a given device.
|
|
|
|
*/
|
|
|
|
void dasd_eer_disable(struct dasd_device *device)
|
|
|
|
{
|
|
|
|
struct dasd_ccw_req *cqr;
|
|
|
|
unsigned long flags;
|
|
|
|
int in_use;
|
|
|
|
|
|
|
|
if (!device->eer_cqr)
|
|
|
|
return;
|
|
|
|
spin_lock_irqsave(get_ccwdev_lock(device->cdev), flags);
|
|
|
|
cqr = device->eer_cqr;
|
|
|
|
device->eer_cqr = NULL;
|
|
|
|
clear_bit(DASD_FLAG_EER_SNSS, &device->flags);
|
|
|
|
in_use = test_and_clear_bit(DASD_FLAG_EER_IN_USE, &device->flags);
|
|
|
|
spin_unlock_irqrestore(get_ccwdev_lock(device->cdev), flags);
|
|
|
|
if (cqr && !in_use)
|
2018-06-04 17:18:03 +00:00
|
|
|
dasd_sfree_request(cqr, device);
|
2006-03-24 11:15:25 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* SECTION: the device operations
|
|
|
|
*/
|
|
|
|
|
|
|
|
/*
|
|
|
|
* On the one side we need a lock to access our internal buffer, on the
|
|
|
|
* other side a copy_to_user can sleep. So we need to copy the data we have
|
|
|
|
* to transfer in a readbuffer, which is protected by the readbuffer_mutex.
|
|
|
|
*/
|
|
|
|
static char readbuffer[PAGE_SIZE];
|
2007-05-31 15:38:02 +00:00
|
|
|
static DEFINE_MUTEX(readbuffer_mutex);
|
2006-03-24 11:15:25 +00:00
|
|
|
|
|
|
|
static int dasd_eer_open(struct inode *inp, struct file *filp)
|
|
|
|
{
|
|
|
|
struct eerbuffer *eerb;
|
|
|
|
unsigned long flags;
|
|
|
|
|
|
|
|
eerb = kzalloc(sizeof(struct eerbuffer), GFP_KERNEL);
|
2006-06-29 12:57:46 +00:00
|
|
|
if (!eerb)
|
|
|
|
return -ENOMEM;
|
2006-03-24 11:15:25 +00:00
|
|
|
eerb->buffer_page_count = eer_pages;
|
|
|
|
if (eerb->buffer_page_count < 1 ||
|
|
|
|
eerb->buffer_page_count > INT_MAX / PAGE_SIZE) {
|
|
|
|
kfree(eerb);
|
2009-03-26 14:23:49 +00:00
|
|
|
DBF_EVENT(DBF_WARNING, "can't open device since module "
|
2008-10-16 17:02:37 +00:00
|
|
|
"parameter eer_pages is smaller than 1 or"
|
|
|
|
" bigger than %d", (int)(INT_MAX / PAGE_SIZE));
|
2006-03-24 11:15:25 +00:00
|
|
|
return -EINVAL;
|
|
|
|
}
|
|
|
|
eerb->buffersize = eerb->buffer_page_count * PAGE_SIZE;
|
treewide: kmalloc() -> kmalloc_array()
The kmalloc() function has a 2-factor argument form, kmalloc_array(). This
patch replaces cases of:
kmalloc(a * b, gfp)
with:
kmalloc_array(a * b, gfp)
as well as handling cases of:
kmalloc(a * b * c, gfp)
with:
kmalloc(array3_size(a, b, c), gfp)
as it's slightly less ugly than:
kmalloc_array(array_size(a, b), c, gfp)
This does, however, attempt to ignore constant size factors like:
kmalloc(4 * 1024, gfp)
though any constants defined via macros get caught up in the conversion.
Any factors with a sizeof() of "unsigned char", "char", and "u8" were
dropped, since they're redundant.
The tools/ directory was manually excluded, since it has its own
implementation of kmalloc().
The Coccinelle script used for this was:
// Fix redundant parens around sizeof().
@@
type TYPE;
expression THING, E;
@@
(
kmalloc(
- (sizeof(TYPE)) * E
+ sizeof(TYPE) * E
, ...)
|
kmalloc(
- (sizeof(THING)) * E
+ sizeof(THING) * E
, ...)
)
// Drop single-byte sizes and redundant parens.
@@
expression COUNT;
typedef u8;
typedef __u8;
@@
(
kmalloc(
- sizeof(u8) * (COUNT)
+ COUNT
, ...)
|
kmalloc(
- sizeof(__u8) * (COUNT)
+ COUNT
, ...)
|
kmalloc(
- sizeof(char) * (COUNT)
+ COUNT
, ...)
|
kmalloc(
- sizeof(unsigned char) * (COUNT)
+ COUNT
, ...)
|
kmalloc(
- sizeof(u8) * COUNT
+ COUNT
, ...)
|
kmalloc(
- sizeof(__u8) * COUNT
+ COUNT
, ...)
|
kmalloc(
- sizeof(char) * COUNT
+ COUNT
, ...)
|
kmalloc(
- sizeof(unsigned char) * COUNT
+ COUNT
, ...)
)
// 2-factor product with sizeof(type/expression) and identifier or constant.
@@
type TYPE;
expression THING;
identifier COUNT_ID;
constant COUNT_CONST;
@@
(
- kmalloc
+ kmalloc_array
(
- sizeof(TYPE) * (COUNT_ID)
+ COUNT_ID, sizeof(TYPE)
, ...)
|
- kmalloc
+ kmalloc_array
(
- sizeof(TYPE) * COUNT_ID
+ COUNT_ID, sizeof(TYPE)
, ...)
|
- kmalloc
+ kmalloc_array
(
- sizeof(TYPE) * (COUNT_CONST)
+ COUNT_CONST, sizeof(TYPE)
, ...)
|
- kmalloc
+ kmalloc_array
(
- sizeof(TYPE) * COUNT_CONST
+ COUNT_CONST, sizeof(TYPE)
, ...)
|
- kmalloc
+ kmalloc_array
(
- sizeof(THING) * (COUNT_ID)
+ COUNT_ID, sizeof(THING)
, ...)
|
- kmalloc
+ kmalloc_array
(
- sizeof(THING) * COUNT_ID
+ COUNT_ID, sizeof(THING)
, ...)
|
- kmalloc
+ kmalloc_array
(
- sizeof(THING) * (COUNT_CONST)
+ COUNT_CONST, sizeof(THING)
, ...)
|
- kmalloc
+ kmalloc_array
(
- sizeof(THING) * COUNT_CONST
+ COUNT_CONST, sizeof(THING)
, ...)
)
// 2-factor product, only identifiers.
@@
identifier SIZE, COUNT;
@@
- kmalloc
+ kmalloc_array
(
- SIZE * COUNT
+ COUNT, SIZE
, ...)
// 3-factor product with 1 sizeof(type) or sizeof(expression), with
// redundant parens removed.
@@
expression THING;
identifier STRIDE, COUNT;
type TYPE;
@@
(
kmalloc(
- sizeof(TYPE) * (COUNT) * (STRIDE)
+ array3_size(COUNT, STRIDE, sizeof(TYPE))
, ...)
|
kmalloc(
- sizeof(TYPE) * (COUNT) * STRIDE
+ array3_size(COUNT, STRIDE, sizeof(TYPE))
, ...)
|
kmalloc(
- sizeof(TYPE) * COUNT * (STRIDE)
+ array3_size(COUNT, STRIDE, sizeof(TYPE))
, ...)
|
kmalloc(
- sizeof(TYPE) * COUNT * STRIDE
+ array3_size(COUNT, STRIDE, sizeof(TYPE))
, ...)
|
kmalloc(
- sizeof(THING) * (COUNT) * (STRIDE)
+ array3_size(COUNT, STRIDE, sizeof(THING))
, ...)
|
kmalloc(
- sizeof(THING) * (COUNT) * STRIDE
+ array3_size(COUNT, STRIDE, sizeof(THING))
, ...)
|
kmalloc(
- sizeof(THING) * COUNT * (STRIDE)
+ array3_size(COUNT, STRIDE, sizeof(THING))
, ...)
|
kmalloc(
- sizeof(THING) * COUNT * STRIDE
+ array3_size(COUNT, STRIDE, sizeof(THING))
, ...)
)
// 3-factor product with 2 sizeof(variable), with redundant parens removed.
@@
expression THING1, THING2;
identifier COUNT;
type TYPE1, TYPE2;
@@
(
kmalloc(
- sizeof(TYPE1) * sizeof(TYPE2) * COUNT
+ array3_size(COUNT, sizeof(TYPE1), sizeof(TYPE2))
, ...)
|
kmalloc(
- sizeof(TYPE1) * sizeof(THING2) * (COUNT)
+ array3_size(COUNT, sizeof(TYPE1), sizeof(TYPE2))
, ...)
|
kmalloc(
- sizeof(THING1) * sizeof(THING2) * COUNT
+ array3_size(COUNT, sizeof(THING1), sizeof(THING2))
, ...)
|
kmalloc(
- sizeof(THING1) * sizeof(THING2) * (COUNT)
+ array3_size(COUNT, sizeof(THING1), sizeof(THING2))
, ...)
|
kmalloc(
- sizeof(TYPE1) * sizeof(THING2) * COUNT
+ array3_size(COUNT, sizeof(TYPE1), sizeof(THING2))
, ...)
|
kmalloc(
- sizeof(TYPE1) * sizeof(THING2) * (COUNT)
+ array3_size(COUNT, sizeof(TYPE1), sizeof(THING2))
, ...)
)
// 3-factor product, only identifiers, with redundant parens removed.
@@
identifier STRIDE, SIZE, COUNT;
@@
(
kmalloc(
- (COUNT) * STRIDE * SIZE
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
kmalloc(
- COUNT * (STRIDE) * SIZE
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
kmalloc(
- COUNT * STRIDE * (SIZE)
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
kmalloc(
- (COUNT) * (STRIDE) * SIZE
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
kmalloc(
- COUNT * (STRIDE) * (SIZE)
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
kmalloc(
- (COUNT) * STRIDE * (SIZE)
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
kmalloc(
- (COUNT) * (STRIDE) * (SIZE)
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
kmalloc(
- COUNT * STRIDE * SIZE
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
)
// Any remaining multi-factor products, first at least 3-factor products,
// when they're not all constants...
@@
expression E1, E2, E3;
constant C1, C2, C3;
@@
(
kmalloc(C1 * C2 * C3, ...)
|
kmalloc(
- (E1) * E2 * E3
+ array3_size(E1, E2, E3)
, ...)
|
kmalloc(
- (E1) * (E2) * E3
+ array3_size(E1, E2, E3)
, ...)
|
kmalloc(
- (E1) * (E2) * (E3)
+ array3_size(E1, E2, E3)
, ...)
|
kmalloc(
- E1 * E2 * E3
+ array3_size(E1, E2, E3)
, ...)
)
// And then all remaining 2 factors products when they're not all constants,
// keeping sizeof() as the second factor argument.
@@
expression THING, E1, E2;
type TYPE;
constant C1, C2, C3;
@@
(
kmalloc(sizeof(THING) * C2, ...)
|
kmalloc(sizeof(TYPE) * C2, ...)
|
kmalloc(C1 * C2 * C3, ...)
|
kmalloc(C1 * C2, ...)
|
- kmalloc
+ kmalloc_array
(
- sizeof(TYPE) * (E2)
+ E2, sizeof(TYPE)
, ...)
|
- kmalloc
+ kmalloc_array
(
- sizeof(TYPE) * E2
+ E2, sizeof(TYPE)
, ...)
|
- kmalloc
+ kmalloc_array
(
- sizeof(THING) * (E2)
+ E2, sizeof(THING)
, ...)
|
- kmalloc
+ kmalloc_array
(
- sizeof(THING) * E2
+ E2, sizeof(THING)
, ...)
|
- kmalloc
+ kmalloc_array
(
- (E1) * E2
+ E1, E2
, ...)
|
- kmalloc
+ kmalloc_array
(
- (E1) * (E2)
+ E1, E2
, ...)
|
- kmalloc
+ kmalloc_array
(
- E1 * E2
+ E1, E2
, ...)
)
Signed-off-by: Kees Cook <keescook@chromium.org>
2018-06-12 20:55:00 +00:00
|
|
|
eerb->buffer = kmalloc_array(eerb->buffer_page_count, sizeof(char *),
|
|
|
|
GFP_KERNEL);
|
2006-03-24 11:15:25 +00:00
|
|
|
if (!eerb->buffer) {
|
|
|
|
kfree(eerb);
|
|
|
|
return -ENOMEM;
|
|
|
|
}
|
|
|
|
if (dasd_eer_allocate_buffer_pages(eerb->buffer,
|
|
|
|
eerb->buffer_page_count)) {
|
|
|
|
kfree(eerb->buffer);
|
|
|
|
kfree(eerb);
|
|
|
|
return -ENOMEM;
|
|
|
|
}
|
|
|
|
filp->private_data = eerb;
|
|
|
|
spin_lock_irqsave(&bufferlock, flags);
|
|
|
|
list_add(&eerb->list, &bufferlist);
|
|
|
|
spin_unlock_irqrestore(&bufferlock, flags);
|
|
|
|
|
|
|
|
return nonseekable_open(inp,filp);
|
|
|
|
}
|
|
|
|
|
|
|
|
static int dasd_eer_close(struct inode *inp, struct file *filp)
|
|
|
|
{
|
|
|
|
struct eerbuffer *eerb;
|
|
|
|
unsigned long flags;
|
|
|
|
|
|
|
|
eerb = (struct eerbuffer *) filp->private_data;
|
|
|
|
spin_lock_irqsave(&bufferlock, flags);
|
|
|
|
list_del(&eerb->list);
|
|
|
|
spin_unlock_irqrestore(&bufferlock, flags);
|
|
|
|
dasd_eer_free_buffer_pages(eerb->buffer, eerb->buffer_page_count);
|
|
|
|
kfree(eerb->buffer);
|
|
|
|
kfree(eerb);
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static ssize_t dasd_eer_read(struct file *filp, char __user *buf,
|
|
|
|
size_t count, loff_t *ppos)
|
|
|
|
{
|
|
|
|
int tc,rc;
|
|
|
|
int tailcount,effective_count;
|
|
|
|
unsigned long flags;
|
|
|
|
struct eerbuffer *eerb;
|
|
|
|
|
|
|
|
eerb = (struct eerbuffer *) filp->private_data;
|
2007-05-31 15:38:02 +00:00
|
|
|
if (mutex_lock_interruptible(&readbuffer_mutex))
|
2006-03-24 11:15:25 +00:00
|
|
|
return -ERESTARTSYS;
|
|
|
|
|
|
|
|
spin_lock_irqsave(&bufferlock, flags);
|
|
|
|
|
|
|
|
if (eerb->residual < 0) { /* the remainder of this record */
|
|
|
|
/* has been deleted */
|
|
|
|
eerb->residual = 0;
|
|
|
|
spin_unlock_irqrestore(&bufferlock, flags);
|
2007-05-31 15:38:02 +00:00
|
|
|
mutex_unlock(&readbuffer_mutex);
|
2006-03-24 11:15:25 +00:00
|
|
|
return -EIO;
|
|
|
|
} else if (eerb->residual > 0) {
|
|
|
|
/* OK we still have a second half of a record to deliver */
|
|
|
|
effective_count = min(eerb->residual, (int) count);
|
|
|
|
eerb->residual -= effective_count;
|
|
|
|
} else {
|
|
|
|
tc = 0;
|
|
|
|
while (!tc) {
|
|
|
|
tc = dasd_eer_read_buffer(eerb, (char *) &tailcount,
|
|
|
|
sizeof(tailcount));
|
|
|
|
if (!tc) {
|
|
|
|
/* no data available */
|
|
|
|
spin_unlock_irqrestore(&bufferlock, flags);
|
2007-05-31 15:38:02 +00:00
|
|
|
mutex_unlock(&readbuffer_mutex);
|
2006-03-24 11:15:25 +00:00
|
|
|
if (filp->f_flags & O_NONBLOCK)
|
|
|
|
return -EAGAIN;
|
|
|
|
rc = wait_event_interruptible(
|
|
|
|
dasd_eer_read_wait_queue,
|
|
|
|
eerb->head != eerb->tail);
|
|
|
|
if (rc)
|
|
|
|
return rc;
|
2007-05-31 15:38:02 +00:00
|
|
|
if (mutex_lock_interruptible(&readbuffer_mutex))
|
2006-03-24 11:15:25 +00:00
|
|
|
return -ERESTARTSYS;
|
|
|
|
spin_lock_irqsave(&bufferlock, flags);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
WARN_ON(tc != sizeof(tailcount));
|
|
|
|
effective_count = min(tailcount,(int)count);
|
|
|
|
eerb->residual = tailcount - effective_count;
|
|
|
|
}
|
|
|
|
|
|
|
|
tc = dasd_eer_read_buffer(eerb, readbuffer, effective_count);
|
|
|
|
WARN_ON(tc != effective_count);
|
|
|
|
|
|
|
|
spin_unlock_irqrestore(&bufferlock, flags);
|
|
|
|
|
|
|
|
if (copy_to_user(buf, readbuffer, effective_count)) {
|
2007-05-31 15:38:02 +00:00
|
|
|
mutex_unlock(&readbuffer_mutex);
|
2006-03-24 11:15:25 +00:00
|
|
|
return -EFAULT;
|
|
|
|
}
|
|
|
|
|
2007-05-31 15:38:02 +00:00
|
|
|
mutex_unlock(&readbuffer_mutex);
|
2006-03-24 11:15:25 +00:00
|
|
|
return effective_count;
|
|
|
|
}
|
|
|
|
|
2017-07-03 10:39:46 +00:00
|
|
|
static __poll_t dasd_eer_poll(struct file *filp, poll_table *ptable)
|
2006-03-24 11:15:25 +00:00
|
|
|
{
|
2017-07-03 10:39:46 +00:00
|
|
|
__poll_t mask;
|
2006-03-24 11:15:25 +00:00
|
|
|
unsigned long flags;
|
|
|
|
struct eerbuffer *eerb;
|
|
|
|
|
|
|
|
eerb = (struct eerbuffer *) filp->private_data;
|
|
|
|
poll_wait(filp, &dasd_eer_read_wait_queue, ptable);
|
|
|
|
spin_lock_irqsave(&bufferlock, flags);
|
|
|
|
if (eerb->head != eerb->tail)
|
2018-02-11 22:34:03 +00:00
|
|
|
mask = EPOLLIN | EPOLLRDNORM ;
|
2006-03-24 11:15:25 +00:00
|
|
|
else
|
|
|
|
mask = 0;
|
|
|
|
spin_unlock_irqrestore(&bufferlock, flags);
|
|
|
|
return mask;
|
|
|
|
}
|
|
|
|
|
2007-02-12 08:55:34 +00:00
|
|
|
static const struct file_operations dasd_eer_fops = {
|
2006-03-24 11:15:25 +00:00
|
|
|
.open = &dasd_eer_open,
|
|
|
|
.release = &dasd_eer_close,
|
|
|
|
.read = &dasd_eer_read,
|
|
|
|
.poll = &dasd_eer_poll,
|
|
|
|
.owner = THIS_MODULE,
|
llseek: automatically add .llseek fop
All file_operations should get a .llseek operation so we can make
nonseekable_open the default for future file operations without a
.llseek pointer.
The three cases that we can automatically detect are no_llseek, seq_lseek
and default_llseek. For cases where we can we can automatically prove that
the file offset is always ignored, we use noop_llseek, which maintains
the current behavior of not returning an error from a seek.
New drivers should normally not use noop_llseek but instead use no_llseek
and call nonseekable_open at open time. Existing drivers can be converted
to do the same when the maintainer knows for certain that no user code
relies on calling seek on the device file.
The generated code is often incorrectly indented and right now contains
comments that clarify for each added line why a specific variant was
chosen. In the version that gets submitted upstream, the comments will
be gone and I will manually fix the indentation, because there does not
seem to be a way to do that using coccinelle.
Some amount of new code is currently sitting in linux-next that should get
the same modifications, which I will do at the end of the merge window.
Many thanks to Julia Lawall for helping me learn to write a semantic
patch that does all this.
===== begin semantic patch =====
// This adds an llseek= method to all file operations,
// as a preparation for making no_llseek the default.
//
// The rules are
// - use no_llseek explicitly if we do nonseekable_open
// - use seq_lseek for sequential files
// - use default_llseek if we know we access f_pos
// - use noop_llseek if we know we don't access f_pos,
// but we still want to allow users to call lseek
//
@ open1 exists @
identifier nested_open;
@@
nested_open(...)
{
<+...
nonseekable_open(...)
...+>
}
@ open exists@
identifier open_f;
identifier i, f;
identifier open1.nested_open;
@@
int open_f(struct inode *i, struct file *f)
{
<+...
(
nonseekable_open(...)
|
nested_open(...)
)
...+>
}
@ read disable optional_qualifier exists @
identifier read_f;
identifier f, p, s, off;
type ssize_t, size_t, loff_t;
expression E;
identifier func;
@@
ssize_t read_f(struct file *f, char *p, size_t s, loff_t *off)
{
<+...
(
*off = E
|
*off += E
|
func(..., off, ...)
|
E = *off
)
...+>
}
@ read_no_fpos disable optional_qualifier exists @
identifier read_f;
identifier f, p, s, off;
type ssize_t, size_t, loff_t;
@@
ssize_t read_f(struct file *f, char *p, size_t s, loff_t *off)
{
... when != off
}
@ write @
identifier write_f;
identifier f, p, s, off;
type ssize_t, size_t, loff_t;
expression E;
identifier func;
@@
ssize_t write_f(struct file *f, const char *p, size_t s, loff_t *off)
{
<+...
(
*off = E
|
*off += E
|
func(..., off, ...)
|
E = *off
)
...+>
}
@ write_no_fpos @
identifier write_f;
identifier f, p, s, off;
type ssize_t, size_t, loff_t;
@@
ssize_t write_f(struct file *f, const char *p, size_t s, loff_t *off)
{
... when != off
}
@ fops0 @
identifier fops;
@@
struct file_operations fops = {
...
};
@ has_llseek depends on fops0 @
identifier fops0.fops;
identifier llseek_f;
@@
struct file_operations fops = {
...
.llseek = llseek_f,
...
};
@ has_read depends on fops0 @
identifier fops0.fops;
identifier read_f;
@@
struct file_operations fops = {
...
.read = read_f,
...
};
@ has_write depends on fops0 @
identifier fops0.fops;
identifier write_f;
@@
struct file_operations fops = {
...
.write = write_f,
...
};
@ has_open depends on fops0 @
identifier fops0.fops;
identifier open_f;
@@
struct file_operations fops = {
...
.open = open_f,
...
};
// use no_llseek if we call nonseekable_open
////////////////////////////////////////////
@ nonseekable1 depends on !has_llseek && has_open @
identifier fops0.fops;
identifier nso ~= "nonseekable_open";
@@
struct file_operations fops = {
... .open = nso, ...
+.llseek = no_llseek, /* nonseekable */
};
@ nonseekable2 depends on !has_llseek @
identifier fops0.fops;
identifier open.open_f;
@@
struct file_operations fops = {
... .open = open_f, ...
+.llseek = no_llseek, /* open uses nonseekable */
};
// use seq_lseek for sequential files
/////////////////////////////////////
@ seq depends on !has_llseek @
identifier fops0.fops;
identifier sr ~= "seq_read";
@@
struct file_operations fops = {
... .read = sr, ...
+.llseek = seq_lseek, /* we have seq_read */
};
// use default_llseek if there is a readdir
///////////////////////////////////////////
@ fops1 depends on !has_llseek && !nonseekable1 && !nonseekable2 && !seq @
identifier fops0.fops;
identifier readdir_e;
@@
// any other fop is used that changes pos
struct file_operations fops = {
... .readdir = readdir_e, ...
+.llseek = default_llseek, /* readdir is present */
};
// use default_llseek if at least one of read/write touches f_pos
/////////////////////////////////////////////////////////////////
@ fops2 depends on !fops1 && !has_llseek && !nonseekable1 && !nonseekable2 && !seq @
identifier fops0.fops;
identifier read.read_f;
@@
// read fops use offset
struct file_operations fops = {
... .read = read_f, ...
+.llseek = default_llseek, /* read accesses f_pos */
};
@ fops3 depends on !fops1 && !fops2 && !has_llseek && !nonseekable1 && !nonseekable2 && !seq @
identifier fops0.fops;
identifier write.write_f;
@@
// write fops use offset
struct file_operations fops = {
... .write = write_f, ...
+ .llseek = default_llseek, /* write accesses f_pos */
};
// Use noop_llseek if neither read nor write accesses f_pos
///////////////////////////////////////////////////////////
@ fops4 depends on !fops1 && !fops2 && !fops3 && !has_llseek && !nonseekable1 && !nonseekable2 && !seq @
identifier fops0.fops;
identifier read_no_fpos.read_f;
identifier write_no_fpos.write_f;
@@
// write fops use offset
struct file_operations fops = {
...
.write = write_f,
.read = read_f,
...
+.llseek = noop_llseek, /* read and write both use no f_pos */
};
@ depends on has_write && !has_read && !fops1 && !fops2 && !has_llseek && !nonseekable1 && !nonseekable2 && !seq @
identifier fops0.fops;
identifier write_no_fpos.write_f;
@@
struct file_operations fops = {
... .write = write_f, ...
+.llseek = noop_llseek, /* write uses no f_pos */
};
@ depends on has_read && !has_write && !fops1 && !fops2 && !has_llseek && !nonseekable1 && !nonseekable2 && !seq @
identifier fops0.fops;
identifier read_no_fpos.read_f;
@@
struct file_operations fops = {
... .read = read_f, ...
+.llseek = noop_llseek, /* read uses no f_pos */
};
@ depends on !has_read && !has_write && !fops1 && !fops2 && !has_llseek && !nonseekable1 && !nonseekable2 && !seq @
identifier fops0.fops;
@@
struct file_operations fops = {
...
+.llseek = noop_llseek, /* no read or write fn */
};
===== End semantic patch =====
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Cc: Julia Lawall <julia@diku.dk>
Cc: Christoph Hellwig <hch@infradead.org>
2010-08-15 16:52:59 +00:00
|
|
|
.llseek = noop_llseek,
|
2006-03-24 11:15:25 +00:00
|
|
|
};
|
|
|
|
|
2007-02-05 20:17:04 +00:00
|
|
|
static struct miscdevice *dasd_eer_dev = NULL;
|
2006-03-24 11:15:25 +00:00
|
|
|
|
|
|
|
int __init dasd_eer_init(void)
|
|
|
|
{
|
|
|
|
int rc;
|
|
|
|
|
2007-02-05 20:17:04 +00:00
|
|
|
dasd_eer_dev = kzalloc(sizeof(*dasd_eer_dev), GFP_KERNEL);
|
|
|
|
if (!dasd_eer_dev)
|
|
|
|
return -ENOMEM;
|
|
|
|
|
|
|
|
dasd_eer_dev->minor = MISC_DYNAMIC_MINOR;
|
|
|
|
dasd_eer_dev->name = "dasd_eer";
|
|
|
|
dasd_eer_dev->fops = &dasd_eer_fops;
|
|
|
|
|
|
|
|
rc = misc_register(dasd_eer_dev);
|
2006-03-24 11:15:25 +00:00
|
|
|
if (rc) {
|
2007-02-05 20:17:04 +00:00
|
|
|
kfree(dasd_eer_dev);
|
|
|
|
dasd_eer_dev = NULL;
|
2009-03-26 14:23:49 +00:00
|
|
|
DBF_EVENT(DBF_ERR, "%s", "dasd_eer_init could not "
|
2006-03-24 11:15:25 +00:00
|
|
|
"register misc device");
|
|
|
|
return rc;
|
|
|
|
}
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2006-09-20 13:59:12 +00:00
|
|
|
void dasd_eer_exit(void)
|
2006-03-24 11:15:25 +00:00
|
|
|
{
|
2007-02-05 20:17:04 +00:00
|
|
|
if (dasd_eer_dev) {
|
2010-08-10 00:20:35 +00:00
|
|
|
misc_deregister(dasd_eer_dev);
|
2007-02-05 20:17:04 +00:00
|
|
|
kfree(dasd_eer_dev);
|
|
|
|
dasd_eer_dev = NULL;
|
|
|
|
}
|
2006-03-24 11:15:25 +00:00
|
|
|
}
|