leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
Files
ea68376c8bed5cd156900852aada20c3a0874d17
linux/kernel
History
Stanislav Fomichev ea68376c8b bpf: prevent decl_tag from being referenced in func_proto 
Syzkaller was able to hit the following issue:

------------[ cut here ]------------
WARNING: CPU: 0 PID: 3609 at kernel/bpf/btf.c:1946
btf_type_id_size+0x2d5/0x9d0 kernel/bpf/btf.c:1946
Modules linked in:
CPU: 0 PID: 3609 Comm: syz-executor361 Not tainted
6.0.0-syzkaller-02734-g0326074ff465 #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS
Google 09/22/2022
RIP: 0010:btf_type_id_size+0x2d5/0x9d0 kernel/bpf/btf.c:1946
Code: ef e8 7f 8e e4 ff 41 83 ff 0b 77 28 f6 44 24 10 18 75 3f e8 6d 91
e4 ff 44 89 fe bf 0e 00 00 00 e8 20 8e e4 ff e8 5b 91 e4 ff <0f> 0b 45
31 f6 e9 98 02 00 00 41 83 ff 12 74 18 e8 46 91 e4 ff 44
RSP: 0018:ffffc90003cefb40 EFLAGS: 00010293
RAX: 0000000000000000 RBX: 0000000000000002 RCX: 0000000000000000
RDX: ffff8880259c0000 RSI: ffffffff81968415 RDI: 0000000000000005
RBP: ffff88801270ca00 R08: 0000000000000005 R09: 000000000000000e
R10: 0000000000000011 R11: 0000000000000000 R12: 0000000000000000
R13: 0000000000000011 R14: ffff888026ee6424 R15: 0000000000000011
FS:  000055555641b300(0000) GS:ffff8880b9a00000(0000)
knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 0000000000f2e258 CR3: 000000007110e000 CR4: 00000000003506f0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
 <TASK>
 btf_func_proto_check kernel/bpf/btf.c:4447 [inline]
 btf_check_all_types kernel/bpf/btf.c:4723 [inline]
 btf_parse_type_sec kernel/bpf/btf.c:4752 [inline]
 btf_parse kernel/bpf/btf.c:5026 [inline]
 btf_new_fd+0x1926/0x1e70 kernel/bpf/btf.c:6892
 bpf_btf_load kernel/bpf/syscall.c:4324 [inline]
 __sys_bpf+0xb7d/0x4cf0 kernel/bpf/syscall.c:5010
 __do_sys_bpf kernel/bpf/syscall.c:5069 [inline]
 __se_sys_bpf kernel/bpf/syscall.c:5067 [inline]
 __x64_sys_bpf+0x75/0xb0 kernel/bpf/syscall.c:5067
 do_syscall_x64 arch/x86/entry/common.c:50 [inline]
 do_syscall_64+0x35/0xb0 arch/x86/entry/common.c:80
 entry_SYSCALL_64_after_hwframe+0x63/0xcd
RIP: 0033:0x7f0fbae41c69
Code: 28 c3 e8 2a 14 00 00 66 2e 0f 1f 84 00 00 00 00 00 48 89 f8 48 89
f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01
f0 ff ff 73 01 c3 48 c7 c1 c0 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007ffc8aeb6228 EFLAGS: 00000246 ORIG_RAX: 0000000000000141
RAX: ffffffffffffffda RBX: 0000000000000000 RCX: 00007f0fbae41c69
RDX: 0000000000000020 RSI: 0000000020000140 RDI: 0000000000000012
RBP: 00007f0fbae05e10 R08: 0000000000000000 R09: 0000000000000000
R10: 00000000ffffffff R11: 0000000000000246 R12: 00007f0fbae05ea0
R13: 0000000000000000 R14: 0000000000000000 R15: 0000000000000000
 </TASK>

Looks like it tries to create a func_proto which return type is
decl_tag. For the details, see Martin's spot on analysis in [0].

0: https://lore.kernel.org/bpf/CAKH8qBuQDLva_hHxxBuZzyAcYNO4ejhovz6TQeVSk8HY-2SO6g@mail.gmail.com/T/#mea6524b3fcd6298347432226e81b1e6155efc62c

Cc: Yonghong Song <yhs@fb.com>
Cc: Martin KaFai Lau <martin.lau@kernel.org>
Fixes: bd16dee66a ("bpf: Add BTF_KIND_DECL_TAG typedef support")
Reported-by: syzbot+d8bd751aef7c6b39a344@syzkaller.appspotmail.com
Signed-off-by: Stanislav Fomichev <sdf@google.com>
Acked-by: Yonghong Song <yhs@fb.com>
Link: https://lore.kernel.org/r/20221015002444.2680969-2-sdf@google.com
Signed-off-by: Martin KaFai Lau <martin.lau@kernel.org>
2022-10-17 10:56:12 -07:00
..
bpf
bpf: prevent decl_tag from being referenced in func_proto
2022-10-17 10:56:12 -07:00
cgroup
Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net
2022-09-29 14:30:51 -07:00
configs
Kbuild: add Rust support
2022-09-28 09:02:20 +02:00
debug
Merge tag 'modules-5.19-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux
2022-05-26 17:13:43 -07:00
dma
dma-mapping: mark dma_supported static
2022-09-07 10:38:28 +02:00
entry
context_tracking: Take NMI eqs entrypoints over RCU
2022-07-05 13:32:59 -07:00
events
perf/core: Fix reentry problem in perf_output_read_group()
2022-09-06 11:33:00 +02:00
futex
Merge tag 'drm-next-2022-05-25' of git://anongit.freedesktop.org/drm/drm
2022-05-25 16:18:27 -07:00
gcov
gcov: Remove compiler version check
2021-12-02 17:25:21 +09:00
irq
Merge tag 'irqchip-5.20' of git://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms into irq/core
2022-07-28 12:36:35 +02:00
kcsan
kcsan: test: Add a .kunitconfig to run KCSAN tests
2022-07-22 09:22:59 -06:00
livepatch
kallsyms: increase maximum kernel symbol length to 512
2022-09-28 08:56:25 +02:00
locking
Merge tag 'rcu.2022.07.26a' of git://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu
2022-08-02 19:12:45 -07:00
module
cfi: Switch to -fsanitize=kcfi
2022-09-26 10:13:13 -07:00
power
Merge tag 'char-misc-6.0-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc
2022-08-04 11:05:48 -07:00
printk
printk: do not wait for consoles when suspended
2022-07-15 10:52:11 +02:00
rcu
Merge branches 'doc.2022.08.31b', 'fixes.2022.08.31b', 'kvfree.2022.08.31b', 'nocb.2022.09.01a', 'poll.2022.08.31b', 'poll-srcu.2022.08.31b' and 'tasks.2022.08.31b' into HEAD
2022-09-01 10:55:57 -07:00
sched
Merge tag 'pm-6.1-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm
2022-10-03 13:26:47 -07:00
time
time: Correct the prototype of ns_to_kernel_old_timeval and ns_to_timespec64
2022-08-09 20:02:13 +02:00
trace
Merge https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next
2022-10-03 13:02:49 -07:00
.gitignore
…
acct.c
kernel/acct: move acct sysctls to its own file
2022-04-06 13:43:44 -07:00
async.c
Revert "module, async: async_synchronize_full() on module init iff async is used"
2022-02-03 11:20:34 -08:00
audit_fsnotify.c
audit: fix potential double free on error path from fsnotify_add_inode_mark
2022-08-22 18:50:06 -04:00
audit_tree.c
audit: use fsnotify group lock helpers
2022-04-25 14:37:28 +02:00
audit_watch.c
fsnotify: pass flags argument to fsnotify_alloc_group()
2022-04-25 14:37:12 +02:00
audit.c
audit: use time_after to compare time
2022-08-29 19:47:03 -04:00
audit.h
audit: remove selinux_audit_rule_update() declaration
2022-09-07 11:30:15 -04:00
auditfilter.c
Merge tag 'audit-pr-20220110' of git://git.kernel.org/pub/scm/linux/kernel/git/pcmoore/audit
2022-01-11 13:08:21 -08:00
auditsc.c
Merge tag 'audit-pr-20221003' of git://git.kernel.org/pub/scm/linux/kernel/git/pcmoore/audit
2022-10-04 11:05:43 -07:00
backtracetest.c
…
bounds.c
…
capability.c
xfs: don't generate selinux audit messages for capability testing
2022-03-09 10:32:06 -08:00
cfi.c
cfi: Switch to -fsanitize=kcfi
2022-09-26 10:13:13 -07:00
compat.c
arch: remove compat_alloc_user_space
2021-09-08 15:32:35 -07:00
configs.c
…
context_tracking.c
MAINTAINERS: Add Paul as context tracking maintainer
2022-07-05 13:33:00 -07:00
cpu_pm.c
context_tracking: Take IRQ eqs entrypoints over RCU
2022-07-05 13:32:59 -07:00
cpu.c
Merge tag 'x86_tdx_for_v5.19_rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip
2022-05-23 17:51:12 -07:00
crash_core.c
vmcoreinfo: add kallsyms_num_syms symbol
2022-08-28 14:02:44 -07:00
crash_dump.c
…
cred.c
x86: Mark __invalid_creds() __noreturn
2022-03-15 10:32:44 +01:00
delayacct.c
delayacct: track delays from write-protect copy
2022-06-01 15:55:25 -07:00
dma.c
…
exec_domain.c
…
exit.c
exit: Fix typo in comment: s/sub-theads/sub-threads
2022-08-03 10:44:54 +02:00
extable.c
context_tracking: Take NMI eqs entrypoints over RCU
2022-07-05 13:32:59 -07:00
fail_function.c
…
fork.c
Merge tag 'execve-v6.0-rc7' of git://git.kernel.org/pub/scm/linux/kernel/git/kees/linux
2022-09-20 08:38:55 -07:00
freezer.c
…
gen_kheaders.sh
kheaders: Have cpio unconditionally replace files
2022-05-08 03:16:59 +09:00
groups.c
security: Add LSM hook to setgroups() syscall
2022-07-15 18:21:49 +00:00
hung_task.c
kernel/hung_task: fix address space of proc_dohung_task_timeout_secs
2022-07-29 18:12:35 -07:00
iomem.c
…
irq_work.c
irq_work: use kasan_record_aux_stack_noalloc() record callstack
2022-04-15 14:49:55 -07:00
jump_label.c
jump_label: make initial NOP patching the special case
2022-06-24 09:48:55 +02:00
kallsyms_internal.h
kallsyms: move declarations to internal header
2022-07-17 17:31:39 -07:00
kallsyms.c
Merge tag 'kcfi-v6.1-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/kees/linux
2022-10-03 17:11:07 -07:00
kcmp.c
…
Kconfig.freezer
…
Kconfig.hz
…
Kconfig.locks
locking/rwlock: Provide RT variant
2021-08-17 17:50:51 +02:00
Kconfig.preempt
Revert "signal, x86: Delay calling signals in atomic on RT enabled kernels"
2022-03-31 10:36:55 +02:00
kcov.c
kcov: update pos before writing pc in trace function
2022-05-25 13:05:42 -07:00
kexec_core.c
kexec: drop weak attribute from functions
2022-07-15 12:21:16 -04:00
kexec_elf.c
…
kexec_file.c
Merge tag 'mm-nonmm-stable-2022-08-06-2' of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
2022-08-07 10:03:24 -07:00
kexec_internal.h
…
kexec.c
kexec: avoid compat_alloc_user_space
2021-09-08 15:32:34 -07:00
kheaders.c
…
kmod.c
…
kprobes.c
Merge https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next
2022-10-03 13:02:49 -07:00
ksysfs.c
kernel/ksysfs.c: use helper macro __ATTR_RW
2022-03-23 19:00:33 -07:00
kthread.c
treewide: Drop WARN_ON_FUNCTION_MISMATCH
2022-09-26 10:13:14 -07:00
latencytop.c
latencytop: move sysctl to its own file
2022-04-21 11:40:59 -07:00
Makefile
kernel: remove platform_has() infrastructure
2022-08-01 07:42:56 +02:00
module_signature.c
…
notifier.c
notifier: Add blocking/atomic_notifier_chain_register_unique_prio()
2022-05-19 19:30:30 +02:00
nsproxy.c
Revert "fs/exec: allow to unshare a time namespace on vfork+exec"
2022-09-13 10:38:43 -07:00
padata.c
padata: replace cpumask_weight with cpumask_empty in padata.c
2022-01-31 11:21:46 +11:00
panic.c
Merge tag 'linux-kselftest-kunit-5.20-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest
2022-08-02 19:34:45 -07:00
params.c
kobject: remove kset from struct kset_uevent_ops callbacks
2021-12-28 11:26:18 +01:00
pid_namespace.c
kernel: pid_namespace: use NULL instead of using plain integer as pointer
2022-04-29 14:38:00 -07:00
pid.c
pid: add pidfd_get_task() helper
2021-10-14 13:29:18 +02:00
profile.c
profile: setup_profiling_timer() is moslty not implemented
2022-07-29 18:12:36 -07:00
ptrace.c
ptrace: fix clearing of JOBCTL_TRACED in ptrace_unfreeze_traced()
2022-07-09 11:06:19 -07:00
range.c
…
reboot.c
Merge branch 'rework/kthreads' into for-linus
2022-06-23 19:11:28 +02:00
regset.c
…
relay.c
relay: remove redundant assignment to pointer buf
2022-05-12 20:38:37 -07:00
resource_kunit.c
…
resource.c
resource: Introduce alloc_free_mem_region()
2022-07-21 17:19:25 -07:00
rseq.c
rseq: Kill process when unknown flags are encountered in ABI structures
2022-08-01 15:21:42 +02:00
scftorture.c
scftorture: Fix distribution of short handler delays
2022-04-11 17:07:29 -07:00
scs.c
kasan, vmalloc: only tag normal vmalloc allocations
2022-03-24 19:06:48 -07:00
seccomp.c
seccomp: Add wait_killable semantic to seccomp user notifier
2022-05-03 14:11:58 -07:00
signal.c
signal handling: don't use BUG_ON() for debugging
2022-07-07 09:53:43 -07:00
smp.c
sched/debug: Try trigger_single_cpu_backtrace(cpu) in dump_cpu_task()
2022-08-31 05:03:14 -07:00
smpboot.c
cpu/hotplug: Allow the CPU in CPU_UP_PREPARE state to be brought up again.
2022-04-12 14:13:01 +02:00
smpboot.h
…
softirq.c
context_tracking: Take IRQ eqs entrypoints over RCU
2022-07-05 13:32:59 -07:00
stackleak.c
stackleak: add on/off stack variants
2022-05-08 01:33:09 -07:00
stacktrace.c
uaccess: remove CONFIG_SET_FS
2022-02-25 09:36:06 +01:00
static_call_inline.c
static_call: Don't make __static_call_return0 static
2022-04-05 09:59:38 +02:00
static_call.c
static_call: Don't make __static_call_return0 static
2022-04-05 09:59:38 +02:00
stop_machine.c
Merge tag 'sched-core-2022-05-23' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip
2022-05-24 11:11:13 -07:00
sys_ni.c
kernel/sys_ni: add compat entry for fadvise64_64
2022-08-20 15:17:45 -07:00
sys.c
arm64/sme: Implement vector length configuration prctl()s
2022-04-22 18:50:54 +01:00
sysctl-test.c
…
sysctl.c
kernel/sysctl.c: Remove trailing white space
2022-08-08 09:01:36 -07:00
task_work.c
task_work: allow TWA_SIGNAL without a rescheduling IPI
2022-04-30 08:39:32 -06:00
taskstats.c
genetlink: start to validate reserved header bytes
2022-08-29 12:47:15 +01:00
torture.c
torture: Wake up kthreads after storing task_struct pointer
2022-02-01 17:24:39 -08:00
tracepoint.c
tracepoint: Allow trace events in modules with TAINT_TEST
2022-09-06 22:26:00 -04:00
tsacct.c
taskstats: version 12 with thread group and exe info
2022-04-29 14:38:03 -07:00
ucount.c
ucounts: Handle wrapping in is_ucounts_overlimit
2022-02-17 09:11:57 -06:00
uid16.c
…
uid16.h
…
umh.c
kthread: Don't allocate kthread_struct for init and umh
2022-05-06 14:49:44 -05:00
up.c
…
user_namespace.c
security, lsm: Introduce security_create_user_ns()
2022-08-16 17:32:46 -04:00
user-return-notifier.c
…
user.c
fs/epoll: use a per-cpu counter for user's watches count
2021-09-08 11:50:27 -07:00
usermode_driver.c
blob_to_mnt(): kern_unmount() is needed to undo kern_mount()
2022-05-19 23:25:47 -04:00
utsname_sysctl.c
…
utsname.c
…
watch_queue.c
Merge tag 'docs-6.0' of git://git.lwn.net/linux
2022-08-02 19:24:24 -07:00
watchdog_hld.c
Revert "printk: add functions to prefer direct printing"
2022-06-23 18:41:40 +02:00
watchdog.c
Merge tag 'powerpc-6.0-1' of git://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux
2022-08-06 16:38:17 -07:00
workqueue_internal.h
workqueue: Assign a color to barrier work items
2021-08-17 07:49:10 -10:00
workqueue.c
Merge tag 'kcfi-v6.1-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/kees/linux
2022-10-03 17:11:07 -07:00