leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
Files
c87bf24cfb60bce27b4d2c7e56ebfd86fb9d16bb
linux/drivers
History
John Garry c87bf24cfb scsi: scsi_debug: Add check for sdebug_max_queue during module init 
sdebug_max_queue should not exceed SDEBUG_CANQUEUE, otherwise crashes like
this can be triggered by passing an out-of-range value:

Hardware name: Huawei D06 /D06, BIOS Hisilicon D06 UEFI RC0 - V1.16.01 03/15/2019
 pstate: 20400009 (nzCv daif +PAN -UAO BTYPE=--)
 pc : schedule_resp+0x2a4/0xa70 [scsi_debug]
 lr : schedule_resp+0x52c/0xa70 [scsi_debug]
 sp : ffff800022ab36f0
 x29: ffff800022ab36f0 x28: ffff0023a935a610
 x27: ffff800008e0a648 x26: 0000000000000003
 x25: ffff0023e84f3200 x24: 00000000003d0900
 x23: 0000000000000000 x22: 0000000000000000
 x21: ffff0023be60a320 x20: ffff0023be60b538
 x19: ffff800008e13000 x18: 0000000000000000
 x17: 0000000000000000 x16: 0000000000000000
 x15: 0000000000000000 x14: 0000000000000000
 x13: 0000000000000000 x12: 0000000000000000
 x11: 0000000000000000 x10: 0000000000000000
 x9 : 0000000000000001 x8 : 0000000000000000
 x7 : 0000000000000000 x6 : 00000000000000c1
 x5 : 0000020000200000 x4 : dead0000000000ff
 x3 : 0000000000000200 x2 : 0000000000000200
 x1 : ffff800008e13d88 x0 : 0000000000000000
 Call trace:
schedule_resp+0x2a4/0xa70 [scsi_debug]
scsi_debug_queuecommand+0x2c4/0x9e0 [scsi_debug]
scsi_queue_rq+0x698/0x840
__blk_mq_try_issue_directly+0x108/0x228
blk_mq_request_issue_directly+0x58/0x98
blk_mq_try_issue_list_directly+0x5c/0xf0
blk_mq_sched_insert_requests+0x18c/0x200
blk_mq_flush_plug_list+0x11c/0x190
blk_flush_plug_list+0xdc/0x110
blk_finish_plug+0x38/0x210
blkdev_direct_IO+0x450/0x4d8
generic_file_read_iter+0x84/0x180
blkdev_read_iter+0x3c/0x50
aio_read+0xc0/0x170
io_submit_one+0x5c8/0xc98
__arm64_sys_io_submit+0x1b0/0x258
el0_svc_common.constprop.3+0x68/0x170
do_el0_svc+0x24/0x90
el0_sync_handler+0x13c/0x1a8
el0_sync+0x158/0x180
 Code: 528847e0 72a001e0 6b00003f 540018cd (3941c340)

In addition, it should not be less than 1.

So add checks for these, and fail the module init for those cases.

[mkp: changed if condition to match error message]

Link: https://lore.kernel.org/r/1594297400-24756-2-git-send-email-john.garry@huawei.com
Fixes: c483739430 ("scsi_debug: add multiple queue support")
Reviewed-by: Ming Lei <ming.lei@redhat.com>
Acked-by: Douglas Gilbert <dgilbert@interlog.com>
Signed-off-by: John Garry <john.garry@huawei.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
2020-07-13 23:42:31 -04:00
..
accessibility
treewide: replace '---help---' in Kconfig files with 'help'
2020-06-14 01:57:21 +09:00
acpi
Merge tag 'libnvdimm-for-5.8' of git://git.kernel.org/pub/scm/linux/kernel/git/nvdimm/nvdimm
2020-06-13 13:04:36 -07:00
amba
Merge tag 'arm-soc-5.8' of git://git.kernel.org/pub/scm/linux/kernel/git/soc/soc
2020-06-04 19:47:11 -07:00
android
treewide: replace '---help---' in Kconfig files with 'help'
2020-06-14 01:57:21 +09:00
ata
treewide: replace '---help---' in Kconfig files with 'help'
2020-06-14 01:57:21 +09:00
atm
treewide: replace '---help---' in Kconfig files with 'help'
2020-06-14 01:57:21 +09:00
auxdisplay
treewide: replace '---help---' in Kconfig files with 'help'
2020-06-14 01:57:21 +09:00
base
Merge tag 'linux-kselftest-kunit-5.8-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest
2020-06-09 10:04:47 -07:00
bcma
…
block
Merge tag 'kbuild-v5.8-2' of git://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild
2020-06-13 13:29:16 -07:00
bluetooth
Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next
2020-06-03 16:27:18 -07:00
bus
Merge tag 'char-misc-5.8-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc
2020-06-07 10:59:32 -07:00
cdrom
Merge branch 'work.sysctl' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
2020-06-10 16:05:54 -07:00
char
treewide: replace '---help---' in Kconfig files with 'help'
2020-06-14 01:57:21 +09:00
clk
treewide: replace '---help---' in Kconfig files with 'help'
2020-06-14 01:57:21 +09:00
clocksource
clocksource/drivers/timer-riscv: Use per-CPU timer interrupt
2020-06-09 19:11:22 -07:00
connector
treewide: replace '---help---' in Kconfig files with 'help'
2020-06-14 01:57:21 +09:00
counter
…
cpufreq
treewide: replace '---help---' in Kconfig files with 'help'
2020-06-14 01:57:21 +09:00
cpuidle
Merge tag 'thermal-v5.8-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/thermal/linux
2020-06-12 14:10:21 -07:00
crypto
Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net
2020-06-13 16:27:13 -07:00
dax
device-dax: add memory via add_memory_driver_managed()
2020-06-04 19:06:23 -07:00
dca
…
devfreq
…
dio
…
dma
treewide: replace '---help---' in Kconfig files with 'help'
2020-06-14 01:57:21 +09:00
dma-buf
treewide: replace '---help---' in Kconfig files with 'help'
2020-06-14 01:57:21 +09:00
edac
Merge tag 'kbuild-v5.8-2' of git://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild
2020-06-13 13:29:16 -07:00
eisa
treewide: replace '---help---' in Kconfig files with 'help'
2020-06-14 01:57:21 +09:00
extcon
…
firewire
…
firmware
Merge tag 'kbuild-v5.8-2' of git://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild
2020-06-13 13:29:16 -07:00
fpga
Merge tag 'char-misc-5.8-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc
2020-06-07 10:59:32 -07:00
fsi
treewide: replace '---help---' in Kconfig files with 'help'
2020-06-14 01:57:21 +09:00
gnss
treewide: replace '---help---' in Kconfig files with 'help'
2020-06-14 01:57:21 +09:00
gpio
treewide: replace '---help---' in Kconfig files with 'help'
2020-06-14 01:57:21 +09:00
gpu
Merge tag 'kbuild-v5.8-2' of git://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild
2020-06-13 13:29:16 -07:00
greybus
treewide: replace '---help---' in Kconfig files with 'help'
2020-06-14 01:57:21 +09:00
hid
treewide: replace '---help---' in Kconfig files with 'help'
2020-06-14 01:57:21 +09:00
hsi
treewide: replace '---help---' in Kconfig files with 'help'
2020-06-14 01:57:21 +09:00
hv
Merge tag 'hyperv-next-signed' of git://git.kernel.org/pub/scm/linux/kernel/git/hyperv/linux
2020-06-03 15:00:05 -07:00
hwmon
Merge branch 'x86/entry' into ras/core
2020-06-11 15:17:57 +02:00
hwspinlock
…
hwtracing
Merge tag 'char-misc-5.8-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc
2020-06-07 10:59:32 -07:00
i2c
Merge tag 'kbuild-v5.8-2' of git://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild
2020-06-13 13:29:16 -07:00
i3c
…
ide
treewide: replace '---help---' in Kconfig files with 'help'
2020-06-14 01:57:21 +09:00
idle
…
iio
treewide: replace '---help---' in Kconfig files with 'help'
2020-06-14 01:57:21 +09:00
infiniband
treewide: replace '---help---' in Kconfig files with 'help'
2020-06-14 01:57:21 +09:00
input
treewide: replace '---help---' in Kconfig files with 'help'
2020-06-14 01:57:21 +09:00
interconnect
Merge tag 'pm-5.8-rc1-2' of git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm
2020-06-10 14:04:39 -07:00
iommu
Merge tag 'kbuild-v5.8-2' of git://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild
2020-06-13 13:29:16 -07:00
ipack
treewide: replace '---help---' in Kconfig files with 'help'
2020-06-14 01:57:21 +09:00
irqchip
clocksource/drivers/timer-riscv: Use per-CPU timer interrupt
2020-06-09 19:11:22 -07:00
isdn
treewide: replace '---help---' in Kconfig files with 'help'
2020-06-14 01:57:21 +09:00
leds
Merge tag 'leds-5.8-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/pavel/linux-leds
2020-06-04 11:03:45 -07:00
lightnvm
Merge tag 'for-5.8/block-2020-06-01' of git://git.kernel.dk/linux-block
2020-06-02 15:29:19 -07:00
macintosh
treewide: replace '---help---' in Kconfig files with 'help'
2020-06-14 01:57:21 +09:00
mailbox
mailbox: qcom: Add ipq6018 apcs compatible
2020-06-10 22:43:57 -05:00
mcb
…
md
treewide: replace '---help---' in Kconfig files with 'help'
2020-06-14 01:57:21 +09:00
media
Merge tag 'kbuild-v5.8-2' of git://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild
2020-06-13 13:29:16 -07:00
memory
…
memstick
…
message
treewide: replace '---help---' in Kconfig files with 'help'
2020-06-14 01:57:21 +09:00
mfd
treewide: replace '---help---' in Kconfig files with 'help'
2020-06-14 01:57:21 +09:00
misc
treewide: replace '---help---' in Kconfig files with 'help'
2020-06-14 01:57:21 +09:00
mmc
treewide: replace '---help---' in Kconfig files with 'help'
2020-06-14 01:57:21 +09:00
most
…
mtd
Merge tag 'for-linus-5.8-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/rw/ubifs
2020-06-10 13:24:40 -07:00
mux
…
net
Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net
2020-06-13 16:27:13 -07:00
nfc
treewide: replace '---help---' in Kconfig files with 'help'
2020-06-14 01:57:21 +09:00
ntb
NTB: perf: Fix race condition when run with ntb_test
2020-06-05 20:02:09 -04:00
nubus
…
nvdimm
Merge tag 'libnvdimm-for-5.8' of git://git.kernel.org/pub/scm/linux/kernel/git/nvdimm/nvdimm
2020-06-13 13:04:36 -07:00
nvme
Merge tag 'kbuild-v5.8-2' of git://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild
2020-06-13 13:29:16 -07:00
nvmem
…
of
Merge tag 'driver-core-5.8-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core
2020-06-07 10:53:36 -07:00
opp
treewide: replace '---help---' in Kconfig files with 'help'
2020-06-14 01:57:21 +09:00
oprofile
mmap locking API: convert mmap_sem comments
2020-06-09 09:39:14 -07:00
parisc
…
parport
treewide: replace '---help---' in Kconfig files with 'help'
2020-06-14 01:57:21 +09:00
pci
Merge tag 'kbuild-v5.8-2' of git://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild
2020-06-13 13:29:16 -07:00
pcmcia
treewide: replace '---help---' in Kconfig files with 'help'
2020-06-14 01:57:21 +09:00
perf
Merge tag 'arm64-upstream' of git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux
2020-06-11 12:53:23 -07:00
phy
…
pinctrl
Merge tag 'pinctrl-v5.8-1' of git://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl
2020-06-07 16:13:43 -07:00
platform
Merge tag 'kbuild-v5.8-2' of git://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild
2020-06-13 13:29:16 -07:00
pnp
treewide: replace '---help---' in Kconfig files with 'help'
2020-06-14 01:57:21 +09:00
power
Merge tag 'for-v5.8' of git://git.kernel.org/pub/scm/linux/kernel/git/sre/linux-power-supply
2020-06-10 11:28:35 -07:00
powercap
Merge tag 'kbuild-v5.8-2' of git://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild
2020-06-13 13:29:16 -07:00
pps
treewide: replace '---help---' in Kconfig files with 'help'
2020-06-14 01:57:21 +09:00
ps3
…
ptp
treewide: replace '---help---' in Kconfig files with 'help'
2020-06-14 01:57:21 +09:00
pwm
pwm: Add missing "CONFIG_" prefix
2020-06-04 19:09:28 +02:00
rapidio
treewide: replace '---help---' in Kconfig files with 'help'
2020-06-14 01:57:21 +09:00
ras
…
regulator
Merge remote-tracking branch 'regulator/for-5.8' into regulator-linus
2020-06-01 13:01:44 +01:00
remoteproc
Merge tag 'rproc-v5.8' of git://git.kernel.org/pub/scm/linux/kernel/git/andersson/remoteproc
2020-06-08 13:01:08 -07:00
reset
Merge tag 'char-misc-5.8-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc
2020-06-07 10:59:32 -07:00
rpmsg
Merge tag 'rproc-v5.8' of git://git.kernel.org/pub/scm/linux/kernel/git/andersson/remoteproc
2020-06-08 13:01:08 -07:00
rtc
Merge tag 'rtc-5.8' of git://git.kernel.org/pub/scm/linux/kernel/git/abelloni/linux
2020-06-07 16:11:23 -07:00
s390
scsi: zfcp: Avoid benign overflow of the Request Queue's free-level
2020-07-08 00:50:56 -04:00
sbus
treewide: replace '---help---' in Kconfig files with 'help'
2020-06-14 01:57:21 +09:00
scsi
scsi: scsi_debug: Add check for sdebug_max_queue during module init
2020-07-13 23:42:31 -04:00
sfi
treewide: replace '---help---' in Kconfig files with 'help'
2020-06-14 01:57:21 +09:00
sh
…
siox
…
slimbus
…
soc
treewide: replace '---help---' in Kconfig files with 'help'
2020-06-14 01:57:21 +09:00
soundwire
…
spi
Merge tag 'char-misc-5.8-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc
2020-06-07 10:59:32 -07:00
spmi
…
ssb
…
staging
Merge tag 'kbuild-v5.8-2' of git://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild
2020-06-13 13:29:16 -07:00
target
scsi: target: Remove unused variable 'tpg'
2020-07-13 23:11:15 -04:00
tc
…
tee
mmap locking API: use coccinelle to convert mmap_sem rwsem call sites
2020-06-09 09:39:14 -07:00
thermal
Merge tag 'thermal-v5.8-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/thermal/linux
2020-06-12 14:10:21 -07:00
thunderbolt
Merge tag 'usb-5.8-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb
2020-06-07 09:42:16 -07:00
tty
treewide: replace '---help---' in Kconfig files with 'help'
2020-06-14 01:57:21 +09:00
uio
…
usb
Merge tag 'kbuild-v5.8-2' of git://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild
2020-06-13 13:29:16 -07:00
vdpa
ifcvf: implement config interrupt in IFCVF
2020-06-06 16:26:47 -04:00
vfio
kernel: better document the use_mm/unuse_mm API contract
2020-06-10 19:14:18 -07:00
vhost
Merge tag 'kbuild-v5.8-2' of git://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild
2020-06-13 13:29:16 -07:00
video
treewide: replace '---help---' in Kconfig files with 'help'
2020-06-14 01:57:21 +09:00
virt
treewide: replace '---help---' in Kconfig files with 'help'
2020-06-14 01:57:21 +09:00
virtio
treewide: replace '---help---' in Kconfig files with 'help'
2020-06-14 01:57:21 +09:00
visorbus
treewide: replace '---help---' in Kconfig files with 'help'
2020-06-14 01:57:21 +09:00
vlynq
…
vme
treewide: replace '---help---' in Kconfig files with 'help'
2020-06-14 01:57:21 +09:00
w1
treewide: replace '---help---' in Kconfig files with 'help'
2020-06-14 01:57:21 +09:00
watchdog
treewide: replace '---help---' in Kconfig files with 'help'
2020-06-14 01:57:21 +09:00
xen
Merge tag 'x86-entry-2020-06-12' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip
2020-06-13 10:05:47 -07:00
zorro
treewide: replace '---help---' in Kconfig files with 'help'
2020-06-14 01:57:21 +09:00
Kconfig
…
Makefile
…