Files
linux/include/linux
Michal Hocko 9852a72123 mm: drop hotplug lock from lru_add_drain_all()
Pulling cpu hotplug locks inside the mm core function like
lru_add_drain_all just asks for problems and the recent lockdep splat
[1] just proves this.  While the usage in that particular case might be
wrong we should avoid the locking as lru_add_drain_all() is used in many
places.  It seems that this is not all that hard to achieve actually.

We have done the same thing for drain_all_pages which is analogous by
commit a459eeb7b8 ("mm, page_alloc: do not depend on cpu hotplug locks
inside the allocator").  All we have to care about is to handle

      - the work item might be executed on a different cpu in worker from
        unbound pool so it doesn't run on pinned on the cpu

      - we have to make sure that we do not race with page_alloc_cpu_dead
        calling lru_add_drain_cpu

the first part is already handled because the worker calls lru_add_drain
which disables preemption when calling lru_add_drain_cpu on the local
cpu it is draining.  The later is true because page_alloc_cpu_dead is
called on the controlling CPU after the hotplugged CPU vanished
completely.

[1] http://lkml.kernel.org/r/089e0825eec8955c1f055c83d476@google.com

[add a cpu hotplug locking interaction as per tglx]
Link: http://lkml.kernel.org/r/20171116120535.23765-1-mhocko@kernel.org
Signed-off-by: Michal Hocko <mhocko@suse.com>
Acked-by: Thomas Gleixner <tglx@linutronix.de>
Cc: Tejun Heo <tj@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Johannes Weiner <hannes@cmpxchg.org>
Cc: Mel Gorman <mgorman@suse.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2018-01-31 17:18:36 -08:00
..
2018-01-08 11:03:35 +00:00
2017-11-30 16:55:35 +00:00
2017-12-21 02:15:41 +01:00
2017-11-15 18:21:04 -08:00
2018-01-03 14:03:48 +01:00
2017-08-24 13:23:03 -07:00
2017-11-27 16:19:56 -05:00
2018-01-25 14:10:39 -08:00
2017-08-07 17:22:14 +02:00
2017-11-13 01:41:20 +01:00
2017-11-15 18:21:06 -08:00
2018-01-17 11:30:16 +00:00
2017-11-15 18:21:05 -08:00
2017-12-29 21:13:04 +01:00
2017-11-15 18:21:01 -08:00
2017-11-17 16:10:04 -08:00
2017-10-12 15:41:05 +02:00
2017-11-15 18:21:01 -08:00
2017-12-01 13:09:40 -08:00
2017-10-19 10:08:56 +02:00
2017-10-07 10:45:02 -06:00
2017-08-28 20:51:22 +02:00
2017-11-15 18:21:04 -08:00
2017-11-27 16:19:52 -05:00
2017-11-17 16:10:00 -08:00
2017-10-20 09:37:32 +02:00
2017-12-14 16:00:49 -08:00
2017-11-15 18:21:03 -08:00
2017-11-15 18:21:06 -08:00
2017-11-09 10:23:28 +01:00
2017-08-06 20:55:29 -07:00
2017-11-17 16:10:04 -08:00
2017-11-17 16:10:04 -08:00
2017-11-13 01:33:48 +01:00
2017-12-16 02:05:48 +01:00
2017-11-27 16:19:55 -05:00
2017-11-07 12:22:21 +01:00
2017-11-27 16:19:55 -05:00
2017-08-16 16:28:47 -07:00
2017-11-15 18:21:01 -08:00
2017-11-15 18:21:06 -08:00
2017-11-15 18:21:01 -08:00
2018-01-18 11:56:49 +01:00
2018-01-15 09:35:45 +01:00
2017-10-11 22:36:54 -04:00
2017-10-04 10:29:22 +02:00
2017-11-27 16:19:54 -05:00
2017-08-15 09:02:07 -07:00
2017-08-15 09:02:08 -07:00