leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
1,042,671 Commits 2 Branches 0 Tags
44df58d441a94de40d52fca67dc60790daee4266
Commit Graph

958 Commits

Author SHA1 Message Date
Aldas Taraškevičius
4adb389e08 staging: vt6655: Remove filenames in files 
Fix checkpatch warnings about having filenames in the files.

Signed-off-by: Aldas Taraškevičius <aldas60@gmail.com>
Link: https://lore.kernel.org/r/20210828072119.1395-1-aldas60@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2021-08-28 09:45:10 +02:00
Greg Kroah-Hartman
ece42658c8 staging: vt665X: remove unused CONFIG_PATH 
The vt6655 and vt6656 drivers have an unused CONFIG_PATH define floating
around in the code, but it is never used.  Remove it as drivers should
never be reading from config files anyway, even if these were valid
files.

Reported-by: Joe Perches <joe@perches.com>
Reported-by: Randy Dunlap <rdunlap@infradead.org>
Acked-by: Randy Dunlap <rdunlap@infradead.org>
Link: https://lore.kernel.org/r/20210729095812.1693061-1-gregkh@linuxfoundation.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2021-07-30 10:20:53 +02:00
Lucas Henneman
050cbd980e staging: vt6655: remove filename from upc.h 
This patch resolves checkpatch's warning, "It's generally not useful to
have the filename in the file" for upc.h.

Signed-off-by: Lucas Henneman <lucas.henneman@linaro.org>
Link: https://lore.kernel.org/r/20210723144340.15787-15-lucas.henneman@linaro.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2021-07-27 15:22:15 +02:00
Lucas Henneman
ed0b62a568 staging: vt6655: remove filename from mac.h 
This patch resolves checkpatch's warning, "It's generally not useful to
have the filename in the file" for mac.c.

Signed-off-by: Lucas Henneman <lucas.henneman@linaro.org>
Link: https://lore.kernel.org/r/20210723144340.15787-14-lucas.henneman@linaro.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2021-07-27 15:22:15 +02:00
Lucas Henneman
290262b919 staging: vt6655: kernel style cleanup of mac.c 
This patch removes from mac.c the file name and an ftrace-like pr_debug
per checkpatch's two warnings.

Signed-off-by: Lucas Henneman <lucas.henneman@linaro.org>
Link: https://lore.kernel.org/r/20210723144340.15787-13-lucas.henneman@linaro.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2021-07-27 15:22:15 +02:00
Lucas Henneman
56bfb9bc6c staging: vt6655: remove filename from key.h 
This patch resolves checkpatch's warning, "It's generally not useful to
have the filename in the file" for key.h.

Signed-off-by: Lucas Henneman <lucas.henneman@linaro.org>
Link: https://lore.kernel.org/r/20210723144340.15787-12-lucas.henneman@linaro.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2021-07-27 15:22:15 +02:00
Lucas Henneman
692b3e44b7 staging: vt6655: remove filename from key.c 
This patch resolves checkpatch's warning, "It's generally not useful to
have the filename in the file" for key.c.

Signed-off-by: Lucas Henneman <lucas.henneman@linaro.org>
Link: https://lore.kernel.org/r/20210723144340.15787-11-lucas.henneman@linaro.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2021-07-27 15:22:15 +02:00
Lucas Henneman
82bcc3174a staging: vt6655: remove filename from dpc.h 
This patch resolves checkpatch's warning, "It's generally not useful to
have the filename in the file" for dpc.h.

Signed-off-by: Lucas Henneman <lucas.henneman@linaro.org>
Link: https://lore.kernel.org/r/20210723144340.15787-10-lucas.henneman@linaro.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2021-07-27 15:22:15 +02:00
Lucas Henneman
eee245f5d7 staging: vt6655: remove filename from dpc.c 
This patch resolves checkpatch's warning, "It's generally not useful to
have the filename in the file" for dpc.c.

Signed-off-by: Lucas Henneman <lucas.henneman@linaro.org>
Link: https://lore.kernel.org/r/20210723144340.15787-9-lucas.henneman@linaro.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2021-07-27 15:22:15 +02:00
Lucas Henneman
0e9e3f6170 staging: vt6655: remove filename from device_main.c 
This patch resolves checkpatch's warning, "It's generally not useful to
have the filename in the file" for device_main.c.

Signed-off-by: Lucas Henneman <lucas.henneman@linaro.org>
Link: https://lore.kernel.org/r/20210723144340.15787-8-lucas.henneman@linaro.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2021-07-27 15:22:15 +02:00
Lucas Henneman
f0d52cd214 staging: vt6655: remove filename from device_cfg.h 
This patch resolves checkpatch's warning, "It's generally not useful to
have the filename in the file" for device_cfg.h, and adds an empty line
after the top description comment to match the style of the other vt6655
files.

Signed-off-by: Lucas Henneman <lucas.henneman@linaro.org>
Link: https://lore.kernel.org/r/20210723144340.15787-7-lucas.henneman@linaro.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2021-07-27 15:22:14 +02:00
Lucas Henneman
646ce5315f staging: vt6655: remove filename from channel.h 
This patch resolves checkpatch's warning, "It's generally not useful to
have the filename in the file" for channel.h.

Signed-off-by: Lucas Henneman <lucas.henneman@linaro.org>
Link: https://lore.kernel.org/r/20210723144340.15787-6-lucas.henneman@linaro.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2021-07-27 15:22:14 +02:00
Lucas Henneman
ec32e0776f staging: vt6655: remove filename from channel.c 
This patch resolves checkpatch's warning, "It's generally not useful to
have the filename in the file" for channel.c.

Signed-off-by: Lucas Henneman <lucas.henneman@linaro.org>
Link: https://lore.kernel.org/r/20210723144340.15787-5-lucas.henneman@linaro.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2021-07-27 15:22:14 +02:00
Lucas Henneman
065dddf31e staging: vt6655: remove filename from card.h 
This patch resolves checkpatch's warning, "It's generally not useful to
have the filename in the file" for card.h.

Signed-off-by: Lucas Henneman <lucas.henneman@linaro.org>
Link: https://lore.kernel.org/r/20210723144340.15787-4-lucas.henneman@linaro.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2021-07-27 15:22:14 +02:00
Lucas Henneman
51f42c7665 staging: vt6655: remove filename from card.c 
This patch resolves checkpatch's warning, "It's generally not useful to
have the filename in the file" for card.c.

Signed-off-by: Lucas Henneman <lucas.henneman@linaro.org>
Link: https://lore.kernel.org/r/20210723144340.15787-3-lucas.henneman@linaro.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2021-07-27 15:22:14 +02:00
Lucas Henneman
cae9546ac9 staging: vt6655: remove filename from baseband.c 
This patch resolves checkpatch's warning, "It's generally not useful to
have the filename in the file" for baseband.c.

Signed-off-by: Lucas Henneman <lucas.henneman@linaro.org>
Link: https://lore.kernel.org/r/20210723144340.15787-2-lucas.henneman@linaro.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2021-07-27 15:22:14 +02:00
Lucas Henneman
14127269cd staging: vt6655: remove filename from baseband.h 
This patch resolves checkpatch's warning, "It's generally not useful to
have the filename in the file" for baseband.h.

Signed-off-by: Lucas Henneman <lucas.henneman@linaro.org>
Link: https://lore.kernel.org/r/20210723144340.15787-1-lucas.henneman@linaro.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2021-07-27 15:22:14 +02:00
Lee Jones
b259c9b238 staging: vt6655: upc: Suppress set but not used warning in macro 
The variable is used in the function using the macro.

Fixes the following W=1 kernel build warning(s):

 drivers/staging/vt6655/upc.h:45:16: warning: variable ‘byData’ set but not used [-Wunused-but-set-variable]

Cc: Forest Bond <forest@alittletooquiet.net>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-staging@lists.linux.dev
Signed-off-by: Lee Jones <lee.jones@linaro.org>
Link: https://lore.kernel.org/r/20210414181129.1628598-28-lee.jones@linaro.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2021-05-10 11:19:25 +02:00
Greg Kroah-Hartman
c7f57fd6b7 Merge v5.12-rc4 into staging-next 
We want the staging/iio fixes in here as well.

Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2021-03-22 08:55:27 +01:00
Edmundo Carmona Antoranz
2cafd46a71 staging: vt665x: fix alignment constraints 
Removing 2 instances of alignment warnings

drivers/staging/vt6655/rxtx.h:153:1: warning: alignment 1 of ‘struct vnt_cts’ is less than 2 [-Wpacked-not-aligned]
drivers/staging/vt6655/rxtx.h:163:1: warning: alignment 1 of ‘struct vnt_cts_fb’ is less than 2 [-Wpacked-not-aligned]

The root cause seems to be that _because_ struct ieee80211_cts is marked as __aligned(2),
this requires any encapsulating struct to also have an alignment of 2.

Fixes: 2faf12c57e ("staging: vt665x: fix alignment constraints")
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Edmundo Carmona Antoranz <eantoranz@gmail.com>
Link: https://lore.kernel.org/r/20210316181736.2553318-1-eantoranz@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2021-03-18 10:21:46 +01:00
Madhumitha Prabakaran
754db907b2 staging: vt6655: Rename two dimensional array declaration 
Rename two dimensional array declaration to fix checkpatch warning: Avoid
Camelcase and make the declaration more readable and understandable

Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com>
Link: https://lore.kernel.org/r/20210315004641.378933-1-madhumithabiw@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2021-03-16 12:36:20 +01:00
Edmundo Carmona Antoranz
ebf4824798 staging: vt6655: remove duplicate code 
In the definition of vnt_init_bands(), there are two sections of
code that are very similar. Unifying them through a new
function that takes care of initialization of a single band.

Signed-off-by: Edmundo Carmona Antoranz <eantoranz@gmail.com>
Link: https://lore.kernel.org/r/20210314145943.1933245-3-eantoranz@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2021-03-14 17:01:46 +01:00
Edmundo Carmona Antoranz
c170f1687b staging: vt6655: correct documentation warnings 
Both arguments to set_channel have changed their names and their
types. Correct the discrepancy in the function documentation to get
rid of four warnings:

drivers/staging/vt6655/channel.c:165: warning: Function parameter or member 'priv' not described in 'set_channel'
drivers/staging/vt6655/channel.c:165: warning: Function parameter or member 'ch' not described in 'set_channel'
drivers/staging/vt6655/channel.c:165: warning: Excess function parameter 'pDeviceHandler' description in 'set_channel'
drivers/staging/vt6655/channel.c:165: warning: Excess function parameter 'uConnectionChannel' description in 'set_channel'

Signed-off-by: Edmundo Carmona Antoranz <eantoranz@gmail.com>
Link: https://lore.kernel.org/r/20210314145943.1933245-2-eantoranz@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2021-03-14 17:01:44 +01:00
Yujia Qiao
3b27f64672 Staging: vt6655: Replace a camel case variable name 
Replace camel case variable names with snake case in baseband.c.

Signed-off-by: Yujia Qiao <rapiz@foxmail.com>
Link: https://lore.kernel.org/r/tencent_21CFC58E6013D47A55691E4F4C6C4CF20706@qq.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2021-02-11 12:13:53 +01:00
Arnd Bergmann
2faf12c57e staging: vt665x: fix alignment constraints 
multiple structures contains a ieee80211_rts structure, which is required to
have at least two byte alignment, but are annotated with a __packed attribute
to force single-byte alignment:

staging/vt6656/rxtx.h:98:1: warning: alignment 1 of 'struct vnt_rts_g' is less than 2 [-Wpacked-not-aligned]
staging/vt6656/rxtx.h:106:1: warning: alignment 1 of 'struct vnt_rts_ab' is less than 2 [-Wpacked-not-aligned]
staging/vt6656/rxtx.h:116:1: warning: alignment 1 of 'struct vnt_cts' is less than 2 [-Wpacked-not-aligned]

I see no reason why the structure itself would be misaligned, and all members
have at least two-byte alignment within the structure, so use the same
constraint on the sturcture itself.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Link: https://lore.kernel.org/r/20210204162731.3132069-1-arnd@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2021-02-06 14:11:21 +01:00
Gustavo A. R. Silva
6a8ce97113 staging: vt6655: Fix fall-through warnings for Clang 
In preparation to enable -Wimplicit-fallthrough for Clang, fix multiple
warnings by explicitly adding multiple break statements instead of just
letting the code fall through to the next case.

Link: https://github.com/KSPP/linux/issues/115
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Link: https://lore.kernel.org/r/863fda60074850bc976974af48fa769c64725e64.1605896059.git.gustavoars@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2020-11-23 17:55:23 +01:00
Marcos Antonio de Jesus Filho
0d79a48440 staging: vt6655: Remove useless else 
The else statements are not useful due to the presence of a return
statement on the if block. Remove the else statements, adjust the
indentation of the code, move variable declarations to the beginning of
their scope and remove useless return statement. Reported by checkpatch.

Signed-off-by: Marcos Antonio de Jesus Filho <mdejesusfilho@gmail.com>
Link: https://lore.kernel.org/r/20201109025641.GA69196@Zangetsu
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2020-11-13 16:35:21 +01:00
Marcos Antonio de Jesus Filho
36f18e741a staging: vt6655: Fix typo 
Fix typo reported by checkpatch.

Signed-off-by: Marcos Antonio de Jesus Filho <mdejesusfilho@gmail.com>
Link: https://lore.kernel.org/r/20201026201714.GA24239@Zangetsu
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2020-10-27 12:23:44 +01:00
Deepak R Varma
2ed1fa08e6 staging: vt6655: rearrange lines exceeding 100 columns 
Rearrange lines that are longer than 100 columns in width. Issue reported
by chckpatch script. Also remove unnecessary pair of braces for single
line instruction post if condition.

Signed-off-by: Deepak R Varma <mh12gx2825@gmail.com>
Link: https://lore.kernel.org/r/20201016154423.GA17210@ubuntu204
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2020-10-26 06:53:10 +01:00
Sebastian Fuentes
9a9c1827e7 staging: vt6655: Add spaces around arithmetic operators 
This addresses the checkpatch.pl warning "spaces preferred around that
'+/-/*'"

Signed-off-by: Sebastian Fuentes <sefu1789@gmail.com>
Link: https://lore.kernel.org/r/20200912052357.GA4707@ubuntu
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2020-09-13 09:20:38 +02:00
Gustavo A. R. Silva
deb34767b2 staging: vt6655: Use fallthrough pseudo-keyword 
Replace the existing /* fall through */ comments and its variants with
the new pseudo-keyword macro fallthrough[1]. Also, remove unnecessary
fall-through markings when it is the case.

[1] https://www.kernel.org/doc/html/latest/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through

Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Link: https://lore.kernel.org/r/20200707194350.GA3255@embeddedor
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2020-07-10 13:52:46 +02:00
Vaibhav Gupta
7a46931ba9 staging: vt6655/device_main.c: use generic power management 
Drivers should not use legacy power management as they have to manage power
states and related operations, for the device, themselves. This driver was
handling them with the help of PCI helper functions like
pci_save/restore_state(), pci_enable/disable_device(), etc.

With generic PM, all essentials will be handled by the PCI core. Driver
needs to do only device-specific operations.

The driver was also using pci_enable_wake(...,..., 0) to disable wake. Use
device_wakeup_disable() instead.

Compile-tested only.

Signed-off-by: Vaibhav Gupta <vaibhavgupta40@gmail.com>
Link: https://lore.kernel.org/r/20200629082819.216405-5-vaibhavgupta40@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2020-07-01 15:39:21 +02:00
Rodolfo C. Villordo
79e88fd45b drivers: staging: vt6655: replace CamelCase names on function s_uGetRTSCTSRsvTime 
Replace function and variables name from CamelCase style to snake_case style.
Remove Hungarian notation.

Signed-off-by: Rodolfo C. Villordo <rodolfovillordo@gmail.com>
Link: https://lore.kernel.org/r/20200624100256.GA17118@ip-172-31-24-31.ec2.internal
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2020-06-25 15:40:27 +02:00
Matej Dujava
3abbab5132 staging: vt6656: vt6655: removing unused macros definition Makefiles 
This patch is removing definition of CFLAGS in Makefile of vt6656 and
vt6655, as those are defining macros that are not used. This will remove
undef of one macro from vt6655/device_main.c, as it is only undef and it is
not used anywhere else, so it is safe to remove it.

Macros are removed from vt665x/Makefile and vt6655/device_main.c.

Signed-off-by: Matej Dujava <mdujava@kocurkovo.cz>
Link: https://lore.kernel.org/r/1589397351-24655-2-git-send-email-mdujava@kocurkovo.cz
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2020-05-15 15:49:13 +02:00
Matej Dujava
0729bb9b2a staging: vt6655: fix LONG_LINE warning 
This patch will fix LONG_LINE error from checkpatch, by using ternary
operator.

Signed-off-by: Matej Dujava <mdujava@kocurkovo.cz>
Link: https://lore.kernel.org/r/1588520570-14388-3-git-send-email-mdujava@kocurkovo.cz
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2020-05-05 12:33:00 +02:00
Matej Dujava
3fc29573cf staging: vt6655: return early if not bNeedAck 
This patch will check for bNeedAck before making bb_get_frame_time call, so
in case we dont need uAckTime, we can return early.

Signed-off-by: Matej Dujava <mdujava@kocurkovo.cz>
Link: https://lore.kernel.org/r/1588520570-14388-2-git-send-email-mdujava@kocurkovo.cz
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2020-05-05 12:32:59 +02:00
Matej Dujava
e3b8577aa1 staging: vt6655: extract index manupulation out of function call 
This patch will remove if/else by selecting proper argument before
function call, also index is updated before function call.

Signed-off-by: Matej Dujava <mdujava@kocurkovo.cz>
Link: https://lore.kernel.org/r/1588512552-12297-6-git-send-email-mdujava@kocurkovo.cz
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2020-05-05 12:31:19 +02:00
Matej Dujava
ae25983134 staging: vt6655: return at the ond of case body 
This patch will unify exit point for s_uGetDataDuration function.

Signed-off-by: Matej Dujava <mdujava@kocurkovo.cz>
Link: https://lore.kernel.org/r/1588512552-12297-5-git-send-email-mdujava@kocurkovo.cz
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2020-05-05 12:31:19 +02:00
Matej Dujava
3be1acffe6 staging: vt6655: remove else after return and invert condition 
This patch will prepare us to make return at the end of case body

Signed-off-by: Matej Dujava <mdujava@kocurkovo.cz>
Link: https://lore.kernel.org/r/1588512552-12297-4-git-send-email-mdujava@kocurkovo.cz
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2020-05-05 12:31:19 +02:00
Matej Dujava
0ae73acc44 staging: vt6655: do calculation of uAckTime first 
This patch is extracting calculation of uAckTime in one place, at the
start of case body.

Signed-off-by: Matej Dujava <mdujava@kocurkovo.cz>
Link: https://lore.kernel.org/r/1588512552-12297-3-git-send-email-mdujava@kocurkovo.cz
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2020-05-05 12:31:18 +02:00
Matej Dujava
e4a34ef772 staging: vt6655: merge two switch cases in s_uGetDataDuration 
This patch will reuse code for two cases.

Signed-off-by: Matej Dujava <mdujava@kocurkovo.cz>
Link: https://lore.kernel.org/r/1588512552-12297-2-git-send-email-mdujava@kocurkovo.cz
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2020-05-05 12:31:18 +02:00
Briana Oursler
af93096eef Staging: vt6655: Replace camel case variable names. 
Replace camel case variable names with snake case in baseband.h and its
dependencies.

Signed-off-by: Briana Oursler <briana.oursler@gmail.com>
Reviewed-by: Stefano Brivio <sbrivio@redhat.com>
Link: https://lore.kernel.org/r/20200403171805.466600-1-briana.oursler@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2020-04-13 08:55:31 +02:00
Briana Oursler
3d7b79f2ee Staging: vt6655: Remove BBvExitDeepSleep definition. 
Remove function BBvExitDeepSleep that is never called.

Signed-off-by: Briana Oursler <briana.oursler@gmail.com>
Reviewed-by: Stefano Brivio <sbrivio@redhat.com>
Link: https://lore.kernel.org/r/027b00a27e2bef13c1daab3514dc7dc19fa1aa00.1585802818.git.briana.oursler@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2020-04-13 08:55:27 +02:00
Briana Oursler
3d1f39e962 Staging: vt6655: Remove CARDbRadioPowerOn definition. 
Remove function CARDbRadioPowerOn that is never called, along with
comments related to it.

Signed-off-by: Briana Oursler <briana.oursler@gmail.com>
Reviewed-by: Stefano Brivio <sbrivio@redhat.com>
Link: https://lore.kernel.org/r/e64c02aadd0b846604c755989b39f374161a87e0.1585802818.git.briana.oursler@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2020-04-13 08:55:27 +02:00
Briana Oursler
5ec64e91d3 Staging: vt6655: Remove CARDvSetLoopbackMode definition. 
Remove function CARDvSetLoopbackMode that is never called, along with
comments related to it.

Signed-off-by: Briana Oursler <briana.oursler@gmail.com>
Reviewed-by: Stefano Brivio <sbrivio@redhat.com>
Link: https://lore.kernel.org/r/b81f06ebc0179fbceb43c085411b372ff909b134.1585802818.git.briana.oursler@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2020-04-13 08:55:27 +02:00
Briana Oursler
1ad93e3166 Staging: vt6655: Remove CARDbSoftwareReset definition. 
Remove function CARDbSoftwareReset that is never called, along with
comments related to it.

Signed-off-by: Briana Oursler <briana.oursler@gmail.com>
Reviewed-by: Stefano Brivio <sbrivio@redhat.com>
Link: https://lore.kernel.org/r/8ec491439b947c959fab52e006d9ca26ec3657ab.1585802818.git.briana.oursler@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2020-04-13 08:55:27 +02:00
Briana Oursler
2f7ccc387c Staging: vt6655: Format long lines. 
Add whitespace around '-' operator and wrap long lines. Issue found by
checkpatch.pl.

Signed-off-by: Briana Oursler <briana.oursler@gmail.com>
Reviewed-by: Stefano Brivio <sbrivio@redhat.com>
Link: https://lore.kernel.org/r/e1c9fc822f1576f9896799fea6c467457cf0f6da.1585763457.git.briana.oursler@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2020-04-13 08:55:27 +02:00
Briana Oursler
b03ee7b2b8 Staging: vt6655: Eliminate nested if else 
Eliminate  nested if else statement, reduce code duplication, and
shorten long lines by creating a new variable, len, to determine
function input needed for s_uGetTxRsvTime.

Signed-off-by: Briana Oursler <briana.oursler@gmail.com>
Reviewed-by: Stefano Brivio <sbrivio@redhat.com>
Link: https://lore.kernel.org/r/301ff66e13e76be6416b5c0f8359249fa25f08e3.1585763457.git.briana.oursler@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2020-04-13 08:55:26 +02:00
Briana Oursler
e781fd1b33 Staging: vt6655: Move rate determination logic. 
Factor rate setting logic out of nested if-else statement to prevent
code duplication.

Signed-off-by: Briana Oursler <briana.oursler@gmail.com>
Reviewed-by: Stefano Brivio <sbrivio@redhat.com>
Link: https://lore.kernel.org/r/ba87af8a2d28d5737c6d8888bbda143aad723d2c.1585763457.git.briana.oursler@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2020-04-13 08:55:26 +02:00
Briana Oursler
5b0578364f Staging: vt6655: Limit return statements. 
Limit return statements within context of switch case to improve
readability.

Signed-off-by: Briana Oursler <briana.oursler@gmail.com>
Reviewed-by: Stefano Brivio <sbrivio@redhat.com>
Link: https://lore.kernel.org/r/fe417533b66d29ef6ea19128b38b8c8de7757ae2.1585763457.git.briana.oursler@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 2020-04-13 08:55:26 +02:00